[01:14] andyrock, I was able to reproduce the lock screen/keyboard layout bug. It's not 100% consistent, but I did get it to trigger two of out 5 times. [01:33] I take it the EOL scripts haven't been run as I'm finding a lot of really old bugs.. === hikiko-lpt is now known as hikiko [05:14] hello [05:30] Good morning [06:14] hello! [06:23] bonjour didrocks ! [06:23] ça va pitti ? [06:24] didrocks: ça va bien, et toi ? Dieu merci c'est vendredi :-) [06:24] pitti: en effet, c'est vendredi ! Moi, je suis encore malade [06:24] pitti: j'ai le nez bien bouché et je me sens comme dans du coton [06:25] (oreilles bouchées, cerveau moyennement actif…) [06:25] didrocks: hm -- replace work chair with a hot bath? [06:26] pitti: would love to, however, yesterday evening, I was given some snappy stuff to do before this afternoon… [06:26] pitti: manager's preparation for next week… [06:26] oh noes [06:27] good morning desktopers [06:27] bonjour seb128 ! [06:27] hey didrocks pitti [06:27] pitti, wie gehts? [06:27] re seb128! [06:30] seb128: prima, danke! [06:30] seb128: as-tu encore reçu le stollen ? [06:30] pitti, non, pas encore [06:33] Hey desktoppers. :) Heading off for the weekend, and indeed for a week off. You see you folks in a week or so. :) [06:33] * TheMuso -> EOD [06:33] hey TheMuso, enjoy your w.e! [06:34] enjoy your week off TheMuso! [06:34] and your holidays as well [06:34] good morning! [06:34] bye TheMuso :) [06:35] great morning larsu [06:36] salut didrocks [06:36] ça va? [06:36] hey larsu [06:36] larsu: bof, toujours malade… [06:36] didrocks: ugh, sorry to hear :/ [06:37] seb128: hola! que tal? [06:37] larsu, prima, danke! [06:38] good afternoon [06:40] hey FJKong [06:40] hi FJKong [06:40] just as a note, I'm going to be offline in the afternoon [06:40] Friday \o/ [06:40] travelling, so working a bit offline and going to catch up a bit after arriving [06:40] seb128: larsu hey~ [06:41] afternoon FJKong [06:41] seb128: safe driving! [06:41] didrocks, thanks :-) [06:41] it seems that I need to learn more about golang if we work on snappy. [06:41] right/ [06:42] s/\/? [06:44] FJKong, not everybody is going to work on snappy [06:44] but you can have a look to go if you want, doesn't hurt [06:45] just look at some demo apps, I find most of them are written with golang [07:52] good morning you fine fellows [07:53] hello willcooke [07:53] morning hikiko. That bug from yesterday, I can't reproduce it, so I dont know why I marked it as rls-w-incoming [07:53] you can close if you want [07:54] thanks willcooke :) [07:54] hey willcooke hikiko [07:55] morning seb128 [07:55] morning all [07:55] g'day larsu [07:56] this is n²... [07:56] at least it comes in waves :) [07:58] I prefer to think of it as The Waltons effect [07:58] heh [08:00] http://www.ubuntu.com/usn/usn-2743-3/ [08:00] seb128, did you see that ^^ ? [08:01] hi seb128 larsu et al [08:01] willcooke, saw now, "fun" [08:03] yo [08:03] hey Laney [08:04] good morning willcooke, hikiko, Laney! [08:05] 3 in a row \o/ [08:05] hi didrocks :) [08:07] Laney, seems like we got adwaita-icon-theme-full on the iso, unsure if that's wanted? [08:07] (I guess not, otherwise the split becomes useless?) [08:07] yes [08:08] you looking at it? [08:11] not yeah, I don't have it installed on my desktop, so probably a recommends somewhere [08:11] need to download a daily iso I guess ;-) [08:11] hi Laney :) [08:11] pesky recommend! [08:12] *recommends [08:12] hey larsu and didrocks and seb128 btw :) [08:12] seb128: I would usually check http://people.canonical.com/~ubuntu-archive/germinate-output/ubuntu.wily/all first [08:12] (probably don't open that in your browser) [08:12] (firefox...) [08:13] btw, if anyone wants to debug the media keys not working, I'm again in a session with that state [08:13] as yesterday [08:13] as the day before… [08:13] and such :p [08:13] hey didrocks, how are you feeling today? [08:13] Trevinho: once you are here, I thought you were looking into this race? ^ [08:14] willcooke: worse than yesterday, speaking heavily from the nose… [08:14] :( [08:14] (add that to a French accent :p) [08:14] ;) [08:14] lol [08:14] * larsu hugs didrocks [08:14] * didrocks hugs larsu back (IRC germ firewall FTW \o/) [08:16] larsu, Laney, do we want gnome-themes-standard on the iso? [08:16] it's what pulls in adwaita-icon-theme-full [08:17] why is that there? [08:17] seb128: I thought this was not needed anymore?! [08:18] maybe it has the gtk2 theme? [08:18] calm [08:47] hi [08:47] didrocks: media keys... [08:47] mh [08:48] Trevinho: media and shorcuts [08:48] like ctrl+alt+t, and such [08:48] yeah, the code is the same [08:48] remember, we talked about a race that started to happen last cycle if I'm right? [08:48] yeah [08:48] I don't remember we did... But might be :) [08:48] so, I'm in that state currently (happened quite more recently than before) [08:49] last cycle the API changed, but I never got issues because of tat [08:49] that* [08:49] like once every 4 login [08:49] willcooke experienced it for sure [08:49] * willcooke me toos [08:49] didrocks: when it happens have you tried to give dbus-monitor a check? [08:49] Trevinho: what do you want me to monitor in particular? [08:49] heh, dbus monitor is broken, right larsu :) [08:50] well, see what's dispatched and how [08:50] well, mh it's on interface org.gnome.Shell [08:51] signal AcceleratorActivated [08:51] * didrocks stops the workrave [08:51] ok, let's see [08:51] because workrave is spamming dbus [08:51] but... well, that might not work if it has not been registered [08:51] Trevinho: ok, signal is sent [08:51] didrocks: ahhh... actually better, maybe trying to initctl restart unity-settings-daemon? [08:51] http://paste.ubuntu.com/12552555/ [08:51] for instance [08:51] no, dono't do that then [08:52] Trevinho: killing unity-settings-daemon doesn't work normally [08:52] So.... registration of keybindings on startup is done, so unity is aware and it does the right thing... [08:52] now, I guess it's still u-s-s that should receive the AcceleratorActivated signal and do what expected [08:52] attente: is this right, correct? [08:53] he's probably sleeping [08:53] I don't remember what it spawing those, I think you are right, it's u-s-s [08:53] u-s-d* [08:54] yaeah, ...-d :P [08:55] I can see the MediaKeys interface on the bus [08:55] org.gnome.SettingsDaemon.Keyboard [08:55] yeah people, don't use dbus-monitor with a destination match [08:55] it's broken [08:56] `busctl --match destination=...` works [08:56] or dbus-monitor and ... err .... grep [08:56] (bug is filed) [08:56] destination=(null destination) [08:56] is that supposed to be the case? [08:56] (it's what we have for a broadcast, I guess?) [08:58] didrocks: sorry, I meant when you give a specific destination [08:58] like, dbus-monitor destination=org.freedesktop.Notifications [08:58] you will *not* see bus traffic to notification daemon [08:58] larsu: but those media keys don't have any destination in the normal case, right (do you mind checking by giving it a try?) [08:58] it works if you leave off the destination match, or use busctl [08:59] didrocks: in a 1:1 right now. Is there a bug I can get the summary from? [08:59] as you are in a working state, and I hope to keep my broken state to debug it [08:59] willcooke opened one, let me check if I can find it [09:01] bug #1482181 [09:01] bug 1482181 in unity-settings-daemon (Ubuntu) "Media keys (ctrl-alt-t, brightness, play/pause) don't work randomly after logging" [Undecided,Triaged] https://launchpad.net/bugs/1482181 [09:01] ah *this* problem [09:01] I've had this [09:01] didrocks: please STAY in the broken state. I'll be with you in a few minutes [09:02] thx! [09:02] * didrocks commented [09:02] and stay broken [09:02] (broken and sick, nice Friday! :p) [09:04] didrocks: :1.28 is u-s-d? (busctl status --user :1.28) [09:05] larsu: no, it's compiz [09:06] it's the compiz gnome plugin IIRC which handles the keys [09:06] (as we have some special build process for that) [09:06] so compiz gets the press event, and broadcast it correctly [09:07] then, the other side (which should listen on that iface and launch the corresponding app) doesn't work [09:07] I wonder if that couldn't be a side effect of the "listen to a signal, and then read the key" [09:07] (in gsettings) [09:07] on the receiver side [09:08] gsettings shouldn't be involved here [09:08] sorry, I meant the glib signal change [09:09] but yeah [09:09] sorry ECONFUSED ;) [09:09] so we don't use u-s-d media keys plugin? [09:10] not for listening in the unity settings, no [09:10] (we never had since unity) [09:10] it's the compiz-gnome plugin [09:11] media keys plugin is active though.. [09:11] yeah, unsure why… [09:12] maybe these two step on each other's feet? [09:12] * willcooke fires up his test laptop [09:12] let me check the bus traffic [09:12] (working for me right now [09:12] ) [09:12] yeah [09:13] so, what is the listening interface on the other side to receive the signal and spawn a process? [09:13] sounds like compiz, not that the interface is GnomeShell? [09:13] wow, 10 messages for one key [09:13] oh, with returns [09:13] I only have one? [09:14] yeah, just one here [09:14] and no returns :p [09:14] didrocks: the gnome shell interface is exposed by unity [09:14] so it's back on Trevinho's plate? :) [09:14] larsu: yeah, that's what I'm seeing from the .service file [09:14] didrocks: you should at least also get messages to notify-osd and "backlight-changed" or similar [09:15] larsu: no, nothing, (and of course, no notify-osd) [09:15] this is because it's broken, right? [09:15] yep [09:16] holy shit whatever is sending the notify thing is asking the daemon about it's capabilities all the time [09:17] *sigh* [09:17] larsu: just in case, "did you change yet?" :p [09:17] haha [09:18] Laney, wallpaper judging has begun.... [09:18] so, if I use a Method like UngrabAccelerator(0), I get a return value [09:18] good! [09:18] there is clearly something listening on the other side [09:18] but not at signals on that iface? [09:18] desktoppers: Take a look at the wallpaper entries... https://www.flickr.com/groups/ubuntu-fcs-1510/pool/ [09:19] larsu: so, seems like to be in Unity code? [09:19] didrocks: you see the signal though, right? [09:19] just not the "result" [09:19] why would unity send itself a signal via dbus, I wonder [09:19] larsu: yeah, I have the signal, but no response [09:20] larsu: because it's 2 different plugins handling it? :p [09:20] hah === hikiko-lpt is now known as hikiko [09:21] hm, unity-settings-daemon is talking to itself [09:21] seb128: did you look at it or should I? [09:22] it seems that GnomeGrabber::Impl::activateAction isn't called for whatever reason [09:22] seb128: seems either metacity or gnome-themes-standard or both could fix this [09:22] larsu: I guess it's where we are blocking on Trevinho to have a look now [09:24] sorry, brb [09:26] Laney, I didn't, sorry, busy with something else and travelling this afternoon, feel free if you want [09:26] thx [09:26] otherwise it's likely going to be on monday for me [09:26] np [09:27] thanks [09:29] larsu, didrocks, just for info https://code.launchpad.net/~attente/unity/gnome-key-grabber was the changeset to use those interfaces [09:29] it might make easier to see the code impacted from the diff of the feature landing [09:30] but basically unity should do the grabbing and dbus message u-s-d which does the actions [09:36] https://code.launchpad.net/~hikiko/compiz/compiz.fix-811591/+merge/272359 Trevinho could you approve this? (it's a bug from ages sam proposed that solution that works for me but it was never added to ubuntu) [09:36] or andyrock ^ [09:36] * hikiko gets rid of bugs :p [09:37] * Trevinho on it [09:38] mh hikiko don't comment code, or if you do add some explaination please. However, I'd just go by dropping those lines. In case bzr annotate or log will help to understand what changed [09:38] ok :) [09:39] sec [09:39] seb128: thanks! [09:40] didrocks: you're getting the signal, so I'm guessing the problem is in settings-daemon [09:40] which actually has two plugins talking to themselves on the bus :/ [09:41] Trevinho, fixed [09:41] hi u-s-d, how are you? [09:42] find u-s-d, and you? [09:42] fine* [09:42] great thanks u-s-d! [09:42] didrocks, larsu, isn't media-key what has the handlers for those dbus calls? [09:42] what is the second plugin? [09:43] seb128: the media key plugin calls the org.gnome.SettingsDaemon.Power.Screen.GetPercentage [09:43] and then .StepUp [09:43] but all of this doesn't seem to be happening for didrocks [09:44] why does it call that? [09:44] to chnage brightness (the media key I pressed) [09:44] for volume, I guess it calls pulse directly? [09:45] oh, I see [09:46] ok, good desktop people I need to drop offline, going for lunch and then travelling [09:46] I'm going to work a bit offline and should be back betwee 17-18 [09:46] hehe enjoy! [09:46] see you later or have a good w.e for those who call it a day by then [09:47] thanks! [09:47] you too! [09:47] cya seb128 [09:47] didrocks: can you paste the output of `busctl --user call org.freedesktop.DBus /org/freedesktop/DBus org.freedesktop.DBus.Debug.Stats GetAllMatchRules` please [09:53] larsu: sorry, in a HO [09:53] just read last line but: http://paste.ubuntu.com/12552889/ [09:56] didrocks: no worries, that was the only interesting one [10:05] larsu: ok, can focus more on this, and opened to any experience that doesn't include physical danger :p [10:09] didrocks: ha ok [10:09] so, you have the match rule [10:10] currently going through u-s-d code to see what could go wrong [10:10] larsu: but it's not u-s-d which spawn the process, it's only handling the notification communication? [10:10] meaning, we would have: [10:10] compiz-gnome -> send signal [10:10] 1. u-s-d grab it and send notification [10:11] 2. unity grabs it and launch the corresponding action/process [10:11] ? [10:11] (like for ctrl+alt+t, launch the terminal) [10:11] right, unity grabs some keys [10:11] but volume and brightness are handled directly [10:11] they all don't work for you, right? [10:11] yeah, all [10:12] so media keys are per see, and other command shorcuts [10:12] let me try to see if I see different traffic for ctrl+alt+t [10:12] argh,and of course, I tried ctrl+alt+t to have a terminal to monitor the traffic… [10:13] try volume [10:13] ok, same with ctrl+alt+t, just getting the broadcast signal [10:13] or brightness [10:13] volume is what I tried in my previous paste [10:13] ok, then unity is not involved at all [10:13] so, same, just getting broadcast signal in both case [10:13] yeah, can be dbus not delivering to any of them? [10:14] hm? [10:14] someone has the match rule, so it should arrive [10:14] and that someone is most likely u-s-d [10:14] shouldn't we have 2 then? [10:14] (matching) [10:14] u-s-d for media keys [10:14] unity for shorcuts [10:15] does unity also listen on the gnome shell interface? [10:15] and then, they filter and only care about some part of the answer [10:15] unity *is* the gnome shell interface [10:15] I hope they simply handle Ctrl+Alt+T internally?! [10:15] well, if this was internally handled, it would work, right? [10:15] seems like it's using the exact same pipe [10:15] indeed [10:17] maybe u-s-d handles all of those? [10:18] larsu: maybe (as it's working for you), set some new env variable to u-s-d [10:18] then ctrl+alt+t [10:18] and see if the terminal gets them? [10:18] that would tell us if it's unity or u-s-d spawning the app? [10:20] Trevinho: maybe you know this workflow, what is supposed to launch a terminal for instance on ctrl+alt+t, is it unity? [10:21] or does compiz-gnome just grab the keys, and forward them to the gnomeshell iface? [10:21] didrocks: unity only grabs the keys, the it's up to u-s-d to launch [10:21] right [10:21] ok, so at least, none of them working makes sense [10:22] so, the issue is in u-s-d [10:22] thanks Trevinho [10:23] didrocks: gsettings reset org.gnome.settings-daemon.plugins.media-keys terminal [10:23] does this make the terminal key work? [10:24] * didrocks tries [10:24] larsu: nope [10:25] the value didn't change (I did a get before), and still the default: 't' [10:25] ah [10:25] try changing it to something [10:25] ok [10:25] larsu: yeah, after changing, it works [10:25] resetting though, doesn't [10:26] FUCK [10:26] ok [10:26] but resetting after changing keeps it working, right? [10:26] nope [10:26] oh? [10:26] I resetted it (and so 't' again) [10:26] and it doesn't work [10:26] but if yo set it to something else it does? [10:27] Weird [10:27] yep, I tried Alt + t [10:27] want me to try with the volume keys? [10:27] to confirm this [10:28] yes please [10:28] same [10:28] so setting it to Alt +t, I can increase the volume [10:28] gsettings reset it [10:28] should be the same changed signal [10:28] and then, the media key doesn't work [10:28] this is awesome :) [10:28] isn't it? :p [10:28] lovely [10:28] let me dbus-monitor this [10:29] to ensure that it's still unity grabbing the key in the second case [10:29] (when setting it to something else) [10:31] so: http://paste.ubuntu.com/12553084/ [10:31] and then, getting all the dbus spam with notification, panel service… [10:31] * didrocks looks for the send id [10:32] interesting btw [10:32] the old key still send a signal [10:32] using dbus-monitor --session "interface='org.gnome.Shell'" does help in filtering? [10:33] can be, but I see enough here [10:33] sender=:1.28 in both case [10:33] still weird that the previous old volume up key send the signal [10:33] so something is wrong unity-side for sure already [10:33] oh [10:33] the first arg has different values [10:34] are you sure? You always get ths signal, regardless of whether the key works, right? [10:34] yeah [10:34] action id maybe is not well defined [10:34] so, I changed to Alt+t, right? [10:34] for volume up [10:34] and then: [10:35] http://paste.ubuntu.com/12553099/ [10:35] the first value of that signal is the keycode pressed (the values are different) right? it's not a "capability index" like volume up or such? [10:35] no, it's the accel id [10:36] so, it should be the same between the 2 calls? [10:36] or at least, it's unique for "volume up"? [10:36] no, u-s-d gets a new one from GrabAccelerator() every time it does a grab [10:36] ok [10:36] if I understand this correctly [10:37] basically it works like this: u-s-d asks unity to grab "Alt+T" and gets an id [10:37] and the unity sends signals with that id - so that u-s-d knows which accel was hit [10:37] that's why you thought reset would work, right? like reasking to regrab "volume up" [10:37] yes [10:37] and the bug would have been u-s-d starting before unity [10:37] indeed [10:38] but since it stops working again when you regrab the old key, this doesn't seem to be the case [10:38] yeah… [10:38] but we're onto something [10:38] try this: [10:38] dbus-monitor interface=org.gnome.Shell [10:39] gsettings set org.gnome.settings-daemon.plugins.media-keys terminal "t" [10:39] gsettings reset org.gnome.settings-daemon.plugins.media-keys terminal [10:39] gsettings set org.gnome.settings-daemon.plugins.media-keys terminal "t" [10:39] in between, hit Alt+T and Ctrl+Alt+T [10:39] and send the log of the monitor [10:39] k [10:39] thanks for being so patient! [10:40] no worry, I'm eager to see it fixed, this waited for too long :) [10:43] larsu: here we go, with annotation: http://paste.ubuntu.com/12553139/ [10:43] you're the best! [10:43] * didrocks hugs larsu [10:43] so, the weird thing [10:44] UngrabAccelerator [10:44] the id isn't the one for Primary alt T [10:44] yeah [10:44] looks like it's getting confused?! [10:44] yeah [10:44] if I keep pressing it [10:45] resetting* [10:45] I always have a GrabAccelerator -> id 3 [10:45] but an ungrab id incrementing [10:45] uint32 736 [10:45] uint32 737 [10:45] … [10:45] (and I just gsettings reset in loop, didn't set it anything else in between) [10:46] but also Activated() doesn't send the right accel id [10:46] yep [10:46] so that's *clearly* wrong [10:47] indeed [10:47] and that explains why unity doesn't ungrab [10:47] unless...... there's an old grab that u-s-d forgot to ungrab [10:47] and unity only sends signals for one grab [10:47] this interface is the biggest shit I've ever seen [10:47] so many problems [10:47] larsu: I'm sure you can always find worse! :) [10:47] lol [10:48] it should work like this: hey unity, I'm interested in these 10 keys! [10:48] ah, remapping rather than incremental? [10:48] ok :1.xyz, I'll send signals for these keys until you die [10:48] or tell me a new set of keys [10:48] yeah [10:49] it needs to check lifetime anyway, in case it crashes [10:49] so ungrab() is completely useless [10:49] indeed [10:49] and apparently causing the problems here [10:49] I don't have any crash of u-s-d, in case this would have been the issue… [10:50] like asked for grabbing, crashing and using weird id [10:50] that's… weird [10:50] so: here is another try: [10:51] no I think it doesn't crash but gets the ungrabbing wrong [10:51] http://paste.ubuntu.com/12553213/ [10:52] so, the id for alt + T which is grabbed when pressed is different from the one set? (always 3) [10:52] oh wait, 3 is input, not return [10:53] ah yeah, it's a flag [10:54] didrocks: sorry I have a lunch date with systemd hackers now. I think I have enough information to figure this out now [10:54] didrocks: thanks a lot again. I might have more questions in an hour or two [10:55] larsu: no worry, keeping it broken for the day. Thanks for looking at it! [10:55] enjoy your lunch :) [10:56] man, this totally works for me thougj [10:56] I bet it gets confused at startup for you [10:56] and then stays in some weird state [10:56] didrocks: thanks! Eating bulgarian [10:56] sounds nice! :) [10:56] larsu: yeah, I think there is something at startup and that's why it's lost then *forever* [10:57] indeed === alan_g is now known as alan_g|lunch [11:15] desktoppers: https://goo.gl/jqRgRC [11:16] cute! [11:16] nice [11:17] Dual landing, then! :( [11:17] :) ^ [11:17] ahah [11:21] :D [11:28] good morning [11:28] hey attente! [11:29] hi didrocks! [11:34] o/ attente [11:35] o/ === hikiko is now known as hikiko|ln [11:48] good morning! [11:51] hey andyrock === hikiko|ln is now known as hikiko === alan_g|lunch is now known as alan_g [12:58] didrocks: so, I was looking further... And I noticed that the gnomecompat plugin in compiz is still enabled (actually we should remove it from our list nowadays), and that it tries to grab Ctrl+Alt+t... So maybe disabling that plugin (or keybinding) should explain why the activated signal is emitted anyway when chaning setting [13:00] Trevinho: can be, yeah [13:00] Oh, well no... Actually it shouldn't be there /usr/share/session-migration/scripts/00_remove_gnomecompat_in_unity_session.py [13:00] (as per this, but maybe it doesn't work?) [13:00] * Trevinho tries a clean session [13:00] it's not enable here [13:00] enabled* [13:00] ah, ok fine [13:01] so no troubles from that... It's all in unity [13:01] but I don't see unity behave badly... I mean, it should do what expected. [13:01] yeah, it seems to be more on the u-s-d side maybe [13:01] or unity doesn't ungrab the first key [13:03] didrocks: if you've installed libxpathselect, you might be able to try to run these AP test autopilot/unity/tests/test_gnome_key_grabber.py [13:03] they play with the interface... [13:04] So you might check if ungrabbing happens also [13:05] willcooke: congrats!! :D [13:05] thanks andyrock :) [13:22] tjaalton: ping [13:22] didrocks: oh... Actually I was looking at the ungrab code... And well it's probably not working well [13:23] didrocks: did you try to manually call the UngrabAccelerator command with a valid id and see what's returning? [13:23] if it's false, as I believe it might do, then... we're into problems [13:28] good morning [13:29] hey qengho [13:35] Trevinho: well, unity does some things wrong [13:36] for example, it sends the AccelaratorActivated signal to everyone [13:36] even though only one process can know about the id [13:36] * larsu wonders if gnome shell gets this right [13:38] ah, seems to [13:38] larsu: well, that's right... But since the ID is generated with methods, others shouldn't listen that [13:38] however, i was mostly concerned by this didn't work, but it actualyl does http://pastebin.ubuntu.com/12554355/ [13:39] well, others get woken up [13:39] and then ignore the message because it doesn't have an id they know about [13:40] could set up a match rule with arg0 set to the id [13:40] ... for every key [13:40] man this interface is dumb [13:41] we should emit the id to the register only, true... To do that we should change our glib::DBusObject too, but feasible [13:54] sorry guys, still on a HO [14:01] larsu: Trevinho: do you want still me to try to manually call the ungrabAccel (I'm unsure about the first key id which was set though) [14:04] didrocks: well, in theory it's the same id you get when you use the key and unity emits the signal [14:04] Trevinho: oh sure, let me try [14:05] ok, called ungrabbed [14:05] returned true [14:05] pressing and working now [14:05] with another id [14:05] so, yeah, the key is registered twice [14:05] and unity only send the first one [14:06] so, this starts to make sense [14:06] larsu: Trevinho ^ [14:06] to sum up: [14:06] -> key id was 33 [14:06] I ungrabbed(33) [14:06] press again [14:06] and now, it's 720 [14:06] and the notification popups and such [14:06] Ok, makes sense... So we need to ensure that an action is just registered once [14:06] yep [14:07] as it will stop at the first match I guess [14:07] and no register again if someone tries to do that [14:07] but then, it means there is one case where it registers twice [14:07] without ungrabbing? [14:07] unless there's an ungrab (best if from the same who asked to grab, but I wouldn't do that for avoiding trobules :P) [14:07] (for all keys, with some racy start condition?) [14:07] yeah [14:07] ungrab is always called before grabbin? [14:08] grabbing* [14:08] * didrocks looks [14:08] at least, seems so from the logs [14:08] so it's supposed to work [14:08] larsu: do you want me also to emit the signal only to the one who registered the grab? Although, if u-s-s crashes, we need to re-register every keybinding... it seems too much noise, considering that security isn't there ayway [14:08] (your strategy to not reregister) [14:09] good call on the crash case, you will need to track and reregister [14:09] where broadcast only enable you to "not care" [14:10] * Trevinho takes the occasion to semplify this stuff [14:11] Trevinho: ok, confirmed with another key where I didn't do any reset/set [14:11] and of course, the id is way smaller (89) [14:11] doesn't fix the real bug where is this something registering twice at startup though [14:12] but weird, especially with no u-s-d crash [14:13] didrocks, so we have got to the bottom of the issue then? [14:15] willcooke: well, we know how it happens, Trevinho is working on a fix (I guess?), we don't know exactly why it goes to that state sometimes though [14:16] oki, progress though, thanks all [14:16] yeah, at least, this should be fixed from an user perspective :) [14:16] yeah, working on that [14:16] Trevinho: hm? You need to watch the service anyway to unregister the ids (in case it crashes) [14:17] would be good to understand exactly why this happens, as this kinds of things are always stricking back in a worse case [14:18] larsu: yes, that's true... But I don't think it's something done right now... I was doing that, anyways... [14:18] larsu: i guess that's the reason why we didn't replace actions before [14:20] actions? [14:21] I mean keybindings... The problem was that we were just adding new keys ignoring the old ones [14:21] right, that's the problem didrocks is seeing? [14:21] so, when restarting usd, we were just adding the same keybindings twice [14:22] yeah... To reproduce just do something like [14:22] gdbus call --session --dest org.gnome.Shell --object-path /org/gnome/Shell --method org.gnome.Shell.GrabAccelerator "x" 0 [14:22] twice or more... [14:22] We don't return false [14:22] indeed [14:23] so this is the issue? [14:23] didrocks' u-s-d crashes [14:23] once on startup? [14:23] * larsu checks [14:23] no, it adds twice the same shortcuts.. [14:23] well, it adds them again when restarting [14:24] so only the first id is used by ucc, but unity sends the last registered one [14:24] and unity doesn't delete the old ones [14:24] oh [14:24] Well, that wouldn't be an issue, as restarting adds new ones... [14:24] it only registers them once for me [14:24] Trevinho: except for the obvious memory leak ;) [14:25] here's what I get http://pastebin.ubuntu.com/12554875/ [14:25] larsu: I don't have anything in /var/crash [14:25] as told [14:25] yeah, I just think that for some reason you get the method called twice [14:25] yep [14:25] and without ungrab in the middle [14:26] Trevinho: I don't see it twice in didrocks' logs [14:26] didrocks: for double checking, you might set UNITY_TEST_LOG_SEVERITY="error;unity.key.gnome.grabber=debug" for your session and see if you get anything relevant [14:26] larsu: I guess it happens on startup.. [14:26] err, sorry wrong env name [14:27] Trevinho: well, it's not a one 100% startup case, but yeah, I can do that for future logins [14:27] didrocks: it's UNITY_LOG_SEVERITY="error;unity.key.gnome.grabber=debug" for your session and see if you get anything relevant [14:27] didrocks: yeah, I know, but you might try to relogin tons of times :) [14:28] Trevinho: unsure about now, I have quite some stuff opened and working on, but yeah, adding for later :) [14:28] didrocks: sure, no worries [14:28] * Trevinho has an uptime of weeks generally, so... I also never leave my session :) [14:30] larsu: so, let's say I press volume down, I see the "32" key id being fired [14:30] larsu: then, I ungrab(32) [14:30] larsu: I press again, and I get another event with key id 89, everything now works [14:30] larsu: so, there are been at some point, 2 grab() calls without ungrab [14:31] and unity only send the first match [14:31] where u-s-d expects the second [14:31] ya [14:31] (which is, I guess for it, the only valid one) [14:31] crashing u-s-d is enough to trigger this for me [14:31] I guess for the same reason [14:31] the weird part is u-s-d didn't crash for me [14:31] Trevinho: you need to watch the name and remove all grabs when it disappears [14:32] s/you/unity :P [14:32] didrocks: thank! [14:32] so, there is a case where 2 grabs are called, without ungrab in between [14:32] yw! [14:32] right [14:32] which is the case when it crashes [14:32] larsu: I do expect Trevinho to look at every laptop and watch for the grabs :) [14:32] yep [14:32] haha [14:33] Trevinho: do you want to fix it or should we make a better API? [14:33] * larsu wonders what else is using this [14:35] larsu: well, as you prefer... I was about to use this API as it was the same gnome uses, but we can also make a new one [14:35] larsu: what would you prefer? I'd say the new one, right? [14:35] Trevinho: do you know if anyone else is using this interface? [14:36] larsu: I was about asking you the same :) [14:36] because if you need to implement it anyways, we might as well keep it [14:36] larsu: well... let me see... We use it for menus I believe, but not sure if it's unity module or we do in unity (/me checks) [14:36] well… we need something for wily though [14:37] and I don't think you want to introduce the new API now :p [14:37] yes! [14:37] no, we do that internally for menus, so I don't think anyone would use [14:37] well... private stuff... :P [14:37] didrocks, yes, as in, no - no you dont [14:37] Ok, I'm reusing the old one.... [14:37] good point [14:38] still, behavior change and such, you can still do a bandaid for now [14:38] and nothing prevents to work on the new API now :) [14:38] but first bandaid I would say ;) [14:39] * Trevinho hates bandaids... [14:39] but yeah... [14:39] well, as everything, it's a risk/benefit assement :) [14:40] larsu: let's decide it now though... as actually I'd avoid to do things twice and probably it's not the best thing to rewrite this in u-s-d and unity. Considering we can rewrite just one side [14:40] ya [14:40] (keeping u-s-d even closer to upstream) [14:43] ok, so nothing needed from me? [14:44] larsu: don't you think we should investigate why the grab can happen twice at some startup? [14:44] (and without an ungrab in between) [14:44] ah right you said it's not because it crashed [14:44] yeah… [14:44] that worries me [14:44] maybe we just get lucky most of the time and the last grab is what unity sees [14:44] but maybe sometimes… [14:45] and so, we would double grab for everyone at every login? [14:46] sigh [14:47] larsu: so, I just looks at /proc/pid/maps [14:47] larsu: it doesn't load (phew) the g-s-d media keys plugin [14:47] I wonder though why I have every plugin listed 4 times? [14:47] haha good idea [14:47] hm? in maps? [14:48] yep [14:48] even libwacom and such [14:48] that might be "normal", I would have expected to see it only once though [14:48] that's all libs though, not only the plugins [14:48] at least for me [14:48] yeah [14:48] sale [14:49] same* [14:49] ok, so "normal" [14:49] I guess it spawns multiple memory chunks [14:49] so, it's not the g-s-d plugin interfering, so, in the code itself… [14:49] kgunn: pong, EOW already, but if you have a bug just assign it to me :) [14:50] tjaalton: no worries, i'll just email you...oh, i'm assuming you're the person to talk to about mesa uploads ? [14:51] kgunn: yes, did 11.0.0 break something? [14:52] tjaalton: yep :) so just wanted to establish some kinda of communication/agreement between us [14:52] first point release will arrive today, i'll push it next week [14:52] ah [14:52] busted our mir ci jobs for wily [14:53] well the FFE was filed a month ago and raof tested it iirc [14:53] but i hear you [16:02] have a good week-end guys! === alan_g is now known as alan_g|EOW [17:11] bye! [17:12] gnight Laney [17:12] gnight all [18:11] Good weekend folks! [21:49] bye!