[00:26] <bluesabre> O.O
[08:02] <knome> pleia2, sorry, nope, was a long day
[08:03] <flocculant> morning knome :)
[08:03] <knome> hello flocculant 
[08:05] <knome> yep, other flavors didn't fancy drawing a "real" werewolf either: http://www.kubuntu.org/news/kubuntu-15-10-beta-2/
[08:06] <flocculant> ha ha 
[08:54] <dkessel> that's a nice half-werewolf :)
[08:54] <dkessel> good morning btw
[08:55] <flocculant> hey dkessel :)
[08:55] <dkessel> i just checked out the PDF version of the docs the first time. good work guys! i really like the layout and formatting
[08:58] <dkessel> oh, and russian and french could be included this cycle. i guess mentioning the 70% threshold helped motivate some people, slickymaster :)
[08:58] <dkessel> hey flocculant :)
[09:00] <knome> hey dkessel 
[09:01] <knome> dkessel, thanks for the feedback/praise! if you have any ideas on how to improve the PDF docs though... :)
[09:01] <dkessel> was that new release of xfdesktop included in wily? i only read about it, but could not test it at the time
[09:01] <knome> just let us know
[09:03] <dkessel> knome: huomenta! no, nothing to criticise at the moment :)
[09:03] <knome> ooh ooh
[09:03] <knome> ;)
[09:03] <knome> guten morgen
[10:28] <bluesabre> morning all
[10:29] <bluesabre> dkessel: yes, it made it in
[10:29] <bluesabre> knome: kubuntu
[10:29] <bluesabre> 's site is much cleaner than I remember
[10:30] <bluesabre> I guess we're not the only ones with a nice web designer on board
[10:31] <flocculant> hi bluesabre 
[10:31] <bluesabre> hi flocculant 
[10:32] <flocculant> you always turn up just as I'm off out :)
[10:33] <knome> bluesabre, they have recently updated the design
[10:34] <bluesabre> flocculant: :D
[10:34] <bluesabre> makes you wonder if I do it on purpose
[10:34] <bluesabre> >.>
[10:35] <knome> hah
[10:35] <knome> ok, time to go
[10:35] <knome> bbl
[10:36] <flocculant> bluesabre: I'm sure you do :D
[10:36] <bluesabre> bye knome
[10:57] <ochosi> hey bluesabre 
[11:03] <bluesabre> hey ochosi 
[11:04] <ochosi> how're things?
[11:06] <bluesabre> good good
[11:06] <bluesabre> getting ready to start working on something
[11:07] <ochosi> what did you think of extending xfpanel-switch?
[11:08] <bluesabre> well, I think that'd be better as xfce appearance settings
[11:08] <bluesabre> since it's basically a reimplementation of themes, which gnome used to do
[11:10] <ochosi> that'd also be an option, yeah
[11:11] <ochosi> my main concern with xfpanel-switch is the lack of checking whether the needed extensions/plugins are installed
[11:11] <ochosi> that'd be high up on my wishlist for 2.0
[11:11] <bluesabre> yeah
[11:12] <ochosi> not sure what the easiest way of checking for plugins is though
[11:12] <bluesabre> oh, I just remembered, can you upstream the xfce4-panel integration code so we can get some translations for "Backup and restore"
[11:12] <ochosi> ah right
[11:12] <bluesabre> :D
[11:12] <ochosi> yeah, that sounds like a good thing to do
[11:13] <ochosi> guess i should add that as a workitem for myself
[11:13] <ochosi> not sure though whether to target w or x
[11:14] <ochosi> andrzejr: hey! we discussed this previously, but are you ok with me upstreaming our xfce4-panel patch to display a "backup and restore" button in the panel config if xfpanel-switch is installed?
[11:14] <bluesabre> we have until october 8th for non-translation pack translations
[11:14] <bluesabre> brb
[11:14] <ochosi> right, i guess i'll try to get this done asap then
[11:15] <ochosi> anyway, added the workitem
[11:23] <bluesabre> :)
[11:53] <andrzejr> ochosi, sure. Can you do that or do you need my help?
[13:09] <bluesabre> andrzejr: I think ochosi is an admin, should have push rights for everything
[13:25] <ochosi> andrzejr: yeah, i'll take care of it either tonight or tomorrow
[13:25] <ochosi> bluesabre: wanna pull those translations in as a patch then too or shall we do a translation release of the panel?
[13:30] <ochosi> andrzejr: humm, shall i push that to the 4.12 branch or master..?
[13:31] <ochosi> 4.12 sorta feels wrong since it's a new feature, even if it's a small one
[13:32] <ochosi> it's a bit confusing that the branch for 4.12 was created later then the release. anyhow, i see there are a few more fixes, i guess we could do a 4.12.1 bugfix/translations release after a bit
[13:36] <ochosi> bluesabre: humm, wasn't there some additional stuff you did because the settings ui was precompiled into the code or something..? (i've prepped the patch locally on top of master already now, so basically just need to push the button)
[13:46] <ochosi> gotta run now, i can push this anytime later
[13:49] <bluesabre> ochosi: yeah, since we don't run --enable-maintainer-mode in the package build process, I had to dump it into the precomiled _ui.h file
[20:15] <ochosi> bluesabre: i guess working on that appearance thing you mentioned would be for xfce 4.16, we should really focus on making it gtk3 first
[20:36] <bluesabre> ochosi: yeah, I think I'd agree with that
[20:36] <bluesabre> maybe even 4.14
[20:36] <bluesabre> 1 new dialog might be easier than 2-3 converted dialogs
[20:36] <ochosi> right
[20:36] <ochosi> potentially, but the code for that 1 dialog would have to be written first
[20:37] <bluesabre> well, its already mostly there
[20:37] <ochosi> right
[20:37] <ochosi> btw i have another hour or so, if you feel like hacking on something
[20:37] <bluesabre> and we'd probably just borrow most of it from mate :D
[20:37] <ochosi> also, i'm still waiting for gitolite to update my perms, seems i've never pushed to the panel repo myself...
[20:38] <bluesabre> gotcha
[20:40] <bluesabre> ochosi: ever work on thunar?
[20:40] <ochosi> not much
[20:40] <ochosi> only added that progressbar feature to the props dialog
[20:40] <ochosi> and i read parts of the code, but yeah, that's a huge codebase
[20:41] <bluesabre> fun
[20:42] <ochosi> why? planning on working on that?
[20:42] <bluesabre> https://bugs.launchpad.net/ubuntu/+source/gvfs/+bug/1497175
[20:42] <bluesabre> the mate folks found a fix for caja, might also apply for thunar
[20:43] <ochosi> right, better to ask harald or peter to take a look
[20:44] <bluesabre> I'll probably see if I can find the relevant code myself
[20:44] <bluesabre> the issue affects me as well, so will be easy to test
[20:44] <ochosi> right
[20:44] <ochosi> that's good
[20:47] <bluesabre> ochosi: so, this seems pretty minor... do we particularly want it for 15.10? https://github.com/shimmerproject/Greybird/pull/105
[20:48] <ochosi> it's just an improvement for the compact theme, it's not particularly important to push it in
[20:48] <ochosi> from my pov we can focus on bugfixes for 15.10 and ... well 16.04 :>
[20:48] <bluesabre> cool
[20:49] <ochosi> it's more important to ship the a11y theme than that
[20:50] <bluesabre> and we did get that one out for b2
[20:52] <bluesabre> looks like the mate fix might be relevant
[20:52] <bluesabre> $ grep -rn "trash::"
[20:52] <bluesabre> thunarx/thunarx-file-info.h:48:  "trash::*," \
[20:52] <bluesabre> ChangeLog:19372:    Make restore from trash work again. Add trash::* to default attributes.
[20:52] <bluesabre> ChangeLog:19376:    to read trash::orig-file but it's actually trash::orig-path. Last but
[20:53] <ochosi> thunar_application_restore_files was where i was heading
[20:54] <ochosi> but i haven't looked at mate's fix yet
[20:55] <bluesabre> https://github.com/mate-desktop/caja/pull/459/files
[20:57] <ochosi> yup, already looking at that ;)
[20:59] <ochosi> so a workaround in thunar-file.c?
[20:59] <ochosi> hah
[20:59] <ochosi> that part already uses what is patched in caja
[21:00] <ochosi> at least these parts: https://github.com/mate-desktop/caja/commit/bc11ee765a8334020f02fd7802d6eb5802b80c33
[21:01] <ochosi> so not sure what to do about this
[21:01] <bluesabre> ah
[21:01] <bluesabre> hm
[21:02] <ochosi> are we sure they were experiencing the same issue?
[21:02]  * ochosi starts reading the bugrepoprt
[21:02] <ochosi> i'd rather look for the bug in xfdesktop not trashing files correctly
[21:03] <bluesabre> "Open wastebasket - right click on deleted file - select restore"
[21:03] <bluesabre> sounds like thunar to me
[21:03] <ochosi> also because it has been confirmed with another file manager
[21:04] <ochosi> so you can confirm that from places other than the desktop?
[21:04] <ochosi> cause it works fine for me within thunar
[21:04] <bluesabre> yup
[21:04] <bluesabre> create it in home, delete it, try to restore it, fails
[21:04] <ochosi> delete file from home folder > restore > restored
[21:04] <bluesabre> wily?
[21:04] <ochosi> nope
[21:04] <ochosi> 15.10
[21:05] <bluesabre> so, wily?
[21:05] <ochosi> err
[21:05] <ochosi> sry
[21:05] <bluesabre> :D
[21:05] <ochosi> i meant to write:
[21:05] <ochosi> well, you know what i meant to write...
[21:05] <bluesabre> !15.10
[21:05] <bluesabre> woops factoid
[21:05] <ochosi> so if it works in vivid, i'd say it's not a thunar bug for sure
[21:05] <bluesabre> well, its a change in gvfs most likely
[21:05] <ochosi> and adding workarounds in it sounds fugly
[21:06] <bluesabre> and thunar needs patched to support new gvfs
[21:06] <ochosi> aha
[21:06] <ochosi> wasn't aware of gvfs breakage
[21:06] <ochosi> api break?
[21:07] <bluesabre> probably, or just doing something for years because it worked, even though gvfs did something years ago
[21:08] <ochosi> hm, well as i said, to me it looks like we're already doing what fixed it for caja
[21:10] <bluesabre> could be we need to add to the namespace in thunarx/thunarx-file-info.h:39
[21:11] <ochosi> add what?
[21:11] <ochosi> it's already trash::*
[21:12] <ochosi> and caja actually took out the trash-namespace references and replaced them with g_file references
[21:12] <ochosi> (or maybe i misunderstand this all, after all it's late over here :))
[21:13] <ochosi> plus are you sure this is the same issue?
[21:13] <bluesabre> http://git.xfce.org/xfce/thunar/commit/?id=0164cdb934fb1c46a8d77dda6a6799f377b73fc3
[21:14] <bluesabre> when changing it way back then, he also added the properties to thunarx-file-info.h
[21:14] <bluesabre> could be the missing piece
[21:14] <bluesabre> I'll hack on it a bit and see if I make an progress
[21:14] <ochosi> right
[21:14] <ochosi> i still dont really get it
[21:15] <bluesabre> me neither
[21:15] <bluesabre> but if the patch works, yay
[21:15] <ochosi> cause the relevant portion in thunar_file_get_original_path has been updated already
[21:15] <bluesabre> right
[21:16] <ochosi> so i wouldn't know what to patch
[21:16] <ochosi> back then it used the trash:orig-path reference
[21:16] <ochosi> but it doesn't anymore
[21:16] <bluesabre> right
[21:16] <bluesabre> now it uses the constants
[21:16] <ochosi> yeah
[21:16] <ochosi> like caja
[21:16] <bluesabre> but the constants are not in that fix
[21:16] <bluesabre> *file
[21:17] <ochosi> you mean they have to be defined?
[21:17] <bluesabre> nvm
[21:17] <bluesabre> I'm confusing
[21:17] <bluesabre> :D
[21:17] <ochosi> :)
[21:17] <ochosi> the constands come from gvfs, no?
[21:17] <ochosi> constants
[21:17] <bluesabre> yes
[21:18] <ochosi> anyhoo, you lost me there - i'm still not sure what you're trying to patch :)
[21:19] <bluesabre> :D
[21:20] <bluesabre> http://paste.ubuntu.com/12584084/
[21:20] <bluesabre> if it works
[21:20] <bluesabre> testing now
[21:21] <ochosi> woot, that is strange if you ask me
[21:31] <ochosi> still compiling?
[21:33] <bluesabre> annnnnnnd
[21:33] <bluesabre> didn't work
[21:33] <ochosi> i'd love to say i'm surprised...
[21:33] <bluesabre> :D
[21:34] <bluesabre> suppose I'll see if there is an upstream bug or not, then poke folks
[21:35] <ochosi> i'm really surprised if this bug also appears in nautilus tbh
[21:35] <ochosi> s/i'm/i'd be/
[21:35] <SwissBot> ochosi meant: "i'd be really surprised if this bug also appears in nautilus tbh"
[21:36] <ochosi> thanks SwissBot, good boy.
[21:36] <bluesabre> :D
[21:39] <ochosi> that's why i thought xfdesktop might be at the bottom of this
[21:39] <ochosi> (you know, as in: below all other windows)
[21:40] <bluesabre> ugh
[21:40] <bluesabre> nautilus removed single file restore
[21:41] <bluesabre> ochosi: yeah, but the delete and restore both take place in thunar
[21:41] <ochosi> how... user-friendly
[21:41] <bluesabre> in my test at least
[21:41] <bluesabre> ochosi: removed everything from my trash
[21:41] <bluesabre> also affects nautilus it seems
[21:42] <ochosi> humm, in v it also works from the desktop
[21:42] <bluesabre> I'll go ahead and tag thunar and nautilus as affected
[21:42] <ochosi> yup
[21:47] <bluesabre> https://bugs.launchpad.net/ubuntu/+source/gvfs/+bug/1497175
[21:47] <bluesabre> tagged both
[21:48] <ochosi> good
[21:48] <ochosi> at least it's not just our problem
[21:48] <ochosi> i wonder though whether this is even reproducible upstream
[21:50] <bluesabre> potentially
[21:50] <bluesabre> now we can watch if a patch comes in for gvfs or nautilus
[21:51] <ochosi> sounds like a fun activity ;)
[21:53] <bluesabre> :D