davecheneyanastasiamac: i cannot test on windows00:04
davecheneyi dn't have a windows machine00:04
davecheneybut I fixed the error reported by CI00:05
davecheneywhich was the sole remaining use og version.Current.OS00:05
anastasiamacdavecheney: did u have a chance to look at this? is this worth a try? http://wiki.cloudbase.it/juju-testing00:09
* thumper wanders off to find some lunch00:10
davecheneyi'm fine with letting CI test this00:13
davecheneyif there is a problem, reverting it is a quick process00:13
axwwallyworld: I'm going to be out tonight, so won't be able to make the retro sorry00:49
wallyworldaxw: sure, np00:49
axwwallyworld: also I'm not working today, in case you'd forgotten00:49
wallyworldyou have a holiday anyway00:49
anastasiamacaxw: why r on irc?00:50
anastasiamacaxw: u*00:50
axwwallyworld: summary: I spent most of last week working on various bugs, and trying to come up with a demo for storage for seattle (no fruit yet). blocked on azure because no SDK updates yet00:50
axwanastasiamac: just to rub it in that I have a holiday ;)00:50
anastasiamacaxw: oh yes - thank you - appreaciated :D00:51
wallyworldthumper: you don't need +1 for backport, you can just land that can't you00:59
thumperwallyworld: no, but I was really wanting some form of confirmation00:59
thumperbut I may just merge it00:59
wallyworldi can look if yiu want01:00
wallyworldthumper: lgtm, seems to be an extra unrelated test from the cherry pick that came across, doesn't matter01:05
mupBug #1500283 opened: apiserver: data race in machinePinger.Stop <juju-core:New> <https://launchpad.net/bugs/1500283>01:31
mupBug #1500283 changed: apiserver: data race in machinePinger.Stop <juju-core:New> <https://launchpad.net/bugs/1500283>01:52
mupBug #1500283 opened: apiserver: data race in machinePinger.Stop <juju-core:New> <https://launchpad.net/bugs/1500283>01:55
perrito666for those of you who are in the wrong side of the world02:25
perrito666sorry for the quality my lens is not the best there is02:25
anastasiamacperrito666: nice picture :P02:29
anastasiamacperrito666: but everyone who is on the "wrong side of the world" is now asleep :P02:30
perrito666anastasiamac: lol02:30
perrito666its noon for you02:30
anastasiamac:P yes just passed02:36
davecheney^ quite urgent02:46
anastasiamacdavecheney: wrong channel... re-posting here02:48
anastasiamac<anastasiamac> ok.. m pleading my ignorance... why changing from bool will fix a race? :D02:48
davecheneywe need to use atomic operations so the change to the value is visible across threads02:49
davecheneyand there is no atomic.LoadBool() in 1.2.1, so this is the closes02:50
davecheneyand there is no atomic.LoadBool() in 1.2.1, so this is the closest02:50
anastasiamacdavecheney: ah!02:50
anastasiamacdavecheney: is it possible to add this info to codebase and/or PR?02:51
davecheneysure, i'll amend the description02:57
wallyworlddavecheney: just saw this branch in when i pulled master "bugger-off-version-binary-os". that is awesome, most aussie branch name ever03:02
davecheneywallyworld: :)03:08
mupBug #1465873 changed: Environment.Users does not take into consideration the current environment <juju-core:Fix Released by waigani> <https://launchpad.net/bugs/1465873>03:34
mupBug #1500298 opened: API message logging should have field blacklist <security> <tech-debt> <juju-core:Triaged> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1500298>04:14
mupBug #1500298 changed: API message logging should have field blacklist <security> <tech-debt> <juju-core:Triaged> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1500298>04:17
mupBug #1500298 opened: API message logging should have field blacklist <security> <tech-debt> <juju-core:Triaged> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1500298>04:20
mupBug #1500298 changed: API message logging should have field blacklist <security> <tech-debt> <juju-core:Triaged> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1500298>04:23
mupBug #1500298 opened: API message logging should have field blacklist <security> <tech-debt> <juju-core:Triaged> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1500298>04:32
wallyworldrogpeppe: heyya, can i get a review of a small charm.v6-unstable pr when you have time? https://github.com/juju/charm/pull/15407:40
wallyworldrogpeppe: also, i've made a charmrepo.v2, since i also need to change other methods besides just adding a new interface. i'll push a deps update once the above pr lands, plus there's also a failing test that slipped through onto gh07:41
urulamawallyworld: morning, he'll be here in a "few minutes"07:44
urulamawallyworld: still a bit early for UK :)07:44
wallyworldurulama: no worries :-)07:44
urulamawallyworld: and welcome back, hope you had a great time off07:44
wallyworldurulama: yeah, had a wedding to go to, was good07:44
voidspacefrobware: I saw the updated 1:1 time by the way08:01
voidspacefrobware: fine08:01
frobwarevoidspace, great. sorry for the short notice. :)08:02
wallyworldurulama: with mongo, do you know a way to detect if javascript is enabled via the session or some such? i have a bunch of charmrepo tests failing because i'm using juju-mongo without javascript engine. i can add a skip for those tests where mongo doesn't support javascript08:02
urulamawallyworld: hm, isn't there "isJavascriptEnabled" or something like that?08:03
urulamawallyworld: i can take a look, but after the call08:03
rogpeppewallyworld: have you actually found some instances of old charms that have a series field in?08:04
wallyworldnot sure, hence the question, but i'll go searching for a func name like that. ty08:04
wallyworldrogpeppe: in a gz file08:04
wallyworldwhich contained bundles08:04
wallyworldrogpeppe: it has Series: ""08:04
wallyworldso it needs to be handled08:04
rogpeppewallyworld: hmm, bummer08:05
rogpeppewallyworld: um, what's a charm metadata file doing in json format anyway?08:06
wallyworldrogpeppe: nfi08:06
wallyworldrogpeppe: see allcharms.json.gz in the charmrepo08:06
rogpeppewallyworld: so not a charm in the charm store then?08:06
rogpeppewallyworld: i don't think you should take allcharms.json as representative08:08
rogpeppewallyworld: it was generated from actual charms that do not have series entries08:09
rogpeppewallyworld: for example, the first entry in that file is cs:precise/apache2-1208:09
wallyworldrogpeppe: sure, but legacy charms won't08:09
rogpeppewallyworld: but if you get that entry from the charm store, it doesn't have a series field in its metadata08:09
wallyworldrogpeppe: hmmm, ok. so an option is to change that json file then08:10
wallyworlddelete all the Series: ""08:11
wallyworldrogpeppe: although, the code is safe, i think it's best to be robust08:11
wallyworldread everything, write concisely08:11
wallyworldwho know what local charms people will have08:12
wallyworldi'd rather err on the side of caution08:12
rogpeppewallyworld: ok, i guess08:14
rogpeppewallyworld: but i'm not convinced about the approach in that PR08:14
rogpeppewallyworld: it means that the series will be lost when marshaling the metadata08:14
wallyworldlost how? it's converted to a slice08:15
wallyworldyes, but series as a string literal is deprecated08:15
wallyworlds/deprecated/strongly discouraged08:16
wallyworldi think we just need to handle reading older bundles08:17
rogpeppewallyworld: it'll be lost even if it's a slice, no?08:17
rogpeppewallyworld: anyway, i thought we were calling it SupportedSeries08:17
wallyworldrogpeppe: oh, hmmm. i think you're right. in which case it's kinda moot08:18
wallyworldrogpeppe: the spec says "series' thpugh08:19
wallyworldi guess we can change it08:19
wallyworldwill be a lot easier08:19
wallyworldrogpeppe: i think i'll just change the spec and ask for forgiveness, and can repropose this pr if needed if the spec has to be changed back08:20
rogpeppewallyworld: i think you can call the field SupportedSeries in the Meta type08:21
wallyworldand make the serialised field name "supported-series"08:21
rogpeppewallyworld: theoretically you can actually have two fields that both marshal to "series"08:22
rogpeppewallyworld: but actually better to use "supported-series" in the metadata08:22
rogpeppewallyworld: it's a good name anyway - it reflects what it does08:22
wallyworldrogpeppe: ok, i'll delete the current pr and repropose a charm.v6-unstable pr with SupportedSeries08:22
rogpeppewallyworld: thanks08:23
wallyworldrogpeppe: ty too. btw, do you know how to detect is mongo javascript is enavled? i have abunch of failing tests08:23
wallyworldbecause i have juju-mongodb without js08:23
rogpeppewallyworld: i don't think we can rely on mongo-with-js08:23
wallyworldand so charmrepo tests fail08:23
rogpeppewallyworld: because it's not supported on some architectures08:24
wallyworldrogpeppe: there's about 4 tests which check that stats are updated which fail without js08:24
rogpeppewallyworld: ah yes, charmstore uses mongojs08:24
wallyworldrogpeppe: yeah, so i'd like just to skip those tests if there's no js08:25
rogpeppewallyworld: perhaps just ignore those failures on your machine - CI will tell you if the tests really pass08:25
wallyworldoh, ok :-) but i was hoping for something nicer :-)08:25
rogpeppewallyworld: i'm sure it wouldn't be hard to work out08:26
rogpeppewallyworld: just execute some js and see what happens08:26
wallyworldrogpeppe: yeah i had a quick look but nothng jumped out, thought i'd ask just in case you knew off the top og your head08:26
wallyworldthere's an error just i can catch, but i'd rather detect it and skip08:27
wallyworldanyways, it's no biggie08:27
rogpeppewallyworld: you could use Database.Run to run http://docs.mongodb.org/manual/reference/command/eval/#dbcmd.eval08:29
rogpeppewallyworld: but eval is deprecated, so i don't know how long that'll carry on working08:29
wallyworldyeah, i saw that and came to the same conclusion08:29
urulamawallyworld: this might help you with JS https://github.com/juju/charmstore/blob/v5-unstable/internal/storetesting/flag.go08:36
wallyworldurulama: ty, will look after dinner08:37
wallyworldrogpeppe: quick one to rename series https://github.com/juju/charm/pull/15509:15
rogpeppewallyworld: so we want to support "supported-series: trusty" as well as "supported-series: [trusty]" ?09:17
wallyworldrogpeppe: ah, bollocks, will fix that, thanks. was rushing to get it done before dessert09:18
wallyworldi'll check that we just want []string09:18
rogpeppewallyworld: tbh i'm not sure that categories and tags work as intended in that respect09:19
* rogpeppe checks09:19
wallyworldrogpeppe: i just checked - actually, supported-series doesn't support string literals09:19
wallyworldit requires a list09:20
wallyworldso it's ok as is09:20
wallyworldwe now just ignore any series attribute09:20
wallyworldas it is meaningless09:20
rogpeppewallyworld: you're right - i misread parseStringList09:20
rogpeppewallyworld: sorry for false alarm :)09:20
wallyworldnp :-)09:21
wallyworldi didn't change parseStringList I don't think09:21
wallyworldrogpeppe: thanks, after dinner, i'll propose that tweak to charmrepo to make the tests happy09:23
rogpeppewallyworld: no, i thought that parseStringList accepted a single string09:24
rogpeppewallyworld: i'd be interested to know what API-breaking changes you were thinking of for charmrepo, BTW09:24
rogpeppewallyworld: BTW, $$merge$$ works on the charm repository09:25
wallyworldrogpeppe: InferRepository() returns Interface09:25
rogpeppewallyworld: so better to use that than the big green button :)09:25
wallyworldrogpeppe: oh sorry, i thought there was no bot09:25
rogpeppewallyworld: it's relatively recent. no worries.09:25
wallyworldrogpeppe: so even if I use a new SupportedSeries interface, that method wil need to change also09:26
wallyworldgotta run, dibber, bbiab09:26
rogpeppewallyworld: enjoy09:26
wallyworldrogpeppe: sorry, last one for a bit, it's small https://github.com/juju/charmrepo/pull/3009:56
wallyworldrogpeppe: wtf, tests pass for me but github says checks fail due to a charmstore.v5 build error10:00
wallyworldand i haven't updated charmstore.v5 dep for this pr10:01
dimiternfrobware, voidspace, dooferlad, TheMue, I'm back, we can start the planning HO10:07
frobwaredimitern, OK10:07
dooferladdimitern: on it10:07
frobwaredimitern, shall we use the link from friday's meeting?10:07
dimiternfrobware, sgtm10:08
* dimitern ah.. monday hangouts..10:09
rogpeppewallyworld: you haven't added charmrepo.v2 to the deps10:09
rogpeppewallyworld: oh, sorry my mistake10:10
rogpeppewallyworld: this is targetted at v2 of course10:10
wallyworldrogpeppe: it is. and with the flag stuff, uros pointed me at that code, it's straight from charmstore10:11
dimiternvoidspace, ping10:11
rogpeppewallyworld: in the charmstore, that code is in the storetesting package10:12
rogpeppewallyworld: which is there specifically for tests10:12
rogpeppewallyworld: we don't want to have that stuff in production code10:12
wallyworldok, i'll tweak it10:13
rogpeppewallyworld: thanks10:15
wallyworldrogpeppe: there's a testing package in the top level i'll mov eit top10:15
rogpeppewallyworld: i wonder whether you shouldn't just use jujutesting.MgoServer.WithoutV810:15
wallyworldcould do, i wonder why that other code doesn't do that10:16
rogpeppewallyworld: although... i'm not convinced by the heuristics for deciding whether the set that10:16
rogpeppewallyworld: are you using /usr/lib/juju/bin/mongod ?10:17
rogpeppewallyworld: in which case that'll probably do the trick10:17
rogpeppewallyworld: it certainly seems like the right place to look at10:17
wallyworldi'll try10:17
wallyworldrogpeppe: although for consistency, may be nice to use the same code10:18
rogpeppewallyworld: i'll suggest changing charmstore actually. and possibly changing juju/testing too.10:18
rogpeppewallyworld: ISTM there should be one canonical place for this info10:19
voidspacedimitern: omw, sorry10:21
wallyworldrogpeppe: just using that WithoutV8 flag seems to have worked10:22
rogpeppewallyworld: cool10:22
voidspacedimitern: need to do authentication dance, will take a minute10:22
voidspacedimitern: aaaand you're not in the standup hangout - got a link for me?10:24
wallyworldrogpeppe: so jenkins still fails, should i just try doing another PR to update charmstore.v5-unstablel to use charmrepo.v2?10:26
wallyworldcharmstore.v5 imports charmrepo.v110:26
wallyworldand the build of charmstore.v5 fails10:26
rogpeppewallyworld: if you run godeps -t ./... > dependencies.tsv, you'll probably end up with something that works10:28
rogpeppewallyworld: you'll still need charmrepo.v1 as a dependency, but that will be fixed in time10:28
wallyworldmakes sense, ta10:28
urulamawallyworld, rogpeppe: we don't have jenkins jobs picking up charmrepo.v2 or charmstore.v5, only charmstore.v1 and cs.v5-unstable10:28
urulamawallyworld, rogpeppe: if you're relying on our CI that is10:29
rogpeppeurulama: it looks like the bot is picking up that branch ok10:29
urulamait shouldn't :D10:29
rogpeppeurulama: although it's possible it's ignoring the target branch i guess10:29
rogpeppeurulama: well, it should really :)10:29
rogpeppeurulama: but it might be doing it erroneously10:30
urulamarogpeppe: ah, ok, the test bot, but the merge bot won't work10:30
rogpeppeurulama: ah, ok10:30
rogpeppeurulama: well, if the test bot says it passes, i don't mind clicking the big green button while we wait for CI to catch up10:31
rogpeppeurulama: i'm wondering if we should be using v2.unstable though10:31
urulamarogpeppe: v2-unstable would be following our protocol, yes10:31
wallyworldrogpeppe: that worked10:32
rogpeppewallyworld: given that we probably haven't finished making breaking changes to charmrepo, could you retarget at v2-unstable please?10:33
rogpeppewallyworld: cool10:33
wallyworldi'll merge this change first and then rename10:33
wallyworldrogpeppe: assuming you give it a +110:35
rogpeppewallyworld: i'd prefer not to create charmrepo.v210:35
rogpeppewallyworld: as it gives the impression that it's stable10:35
wallyworldok, i'll update now before landing10:35
wallyworldrogpeppe: ok, so v2-unstable created, and here's the new pr https://github.com/juju/charmrepo/pull/3111:06
rogpeppewallyworld: LGTM11:07
wallyworldrogpeppe: awesome, ty11:07
wallyworldnow i can start the Interface changes11:07
wallyworldrogpeppe: how long do i need to wait for the $$merge$$ on charmrepo to be picked up?11:18
rogpeppewallyworld: we use :shipit: instead11:19
wallyworldah, oops, ty11:19
rogpeppewallyworld: but it might not work, as i'm not sure the merge bot picks up merges for all targets11:19
rogpeppewallyworld: try it and see11:19
wallyworldi've tried it, let's see11:19
wallyworldand done11:23
voidspacefrobware: just realised I pick my daughter up from school at 3:15pm, can we move 1:1 to 4.00pm?11:47
frobwarevoidspace, done12:46
voidspacefrobware: thanks13:54
katcowwitzel3: ericsnow: let's just meet in moonstone for iteration planning13:54
wwitzel3katco: rgr13:54
sinzuimgz: can you review https://github.com/juju/juju/pull/338813:59
mgzsinzui: looking13:59
katconatefinch: we're meeting in moonstone for iteration planning13:59
wwitzel3katco: browser crashed, brb14:00
katcowwitzel3: no worries14:00
sinzuimgz: sorry http://reviews.vapour.ws/r/2771/14:00
mgzsinzui: lgtm14:04
sinzuithank you mgz14:04
mgzhm, I think I will install ntpd on reviews. my comment is now 8 minutes from now.14:05
sinzuimgz: yeah. I have installed ntpd on most of our machines because something eventually breaks when the instance lives more thsn a month14:06
frobwaredimitern, ping; do you have time for a quick HO regarding juju-br0?14:08
dimiternfrobware, sure14:08
frobwaredimitern, let's use the standup HO14:09
dimiternfrobware, ok, omw14:09
frobwarevoidspace, can we delay 15 mins?14:58
frobwarevoidspace, in a HO with dimitern and sean looking at the wily 4.2 bug14:59
voidspacefrobware: yup, np15:02
frobwarevoidspace, as we're making some progress any objections if we reschedule for tomorrow?15:19
voidspacefrobware: no problem15:21
voidspacefrobware: maybe give me a chance to get my branches landed by the time of the network call (maybe...)15:21
voidspacefrobware: good that you're making progress15:22
TheMuedimitern: Regarding constraints, is the section in the network model document still up-to-date?15:30
dimiternTheMue, it should be - which part specifically?15:38
TheMuedimitern: the meaning of the spaces constraint, to add it to the docs15:39
dimiternTheMue, that part hasn't changed15:39
dimiternTheMue, the format - comma-delimited list with ^ prefix for negatives15:40
TheMuedimitern: ok, thx. only wanted to get sure as we had some discussions in London15:40
rogpeppeanyone fancy a tiny review? https://github.com/juju/juju/pull/339015:41
dooferladfrobware, dimitern, TheMue: hangout16:01
mupBug #1499613 changed: Windows device path mismatch in volumeSuite.TestListVolumesStorageLocationBlockDevicePath <blocker> <ci> <regression> <test-failure> <unit-tests> <windows> <juju-core:Fix Released by cmars> <juju-core 1.25:Fix Released by cmars> <https://launchpad.net/bugs/1499613>16:03
dimiterndooferlad, we're still in a call, will join soon16:03
voidspacedimitern: frobware: eta?16:07
voidspacedimitern: frobware: jay is looking at Andrew's bug but we can't really help without him, and we don't have anything else to talk about16:08
voidspaceso maybe we defer to email for that bug16:08
mupBug #1499613 opened: Windows device path mismatch in volumeSuite.TestListVolumesStorageLocationBlockDevicePath <blocker> <ci> <regression> <test-failure> <unit-tests> <windows> <juju-core:Fix Released by cmars> <juju-core 1.25:Fix Released by cmars> <https://launchpad.net/bugs/1499613>16:09
voidspacedimitern: frobware: Jay has gone for breakfast :-)16:12
dimiternvoidspace, ah :/ too bad16:12
mupBug #1499613 changed: Windows device path mismatch in volumeSuite.TestListVolumesStorageLocationBlockDevicePath <blocker> <ci> <regression> <test-failure> <unit-tests> <windows> <juju-core:Fix Released by cmars> <juju-core 1.25:Fix Released by cmars> <https://launchpad.net/bugs/1499613>16:12
dimiternvoidspace, dooferlad, that 4.2 kernel bug seems like something is messed up with the hardware network stack - juju does what's expected16:12
voidspacedimitern: ah...16:13
dimiterni.e. ifdown eth1 looks like it worked,but the device is still up after that16:13
rogpeppehere's an incremental change to apiserver/common, converting a macaroon discharge-required error with ServerError: http://reviews.vapour.ws/r/2774/16:13
voidspacedimitern: Jay was very suspicious about the fact that it was receiving packets with itself as the source address16:13
dimiternvoidspace, yeah16:13
voidspacedimitern: he suspected a loop somewhere in the network stack16:13
dimiternvoidspace, it looks like it yeah16:13
dimiternfrobware, I think I'll call it a day and resume with the demo prep first time tomorrow morning16:17
frobwaredimitern, agreed. been in a meeting since 9am....16:18
katcoericsnow: wwitzel3: natefinch: be there in a sec17:17
katconatefinch: ready?17:21
natefinchkatco: sorry, my wife is late coming home from picking up Lily, so I still have two kids...17:30
katconatefinch: we're going to defer for half an hour; ericsnow is occupied until then anyway17:37
natefinchkatco: ok, great (sorta).17:37
voidspacefrobware: dooferlad: TheMue: if you have a chance: http://reviews.vapour.ws/r/2775/17:42
voidspacetasdomas: you're OCR I believe, so if you get a chance http://reviews.vapour.ws/r/2775/17:46
thumpermramm: ping?20:32
mupBug #1500613 opened: configstore should break fslock if time > few seconds <tech-debt> <juju-core:Triaged> <https://launchpad.net/bugs/1500613>21:04
mupBug #1500613 changed: configstore should break fslock if time > few seconds <tech-debt> <juju-core:Triaged> <https://launchpad.net/bugs/1500613>21:07
thumperdavechen1y: http://data.vapour.ws/juju-ci/products/version-3112/maas-1_8-deploy-trusty-amd64/build-884/machine-0.log.gz21:07
thumperdavechen1y: look at the panic there21:07
thumperpanic: cannot pass empty version to VersionSeries(), github.com/juju/utils/series/supportedseries.go:18521:08
thumperutils/series looks like your recent stuff21:08
thumperfound this looking through the CI failure on http://reports.vapour.ws/releases/3112/job/maas-1_8-deploy-trusty-amd64/attempt/88421:09
thumperwhich just failed on master21:09
mupBug #1500613 opened: configstore should break fslock if time > few seconds <tech-debt> <juju-core:Triaged> <https://launchpad.net/bugs/1500613>21:19
wallyworldaxw: perrito666: anastasiamac: i'm finishing another meeting, will be 10 mins or so late23:12
anastasiamacwallyworld: sure \o/23:15
anastasiamacJust noticed this in the build - + bzr whoami 'J. Random Hacker <jrandom@example.org>'23:19
anastasiamacvery funny23:19
perrito666Could any of you join the hangout? Trying my connection axw anastasiamac23:24
axwperrito666: coming23:24

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!