[00:25] <rick_h_> katco: pong
[01:45] <axw> let the merge wars commence
[01:46] <axw> thumper wallyworld waigani anastasiamac: if you have things waiting, master is got unblocked
[01:46] <wallyworld> \o/
[01:46] <axw> naturally I started mine merging before I told you
[01:46] <waigani> axw: lol, cheers
[01:53] <mup> Bug #1501381 changed: panic: cannot pass empty version to VersionSeries() <blocker> <ci> <intermittent-failure> <juju-core:Fix Released by cherylj> <https://launchpad.net/bugs/1501381>
[01:53] <mup> Bug #1501432 changed: BootstrapSuite tests fail on non-ubuntu platforms with no matching tools <blocker> <centos> <ci> <test-failure> <windows> <juju-core:Fix Released by cherylj> <https://launchpad.net/bugs/1501432>
[01:53] <mup> Bug #1501786 changed: juju cannot provision precise instances: need a repository as argument <blocker> <ci> <precise> <regression> <juju-core:Fix Released by cherylj> <https://launchpad.net/bugs/1501786>
[02:18] <rick_h_> perrito666: how big?
[02:19] <perrito666> rick_h_: something that can compile mongo in less than the time it takes for launchpad I am trying to fix the willy build of a mongo3 ppa and I dont have a willy nor intentions of breaking my laptop
[02:20] <rick_h_> perrito666: what's your LP id?
[02:20] <perrito666> rick_h_: hduran-8
[02:23] <rick_h_> perrito666: oh bah, it's in use.
[02:23] <perrito666> rick_h_: ??
[02:23] <rick_h_> perrito666: well you can ssh to maas.jujugui.org and create an lxc container on that laptop and use it if you'd like, though tit's not that fast
[02:24] <rick_h_> perrito666: I thought we had an unused node in our guimaas the team uses
[02:24] <perrito666> rick_h_: I appreciate it, ill ponder on it if I dont fall asleep on the kb before
[02:24] <rick_h_> perrito666: but looks like the team put it to use
[02:25] <rick_h_> perrito666: ok, well let me know. We've got hardware if it'll help. However you should be able to create a wily lxc and do the builds in there and keep the laptop safe
[02:26] <natefinch> lol compiling mongo is super slow...  it took forever even on my quad core i7 with a beastly SSD.  That's C++ for you.
[02:26] <rick_h_> perrito666: worst case can ask urulama to take over the QA environment for a bit and get full machines
[02:27] <natefinch> I think it took like 45 minutes on my laptop
[02:27] <rick_h_> natefinch: have a 6 core 32gb machine if the instructions are easy for me to dupe
[02:29] <natefinch> rick_h_: I haven't done it in like a year, but IIRC, the directions were terrible
[02:30] <rick_h_> natefinch: :/ well if it would help happy to try to get something better working. shoot, maybe just get a giant ec2 machine for a bit. but understand if it's just a pita
[02:31] <perrito666> it is sort of a pita, especially the one I am trying to build, which is a debian package
[02:31] <natefinch> rick_h_: it's a good lesson for why perrito666 shouldn't buy such namby pamby laptops
[02:32] <rick_h_> lol
[02:32] <rick_h_> laptops are for portability, many core desktops with lots of ram for real work :)
[02:32] <perrito666> natefinch: my laptop kicks ass, I just dont want to install willy on it
[02:32] <natefinch> haha
[02:32] <rick_h_> perrito666: but surely in an lxc it's safe?
[02:32] <perrito666> rick_h_: ill give it a shot, I hadn't thought of it
[02:32] <natefinch> perrito666: just giving you shit :)
[02:33] <perrito666> natefinch: so is mongo :p
[02:33] <perrito666> I really need to buy some heavy lifting machine I am just too lazy to import it
[02:33] <perrito666> and to cheap to pay local price for what I can get here
[02:33] <natefinch> perrito666: probably easier to just get us to stop using mongo
[02:35] <natefinch> perrito666: I saw our new competitor nomad uses boltdb... which blows mongo out of the water as far as compile time and ease of setup.  Of course, it doesn't have replication, so they must be doing that themselves somehow.. but still.. I love boltdb... pure Go, man.  That's the way to do it.
[03:18] <cmars> I like boltdb, i've used it in some side-projects and it's always been great to work with. I've never really pushed it in terms of concurrent txns though.
[07:11] <mup> Bug #1502016 opened: Juju-quickstart error message lacks detailed error info <canonical-bootstack> <juju-core:New> <https://launchpad.net/bugs/1502016>
[07:14] <mup> Bug #1502016 changed: Juju-quickstart error message lacks detailed error info <canonical-bootstack> <juju-core:New> <https://launchpad.net/bugs/1502016>
[07:17] <mup> Bug #1502016 opened: Juju-quickstart error message lacks detailed error info <canonical-bootstack> <juju-core:New> <https://launchpad.net/bugs/1502016>
[08:37] <TheMue> fwereade: Happy Birthday
[08:48] <dimitern> fwereade, oh wow, happy birthday indeed! :)
[08:50] <anastasiamac> fwereade: ¸¸♬·¯·♩¸¸♪·¯·♫¸¸Happy Birthday To You¸¸♬·¯·♩¸¸♪·¯·♫¸¸
[08:58] <fwereade> TheMue, dimitern, anastasiamac: <3
[08:59]  * fwereade is tired and is taking a pre-travel swap day to relax
[09:02] <voidspace> fwereade: hippy bathday fella
[09:02] <voidspace> fwereade: enjoy the rest and seattle
[09:02] <fwereade> voidspace, cheers :)
[09:21] <mfoord> frobware: dimitern: conflicts resolved and unit public address branch set to attempt to land on master (again...)
[09:21] <dimitern> mfoord, awesome!
[09:21] <mfoord> frobware: dimitern: ec2 subnets branch also landing on master
[09:21] <dimitern> mfoord,
[09:22] <dimitern> mfoord, and it did land on 1.25 alread?
[09:22] <mfoord> dimitern: yup, already landed there
[09:22]  * dimitern gaahh I seem to be eating letter today
[09:22] <mfoord> :-)
[09:34] <rogpeppe> mfoord: fancy a review? http://reviews.vapour.ws/r/2822
[09:36] <mfoord> rogpeppe: sure, coffee first
[09:36] <rogpeppe> mfoord: ta!
[10:11] <mfoord> rogpeppe: the only wart is having assertErrorResponse return the failure for a single use case
[10:12] <rogpeppe> mfoord: yeah, i had to think a bit about that
[10:12] <rogpeppe> mfoord: if you've got a better suggestion... ?
[10:12] <mfoord> rogpeppe: haha, not sure I do :-)
[10:12] <mfoord> I'll have another look
[10:12] <mfoord> the rest is straightforward
[10:13] <rogpeppe> mfoord: thanks
[10:13] <mfoord> it's a common pattern in error testing (or testing in general) - to have some detail that only needs checking once
[10:19] <mfoord> rogpeppe: as doer is only used once, and it's a one line function, does it need to be a separate function?
[10:22] <dimitern> mfoord, is a Doer constructed by a Doerer ?:D
[10:23] <mfoord> dimitern: the doerer is the function that does the doer
[10:23] <mfoord> and what that does, well...
[10:24] <dimitern> is Do()es
[10:24] <dimitern> it even
[10:25] <mfoord> rogpeppe: LGTM with the minor proviso about (maybe) inlining doer
[10:25] <rogpeppe> mfoord: thanks
[10:25] <rogpeppe> mfoord: it's like that in the other tests
[10:26] <mfoord> rogpeppe: ah right, fair enough
[10:26] <rogpeppe> mfoord: it could be inlined, but it's like it is to make it trivial to make other similar tests
[10:26] <mfoord> ok
[10:26] <mfoord> fine, drop the issue then
[10:49] <rogpeppe> mfoord: done :)
[10:50] <rogpeppe> fwereade: ping
[10:57] <TheMue> rogpeppe: he's swapping due to Seattle
[10:57] <rogpeppe> TheMue: ah, np
[11:06] <dimitern> TheMue, reviewed - quite a lot of comments I'm afraid, ping me if anything is unclear
[11:06] <TheMue> dimitern: ok, and I appreciate any comments
[11:16] <TheMue> dimitern: jfi, I'll fix it in the 1.25 branch first but mark the issues in your review. later we can forward-port the 1.25
[11:26] <dimitern> TheMue, cheers, sounds good
[11:43] <bogdanteleaga> niemeyer: is -run deprecated in gocheck in favor of check.f?
[11:46] <TheMue> dimitern: great input, you speak juju networking fluently ;) changes are now visible in http://reviews.vapour.ws/r/2823/
[11:50] <dimitern> TheMue, looks good, thanks! I'll leave frobware / voidspace to proof-read as discussed
[11:51] <TheMue> dimitern: cheers
[12:36] <frobware> TheMue, I have a few comments - just wondering whether you want to address dimiter's first before I add mine
[12:37] <TheMue> frobware: I already have done and pushed it, see http://reviews.vapour.ws/r/2823/.
[12:37] <TheMue> frobware: dimitern reviewed my master branch, this is the 1.25 one.
[12:44] <frobware> TheMue, I've add some comments but will want to take another pass. Just adding and publishing now so you're not blocked. OK?
[12:44] <TheMue> frobware: great, thanks
[12:54] <TheMue> frobware: deploy.go:118, singular "space" or plural "spaces"? the latter sounds more natural to me.
[12:57] <frobware> TheMue, You could drop this bit "but not of the cmd and the database space"
[12:58] <TheMue> frobware: ok, thx
[12:58] <frobware> TheMue, leaving it as "deploy 2 instances of haproxy on cloud instances inside subnets of the dmz space only"
[12:59] <TheMue> frobware: short and clear, sounds even better ;)
[13:00] <frobware> TheMue, also note I saw a reference to "carret" which should be "caret"
[13:01] <TheMue> frobware: fixed
[13:14] <niemeyer> bogdanteleaga: Not deprecated per se.. -run still has its usual meaning, but it's orthogonal to gocheck.. The latter has check.f for its own use
[13:15] <bogdanteleaga> niemeyer: hmm, -run doesn't seem to work for me, while check.f does with the same simple regex
[13:27] <mup> Bug #1502127 opened: TestNoUniterUpdateStatusHookInError never reached desired status <ci> <intermittent-failure> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1502127>
[13:27] <mup> Bug #1502130 opened: charm upload fails often on maas <charm> <ci> <maas-provider> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1502130>
[13:30] <mup> Bug #1502139 opened: Panic in TestUpgradeJuju on wily and vivid <ci> <intermittent-failure> <panic> <unit-tests> <vivid> <wily> <juju-core:Triaged> <https://launchpad.net/bugs/1502139>
[13:33] <mup> Bug #1502139 changed: Panic in TestUpgradeJuju on wily and vivid <ci> <intermittent-failure> <panic> <unit-tests> <vivid> <wily> <juju-core:Triaged> <https://launchpad.net/bugs/1502139>
[13:36] <mup> Bug #1502139 opened: Panic in TestUpgradeJuju on wily and vivid <ci> <intermittent-failure> <panic> <unit-tests> <vivid> <wily> <juju-core:Triaged> <https://launchpad.net/bugs/1502139>
[13:51] <mup> Bug #1502139 changed: Panic in TestUpgradeJuju on wily and vivid <ci> <intermittent-failure> <panic> <unit-tests> <vivid> <wily> <juju-core:Triaged> <https://launchpad.net/bugs/1502139>
[13:52] <mgz> what are you on mup...
[13:54] <mup> Bug #1502139 opened: Panic in TestUpgradeJuju on wily and vivid <ci> <intermittent-failure> <panic> <unit-tests> <vivid> <wily> <juju-core:Triaged> <https://launchpad.net/bugs/1502139>
[13:55] <niemeyer> bogdanteleaga: Probably because you're expecting -run to do something it doesn't do
[13:57] <bogdanteleaga> niemeyer: the docs seem to say they do pretty much the same thing(-run and check.f), just that check.f takes suites as well
[13:57] <mup> Bug # opened: 1502149, 1502153, 1502154, 1502158
[14:00] <frobware> dimitern, I was just getting back to the demo. Which region did you create the subnets in?
[14:00] <dimitern> frobware, eu-central-1
[14:00] <TheMue> frobware: dimitern: done, now just swapping offices. if branch is ok I will immediately merge it into 1.25 and then port it to master
[14:01] <dimitern> TheMue, cheers, will have one last look
[14:07] <mup> Bug #1502140 opened: panic in lastlogin upgrade step <blocker> <ci> <regression> <upgrade-juju> <juju-core:Incomplete> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1502140>
[14:09] <frobware> dimitern, TheMue: taking another look
[14:09] <niemeyer> bogdanteleaga: Just that they are different, yes :-)
[14:10] <mup> Bug #1502140 changed: panic in lastlogin upgrade step <blocker> <ci> <regression> <upgrade-juju> <juju-core:Incomplete> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1502140>
[14:12] <frobware> dimitern, how do I get to eu-central? My choices are frankfurt or ireland.
[14:18] <mgz> the 1.25 branch is blocked at present, see ^ that bug
[14:19] <mup> Bug #1502140 opened: panic in lastlogin upgrade step <blocker> <ci> <regression> <upgrade-juju> <juju-core:Incomplete> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1502140>
[14:27] <dimitern> frobware, eu-central-1 is in frankfurt :)
[14:31] <frobware> dimitern, yeah. I noticed. <face palm>
[14:31] <frobware> :)
[14:38] <natefinch> fwereade: you around?
[15:04] <natefinch> ericsnow: anything I need in the environments.yaml besides type: lxd?
[15:05] <ericsnow> natefinch: nope
[15:08] <katco> fwereade: hey can you give a high-level review of http://reviews.vapour.ws/r/2814 ? i'm doing a detailed review, but i want to make sure we're not doing anything wrong, conceptually
[15:08] <katco> fwereade: i.e. i think it will need a +2 from you
[15:09] <katco> natefinch: i see several places ericsnow's multi error patch would help :)
[15:09] <katco> if only it were in the codebase.... le'sigh
[15:10] <ericsnow> katco: what!!! someone isn't opposed!  ;)
[15:10] <katco> ericsnow: hey, i've always thought it was a good idea
[15:10] <katco> ericsnow: very common patterns
[15:11] <ericsnow> katco: all providers use it (and not for necessarily API-related stuff)
[15:11] <ericsnow> (it = the pattern)
[15:12] <natefinch> definitely a common APIMultiError  would be good.... it's just proposed as being more general than it needs to be now
[15:12] <ericsnow> katco: check out Environ.Instances in conjunction with ErrNoInstances and ErrPartialInstances
[15:13] <ericsnow> natefinch: I wrote it in the first place to meet a non-API use case
[15:13] <katco> natefinch: yeah not sure that's true... ericsnow ran into a place yesterday
[15:14] <natefinch> it just assumes you have an id for each error, which is not always the case... but it would fit many cases, most of which are bulk calls in the API
[15:15] <ericsnow> natefinch: the ID is neither required not necessarily unique
[15:15] <ericsnow> (not -> nor)
[15:16] <perrito666> bbl people
[15:16] <mgz> natefinch: I don't like that retry function much
[15:17] <mgz> means all those tests will have an extra 3s ceiling runtime?
[15:17] <natefinch> mgz: we have to wait for the worker... I don't know how to get around that
[15:19] <natefinch> mgz: and in theory it's up to 3 seconds... though in small scale tests I did find it took a couple seconds for the watcher to notify the worker and for the worker to do its job
[15:20] <natefinch> mgz: I don't know why the worker/watcher cycle is so slow
[15:21] <natefinch> mgz: I also don't know if that slowness is outside the norm.... are they usually instant?  I don't know the details of how the watchers and workers work.... but I know there's a lot of machinery between them.
[15:22] <mgz> natefinch: yeah, i don't have a good answer on overall speed, but why not usin LongAttempt
[15:23] <natefinch> mgz: I thought about using the attempt code, but it didn't really fit with the pattern I wanted, IIRC'
[15:24] <natefinch> mgz: I could certainly look at it again
[15:25] <natefinch> mgz: on second thought, I could make that work.. I missed the fact that I could call HasNext()
[15:26] <mgz> natefinch: that would make me happier, at least we're staying with the existing constants
[15:29] <natefinch> mgz: makes me happier, too.
[15:37] <mup> Bug #1502202 opened: toolsversionchecker worker failing <juju-core:New> <https://launchpad.net/bugs/1502202>
[15:37] <natefinch> mgz: fixed :)
[15:38] <mgz> natefinch: thanks!
[15:38] <natefinch> mgz: thanks for getting me to look at the attempt code again.  I definitely prefer using something already written than handcrafting my own.
[15:41] <aisrael> jcastro: alexisb: lp:1502202 is the first I found. I'm trying to recreate the second.
[15:43] <mup> Bug #1502202 changed: toolsversionchecker worker failing <juju-core:New> <https://launchpad.net/bugs/1502202>
[15:46] <mup> Bug #1502202 opened: toolsversionchecker worker failing <juju-core:New> <https://launchpad.net/bugs/1502202>
[15:55] <aisrael> jcastro: alexisb: I can't recreate the second issue. I've been running 1.25 since alpha1 for daily work and it's been solid except for the previously mentioned issue. Kudos.
[16:17] <katco> natefinch: that is some hairy code. lgtm, but i think we really need someone like fwereade to look at it
[16:18] <fwereade> katco, natefinch: link? (no promises today though)
[16:18] <katco> fwereade: http://reviews.vapour.ws/r/2814/
[16:18] <fwereade> katco, cheers
[16:18] <katco> fwereade: a high-level overview should suffice. just need to make sure we're conceptually doing the right thing.
[16:19] <katco> fwereade: this is the combining txns you and natefinch have been discussing
[16:19] <fwereade> katco, so I see -- awesome :)
[16:23] <natefinch> fwereade: I have a couple concerns... I'm using raw ids across the API... I think that's a no-no, but not sure if I should be creating a new tag just for my new mini collection
[16:24] <fwereade> natefinch, for watcher results it's the least wrong thing to do actually
[16:24] <fwereade> natefinch, might be inclined to go with unit ids though
[16:24] <natefinch> fwereade: that's certainly doable
[16:25] <natefinch> fwereade: the other one is that this is a general worker, but maybe it should be a singular worker?  We don't want multiples of these things doing assignments of the same things at the same time
[16:25] <fwereade> natefinch, (translating id->tag at apiserver Next() time has complications -- but that's where it should be fixed, and for every watcher at once)
[16:25] <fwereade> natefinch, I'd favour making it safe when racing with itself
[16:26] <fwereade> natefinch, singular is a bit yucky
[16:26] <fwereade> natefinch, but you're probably right
[16:26] <fwereade> natefinch, yeah, make it singular, we just need a less layer--breaky singular implementation
[16:26] <natefinch> fwereade: yeah, I started to go down the singular route, but all the current examples seem to use state directly, which I know is a Bad Thing... and trying to get it working with the API was tricky
[16:27] <fwereade> natefinch, yeah, it should just affect where you launch it in  the machine agent
[16:27] <fwereade> natefinch, there's a singular wrappper func which at least keeps the evil out of its clients' hair
[16:27] <fwereade> natefinch, gtg for now
[16:27] <natefinch> fwereade: ok, thanks for the input
[18:03] <natefinch> ericsnow: gah, I hate having methods on a type outside the file where that type is defined... when we get some time, can we maybe not do that?
[18:05] <ericsnow> natefinch: yeah, we should split types like that up along the same line as the files (and compose them into the main type)
[18:05] <ericsnow> natefinch: otherwise we end up with enormous files
[18:07] <natefinch> ericsnow: well.... if it's done well, not not just done to get the methods out of the same file, I think that's ok.  But given that the environ.go file is only 147 lines right now, I think we have a long way to go before we need to start breaking things up.
[18:26] <alexisb> frobware, you potentially around?
[18:27] <perrito666> how do you people keep feature branches up to date?
[18:27] <natefinch> perrito666: merge from master once in a while
[18:27] <natefinch> perrito666: it's not fun
[18:27] <perrito666> natefinch: was thinking on the details :)
[18:27] <perrito666> pr?
[18:27] <perrito666> direct merge?
[18:27] <natefinch> perrito666: meh, just merge
[18:28] <natefinch> rebase if you're feeling lucky
[18:28] <perrito666> natefinch: and you push that to the feature branch directly?
[18:29] <natefinch> perrito666: oh uh... hmm..
[18:29] <natefinch> perrito666: I guess PR.. sorry, wasn't thinking
[18:29] <natefinch> perrito666: though it's generally not something that can really get reviewed
[18:35] <perrito666> mm, can I get permissions to push into a branch in our repo?
[18:40] <mup> Bug #1502140 changed: panic in lastlogin upgrade step <blocker> <ci> <regression> <upgrade-juju> <juju-core:Incomplete> <juju-core 1.25:Triaged by cherylj> <https://launchpad.net/bugs/1502140>
[18:43] <mup> Bug #1502140 opened: panic in lastlogin upgrade step <blocker> <ci> <regression> <upgrade-juju> <juju-core:Incomplete> <juju-core 1.25:Triaged by cherylj> <https://launchpad.net/bugs/1502140>
[18:46] <mup> Bug #1502140 changed: panic in lastlogin upgrade step <blocker> <ci> <regression> <upgrade-juju> <juju-core:Incomplete> <juju-core 1.25:Triaged by cherylj> <https://launchpad.net/bugs/1502140>
[19:44] <mup> Bug #1502306 opened: cannot find package gopkg.in/yaml.v2 <blocker> <ci> <regression> <juju-core:Incomplete> <juju-core lxd-provider:Triaged> <https://launchpad.net/bugs/1502306>
[20:29] <mup> Bug #1502314 opened: juju-deployer never completes landscape deployment to vmLDS <kanban-cross-team> <landscape> <falkor:Triaged> <juju-core:New> <https://launchpad.net/bugs/1502314>
[20:32] <mup> Bug #1502314 changed: juju-deployer never completes landscape deployment to vmLDS <kanban-cross-team> <landscape> <falkor:Triaged> <juju-core:New> <https://launchpad.net/bugs/1502314>
[20:35] <mup> Bug #1502314 opened: juju-deployer never completes landscape deployment to vmLDS <kanban-cross-team> <landscape> <falkor:Triaged> <juju-core:New> <https://launchpad.net/bugs/1502314>
[20:41] <alexisb> aisrael, jcastro, I really appreciate the feedback on 1.25, that is great!
[20:44] <mup> Bug #1502314 changed: juju-deployer never completes landscape deployment to vmLDS <kanban-cross-team> <landscape> <falkor:Triaged> <juju-core:New> <https://launchpad.net/bugs/1502314>
[20:47] <mup> Bug #1502314 opened: juju-deployer never completes landscape deployment to vmLDS <kanban-cross-team> <landscape> <falkor:Triaged> <juju-core:New> <https://launchpad.net/bugs/1502314>
[21:38] <beisner> alexisb, do we have an eta on the fix for the being ppa-consumable somewhere? https://bugs.launchpad.net/juju-core/+bug/1335885
[21:38] <mup> Bug #1335885: destroy-environment reports WARNING cannot delete security group <amulet> <cloud-installer> <destroy-environment> <landscape> <openstack-provider> <security>
 <juju-core:In Progress> <juju-core 1.24:Fix Committed by thumper> <juju-core 1.25:In Progress by thumper> <https://launchpad.net/bugs/1335885>
[22:06] <alexisb> heya beisner
[22:06] <alexisb> we have a fix committed for that bug for 1.24, but we are currently working to get a blessed build for 1.24 on CI
[22:07] <alexisb> beisner, eta for a 1.24.7 release is next week pending a blessed CI revision
[23:48] <beisner> alexisb, woot, thanks