wgrantcjwatson: I could randomise the sequences on DB setup, but few enough tests were affected that I don't think it's going to be a huge problem.11:40
* cjwatson nods11:42
wgrantcjwatson: So close.12:26
wgrantIn the most obvious test, too :P12:26
cjwatsonGrr.  I ran all the tests but must have been a little out of date.12:28
=== SJW is now known as Peng
blrwgrant: made that wee change to launchpad-buildd when you have a moment. https://code.launchpad.net/~blr/launchpad-buildd/snap_http_proxy/+merge/27335520:40
wgrantblr: Your os.environ set is bad.21:11
wgrantAnd did you manage to confirm the approach with Martin?21:11
blrwgrant: no he hasn't responded yet.21:11
blrwgrant: at the snappy sprint presumably21:13
blrI'll try pinging him again21:13
wgrantcjwatson: Huh, no idea how that test slipped through, sorry. I ran the entire test suite with all the sequences set to strange values...21:14
wgrantI wonder if I missed a case in the fixture, will rerun.21:14
cjwatsonwgrant: I think it must depend on the BPPH sequence starting just the right amount offset from the SPPH sequence21:17
cjwatsonProbably should just test that it doesn't get a thing of the wrong type back, rather than specifically None21:18
blrwgrant: ah, env=os.environ in _reactor.spawnProcess21:18
wgrantblr: More that you're setting the http_proxy environment variable to "http_proxy=[...]"21:24
blrah, so I am... >.<21:26
wgrantcjwatson: Yeah, will fix.21:27
wgrantAnd try to come up with a more diabolical sequence breaking strategy.21:27
blrwgrant: updating startBuild in the buildd snap test, however can't find the 'apt21:43
blr' module21:43
blrand there's no setup.py or dependency manifest afaict21:44
blris that python-apt?21:45
blrthanks cjwatson21:45
wgrantblr: You are meant to run the buildd tests under LP's bin/py, IIRC.21:45
wgrantBut the snap ones may work without that.21:46
cjwatsonIt's in the package dependencies ... and yes, what wgrant says21:46
blrah, didn't realise that was possible.21:46
cjwatsonThere's a comment in the Makefile about it21:46
cjwatsonIt's a bit awkward because they don't necessarily always end up being in version sync, but txfixtures isn't packaged IIRC21:47
=== Spads_ is now known as Spads

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!