/srv/irclogs.ubuntu.com/2015/10/06/#juju-dev.txt

beisnero/ hi core friends02:03
beisnerany idea if https://bugs.launchpad.net/juju-core/+bug/1500613 can be targeted to something (way) earlier than 1.26a1?02:04
mupBug #1500613: configstore should break fslock if time > few seconds <amulet> <openstack-provider> <tech-debt> <uosci> <juju-core:Triaged> <https://launchpad.net/bugs/1500613>02:04
mupBug #1261780 opened: api.Client().AddLocalCharm() uses utils.GetNonValidatingHTTPClient() <security> <tech-debt> <juju-core:In Progress> <https://launchpad.net/bugs/1261780>06:59
mupBug #1261780 changed: api.Client().AddLocalCharm() uses utils.GetNonValidatingHTTPClient() <security> <tech-debt> <juju-core:In Progress> <https://launchpad.net/bugs/1261780>07:02
mupBug #1261780 opened: api.Client().AddLocalCharm() uses utils.GetNonValidatingHTTPClient() <security> <tech-debt> <juju-core:In Progress> <https://launchpad.net/bugs/1261780>07:05
mupBug #1261780 changed: api.Client().AddLocalCharm() uses utils.GetNonValidatingHTTPClient() <security> <tech-debt> <juju-core:In Progress> <https://launchpad.net/bugs/1261780>07:17
mupBug #1261780 opened: api.Client().AddLocalCharm() uses utils.GetNonValidatingHTTPClient() <security> <tech-debt> <juju-core:In Progress> <https://launchpad.net/bugs/1261780>07:20
voidspaceTheMue: dooferlad: morning08:01
voidspaceTheMue: dooferlad: not really any worse than last night, so I'm "in" today08:01
voidspacesee you at standup08:01
voidspacecherylj: I think you looked at the "Restore failed: error fetching address" critical issue08:07
voidspacecherylj: just to let you know that I've got it (and it's almost certainly my fault anyway)08:07
voidspacedooferlad: TheMue: if you have a chance, it's a nice short diff but should fix the problem09:23
voidspacedooferlad: TheMue: http://reviews.vapour.ws/r/2835/09:23
voidspaceThe added tests fail without the change in addmachine, so pretty sure it's the right fix. (Restore creates a new machine as the bootstrap machine and then immediately asks for its address - which currently isn't set.)09:24
TheMuevoidspace: looks good09:26
dooferladvoidspace: what is the parameter from network.SelectInternalAddr that you are ignoring?09:26
voidspacedooferlad: it's an error - which will be a "no address" error if the slice of addresses is empty09:27
voidspacedooferlad: in that case the returned address will be empty - and setting the preferred address to an empty address is then the right thing to do09:27
dooferladvoidspace: sounds good09:27
voidspacedooferlad: so we can safely ignore the error - even if an error is returned we still use the empty address that is also returned09:27
voidspaceTheMue: thanks09:27
dooferladvoidspace: maybe just add a comment about that logic? Then it is good to go.09:28
voidspacedooferlad: ok09:28
TheMuedooferlad: good idea09:29
voidspacedooferlad: done09:30
rogpeppei hadn't realised just how broken reviewboard was until now10:11
voidspacerogpeppe: just how broken is it?10:13
voidspacescrewed up diffs?10:13
rogpeppevoidspace: unimaginably10:13
rogpeppevoidspace: can't click on comments. can't close tabs.10:14
voidspacewow10:14
voidspacerogpeppe: to be fair, that sounds like firefox (or whatever) is broken10:14
rogpeppevoidspace: it takes some serious screwups not to be able to close a tab in Chrome10:14
rogpeppevoidspace: i don't think i've ever encountered that before10:14
voidspacerunaway javascript I guess10:14
rogpeppevoidspace: the machine's not spinning...10:14
voidspacerogpeppe: I thought tabs in chrome were supposed to be isolated so that couldn't happen10:15
rogpeppevoidspace: indeed10:15
voidspaceit still sounds like a browser bug10:15
voidspaceI've never had that with reviewboard10:15
rogpeppevoidspace: and it's just screwed up by design. the fact that if you want to reply to a review comment, it takes you to a new page.10:15
rogpeppevoidspace: i've worked out how i did it, i think10:16
rogpeppevoidspace: i didn't like the above behaviour (i wanted to keep my inline comment context and still reply to a review comment) so i right-clicked "open in new tab" on the Reply button.10:16
rogpeppevoidspace: instant screwup10:16
TheMuerogpeppe: a new page? hmm, never had this10:17
voidspacerogpeppe: nice10:17
voidspaceTheMue: rogpeppe: submitting an inline comment takes you away from the review page10:18
rogpeppeTheMue: so if you want to reply to a review comment (not adding a new comment which is what i was doing initially without knowing it), you click on "reply" and it doesn't take you away from the full diff context?10:18
voidspacewhich is annoying10:18
* TheMue checks10:18
rogpeppevoidspace: also, it appears that you're not able to reply to issues that have been fixed or dropped10:18
voidspacenot ideal10:19
TheMuerogpeppe: somehow I only find the link "Add comment"10:20
rogpeppeTheMue: that's in the comment overview page10:21
rogpeppeTheMue: i'm almost always in the "View Diff" page10:21
TheMuerogpeppe: yes, I'm mostly in the "View Diff" too10:22
TheMueeveryday something new ...10:22
=== IceyEC is now known as Icey
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
voidspaceericsnow: hey13:04
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
ericsnowvoidspace: hey14:03
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
voidspaceericsnow: a package arrived for me today14:49
voidspaceericsnow: thank you14:49
ericsnowvoidspace: you are quite welcome! :)14:54
voidspaceericsnow: looks like there's a lot of good stuff in there, I've only dipped in so far14:56
perrito666Voidspace you where blaming me for something but you disconnected too soon14:56
voidspaceperrito666: restore was broken14:59
voidspaceperrito666: my fault this time (originally I pinged you because I wanted some help - but then I worked it out)15:00
voidspaceI mainly blame fwereade though, my original approach didn't have that bug :-p15:00
voidspaceperrito666: http://pad.lv/149957115:00
perrito666Lol if what you did broke restore, then it was probably good15:01
voidspaceperrito666: the actual fix was only a few lines though15:01
voidspaceperrito666: it nicely proves our CI system works - it was a genuine bug only caught by the CI tests15:01
=== akhavr1 is now known as akhavr
ericsnowvoidspace, perrito666: FYI, a LXD-based provider will allow you to test restore locally15:01
perrito666Indeed15:02
ericsnowhopefully it is coming sooner rather than later :)15:02
perrito666Ericsnow anyway it is rather annoying to run that particular test but we could have a bootstrap test which would be nice15:03
perrito666Lunch bbl15:03
voidspaceo/15:03
=== akhavr1 is now known as akhavr
abentleyericsnow: I had no idea an lxd provider was coming until I watched Stephane Graber's Container Camp presentation.15:12
=== akhavr1 is now known as akhavr
ericsnowabentley: yeah, the LXD folks have done a great job, reducing the complexity of building a Juju provider around LXD15:14
abentleyericsnow: I'm excited that we're getting LXD support.  Especially if that means machine 0 will not be my actual host.15:16
ericsnowabentley: yeah, that's what has me most excited as well :)15:16
voidspaceyep +115:16
ericsnowabentley: we'll see how it pans out, but there are a number of other possibilities that a LXD provider would open up15:17
voidspaceabentley: master is not blocked on bug 149957115:18
ericsnowabentley: e.g. running across multiple hosts; snapshots15:18
mupBug #1499571: Restore failed: error fetching address <backup-restore> <blocker> <ci> <regression> <reliability> <retry> <juju-core:In Progress by mfoord> <juju-core 1.24:Fix Released by mfoord> <juju-core 1.25:Fix Committed by mfoord> <https://launchpad.net/bugs/1499571>15:18
perrito666Not having to sysadmin my machine back into working a couple of times a week is already a big plus15:18
=== akhavr1 is now known as akhavr
voidspaceabentley: which surprises me as it blocked 1.24 and 1.2515:18
voidspaceabentley: I've committed a fix to both those branches but master is blocked on something else15:19
voidspaceabentley: ok for me to JFDI my fix onto master, or is it better if I wait?15:19
abentleyvoidspace: sinzui demoted it to Medium.15:19
voidspaceright15:19
voidspaceI don't know why15:19
ericsnowalso, having multiple distinct Juju dev environments on different series (or even distros) all at the same time15:19
abentleyvoidspace: It's better if you wait.  That way, when you land, it will be clear whether your branch was blessed or cursed.15:21
voidspaceabentley: ok, no problem15:21
=== akhavr1 is now known as akhavr
dimiternvoidspace, o/15:28
voidspacedimitern: hey, hi15:29
voidspacedimitern: how's it going?15:29
dimiternvoidspace, so far so good :) we're demoing today - well, frobware will be driving it actually15:30
voidspacedimitern: cool, good luck15:31
dimiternvoidspace, how about that 1.9 bug?15:31
dimiternvoidspace, thanks!15:31
voidspacedimitern: only just getting to it really15:31
voidspacedimitern: got hit fixing a critical blocker on 1.24 - master15:32
voidspacedimitern: plus my maas is borked and no-one seems available to help fix it15:32
voidspacedimitern: but I have maas 1.9 in a kvm I can use15:32
voidspacedimitern: just looking at the cloudinit code now15:32
dimiternvoidspace, right, ok then - please, post updates on the bug as you go to show we're handling it15:33
voidspacedimitern: so the bit I actually need to fix is the *bash script* in bridgeConfigTemplate15:33
voidspaceoh joy :-)15:33
dimiternvoidspace, yes, that was the crux of the issue IIRC15:34
voidspacecool15:34
voidspacelooks like some fun playing with sed and grep15:34
voidspaceand some test scripts15:34
dimiternvoidspace, just don't drop the "auto eth0" if we haven't rendered the bridge config15:35
dimiternin /e/n/i15:35
dimiternvoidspace, also if /e/n/i already has a static config for the primary nic, we should move it into the juju-br0 config, and still set ethX to manual15:36
voidspaceright15:36
voidspacedimitern: what do you mean by "if we haven't rendered the bridge config"15:37
voidspacedimitern: bridgeConfigTemplate checks to see if the bridge already exists and exits15:37
dimiternvoidspace, so in the script there's a pipeline like grep 'iface ethX inet dhcp' && sed ... & cat << EOF15:37
voidspaceyep15:38
dimiternvoidspace, if that first grep fails, the cat is not done, and /e/n/i not modified with the bridge config15:38
voidspaceah, but then we still remove the auto15:38
dimiternvoidspace, yeah15:38
voidspaceso that should be guarded too15:38
dimiternvoidspace, yes, but just that won't cut it15:39
voidspacewe still need to create the bridge15:39
voidspacedo we leave the primary interface definition in place and copy it into the bridge definition?15:39
dimiternvoidspace, we need to check if /e/n/i has iface ethX inet static, and copy the rest of the section into the section for iface juju-br0 inet static (e.g. address, netmask, etc.) in addition to bridge_ports15:40
voidspaceso leave the auto in place *plus* copy the details15:40
voidspacethat should be fine, need to get this kvm booting instances - it's been a while since I set it up15:40
dimiternvoidspace, let me paste you an example, just a sec15:41
dimiternvoidspace, http://paste.ubuntu.com/12697581/15:43
voidspacedimitern: cool, thanks - that's clear15:44
dimiternvoidspace, cheers :)15:44
voidspacethe fun part is using bash to detect the *whole* of the section to copy15:44
voidspacenot entirely sure how to express "copy everything up to the dedent" in bash :-)15:44
voidspaceI'll work it out though15:44
dimiternvoidspace, yeah, that's a bit fiddly with bash I guess15:44
voidspaceworst case I use Python :-p15:45
voidspacebut I'll try not to15:45
dimiternvoidspace, I don't mind - if you do, add it to the packages to install ;)15:45
voidspaceok15:45
dimiternvoidspace, however, I've just realized it might not work, as this is called too early in the boot process, likely before the packages are installed - hence, bash unfortunatelly15:46
voidspacedimitern: kk15:47
frobwarevoidspace, you could refactor what's there a bit and turn some of into functions15:47
voidspacefrobware: that sounds eminently sensible15:49
frobwarevoidspace, it would help to determine what to call based on what you discover15:49
voidspaceyep15:50
voidspaceand some good names could make it a bit clearer what's being done15:50
mgzabentley: https://github.com/ericsnowcurrently/juju/tree/lxd-provider-full-provider15:52
voidspacefrobware: good luck with the demo16:02
frobwarevoidspace, thx16:02
voidspacefrobware: did you do the devices demo already?16:04
frobwarevoidspace, nope16:04
voidspaceah16:04
voidspacecool16:04
frobwarevoidspace, does work for me though16:04
voidspacegreat16:04
voidspacethat's a good sign...16:04
voidspaceit might actually work then ;-)16:04
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
rogpeppeales, anyone else: this PR adds macaroon authentication to the streaming API endpoints: http://reviews.vapour.ws/r/2838/16:42
rogpeppereview much appreciated16:42
=== akhavr1 is now known as akhavr
mgzvoidspace: any news on bug 1499571? it is due to the address stability change?16:54
mupBug #1499571: Restore failed: error fetching address <backup-restore> <blocker> <ci> <intermittent-failure> <regression> <reliability> <retry> <juju-core:In Progress by mfoord> <juju-core 1.24:In Progress by mfoord> <juju-core 1.25:In Progress by mfoord> <https://launchpad.net/bugs/1499571>16:54
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
voidspacemgz: it was, fix committed on 1.24 and 1.25 - master is blocked on something else and that bug was only marked as "medium" on master17:20
voidspacemgz: so not landed there yet17:20
mgzvoidspace: aha, I misunderstood then17:23
voidspacemgz: misunderstood what?17:23
mgzthe state of the bug17:23
voidspaceah :-)17:24
voidspaceI misunderstood your misunderstanding17:24
=== akhavr1 is now known as akhavr
voidspacemgz: just seen your comment17:25
voidspacemgz: is your comment out of date then?17:25
voidspacemgz: it was intermittent because as soon as SetMachineAddresses or SetProviderAddresses was called on the bootstrap machine the PublicAddress and PrivateAddress would become available17:25
voidspacemgz: with the fix already landed they should be available immediately17:26
voidspacemgz: have they failed since my fix landed?17:26
mgzvoidspace: I had not realised you had landed something,17:27
voidspaceah17:27
voidspace:-)17:27
mgzyou had the bug in progress and CI auto-marked fix released because 1.24 was blessed17:28
voidspacekk17:28
voidspacemgz: it marked fix released because prior to the bless I marked the 1.24 milestone as fix  committed17:28
voidspacesame with 1.2517:28
voidspacebut master is still in progress because I can't land there yet17:28
voidspacemgz: so you put them back to "in progress"?17:29
mgzright, I didn't see you'd landed anything.17:29
voidspace:-)17:29
voidspacefair enough17:29
mgzso, can put back to fix released, and make it so you can land change on master too.17:29
voidspacemgz: mark it as critical?17:29
voidspacethat should allow me to land it17:30
voidspaceI'm not sure why it was set as medium17:30
voidspaceit's still a regression on master17:30
mgzvoidspace: done and done17:33
voidspacemgz: thanks17:33
=== akhavr1 is now known as akhavr
mgzvoidspace: thanks for the fix, sorry for the confusion :)17:46
voidspacemgz: np :-)17:47
voidspaceEOD17:48
voidspaceg'night all17:48
mgzsleep well :P17:48
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
mupBug #1496972 changed: juju bootstrap fails to successfully configure the bridge juju-br0 when deploying with wily 4.2 kernel <hs-arm64> <kernel-da-key> <network> <Linux:Triaged by jsalisbury> <https://launchpad.net/bugs/1496972>20:04
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== meetingology` is now known as meetingology
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
ericsnowcmars: FYI, I have a patch up that merges master into the lxd-provider branch: http://reviews.vapour.ws/r/2834/21:37
ericsnowcmars: mind if I fold in those deps from your patch?21:38
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
perrito666oh god why status is so cruel21:57
mupBug #1503449 opened: easy bug reporting for juju - e.g. sosreport <juju-core:New> <https://launchpad.net/bugs/1503449>22:10
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
katcoericsnow: awesome. wwitzel3 ^^^ what ericsnow said23:39
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!