/srv/irclogs.ubuntu.com/2015/10/13/#juju-dev.txt

=== akhavr1 is now known as akhavr
mupBug #1505460 opened: Image consistency with containers can be broken <juju-core:New> <https://launchpad.net/bugs/1505460>01:07
mupBug #1505460 changed: Image consistency with containers can be broken <juju-core:New> <https://launchpad.net/bugs/1505460>01:10
mupBug #1505460 opened: Image consistency with containers can be broken <juju-core:New> <https://launchpad.net/bugs/1505460>01:13
mupBug #1505460 changed: Image consistency with containers can be broken <juju-core:New> <https://launchpad.net/bugs/1505460>01:16
mupBug #1505460 opened: Image consistency with containers can be broken <juju-core:New> <https://launchpad.net/bugs/1505460>01:19
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
davecheneyGet:1 http://ports.ubuntu.com/ubuntu-ports/ trusty-updates/main linux-image-3.19.0-30-generic arm64 3.19.0-30.34~14.04.1 [51.2 MB]03:42
davecheney16% [1 linux-image-3.19.0-30-generic 10.0 MB/51.2 MB 20%]    56.8 kB/s 15min 1s^Z03:42
davecheneywheee03:42
davecheneycloud scale03:42
=== meetingology` is now known as meetingology
=== urulama_ is now known as urulama
mupBug #1505504 opened: error when destroying current environment in a multi-environment scenario <juju-core:New> <https://launchpad.net/bugs/1505504>05:23
=== akhavr1 is now known as akhavr
mupBug #1505504 changed: error when destroying current environment in a multi-environment scenario <juju-core:New> <https://launchpad.net/bugs/1505504>05:32
mupBug #1505504 opened: error when destroying current environment in a multi-environment scenario <juju-core:New> <https://launchpad.net/bugs/1505504>05:47
=== akhavr1 is now known as akhavr
rogpeppemgz: it looks like reviewboard has stopped adding the "Review request" comment to github PR titles06:57
rogpeppemgz: (i just had to add one manually to https://github.com/juju/juju/pull/3485 and the two before it haven't been labeled)06:57
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
mgzrogpeppe: yeah, I broke eric the other day, will fix now and poke him again later to sort out08:07
* rogpeppe hopes eric can be fixed08:08
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
dooferladvoidspace: hangout time09:01
dooferladjam: hangout?09:04
voidspacefrobware: I've turned it into a PR so it can be reviewed, but  I won't land it until we've confirmed it actually fixes the bug!09:36
voidspacefrobware: https://github.com/juju/juju/pull/348909:36
voidspacefrobware: bootstrapping against 1.9 now09:36
voidspacebug updated as well09:38
frobwarevoidspace, thanks - bbiab (rebooting)...09:38
voidspacefrobware: hmmm... two failed bootstraps10:01
voidspacefrobware: failing with 2015-10-13 10:00:33 WARNING juju.replicaset replicaset.go:98 Initiate: fetching replication status failed: cannot get replica set status: can't get local.system.replset config from self or any seed (EMPTYCONFIG)10:01
voidspacefrobware: switched to 1.25 and trying to see if it fails in the same way10:02
frobwarevoidspace, worked first time for me - using your branch10:02
voidspaceodd :-)10:02
voidspaceit could just be dumb luck10:02
frobwarevoidspace, the times I see this I force a really clean build...10:02
voidspacefrobware: that's certainly not the failure I would expect10:03
voidspacefrobware: after I've tried vanilla 1.25 I'll rebuild and do a clean attempt10:03
voidspaceI would expect everything after the ifdown/ifup to fail10:03
voidspacefrobware: yeah, vanilla 1.25 fails much harder10:08
voidspacefrobware: so I'll call that a win ;-)10:08
voidspace(fails earlier)10:08
frobwarevoidspace, still going through the motions with multiple NICs10:08
voidspacefrobware: kk10:09
voidspacein the meantime10:09
voidspacedooferlad: TheMue: fancy a review? http://reviews.vapour.ws/r/2882/10:10
voidspacefrobware: ah, a godeps made some changes, maybe that was it10:28
voidspacetrying yet again10:28
=== urulama is now known as urulama|afk
frobwarevoidspace, pretty sure that's why/when I see the replicaset issue.10:29
frobwarevoidspace, posted a few comments and still doing some manual testing.10:29
voidspacefrobware: thanks10:31
voidspacefrobware: we can't create unit tests for machines with multiple nics  I don't think10:31
voidspacefrobware: as the tests really just do text manipulation10:31
frobwarevoidspace, I was thinking more of the case where we have multiple entries in the expected input/output tests.10:32
=== urulama|afk is now known as urulama
voidspacefrobware: we use the primary interface as found from the "ip route list exact 0/0" command10:33
frobwarevoidspace, so maybe I misread the test - let me take another look10:33
voidspacefrobware: nice improvement in those bash functions though10:35
voidspacepushing now10:35
voidspacefrobware:can I drop that issue?10:49
frobwarevoidspace, line 219 in environ_test.go - can we not simulate in there that there might be multiple NICs?10:52
voidspacefrobware: that's the script we generate - which is the same for multiple nics10:53
voidspacefrobware: we don't simulate the machine at all10:53
voidspacethat script has to *work* on machines with multiple nics - but is itself unchanged10:53
frobwarevoidspace, that's just expected output though10:53
voidspacethat's the script itself10:53
voidspacethe output of generating the script10:53
frobwarevoidspace, to me that's just test input/output, no?10:54
voidspacefrobware: well yes10:54
voidspacefrobware: but that input / output will be the same on a machine with multiple nics10:55
voidspacewe do not simulate the machine10:55
frobwarevoidspace, so does it make sense to have a test that has multiple ethN entries?10:55
voidspacewe only generate the script and check the generated output matches what we expect10:55
voidspacefrobware: the script will never have multiple ethN entries10:55
voidspace*running* the script on a machine with multiple nics will do something10:56
voidspacebut the unit tests never run that part of the code10:56
voidspacefrobware: see how that script doesn't mention ethN at all - but sets and uses $PRIMARY_IFACE10:57
voidspacefrobware: or are you talking about networkStaticInitial versus networkStaticFinal10:57
frobwarevoidspace, sure, but the stuff I thought we were talking about was just text matching/replacement10:57
voidspacefrobware: and adding extra ethN entries in the canned /etc/network/interfaces ?10:58
voidspacefrobware: well it is10:58
frobwarevoidspace, exactly10:58
voidspaceah10:58
voidspacefrobware: I can add an extra entry and we can test it is left untouched10:58
voidspacesome value in that I guess10:58
frobwarevoidspace, agreed10:58
voidspaceI'll add an extra test10:59
frobwarevoidspace, I think there should be two: 1 with eth0, 1 with eth...ethN.10:59
voidspacefrobware: well I'll add one extra with an eth110:59
voidspacefrobware: if eth1 is untouched then adding ...ethN adds no extra value11:00
voidspacewe just want to test that "not the primary interface" is left intact11:00
voidspacefrobware: sorry for the misunderstanding :-)11:05
mupBug #1505617 opened: juju backup intermittent failure <canonical-bootstack> <juju-core:New> <https://launchpad.net/bugs/1505617>11:06
mupBug #1505617 changed: juju backup intermittent failure <canonical-bootstack> <juju-core:New> <https://launchpad.net/bugs/1505617>11:09
voidspacefrobware: additional test pushed11:10
mupBug #1505617 opened: juju backup intermittent failure <canonical-bootstack> <juju-core:New> <https://launchpad.net/bugs/1505617>11:12
frobware_voidspace, thanks11:15
frobware_voidspace, mgz: do we have an easy or existing mechanism to build a ppa for a proposed fix like this?11:19
voidspacefrobware_: I don't know, I don't think deploying a ppa is "simple"11:26
frobware_voidspace, heh, no. I've always used fpm when I wanted to do this.11:26
voidspacefrobware_: are you using trusty or vivid?11:27
voidspacefrobware_: on trusty I can bootstrap but then get the replset failure - reliably it seems11:27
frobware_voidspace, trusty11:27
voidspacefrobware_: I'm trying changing the images to see if that helps11:27
voidspaceprobably a different mongo package11:27
voidspacebut if it works for you it shouldn't be that11:28
frobware_voidspace, to rebuild I use: alias rebuild-juju='[ -f $PWD/juju/api.go ] && { set -e; nukegopkg; make clean; godeps -u dependencies.tsv; make install; }'11:28
mgzfrobware_: people ask for ppas, but generally that's not actually useful for juju11:29
mgzwe're better off giving them some built binaries11:29
voidspacemgz: frobware_ : in this case it's Mark Shuttleworth asking for a ppa...11:29
mgzyeah, well that's always a fun conversation11:29
voidspaceoh no its not11:29
voidspace<voidspace> frobware: additional test pushed11:29
voidspace<mup> Bug #11:29
mgzvoidspace: you killed him11:30
voidspacehttps://bugs.launchpad.net/juju-core/+bug/149447611:30
mupBug #1494476: MAAS provider with MAAS 1.9 - /etc/network/interfaces "auto eth0" gets removed and bridge is not setup <addressability> <lxc> <maas-provider>11:30
mup<network> <juju-core:Triaged by mfoord> <juju-core 1.24:Triaged by mfoord> <juju-core 1.25:In Progress by mfoord> <https://launchpad.net/bugs/1494476>11:30
voidspaceit's andreserl asking11:30
voidspaceprebuild binaries should be enough11:30
mgzyup.11:31
rogpeppemgz, anyone else: reviews much appreciated for this PR which fixes a critical issue: http://reviews.vapour.ws/r/2878/diff/#11:36
mgzrogpeppe: I'll +1, looked at it yesterday11:38
rogpeppemgz: it's changed quite a bit since then11:38
rogpeppemgz: yesterday's didn't actually fix the problem11:38
rogpeppemgz: because we actually need to be able to log in11:39
rogpeppemgz: and the Login method i had fetched the environment config, which failed11:39
rogpeppemgz: so i've refactored things so agent login can be done without doing that11:39
mgz;_;11:39
rogpeppemgz: (which incidentally did simplify things a bit which was nice)11:40
mupBug #1505648 opened: meter-status worker spins if charm doesn't have meter-status-changed hook <logging> <manifold> <uniter> <juju-core:Triaged> <https://launchpad.net/bugs/1505648>11:48
voidspacefrobware: shall I land this branch12:05
frobwarevoidspace, I was just about try / validate on 1.812:06
frobwarevoidspace, give me 30 mins. OK?12:06
voidspacefrobware: sure12:19
frobwarevoidspace, I ran into the replicaset issue too12:26
mattywmgz, ping?12:33
voidspacefrobware: 1.8 or 1.9?12:44
voidspaceor both :-(12:44
frobwarevoidspace, 1.8. third time lucky?? now12:46
voidspacefrobware: did you work out how to get ssh access?12:46
frobwarevoidspace, backdoor access?12:46
voidspaceyeah12:46
frobwarevoidspace, nope :)12:46
voidspaceI'll try hacking cloud init config and ssh into the machine after a failed bootstrap12:46
voidspacethe machine is still running12:46
voidspacefrobware: I'm going to have lunch first12:46
frobwarevoidspace, me too. though the patch seems fine for the combos I have tried on 1.8 and 1.912:47
voidspacefrobware: if it works sometimes that implies a timing issue12:47
voidspaceyeah, odd :-/12:47
frobwarevoidspace, and I tried 1.9 way more12:47
voidspaceannoying12:47
perrito666belated good morning all13:00
mgzmattyw: hey, what's up?13:26
mattywmgz, hey hey - sorry you can ignore me13:27
mattywmgz, I found some docs I could read instead of pestering others :)13:27
mgz:)13:27
mupBug #1505617 changed: juju backup intermittent failure <backup-restore> <canonical-bootstack> <juju-core:New> <https://launchpad.net/bugs/1505617>14:00
mgzbogdanteleaga: wotcha, you around? need to bother you about centos testing14:30
mgzericsnow: also poké, when you have a mo, to talk about reviewboard github persm14:32
ericsnowmgz: k (OTP)14:32
rogpeppemgz: did you forget to publish your review of http://reviews.vapour.ws/r/2878/ ?14:41
mgzrogpeppe: yeah, need to finish that14:47
rogpeppemgz: thanks14:47
mgzrogpeppe: okay, the thing I am hung up on, and why I didn't finish looking through the code yesterday,14:50
mgzis one we've started the server, what's to stop something connecting before all the upgrades have actually happened14:51
mgzthe ordering around this hurts my head14:51
rogpeppemgz: the machine agent has logic in it to stop that14:54
rogpeppemgz: and i agree, it's a pain to reason about and should really be fixed at a more fundamental level14:54
rogpeppemgz: but this at least works around the issue for now and is no worse than what we had before14:55
rogpeppemgz: i think that probably mongo schema upgrades should be treated entirely separately from the other upgrades14:55
rogpeppemgz: but that's too big a change for me to do right now (and it's not really my responsibility to fix old juju tech debt tbh)14:56
mgzrogpeppe: I agree this is better, will plus one and give in to the fact I don't comprehend all of cmd/jujud/agent/14:56
rogpeppemgz: y'know, looking at the code, i'm no longer convinced that it does15:00
mgzehehe ;_;15:01
rogpeppemgz: but again, it's no different to how it was before15:03
mgzrogpeppe: you have reviews.15:04
rogpeppemgz: ta!15:04
voidspacefrobware: this is the /etc/network/interfaces I have15:18
voidspacejuju-dev15:18
voidspace* gberginc has quit (Quit: -sigh-)15:18
voidspacefrobware: http://pastebin.ubuntu.com/12773634/15:18
voidspacea bit weird15:18
voidspaceah15:18
voidspaceauto eth0:115:18
voidspacehas been replaced with "auto juju-br0:1"15:19
voidspacefunnily enough it occured to me that the sed we were using would clobber interface names where the primary interface was *part* of another interface15:19
voidspacedammit15:19
voidspaceok, easy enough to fix and test I think15:19
mattywmgz, here's my yaml migration pr http://reviews.vapour.ws/r/2883/15:20
voidspacedooferlad: ping15:26
mgzmattyw: thanks!15:27
mgzmattyw: anything particularly fun?15:27
mattywmgz, there was one place where yaml setters and getters were changed and I think that reduced line count15:28
mattywmgz, and also there was some validation that just wan't needed anymore15:28
mattywmgz, https://github.com/juju/juju/pull/3490/files#diff-992668ccf77c55eabded974107a15a3bL9415:29
frobwarevoidspace, how did you get it into that state?15:30
mgzmattyw: is it worth wrapping errors from marshal funcs, or will we get enough context anyway?15:30
voidspacefrobware: that's after a fresh bootstrap15:30
voidspacefrobware: for some reason it has an "auto eth0:1" in it initially15:30
frobwarevoidspace, I did not run into that case15:30
voidspacefrobware: were you able to ssh in?15:31
frobwarevoidspace, this through adding additional NICs via MAAS?15:31
voidspacefrobware: that's ssh'ing into the failed bootstrap node15:31
frobwarevoidspace, ah. without your change?15:31
voidspacefrobware: the sed code (pre-existing I might add) badly mangles "ssh eth0:1" into "auto juju-br0:1"15:31
voidspacefrobware: no, that's with my change15:31
mattywmgz, I think we get enough context - but opinions may vary15:32
voidspacefrobware: so I can fix that problem and see if it fixes the replicaset issue15:32
frobwarevoidspace, I never saw that generated with multiple NICs.15:32
voidspacejust bootstrapping now to see if I've fixed it15:32
mattywmgz, for example for long sequences or maps you don't get much feedback15:32
voidspacefrobware: even when bootstrap failed?15:32
mattywmgz, but in the cases I've changed you're likely to know what was input anyway15:32
frobwarevoidspace, the only time I saw bootstrap fail (on 1.9) was when I was not running your branch15:32
frobwarevoidspace, btw - I'm currently running 1.25 in a bootstrap/destroy loop and have not seen the replicaset failure.15:33
voidspacefrobware: with my fix in place I still have an eth0:1, but it isn't mangled by sed15:34
voidspaceso maybe it will work this time15:34
voidspacebootstrap still in progress15:34
frobwarevoidspace, it's not clear to me how you got :1 added15:34
voidspacefrobware: that's the *initial* /etc/network/interfaces that cloud init modifies15:35
voidspaceso it comes from maas15:35
frobwarevoidspace, have not seen that.15:35
voidspaceit has a different address!15:35
voidspacethe machine has two addresses15:35
frobwarevoidspace, two addresses, 1 NIC?15:35
voidspaceyep15:35
frobwarevoidspace, aha. Thought you were getting this on 2 NICs- confused.15:36
voidspaceI have no idea why it is there15:36
voidspacebut it is, and juju is no longer mangling it15:36
voidspacefrobware: so the fix is good I think15:37
voidspacefrobware: I'll push shortly with an extra test15:37
voidspacewell, if the bootstrap works that is...15:37
voidspacenope, same problem15:37
voidspaceso I think this additional interface in /etc/network/interfaces must be the problem15:37
voidspaceI wonder if bootstrapping to a different node, not screwed up, would help15:38
voidspaceI've acquired that node to force maas to pick a different one for bootstrap15:38
voidspacetrying again15:38
frobwarevoidspace, and the new node has an alias too?15:39
voidspacefrobware: don't know - will see shortly15:39
frobwarevoidspace, I just added one to my node... previously I was only concentrating on two NICs.15:39
voidspacefrobware: as far as I can *see* the alias (if that's what it is) isn't defined in virt-manager15:39
voidspaceno idea where it came from15:40
frobwarevoidspace, I added the alias in the MAAS screen15:40
frobwarevoidspace, so I see eth0 and eth0:1 each with their own addrs15:40
voidspaceah, ok - looking at the node in maas15:40
voidspaceah yes, it's there15:40
voidspacefrobware: the other nodes don't have aliases15:41
voidspaceso that's the problem15:41
frobwarevoidspace, but it is a legitimate combo.15:41
voidspacefrobware: well, it is15:41
voidspacefrobware: but it's an existing problem15:41
voidspacelet's fix the reported bug15:41
voidspaceand file a new one for the alias15:41
voidspaceas the current bug is urgent15:41
frobwarevoidspace, fair enough15:42
frobwarevoidspace, but I think we would have to get the new bug fix into 1.25 as well15:42
voidspacethat would depend on priority of that bug :-)15:42
voidspaceI also don't immediately know the right fix15:43
voidspaceI think we would probably need to add bridge_ports to all aliases too15:43
voidspacefrobware: I'll leave the fix to not *mangle* aliases in15:43
voidspaceas it's more correct15:43
voidspaceso I'll write the extra test15:43
voidspacebut that scenario still doesn't work15:44
voidspaceI assume because the alias isn't routable and mongo is picking that address15:44
frobwarevoidspace, agreed to not mangling aliases15:44
voidspacecool15:44
voidspacefrobware: bootstrap just worked15:48
voidspaceso that was it15:48
frobwarevoidspace, if it's obvious I'm inclined to make sure it works with aliases too15:49
voidspacefrobware: it's not obvious to me15:54
voidspacefrobware: but it's *probably* not hard15:54
voidspacelet's land this and I can work on it alongside15:54
frobwarevoidspace, ack15:54
frobwarevoidspace, whilst testing your bits I may have made some progress with addressable containers and macvlan...15:55
voidspacefrobware: latest version pushed15:55
voidspacefrobware: cool15:55
voidspacefrobware: if you fancy a quick look over and giving me a ShipIt I'll land it15:55
frobwarevoidspace, looking and trying now...15:56
voidspaceand then I'll do back/forward ports15:56
voidspacealthough dimitern said he has a simpler fix for 1.2415:56
voidspacenot sure what that is15:56
frobwarevoidspace, heh - the node I'm using is entitled 'elegant-belief'. :)15:57
frobwarevoidspace, I think the simper fix is just 2 invocations of sed. one to replace, one to insert the bridge bits.15:57
voidspaceah, ok15:58
voidspacemaas node names are lovely15:59
voidspaceI'm on imaginative-hose15:59
mattywI wonder which meaning of hose they had in mind15:59
voidspaceheh16:00
voidspaceall of them16:00
frobwarevoidspace, I wonder whether as debug we should $(cat /e/n/i) before and after our mods. At least the former may show up before we nuke any access...16:07
voidspacefrobware: to the client?16:08
frobwarevoidspace, wherever debug goes16:09
voidspacefrobware: I don't think there is any debug output from cloud init16:09
voidspacefrobware: we could save a copy before mangling it16:09
frobwarevoidspace, but this is juju doing this bit16:09
voidspacefrobware: this is cloud init16:10
voidspacefrobware: this is a bash script we send to the machine using cloud init16:10
frobwarevoidspace, oh. I though juju did this in place16:10
voidspaceno, that's why we have to use bash16:10
voidspaceit's not the juju executable doing this16:10
voidspaceit's bash code executed as part of machine setup16:11
frobwarevoidspace, so it could still be logged.16:11
voidspacefrobware: using syslog?16:12
voidspaceit's before there's a juju log file16:12
frobwarevoidspace, cloud-init can log stuff too16:12
voidspaceok16:13
frobwarevoidspace, just to be clear - your latest change is not alias aware, correct?16:13
voidspacefrobware: it has changes to not mangle aliases16:13
voidspacebut it doesn't work with aliases16:13
voidspaceso basically correct, yes16:13
frobwarevoidspace, so no bootstrap possible with aliases (eth0:1)?16:14
voidspacefrobware: that's correct, but it's also correct with trunk16:14
voidspacethe new code is marginally better16:14
voidspaceas trunk code will mangle aliases16:14
frobwarevoidspace, because it does bootstrap OK for me with aliases16:15
voidspacefrobware: no replicaset issue?16:15
frobwarevoidspace, nope. here with aliases: http://pastebin.ubuntu.com/12773981/16:15
voidspacefrobware: deleting the alias solved the replicaset problem for me16:15
voidspacefrobware: using my branch?16:16
voidspacefrobware: right, I guet that output - but bootstrap fails16:16
voidspaceit maybe intermittent16:16
voidspaceit probably depends which address of the two that mongo reports first16:16
frobwarevoidspace, 7a13a40365df2aa5f13572955783a8ac60fb0dd6 Don't mangle aliases16:16
voidspacefrobware: cool16:17
voidspacefrobware: I'll add an alias and try again16:17
voidspacefrobware: in the meantime, care to give me a ShipIt?16:17
voidspaceright, bootstrap in progress16:19
frobwarevoidspace, I added one more alias and it no longer bootstraps for me.16:24
voidspaceheh16:24
voidspacefrobware: really we would want mongo to use the primary interface not the alias16:26
voidspaceso I wonder if that's the real problem here16:26
frobwarevoidspace, so the script output ends up in /var/lib/juju/nonce.txt - so we could add the cat before/after to see what we did...16:27
frobwarevoidspace, correction in /var/log/cloud-init-output.log16:27
voidspaceah, right16:27
voidspacewe don't need after, as that's what's in /e/n/i anyway16:27
voidspacejust before16:27
voidspacewhy the $(cat ...) ?16:28
voidspacewhy not just "cat ..."16:28
frobwarevoidspace, the $(...) was just be delimiting in the written prose...16:29
voidspaceah :-)16:29
frobwarevoidspace, the after is a sanity check if the cloud-init is logged to a console and e/n/i is borked. there's then a chance we could see why.16:30
voidspaceok...16:31
frobwarevoidspace, so your most recent change does handle the alias -- or so it seems to me.16:34
voidspacefrobware: ok, that's good16:35
voidspacefrobware: we can topic it in tomorrow's standup16:35
frobwarevoidspace, added a shipit - do you plan to post any binaries?16:38
voidspacefrobware: I can create some I guess16:39
voidspacewonder where they should go16:39
frobwarevoidspace, http://people.canonical.com/~voidspace16:40
voidspacefrobware: ah16:41
voidspacenever used that...16:41
voidspaceI'll look into it16:41
voidspaceheh, 40416:42
frobwarevoidspace, nor me. I just saw dimiter publish some stuff there the other day... not sure I can login atm.16:42
frobwarevoidspace, I think you first need to create public_html16:42
voidspaceright16:42
voidspaceI'll look into it in a bit - some exercise first16:42
voidspaceI've set my branch to land on 1.2516:42
mgzvoidspace: you can (with vpn or chinstrap) scp to lillypilly.canonical.com:~/public_html16:42
mgzthough it likes scri16:43
voidspacemgz: thanks16:43
mgz..screwing up file persm so you have to ssh in to make apache like it anywa16:43
voidspaceheh, right16:43
natefinchericsnow: anything I can do to help?16:46
ericsnownatefinch: I don't think so16:47
ericsnownatefinch: you could look through the TODOs in that PR16:47
natefinchericsnow: the LXD PR?16:47
frobwarevoidspace, you still there?16:48
frobwarevoidspace, this worked for me: ssh -i ~/.ssh/id_launchpad_rsa people.canonical.com16:48
ericsnownatefinch: yeah, that would help, but I was thinking of the list-payloads one (which probably doesn't actually have many TODOs)16:48
voidspacefrobware: cool, thanks16:49
frobwarevoidspace, you'll need to be on the VPN16:49
natefinchericsnow: sure, I can look at that one. Probably have a better base of knowledge for it anyway.16:49
voidspacefrobware: bootstrap with an alias just worked for me too16:50
frobwarevoidspace, it seems a nice by product of the \s* sed/grep match16:50
voidspaceyeah16:51
voidspacenot mangling things is generally good...16:51
frobwares/nice/natural <shrug>16:51
voidspace:)16:51
frobwarevoidspace, we're just waiting for that to merge in 1.25, correct?16:52
voidspaceyep16:52
voidspacethen porting to master16:52
frobwarevoidspace, if so could you update the bug report so at least everybody knows current status. thx.16:52
voidspaceand maybe 1.24 depending on if dimiter prefers his fix16:52
voidspaceyep16:52
voidspacefrobware: updated, really going now16:54
frobwarevoidspace, me too. thanks!16:54
natefinchericsnow: I don't really see any super important todos that need to get done for that code.  Mostly just nice-to-haves and/or open questions.16:54
ericsnownatefinch: k16:55
natefinch(that code = payloads list)16:55
ericsnownatefinch: perhaps catalog what tests are missing?16:55
natefinchericsnow: good idea16:55
natefinchericsnow: I started doing the list as another review of the code, but would it be more useful in textual form?  So we could put it in a card and anyone could work on it/17:04
ericsnownatefinch: sgtm17:12
katcoericsnow: wwitzel3: time to start again17:37
=== coreycb` is now known as coreycb
ericsnowwwitzel3: FYI, my list-payloads patch works now20:35
thumperdooferlad: ping20:47
cheryljHey davechen1y, are you actively working on bug 146531721:14
mupBug #1465317: Wily osx win: panic: osVersion reported an error: Could not determine series <osx> <packaging> <wily> <windows> <juju-core:In Progress by dave-cheney> <juju-core 1.24:Triaged> <juju-core 1.25:Triaged> <juju-release-tools:Fix Released by sinzui> <https://launchpad.net/bugs/1465317>21:15
thumpercherylj: what's the concern with http://reviews.vapour.ws/r/2868/21:22
cheryljthumper: look at http://reviews.vapour.ws/r/2854/21:23
thumperlooking there now actually21:23
* thumper thinks21:23
wwitzel3ericsnow: awesome, will check it out now21:24
mattywthumper, while we happen to be in the same place (irc) at the same time (now) have you seen rog' email on juju-dev about the user names local domain stuff, and do you have any problem with it?21:50
thumperno, not seen it yet21:50
thumperso no comment21:50
mattywthumper, ok, I figured that might be the case, just wanted to check21:52
mattywthumper, it's no particularly urgent21:52
* thumper headdesks22:11
thumpertwo hours at work and it has started already22:12
thumperFFS22:12
mgzno, no, the poor desk22:12
mgzmattyw: reviewed your branch earlier btw22:13
mattywmgz, I saw, thanks very much22:13
mattywmgz, I'm saving the work until tomrrow22:13
mattywmgz, something to look forward to22:13
mgz:D22:14
thumpercherylj: you were right to be concerned about the flslock changes22:14
* thumper brings up a juju/utils branch22:14
mgzthumper: my argument was we just want to do what bzr used to, which is `kill -0 pid`22:15
mgzwhich approximately works everywhere22:15
thumperwhat is that?22:15
mgzjust check if the pid in the lock is alive22:16
mgzno fancy stuff22:16
thumperkill works on windows?22:17
thumperI do agree, no fancy stuff22:17
mgzthere's a very similar equivalent with TerminateProcess22:17
thumpersurely there is a way to get Go to tell us about a pid22:17
thumperimplicit breaking of a lock is bad IMO22:18
thumperthere are better ways22:18
mgzI agree just using a better lock primative would be better regardless22:19
thumperhttp://stackoverflow.com/questions/15204162/check-if-a-process-exists-in-go-way22:22
thumpermgz: this does what you said the Go way22:22
mgzthumper: looks like we'd actually want x/sys/unix Kill22:23
thumperno, because windows22:23
mgzI have doubts process.Signal does the right thing on windows22:24
thumperI'll write a test and check :-)22:24
* thumper goes to walk the dog to clear thinking22:46
wallyworldperrito666: anastasiamac: running a bit late23:15
anastasiamacwallyworld: k. ping when ready :D23:15
perrito666wallyworld: ack23:15
davechen1yis anyone on call reviewer today ?23:21
perrito666davechen1y: I still am23:21
perrito666at least in my tz23:21
* perrito666 shifted his day a bit to the right23:22
davechen1yhttp://reviews.vapour.ws/r/2881/23:22
davechen1yhttp://reviews.vapour.ws/r/2880/23:22
davechen1yif you have time please23:22
perrito666davechen1y: syre23:22
perrito666sure23:22
wallyworldanastasiamac: here now23:26

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!