| mup | Bug #1506680 opened: `juju environments` fails due to missing ~/.juju/current-environment <juju-core:New> <https://launchpad.net/bugs/1506680> | 00:10 |
|---|---|---|
| davechen1y | thumper: final version.Current PR is up for review | 00:15 |
| === wgrant is now known as Guest27601 | ||
| === thumper is now known as Guest68941 | ||
| === Guest68941 is now known as thumper | ||
| thumper | wallyworld: heading out for a quick dog walk before the rain comes in | 00:58 |
| wallyworld | ok | 00:58 |
| wallyworld | ping when you are free | 00:58 |
| === Guest27601 is now known as wgrant | ||
| thumper | wallyworld: there now | 01:39 |
| wallyworld | ok | 01:39 |
| natefinch | ericsnow: how goes? | 02:23 |
| rogpeppe | mgz: ping | 06:55 |
| wallyworld | fwereade: i reverted the change omit series, could you PTAL http://reviews.vapour.ws/r/2888/ | 08:59 |
| fwereade | wallyworld, cheers | 08:59 |
| fwereade | wallyworld, LGTM, thanks | 09:02 |
| wallyworld | tyvm | 09:02 |
| dooferlad | fwereade, jam: hangout? | 09:03 |
| voidspace | dimitern: looks like they took a different approach in maas - they didn't go with device_type in the end | 09:22 |
| voidspace | dimitern: so that card can be deleted | 09:22 |
| voidspace | dimitern: https://bugs.launchpad.net/maas/+bug/1490637 | 09:22 |
| mup | Bug #1490637: Devices with parents should not show on devices tab <MAAS:Fix Committed by blake-rouse> <https://launchpad.net/bugs/1490637> | 09:22 |
| voidspace | dimitern: they just decided to use the presence of a parent instead | 09:22 |
| voidspace | dimitern: so I can delete my branch.... | 09:22 |
| dooferlad | TheMue: so, the lock problem. | 09:28 |
| dimitern | voidspace, it sounds like a mess that they need to fix :) | 09:28 |
| voidspace | dimitern: yeah, weird | 09:30 |
| voidspace | dimitern: I've added a comment to the issue and will ping them about it | 09:30 |
| TheMue | dooferlad: yes, let's unlock it | 09:30 |
| * dooferlad groans | 09:31 | |
| TheMue | dooferlad: the scope is always only the local node? | 09:32 |
| dimitern | voidspace, cheers | 09:32 |
| dooferlad | TheMue: yes | 09:32 |
| dooferlad | https://github.com/golang/go/issues/2307 is background on the Windows socket behaviour | 09:32 |
| TheMue | dooferlad: so surely a state based solution is nice, but not needed? | 09:32 |
| dooferlad | TheMue: using state would fix the problem, yes | 09:33 |
| dooferlad | TheMue: it is our single source of truth | 09:33 |
| TheMue | dooferlad: as we just said, state would help, but not solve it if a process/node dies and the lock stays in state | 09:34 |
| dooferlad | TheMue: state would notice that the connection died though, right? That could be an even to unlock. | 09:34 |
| dooferlad | TheMue: actually, it looks like the socket code on Windows should only allow one connection now. | 09:35 |
| dooferlad | TheMue: | 09:35 |
| TheMue | dooferlad: a, you would check, if a connection between a node and state exists? not the data in state in a collection? | 09:35 |
| TheMue | dooferlad: I thought the whole time of a lock collection with records containing node, handle, and lease time | 09:36 |
| dooferlad | TheMue: you would store the lock data in the collection, but you could validate it against if the thing that created the lock still exists | 09:36 |
| TheMue | dooferlad: and processes use their node and handle to check if the lease time is passed off or not | 09:37 |
| dooferlad | TheMue: but I don't want to do anything lock related in state because adding more logic to state unless we have a good future use case. | 09:38 |
| dooferlad | And we don't have a lease time. There is no need. | 09:38 |
| TheMue | dooferlad: how would you validate if the creator still exists? | 09:38 |
| dooferlad | We have connections to state open to update state from machines. | 09:38 |
| dooferlad | We just see if the connection that created the lock is still there | 09:39 |
| dooferlad | but, it involves a network, so no, don't do that | 09:39 |
| TheMue | dooferlad: many distributed solutions I've looked for use lease times. we could create this lock as a util type, it will find it's usage ;) | 09:39 |
| dooferlad | Doing this right over a network turns into a distributed consensus algorithm | 09:39 |
| dooferlad | at which point we have implemented etcd to replace a file lock | 09:40 |
| dooferlad | so lets not | 09:40 |
| dooferlad | On Linux we could use /tmp to ensure our locks don't exist across reboots (yay!) and on Windows we can use the file attributes FILE_ATTRIBUTE_TEMPORARY and FILE_FLAG_DELETE_ON_CLOSE (see https://en.wikipedia.org/wiki/List_of_RAM_drive_software#Native) to achieve about the same thing | 09:44 |
| dooferlad | that solves all my problems. | 09:44 |
| dooferlad | apart from delete_on_close doesn't look right | 09:46 |
| dooferlad | arg | 09:46 |
| dooferlad | https://github.com/natefinch/npipe maybe is the best way to go on Windows | 09:47 |
| TheMue | dooferlad: hmmm, ok, not yet really sure | 09:49 |
| dooferlad | TheMue: maybe I just move the file locks to /tmp on Linux and leave the rest. It would be enough to get the MAAS and EC2 tests passing and since we don't do container init on Windows (or run those tests) then problem solved. | 09:50 |
| dooferlad | TheMue: the need for the lock then goes away once we are down to 1 juju process and we all celebrate. | 09:50 |
| dooferlad | TheMue: (well, when that happens) | 09:50 |
| * dooferlad needs a cup of tea. Back in 5 | 09:51 | |
| fwereade | mattyw, tasdomas: as people who've used the dependency engine: I have a use case for injecting an engine into itself, and am having naming troubles | 09:59 |
| mattyw | fwereade, ah naming, one of the solved problems | 09:59 |
| fwereade | mattyw, tasdomas: currently exposed as InceptionManifold, which is not really accurate, but is a useful indicator of the presence of weirdness | 09:59 |
| fwereade | mattyw, tasdomas: a more accurate nname would be OurobourosManifold but that's, er, a bit obscure | 10:00 |
| fwereade | mattyw, tasdomas: thoughts appreciated :) | 10:00 |
| tasdomas | fwereade, RecursiveManifold ? | 10:01 |
| mattyw | fwereade, -1 to inception | 10:01 |
| mattyw | tasdomas, fwereade, I was just typing exactly that! | 10:01 |
| tasdomas | fwereade, I don't really care for names as long as they are not misleading | 10:01 |
| tasdomas | fwereade, a rose by any other name.. | 10:01 |
| fwereade | tasdomas, there's quite a lot of subtlety embedded in "so long as they are not misleading" ;) | 10:02 |
| tasdomas | fwereade, well, in my case misleading would be calling it SimpleManifold | 10:02 |
| fwereade | tasdomas, it *is* actually pretty simple ;p | 10:03 |
| fwereade | tasdomas, (but point taken all the same) | 10:03 |
| tasdomas | fwereade, there's no such thing as a simple manifold | 10:03 |
| tasdomas | ;-] | 10:03 |
| * fwereade has a sad now | 10:03 | |
| fwereade | ;p | 10:03 |
| fwereade | hm, maybe it would be best to just have an `Engine.InstallSelf(name string) error` method? and unexport the manifold itself except for tests? | 10:06 |
| fwereade | ...but then the InstallSelf tests end up yucky and arms-lengthy in a bad way | 10:08 |
| fwereade | SelfManifold? | 10:08 |
| fwereade | mattyw, tasdomas: ^^ | 10:08 |
| mattyw | fwereade, self is fine | 10:09 |
| mattyw | fwereade, but document it | 10:09 |
| fwereade | mattyw, cheers | 10:11 |
| fwereade | mattyw, http://reviews.vapour.ws/r/2916/diff/# -- adequately documented? | 10:26 |
| mattyw | fwereade, a proper review will come later | 10:38 |
| mattyw | fwereade, but for now the documentation seems fine | 10:38 |
| mattyw | fwereade, and given the actualy implementation i really like SelfManifold as a name | 10:38 |
| fwereade | mattyw, cool, thanks :D | 10:38 |
| fwereade | mattyw, don't feel obliged to do a full review, the implementation remains unchanged from when thumper LGTMed it | 10:39 |
| mattyw | fwereade, ok cool, good enough for me | 10:39 |
| fwereade | mattyw, tyvm | 10:39 |
| mattyw | fwereade, I'm having one of those days where I'm chasing shiny things instead of doing the stuff I'm supposed to | 10:39 |
| fwereade | mattyw, haha, sorry to contribute to that | 10:39 |
| mattyw | fwereade, no problem - shiny == awesome | 10:39 |
| mattyw | mgz, are you around? | 13:17 |
| mgz | mattyw: hey | 13:20 |
| mattyw | mgz, just pushing an update to the yaml branch | 13:22 |
| mattyw | mgz, it looks like we can get rid of that weirdness | 13:22 |
| mattyw | mgz, but I'm not full of confidence as I still don't really understand why it was there | 13:22 |
| mgz | mattyw: jw4's comment is bug 1436871 | 13:26 |
| mup | Bug #1436871: ppc64 gccgo fails to build cmd/juju <ci> <ppc64el> <regression> <juju-core:Fix Released by johnweldon4> <https://launchpad.net/bugs/1436871> | 13:26 |
| mgz | if it builds with both go and the version of yaml we're using, and gccgo, there's nothing left to worry about | 13:27 |
| mattyw | mgz, can I test that somehow? | 13:27 |
| mgz | yeh,or I can. install gccgo on trusty and build with -compiler gccgo | 13:28 |
| mattyw | mgz, it's here if you want to try it | 13:30 |
| mattyw | mgz, I'll see if I'm setup to do it as well | 13:30 |
| mgz | seems to build | 13:34 |
| mgz | of course, looking at the bug it did for me last time too, but I *think* this was a short-lvied bug in the packages | 13:34 |
| mgz | we'll find out for certain when it gets merged anyway | 13:34 |
| mattyw | mgz, maybe I could channel rogpeppe | 13:34 |
| * rogpeppe 's ghost appears | 13:35 | |
| rogpeppe | mattyw: that bug resulted in some quite weird things happening | 13:36 |
| rogpeppe | mattyw: best to definitively check that it works properly before renaming those types | 13:36 |
| mgz | spooky! | 13:36 |
| mattyw | rogpeppe, how would I check that? | 13:38 |
| mattyw | rogpeppe, are you the ghost of bugs yet to come? | 13:38 |
| rogpeppe | mattyw: you'd write a little piece of test code | 13:38 |
| mattyw | rogpeppe, test code - that's an odd concept | 13:39 |
| rogpeppe | mattyw: more like the ghost of your fetid past | 13:39 |
| rogpeppe | mattyw: i'm not thinking of an actual test | 13:39 |
| rogpeppe | mattyw: just a standalone program to check current behaviour | 13:40 |
| rogpeppe | mattyw: tell you what, i'll do one if you want | 13:40 |
| mattyw | rogpeppe, make sure you send me the code, and show me how to run it | 13:42 |
| mattyw | rogpeppe, it's the only way I'll learn | 13:42 |
| rogpeppe | mattyw: ironically it appears that the yaml bug was actually fixed 2 hours before i committed that juju comment | 13:54 |
| mup | Bug #1506865 opened: Failed to retry tools download after EOF <bootstrap> <reliability> <retry> <upgrade-juju> <juju-core:Triaged> <https://launchpad.net/bugs/1506865> | 13:54 |
| mup | Bug #1506869 opened: TestNewServerDoesNotAccessState api connection failure <i386> <test-failure> <unit-tests> <windows> <juju-core:Incomplete> <juju-core chicago-cubs:Triaged> <https://launchpad.net/bugs/1506869> | 13:54 |
| rogpeppe | mattyw: here's my test code | 13:54 |
| rogpeppe | mattyw: http://paste.ubuntu.com/12798941/ | 13:54 |
| mattyw | rogpeppe, thanks very much | 13:54 |
| rogpeppe | mattyw: the yaml commit that fixed the bug was 4d6bb54d8acc91e147763cea066cff0b89437e90 | 13:54 |
| mattyw | rogpeppe, you're welcoe to review the pr if you want | 13:55 |
| mattyw | rogpeppe, http://reviews.vapour.ws/r/2912/ | 13:55 |
| rogpeppe | mattyw: this was the important piece of the diff: http://paste.ubuntu.com/12798949/ | 13:56 |
| rogpeppe | mattyw: have you run the status tests on that branch? | 13:57 |
| mattyw | rogpeppe, I have | 13:57 |
| rogpeppe | mattyw: hmm, weird, i wonder why you don't get an infinite loop | 13:57 |
| mattyw | rogpeppe, I've not run cmd/juju/... yet - in hangouts | 13:57 |
| rogpeppe | mattyw: try running the status tests in cmd/juju/status | 13:58 |
| mattyw | rogpeppe, I've run all of those | 13:58 |
| rogpeppe | mattyw: interesting. I think that exposes a bug in goyaml actually | 14:02 |
| rogpeppe | mattyw: what would you expect this to print? http://paste.ubuntu.com/12799013/ | 14:02 |
| mattyw | rogpeppe, shall I read it and guess or you want me to run it? | 14:03 |
| mattyw | rogpeppe, (in our planning meeting now so sort of distracted I'm afraid, many apologies) | 14:04 |
| rogpeppe | mattyw: first guess, then run | 14:04 |
| mattyw | rogpeppe, I guessed and ran | 14:09 |
| mattyw | rogpeppe, and now I'm confused | 14:10 |
| rogpeppe | mattyw: the answer it gave is the reason your change doesn't cause infinite recursion | 14:10 |
| rogpeppe | mattyw: https://github.com/go-yaml/yaml/issues/134 | 14:16 |
| rogpeppe | mattyw: reviewed http://reviews.vapour.ws/r/2912/ | 14:19 |
| mattyw | rogpeppe, thanks, see martins previous comment regarding omitempty | 14:20 |
| rogpeppe | mattyw: ah, ok i see about the omitempty. i guess it's best not to mess with the output. | 14:24 |
| mup | Bug #1506881 opened: 1.22 client cannot talk to chicago-cubs server <api> <regression> <juju-core:Incomplete> <juju-core chicago-cubs:Triaged> <https://launchpad.net/bugs/1506881> | 14:30 |
| mattyw | rogpeppe, mgz and again http://reviews.vapour.ws/r/2912 | 15:11 |
| mattyw | rogpeppe, I'll be back in 10 though | 15:12 |
| dimitern | voidspace, ping | 15:24 |
| dimitern | voidspace, if you're still around, you might be interested in what I came up with for the juju-br0 script | 15:32 |
| === tych0- is now known as tych0 | ||
| dimitern | voidspace, it turned out not quite as simple as I imagined (~200 lines of bash), but handles properly the IPv4/IPv6/both cases as well as aliases, and it's more resilient towards failures (reverts changes back so you can ssh later and diagnose) | 15:33 |
| dimitern | voidspace, anyway - here it is: http://paste.ubuntu.com/12799841/ (still testing a few cases though) | 15:34 |
| * dimitern really wants at this point to do all these steps in Go and inject a simple binary that does all and can be easily tested in isolation | 15:34 | |
| dooferlad | dimitern: I am amazed we don't insist on Python being installed for these things :-| | 15:37 |
| dimitern | dooferlad, it's about time :) | 15:39 |
| dimitern | dooferlad, the issue in this specific case is the script is run very early, before packages are installed (well, we could change the cloud images to include python always - it might be so already in fact) | 15:40 |
| dooferlad | dimitern: indeed. I would check that. | 15:40 |
| dimitern | dooferlad, yeah - good idea - check a pristine trust amd64 image deployed from maas as well as "lxc-create -t ubuntu-cloud" - as lxc images might be different (same applies to KVM I guess, but I suspect the use the same images as maas) | 15:42 |
| * dimitern pats himself on the back :D in all those ~200 lines of bash (in a go string) - so far only 2 syntax issues (apart from a panic from unmatched "}" in the template) | 15:45 | |
| mgz | mattyw: you still seem to comflict with my (landed) change that scrubs subnets | 15:53 |
| mattyw | mgz, let me wave my rebase wand | 15:53 |
| dooferlad | mattyw: you can get a wand for that? Ohh. | 15:54 |
| mattyw | mgz, should be better now | 15:56 |
| mattyw | dooferlad, wand didn't work, had to use keyboard | 15:57 |
| dooferlad | mattyw: boo | 15:57 |
| mattyw | tough crowd | 15:57 |
| mgz | mattyw: shipit | 15:58 |
| mgz | if it blows up on ppc we'll find out and can add back the hack | 15:59 |
| mgz | yak sack | 15:59 |
| mup | Bug # changed: 1335885, 1373516, 1435283, 1465844, 1478156, 1489477, 1492066, 1493123, 1494070, 1494542, 1495338, 1496639, 1496750, 1497094, 1498746, 1500613 | 16:36 |
| voidspace | dimitern: pong | 17:20 |
| voidspace | dimitern: wow | 17:20 |
| natefinch | sweet, just got my new code keyboard. Gonna take a little getting used to, but the difference from my old keyboard is crazy. | 17:59 |
| katco` | natefinch: i expect 50.02% more productivity from you. | 18:00 |
| natefinch | katco`: of course ;) | 18:01 |
| perrito666 | katco`: which part of the .el for emacs is the one that makes the editor remind me that exported functions should have docs? | 18:03 |
| katco` | perrito666: lol dunno if golint does that or not | 18:05 |
| natefinch | golint does | 18:05 |
| perrito666 | katco`: something is doing it in the conf you passed to me :p I am just trying to understand lol | 18:06 |
| katco` | perrito666: flycheck does things on the fly, so it's probably just running golint every time the buffer changes or something | 18:07 |
| katco` | perrito666: i'm sure it has some kind of smarter algo, but that's the just of it | 18:07 |
| natefinch | katco`: is there anything to do to get the payloads stuff in? ericsnow says it merges just fine... do we do a PR, or what? There's no process written down in the wiki. | 18:39 |
| katco` | natefinch: the CI test to bless it is currently 50% complete | 18:42 |
| natefinch | katco`: sweet | 18:42 |
| katco` | natefinch: then i think we just propose a merge against 1.25 and do the merge | 18:42 |
| natefinch | wow, glad I got the "quiet" mechanical keyboard. Geez. | 19:11 |
| perrito666 | natefinch: lol, I thought you had one of those before | 19:12 |
| natefinch | perrito666: nope. My last keyboard was expensive only because it was wireless and solar powered, not due to the quality of the typing experience. | 19:13 |
| perrito666 | solar powered, really? what a strange feature for a kb | 19:13 |
| natefinch | perrito666: never need to charge or change batteries | 19:14 |
| jcastro | natefinch: I have a Code! | 19:14 |
| perrito666 | natefinch: my kb never sees the light of day | 19:15 |
| perrito666 | the window is behind two monitors | 19:15 |
| natefinch | jcastro: yeah, just got mine, love it. the lights are so perty | 19:15 |
| perrito666 | natefinch: pic | 19:16 |
| natefinch | perrito666: http://imgur.com/c7H33c0 | 19:24 |
| * natefinch carefully crops out his messy desk | 19:24 | |
| perrito666 | sure, all of us that have very neat desks will be incredibly offended by it :p | 19:26 |
| perrito666 | that is one sexy keyboard | 19:26 |
| perrito666 | I want it | 19:26 |
| natefinch | it is wicked sexy... didn't even realize it had media keys until I saw them in that picture ;) | 19:27 |
| mup | Bug #1506994 opened: deploy unit can fail after creating a machine but before assigning unit to it <juju-core:New> <https://launchpad.net/bugs/1506994> | 19:28 |
| natefinch | keyboard backlight has adjustable brightness, too, which is nice - it goes pretty bright. | 19:28 |
| mup | Bug #1506994 changed: deploy unit can fail after creating a machine but before assigning unit to it <juju-core:New> <https://launchpad.net/bugs/1506994> | 19:31 |
| mup | Bug #1506994 opened: deploy unit can fail after creating a machine but before assigning unit to it <juju-core:New> <https://launchpad.net/bugs/1506994> | 19:34 |
| mup | Bug # changed: 1463053, 1463922, 1469844, 1471657, 1471936, 1487191, 1499573 | 19:58 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!