/srv/irclogs.ubuntu.com/2015/10/21/#juju-dev.txt

cheryljthanks, wallyworld.  Given that we want 1.25.0 asap, do you think it could reasonably be done soon?  or should we aim for it in 1.25.1?01:04
wallyworldcherylj: it can go in 1.25.1 - it's been broken for a while AFAIK. so let's not hold up 1.25 for it, but i'd like to think 1.25.1 will appear not too long after01:05
cheryljwallyworld: sounds good, thanks!01:05
lazyPower:O01:09
lazyPowerupdate-status hook isn't a myth!01:09
perrito666lazyPower: it better not01:15
perrito666we should settle for one of the englishes in the code01:15
lazyPowerperrito666, i heard about it in seattle, but called schenanigans01:16
lazyPoweri'm on a build of 1.25-beta2 and its in here01:16
perrito666grep -ri authorized | wc -l01:16
perrito66699701:16
perrito666grep -ri authorised | wc -l01:16
perrito66620001:16
perrito666lazyPower: it better be, I put it there01:16
thumperperrito666: english vs american01:55
perrito666thumper: they both sound foreign to me :p01:56
thumper:)01:56
natefinchpretty sure America invented English01:58
perrito666My brain reads juju comments and code with the BBC narrator voice so I presume it is uk version :p01:59
natefinchlol01:59
perrito666ok brain coredumped, see some of you tomorrow02:06
axwdpb1: don't suppose you still have the env for https://bugs.launchpad.net/juju-core/+bug/1491688? and can I get access? I haven't had any luck reproducing it, and the logs aren't very illuminating02:39
mupBug #1491688: all-machine logging stopped, x509: certificate signed by unknown authority <landscape> <logging> <rsyslog> <sts> <juju-core:Triaged> <juju-core 1.24:In Progress by axwalk> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1491688>02:39
thumperaxw: I have that locally with 1.24.602:53
axwthumper: orly? did you have to do something special?02:54
thumperstart two local providers02:54
thumperit fucks up all the logs02:54
thumperit used to work02:54
axwinteresting02:54
axwI'll try that02:54
thumperthe lxd provider will fix this...02:55
* thumper can't wait02:55
natefinchwe should just warn people about the problems of running more than zero local providers02:55
axwthumper: pretty sure LS is using MAAS though...02:55
thumperyeah...02:55
natefinchand yes, the lxd provider is amazing02:55
thumperI'm guessing that this isn't necessarily the same problem02:55
axwI want it nowwwww02:55
natefincha little slow, though02:55
thumpernatefinch: plz make tools work properly with local streams02:55
thumperslow02:56
thumper?02:56
axwnatefinch: the OpenStack on LXD demo wayne did was pretty sweet02:56
thumperagreed02:56
natefinchbootstrapping takes like twice as long as the local provider02:56
natefinchaxw: yeah, that demo was pretty killer02:56
natefinchhonestly, just bootstrapping without it asking for a sudo password kind of rocks my world... not to mention the fact it doesn't crap all over my local machine02:57
thumpernatefinch: hah...02:57
thumperwell that isn't really surprising02:57
thumperlocal bootstrap isn't starting a machine02:57
natefinchright02:57
thumperit is just shitting on our local machine02:57
natefinchwhat amazed me the most was how easy it was to write the provider.  They really did well with lxd02:58
dpb1axw: I don't, and it wasn't seen with doing anything funky (like two local providers).  But, if you all can't repro, I totally understand (I certainly can't at will).  I've seen it a total of twice.03:07
axwdpb1: ok, no worries. I'll keep looking anyway03:08
natefinchwhat's the right way to convert from a unit ID to a unit tag?  I'm getting unit ids back from a strings watcher and I've been told I have to pass Tags through the API.03:22
natefinchnames.NewUnitTag looks likely, but it panics if I pass it an invalid id (which is gobsmackingly horrible, btw)03:23
* thumper looks03:24
thumpernatefinch: what do you have?03:24
thumperservice/3 ?03:24
natefinchyeah03:24
thumpernames.NewUnitTag should work03:25
* thumper looks at the tests03:25
natefinchbut it panics... which means I have to check the ids before I pass it into the function, and then that function itself rechecks the ids, which is dumb03:25
thumpernatefinch: c.Assert(names.NewUnitTag("wordpress/2").String(), gc.Equals, "unit-wordpress-2")03:25
thumperyes, you have to check03:25
thumpernames.IsValidUnit03:26
thumperall the New*Tag methods panic on invalid input03:26
natefinchthat's horrible03:26
thumperbecause they are generally used where checking errors is a PITA03:26
thumperno... it is a valid pattern03:26
thumpermost places, you know you are dealing with valid names03:26
thumpersometimes, like user input, you need to validate03:27
natefinchit's a house of cards waiting for someone to feed the wrong string into the wrong function at some point and the whole thing blows up in production because someone didn't want to check an error.03:28
thumperI disagree03:28
thumperbut I can see your point of view03:28
natefinchditto :)03:28
thumperso...03:28
thumpergiven that you have a valid unit name, why is it failing?03:29
thumperperhaps you don't have what you think you have03:29
natefinchI'mwriting an api client.  It takes a list of strings it hopes are ids. It shouldn't assume someone's not going to do the wrong thing03:29
* thumper looks at unit id03:29
thumperagreed, the client (and the server) need to validate03:30
natefinchfor example, my test passed in an invalid id, and the code panicked.  Sure, I could not do that, but that seems silly03:30
thumperright, so validate03:31
natefinchright03:31
thumperIIRC the general use case for creating tags using the New*Tag methods was tests03:32
thumperat the time they were written03:32
thumperand panicing in tests is fine03:32
thumperperhaps we should create a new class of functions03:32
thumperthat validate and return (tag, error)03:32
thumperhowever, the line count will be approx the same as currently03:33
natefinchit just irks me to call IsValidUnit twice03:33
thumperit is my expectation that if I'm calling a function that doesn't return an error, I should check theinput03:33
thumperyou don't03:33
thumperdo you?03:33
natefinchI assume a function that doesn't return an error can't fail03:34
thumperwell...03:34
thumperor it panics03:34
thumperbecause Go03:34
natefinchwell... except that in general you never panic unless THE WORLD HAS COME TO AN END.  Not because johhnny passed in "foo"03:34
natefinchso, I don't call IsValidUnit twice, but I call it once and then NewUnitTag calls it once03:35
thumper/ NewUnitTag returns the tag for the unit with the given name.03:35
thumper/ It will panic if the given unit name is not valid.03:35
natefinchtrivia - the panic was added on the day I joined canonical (though not by me)03:36
thumper:)03:36
thumpermagic03:36
natefinchAnd yes, I am glad that the comment states it panics. That's at least better than blindsiding someone.03:37
thumperboo yeah - have a panic03:38
thumpernot as nice as a picnic03:38
thumperbut close enough03:38
natefinchha03:39
axwwallyworld: I really don't know what's up with the rsyslog bug. I can't reproduce it, and injecting errors into the rsyslog worker shows that it does recover from errors writing certs to state03:46
axwwallyworld: rsyslog looks unhealthy in the env, because it's repeating machine-0's logs in all-machines.log03:47
wallyworldaxw: hmmm. mark as incomplete and ask for steps to repro? or access to an env with the problem so it can be investigated03:47
axwwallyworld: ok03:47
wallyworldty for looking03:47
axwmenn0: what ever happened to the logging-in-state feature branch? is that still happening?03:49
menn0axw: it's been merged for a long time03:52
menn0axw: but it's still behind a feature flag03:53
axwmenn0: ah03:53
axwmenn0: any particular reason why it's not enabled by default?03:53
menn0axw: it also gets activated if the "jes" feature flag is turned on03:53
axwI see03:53
axwmenn0: so it will be soon then I guess?03:53
menn0axw: to be honest, I don't know when03:53
axw(on by default)03:53
axwmk03:54
menn0axw: some people had concerns about logging to mongodb03:54
menn0axw: performance related mainly03:54
menn0axw: let me bring it up on the list03:54
thumpermenn0: I don't think it is in 1.24 is it?03:58
wallyworldaxw: small corner case fix please http://reviews.vapour.ws/r/2955/03:58
* menn0 checks04:01
menn0thumper, axw: it's in 1.25 but not 1.2404:04
menn0there's bits of it there in 1.24 but it wasn't complete nor wired in at that stage04:05
axwmenn0: ok. was mainly just curious what the plan was for enabling it04:05
axwthanks04:05
menn0axw: I'll email the list about getting it turned on by default for 1.2604:06
natefinchmenn0: do we need the EnvUUID field in new mongo docs?  William said in a review that he thought we didn't, but to check with you.04:09
menn0natefinch: no they're not necessary any more04:10
menn0the multi-env DB layer will automatically add them04:10
menn0I have a personal tech debt item to go and remove them from all our structs (and all the place they're set)04:11
menn0even if a document struct has an EnvUUID field you can just leave out setting it in the code that creates them04:11
menn0it'll still get added04:11
menn0 /populated04:11
natefinchmenn0: thanks04:21
menn0natefinch: np04:24
menn0natefinch: let me know if you find that any aspect of this doesn't work how I've just described04:24
natefinchmenn0: will do04:25
wallyworldaxw: with the test it would be either a big cut and paste or a bit of refactoring all for a corner case where the method being used is tested extensively elsewhere. i can do it if you insist :-)04:37
wallyworldaxw: another small one sorry http://reviews.vapour.ws/r/2956/04:48
frobwaredimitern, running 10 mins late...06:57
dimiternfrobware, that's ok, I'm finishing my HW list here, will join ~5m07:03
=== urulama is now known as urulama|afk
=== urulama|afk is now known as urulama
dooferladdimitern: hangout?09:02
dimiternomw09:02
voidspacedimitern: frobware: I see that AWS "space discovery" is still listed as a deliverable, even after our conversation with William last week when we said it shouldn't be done09:34
dimiternvoidspace, that depends on "shared spaces by default" or not09:44
voidspacedimitern: yes, and the agreement in discussion with fwreade was that we should *not* do shared spaces by default09:45
voidspacedimitern: because of the unnecessary pain that it brings09:45
dimiternvoidspace, I know, but that's not approved yet by jam or rick09:45
dimiternvoidspace, I'd like it if we don't share by default, but mark seemed keen on the idea09:46
voidspacedimitern: listing it as a deliverable seems like a bad idea (very)09:47
voidspaceyou're boxing us into a corner09:47
dimiternvoidspace, even if we go with "not shared by default", there is still value in having discover + filters09:49
voidspacedimitern: how is discover different from list then?09:49
dimiternvoidspace, discover lists spaces which are pre-existing on the cloud, but not yet known to (or usable by) juju09:50
voidspacedimitern: but if you don't have shared spaces then there won't be pre-existing spaces09:51
dimiternvoidspace, i.e. you can import these (idempotently)09:51
voidspacebecause as soon as you can share spaces (import them) then the can of worms is open09:51
voidspaceand you can't delete / rename them or move subnets09:51
dimiternvoidspace, well, "not sharing by default" does not exclude "being able to share spaces at all"09:51
voidspacewhich is why we agreed not to do it09:52
dimiternvoidspace, how about openstack, azure?09:56
dimiternvoidspace, for maas "shared by default" and "no creation" is clear09:56
voidspacedimitern: I'm talking about AWSD09:57
voidspace*AWS09:57
mupBug #1508392 opened: Clearer error message when servicename instead of unitname <juju-core:New> <https://launchpad.net/bugs/1508392>09:57
voidspaceyou have listed space discovery as a 16.04 deliverable for AWS, despite discussion with fwreade saying we shouldn't do it09:57
dimiternvoidspace, we have to do auto-discovery at bootstrap to figure out where to put the apiserver, and to allow bootstrapping into a space10:01
voidspacedimitern: not if we don't have shared spaces10:02
voidspacedimitern: because there won't be a pre-existing space, so we'll create the necessary infrastructure at bootstrap10:02
voidspacedimitern: it *does* mean we don't have feature parity between AWS / MAAS for spaces10:05
dimiternvoidspace, that's one of the options10:05
dimiternvoidspace, let's have a call with jam about this, ideally also with rick10:05
dimiternfrobware, ^^ ?10:05
dimiternwe need to clarify this ASAP10:05
voidspaceheh10:06
jamdimitern: voidspace: if the user has to set up the spaces in order for anything to work at all (which they do today), then it seems to make sense to discover them without having to have a bunch of steps. I don't think it is a prereq for January, though.10:12
dimiternjam, not for jan, we're discussing later, until 16.0410:13
voidspacejam: they set them up through juju10:14
voidspacejam: so they don't have to set them up in EC2 as a pre-requisite10:15
voidspacejam: they only configure them through juju10:15
voidspacejam: having spaces discoverable (i.e. potentially shareable between environments) means that you can't safely delete or rename a space (can't fix typos) and you can't delete subnets or move them between spaces (so you have to assign a subnet to a space at subnet creation)10:17
voidspacejam: all of which is a horrible UX10:17
voidspacejam: not to mention that if you have different teams sharing a substrate (amazon account) with different environments they will see each others spaces10:17
jamvoidspace: if you have different teams sharing an amazon account you see everyone's stuff anyway10:18
jamhence the *shared account*10:18
voidspacejam: and old spaces/subnets from old environments will hang around for ever10:18
voidspacejam: not with juju - you just see your environment10:18
voidspacejam: a much better model, both for implementation and for UX, is private (to the environment) spaces by default, with explicitly global spaces for sharing10:19
voidspacejam: with the added benefit that "explicitly global" doesn't need to be done initially (yay scope reduction) and can be added later10:19
jamvoidspace: so I wouldn't focus too much on things beyond January at this point, but I'd also note that if we aren't handling routing between subnets, etc, then the user still has to go to the console to do anything.10:29
jamI do agree with some of your points about shared-on-request10:29
voidspacejam: dimitern: the strongest argument for not promising it is that if we don't do it we can always add it - but as soon as we add it we have to support it for ever10:30
voidspacejam: dimitern: so really, let's not promise it or do it until we're clear about the implications10:30
voidspacejam: (it's currently listed as a 16.04 deliverable in the draft doc - which is why I'm bringing it up now)10:31
dimiternfrobware, voidspace, jam, I agree to drop it, but it should be replaced with an entry about modeling the shared (global/local) aspect of spaces/subnet and how does it affect the CLI commands10:40
dimitern(i.e. make sure we can do it later properly)10:40
voidspacewell yes we should document what we do...10:41
TheMuedimitern: backported latest doc changes to 1.25, mind a quick look at http://reviews.vapour.ws/r/2961/ ? thx13:39
dimiternTheMue, sure, will do shortly13:40
TheMuedimitern: great13:40
mupBug #1508498 opened: JUJU bootstrap fails first time every time <juju-core:New> <https://launchpad.net/bugs/1508498>15:01
mupBug #1508498 changed: JUJU bootstrap fails first time every time <juju-core:New> <https://launchpad.net/bugs/1508498>15:04
dimiternTheMue, reviewed15:06
dimiternsorry it took so long15:06
TheMuedimitern: thx15:06
mupBug #1508498 opened: JUJU bootstrap fails first time every time <juju-core:New> <https://launchpad.net/bugs/1508498>15:13
alexisbwwitzel3, can you refresh my memory on what is happening the first week of feb w/ the eco team15:34
alexisbI see your travel request15:34
rick_h_alexisb: fosdem charmers summit party time!15:34
katcoalexisb: the 1st rule of charmers summit is you talk about charmers summit ALL THE TIME.15:34
marcoceppiALL THE TIME EVERYWHERE15:35
wwitzel3lol15:35
katcowoo woo15:35
mgzfosdem fosdem15:35
katcohypetrain15:35
wwitzel3do I even need to say anything at this point?15:35
alexisb:)15:35
marcoceppifosdem, cfgmgmtcamp, and http://summit.juju.solutions15:35
rick_h_wwitzel3: jsut 'pretty please'? :P15:35
wwitzel3rick_h_: :)15:36
alexisbwwitzel3, seems I am a good spot to ask for bribes ;)15:37
wwitzel3alexisb: haha15:40
voidspacefrobware: so I've done a 1.22 -> 1.24 upgrade with ignore-machine-addresses=true and failed to reproduce that issue16:14
voidspacefrobware: trying some other configurations16:14
katcoericsnow: natefinch: wwitzel3: http://reviews.vapour.ws/r/2963/17:05
natefinchkatco: are those first two tests going to compile?17:12
katconatefinch: tests run17:12
natefinchkatco: workload.Info doesn't ahve a Workload field anymore, does it?17:12
wwitzel3katco: looking17:13
katconatefinch: hm. no it does not17:13
katconatefinch: doh... didn't run those tests17:13
natefinchkatco: oh good, I was hoping this wasn't some wacky like embedding thing where it works both ways17:14
sinzuicherylj: bug 1465317 just came up in #ubuntu-devel. Ubuntu just learned about series X and the dep8 tests failed. They have fixed a test to avoid the panic, but they are nontheless concerned about Juju's insistence on knowing every version of every OS.17:34
mupBug #1465317: Wily osx win: panic: osVersion reported an error: Could not determine series <osx> <packaging> <wily> <windows> <juju-core:In Progress by dave-cheney> <juju-core 1.24:Triaged> <juju-core 1.25:Triaged> <juju-release-tools:Fix Released by sinzui> <https://launchpad.net/bugs/1465317>17:34
cheryljsinzui: I was just looking at that bug.  I see that it's in progress, but I'm not convinced that dave is actually working it.17:35
cheryljI asked for an update, but I'll also talk with him directly in the onyx standup today17:36
katcoericsnow: natefinch: wwitzel3: updatedf17:36
sinzuicherylj: I saw. I think we really need the issue to be fixed in 1.26. I think 1.25.1 is nice to have, I think all the next OS upgrades will involve 1.26 being the new stable17:38
cheryljsinzui: sounds reasonable.17:39
mupBug #1508498 changed: JUJU bootstrap fails first time every time <adoption> <charmers> <cpp> <juju-core:New> <https://launchpad.net/bugs/1508498>17:46
katcoyeeeeesssss: https://github.com/rmuslimov/jenkins.el17:48
mupBug #1508498 opened: JUJU bootstrap fails first time every time <adoption> <charmers> <cpp> <juju-core:New> <https://launchpad.net/bugs/1508498>17:49
mupBug #1508498 changed: JUJU bootstrap fails first time every time <adoption> <charmers> <cpp> <juju-core:New> <https://launchpad.net/bugs/1508498>17:52
mupBug #1508498 opened: JUJU bootstrap fails first time every time <adoption> <charmers> <cpp> <juju-core:New> <https://launchpad.net/bugs/1508498>17:58
mupBug #1508498 changed: JUJU bootstrap fails first time every time <adoption> <charmers> <cpp> <juju-core:New> <https://launchpad.net/bugs/1508498>18:01
marcoceppimup: calm down18:02
mupmarcoceppi: Excuse moi, parlez vous anglais?18:02
marcoceppiokay who made mup sassy18:02
wwitzel3katco: lol .. isn't there a bootloader for emacs? just switch already18:53
katcowwitzel3: lol i think there is18:54
wwitzel3there are instructions for making it pid 118:55
wwitzel3good enough18:55
katcowwitzel3: i know you can make it your wm19:22
lazypowerthe day fun died and emacs won19:28
wwitzel3katco: heh, for an editor no one uses there sure are a lot of plugins and extensions for it19:28
cheryljsinzui: I was just about to ask you if that juju-local packaging bug should be sent to lxc.  You're too quick!19:29
katcowwitzel3: maybe more people use it than people think :)19:29
cherylj:)19:29
katcowwitzel3: semi-complete list: https://melpa.org/#/19:29
sinzuicherylj: :) I was helping the user in another channel19:30
cheryljah!19:30
wwitzel3all those packages just for katco19:30
katcohaha19:30
katcowwitzel3: 70k+ downloads... you should try it out (whistles) https://melpa.org/#/evil19:31
natefinchkatco: http://reviews.vapour.ws/r/2814/  all tests passing19:33
katconatefinch: tal19:33
jamesmillerio  wwitzel3: Kind of random, but I think I just realized I actually know you based on your handle, hah19:38
jamesmilleriokind of crazy19:39
sinzuicherylj: I just reported bug 1508585 which is the cause the failure of the current test of 1.2519:42
mupBug #1508585: TestUploadedToolsMetadata fails on windows and centos <blocker> <centos> <ci> <regression> <test-failure> <unit-tests> <windows> <juju-core:Incomplete> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1508585>19:42
mupBug #1508585 opened: TestUploadedToolsMetadata fails on windows and centos <blocker> <centos> <ci> <regression> <test-failure> <unit-tests> <windows> <juju-core:Incomplete> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1508585>19:47
cheryljthanks for the heads up, sinzui19:47
mupBug #1508585 changed: TestUploadedToolsMetadata fails on windows and centos <blocker> <centos> <ci> <regression> <test-failure> <unit-tests> <windows> <juju-core:Incomplete> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1508585>19:50
mupBug #1508585 opened: TestUploadedToolsMetadata fails on windows and centos <blocker> <centos> <ci> <regression> <test-failure> <unit-tests> <windows> <juju-core:Incomplete> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1508585>19:53
wwitzel3jamesmillerio: yeah?19:53
jamesmilleriowwitzel3: yeah, you're Laura Tripletts friend and Jessa's husband, right?19:54
wwitzel3jamesmillerio: ahh, yeah, I know you and your wife :)19:54
jamesmillerioNiceeee, yep. I saw your wedding pictures go over my FB feed a few days ago so your name was fresh in my head. Saw you in here and there are only so many witzel's out there, haha.19:55
katcoi am fairly certain that wwitzel3 is actually a golden retriever who has no idea what he's doing.20:05
katcolike 20% sure.20:06
wwitzel320% seems low20:06
katcowell. i'm also unsure of what i'm doing.20:07
wwitzel3I'm 100% sure that I'm unsure20:07
wwitzel3;)20:07
katcoi... uh... i... yeah.20:08
katcomaybe.20:08
mupBug #1508595 opened: revisit use of networks in AddService code <tech-debt> <juju-core:New> <https://launchpad.net/bugs/1508595>20:17
natefinchkatco: so.... now what?20:30
natefinchkatco: what can I do to help with our demos, now that we've finally reached a more or less stopping point for this bug?20:31
katconatefinch: wwitzel3: ping, you need help with lxd?20:31
thumpercan I add any surity?20:34
thumperbut I know I don't know what you are doing20:34
katcothumper: surity?20:35
thumpersureity?20:35
natefinchsureitude20:35
thumperdamn english20:35
katcothumper: lol20:35
thumpersureness20:36
katcothumper: no i don't think so, just trying to find the next best thing for nate to work on20:36
katconatefinch: you could start working on feature tests for payloads20:37
natefinchkatco: I can do that.20:38
natefinchkatco: I'll start working on that tonight.20:39
katconatefinch: kk20:39
natefinchgotta run, back in a while20:39
=== natefinch is now known as natefinch-afk
cheryljcan I get a review for the 1.25 blocker?  http://reviews.vapour.ws/r/2965/21:13
katcocherylj: lgtm21:18
cheryljkatco: thanks!21:18
wwitzel3katco: you got a shipit21:57
katcowwitzel3: ty. 1.25 is blocked atm21:58
perrito666can anyone thing a way to check the size of all collections on a mongo db?22:29
perrito666thumper: seems that you are not the only one thinking the way you do about english http://img-9gag-fun.9cache.com/photo/aDmPrnO_700b.jpg22:37
alexisbanastasiamac, cherylj I will be late23:04
anastasiamacalexisb: k :) we r there23:04
menn0wallyworld: ping23:21
wallyworldmenn0: sorry, in standup, give me 523:30
menn0wallyworld: no rush23:34

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!