cjwatson | Odd_Bloke: Something about this particular case, I think - https://pastebin.canonical.com/142724/ but that code didn't change in the last deployment and hasn't changed for some time | 00:17 |
---|---|---|
cjwatson | Odd_Bloke: Can you file a bug with details and referencing the OOPS ID, please? | 00:18 |
cjwatson | We still have relatively few users of git-based MPs, so it's probably specific to some subcase of that. | 00:18 |
cjwatson | Odd_Bloke: Indeed, it looks like any git diff that involves an extended header line will fail. | 00:48 |
cjwatson | Odd_Bloke: Well, other than "index <hash>..<hash> <mode>". | 00:49 |
cjwatson | Odd_Bloke: Never mind, I filed https://bugs.launchpad.net/launchpad/+bug/1510337 | 01:08 |
ubot5 | Launchpad bug 1510337 in Launchpad itself "Extended headers in git diffs break patch parsing" [Critical,In progress] | 01:08 |
blr | cjwatson: hmm fun, I thought we had a few git tests | 01:12 |
cjwatson | We do, but they don't cover extended header lines. | 01:12 |
cjwatson | I'm fixing that. | 01:12 |
cjwatson | (Or at least they don't cover most extended header lines.) | 01:13 |
cjwatson | blr: https://code.launchpad.net/~cjwatson/launchpad/git-patch-headers/+merge/275792 | 01:50 |
sergio-br2 | ergh, I just changed some stuff in the packaging, and it's not building for ARM... | 02:05 |
sergio-br2 | https://launchpadlibrarian.net/222927857/buildlog_ubuntu-vivid-armhf.libretro-gpsp_0.9%2Br247~10~ubuntu15.04.1_BUILDING.txt.gz | 02:05 |
sergio-br2 | this gba emu has ARM dynarec which I think is hard to build in the launchpad, but last time it built... | 02:06 |
sergio-br2 | the diff: http://bazaar.launchpad.net/~libretro/libretro/gpsp-libretro-debian/revision/10 | 02:08 |
sergio-br2 | I'm pretty sure it's not my fault... | 02:08 |
cjwatson | sergio-br2: Launchpad itself doesn't really have a whole lot to do with this. I suspect you'd do better to diff build logs and/or consult an ARM/toolchain expert | 02:11 |
sergio-br2 | hum | 02:12 |
cjwatson | You have a working build log from before, so you can diff it and see what compiler options changed etc. | 02:12 |
cjwatson | And try changing them back and seeing if it works again | 02:12 |
sergio-br2 | weird, there's this fstack-protector-strong, I didn't add that | 02:13 |
cjwatson | e.g. perhaps the change from -fstack-protector to (implicitly via dpkg-buildflags) -fstack-protector-strong makes some kind of difference for some reason | 02:13 |
sergio-br2 | the working log: https://launchpadlibrarian.net/222742385/buildlog_ubuntu-vivid-armhf.libretro-gpsp_0.9%2Br247~9~ubuntu15.04.1_BUILDING.txt.gz | 02:13 |
cjwatson | Don't tell us, diff it yourself please | 02:13 |
sergio-br2 | :p | 02:13 |
cjwatson | You effectively switched to dpkg-buildflags by changing to DEB_*FLAGS_MAINT_* | 02:14 |
sergio-br2 | yup | 02:14 |
cjwatson | That's normally a good direction to take, but in some cases it needs further overrides, and it's certainly a place to look for problems of this kind | 02:14 |
sergio-br2 | before I was overriding it | 02:14 |
sarnold | also -g flag | 02:15 |
sergio-br2 | weird, the CFLAGS should be -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security | 02:15 |
sergio-br2 | not with this fstack-protector-strong | 02:16 |
sarnold | though it's hard to imagine either influencing a section named .jit | 02:16 |
sergio-br2 | I removed the -g, so it was building without debug symbols right? | 02:16 |
cjwatson | $ dpkg-buildflags --get CFLAGS | 02:16 |
cjwatson | -g -O2 -fstack-protector-strong -Wformat -Werror=format-security | 02:16 |
sergio-br2 | Mine is -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security | 02:17 |
cjwatson | It depends on the release. | 02:17 |
sergio-br2 | why yours is protect? | 02:17 |
sergio-br2 | humm | 02:17 |
sergio-br2 | mine is 14.04 | 02:17 |
cjwatson | Right, which is different. | 02:17 |
cjwatson | The Launchpad build you're referring to is vivid, so unless you know the packaging toolchain well enough to know all the differences then maybe you might be well advised to check there? | 02:18 |
sergio-br2 | ok, so probably this is not the problem, the log from 14.04 has -fstack-protector too | 02:18 |
sergio-br2 | I'll try to remove the -g i guess | 02:18 |
cjwatson | The vivid log has -fstack-protector-strong, which is different. I'm not saying that that is definitely the problem or anything, but you should check all the obvious differences. | 02:18 |
sergio-br2 | with -s is no debug symbol right? | 02:18 |
sergio-br2 | * the 14.04 also failed | 02:19 |
cjwatson | -s? what? | 02:19 |
sergio-br2 | -s -O2 | 02:19 |
cjwatson | Do you mean -g? | 02:19 |
sergio-br2 | instead -g -O2 | 02:19 |
cjwatson | Omit it, don't make up some random other flag :) | 02:19 |
sergio-br2 | ok :) | 02:19 |
cjwatson | Should just need to add -g to *_MAINT_STRIP | 02:20 |
sergio-br2 | yup | 02:21 |
sergio-br2 | let's see | 02:21 |
blr | cjwatson: so many fun cases to handle in this code... | 02:22 |
blr | that seems like a good approach though, certainly trying to match every possible extended header could be problematic in the future? | 02:23 |
cjwatson | Yeah, there are enough entries that I'd rather treat it as an open-ish set | 02:25 |
sergio-br2 | cjwatson, it worked | 02:57 |
Odd_Bloke | cjwatson: wgrant: Is there a problem with git hosting ATM? I'm seeing a Jenkins job that started failing in the last hour, and I've noticed rumblings about problems in other channels. | 11:18 |
cjwatson | Odd_Bloke: Can you link to details? | 11:19 |
cjwatson | (wgrant is on holiday) | 11:19 |
Odd_Bloke | cjwatson: I'm seeing http://paste.ubuntu.com/12978751/ in a Jenkins job that was working about an hour ago. | 11:20 |
Odd_Bloke | cjwatson: And the rumblings: http://paste.ubuntu.com/12978753/ | 11:21 |
cjwatson | ouch | 11:22 |
cjwatson | investigating | 11:23 |
Odd_Bloke | Thanks. | 11:23 |
cjwatson | Odd_Bloke: Fixed now; maas decided to turn on dnssec validation on one of the internal nameservers, which doesn't work so well for .internal names. | 11:38 |
Odd_Bloke | cjwatson: Thanks muchly. | 11:38 |
Odd_Bloke | cjwatson: Have let the other folks who were hitting issues know as well. :) | 11:39 |
Cysioland | Did I do good by changing that bug's project, or do I need to revert it some way and report a new bug? https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1507957 | 20:08 |
ubot5 | Launchpad bug 1507957 in network-manager (Ubuntu) "Huawei E3372 LTE modem on 15.10 works only when connecting via wvdial and not network-manager" [Medium,Confirmed] | 20:08 |
dobey | Cysioland: ask in #ubuntu for help about reporting ubuntu bugs; this channel is more about questions about how to use launchpad itself, and not for answquering questions about how projects that use launchpad manage their bugs | 20:24 |
teward | and bug related questions like that are likely supposed to be in #ubuntu-bugs (bug triage questions usually end up there) | 20:24 |
dobey | oh right, yeah, #ubuntu-bugs | 20:25 |
teward | :) | 20:25 |
dobey | (so many irc channels, can't remember them all if i don't hang out in them) | 20:25 |
Cysioland | On #ubuntu nobody responds, maybe #ubuntu-bugs will work | 20:25 |
teward | dobey: happens to us all :0 | 20:26 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!