| dholbach | good morning | 08:04 |
|---|---|---|
| dholbach | dpm, mhall119: https://stackoverflow.com/questions/33284171/added-updated-pages-in-wrong-place-in-django-cms-article-tree-using-postgres/33399188#33399188 | 08:50 |
| dholbach | I'll try to upgrade mptt and see if that helps | 08:51 |
| dholbach | we should really make https://code.launchpad.net/~developer-ubuntu-com-dev/developer-ubuntu-com/1470715/+merge/268471 a priority | 08:51 |
| dholbach | especially now with landings being possible again | 08:51 |
| dpm | thanks dholbach! | 08:57 |
| dpm | dholbach, the bug report does only say do django upgrade. From which version to which version, and why do we need the upgrade? | 08:59 |
| dholbach | it's slightly outdated | 09:01 |
| dpm | ok, I can see the new revision on the diff too: 1.8.4 | 09:03 |
| dpm | it seems we should be able to drop South too, as 1.7 shipped built-in schema migration? | 09:05 |
| dholbach | yes | 09:06 |
| dholbach | that's why the diff of the MP is so big | 09:07 |
| dholbach | all migrations need to be converted from the old to the new format | 09:07 |
| dholbach | everything from L525 onwards it the non-migrations part of the diff | 09:07 |
| dholbach | but for bug 1506861 we probably don't need the full upgrade | 09:09 |
| ubot2 | bug 1506861 in developer-ubuntu-com "Markdown article importer messes up article tree" [Critical,New] https://launchpad.net/bugs/1506861 | 09:09 |
| dholbach | it might make sense to fix this issue before | 09:09 |
| dholbach | WOW | 09:11 |
| dholbach | it looks like manage.py cms fix-mptt actually made it work | 09:11 |
| dholbach | I'll embed it in my testing | 09:12 |
| dholbach | Daniele is a great guy - he's a contact from mhall119 | 09:15 |
| dholbach | I'll ask him if he has an Amazon Wishlist or something | 09:15 |
| dpm | :-) | 09:16 |
| dholbach | hum, that might have been a bit premature... it just worked one time now - I'll need to figure out more specifically how it works and under which conditions it fixes the issue | 09:40 |
| dholbach | it looks like we should move off of the old django cms (and with that off of mptt to treebeard) in any case | 09:40 |
| czajkowski | aloha | 09:59 |
| dpm | morning czajkowski | 10:00 |
| dpm | dholbach, I guess it's a two step process, right? First upgrade django (which we can theoretically do right now) and then migrate to treebeard? | 10:02 |
| dholbach | dpm, I personally would for now just upgrade to a newer mptt and apply the fix-mptt change (if I can make sure that fixes everything we need in the importer) | 10:03 |
| dholbach | and then do the big upgrade where we do django and everything else | 10:03 |
| dholbach | and migrate to treebeard with that at the same time | 10:03 |
| dholbach | the big upgrade will need a lot of testing to see if all plugins still work etc | 10:03 |
| dholbach | maybe we can try to do a better job staying on current stuff later on | 10:04 |
| dpm | dholbach, ok | 10:04 |
| dholbach | but we can discuss it later on with davidcalle and mhall119 if you like | 10:04 |
| dholbach | just to see how everyone feels about it | 10:04 |
| dholbach | for now I'll just work on an isolated fix for the importer | 10:04 |
| dholbach | davidcalle, mhall119's contact gave us some food for thought (and experimentation: https://stackoverflow.com/questions/33284171/) | 10:05 |
| dholbach | I'll let you know how it goes :) | 10:05 |
| dholbach | davidcalle, mhall119: if you have some time later on, I'd appreciate a review (and testing) of https://code.launchpad.net/~dholbach/developer-ubuntu-com/1506861/+merge/276104 | 11:36 |
| dholbach | davidcalle, mhall119: and there's https://code.launchpad.net/~dholbach/developer-ubuntu-com/1510904/+merge/276111 now | 12:00 |
| dholbach | with that I I'll run out for lunch :-) | 12:02 |
| dholbach | see you later! | 12:02 |
| dpm | davidcalle, could you add a description for the "JavaScript scopes hands-on" session? I'm writing a blog post announcing the summit and I wanted to highlight it :) | 12:50 |
| dholbach | dpm, davidcalle, mhall119: shall we have a chat about landing the rest of MPs in our docs hour call in 40m? | 13:48 |
| dpm | dholbach, sounds good to me | 13:49 |
| mhall119 | dholbach: works for me | 13:49 |
| dholbach | awesome | 13:50 |
| davidcalle | dpm, sure! | 14:21 |
| davidcalle | dholbach, sure! | 14:21 |
| davidcalle | dholbach, mhall119, will be 5 min late | 14:29 |
| dholbach | ok | 14:30 |
| dpm | dholbach, will be a few mins | 14:35 |
| mhall119 | seems we all will ;) | 14:35 |
| popey | we hanging out? | 14:39 |
| dholbach | davidcalle, I'll test yours in a sec | 15:27 |
| dholbach | let me know if you have any feedback about the branches | 15:28 |
| davidcalle | dholbach, yep | 15:28 |
| dholbach | davidcalle, 127.0.0.1/:44 Uncaught TypeError: window.location.href.contains is not a function | 15:32 |
| davidcalle | waaat | 15:32 |
| dholbach | davidcalle, this seems to work .indexOf(...) > -1 | 15:34 |
| davidcalle | dholbach, where do you see this issue? | 15:40 |
| dholbach | trunk | 15:40 |
| dholbach | trunk + your branch using chromium | 15:40 |
| davidcalle | dholbach, this output I mean | 15:40 |
| dholbach | in the js console | 15:40 |
| dholbach | press f12 | 15:40 |
| davidcalle | dholbach, works in firefox :p | 15:41 |
| dholbach | does it work for you in chromium? | 15:41 |
| davidcalle | dholbach, just tested in chrome, doesn't work | 15:42 |
| dholbach | this might work: if(window.location.href.indexOf("cn.developer.ubuntu.com") == -1) | 15:43 |
| dholbach | I'm still trying to figure out how to pretend I'm "cn.developer.ubuntu.com" | 15:43 |
| dholbach | nevermind, I was a bit dense :) | 15:44 |
| dholbach | shall we remove http://stats.g.doubleclick.net/dc.js as well? | 15:44 |
| dholbach | not sure where that's coming from | 15:44 |
| davidcalle | dholbach, don't know | 15:45 |
| dholbach | ok | 15:45 |
| dholbach | so the check I posted above wfm | 15:45 |
| dholbach | both in chromium and firefox | 15:45 |
| davidcalle | dholbach, was testing, can confirm | 15:46 |
| * davidcalle changes | 15:46 | |
| davidcalle | dholbach, updated: https://code.launchpad.net/~davidc3/developer-ubuntu-com/analytics-exclude-cn-domain/+merge/275887 | 15:51 |
| dholbach | approved | 15:53 |
| davidcalle | Yay | 15:55 |
| * davidcalle hugs dholv | 15:55 | |
| jcastro | popey: this latest podcast is brilliant, well done | 15:55 |
| davidcalle | *dholbach | 15:55 |
| jcastro | well, brilliant so far I mean, in the middle of listening | 15:55 |
| * dholbach hugs davidcalle back | 15:55 | |
| popey | ooh, cool, thanks jcastro | 15:56 |
| davidcalle | dholbach, I'm impatient to test your importer fix on staging! | 16:26 |
| dholbach | davidcalle, oh ok... I thought somebody was going to review and test them? | 16:26 |
| dholbach | or do we just push to trunk? | 16:26 |
| davidcalle | dholbach, I've just tried it :) | 16:26 |
| dholbach | ah! great! | 16:27 |
| dholbach | so I can push to trunk now? :) | 16:27 |
| davidcalle | dholbach, yep :) | 16:27 |
| dholbach | both? | 16:28 |
| davidcalle | dholbach, haven't tested git yet, and taking tristan to the doc in 10 min :/ | 16:28 |
| dholbach | ^ mhall119 - can you look at the git branch then? | 16:29 |
| dholbach | I'll merge the other one | 16:29 |
| mhall119 | dholbach: do we know that bzr and git command-line tools are available on the server? | 16:30 |
| dholbach | it'd surprise me a lot if bzr wasn'T | 16:30 |
| dholbach | but for git we should ask | 16:30 |
| davidcalle | bzr is, since it imports on tsaging | 16:31 |
| davidcalle | staging* | 16:31 |
| === davidcalle is now known as davidcalle|afk | ||
| dholbach | mhall119 (and davidcalle|afk): I pushed a check for bzr/git availability to the branch | 17:04 |
| dholbach | I hope that's better | 17:05 |
| dholbach | all right - I call it a day - see you all tomorrow! | 17:08 |
| dpm | hi czajkowski, around? | 19:00 |
| dpm | czajkowski, nm, we can chat tomorrow if you're around | 19:05 |
| dpm | calling it a day for today | 19:05 |
| dpm | see you all tomorrow! | 19:05 |
| === davidcalle|afk is now known as davidcalle | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!