| sethj | alright, I fixed the bug.. Can someone help me figure out how to submit it? I tried submitting a merge proposal but that didn't work out right https://code.launchpad.net/~sethj/ubuntu/wily/unity/fix-for-1445595/+merge/276072 | 00:26 |
|---|---|---|
| sarnold | quarter million lines changed, heh | 00:28 |
| sethj | sarnold, yeah. that was strange. I used bzr branch lp:unity to get the source.. | 00:30 |
| sethj | should I have instead pushed it to unity/unity instead of wily/unity? | 00:30 |
| sarnold | sethj: sorry, I don't know bzr very well :/ | 00:31 |
| sarnold | perhaps paste this link into the bug? http://bazaar.launchpad.net/~sethj/ubuntu/wily/unity/fix-for-1445595/revision/4028 | 00:31 |
| sethj | sarnold, I doubt it is as simple as that.. Somehow I got an old source tree so I'm "reverting" a bunch of changes. | 00:38 |
| cyphermox | sethj: this would happen if you starting with lp:unity and tried to merge to lp:ubuntu/unity | 01:22 |
| sethj | cyphermox, I tried merging into wily/unity, does that count? | 01:23 |
| cyphermox | same thing :) | 01:23 |
| sethj | that's what I thought. | 01:23 |
| cyphermox | run bzr info, check what the parent is | 01:23 |
| sethj | Should I remerge into unity/unity then? | 01:23 |
| sethj | parent branch is parent branch: bzr+ssh://bazaar.launchpad.net/+branch/unity/ cyphermox | 01:24 |
| cyphermox | right | 01:24 |
| cyphermox | so you simply want to file your merge proposal again, but against ~unity-team/unity/trunk | 01:24 |
| cyphermox | (lp:unity, should be in the list of suggestions I think) | 01:25 |
| cyphermox | you should be able to change that by using the resubmit link at the top right on the merge proposal page | 01:26 |
| sethj | thanks cyphermox! It looks like that worked. | 01:27 |
| cyphermox | sethj: yep. I'll let the unity dev review that | 01:32 |
| === cute is now known as EphraimB | ||
| hikiko | hi | 06:01 |
| duflu | Morning hikiko | 06:35 |
| hikiko | hi duflu :) | 06:37 |
| hikiko | how are you? | 06:37 |
| duflu | hikiko: Going OK. How are you? | 06:37 |
| hikiko | I'm good too | 06:42 |
| darkxst | seb128, I gotta run, but tried to push a no change rebuild of g-c-c for cheese, but it needs the new valac package MIR'ed | 06:54 |
| darkxst | seb128, also unity is FTBFS with what looks like gcc5/libsig++ fallout, https://launchpad.net/~darkxst/+archive/ubuntu/gd318/+build/8216566/+files/buildlog_ubuntu-xenial-amd64.unity_7.3.2%2B15.10.20151016-0ubuntu2_BUILDING.txt.gz | 06:54 |
| seb128 | good morning desktopers | 06:58 |
| seb128 | hey duflu hikiko darkxst | 06:59 |
| seb128 | darkxst, Trevinho has unity fixed from what he said in the previous days | 06:59 |
| seb128 | k for vala | 06:59 |
| didrocks | good morning | 06:59 |
| duflu | Morning seb128 | 07:00 |
| duflu | And morning didrocks | 07:00 |
| seb128 | lut didrocks | 07:00 |
| didrocks | hey duflu, seb128 | 07:01 |
| hikiko | hey seb128 didrocks | 07:02 |
| didrocks | salut hikiko | 07:02 |
| pitti | Good morning | 07:23 |
| desrt | good morning didrocks, duflu, seb128, hikiko, pitti, darkxst :) | 07:24 |
| desrt | (and everyone else) | 07:24 |
| pitti | hey desrt, wie gehts? | 07:24 |
| seb128 | hey desrt pitti | 07:24 |
| duflu | Hey desrt | 07:24 |
| desrt | pitti: i gehts very well, thank you | 07:24 |
| hikiko | goodmorning all :p | 07:24 |
| * seb128 goes to get something to eat, bbiab | 07:25 | |
| didrocks | morning pitti, desrt | 07:26 |
| desrt | greetings, mvo | 07:31 |
| mvo | hey desrt | 07:31 |
| pitti | ça va seb128 et didrocks ! | 07:33 |
| pitti | hey mvo, wie gehts? | 07:33 |
| mvo | hey pitti, I'm very well, thank you! und du? | 07:34 |
| pitti | mvo: bisschen muede, bin erst halb zwei ins Bett; aber okay, danke! | 07:34 |
| mvo | pitti: halb-zwei? hat augsburg noch gespielt letzte nacht :) ? | 07:35 |
| pitti | mvo: Actually FCA did play yesterday evening for the DFB Pokal (3:0 against Freiburg!), but that wasn't the reason | 07:36 |
| didrocks | pitti: sneezing way more and didn't really sleep (was awake between 3:30am to 7am), so well… :p | 07:37 |
| pitti | mvo: I play basketball Wed evenings, and only come home 22:30, and after that I'm still too pumped to go to bed immediately | 07:37 |
| pitti | so, late-night debugging session :) | 07:37 |
| desrt | didrocks: ah.. you too, hm? | 07:37 |
| * desrt is also coming down with something and didn't sleep well :( | 07:37 | |
| didrocks | desrt: yeah, since Monday, just getting worse | 07:37 |
| desrt | ugh | 07:38 |
| desrt | i was sort of hoping it cleared up before i have to fly | 07:38 |
| mvo | pitti: aha, nice! | 07:39 |
| pitti | didrocks: erk; time for some tea and midday nap? | 07:39 |
| didrocks | pitti: good idea, and will add some honey to the tea as well! | 07:41 |
| * desrt makes some tea too | 07:42 | |
| ricotz | hey desktopers | 07:51 |
| ricotz | could someone hold back gjs to transition from xenial-proposed? | 07:52 |
| ricotz | afaics it breaks API/ABI | 07:52 |
| pitti | ricotz: it still builds libgjs0e, so if it does change ABI it doesn't declare it? | 07:53 |
| pitti | ricotz: you can file a bug against it and tag it "block-proposed"; right now it's held because of the powerpc FTBFS, but of course that might get "accidentally" resolved; so better file a bug with a rationale | 07:54 |
| ricotz | pitti, upstream doesnt care about abi break, that is why there is the suffix "e" | 07:54 |
| ricotz | pitti, ok | 07:56 |
| ricotz | pitti, is this enough since I can't link it xenial -- bug 1511253 | 08:02 |
| ubot5 | bug 1511253 in gjs (Ubuntu) "1.44.0 breaks API/ABI without transitioning" [Undecided,New] https://launchpad.net/bugs/1511253 | 08:02 |
| pitti | ricotz: yes, proposed-migration doesn't care about that; but I'll mark it anyway for clarity | 08:02 |
| ricotz | thx | 08:03 |
| larsu | good morning! | 08:06 |
| Trevinho | Morning! | 08:08 |
| desrt | larsu: hello! | 08:12 |
| didrocks | morning larsu & Trevinho | 08:13 |
| larsu | hi Trevinho and desrt! How are you? | 08:13 |
| larsu | and didrocks :) | 08:13 |
| desrt | Trevinho: hey :) | 08:13 |
| desrt | not great. sick :/ | 08:13 |
| desrt | didrocks gave it to me | 08:13 |
| larsu | :( | 08:14 |
| larsu | get better! | 08:14 |
| Trevinho | Hey larsu and didrocks! So, so... You? | 08:15 |
| didrocks | sick as well :/ | 08:17 |
| didrocks | missing quite some hours of sleep in the process due to this | 08:17 |
| larsu | Trevinho: good good. Going to Milan this afternoon | 08:17 |
| larsu | didrocks: uh oh - got worse after all? Sorry to hear | 08:18 |
| didrocks | larsu: yeah, sneezing and couldn't sleep anymore between 3:30 to 7am | 08:18 |
| Trevinho | larsu: Milan? Why? | 08:24 |
| larsu | Trevinho: Faina has some work thing there. I'm coming as the spouse | 08:26 |
| larsu | and then we'll spend some time there | 08:26 |
| larsu | drinking a lot of coffee, I presume :) | 08:26 |
| Trevinho | larsu: eh he... Good, it's a good moment for Milan, because of the expo... | 08:31 |
| Trevinho | I guess you'll find a lot of other good stuff, together with espresso :-) | 08:31 |
| larsu | hehe | 08:33 |
| * larsu is looking forward to it | 08:33 | |
| larsu | desrt: g_settings_set() immediately changes the value in the settings object and sends a changed() to the same process? | 08:39 |
| desrt | yes | 08:40 |
| desrt | meanwhile it sends a dbus message (async via the worker thread) to dconf to record the change | 08:40 |
| larsu | right | 08:40 |
| larsu | just making sure | 08:40 |
| desrt | when dconf says "okay, i'm done" then the local value is dropped from the process | 08:40 |
| larsu | having some trouble with the qml bindings again | 08:40 |
| desrt | or if dconf says "something went wrong" then the local value is dropped and an additional change signal is sent (so that the program sees the old value again) | 08:40 |
| larsu | desrt: oh you *remember* the local value? | 08:40 |
| desrt | yes | 08:40 |
| desrt | we have to, since it's not on disk yet and the user will expect to see it immediately | 08:40 |
| larsu | makes sense | 08:41 |
| desrt | dconf is very tricky | 08:41 |
| desrt | so is irccloud... | 08:41 |
| larsu | why? | 08:41 |
| desrt | i just realised while having this conversation that it does much the same thing | 08:41 |
| desrt | when i press enter, it immediately shows my message as having been sent | 08:41 |
| pitti | seb128: are you on teh remaining bits of the poppler transition? (http://people.canonical.com/~ubuntu-archive/proposed-migration/update_output.txt) | 08:41 |
| larsu | hehe | 08:41 |
| desrt | but by the time it makes it to the server, maybe you said something before i did | 08:41 |
| pitti | seb128: seems there's still some uninstallables there | 08:41 |
| desrt | so it reorders messages after they've already been put in the buffer | 08:41 |
| seb128 | pitti, I plan to spend some time today looking at some of the transitions, cheese poppler evolution-data-server | 08:42 |
| seb128 | but help would be welcome | 08:42 |
| pitti | cool, thanks | 08:42 |
| larsu | desrt: the problem is that we're now sending the changed signal in another main loop iteration (because of a qt bug). When the change signal comes in, we don't emit it anymore because we have a "if the value hasn't change, don't emit" condition | 08:42 |
| larsu | and I can't take that out, becasue of cycles | 08:42 |
| larsu | it's all very messed up | 08:42 |
| seb128 | pitti, let me do a round of test builds now | 08:43 |
| desrt | ugh | 08:43 |
| desrt | gsettings handles this in a pretty simple way | 08:44 |
| pitti | seb128: it's just libpoppler56 -> 58, -glib, -qt etc. are the same, right? | 08:44 |
| pitti | seb128: want a transition tracker for it? | 08:44 |
| desrt | 1) change signals that came from the same process always go directly, never via mainloop | 08:44 |
| seb128 | pitti, correct | 08:44 |
| desrt | s/process/thread/ | 08:44 |
| seb128 | pitti, that could be good yes | 08:44 |
| desrt | 2) we detect recursion in the normal sense of the word and stop it there | 08:44 |
| larsu | desrt: (1) is what we had before, but we have to go through the main loop because qt leaks if we don't | 08:44 |
| seb128 | pitti, we might want one for e-d-s as well? | 08:44 |
| desrt | good luck to you... | 08:44 |
| desrt | i don't know of a good solution to this problem. this problem is part of the reason that gsettings works the way that it does. | 08:45 |
| larsu | desrt: I could now remember the changed keys in a hash map and check that when change signals come in | 08:45 |
| larsu | or remove the check entirely | 08:45 |
| larsu | I hate this problem :/ | 08:45 |
| seb128 | pitti, some of the rebuilds are failing due to valac not being installable if you want to have a look to that | 08:51 |
| pitti | seb128: won't have time today, I'm afraid | 08:51 |
| seb128 | k, no worry | 08:51 |
| seb128 | adding to my todo if nobody beats me | 08:51 |
| seb128 | +to it | 08:52 |
| pitti | seb128: committed poppler transition | 08:53 |
| seb128 | pitti, danke | 08:54 |
| willcooke | morning all | 09:01 |
| didrocks | hey willcooke | 09:02 |
| seb128 | hey willcooke | 09:03 |
| desrt | hello willcooke | 09:04 |
| larsu | morning willcooke | 09:04 |
| willcooke | larsu, I think it was you who told me about the calendar trick where you set the timezone to ???? somewhere in Iceland perhaps, and then it doesn't move around with DST changes? | 09:23 |
| willcooke | Can you remind me where that place was? | 09:23 |
| willcooke | oh wait, ignore | 09:24 |
| willcooke | I've just removed the time zone altogether | 09:24 |
| seb128 | willcooke, Laney does that ;-) | 09:28 |
| willcooke | ah, thx | 09:29 |
| willcooke | I think it's sorted now | 09:29 |
| * larsu has no clue what willcooke is talking about | 09:42 | |
| * willcooke puts down the crack pipe | 09:42 | |
| larsu | hehe | 09:43 |
| willcooke | https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1480217 | 09:57 |
| ubot5 | Launchpad bug 1480217 in nautilus (Ubuntu) "Nautilus background handling screwed when changing scaling factor." [High,Triaged] | 09:57 |
| willcooke | We've been asked to take a look at this bug with some urgency, who can take a look? It'll need back-porting to Trusty as well | 09:58 |
| seb128 | larsu, ^ maybe? | 09:59 |
| seb128 | Laney and larsu are the only ones in the team with hidpi configs I think | 10:00 |
| larsu | reading right now | 10:00 |
| seb128 | danke | 10:00 |
| willcooke | thanks larsu | 10:00 |
| Trevinho | damned you arm64! | 10:13 |
| Trevinho | Unity doesn't compile there (in xenial). collect2: fatal error: ld terminated with signal 11 [Segmentation fault] | 10:13 |
| Trevinho | Not much to do... Nor to understand | 10:13 |
| ogra_ | just blame doko and move on :) | 10:13 |
| seb128 | Trevinho, try to ping doko about it on #ubuntu-devel | 10:24 |
| Trevinho | seb128: ok thanks | 10:26 |
| === nudtrobert1 is now known as nudtrobert | ||
| willcooke | Can we get this SRU'd in the next few days? https://bugs.launchpad.net/ubuntu/+source/gtk+3.0/+bug/1508357 | 11:01 |
| ubot5 | Launchpad bug 1508357 in gtk+3.0 (Ubuntu) "Tooltips have a black squares outside of its rounded corners" [Medium,Fix committed] | 11:01 |
| seb128 | willcooke, yeah, it's on my list for today | 11:01 |
| willcooke | oh sweet, thanks seb128 | 11:02 |
| seb128 | willcooke, did we get any user reporting it or commenting about the issue? | 11:02 |
| seb128 | I didn't see any comment about that one yet | 11:02 |
| willcooke | seb128, not many. I saw a guy mention it on the Ubuntu G+ community, but I dont think people are really noticing it. | 11:02 |
| seb128 | didrocks has good eyes ;-) | 11:03 |
| willcooke | :) | 11:03 |
| seb128 | I still can't see it even on my external monitor | 11:03 |
| didrocks | for close vision, sure :) | 11:03 |
| seb128 | well I see that the corners are not round | 11:03 |
| willcooke | same | 11:03 |
| seb128 | but I can't see the round inside the rectangle | 11:03 |
| * larsu sings the song of rgba windows | 11:03 | |
| willcooke | seb128, I can just about make it out on my Inspiron | 11:04 |
| willcooke | but I have to press my nose against the screen :) | 11:04 |
| seb128 | :-) | 11:04 |
| larsu | willcooke: touch screen? | 11:04 |
| willcooke | :D | 11:06 |
| ricotz | Sweet5hark1, please ping me when you copied 5.0.3~rc2 to the public ppa | 11:49 |
| Sweet5hark1 | ricotz: aye | 11:51 |
| ricotz | Sweet5hark1, and don't be lazy with tweaking the version for a ppa ;) | 11:52 |
| ricotz | Sweet5hark1, while you are here, do you see a need for 5.1.x backports for vivid? | 11:53 |
| Sweet5hark1 | ricotz: not really. vivid is EOL when 5.1.0 will be released. | 11:57 |
| Sweet5hark1 | ricotz: 5.0.3 copied. | 12:00 |
| ricotz | Sweet5hark1, alright | 12:09 |
| ricotz | Sweet5hark1, do you intend to push a xenial build for 5.0.3 to the ppa too? | 12:11 |
| qengho | good morning | 12:14 |
| desrt | qengho: hello! | 12:15 |
| didrocks | popey: FYI, the twine support brings interesting challenge for ubuntu make :p | 12:16 |
| popey | Oh good! :) | 12:16 |
| popey | node? | 12:16 |
| qengho | "challenge" | 12:17 |
| popey | Sweet5hark1, ooh, do you have a 5.0.3 build for me too? :) | 12:17 |
| didrocks | popey: not, more simple than that: they don't provide an icon, so I need to do multiple downloads in parallel | 12:17 |
| popey | hah | 12:17 |
| didrocks | popey: in addition to the requirements (packages to install) | 12:17 |
| didrocks | it was supposed to be supported from the beginning | 12:17 |
| didrocks | but it seems there are BUGS! :) | 12:17 |
| didrocks | (like a callback only called once called multiple times…) | 12:18 |
| didrocks | weird that unit tests are still telling it's doing the right thing, need to investigate… | 12:18 |
| seb128 | tkamppeter, what's the difference between Debian's pysmbc and our python-smbc? should be use the same name as they do? also it seems there is a new bugfix update available if you want to work on that one | 12:18 |
| desrt | didrocks: welcome to TDD. the API is what the tests say it is. please adjust your code to be more like the tests :) | 12:20 |
| didrocks | desrt: actually, the test is correct and the module have the right behavior | 12:24 |
| didrocks | the issue is in the main module doing the different calls not behaving well | 12:25 |
| didrocks | (the icon file is too small and so one download finish before I get the chance to have one progress for all requested download) | 12:25 |
| tkamppeter | seb128, thank you very much. I was not aware of that. I will have a look. By the way, what is the (Ubuntu/Debian) naming policy for python libs, python-xxx or pyxxx? When I started at Ubuntu there were simply these python-xxx packages for s-c-p which I continued to maintain. | 12:37 |
| seb128 | tkamppeter, unsure there is a policy about the source packages names, usually we use the same as upstream does | 12:37 |
| didrocks | yeah, for instance python-foo would be "foo" as source package name (for the most of python ones I've seen) | 12:39 |
| === hikiko-lpt is now known as hikiko|ln | ||
| === alan_g is now known as alan_g|lunch | ||
| === hikiko|ln is now known as hikiko | ||
| === alan_g|lunch is now known as alan_g | ||
| didrocks | oh nice, CI jenkins now seems to have access to docker hub | 14:05 |
| * didrocks will be able to wire medium tests | 14:05 | |
| willcooke | neat! | 14:05 |
| * didrocks takes his plumbing hat, and start diving | 14:06 | |
| * mdeslaur slaps seb128 for losing changelog entries in unzip merge | 14:08 | |
| seb128 | mdeslaur, ? | 14:08 |
| seb128 | oh, you mean merging back old changelog entries? | 14:08 |
| mdeslaur | yeah | 14:08 |
| mdeslaur | oh, did it get synced? | 14:08 |
| seb128 | question for you, if we had unzip in sync for a week and then added a delta again, would you then bring back all the old entries? | 14:09 |
| mdeslaur | no | 14:09 |
| seb128 | k, so if that makes you happier just think that it was synced by mistake | 14:10 |
| * mdeslaur slaps seb128 again | 14:10 | |
| seb128 | then some change needed were added :p | 14:10 |
| seb128 | roh | 14:10 |
| didrocks | ahah, that discussion again! | 14:10 |
| seb128 | but yeah, I can't be bothered | 14:10 |
| mdeslaur | slapping you makes me happier :) | 14:10 |
| * didrocks has some déjà-vu from 2009 :) | 14:10 | |
| seb128 | I never merged the old changelog entries, that's more work than it's worth and it eats extra space on disk | 14:10 |
| seb128 | didrocks, yeah ;-) | 14:10 |
| seb128 | mdeslaur, instead of slapping me you should get going with doing your merges! ;-) | 14:11 |
| seb128 | that wouldn't happen if you were the one who merged it :p | 14:11 |
| mdeslaur | hehe :) | 14:12 |
| mhall119 | willcooke: welcome back and ping about UOS sessions from the desktop team for next week | 14:26 |
| willcooke | mhall119, hi, going in to a meeting in a mo | 14:26 |
| mhall119 | willcooke: let me know when you're free | 14:26 |
| willcooke | that reminds me, seb128 can you attend: http://summit.ubuntu.com/uos-1511/meeting/22576/developer-desktop-plan-1604/ | 14:28 |
| seb128 | willcooke, what tz is that in? utc? | 14:28 |
| willcooke | seb128, I think so | 14:28 |
| seb128 | so yes | 14:29 |
| willcooke | thx | 14:29 |
| mhall119 | yes, it's UTC | 14:30 |
| willcooke | mhall119, meeting done quickly. | 14:38 |
| willcooke | mhall119, so fire away | 14:38 |
| mhall119 | hey willcooke, I was asking for UOS sessions for next week, we have the developer desktop planning on already, but are there any others from your team that we can put on the schedule? | 15:02 |
| willcooke | mhall119, we've added a QA one too | 15:02 |
| mhall119 | ok, any others you can think of? | 15:03 |
| willcooke | other than that, there isn't anything else we need to meet about, the general 16.04 will cover everything we need to cover | 15:03 |
| mhall119 | ok | 15:03 |
| tkamppeter | seb128, I have checked now and Debian has pysmbc 1.0.15.4-1 with binary package names python-smbc and python3-smbc, we have python-smbc 1.0.15.4-0ubuntu1 with the same binary package names. | 15:05 |
| tkamppeter | seb128, how should I proceed to sync Debian's packages? Simply syncpackage pysmbc? Or do I (or the Debian package maintainer) do anything additional, for example to get the old python-smbc source package removed? | 15:06 |
| seb128 | tkamppeter, the source needs to be removed from http://people.canonical.com/~ubuntu-archive/sync-blacklist.txt | 15:14 |
| seb128 | then we need to remove the ubuntu specific source | 15:14 |
| tkamppeter | seb128, can I already syncpackage the new ones? The version number of Debian is "newer" so with both the python-smbc source package from Ubuntu and the pysmbc source package from Debian in our archive the Debian binary packages should be picked by installation processes. | 15:18 |
| seb128 | tkamppeter, you can try | 15:18 |
| tkamppeter | seb128, the sync is blocked by the blacklist. Who can remove the entry? | 15:20 |
| seb128 | tkamppeter, I probably can, let me have a look | 15:21 |
| seb128 | or I see that you pinged Colin | 15:21 |
| tkamppeter | seb128, if you can, simply do. | 15:21 |
| seb128 | tkamppeter, done | 15:23 |
| tkamppeter | seb128, thanks. | 15:24 |
| seb128 | yw | 15:24 |
| tkamppeter | seb128, how long does it take for really getting active? | 15:25 |
| seb128 | that I don't know | 15:25 |
| seb128 | Colin should know though | 15:25 |
| tkamppeter | seb128, now pysmbc is introduced as a new source package probably going into Universe, but the binary python3-smbc is in Main and the new one should continue in Main. What needs to be done here. | 15:29 |
| seb128 | tkamppeter, I've accepted it to main | 15:33 |
| tkamppeter | seb128, Thanks. | 15:33 |
| tkamppeter | seb128, and how will the old, now useless, python-smbc source package be removed? Can you simply remove it? | 15:35 |
| seb128 | yes, going to do that once the new is built | 15:35 |
| ricotz | Sweet5hark1, do you intend to push a xenial build for 5.0.3 to the ppa too?? | 15:54 |
| Sweet5hark1 | ricotz: not really | 16:01 |
| Sweet5hark1 | ricotz: will work on 5.1 alpha for xenial | 16:01 |
| ricotz | Sweet5hark1, hmm, will do it then | 16:01 |
| ricotz | (to cope with python3.5 and poppler) | 16:01 |
| ricotz | Sweet5hark1, see pm | 16:02 |
| === davidcalle is now known as davidcalle|afk | ||
| sethj | Trevinho, got my timezones all mixed up so I'm not sure exactly when morning is for you, but I found the issue behind the empty trash bug. | 16:41 |
| Trevinho | sethj: hey | 16:41 |
| sethj | and I *think* I fixed it. | 16:41 |
| sethj | I mean, I fixed it and everything seems to work still haha. it was pretty simple so there shouldn't be any room for breaking something else. | 16:43 |
| Trevinho | sethj: I've seen the change... | 16:44 |
| sethj | The ... doesn't make me feel good D: | 16:44 |
| Trevinho | However that causes another issue: so basically the "empty trash" dialog might not be focused | 16:44 |
| Trevinho | i.e. if you write something in gnome-terminal or gedit, then you empty the trash, the dialog won't be focused | 16:45 |
| Trevinho | That's because we need to send the action timestamp... The way i'm doing it's hackish I think | 16:45 |
| Trevinho | sethj: the proper solution would be to fix the Nautilus dbus API to get the action timestamp as parameter. | 16:45 |
| Trevinho | sethj: another possibility instead is to do what you did, and... To change nautilus to force opening that dialog in front always | 16:46 |
| Trevinho | that can be done by using gtkx stuff, but it's a little hackish | 16:46 |
| Trevinho | I guess having proper API would be better | 16:46 |
| sethj | Trevinho, let me do some more testing on the focus issue. The dialog always raised in focus for me.. | 16:47 |
| sethj | That makes sense why the Activate call was there then. That was really confusing me (hence the suspicion that something was off with my fix) | 16:48 |
| Trevinho | sethj: the related bug was https://bugs.launchpad.net/ubuntu/+source/unity/+bug/807808 | 16:48 |
| ubot5 | Launchpad bug 807808 in Unity "Empty trash dialog sometimes dont have the focus" [Medium,Fix released] | 16:48 |
| sethj | Trevinho, cool. I'm no wizard, but I will take another look. | 16:49 |
| Trevinho | sethj: thanks for taking care of this issue :) | 16:49 |
| tkamppeter | seb128, seems that the new pysmbc has correctly made it into the archive now. so the old python-smbc can get removed. | 16:52 |
| seb128 | tkamppeter, k, thanks | 16:52 |
| didrocks | ok, headache too strong, needs to take a nap, see you tomorrow guys | 16:53 |
| sethj | Trevinho, do you have any more precise steps to reproduce? The dialog always appears on top and in focus.. | 16:55 |
| Trevinho | sethj: you need to write in some gnome app, then right-click the trash icon and select empty the trash.. | 16:57 |
| sethj | Trevinho, that's what I'm doing... | 16:57 |
| Trevinho | sethj: maybe something changed at nautilus level nowadays, so it might be not neeeded... | 16:57 |
| sethj | Trevinho, so I tried slack, gedit and gnome-terminal. with text typed and the text fields in focus the dialog still takes focus and the buttons can be manipulated from the keyboard.. | 16:58 |
| Trevinho | sethj: you also have to ensure that no nautilus window was opened.. | 16:59 |
| sethj | Trevinho, nope. | 17:00 |
| Trevinho | sethj: basically, the same issue (the focus thing) happens if you go in the dash, files lens, open a folder preview -> press on "Open" button | 17:00 |
| Trevinho | That action doesn't use the proper activation (there's no timestamp in previews, yet) so... The nautilus window instead of being focused, it gets opened underneath your latest used app | 17:01 |
| Trevinho | sethj: but... In case this has changed recently (as per some nautilus change), then we could try your fix | 17:02 |
| sethj | Trevinho, I can't reproduce the dash issue either. | 17:02 |
| sethj | I might have noticed one regression though, testing.. | 17:02 |
| Trevinho | mhmh, sethj have you maybe disabled the compiz focus stealing prevention? | 17:03 |
| Trevinho | sethj: in ccsm -> general -> Focus and behavior -> Focus prevention level by default is "low" | 17:04 |
| sethj | Trevinho, ahh, yes, I believe I did. Why is that at low? It's so awful. | 17:04 |
| Trevinho | sethj: well, the thing is that if you're writing something... And something opens, the focus shouldn't be moved away | 17:05 |
| Trevinho | or you risk to continue writing, pressing keys in another window | 17:05 |
| sethj | ah, right. | 17:06 |
| sethj | Now that I think about it that happened to me during the Wily upgrade. | 17:06 |
| sethj | yup, if I put focus prevention on low the dialog doesn't raise with focus. | 17:07 |
| sethj | grr. | 17:07 |
| Trevinho | so... Yeah, the only way we have do do this cleanly is to add a timestamp parameter to nautilus API | 17:08 |
| Trevinho | This won't work when not using nautilus (i.e. elementary file manager used to work), but well... Not supporting ubuntu default is hard | 17:09 |
| sethj | honestly I wish the default was Thunar :P Okay, I'll see if I can fix it differently. | 17:10 |
| Trevinho | You can add an XUbuntuEmptyTrash method with timestamp parameter | 17:11 |
| Trevinho | and... if you want thundar to support it, it has to be patched as well | 17:11 |
| sethj | Trevinho, there's no real point IMO since Unity doesn't support changing the default file manager anyway.. | 17:14 |
| sethj | but I'll see what I can do with nautilus. I'm not sure I understand what makes the timestamp so crucial though.. | 17:15 |
| Trevinho | Mh, I see | 17:15 |
| Trevinho | sethj: basically you should use gtk_window_present_with_time... | 17:16 |
| Trevinho | sethj: now, there's a trick to get the current time from Xserver, and just use that value without passing it | 17:17 |
| Trevinho | but, the right way to do this, is to use the timestamp of the event that triggered the action | 17:17 |
| sethj | Trevinho, that's really helpful, but my first question was why adding a timestamp argument to the API fixes the issue. Does that somehow let it bypass the focus prevention? | 17:21 |
| Trevinho | sethj: yeah, basically there's a workaround to activate a gtk app by passing the timestamp via a gtk action... | 17:43 |
| Trevinho | sethj: it worked fine so I didn't change the API... But I didn't think to this sideeffect | 17:44 |
| larsu | ..... but please don't | 17:44 |
| sethj | Trevinho, ahh. | 17:44 |
| * larsu hopes will disallow apps from doing this | 17:44 | |
| larsu | *mir | 17:44 |
| sethj | well mir will have to workout the other focus bugs then. | 17:45 |
| larsu | which other focus bugs? | 17:45 |
| sethj | larsu, the ones Trevinho has been working around. e.g. https://bugs.launchpad.net/ubuntu/+source/unity/+bug/807808 | 17:56 |
| ubot5 | Launchpad bug 807808 in Unity "Empty trash dialog sometimes dont have the focus" [Medium,Fix released] | 17:56 |
| larsu | Trevinho: wow! Why aren't we just fixing this in nautilus? | 17:58 |
| larsu | sethj: clearly the window manager shouldn't need to work around such issues | 17:58 |
| Trevinho | larsu: I do agree, but it needs an API change | 18:00 |
| Trevinho | dbus Api change, or DBus api addition | 18:00 |
| larsu | Trevinho: because it's an action activation? | 18:00 |
| larsu | doesn't that take platform data already? | 18:01 |
| Trevinho | nope | 18:01 |
| larsu | ah, this is still the old stuff with the command line? | 18:01 |
| === alan_g is now known as alan_g|EOD | ||
| seb128 | that might be fixed in newer nautilus versions? | 18:06 |
| larsu | seb128: I don't know if it has been converted to a dbus-activaeted app yet | 18:08 |
| larsu | I don't think it has | 18:09 |
| seb128 | larsu, https://git.gnome.org/browse/nautilus/commit/?id=a5617016d3e5d8e32ce02708f2c08d09926141d1 | 18:12 |
| seb128 | but unsure that's enough/what you mean | 18:13 |
| larsu | oh, that doesn't include the trash thing | 18:14 |
| larsu | is this hard coded in unity maybe? | 18:14 |
| Trevinho | larsu: yeah, for now we used an ugly workaround by http://pastebin.ubuntu.com/13001134/ | 18:26 |
| sethj | Trevinho, wow, so is the entire activate method just to "fix" the no focus bug? | 18:27 |
| Trevinho | sethj: yeah... | 18:27 |
| sethj | ouch. | 18:27 |
| * Trevinho leaves | 18:36 | |
| nessita | hello everyone! quick question: I upgraded to Wily on my Lenovo Thinkpad X201 and the battery icon is missing, and so are the power settings | 19:31 |
| nessita | is there any package I should check is installeD? | 19:31 |
| nessita | indicator-power shows as installed at the newest version | 19:32 |
| willcooke | g'night all - see you next week | 19:52 |
| === davidcalle|afk is now known as davidcalle | ||
| === howefield_afk is now known as howefield | ||
| === howefield is now known as howefield_afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!