=== maclin1 is now known as maclin
=== nudtrobert1 is now known as nudtrobert
=== maclin1 is now known as maclin
=== broder_ is now known as broder
* Guest42341 such a beautiful day, today. great for science and such05:22
=== larsu_ is now known as larsu
=== jamesh_ is now known as jamesh
Mirvheh, I was going to "quickly grab" the unity8 audio role patch for the xenial Qt 5.5.1 build, but it depends on use_quick_24 which depends on use_sdk_13 so I'll just instead remove the two lines from QML files :)09:31
tsdgeosSaviq: mzanetti: since we regularly forget to run make pot_file do you think i should add items to the checklist in both submit and review saying "HAve you run make_pot if there's new i18n messages"?09:47
Saviqtsdgeos, maybe we can automate that09:48
tsdgeosSaviq: as in?09:49
mzanettisounds like a silo thin09:49
Saviqmzanetti, bug #135966709:49
ubot5bug 1359667 in CI Train [cu2d] "There should be a hook mechanism available" [Undecided,Incomplete] https://launchpad.net/bugs/135966709:50
Saviqbut tsdgeos, have a test that updates the .pot and compares it with the one in source (ignoring newlines and header etc.)09:50
Saviqbut yeah, maybe time better spent on trying the approach proposed by robru in the bug09:50
tsdgeosi agree with him that commiting from the build bots is scary09:51
tsdgeosi think i kind of prefer the suggestion to have a test09:52
tsdgeosor maybe just run make_pot as part of make09:52
Saviqtsdgeos, don't want that, we'll get .pot updates with every MP09:52
Saviqat least not unconditionally09:53
* Saviq don't see a problem with build bot committing09:53
tsdgeosactually i shouldn't eihter since it's what we have in KDE :D09:54
tsdgeosbut somehow here us doing it instead of a site-wide script makes me a bit more uneasy09:54
Saviqtsdgeos, oh yeah, the debian/rules approach makes me cringe, too, would much rather have an explicit hook mechanism09:59
Saviqbut since debian/rules is really just a Makefile, maybe it's workable10:00
tsdgeosSaviq: the question is, does the thing thar run debian/rules actually have commit power on the repo?10:03
Saviqtsdgeos, don't think so, not today indeed10:05
Saviqso we'd need the train to do something anyway10:05
Saviqat which point might as well have a custom solution10:05
Saviqtsdgeos, oh well, they do run clean when bzr is available, so should be fine10:07
Saviqbut we'd need to have a condition on which to hinge whether we do it or not, that the train would make true (like an env var)10:08
tsdgeosseems like that'd be close to "a hook" :D10:09
tsdgeosfaenil: i didn't set https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1431328 since i could never reproduce it10:27
ubot5Ubuntu bug 1431328 in unity8 (Ubuntu) "build.sh --setup doesn't install build dependencies" [Low,Confirmed]10:27
tsdgeosso no idea if it's fixed or not, maybe you can try to reproduce it or give us some more steps?10:28
tsdgeosmzanetti: isn't it a bit bad to have almost duplicated code in Unity/Launcher  vs Greeter/Unity/Launcher ?10:30
mzanettitsdgeos, there's not so much duplicate, is there?10:32
mzanettiit's a different implementation of a backend10:32
tsdgeosmzanetti: quicklistentry, quicklistmodel, launcheritem10:33
tsdgeosproblem is they have small differences10:33
mzanettitsdgeos, well, that's the api definition10:33
tsdgeosand the untrained eye can't decide if it's because people forgot to update them10:33
tsdgeosor because it actually needs to be different10:33
mzanettiobviously it needs the same classes10:33
mzanettitsdgeos, what do you suggest?10:34
tsdgeose.g. one has10:34
tsdgeosif (countVisible) setAlerting(true);10:34
Saviqmaybe we can abuse Qt/QML revisions? :)10:34
tsdgeosand the other has not10:35
Saviqand export Unity.Launcher with rev 1, and Greeter.Unity.Launcher with rev 2?10:35
tsdgeosand i guess this is a "correct" difference for greeter vs non-greeter10:35
mzanettitsdgeos, yes... well, the bigger difference is actually how the models are filled10:35
mzanettione has access to the system, the other only to accounts-service10:36
faeniltsdgeos: sorry, I'll try again and see if it works now.10:36
tsdgeosi guess we could share those 3 files in a lib10:36
tsdgeosbut maybe it's me just being annoyin :D10:36
Saviqsince nobody related to what I wrote, maybe it's just too crazy, but mzanetti, tsdgeos maybe we can abuse Qt's revision mechanism and export different revisions to Unity. and to Greeter.Unity.? or did you not respond because you hate that idea? ;)10:40
mzanettitbh I'd need to read up on that first to form an opinion10:40
tsdgeosSaviq: i think it's unneeded since it's basically C++ code that is dupe, we can "fix" with simpler solutions if we think is a problem10:41
mzanettiSaviq, you mean just using different import versions?10:42
Saviqmzanetti, no10:42
Saviqmzanetti, basically, you can declare the same method multiple times, marking them with a different revision10:42
Saviqmzanetti, then, as you register the plugin, you say which revision you want10:42
mzanettiah so we'd have just one plugin, which implements some methods multiple times10:43
mzanettisounds like it could work...10:43
Saviqso you can have two different implementations of the same method in the same .so, and depending on which plugin you import you get one or the other10:43
Saviqs/which plugin you import/which import you use/10:43
mzanettibut also sounds like you better test that first as for sure you'll run into corner cases10:43
Saviqoh sure, and maybe not even in this case, but we should keep that possibility in mind10:44
mzanettiyes... I really need to use that at some point... when you write apps usually that revisioning stuff is not really needed...10:44
Saviqyeah, it's usually only useful for backwards compat10:46
Saviqso not really for unity8 either10:46
Saviqwe *could* think of applying that to all the bits that implement unity-api APIs, but probably too early for that still10:47
faeniltsdgeos: ah that's why I didn't provide any info, you replied "it's the first run of build.sh that installs the build deps" but in the comment above I say that I ran build.sh -s and then build.sh10:48
Saviqfaenil, let me come to you :)10:48
=== marcusto_ is now known as marcustomlinson_
=== marcustomlinson_ is now known as marcustomlinson
Saviqtsdgeos, could you have a look at https://code.launchpad.net/~larsu/gsettings-qt/lp1503693/+merge/276190 ?11:15
tsdgeosSaviq: as in, confirm the bug exists and this workarounds it?11:15
tsdgeosfix the qt bug?11:15
Saviqtsdgeos, seb128 asked for a review of ↑, but if we can fix the Qt bug, might be better ;)11:16
seb128Saviq, +1!11:16
tsdgeos"can fix" is a pretty broad statement :D11:17
tsdgeosi'm sure we can fix it, but it may take much more than those 3 lines :D11:17
tsdgeosbut anyway yes i'll have a look11:17
tsdgeosi already had a look to it tbh11:17
tsdgeosbut i'll have a second and approve if that's what you guys want11:17
=== dandrader is now known as dandrader|bbl
mterrygreyback_, heyo, poke about the no-touch-no-lifecycle branches.  They are in our silo, but I realized they aren't approved yet.  Would like to get them cleared, since other branches have started to pre-req them13:39
PrasadHi, is anybody working on fix for bug # 115436413:57
greyback_mterry: on it14:11
mterrygreyback_, also I made a small change to the unity-api branch after you had approved it -- Saviq caught me not incrementing the VERSION for unity-shell-application14:13
mterrygreyback_, so might want to give that a look over again14:13
PrasadHi, I'm a C++ software , and willing to contribute to unity bug fixes14:18
=== mardy_ is now known as mardy
=== dandrader_ is now known as dandrader
tsdgeosSaviq: so do we want cimi to run make pot_file on lp:~cimi/unity8/preview-sharing or lading it "broken" and update it later?14:37
Saviqtsdgeos, we'll rebuild silo 21 so yeah14:40
Saviqcimi, ↑14:40
cimiSaviq, oki14:41
tsdgeosSaviq: mzanetti: opinion on https://code.launchpad.net/~aacid/unity8/coding_update/+merge/276662 ?14:42
mzanettitsdgeos, +1 for less redundancy14:48
cimitsdgeos, I like having some information already in the package, shall we leave a bit and point to the website for "more details"?14:49
cimilike, usually when I download some new source code, I grep for README/HACKING for quick build instructions14:49
tsdgeoscimi: what would you leave of what i removed?14:51
cimitsdgeos, maybe just build and a simple run14:52
tsdgeosdandrader: your "let's keep it closer to the code so it's update" has been proved wrong14:56
tsdgeosthe web is up to date, that file is not14:56
tsdgeostrue is that i updated the web so i'm half cheating14:56
tsdgeosbut it was still more up to date that the file14:56
tsdgeosbefore i updated it more14:56
dandradertsdgeos, you need special rights to edit that web page? it's not even a wiki14:59
tsdgeosdandrader: yes it's not a wiki15:00
tsdgeosit's a wordpress instance15:00
dandradertsdgeos, I recall mhall119 was trying to get it up to date before...15:00
dandraderbut a hard job as he's not involved in the daily development15:00
Saviqit should probably be in our source and updated from there automagically on the website15:01
mhall119dandrader: you just need to be in the right LP team and then go to unity.ubuntu.com/wp-admin/15:01
dandraderSaviq, that's my opinion as well15:01
mhall119~unity-website-editors is the team15:01
tsdgeosSaviq: ideality is nice, who's going to write that wordpress plugin ? :D15:02
tsdgeosdandrader: Saviq: we could link from the web to http://bazaar.launchpad.net/~unity-team/unity8/trunk/view/head:/CODING15:04
tsdgeosit's less fancy15:05
tsdgeoswould also saves us from having to update stuff twice15:05
Saviqtsdgeos, I'm sure there is a wordpress plugin that imports rst or something from a url already15:05
Saviqand that url could very well be ↑15:05
dandraderWe could just ensure that CODING file follows some lightweight markup language and ta da!15:06
=== dandrader is now known as dandrader|lunch
tsdgeosSaviq: you moved https://code.launchpad.net/~cimi/unity8/sdk1.3_newUbuntuShape/+merge/271610 to needs review because of the flaky test, should we move back to approved? i remmeber you mentioning something about the flaky not being clocking?15:17
Saviqtsdgeos, yeah, will do15:17
mterrygreyback_, thanks for reviews!15:17
mterrytsdgeos, you approved the slim greeter branch?15:18
tsdgeosmterry: wrong click15:18
tsdgeosmterry: it should be back on needs review15:18
mterryjosharenson, btw I'm reviewing slim greeter as we speak15:18
tsdgeosplrease double check15:18
mterrytsdgeos, oh cool, LP must not have sent me email yet.  I'm reviewing the branch now actually15:19
josharensonmterry: cool, you saw the conversation I just had w/ tsdgeos in #unity?15:19
mterrymmm, no will read15:19
mterryjosharenson, ah cool15:19
tsdgeosjosharenson: mterry: the CI just passed :)15:19
mterryjosharenson, will avoid complaining about any qmluitest failures then15:20
mterryoh good15:20
josharensontsdgeos: cool maybe the thing I did last night worked then... chmodded the runtests.sh15:20
mterryjosharenson, so in terms of testing...  I'm confirming that there are no regressions on phone, and then confirming that the new greeter works on my desktop?  Anything else?15:22
mterryI guess test each of the modes real quick maybe15:22
josharensonmterry: uhhh I tested multi monitor... you can take my word for that15:23
cimitsdgeos, you got my message about two columns?15:24
tsdgeoscimi: i did15:24
tsdgeosbut there was "no message" D15:25
tsdgeosjust a forward15:25
tsdgeoswhat do i do with it?15:25
cimitsdgeos, I wrote here but probable I was disconnected15:25
cimitsdgeos, design asked me to increase those paddings15:25
cimias you read the mail15:25
cimitsdgeos, also, potfiles were updated too in the branch you needreviewed15:26
tsdgeoscimi: in the past or just now?15:26
cimi20 mins ago15:26
tsdgeoscimi: forgot to push?15:26
cimitsdgeos, I did15:27
tsdgeoswait i'm looking at the wrong MR15:27
cimi"meh" :D15:27
tsdgeosback to approved15:28
=== dandrader|lunch is now known as dandrader
tsdgeoscimi: be careful when moving those margins15:37
cimitsdgeos, yeah...15:37
tsdgeosthey'll complain later again when the composition is differnet :D15:37
cimitsdgeos, do we have any code or place that gets enabled for two column layout?15:37
cimiis everything in Preview.qml?15:37
tsdgeosnot sure what you mean15:38
tsdgeosPreview.qml decides the number of columns yes15:38
tsdgeosproperty int columns: width >= units.gu(80) ? 2 : 115:38
tsdgeosshould be readonly if you're going to modify that file15:39
larsuSaviq: are you planning on landing the gsettings-qt patch?16:40
=== dandrader is now known as dandrader|afk
mzanettidandrader|afk, I've moved the code over to Dialogs.qml... not sure if it's really better, but the argument to take some load from Shell.qml is a good one17:04
Saviqlarsu, I didn't, do you want us to?17:09
larsuSaviq: yes please, unless seb128 wants to...17:12
kgunnmzanetti: trying to locate a bug i think you logged, i couldn't find it, but in windowed mode/monitor connect u-s-c cpu is high ?17:14
kgunnmaybe i dreamed that17:14
Saviqkgunn, bug #149903917:14
ubot5bug 1499039 in mir (Ubuntu) "compositing never stops when external monitor is connected" [Undecided,Confirmed] https://launchpad.net/bugs/149903917:14
mzanettikgunn, I think Saviq logged it in the end, but I have seen the issue too17:14
Saviqseb128, could you take care of that landing please? I'm already on the naughty list in the train ;)17:15
=== dandrader|afk is now known as dandrader
cimiltinkl, you around?17:30
seb128Saviq, can do17:37
jcastrohi guys, I'm in xenial on the unity8 session18:02
jcastrothe one problem is it seems the lock screen is over the desktop18:03
jcastroso when I click on the launcher to launch apps I don't see them launching18:03
jcastroI suspect they're behind the lock screen18:03
jcastroputting my password in the lock screen turns the entire screen black, so I don't think that's what is supposed to happen18:03
Saviqjcastro, what release?18:29
jcastrothe latest in xenial, let me check18:31
Saviqjcastro, can you try a different user18:32
jcastroSaviq: 8.11+15.10.20151021-0ubuntu1 is the version of the unity8 package18:32
jcastrosame thing with a new test user18:34
jcastrowith either user I can't get past the unity8 lock screen18:35
Saviqjcastro, and you installed via unity8-desktop-session-mir?18:36
Saviqjcastro, and you select the unity8 session in the greeter?18:36
Saviqjcastro, can you clear ~/.cache/upstart/*, try again and see what you find there18:36
jcastrono change18:38
Saviqjcastro, didn't mean that would fix, but the logs could help then18:40
jcastrooh! ok I have a session, will investigate and come back later18:53
jcastrothanks for the tips18:53
jcastroalso is there a PPA I should follow? I don't mind breakage, I'm basically setting aside a machine for U818:54
Saviqjcastro, no ppa, everything goes straight into trunks and xenial19:02
jcastroman dude, look at all these logs, finally, a desktop that logs everything, I love you.19:03
Saviqjcastro, plenty more to be logged, but yeah, much better than .xsession-errors, 'innit ;)19:09
jcastronothing reallu jumps out as fatal-looking19:12
jcastrowe need WARN: and ERR: for grepability :)19:12
pmcgowanwhen we pair with a bluetooth keyboard do we suppress the OSK?21:15

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!