| === hikiko-lpt is now known as hikiko | ||
| === jzheng_ is now known as jzheng | ||
| handsome_feng | hi, everyone, sorry i'm latter | 08:35 |
|---|---|---|
| handsome_feng | late... | 08:36 |
| handsome_feng | marco ? eleni ? | 08:38 |
| Trevinho | hi handsome_feng | 08:38 |
| handsome_feng | hi :) | 08:38 |
| Trevinho | Ah, we have a meeting to day... But time changed here, so in theory it was in in 1 hour | 08:39 |
| Trevinho | is that too late for you? | 08:39 |
| handsome_feng | er , yes, maybe we can make this meeting tomoro ? | 08:41 |
| Trevinho | handsome_feng: no, well it's fine for me now... | 08:41 |
| Trevinho | I'm going to change the event | 08:41 |
| handsome_feng | OK | 08:43 |
| Trevinho | handsome_feng: it's 16:30 there, right? | 08:43 |
| handsome_feng | yes | 08:43 |
| Trevinho | err, 16:43... :P | 08:43 |
| handsome_feng | ... | 08:44 |
| handsome_feng | you are right | 08:45 |
| Trevinho | handsome_feng: no problem, let's do this quick and informal, there's no problem | 08:46 |
| Trevinho | handsome_feng: or.... I don't know... what's the best plan | 08:46 |
| handsome_feng | best plan of wizard ? | 08:47 |
| Trevinho | handsome_feng: so, I didn't get anything back from the design, let me ask willcooke | 08:48 |
| Trevinho | Ouch, he's still not online... | 08:48 |
| Trevinho | So, well I'll ask him later | 08:48 |
| handsome_feng | @Trevinho OK, no problem | 08:48 |
| Trevinho | However, I'd say your design is mostly fine. You can proceed with that, at least the logic part... Then if we need to tune the UI there's time. | 08:48 |
| Trevinho | Ah, you need to handle also multi-monitor, I'd do the same as it's done in the lockscreen... | 08:49 |
| Trevinho | So show that view in the monitor where's the pointer is | 08:49 |
| handsome_feng | OK, Got this | 08:50 |
| handsome_feng | Hi, willcooke | 08:51 |
| willcooke | hi handsome_feng | 08:52 |
| handsome_feng | we are just talk about the wizard | 08:52 |
| Trevinho | willcooke: hey, did you get anything back from John/design about the wizard? | 08:52 |
| willcooke | Not quite yet, but they are due to review "real soon now" | 08:52 |
| willcooke | I will chase him now and see if I can get a time line | 08:52 |
| Trevinho | nice | 08:53 |
| handsome_feng | Thank you , so let's wait :) | 08:54 |
| handsome_feng | marco, anything else about the lockscreen ? | 08:57 |
| Trevinho | handsome_feng: no, I've seen you're still working on it... Are you already ready for a review? | 08:58 |
| handsome_feng | I have not write the autopilot test ... | 08:59 |
| Trevinho | Well, those are a little hard to do in the lockscreen, you can add some unit-tests if you want | 09:00 |
| Trevinho | but autopilot is complicated there | 09:00 |
| handsome_feng | And also should handle some detals | 09:00 |
| Trevinho | Ok, fine... Once you're ok, feel free to propose the merge request, and I'll review it | 09:00 |
| Trevinho | I've seen some progress also in the launcher rotation... | 09:01 |
| handsome_feng | Yes, I just add the option about launcher position | 09:01 |
| Trevinho | Ah, one thing I've seen there that you should change: you added a sigc::signal<void> launcher_position_changed; | 09:01 |
| Trevinho | But you don't need that... just use nux::RWProperty<LauncherPosition> launcher_position; (just use nux::Property) | 09:02 |
| Trevinho | and that gives you the signal for free | 09:02 |
| Trevinho | so you can just do | 09:02 |
| Trevinho | launcher_position.changed.connect() ... | 09:02 |
| Trevinho | Also, maybe, instead of using LauncherWidth/LauncherHeight, we can just use LauncherSize at this point | 09:03 |
| handsome_feng | er, i put it there and just forget it ... | 09:03 |
| Trevinho | You rename that value and use for both the cases. | 09:03 |
| handsome_feng | ok, i have do this in some small functions | 09:03 |
| Trevinho | good | 09:05 |
| Trevinho | Ah, I wanted to mention that the list of bugs we want to target for 16.04, have now been moved to | 09:05 |
| Trevinho | http://reqorts.qa.ubuntu.com/reports/rls-mgr/rls-x-incoming-bug-tasks.html | 09:05 |
| Trevinho | The same as searching for the "rls-x-incoming" tag in launchpad, but shows all the projects involved | 09:06 |
| handsome_feng | And i should use launcher_position.changed to info the dash/launcher/panel to redraw , right ? | 09:06 |
| Trevinho | So,. if you think there's anything important, you can just tag with that | 09:06 |
| Trevinho | handsome_feng: yep | 09:06 |
| Trevinho | handsome_feng: that property will both allow you to handle the value, and being notified when changed | 09:06 |
| handsome_feng | Trevinho: Thank you , got it | 09:07 |
| Trevinho | handsome_feng: you can look for examples around in the code, it's all quite easy | 09:07 |
| handsome_feng | ok , i just learn from the code too | 09:08 |
| Trevinho | Just remember that if you use lambda_functions to connect to signals, you need to disconnect from them (using a connnection::wrapper or a connection::manager)... Otherwise you might experience crashes. | 09:08 |
| Trevinho | In xenial there's also the sigc::track_obj feature, but it's probably too early to use it. | 09:08 |
| handsome_feng | oh, write it down in my notebook | 09:10 |
| handsome_feng | Thank you for your advise , seems all things have discussed | 09:13 |
| handsome_feng | maybe we can wrap this up? | 09:14 |
| Trevinho | handsome_feng: yeah, sorry... I got int a bug :P... However yes | 09:17 |
| Trevinho | I think we're done. | 09:17 |
| Trevinho | Thanks | 09:17 |
| handsome_feng | Thanks ! and bye ! maro :) | 09:18 |
| handsome_feng | bye, willcooke ! | 09:18 |
| willcooke | see you | 09:18 |
| === jzheng is now known as jzheng_afk | ||
| === hikiko-lpt is now known as hikiko | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!