/srv/irclogs.ubuntu.com/2015/11/06/#juju-dev.txt

lazypowerIs this bit just some spam or have i encountered a bug? http://paste.ubuntu.com/13118294/00:02
davechen1ylazypower: yeah, that's not an awesome message00:02
davechen1yit doesn't give a hint _why_ the dependency is unavailable00:02
davechen1yie, should you wait, or should you declare defcon 400:03
lazypowerI just noticed that i dont have a leader in the service pool. Possibly related?00:04
davechen1yalmost certainly00:06
davechen1ybut that log message is shit00:06
davechen1yplease log a bug00:06
mupBug #1513667 opened: Better error messaging around uniter failure <juju-core:New> <https://launchpad.net/bugs/1513667>00:19
mupBug #1513667 changed: Better error messaging around uniter failure <juju-core:New> <https://launchpad.net/bugs/1513667>00:22
mupBug #1513667 opened: Better error messaging around uniter failure <juju-core:New> <https://launchpad.net/bugs/1513667>00:25
mupBug #1513671 opened: juju bootstrap fails <local-provider> <network> <wily> <juju-core:New> <https://launchpad.net/bugs/1513671>00:40
mupBug #1513671 changed: juju bootstrap fails <local-provider> <network> <wily> <juju-core:New> <https://launchpad.net/bugs/1513671>00:43
mupBug #1513671 opened: juju bootstrap fails <local-provider> <network> <wily> <juju-core:New> <https://launchpad.net/bugs/1513671>00:46
menn0thumper: phew. here's the machine agent symlink improvements: http://reviews.vapour.ws/r/3082/01:20
thumperm'kay01:21
menn0this makes setting the symlink for juju-dumplogs a piece of cake01:21
thumperjust going through the rename branch suggestions you had01:21
thumpermenn0: http://reviews.vapour.ws/r/3072/01:24
* menn0 looks01:24
thumpermenn0: shipit01:29
menn0thumper: thanks01:30
thumpernp01:30
menn0thumper: ship it with a bunch more things to change01:38
* thumper sighs02:03
thumperoh FFS02:03
thumperI feel that this is never ending02:03
* thumper looks for a knife so he can finish it all...02:04
natefinchthumper: have you looked at using gorename?  It won't find things to rename, but it should type-safely rename all copies of type/method/etc02:14
thumpernatefinch: that isn't the problem...02:15
thumperthere are many methods with System in the name02:15
thumpersystem in docs02:15
thumperhelp docs02:15
thumpervariable names02:15
thumperspewed everywhere02:15
thumperenvironment rename will be worse02:15
davechen1ythumper: tried the vpn02:21
davechen1yno job02:21
davechen1yjoy02:21
davechen1ysee email, i'm waitin on the ibm contact to fix02:21
thumperdavechen1y: did you try using the name rather than the ip address?02:21
thumperI think that was in the email thread02:22
davechen1yi'm using the openconnect strink that popey used02:25
davechen1yi have no problem conneting to the service02:25
davechen1ybut my credientials expired 5/11/201502:26
davechen1yi don't know which timezone that is02:26
davechen1ybut they need to be refreshed and I cannot do that because the interface to do so is behind the vpn02:26
thumperhazaah02:38
thumpermagical02:38
* thumper goes back to smashing his head against the table02:39
* thumper sadface02:47
thumperjust came across another intermittent failure in worker/provisioner02:47
davechen1ythumper: would you care for a break and a chat about the various charm.* types in state ?02:47
menn0thumper: juju-dumplogs work is done: http://reviews.vapour.ws/r/3075/diff/#02:48
thumpersure, two minutes02:48
menn0this is what you've reviewed + the symlink stuff02:48
menn0no rush02:48
natefinchthumper: what's the error you're seeing?  I was getting a weird error in provisioner earlier today02:48
natefinchthumper: http://pastebin.ubuntu.com/13115387/02:49
thumpernope, http://paste.ubuntu.com/13121047/02:49
natefinchhmm02:49
thumperdavechen1y: 1:1 hangout02:52
davechen1ythumper: yup02:52
davechen1yjust getting my other laptop02:52
davechen1y        return insertAnyCharmOps(&charmDoc{02:54
davechen1y                DocID:        curl.String(),02:54
davechen1y                URL:          curl,02:54
davechen1ythumper: oh oh, maybe reflect.DeepEqual will do all the magic we need03:10
davechen1ygonna run some test03:10
davechen1ygonna run some tests03:10
* thumper feels sad03:11
thumperwe have a method ConnectStream that takes a path and attrs03:11
thumperand every single test passes nil for the attrs03:11
cheryljwallyworld: ping?03:13
davechen1ythumper: if that parameter is 99% unused, especially in the default case03:14
davechen1yit should be removed03:14
davechen1yand a second method added for the case that needs the second parameter03:14
thumperno, real use passes it in03:14
thumperbut our tests don't test03:14
davechen1ywhere is the emoji for jaw hitting table03:15
thumpermenn0: looks like I'm implementing the juju/api and apiserver bits for NoTail for debug log just to get the freaking tests passing...03:25
menn0thumper: well that takes care of the that bug 1390585 then  :)03:26
mupBug #1390585: juju debug-log and EOF <debug-log> <landscape> <juju-core:Triaged by menno.smits> <https://launchpad.net/bugs/1390585>03:26
* menn0 assigned the card to thumper and moves it to "in progress" :-p03:26
thumper\o/03:26
davechen1ythumper: I have 7 version of juju/charm in my GOPATH03:32
davechen1y4 released, 3 unreleased03:32
thumper\o/03:32
davechen1ythis scares the piss out of me03:32
davechen1yhow did we not manage to insert invalid data into mongo ?03:33
natefinchdid something change with how machine numbers are assigned?  I seem to be getting machine 0, 1, 3, 8 (+-1) instead of reliably 0 1 2 3 403:41
davechen1ynatefinch: yes, they are now assigned exponentially03:41
menn0natefinch: didn't you change something in this area recently?03:41
natefinchmenn0: yeah, the unit assignment now runs on a worker... but in theory that shouldn't have changed how the machine  numbers are assigned.  That code is the same, it's just getting run slightly later.03:42
menn0natefinch: granted, but given the locality of the change...03:42
natefinchmenn0: oh sure, my first assumption was that it was my fault :)03:43
menn0:003:43
menn0:) even03:43
* thumper chucks it in for the week03:46
thumperlaters03:46
natefinchwell crap, I suppose I should just revert my unit assigner merge until such a time as I can fix these bugs....04:21
natefinchgah, what the hell is the magic incantation to tell CI that I'm trying to merge the fix to the blocker?04:36
natefinchsinzui: don't suppose you're around?04:38
natefinchwallyworld: you around?04:43
natefinchor menn0 ?04:43
wallyworldmaybe :-)04:43
natefinchhow the hell do I mark my PR as fixing the blocking bug?04:44
wallyworldzup?04:44
menn0natefinch: $$fixes-NNNNNN$$04:44
wallyworld$$fixes-12345$$04:44
menn0ha :)04:44
natefinchI friggin' have that in my first comment...04:44
wallyworldwhich pr?04:44
natefinchhttps://github.com/juju/juju/pull/367904:44
wallyworldit needs to go in the merge command04:45
wallyworldnot the cover description04:45
menn0actually, I don't think it has to be in the merge command04:45
wallyworldsure?04:45
menn0but it has to be in a comment, not the description04:45
wallyworldyup04:46
natefinchdumb04:46
wallyworldthat's what i meant04:46
menn0yeah, i'm pretty sure you can do fixes-NNNNNNN in one comment and then separately do $$merge$$ later04:46
menn0$$fixes-NNNNNN$$ is just the most convenient way to do it04:46
natefinchit would be nice if the error message more clearly indicated how to fix the problem.04:49
natefinch(and if we checked the description as well :/)04:51
wallyworldnatefinch: Build failed: Does not match ['fixes-1513552']   is not clear enough?04:52
natefinchwallyworld: no.  It doesn't say how to get the PR to merge. It says something does not match something else.  There's zero context.04:53
wallyworldthere is a tiny bit of assumed knoweldge there04:53
natefinchIt only takes 30 seconds to write a better error message to avoid confusion.  For example, it could say that the string 'fixes-NNN' must be in a comment, not the description.04:54
menn0natefinch: suggest it to mgz_ and it might happehn04:55
natefinchTarget branch is blocked by a critical bug (http://pad.lv/NNNNN).  If this PR would fix that bug, include the string 'fixes-nnnn' in a comment (not the description) on this PR, before using $$merge$$.04:56
natefinchmenn0: will do04:57
natefinchdavechen1y: what is this, java? https://github.com/juju/juju/blob/master/state/unit.go#L73905:09
natefinchdavechen1y: related: https://github.com/juju/juju/blob/master/apiserver/client/status.go#L66005:11
frobwarej07:57
davechen1ynatefinch, nailed it08:18
rogpeppe1wallyworld: ping09:51
voidspacedimitern: frobware: grabbing coffee, be three minutes09:59
dimiternomw as well10:00
voidspaceomw10:07
voidspacedimitern: frobware: gah, firefox misbehaving - having to restart browser10:08
perrito666wallyworld: still here?10:44
wallyworldperrito666: hey11:48
wallyworldrogpeppe1: hi, you rang?12:46
rogpeppe1wallyworld: hiya12:46
rogpeppe1wallyworld: yeah, i just discovered that a PR of yours (that I reviewed!) broke stuff, and just wanted to check that you thought the fix was ok: https://github.com/juju/charm/pull/16712:47
=== rogpeppe1 is now known as rogpeppe
wallyworldoh no, looking12:47
wallyworldrogpeppe: seriously? I mesed up capitisation?12:48
wallyworldsigh12:48
rogpeppewallyworld: np12:48
rogpeppewallyworld: easy to do12:48
wallyworldty for fixing12:48
wallyworldrogpeppe: i'll update the dep for core on monday12:49
rogpeppewallyworld: FWIW i recently started on a tool for automatic API compatibility checking. i'll try and move it forward - it would've helped here i think: https://github.com/rogpeppe/apicompat12:50
wallyworldoh, sounds nice, i'll look12:50
rogpeppewallyworld: (that's just a one day spike to see if it was viable so no tests or docs...)12:51
wallyworldsure :-)12:51
wallyworldrogpeppe: too tired to look properly now, but on my todo list12:52
rogpeppewallyworld: the basic idea is that you write out type info on all the types you're interested in (e.g. all the types that have been serialised/deserialised) to a file; then later you can check that the types are still compatible with what you wrote before12:54
wallyworldok12:56
cheryljfrobware: looks like this old bug has now become part of a crit sit:  https://bugs.launchpad.net/juju-core/+bug/138255613:21
mupBug #1382556:  "cannot allocate memory" when running "juju run" <cpe-critsit> <run> <juju-core:Triaged> <https://launchpad.net/bugs/1382556>13:21
cheryljfrobware: got anyone who can take a look?13:21
cheryljalexisb, fyi ^^13:22
frobwarecherylj, I can take a look as my current bug has stalled (broken tests).13:24
cheryljthanks, frobware13:26
dimiternfwereade, hey, so it seems you got back online before me :)13:30
fwereadedimitern, haha, yeah13:31
katcofrobware: hey14:28
frobwarekatco, what's up?14:28
katcofrobware: can i move the cards from sapphire's kanban to moonstone's for those bugs?14:28
frobwarekatco, please do14:28
katcofrobware: the ones that won't be finished anyway14:28
katcofrobware: perfect, ty!14:29
frobwaredooferlad, if you have chance today could you post links to your scripts for the HA bug, or better yet update the bug to reflect their location14:29
katcofrobware: lol oops, looks like i don't have permissions14:29
frobwarekatco, ^^^14:29
katcofrobware: dooferlad: yes, updating the bug would be perfect! ty for creating those14:30
dooferladfrobware: will do14:31
frobwarekatco, just updated your profile on kanban board, care to try again?14:31
* katco attempting14:32
katcofrobware: looks like it's working... ty14:32
katcofrobware: am i blind? i can't seem to find more than 1 card for all those bugs14:38
frobwarekatco, did you move the HA card?14:39
katcofrobware: yeah, that's the only one i could find14:39
frobwarekatco, I'm trying to remember whether they were there this morning (from planning) or they got nuked...14:40
frobwarefrobware, as I notice our archive has now been compressed to show 0 cards...14:41
frobwaredimitern, ^^ did you do some cleanup in the kanban board?14:41
katcofrobware: looks like there are some in the archive'd super-card14:42
frobwarekatco, I wouldn't dig through our trash - create a new card...14:43
katcofrobware: haha ok14:43
dimiternfrobware, nope, it automatically does that I think after 2 weeks14:45
frobwaredimitern, eco friendly. :)14:46
katcodimitern: o/ looking forward to seeing you again in dec.14:47
dimiternkatco, hey - yeah, it will be a change of pace for sure :)14:49
mupBug #1513671 changed: juju bootstrap fails <local-provider> <network> <wily> <juju-core:Invalid> <https://launchpad.net/bugs/1513671>16:01
natefinchkatco, ericsnow: that last 1 pointer is merging now... made the code review changes eric suggested and will do the IOC stuff in a separate PR.16:41
ericsnownatefinch: cool16:42
katconatefinch: but... but! i want to bikeshed more!16:42
fwereadekatco, I am inspecting something that might be a bikeshed right now... trying to figure out whether it's actually a good idea to close watcher Changes chans when the watcher stops16:54
katcofwereade: ah i think i remember when that came up16:54
fwereadekatco, because I *think* that it's an artifact of the lack of something-like-catacomb16:55
katcofwereade: wasn't the consensus that it's fine not to close it because the process would be torn down momentarily?16:55
katcolol16:55
katcosomething-like-catacomb16:55
katcohoenycomb?16:55
katcoparis?16:55
fwereadekatco, http://reviews.vapour.ws/r/3079/ ;p16:56
fwereadekatco, so I think the forces are16:56
katcooh catacomb is actually a thing16:56
fwereadekatco, when using a watcher you generally start it, defer a stop, and then select on changes forever16:57
fwereadekatco, and so your only (heh) channel for notification of watcher problems is the changes chan16:57
fwereadekatco, and closing it seems, eh, nice and idiomatic because then you could range over it, and it means "you're not getting any more values" so it seems to fit perfectly16:58
fwereadekatco, and so we can make the select loop aware of problems16:58
fwereadekatco, and then every select needs to check for that condition16:58
fwereadekatco, and `if !ok { return watcher.EnsureErr(w) }`16:59
katcofwereade: this idea seems very good... reading through code17:00
fwereadekatco, but I think the flaw is basically: just because you *can* use the changes chan for that notification does not mean you *shoul*17:00
fwereadekatco, so, with something like catacomb, if you bind the watcher's lifetime to the containing worker's and the worker's life to the watcher's lack of failure17:01
fwereadekatco, you'll get the something-is-wrong notifications direct to the Dying chan17:01
fwereadekatco, and the worker's tomb will actually have been hit with (something much more likely to be) the *first* error encountered in that goroutine tree17:02
katcoyeah... on the surface i really like the idea of encapsulating that coupling in a codified type17:02
fwereadekatco, another thing that I like is that it means we don't have to `defer watcher.Stop(`17:03
katcofwereade: it removes some of the discipline required to get watchers right17:03
fwereadekatco, which I have just realised is almost always subtly wrong17:03
fwereadekatco, because when the loop errors out and then a watcher fails for boring reasons, the watcher faillure hits the worker's tomb first17:04
katcofwereade: re: doc comment; i wouldn't worry about # of goroutines17:04
katcofwereade: i doubt we could spawn enough for it to really matter17:04
fwereadekatco, well, it is a fundamental difference -- a catacomb needs its own lifetime management17:05
fwereadekatco, once you New() you're responsible for it17:05
fwereadekatco, but maybe it's not important at that point in the doc17:05
natefinchfwereade: you need to move the core worker code into its own repo, so that catacomb can live in its own repo... we gotta stop hiding all this good code deep in the juju internals17:11
* fwereade blushes17:12
fwereadenatefinch, but, yeah, there is a chunk of worker-related functionality that's starting to want to move into its own repo17:12
natefinchfwereade: I think the quality of code goes up when we decide we want to be able to share it with the entire world, rather than keeping it buried in juju somewhere.17:13
fwereadenatefinch, yeah, could well be17:16
fwereadenatefinch, and this + dependency.Engine should go nicely together17:16
natefinchfwereade: yeah, all our really generic code like worker, dependency engine, catacomb, etc.  I think would be valuable to share with people.  Who knows, we might even get PRs against them (I know I have with some of my repos)17:17
fwereadenatefinch, although it's also seeming a bit like catcomb wants/ought to do error-ranking like dependency engine (and worker.Runner) do17:17
fwereadenatefinch, so I'm suspicious that I haven't got stable enough interfaces17:17
natefinchI think putting it in its own repo helps with that, too.  Easy to show to people, easy to view the godoc on godoc.org, forces you to write better documentation, include a readme, etc.17:18
fwereadenatefinch, on the one hand, that increases the resistance to putting it in its own repo; on the other, that's no goddamn excuse really, is it ;)17:18
natefinchyou can certainly put a disclaimer at the top that says it's still in flux.  I did that for https://github.com/juju/deputy17:19
fwereadenatefinch, yeah... but, sorry, gtg, bbiab I hope?17:20
natefinch..which, hey, has a PR against it :)17:20
fwereadenice :D17:20
natefinchfwereade: kk17:20
katcofwereade: ty17:20
natefinchgah17:21
natefinchI can't merge PRs under github.com/juju anymore :/17:22
natefinchkatco: can you give me write access to github.com/juju/deputy so I can merge PRs to it?17:23
katconatefinch: done17:25
natefinchkatco: thanks!17:28
jcastrocan a core dev give a nice answer to this one? http://askubuntu.com/questions/693689/juju-charms-rest-api17:36
mgz_natefinch: can we just set access on juju/deputy to the hackers group? or does it need to be just you?17:47
katcomgz_: i almost did the hackers group, but wanted to ask you first17:49
mgz_katco: we gernally have either that or bots - if the project has a good test suite we can make it gated and use bots, otherwise hackers means the magic erge button appears for all of us17:50
cheryljhey evilnick__ , someone pointed out to me today that the command usage statements on this page all have "no-highlight" in front of them:  https://jujucharms.com/docs/devel/commands17:51
katcomgz_: i could go either way17:51
evilnick__cherylj, ah yes, thanks for pointing it out - that is a bug in the rendering of the site. After a new release, the page gets automatically regenerated and in this case, it hasn't been patched to fix the problem. I will take care of it.17:54
cheryljthanks, evilnick__ !17:55
katcocherylj: are we going to do a 1.24.8?17:57
cheryljkatco: that is the $64,000 question17:59
katcocherylj: i'm going to mark the milestone as inactive. we can always turn it back on17:59
cheryljI think we'd like to avoid it, since we're going to try and get 1.25 back into trusty17:59
dimiterncherylj, in that line of thought, I've just proposed the fix for bug 148387918:14
mupBug #1483879: MAAS provider: terminate-machine --force or destroy-environment don't DHCP release container IPs <bug-squad> <destroy-machine> <landscape> <maas-provider>18:14
mup<sts> <juju-core:Triaged> <juju-core 1.24:In Progress by dimitern> <juju-core 1.25:In Progress by dimitern> <https://launchpad.net/bugs/1483879>18:14
cheryljawesome, thanks dimitern18:16
cheryljI'll take a look this afternoon18:16
dimiternfrobware, ^^18:16
dimiterncherylj, sure, I'd appreciate it - it's a bit quick-and-dirty in a few places, because I really want to get it out the door (1.24.8 will be the last 1.24 I hope), it should be tested better for 1.25/master18:17
cmarsjcastro, i don't have a working stackexchange account, but this would probably be helpful: https://github.com/juju/juju/blob/master/doc/api.txt18:29
cmarsjcastro, short of a nice library for accessing the api, which we don't have yet18:29
mgz_cmars: you can sso using lp, no?18:31
cmarsmgz_, oh, maybe so, there's a lp for this one, isn't there. ok18:32
mgz_well, anything that just needs an open id endpoint like stack overflow etc you can just paste your lp user page18:33
natefinchmgz_, katco: I'm fine with using the bot.  deputy has 94% test coverage.18:35
cmarsmgz_, got it. ok, i'll answer it :)18:35
wwitzel3natefinch, katco, ericsnow: ping18:54
katcowwitzel3: hey18:54
katcowwitzel3: tried to bootstrap lxd and got an error on the unix socket. controller machine is started. what am i doing wrong?18:58
wwitzel3katco: that's odd19:01
wwitzel3katco: what is the head of your lxd-branch?19:02
katcowwitzel3: 0a01db919:02
katcooh jees19:03
katcothat's what's wrong19:03
katco3 weeks ago19:03
katcoi must not have pulled19:03
wwitzel3lol19:03
katcothere we go... this should be a lot better19:03
katcothis provider is so nice19:04
katcono mongo on my host ^.^19:04
wwitzel3I uninstalled mongo19:04
wwitzel3completely, it is great19:04
katcoi recently switched machines and never installed juju-local19:04
katcoit's beautiful19:04
natefinchdon't you need mongo to run the tests?19:06
katconatefinch: i don't typically run all the tests, just the ones around what i'm working on19:07
katconatefinch: so far, hasn't been a problem, but i'm atypical19:07
mupBug #1513552 changed: master cannot deploy charms <blocker> <charm> <ci> <deploy> <regression> <juju-core:Fix Released by natefinch> <https://launchpad.net/bugs/1513552>19:10
natefinchericsnow, katco: is the bot supposed to work on the lxd-provider branch?19:13
katconatefinch: yeah19:13
ericsnownatefinch: yes, but it won't run our tests (runs Go 1.2)19:13
natefinchericsnow: right19:13
ericsnownatefinch: so we have some failing tests that got merged19:14
natefinchericsnow: ahh, I see the problem, I forgot to mark my test file as go1.319:15
katcoericsnow: natefinch: wwitzel3: you all ready to do the demos?19:27
ericsnowkatco: yep19:27
wwitzel3katco: yep19:28
natefinchyep19:28
natefinchkatco: can you make that juju/version repo and give juju-hackers write access to it?22:02
katconatefinch: sec, in a hangout debugging a charm22:02
natefinchkatco: no rush, just wanted to be able to work on that later on tonight...22:02
perrito666natefinch: see you have killer friday nights22:11
mupBug #1513982 opened: Juju can't find daily image streams from cloud-images.ubuntu.com/daily <streams> <juju-core:Triaged> <https://launchpad.net/bugs/1513982>22:29
jogericsnow, I just opened bug 1513982, it may be a dup of 1287949 but I'd like input from someone else, are you able to look it over?22:30
mupBug #1513982: Juju can't find daily image streams from cloud-images.ubuntu.com/daily <streams> <juju-core:Triaged> <https://launchpad.net/bugs/1513982>22:30
perrito666k EOD22:32
perrito666EOW22:32
perrito666game set match :p cheers22:32
ericsnowjog: it could be related to metadata signing; I seem to recall Sergey mentioning something about this22:33
ericsnowjog: this is vsphere-specific, right?22:34
jogyes... I'm trying to test an updated OVA for use by vsphere, that utlemming has pushed into daily22:35
ericsnowjog: yep, I'm pretty sure Sergey had a work-around that he used when manually testing the provider22:46
ericsnowjog: if I remember right, it involved commenting out some line of code somewhere to disable that signed image check22:47
jogI'll subscribe him to the bug and see if he can give some guidance. Although I was able to test this image when I used a locally hosted image stream and set image-metadata-url22:49

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!