davecheneywow, trying to find somethign that _wont_ marshall into yaml is more complicated than I thought00:29
davecheneythumper: menn0 http://paste.ubuntu.com/13205113/00:32
* thumper looks00:32
davecheneyyaml.Marshal returns an error00:32
davecheneybut the code panics ...00:32
* menn0 looks00:32
thumperbecause... reasons00:33
davecheneyso, to test that writeyaml fails on invalid yaml00:35
davecheneyi have to00:35
davecheneya. find some invalid yaml00:35
davecheneyb. find some invalid yaml that doesn't crash the library00:36
davecheneyi've checked yaml.v1 and yaml.v200:36
menn0davecheney: it looks like panics that are yamlErrors will be turned into errors00:37
menn0and all others will be allowed to paniuc00:37
menn0the whole yamlError thing is a crappy way of allowing deeply nested encoding calls to abort the whole process immediately00:38
menn0a way to get around Go not having exceptions00:38
davecheneyi'm discovering why this function had not test coverage ...00:38
menn0davecheney: if that panic were a call to the package's fail() func, an error would be returned00:40
wallyworld_thumper: could i beg for a small review to address a windows test failure https://github.com/juju/charmrepo/pull/4301:38
wallyworldthumper: tyvm for the review03:15
thumpersorry for the delay, was otp for 1:1s03:17
wallyworldnp, long meeting :-)03:19
menn0thumper: logging doc updates: http://reviews.vapour.ws/r/3091/03:21
thumperwallyworld: no, just four in a row03:21
wallyworldallover and done with  for the week :-)03:21
menn0thumper: super quick one: http://reviews.vapour.ws/r/3093/04:43
thumpermenn0: hmm04:49
thumper88 files changed, +1,050 −2,33004:49
thumperholy shitballs batman04:50
thumperI felt it was bad, but didn't realise it was that bad04:50
menn0thumper: good net line delta though04:52
thumperhmm... diff is off04:52
thumperincludes previous branch...04:52
thumperwhich I though landed already04:53
thumperthis will explain a lot04:53
menn0thumper: right04:54
menn0i've got to stop now but might jump back later to review04:54
thumpernot sure why the diff is bad04:54
thumperdon't bother04:54
thumperI'm stopping too04:54
menn0i want to get a few other things squared away as well04:54
thumpermenn0: that's better, 43 files,  +98 −1,37504:57
thumpernow I'm done04:57
thumperlaters folks04:58
davecheneyanyone for a little one ?05:53
wallyworldfwereade: morning to you. did you have a few minutes to spare a sunburnt bread thief?09:25
fwereadewallyworld, heyhey09:34
fwereadesure, joining our hangout09:34
wallyworldfwereade: on my way09:35
wallyworldanastasiamac: https://plus.google.com/hangouts/_/canonical.com/ian-william09:36
frobwarefwereade, standup?10:02
frobwarevoidspace, ping, 1:1?10:34
voidspacefrobware: omw10:34
=== akhavr1 is now known as akhavr
mupBug #1514444 opened: Windows github.com/juju/juju/cmd/jujud/dumplogs/dumplogs.go:65: undefined <blocker> <ci> <regression> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1514444>14:15
=== Ursinha_ is now known as Ursinha
mupBug #1514451 opened: TestUniterConfigChangedHook fails <ci> <intermittent-failure> <test-failure> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1514451>14:51
mupBug #1514456 opened: Juju is unable to detach root volume <intermittent-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1514456>14:51
mupBug #1514451 changed: TestUniterConfigChangedHook fails <ci> <intermittent-failure> <test-failure> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1514451>14:54
mupBug #1514456 changed: Juju is unable to detach root volume <intermittent-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1514456>14:54
mupBug #1514451 opened: TestUniterConfigChangedHook fails <ci> <intermittent-failure> <test-failure> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1514451>14:57
mupBug #1514456 opened: Juju is unable to detach root volume <intermittent-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1514456>14:57
mupBug #1514462 opened: Assertion failure in TestAPI2ResultError <ci> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1514462>14:57
katcoericsnow: ut15:05
katcodimitern: ping, hey do you think you're going to wrap up bug 1483879 soon?15:37
mupBug #1483879: MAAS provider: terminate-machine --force or destroy-environment don't DHCP release container IPs <bug-squad> <destroy-machine> <landscape> <maas-provider>15:37
mup<sts> <juju-core:Triaged> <juju-core 1.24:In Progress by dimitern> <juju-core 1.25:In Progress by dimitern> <https://launchpad.net/bugs/1483879>15:37
dimiternkatco, yes15:38
dimiternkatco, I need another review on it15:38
katcodimitern: ok, cool :) just trying to figure out if bugsquad moonstone needed to pick it up15:39
dimiternand was having lots of maas issues, but managed to verify most of the cases at least manually15:39
katcowwitzel3: hey before you get too far into that bug, can you rebase/merge master into our lxd branch so we can get a bless and prepare for landing?15:47
katcowwitzel3: "<sinzui> katco: cimmit 1c86f86 is what you want to merge."15:47
wwitzel3katco: sure15:47
katcowwitzel3: ty15:48
dimiternfrobware, voidspace, dooferlad, can you please review http://reviews.vapour.ws/r/3088/ ?15:49
dooferladdimitern: *click*15:49
voidspacedimitern: in a bit if no-one gets to it. Got my head stuck in a bug right now.15:49
dimiternvoidspace, sure, np15:50
voidspacefixed the test failure I had, now stuck in a different one *grrr*15:51
fwereadevoidspace, do I remember you having familiarity with the rsyslog stuff?15:57
fwereadevoidspace, wondering if you know why the worker apparent deletes the rsyslog config file when the worker stops15:58
voidspacefwereade: no15:58
voidspacefwereade: it's changed a lot since I worked on it apparently15:58
voidspacefwereade: I don't think that was done by wwitzel3 and I when we worked on it15:59
voidspaceblame would know though...16:00
fwereadevoidspace, yeah, that's all axw's code from about 18 months ago16:00
fwereadevoidspace, and he probably did it for a reason, but I'm not clear what that reason might be, thought you might have already gone through the digging process16:01
fwereadevoidspace, np, I'll ask him tonight, it's not critical16:02
fwereadevoidspace, and moot soon enough what with db-log \o/16:02
alexisbhey all, happy monday16:02
natefinchfwereade: that sounds like the code to clean up the agent stuff... there was a bug about that happening when you sigkilled the agent16:02
alexisbcherylj, katco anything urgent I should be aware of?16:03
alexisbcrawling through the inbox after being out :)16:03
cheryljalexisb: nothing new that I can think of16:03
cheryljalexisb: you feeling better today?16:03
fwereadenatefinch, ooh, if there's a reported bug associated I can be a bit grumpier about it ;p16:03
alexisbcherylj, much! thank you16:03
natefinchfwereade: I would search for it, but I think i'm being bitten by the launchpad "feature" where it's not searching across series16:04
katcoalexisb: nope16:05
katcoalexisb: glad you're feeling better :)16:07
alexisbthanks katco16:08
alexisbthanks to you and the team for keeping things moving in my absence16:08
wwitzel3katco: I rebased that commit in to our branch, but I'm not sure where it goes now16:12
wwitzel3katco: there is still conflicts against current master that need to be resolved16:12
katcowwitzel3: i.e. you're having trouble resolving the conflicts?16:13
wwitzel3katco: so not sure what to make the PR against16:13
wwitzel3katco: no, that hash is rebased16:13
wwitzel3katco: but that hash isn't the current HEAD of master16:13
katcowwitzel3: oh right. so you've got 1 pr up against the lxd feature branch right?16:14
wwitzel3katco: no, I rebased, so it won't merge against our feature branch16:14
katcowwitzel3: ah i see now16:14
katcowwitzel3: gosh... not actually sure how github handles that? if you propose against the feature branch what does it say? just merge conflicts?16:15
frobwaredimitern, will also take a look in a bit16:15
wwitzel3katco: yeah, unable to merge16:15
wwitzel3katco: which makes sense, since I rewrote history16:15
katcowwitzel3: right16:16
katcowwitzel3: hrm. maybe just use git to push directly into the FB?16:16
dimiternfrobware, ta!16:16
katcowwitzel3: and do a force?16:16
katcoericsnow: natefinch: any opinions on how to tackle this?16:17
frobwaredimitern, I started looking then realised it was quite large and I /think/ I now know why one of my tests fails..16:17
dimiternfrobware, yeah? what was it?16:17
frobwaredimitern, (ha, don't ask). :)16:17
wwitzel3katco: yeah, I had to force push to my copy of the feature branch to get it up, so the merge exists under my namespace right now16:18
dimiternfrobware, ok :)16:18
katcowwitzel3: b/c the point is to get a bless of the FB, so skipping the tests might be OK16:18
frobwaredimitern, it was one of those... If only I had taken the dog for a walk earlier... type of bugs. :)16:18
wwitzel3katco: right, makes sense16:18
dimiternfrobware, right :)16:19
natefinchwwitzel3, katco: maybe make a new branch off the feature branch and cherry pick what you need (if it's not too many changes). I've had success with that in the past when I get into a bad spot16:20
wwitzel3natefinch: we need .. a lot16:20
wwitzel3katco: I don't have permission to do a force anyway ;)16:21
katcowwitzel3: lol i can take care of it if we think that's the way to go16:21
wwitzel3katco: well, I could just merge it instead of rebasing16:25
natefinchkatco, wwitzel3: force push onto the feature branch is fine if no one else has outstanding branches against it16:25
katcowwitzel3: yeah we can do that too. rebasing is nice if we have to come back to anything later, but if it's this much of a PITA maybe merging is the way to go16:25
wwitzel3I would just force push the feature16:26
katcowwitzel3: ok. i'll take care of that then16:26
wwitzel3you brought it up, this is for getting blessed16:26
katcowwitzel3: ty for rebasing16:26
wwitzel3katco: np16:26
wwitzel3very minor, mostly dep.tsv nags16:27
natefinchfwereade: gota minute to talk? I found another odd bug in my unitassigner code.   Machines weren't getting created with sequential ids (i.e. I'd get 0, 1, 3, 8..)  Any immediate thoughts in what might cause that?16:28
wwitzel3natefinch: just add "machine number assignment no longer sequental" to the release notes, feature shipped ;)16:29
natefinchrogpeppe: did you have a script for automating the import sorting (i.e. project internal vs. project external)?16:33
rogpeppenatefinch: yeah16:33
rogpeppenatefinch: github.com/rogpeppe/sortimports16:33
fwereadenatefinch, huh16:33
fwereadenatefinch, yes, for some reason st.sequence() is getting called too often16:34
fwereadenatefinch, ideally when you know you need to create a machine you consume a sequence number just once and pass that into the txn-builder loop16:34
fwereadenatefinch, possibly one slipped into a createMachineOps  that was hitting failure a it later? or something?16:35
natefinchfwereade: sounds plausible16:36
dooferladdimitern, frobware, voidspace: hangout17:02
katcowwitzel3: your rebased branch is here? git@github.com:wwitzel3/juju.git17:03
wwitzel3katco: yeah, lxd-provider17:06
katcowwitzel3: k17:06
voidspacefrobware: dooferlad: dimitern: if you have time http://reviews.vapour.ws/r/3097/17:24
cheryljfrobware: Did someone from your team get a chance to look at bug 1512371?17:27
mupBug #1512371: Using MAAS 1.9 as provider using DHCP  NIC will prevent juju bootstrap <bug-squad> <maas-provider> <network> <juju-core:Triaged> <https://launchpad.net/bugs/1512371>17:27
frobwarecherylj, nope17:27
frobwarecherylj, but we talked about dimiter's wip branch which help fix this: https://github.com/dimitern/juju/tree/maas-1.25-better-bridge-script17:29
cheryljfrobware: okay, so that should address that issue as well?17:30
frobwarecherylj, should do / can do, but wasn't specifically started for that bug though.17:31
frobwarecherylj, the bug came after dimitern started work on that17:31
katcowwitzel3: can you tal at this: https://github.com/juju/juju/pull/369417:31
katcowwitzel3: i can't force into FB, so did a merge --theirs of your branch17:32
katcowwitzel3: and would like to land that into FB17:32
katcowwitzel3: just need a sanity check17:32
cheryljfrobware: ah, okay.  so that branch was just for improving things, and not for a specific bug?17:33
frobwarecherylj, correct. the issue is that the current script changes the order of what's in /e/n/i. the branch script is more complicated and attempts to change things in-situ17:34
wwitzel3katco: looking17:35
cheryljfrobware: is there a target for landing that branch?   We'll probably want to make sure we pull that in when we do 1.25.117:36
frobwarecherylj, initially we said master17:36
wwitzel3katco: yeah, that looks like it did the right thing to me17:36
katcowwitzel3: k merging17:36
cheryljfrobware: it looks like that branch is based off of 1.25?17:37
natefinchgah, I've somehow disabled the scroll wheel in sublime :/17:40
natefinch...nope I've disabled both the scroll wheel and right click17:41
perrito666how ennerving, a place that does one of the best croissants in the city makes also one of the worse coffees18:15
perrito666this country would really beneffit from discovering donuts :p18:17
natefinch....and reboot fixes it.18:55
cmarsanyone here familiar with dumplogs to review http://reviews.vapour.ws/r/3100/ ?19:10
cmarsi'm not familiar with juju-dumplogs but windows seems to feel left out19:10
mupBug #1514555 opened: local provider "machine0" agent fails to start up on wily if "/var/lib" is not on the "/" partition.  <juju-core:New> <https://launchpad.net/bugs/1514555>19:13
mupBug #1514555 changed: local provider "machine0" agent fails to start up on wily if "/var/lib" is not on the "/" partition.  <juju-core:New> <https://launchpad.net/bugs/1514555>19:16
mupBug #1514555 opened: local provider "machine0" agent fails to start up on wily if "/var/lib" is not on the "/" partition.  <juju-core:New> <https://launchpad.net/bugs/1514555>19:22
mupBug #1514570 opened: 'JUJU_DEV_FEATURE_FLAGS=address-allocation' blocks after first 3 ips are allocated <juju-core:New> <https://launchpad.net/bugs/1514570>20:04
mupBug #1514570 changed: 'JUJU_DEV_FEATURE_FLAGS=address-allocation' blocks after first 3 ips are allocated <juju-core:New> <https://launchpad.net/bugs/1514570>20:07
mupBug #1514570 opened: 'JUJU_DEV_FEATURE_FLAGS=address-allocation' blocks after first 3 ips are allocated <juju-core:New> <https://launchpad.net/bugs/1514570>20:19
=== urulama is now known as urulama__
natefinchkatco: good news, both bugs with unit assignment were from the same source, and I have a fix for it.21:13
katconatefinch: nice!21:14
=== dames is now known as thedac
natefinchuh, how do un-revert a PR?  I tried re-PRing with the same old branch with some added fixes, and only the fixes are getting applied, not the whole of the branch... which means the unit assigner code is not getting added back to master21:51
* natefinch wonders if he should revert the revert PR...21:52
natefinchI got it.. just cherry-picked the original merge21:55
=== natefinch is now known as natefinch-afk
natefinch-afkkatco, wwitzel3, ericsnow_: if you guys have time... the fixes are very small: (easier to see on github) http://reviews.vapour.ws/r/3103/22:00
natefinch-afk^ https://github.com/juju/juju/pull/369822:00
wwitzel3natefinch-afk: ok, i'll take a look22:00
thumperrick_h__: ping22:15
rick_h__thumper: pong22:19
thumperrick_h__: hey there22:19
thumperrick_h__: wheren't we going to talk this week about CLI stuff?22:19
thumperI thought you were going to make some meetings22:19
rick_h__thumper: yes I was/am22:20
rick_h__ thumper will get them on tonight sorry for the delay22:20
thumperthat's fine22:20
thumperit isn't like I've got nothing to do :)22:20
rick_h__thumper: thanks fornthe poke22:20
rick_h__heh +122:21
katconatefinch-afk: wwitzel3: ericsnow_: as you EOD, be sure to update any bugs you're working on22:36
ericsnow_katco: k22:36
=== ericsnow_ is now known as ericsnow
rick_h__thumper: added please adjust if those don't work out22:39
thumperrick_h__: can we move tomorrows one out 30 minutes?22:40
thumperrick_h__: I'm normally at the gym between 12 and 122:40
rick_h__thumper: wfm22:40
thumperalexisb: why is the TL call this week on a different day?22:41
alexisbthumper, becuase weds is a US holiday22:41
alexisbthumper, hopefully I actually changed this weeks meeting and not some random day in dec ;)22:42
wwitzel3katco: yep, will do, thanks for the reminded23:32

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!