mupBug #1515066 opened: failed to create C:/Juju/bin/juju-run.exe symlink <blocker> <ci> <regression> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1515066>00:42
cheryljdavecheney: I see bug 1465317 is assigned to you and InProgress.  Are you actually working that bug?00:44
mupBug #1465317: Wily osx win: panic: osVersion reported an error: Could not determine series <osx> <packaging> <wily> <windows> <juju-core:In Progress by dave-cheney> <juju-core 1.24:Triaged> <juju-core 1.25:Triaged> <juju-release-tools:Fix Released by sinzui> <https://launchpad.net/bugs/1465317>00:44
=== natefinch-afk is now known as natefinch
davecheneycherylj: nope01:49
davecheneydidn't even know about it01:49
davecheneyhow long has it been assigned to me ?01:50
cheryljdavecheney: thumper assigned it to you back on 22-901:53
mupBug #1496016 changed: jujud uses too much memory <juju-core:Triaged> <https://launchpad.net/bugs/1496016>01:54
mupBug #1510533 changed: destroy-environment panics <destroy-environment> <juju-core:Invalid> <https://launchpad.net/bugs/1510533>01:54
thumperI seem to recall that it was part of the series / os work02:05
thumperat least I had assumed that02:05
menn0thumper: simple juju/utils addition https://github.com/juju/utils/pull/17302:31
menn0needed as part of fix to the machine agent symlink on windows issue02:32
* thumper looks02:32
menn0(tested on Windows)02:32
thumpernot sure why it isn't hooked up on review board02:33
thumperbut +102:33
menn0thumper: yeah, that's weird02:35
menn0but thanks02:35
menn0davecheney: what's the reasoning behind the network operation func move? I have no real problem with it, but I can understand that it might be the kinda of thing that's more widely used which is why it was put in utils03:07
menn0also, it should probably be based on thumpers juju/retry now (but that's beyond the scope of your change)03:07
davecheneymenn0: i'm nuking the utils packge in juju03:13
davecheneythere is no point in having both a utils repo and a utils package03:13
davecheneyit's clear juju/utils is a dumping ground for things that people thought would be generally useful03:13
davecheneybut in all cases have proven to be used in only one place03:13
davecheneypossibly because they were hard to find ?03:14
menn0davecheney: I actually missed that this was being moved from the utils package in juju03:14
menn0all good03:14
davecheneynot to mentino the dumping ground that is github.com/juju/utils03:14
menn0davecheney: ship it03:14
davecheneyhow's the build blockage going ?03:15
menn0davecheney: about to push the final PR. just doing final tests on Windows03:23
davecheneythank you03:24
natefinchis there a fix for bad record mac or do I just retry03:31
natefinch(re the landing bot)03:31
menn0natefinch: retry. it's a mongodb bug that's fixed in a later version than we use.03:33
natefinchmenn0: boo03:35
davecheneynatefinch: nah, just turn it off and on again03:36
axw_wallyworld: going to have some lunch, can we have a chat after to talk about what's next?03:57
natefinchmenn0: I was looking at that x509 cert signed by unknown authority bug... sounds like we're having problems reproducing it, but you suggested flipping mongo to secondary "at just the right time" to try to reproduce the problem.  What would be the right time?04:10
mupBug #1491688: all-machine logging stopped, x509: certificate signed by unknown authority <bug-squad> <landscape> <logging> <rsyslog> <sts> <juju-core:Triaged> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1491688>04:11
menn0natefinch: well we see the problem happening just after the machine agent starts up04:31
menn0natefinch: around the time the "api" worker starts would be a good place I suspect04:32
* thumper is done04:33
thumperdone done04:33
natefinchmenn0: ok, thanks04:34
axw_wallyworld: got time now? 1:1 hangout?05:12
wallyworldaxw_: sure, giv eme 505:14
axw_wallyworld: ok, poke when you're there05:14
wallyworldaxw_: there now05:22
axw_wallyworld: one of us dropped05:31
=== urulama__ is now known as urulama
voidspacedooferlad: wily hasn't [completely] fixed the vanishing windows problem09:15
voidspacedooferlad: just had it now09:15
frobwaredimitern, have 10 mins for a quick HO?09:42
=== rogpeppe2 is now known as rogpeppe
rogpeppewallyworld: ping09:46
dimiternfrobware, can it wait until standup?09:47
frobwaredimitern, let's do it then or later09:48
dimiternfrobware, ok09:48
voidspacedimitern: ping09:53
dimiternvoidspace, pong09:55
voidspacedimitern: question about provider/maas/environ.go:providerSuite.makeEnviron09:55
voidspacedimitern: it looks to me like the call to coretesting.FakeConfig().Merge ought to use testAttrs not maasEnvAttrs09:55
voidspacedimitern: so I'm going to change it in my branch, just checking with you that's correct09:56
dimiternvoidspace, let me have a look09:56
voidspacedimitern: all tests pass before and after the change09:57
voidspacedimitern: it implies that testAttrs is not really needed at all, maybe it's better to get rid of it09:57
dimiternvoidspace, is testAttrs there just to set maas-server URL?09:58
voidspacedimitern: it looks like it to me09:58
voidspacedimitern: but it must not be needed as it isn't used!09:59
dimiternvoidspace, yeah it looks like it - maybe the gomaasapi test server changed so it doesn't need it?10:00
voidspacedimitern: it looks to me like it has never been used...10:00
dimiternvoidspace, all the better then - drop it :)10:00
dimiternvoidspace, dooferlad, frobware, jam, fwereade, standup?10:01
dooferladdimitern: was already there10:01
fwereadedimitern, I think I'm there too ;p10:01
voidspacedimitern: dooferlad: frobware: if you have time, super simple, http://reviews.vapour.ws/r/3116/10:21
dimiternvoidspace, sure, will look in a bit10:22
wallyworldrogpeppe: hey10:36
rogpeppewallyworld: just wondering if there's a feature branch around that's using charmrepo.v2-unstable10:40
wallyworldrogpeppe: yup, series-in-metadata10:40
rogpeppewallyworld: thanks10:42
frobwarevoidspace, I built and ran tests for your change but some fail.10:53
frobwarevoidspace, they may not be related of course, just thought I'd try to see what happens.10:53
frobwarevoidspace, http://pastebin.ubuntu.com/13226255/10:54
dimiternvoidspace, reviewed11:01
voidspacedimitern: it used to return false, why should it *now* return NotSupported11:03
voidspacedimitern: the error channel there is for things like an error contacting the maas server11:04
voidspacedimitern: otherwise there's no point in using a boolean11:04
dimiternvoidspace, because that one slipped by me when frank added it I guess11:04
voidspacefrobware: I'll look into it11:04
voidspacedimitern: "do you support x?" "error"11:05
voidspacedimitern: it seems to me that "no" is a much more logical response...11:05
dimiternvoidspace, it can be "no", "yes", or "I failed to verify"11:05
dimiternvoidspace, for the last case we need the error11:05
voidspacedimitern: no, you're suggesting I return "error" for the no case11:06
dimiternvoidspace, but IIRC some of the places this gets called expects (and ignores) NotSupported error from that method11:06
voidspacedimitern: I do return an error for the "failed to verify" case11:06
voidspacedimitern: expects and ignores? I don't understand what that could mean.11:06
voidspacedimitern: and if so I'd rather fix those *callers* and have them properly check the bool result11:07
frobwarevoidspace, I believe the test failure are introduced by your change11:07
voidspacefrobware: seems odd, but I'll look into it11:07
dimiternvoidspace, ok, but if SupportsSpaces will return false, nil, please look into all places it gets called (incl. featuretests/ and the all the stubs around cmd/juju, api/ and apiserver/)11:09
voidspacedimitern: I'll check other similar provider methods11:11
voidspacedimitern: better to be consistent even if it's weird...11:11
voidspacedimitern: but it seems more obvious to me that a Supports* method returns true or false and only returns an error when there's an error...11:11
dimiternvoidspace, yeah, seems reasonable to use the error return only when needed11:12
dimitern(that's the difference between "lets do a high-level spec" and "let's see how things should sensibly work together, based on that spec")11:13
dimiternvoidspace, updated my review11:13
voidspacedimitern: cool, thanks11:15
voidspacehmmm... that state test consistently fails on the buildbot for my 1.25 branch11:27
voidspacetesting with 1.25 merged into my branch11:27
voidspaceError: machine document does not have a "principals" field11:27
voidspaceDoesn't fail on my machine.11:31
voidspaceWeird, I really don't see how that error can arise.12:07
voidspacePrinciples is part of the machine document and the error indicates that it's missing.12:08
voidspacemgz_: ping12:08
voidspacemgz_: I don't suppose this error is familiar?12:09
voidspacemgz_: http://juju-ci.vapour.ws:8080/job/github-merge-juju/5383/console12:09
voidspacemgz_: it doesn't happen on my machine and it's hard to see how it could be spurious12:09
voidspacebut it's happened twice in a row12:09
jamrick_h__: ping12:33
jamfrobware: sorry I missed the standup today. my meeting with Mark got expanded and went through the time. Anything I should be aware of?12:33
frobwarejam: trying to land first commit on maas-spaces feature branch. :)12:34
rick_h__jam: pong12:35
frobwarejam: I tried the kmaas.py script but could not get a node to register - will come back and look at why12:35
jamfrobware: k. if you want some live feedback with me, just ping12:36
jamthough I'm off in a few12:36
jamrick_h__: mark and I went over the Funding and Budgets stuff, and got pretty far.12:36
jambut we have a few things dangling. thought I might ping ideas off of you, if you're interested.12:36
rick_h__jam: sure thing, I talked to casey about it on monday and hadn't seen if he'd updated it yet12:37
* rick_h__ loads it up12:37
frobwarejam: OK, let me actually debug it a bit more; I tried, it "failed", I got sidetracked.12:37
jamfrobware: :)12:37
jamrick_h__: I'm happy to hangout as a higher bandwidth mechanism for discussion12:38
rick_h__jam: sure thing12:38
rick_h__jam: https://plus.google.com/hangouts/_/canonical.com/rick?authuser=112:38
tvansteenburghcan anyone tell me how to resolve this bootstrap error? http://pastebin.ubuntu.com/13226910/13:15
mupBug #1514444 changed: Windows github.com/juju/juju/cmd/jujud/dumplogs/dumplogs.go:65: undefined <blocker> <ci> <regression> <windows> <juju-core:Fix Released by cmars> <https://launchpad.net/bugs/1514444>14:50
mupBug #1515066 changed: failed to create C:/Juju/bin/juju-run.exe symlink <blocker> <ci> <regression> <windows> <juju-core:Fix Released by menno.smits> <https://launchpad.net/bugs/1515066>14:50
mupBug #1515289 opened: bootstrap node does not use the proxy to fetch tools from streams.c.c <kanban-cross-team> <juju-core:New> <https://launchpad.net/bugs/1515289>14:50
voidspacefrobware: I do have a failure, related to the removal of testAttrs I think14:51
voidspacedimitern: hah, testAttrs *was* used15:13
voidspacedimitern: but only because creating a new reference to a map *doesn't* copy it15:14
voidspacedimitern: so modifying testAttrs mutates maasEnvAttrs15:14
voidspacedimitern: I'll change it to a proper copy15:14
voidspacedimitern: http://play.golang.org/p/O6H0HoQfzh15:15
voidspacedimitern: we can't stop using the legacy Subnets code as the new api doesn't have allocatableHigh and allocatableLow16:01
voidspacedimitern: or at least the new code also needs to fetch nodegroup interfaces in the same way as the current code16:02
dimiternvoidspace, sorry, in a call, will get back to you soon16:02
voidspacedimitern: np, more FYI than requiring a response16:03
=== Ursinha_ is now known as Ursinha
dimiternvoidspace, good catch on testAttrs :)16:21
dimiternvoidspace, about Subnets()16:21
dimiternvoidspace, that only applies to the address allocation logic, right?16:21
dimiternvoidspace, we don't need the allocatable high and low otherwise16:21
dimiternvoidspace, I'd suggest keeping the legacy subnets implementation internally for now (unexported) and use it when the network-deployment-ubuntu is missing, otherwise use the new API and just don't populate the static ranges (until we need them)16:24
voidspacedimitern: well we need them for address allocation16:44
voidspacedimitern: which is currently the major use for Subnets16:44
voidspaceand I don't want to move that code into address allocation16:44
voidspacemgz_: sinzui: test infrastructure (CI bots) seems to be in trouble16:46
dimiternvoidspace, yeah, but for the demo we won't need address allocation, will we?16:50
voidspacedimitern: we won't need containers?16:52
dimiternvoidspace, we won't need the address allocation feature flag16:52
voidspacedimitern: but if we break address allocation we can't merge back to master16:52
voidspacedimitern: and we'll have failing tests16:52
voidspaceand we need tests to pass just to be able to develop16:53
dimiternvoidspace, I'm thinking of dropping the current address allocation approach entirely16:53
voidspaceit's easy enough to share that code between the two implementations of subnets (new api and legacy)16:53
voidspace(the code that figures out addressable range)16:53
voidspaceso I don't see why not do it16:53
voidspacethe new one just won't be as clean as we hoped16:53
dimiternvoidspace, I'd rather ask maas to return the allocatable high/low (both  static and dhcp) using the subnets api16:54
voidspacewe can do that too16:54
dimiternvoidspace, yeah, since it's a new, yet-unreleased api, now's the time to make it saner than the old one16:54
voidspaceI'll file an issue for it16:55
dimiternvoidspace, cheers!16:55
thumpermenn0: a pretty boring review: http://reviews.vapour.ws/r/3115/diff/#21:19
* menn0 looks21:24
menn0thumper: ship it. just one tiny issue.21:31
thumpermenn0: my no tail bit isn't working as expected :-(21:32
menn0thumper: what's happening?21:32
thumperit isn't not tailing21:32
* thumper adding debugging21:32
thumperfound a missing bit21:33
mupBug #1515401 opened: destroy-environment leaving jujud on manual machines <blocker> <destroy-environment> <manual-provider> <regression> <juju-core:Triaged> <juju-core series-in-metadata:Triaged> <https://launchpad.net/bugs/1515401>21:39
thumpermenn0: working now...21:43
thumpermenn0: I missed the param conversion from the apiserver -> state struct21:43
thumperadded tests :)21:44
thumpermenn0: http://reviews.vapour.ws/r/3118/21:47
* menn0 looks22:01
menn0thumper: have you checked what happens when you use the client that supports "no tail" with a server that doesn't?22:02
* thumper thinks22:03
thumperit'll just ignore it22:03
thumperas it comes through as a post param22:03
menn0thumper: it might be a good idea to be sure :)22:03
thumperbut we only check for some...22:03
menn0I'm sure you're right but....22:03
thumperworth confirming22:03
thumperfor sure22:03
menn0thumper: so "NoTail" was added to api.DebugLogParams in an earlier PR? I don't see it here.22:10
thumperI needed to make some tests pass when removing the feature flag22:11
menn0thumper: that's fine :) just making sure the diff was complete and/or I wasn't missing something22:11
menn0thumper: ship it with one request22:12
* perrito666 thinks that this day is lastimg more than it should22:48
anastasiamacperrito666: ?22:49
perrito666anastasiamac: still a lot of things before I EOD22:50
anastasiamacperrito666: ah... i usually get the feeling that days are not long enough \o/22:51
=== mup_ is now known as mup

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!