=== _salem` is now known as _salem | ||
=== bpierre_ is now known as bpierre | ||
dholbach | good morning | 07:50 |
---|---|---|
=== Mirv_ is now known as Mirv | ||
=== chihchun_afk is now known as chihchun | ||
=== oSoMoN_ is now known as oSoMoN | ||
=== _salem is now known as salem_ | ||
hasselmm | zbenjamin: as i just saw you on qtc-devel, is there a branch of the ubuntu plugin that works with qtc master? how about moving the entire plugin to qtc master to offload api-breakage burden to tobias, eike and friends? | 11:53 |
hasselmm | basically everyone does that | 11:53 |
zbenjamin | hasselmm: not atm, 3.5.x is what we build against atm | 11:53 |
zbenjamin | hasselmm: we thought about upstreaming but we did not get to the point yet. At least all our patches to the other plugins are upstreamed | 11:54 |
hasselmm | zbenjamin: yeah, 1000 thanks for your cmake work, btw | 11:55 |
zbenjamin | or 99% of them , except some small if (device == ubuntuDevice) | 11:55 |
hasselmm | makes my daily routine so much easier | 11:55 |
zbenjamin | hasselmm: yw, i had some hard time to get it in ;) | 11:55 |
hasselmm | (ok, not for the current project. but usually) | 11:55 |
hasselmm | still 1000 thanks to everyone involved | 11:55 |
zbenjamin | hasselmm: one feature i had to remove btw, the run cmake dialog is back again (but since you use master you know that already) | 11:56 |
hasselmm | zbenjamin: well, at least it became better | 11:56 |
zbenjamin | hasselmm: yeah imho the cmake per Kit feature is pretty nice and makes sense | 11:57 |
zbenjamin | hasselmm: problem is i only can use the QtC in the most recent ubuntu development branch | 12:02 |
zbenjamin | so keeping up with master is not on the daily agenda | 12:02 |
zbenjamin | but maybe i'll start porting to the current development version soon | 12:03 |
hasselmm | yeah, qtc with its permanent api changes is a pain to work with | 12:03 |
zbenjamin | yes | 12:03 |
hasselmm | see, i also just bug you, because ubuntu-sdk killed all my configured kits | 12:03 |
zbenjamin | hasselmm: -settingspath ftw | 12:11 |
zbenjamin | hasselmm: qtcreator -settingspath ~/.config/QtCMaster | 12:12 |
hasselmm | zbenjamin: indeed! great idea! | 12:16 |
zbenjamin | hasselmm: :D | 12:16 |
hasselmm | thank you | 12:16 |
=== blami_ is now known as blami | ||
timp | ahayzen: I have a fix for bug 1514143 | 15:54 |
ubot5 | bug 1514143 in ubuntu-ui-toolkit (Ubuntu) "While searching often times the keyboard hides while typing" [Critical,In progress] https://launchpad.net/bugs/1514143 | 15:54 |
timp | ahayzen: see https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/lessHeaderDisabling/+merge/277713 | 15:55 |
timp | please test and comment if it works for you :) (I think it does). | 15:55 |
ahayzen | timp, awesome thanks, i'll have a look when i have a moment, thanks for the quick patch :-) | 15:55 |
=== nemo_ is now known as nemo | ||
cwayne1 | popey: how many beers and/or cat pictures would I owe you to let my latest version of activity tracker through? :) For some reason it has a warning for vcs files, even though when I run click-review locally, it says it's fine... | 16:30 |
popey | There are not enough cat pictures. | 16:30 |
popey | cwayne1, done | 16:31 |
cwayne1 | popey: <3 | 16:31 |
popey | cwayne1, seems you are not alone, davmor2 is getting that too | 16:31 |
popey | dholbach, has something recently changed in the review tools? it's barfing for some people when there's no vcs files in the click package | 16:31 |
dholbach | popey, have an error message | 16:34 |
dholbach | and yes, it changes now and then :) | 16:34 |
popey | found VCS files in package: .excludes lint_vcs_files | 16:34 |
popey | why does it care if there's an ".excludes" file in there? | 16:34 |
popey | I mean, it's only a warning, granted :) | 16:34 |
dholbach | it's a valid point | 16:35 |
cwayne1 | should a warning be enough to stop something from being published? | 16:35 |
dholbach | consider you're working on a closed source app | 16:35 |
dholbach | I don't think I implemented the check, but I think it's fair enough | 16:35 |
dholbach | and it can potentially be huge | 16:35 |
dholbach | I think it's good to make the uploader aware | 16:36 |
popey | it stops the line in the store | 16:36 |
popey | forces manual review | 16:36 |
dholbach | the check has been in place since 2013 | 16:37 |
dholbach | 2013-08-20 | 16:37 |
popey | hehe | 16:38 |
cwayne1 | then how did it just start flagging it? i didnt change anything in my click pkg and that check used to always pass | 16:38 |
dholbach | cwayne1, some files were added to the vcs_files list in the past few weeks | 16:39 |
cwayne1 | ah, that's it then | 16:39 |
dholbach | the check didn't change, but some files were added (r533 in lp:click-reviewers-tools) | 16:39 |
cwayne1 | should click build not inlcude them by default then? | 16:39 |
dholbach | I'm not sure I understand the question | 16:40 |
dholbach | you mean... "click build" should run "click-review" and complain? | 16:40 |
popey | click build shouldn't assume what files you should/shouldn't have in your source dir | 16:40 |
popey | oh, yes. | 16:40 |
cwayne1 | yeah | 16:40 |
dholbach | that's what it does if you have it installed | 16:40 |
popey | i do | 16:40 |
popey | and it passed davmor2's app if I run it manually | 16:41 |
popey | but fails (warning) in store | 16:41 |
cwayne1 | yeah, same here | 16:41 |
popey | and cwayne1's :) | 16:41 |
dholbach | it does: http://pastebin.ubuntu.com/13314634/ | 16:41 |
cwayne1 | popey: btw, my cat tax: https://www.thedodo.com/hoodie-with-pouch-for-pets-1154767753.html?xrs=RebelMouse_fb | 16:41 |
cwayne1 | dholbach: yeah, but click review is passing my app locally, but got an error on the store | 16:42 |
popey | yeah, but they pass locally, no warnings issued, but fail after uploading. | 16:42 |
popey | yeah, that :) | 16:42 |
popey | 0.35-0~532~ubuntu15.10.1 is the version of click-review-tools I'm on | 16:42 |
popey | which is some 15 merges out from trunk.. | 16:43 |
dholbach | so you're on wily and have all updates applied - do you have the SDK ppa enabled? | 16:44 |
davmor2 | dholbach: pfff wily that's so old hat, I'm on xenial | 16:46 |
dholbach | davmor2, I'm on xenial too | 16:47 |
dholbach | ? | 16:47 |
davmor2 | dholbach: no to the ppa I am running the sdk from repos | 16:47 |
dholbach | https://developer.ubuntu.com/en/start/ubuntu-sdk/installing-the-sdk/ | 16:48 |
=== chihchun is now known as chihchun_afk | ||
dholbach | it's not my decision, but we strongly recommend that folks use the ppa | 16:48 |
dholbach | so the sdk and its tools are not updated in the distro | 16:48 |
popey | i am on xenial | 16:49 |
dholbach | right... what about the ppa? | 16:51 |
dholbach | so yeah... if you feel that the vcs check should be dropped, please file a bug - I think it'll need some more discussion with Jamie and others | 16:51 |
* popey re-enables the ppa which got disabled on upgrade to xenial | 16:53 | |
* popey expects his sdk to break if he updates | 16:53 | |
popey | \o/ successfully fails on my machine now davmor2 :) | 16:56 |
popey | thanks dholbach | 16:56 |
davmor2 | popey: updating mine | 16:57 |
dholbach | brilliant ;-) | 17:00 |
davmor2 | dholbach, popey: now if I run click-review on my .2 I get 2 errors about debug in apparmor that I don't have in the file and arch all it doesn't like | 17:01 |
popey | davmor2, odd | 17:15 |
davmor2 | and no mention of the vcs | 17:18 |
davmor2 | popey: http://paste.ubuntu.com/13315080/ | 17:22 |
davmor2 | I might just destroy this an try again with a .3 version | 17:23 |
popey | how did you build the click? | 17:23 |
davmor2 | popey: click build . like it tells you in the Readme file | 17:23 |
popey | odd | 17:24 |
davmor2 | popey: also the readme say 128x128 for icon and it is 256x256 :( | 17:24 |
popey | indeed | 17:24 |
popey | file abug | 17:24 |
popey | :) | 17:24 |
davmor2 | popey: will do when I finish tearing my hair out with bluez5 that was supposed to be so easy because we had already tested the hell out of it /me shakes his fist | 17:25 |
=== cachio_ is now known as cachio | ||
davmor2 | removed the .excludes file and now it passes which begs the question why does the sdk create it | 17:34 |
davmor2 | meh and I forgot to change the url now D'oh | 17:37 |
davmor2 | yay and now it works \o/ | 17:52 |
davmor2 | cwayne1: so apparently just remove the .excludes file from the dir and any other .dotfiles and the it builds and everything :) | 17:58 |
=== nemo is now known as Guest44125 | ||
=== Guest44125 is now known as nemo | ||
=== salem_ is now known as _salem | ||
=== _salem is now known as salem_ | ||
=== chihchun_afk is now known as chihchun | ||
* mcphail wonders how many apps go unpublished because the dev cannot think of or make a decent icon? Bah. | 19:39 | |
davmor2 | popey: feel free to confirm https://bugs.launchpad.net/ubuntu-sdk-ide/+bug/1517196 | 20:08 |
ubot5 | Ubuntu bug 1517196 in Ubuntu SDK IDE "Webapps readme incorrectly says icon size 128x128 " [Undecided,New] | 20:08 |
=== chihchun is now known as chihchun_afk | ||
=== jdstrand_ is now known as jdstrand | ||
=== salem_ is now known as _salem |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!