/srv/irclogs.ubuntu.com/2015/11/23/#juju-dev.txt

mupBug #1518793 opened: cinder (liberty) fails to retrieve volume limit in Horizon <juju-core:New> <https://launchpad.net/bugs/1518793>00:20
davecheneydoes anyone have the link to the build tashboard00:26
davecheneyi'm looking for the failing race builder00:26
davecheneymenn0_: thumper https://github.com/juju/testing/pull/8400:36
thumperWTH?01:09
thumperfresh build of juju 1.22.701:10
thumper$ juju bootstrap01:10
thumperBootstrap failed, cleaning up the environment.01:10
thumperERROR there was an issue examining the environment: dial tcp 127.0.0.1:37019: getsockopt: connection refused01:10
thumperwith local provider01:10
thumperoh ffs01:11
thumperfuck fuck fuckity fuck01:12
thumpersomething changed no doubt with go 1.501:12
=== Spads_ is now known as Spads
axwdavecheney: why skip tests that fail the race detector? they're failing due to things other than races? too slow?01:22
axwthumper: yes, that's fixed on master01:22
axwthumper: different error type01:23
thumperyeah01:23
thumperpatched my local01:23
thumperaxw: because we want go get the race test voting01:26
thumperthen expand01:26
thumperotherwise people keep committing races01:27
axwfair enough01:27
davecheneyaxw: the tests timeout01:29
davecheneysome horrid timing issue01:29
davecheneyso, skip them for now01:29
davecheneyget the race test voting01:29
davecheneyand iterate from there01:29
axwdavecheney: nps. getting it voting sounds good01:29
mupBug #1518806 opened: apiserver: tests to not pass with -race under Go 1.2 <juju-core:Triaged by dave-cheney> <https://launchpad.net/bugs/1518806>02:02
mupBug #1518807 opened: apiserver/client: tests to not pass with -race under Go 1.2 <juju-core:New> <https://launchpad.net/bugs/1518807>02:02
mupBug #1518809 opened: apiserver/uniter: tests to not pass with -race under Go 1.2 <juju-core:New> <https://launchpad.net/bugs/1518809>02:02
mupBug #1518810 opened: cmd/juju/commands: tests do not pass with -race under Go 1.2 <juju-core:New> <https://launchpad.net/bugs/1518810>02:14
mupBug #1518810 changed: cmd/juju/commands: tests do not pass with -race under Go 1.2 <juju-core:New> <https://launchpad.net/bugs/1518810>02:17
axwwallyworld: thanks for shipit. I may end up changing the watcher as discussed as the worker evolves to support watching the remote side. we'll see.02:25
wallyworldaxw: yep, np. it's always hard to get this 100% up front. i'm all for iterating on a feature branch and correcting issues as we get futher into the implementtion02:26
wallyworldat least we're considering all the options02:26
mupBug #1518810 opened: cmd/juju/commands: tests do not pass with -race under Go 1.2 <juju-core:New> <https://launchpad.net/bugs/1518810>02:32
mupBug #1518820 opened: environs/bootstrap: tests to not pass with -race under Go 1.2 <juju-core:New> <https://launchpad.net/bugs/1518820>03:26
thumperhmm...03:27
thumperI thought that the lxd provider had been merged into master03:28
mupBug #1518820 changed: environs/bootstrap: tests to not pass with -race under Go 1.2 <juju-core:New> <https://launchpad.net/bugs/1518820>03:29
davecheneythumper: it has03:30
davecheneyi've raised some bugs because now the tests don't pass unless you have lxd installed03:30
thumperyeah... but I can't bootstrap and NFI why03:30
davecheneyand not pass in an impolite way03:30
mupBug #1518820 opened: environs/bootstrap: tests to not pass with -race under Go 1.2 <juju-core:New> <https://launchpad.net/bugs/1518820>03:32
cheryljthumper: I think there were some build flag restrictions with lxd where it wouldn't work unless you had go 1.3 or later.04:00
thumperI have go 1.504:01
cheryljah, n/m then :)04:01
anastasiamacwallyworld: axw: I *think* list cli is ready for review (http://reviews.vapour.ws/r/3171/)04:09
anastasiamacplz b genetle - i have a hole week ahead of me :P04:09
axwanastasiamac: okey dokey, looking04:09
anastasiamacgentle even04:09
wallyworlda "hole" week. what type of hole?04:09
anastasiamaca big and balck one :D04:10
anastasiamacblack*04:10
anastasiamacfor crying out \o/04:11
cheryljO_o04:11
cheryljneato.  I got my provisioning updater to use the new MAAS 1.9 curtin status:  http://paste.ubuntu.com/13469033/04:12
cheryljthumper: ^^04:12
axwcherylj: sweet!04:13
cheryljI feel better about demoing this now that we can use the new MAAS stuff04:13
* thumper looks04:13
axwcherylj: looking forward to being able to tell what's going on ;)04:13
cheryljthanks axw :)04:13
thumpernice04:13
cheryljalthough, the stuff from MAAS isn't as verbose or informative as I was hoping04:13
axwyeah that particular message isn't great04:14
axwanastasiamac: still reviewing, but please rename "type ListEndpointsServicesResult" to "type ListEndpointsServiceResults"04:15
axwanastasiamac: it's a collection of results where each result is a ListEndpointsServiceResult04:15
anastasiamacaxw: there are several result collections04:16
axwanastasiamac: this one is in model/crossmodel04:16
axwnot sure if there are others that need changing yet04:16
anastasiamacaxw: yes.... ListEndpointsServiceResult is "service" and "ListEndpointsServicesResult" is "services" result. The 2nd being really a result from a "service directory" but we did not want to use "service directory" :D04:18
axwanastasiamac: not following. I'm looking at the definition of ListEndpointsServicesResult, and its contents are an error, and a slice of ListEndpointsServiceResult04:19
axwso how is that not ListEndpointsServiceResults?04:20
anastasiamacaxw: it must b too hot in QLD, but isn't ur head spinning form all "Item"(s) and "result"(s)... I wish we had better less awful names (and naming conventions)04:21
anastasiamacaxw: i'll address after school pickup :D04:22
axwanastasiamac: I agree it's not great, but we do have a convention and we do need to stick to it or things will be even worse04:22
axwanastasiamac: thank you04:22
wallyworldaxw: i'll look at api pr, in the meantime, coupld you please look at this small one for charmrepo https://github.com/juju/charmrepo/pull/5404:30
axwwallyworld: LGTM04:32
wallyworldty04:32
mupBug #1518793 changed: cinder (liberty) fails to retrieve volume limit in Horizon <juju-core:Invalid> <cinder (Juju Charms Collection):New> <https://launchpad.net/bugs/1518793>04:39
wallyworldaxw: so we have a naming issue. apifacade.WatchRemoteService(service string) should really call apiserver "WatchRemoteServices". but that method name is already used04:39
axwwallyworld: in existing facades it's always singular, even if it takes bulk. it's named after the singular argument.04:39
axws/always/predominantly/04:40
wallyworldaxw: yeah, i was about to say except in storageprovisioner WatchMachine()04:40
wallyworldmybe elsewhere04:40
wallyworldwish we were consistent04:40
wallyworldok, i'll ignore it04:40
wallyworldaxw: lgtm04:46
axwwallyworld: thanks04:46
dimiternjam, hey, sorry :/ I had to do an emergency reinstall of the new laptop this morning, after some package yesterday caused mayhem09:21
jamdimitern: we had *just* brought up the new laptop09:21
dimiternjam, nice! congrats :)09:21
* dimitern discovered even with 15.10 it's quite a challenge to get 4K laptop monitor + HD external monitor to work short of forcing the 4K screen to 1920x108009:23
dooferladdimitern: wow, really? I thought it was annoying just having the 4k screen.09:36
dooferladdimitern: no scaling per screen I take it09:37
dimiterndooferlad, it's quite good actually, the issue is text is too small, but when scaled by 200% and it looks fine on the 4K screen, the text on the HD screen is also scaled twice :/ I wish unity supported separate scaling factors per display09:38
dimiterndooferlad, nailed it :)09:38
dooferladyea, same problem with a 1200px high screen and a 1440px one. It is great fun moving a window from the "big" one to a small one because you lose the bottom.09:39
dimiternso while it's perfect with 2 screens of the same size (well, and using nvidia drivers, as "Displays" is too dumb to allow the 4K screen to scale to 1920x1080 - it only shows its native res)09:40
dimiterna full make check takes ~5m now, not 2009:41
dooferlad:-)09:41
dooferladthat is about the same speed as my desktop! Nice!09:41
dimiternyeah - quad core i7 + k2100m gpu09:41
dimiternthe latter I only tried with steam :)09:42
dooferlad:-)09:42
dimiternI'll be living the dream - running tests *while* using a HO at full quality :D09:43
voidspacedimitern: https://github.com/juju/juju/pull/378809:59
dimiternvoidspace, will have a look09:59
voidspacedimitern: if we want to rebase a feature branch, instead of merge, then we can't just do it as a rebase then merge09:59
voidspacedimitern: because that ends up being the same as a merge09:59
voidspacedimitern: but if we want CI tests run then we *have* to do it as a merge09:59
jamfwereade: standup?10:01
voidspace dooferlad dimitern: I *think* the rebase is now done on the feature branch10:28
dimiternvoidspace, I'll update and do a make check locally10:29
dimiternvoidspace, has it landed?10:30
voidspacedimitern: I pushed...10:31
dimiternvoidspace, I can't see any changes10:31
voidspacedimitern: hmmm...10:31
voidspaceI pushed to upstream/maas-spaces10:32
voidspaceI wonder where that went10:32
dimiternvoidspace, it looks like you pushed voidspace/juju branch maas-spaces-rebase-110:32
voidspacedimitern: I already had that10:32
dimiternvoidspace, ah, ok10:32
voidspacedimitern: that was my initial rebase on Friday10:32
dimiternvoidspace, we as mere devs no longer have direct commit rights for the upstream repo btw10:33
voidspaceI did a fresh fetch --all then checked out upstream/maas-spaces10:33
voidspacethen did a rebase10:33
voidspacethen pushed10:33
voidspacedimitern: well I did wonder that10:33
voidspacedimitern: I half expected my push to fail10:33
voidspacedimitern: if that is indeed the case then we *can't* do a direct rebase, except using the jujubot credentials or via CI doing a merge10:33
voidspacehowever the push *appeared* to work10:33
voidspacebut the changes aren't there10:34
dimiternyeah10:34
dimiternlet's wait for frobware to come back - he has perms10:34
voidspacecool, he can do it :-)10:34
* frobware back with new shiny keyboard... :)10:42
dimiternfrobware, congrats ;)10:42
frobwaredimitern, dooferlad, voidspace, jam: anything to note from the standup?10:43
dimiternfrobware, we need your expertise (and perms) to do the rebase of maas-spaces :)10:43
* frobware is struck by how nice a new keyboard feels...10:43
dooferladfrobware: not unless you count dimiter in HD10:43
dimiternoh yeah - new laptop, new cam, etc.10:43
frobwaredimitern, all working?10:43
dimiternfrobware, now it is - I had issues mostly around getting the 4K screen to work with my external HD monitor10:45
dimiternfrobware, and I somehow managed to mess up the packages yesterday, so this morning it wasn't booting properly and had to reinstall from the usb10:46
frobwaredimitern, eww10:46
frobwaredimitern, voidspace: rebase to master? I see some chat - what's the redux?10:47
voidspacefrobware: I pushed, it vanished10:47
frobwarevoidspace, you pushed to hard... :)10:48
voidspacefrobware: I shouldn't be able to push anyway as mere devs don't have push rights to core repo10:48
voidspacefrobware: probably10:48
voidspacefrobware: upshot is, you have to do it as you have perms and we don't10:48
voidspacefrobware: so we're leaving it to you10:48
frobwarevoidspace, and in terms of the rebase we're happy to take whatever is on tip this morning?10:48
* frobware will rebase, test, then push10:49
voidspacefrobware: well, I thought putting through CI (and therefore doing a merge not a rebase) was a good idea10:50
voidspacefrobware: however dimitern and dooferlad point out that we need to accept master *anyway*10:51
voidspaceso a rebase is fine10:51
voidspacewith the slight caveat that master currently has tests that fail for me :-(10:51
voidspacebut those are marked as critical and being worked on10:51
frobwarevoidspace, shall we choose a different commit for the rebase then?10:52
voidspacefrobware: we could just wait10:52
frobwarevoidspace, let's do that; do we urgently need something from master today?10:54
voidspacefrobware: I don't think so, we just don't want to drift too far out of sync.10:54
voidspacewe have a map ordering dependency in a test11:07
voidspacesometimes it passes, sometimes it fails11:07
voidspaceTestListAllOkay in payload/persistence/env_test.go11:07
voidspaceor a timing issue I guess11:14
frobwarevoidspace, that's in maas-spaces, master, somewhere else?11:17
voidspacefrobware: well, I'm looking at my branch11:19
voidspacefrobware: I bet it's on master too - will check11:19
voidspacefrobware: yep, I see it on master too11:19
voidspacefrobware: hard to tell if the ordering is significant11:20
voidspacefrobware: committed by ericsnow in October11:21
frobwarevoidspace, I just had successful unit test run on master; was rebasing maas-spaces11:21
voidspacefrobware: it maybe a timing issue, or a wily issue, or something else11:23
voidspacefrobware: but that test fails intermittently for me on master11:23
voidspacefrobware: are you on wily?11:23
frobwarevoidspace, nope - trusty11:24
voidspaceright11:24
dimiternvoidspace, I see the same error on wily with go 1.5.111:24
voidspacedimitern: I'm using go 1.3.311:24
voidspacedimitern: so wily is the common factor11:24
dimiternvoidspace, yeah, seems so - why 1.3.3 btw?11:25
voidspacedimitern: I built go from source a long while ago11:26
voidspacedimitern: and have seen no compelling reason to change the version I'm using11:26
voidspacedimitern: I easily can11:26
dimiternvoidspace, I see11:27
dimiternvoidspace, well, 1.5.1 in wily is slightly faster fwiw11:27
voidspacecool11:29
voidspacewill switch at some point11:29
fwereademattyw, do you recall offhand why api/metricsmanager is using the user-facing ClientFacade stuff?11:38
mattywfwereade, I'm about to go afk for 30 mins, happy to talk when I get back11:51
fwereademattyw, no rush11:51
mattywfwereade, looking at it quickly I suspect it's just bad code - it just needs base.FacadeCaller I think, I'll take a look when I get back an fix it11:52
fwereademattyw, no need, I've speculatively hit it already, just wannted to check I wasn't missing something11:53
frobwarevoidspace, dooferlad, dimitern: http://reviews.vapour.ws/r/3206/12:15
voidspacefrobware: but if you merge it as a pull request it will appear as a merge12:16
dimiternfrobware, looking12:16
frobwaredimitern, so it needs pushing to upstream/maas-spaces then?12:16
dimiternfrobware, LGTM12:17
dimiternfrobware, yeah12:17
dimiternfrobware, unless CI can pick it up I guess?12:17
voidspacedimitern: frobware: if CI picks it up it will be a merge not a rebase12:27
voidspaceif should be pushed to upstream/maas-spaces12:27
rick_h_wallyworld: still around by chance?12:39
wallyworlda bit12:39
rick_h_wallyworld: the series in metadata for core, is that in a feature branch or trunk for 1.26?12:39
wallyworldwas featyre branch, merged in last week12:39
wallyworldbt ony local so far12:39
wallyworldstill wip12:39
wallyworldneed to add forced overrides12:39
wallyworldalso charm store charms12:40
wallyworldand subordinates and upgrades12:40
rick_h_wallyworld: ok cool, do we have a list of items needed to wrap it up on the local side? urulama is close to the store end and I want to make sure we've got a path that ties it into a nice bow for delibery12:40
urulamarick_h_: had a chat this morning, we have a cunning plan :)12:41
wallyworldthere's the spec which defines the overall. there's no done this, need to do that list12:41
wallyworldand yes, we did talk about it :-)12:41
rick_h_urulama: :) ok12:41
urulamarick_h_: i've written the outline of events in the email, but having an action plan would be great, yes. we'll work on it with wallyworld and probably include cmars as well12:43
rick_h_urulama: ok ty12:44
wallyworldaction plan for series in metadata?12:44
rick_h_urulama: wallyworld just want to make sure we've got all the parts in sync and no blockers on getting this 1.26 along with the publish stuff.12:44
urulamawallyworld: yes, series.12:45
rick_h_wallyworld: a bit bigger, we've got a proof point of making the juju-gui charm one charm, mutliple series, published with the new development channel work, pushed from our CI infrastructure12:45
wallyworldok12:45
wallyworldrick_h_: this was a huge undertaking for the 1.26 timeframe, so the work will be ongoing till the deadlines12:46
rick_h_wallyworld: understand, just looking ot make sure there's no dead/blocked time so we can make it. Thanks for the heads up that the current work is in master currently.12:47
wallyworldsure, np12:47
wallyworldrick_h_: i plan on advertising this to feature buddies for beta1 when the local use cases should be pretty much done (with --force options, etc)12:48
rick_h_wallyworld: <3 ty12:49
wallyworldadding support for charm store charms will not be too much extra from a core perspective after that12:49
rick_h_wallyworld: right, I was just nervous it was still in feature branch and curious how much it would take to get it merged into master as sometimes that seems to take a bit.12:50
rick_h_wallyworld: my concerns are all put to bed :) you go enjoy your evening.12:50
wallyworldrick_h_: it did take a bit, but i've done it already :-)12:50
wallyworldrick_h_: if you definition of enjoy is working on a series in metadata PR, I will have a ball12:51
urulama:D12:51
urulamathat's a small PR, wallyworld :)12:51
urulamachecking if that's all that needs to change, now, that's another thing :P12:51
wallyworldi wish it were simple, this current PR has a lot of touch points12:52
marcoceppihelp please bootstrapping agent-version? http://paste.ubuntu.com/13476900/14:17
voidspacedooferlad: your branch of gomaasapi on launchpad doesn't currently build14:25
voidspacedooferlad: do you have a version you can push that does build?14:25
dooferladvoidspace: In the middle of a change, but give me a few minutes14:25
voidspacedooferlad: cool - thanks! Let me know when.14:25
dooferladvoidspace: do you have a build error you can pastebin?14:25
voidspacedooferlad: obviously doesn't need to be feature complete but I'd like to start using the bits that do work14:26
voidspacedooferlad: line 101 of testservice.go Space undefined14:26
voidspacedooferlad: the spaces member of the TestServer is map[uint]Space14:26
dooferladvoidspace: bother, OK.14:27
voidspacedooferlad: maybe you forgot to add a file?14:27
dooferladvoidspace: I purposefully didn't, but clearly I need to.14:27
voidspaceheh14:27
dooferladvoidspace: give that a go14:42
dooferladvoidspace: example code: http://pastebin.ubuntu.com/13477034/14:43
voidspacedooferlad:  "github.com/dooferlad/here"14:43
dooferladvoidspace: no tests for the newest code, but I hope it compiles.14:43
voidspacedooferlad: in jsonobject.do14:43
voidspace*.go14:43
dooferladvoidspace: Eugh, just delete all here references and you will be fine.14:44
voidspacedooferlad: ok14:44
voidspacehere is used quite a lot in testservice.go14:45
voidspacedooferlad: is this because you're developing on github and then pushing to launchpad?14:45
voidspaceor some other hack14:45
voidspaceor is it an error logging package14:46
dooferladvoidspace: it is my debug data logger library. You can go get github.com/dooferlad/here to make it go away14:46
voidspacedooferlad: cool, I'll do that14:46
dooferladvoidspace: it is really quite useful for debugging.14:46
voidspacedooferlad: yay, builds!14:47
voidspacedooferlad: and I'll look at your debug logger later :-)14:47
dooferladvoidspace: yay for building!14:47
dooferladvoidspace: I will brew tea in celebration!14:47
voidspacedooferlad: :-)14:47
voidspaceme too I think14:47
mattywwwitzel3, ping?14:58
dimiternvoidspace, dooferlad, so apparently p&c fixed the hr site and I'm no longer your manager there :)15:16
dimiternbut cadmin is yet to be fixed, so expense claims still come to me15:17
dooferladdimitern: congratulations on having less admin to do!15:20
dimiterndooferlad, cheers :)15:21
sinzuidimitern: voidspace Do either of you have a minute to review http://reviews.vapour.ws/r/3208/15:38
dimiternsinzui, LGTM15:38
sinzuithank you dimitern15:39
dooferladvoidspace: branch updated15:56
dooferladvoidspace: minor change in usage. See TestSubnetsInNodes.15:57
mattywkatco, ping?15:59
natefinchmattyw: she's out this week16:00
mattywnatefinch, yeah I only just saw, I pinged before checking the calendar16:01
mupBug #1519027 opened: lxd cannot bootstrap with streams <bootstrap> <ci> <lxd-provider> <juju-core:Triaged> <https://launchpad.net/bugs/1519027>16:40
mupBug #1519027 changed: lxd cannot bootstrap with streams <bootstrap> <ci> <lxd-provider> <juju-core:Triaged> <https://launchpad.net/bugs/1519027>16:55
mupBug #1519027 opened: lxd cannot bootstrap with streams <bootstrap> <ci> <lxd-provider> <juju-core:Triaged> <https://launchpad.net/bugs/1519027>16:58
dooferladvoidspace, dimitern, frobware: hangout17:01
alexisbnatefinch, you are the only moonstone rep this week correct?17:01
natefinchalexisb: eric is around more or less this week, but he just moved into a new house over the weekend, so may be in and out.17:04
natefinchalexisb: otherwise, yes17:04
voidspacedooferlad: dammit, always catches me by surprise17:13
voidspaceI should check at the start of the day17:13
=== Spads_ is now known as Spads
=== Spads_ is now known as Spads
voidspacedooferlad: so subnet IDs come in from the test server as integers - which the gomaasapi helpfully turns into float6418:16
voidspacedooferlad: as far as I can tell this does match what maas itself spits out18:16
voidspacedooferlad: but it's a mild pain for the code18:16
voidspacedooferlad: currently it doesn't look like the space name is making it across from the test server though (I'm getting nil back from the json even though the gomaasapi.CreateSubnet has the Space field populated)18:17
voidspaceericsnow: one of your payload tests fails intermittently on wily18:48
voidspaceericsnow: maybe a go 1.3+ issue (do you use go 1.2?)18:48
voidspaceericsnow: and new house?18:48
ericsnowvoidspace: :)18:49
voidspace:)18:49
ericsnowvoidspace: does it look like #1516541?18:49
mupBug #1516541: payload/api/private: tests do not pass <juju-core:Triaged> <https://launchpad.net/bugs/1516541>18:49
voidspaceericsnow: no18:49
ericsnowvoidspace: k, I'll take a look18:50
voidspaceericsnow: payload/persistence18:50
ericsnowvoidspace: filed a bug?18:50
voidspaceericsnow: of course not18:50
ericsnowvoidspace: :)18:50
voidspaceericsnow: doing it now18:50
ericsnowvoidspace: thanks18:51
voidspaceericsnow: https://bugs.launchpad.net/juju-core/+bug/151906118:52
mupBug #1519061: payload/persistence intermittent failure <juju-core:New> <https://launchpad.net/bugs/1519061>18:52
ericsnowvoidspace: thanks18:52
voidspaceericsnow: dimiter sees it too, I use go 1.3 and he uses go 1.518:53
mupBug #1519061 opened: payload/persistence intermittent failure <juju-core:New> <https://launchpad.net/bugs/1519061>18:53
voidspaceericsnow: we're both on wily18:53
ericsnowvoidspace: k18:53
mupBug #1519061 changed: payload/persistence intermittent failure <juju-core:New> <https://launchpad.net/bugs/1519061>18:58
mupBug #1519061 opened: payload/persistence intermittent failure <juju-core:New> <https://launchpad.net/bugs/1519061>19:01
mupBug #1519061 changed: payload/persistence intermittent failure <juju-core:New> <https://launchpad.net/bugs/1519061>19:04
mupBug #1519061 opened: payload/persistence intermittent failure <juju-core:Triaged> <https://launchpad.net/bugs/1519061>19:07
cheryljfrobware: ping?19:08
cheryljfrobware: if you're still around, could you update bug 1516891 with your status?19:13
mupBug #1516891: juju 1.25 misconfigures juju-br0 when using MAAS 1.9 bonded interface <juju-core:Triaged by frobware> <MAAS:Invalid> <https://launchpad.net/bugs/1516891>19:13
fwereadewaigani, ping19:30
waiganifwereade: pong19:30
fwereadewaigani, do you know any of the details of how we auth the per-env api connections for the per-env workers?19:31
fwereadewaigani, can controller-machine-0 always log into its own hosted environments? or do they have separate creds or something?19:32
fwereadewaigani, ("I have no idea" is a perfectly reasonable answer, no need to look stuff up if it's not immediately to mind, I'm just looking for a quick answer if it's there)19:33
waiganifwereade: right, I was digging :)19:33
fwereadewaigani, np, I can dig myself :)19:34
waiganiokay, yeah of the top of my head all I can say is it's a good question. thumper will be on soon. I'll check with him too.19:34
waiganifwereade: btw I'm polishing off the system kill. Here's the output: http://paste.ubuntu.com/13468747/19:35
fwereadewaigani, that would be nice, thanks19:35
waiganiand with -v : http://paste.ubuntu.com/13468473/19:36
fwereadenice :D19:36
fwereadelovely19:36
waiganiI'm going to add a header and footer message and not count dead environments19:36
fwereadewaigani, yeah, sounds good19:36
waiganibut yeah, it was cool to watch everything go down19:36
fwereadewaigani, very nice indeed19:37
waiganifwereade: talking with thumper, we thought we'd do the same for environment destroy19:38
waiganii.e. show the same kind of tapering off status, just with machines and services19:39
fwereadewaigani, <319:39
fwereadewaigani, soon I'll want it for units per dying service, and units in scope per dying relation :)19:40
waiganilol19:41
natefinchfwereade: if you have some time in the next couple days, a review on this would be good... it's the other half of the min version stuff, in the charm repo, with your suggested changes from the other review: https://github.com/juju/charm/pull/17619:42
waiganifwereade: not sure if this answers your question, but the undertaker worker apiserver endpoint has two auth checks 1. are you a machine agent 2. are you an environment manager19:46
waiganifwereade: and that worker would be dialing in from machine 019:47
natefinchis it just me, or is the help on storage add internally inconsistent?  "a comma separated sequence of: POOL, COUNT, and SIZE19:49
natefinchjuju storage add u/0 data=ebs,1024,319:50
natefinch... pretty sure that's not supposed to be 1024 instances of 3 meg storage19:50
natefinchmaybe it's supposed to be 1024M, and the order doesn't actually matter since the formats are all unique?  ug...19:53
waiganifwereade: quick answer is, no separate creds as worker agents only come from inside an environ i.e. already authed20:08
mupBug #1519081 opened: help for juju add storage is confusing <storage> <juju-core:New> <https://launchpad.net/bugs/1519081>20:11
mupBug #1519081 changed: help for juju add storage is confusing <storage> <juju-core:New> <https://launchpad.net/bugs/1519081>20:23
mupBug #1519081 opened: help for juju add storage is confusing <storage> <juju-core:Triaged> <https://launchpad.net/bugs/1519081>20:26
fwereadenatefinch, thanks20:31
mupBug #1519095 opened: state: tests to not pass with -race under Go 1.2 <juju-core:New> <https://launchpad.net/bugs/1519095>20:50
cheryljnatefinch: did katco talk to you about bug 1517344?21:02
mupBug #1517344: state: initially assigned units don't get storage attachments <bug-squad> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1517344>21:03
=== urulama is now known as urulama__
mupBug #1519097 opened: juju/utils/fslock: data race caused by createAliveFile running twice <juju-core:Triaged> <https://launchpad.net/bugs/1519097>21:14
mupBug #1514462 changed: Assertion failure in TestAPI2ResultError <ci> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1514462>21:20
mupBug #1514462 opened: Assertion failure in TestAPI2ResultError <ci> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1514462>21:23
mupBug #1514462 changed: Assertion failure in TestAPI2ResultError <ci> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1514462>21:26
mupBug #1514462 opened: Assertion failure in TestAPI2ResultError <ci> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1514462>21:29
davechen1y        for misses := 0; misses < 0; misses++ {21:32
davechen1ylet's count to 2^6321:32
mupBug #1514462 changed: Assertion failure in TestAPI2ResultError <ci> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1514462>21:41
fwereadethumper, thank you for the excellent comments in apiserver/admin.go, they were exactly what I needed to know21:47
thumper:)21:47
davechen1y                        logger.Debugf("Failed to replace lock, giving up: (%s)", err)21:56
davechen1yfatal error logged at debug21:56
fwereademenn0, apiserver/apiserver.go:321 -- we don't statePool.Close until after the tomb.Done21:59
fwereademenn0, is there a reason? I'd usually expect a tomb.Kill(statePool.Close()) *before* the done22:00
menn0fwereade: probably a think-o22:00
* menn0 checks code22:00
menn0fwereade: I remember soon after the StatePool work went in there were panics due to the StatePool being closed too soon22:02
menn0fwereade:  tomb.Kill(statePool.Close()) before the done seems right to me22:03
fwereademenn0, ok, interesting, I will take care around there :)22:03
fwereademenn0, I would hope that the wg.Wait would be enough to get the apiserver's mitts off it22:04
menn0fwereade: yeah, that should be enough22:04
menn0fwereade: it's possible I initially had the defers the wrong way around or something22:04
fwereademenn0, ah yeah :)22:04
fwereademenn0, thanks22:04
menn0fwereade: I think originally all the cleanups were separate defer lines22:05
menn0not trusting my memory too much though22:05
fwereademenn0, ha, yeah, there's something rather off about that sort of construct22:05
mupBug #1510952 changed: Upgrades broken in 1.22 tip <blocker> <ci> <regression> <upgrade-juju> <juju-core:Won't Fix> <juju-core 1.22:Won't Fix> <https://launchpad.net/bugs/1510952>22:11
alexisbthumper, wallyworld I am going to be a bit late for our next call23:30
wallyworldok23:30

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!