/srv/irclogs.ubuntu.com/2015/12/03/#snappy.txt

=== chihchun_afk is now known as chihchun
=== chihchun is now known as chihchun_afk
=== chihchun_afk is now known as chihchun
=== chihchun is now known as chihchun_afk
=== chihchun_afk is now known as chihchun
=== chihchun is now known as chihchun_afk
dholbachgood morning08:19
mvoasac: you mentioned that the webdm store is empty. with what version of snappy do you see this? 15.04? or rolling?08:19
mvohey dholbach, good morning08:20
dholbachhey mvo08:20
mvoasac: I have a rebuild of webdm ready now but want to reproduce the issue first before blindly uploading08:20
=== chihchun_afk is now known as chihchun
=== chihchun is now known as chihchun_afk
=== chihchun_afk is now known as chihchun
mvofgimenez: hi, I uploaded a fix for the /tmp issue from yesterday, buildig a new image now09:45
mvofgimenez: to verify the fix09:45
zygagood morning!09:50
fgimenezmvo, ok thanks a lot! let me know when i can give a try09:51
fgimenezhey zyga :)09:51
* zyga prefers to stick to irc09:51
=== chihchun is now known as chihchun_afk
=== chihchun_afk is now known as chihchun
zygaChipaca: can we please land http://github.com/ubuntu-core/snappy/pull/21210:10
zygaChipaca: I think everything is addressed now10:10
=== chihchun is now known as chihchun_afk
mvozyga: I followed up with a question, I'm sorry if the question is dumb10:32
zygamvo: no questions are, thanks, I've replied10:34
Chipacazyga: something something inquisitive idiots?10:40
zygaChipaca: hehe :)10:40
zygaChipaca: do you know that mvo helped me out in my first days of ubuntu?10:41
zygaChipaca: mvo is awesome!10:41
Chipacazyga: i'd be more surprised if he hadn't, because yes10:41
Chipacaalso, a joy to work with10:41
Chipacaeven when he asks dumb questions :-p10:42
Chipacazyga: landed10:44
* mvo blushes10:45
fgimenezmvo, test suite passing locally with 272 \o/10:55
Chipacazyga: do you have a link to that reflects-using monstrosity again?11:01
Chipacazyga: outside of a hangout i'd like to look at it to show you a more gothic way of doing it, even if you won't use that code because of the simplification11:02
Chipacazyga: got it11:05
zygaChipaca: sure11:10
zygaChipaca: oh, sorry, I was slow11:10
zygaChipaca: I went to remove some code from https://github.com/ubuntu-core/snappy/pull/20511:10
zygaChipaca: I think that fixes all of the comments now11:10
Chipacazyga: so, in this case https://github.com/zyga/snappy/blob/caps-api-assign/daemon/api.go#L101611:11
Chipacazyga: because you're racing to have a vertical working, it's fine to use reflect.DeepEqual to save time11:12
Chipacazyga: but the "right" way would be to implement an Equals or whatever yourself11:12
zygaChipaca: on Assignment struct?11:12
zygaChipaca: will that make comparison on two slices work?11:12
zygaChipaca: (not that this code is staying but I'm curious how to do it in go in general)11:12
Chipacaeither on Assignment or on Caps, depending on the usage11:13
zygaChipaca: I mean I only used deep equals because AFAIR go's doesn't compare slices11:13
Chipacazyga: e.g., newCap.Assignments.Equals(oldCap.Assignments)11:13
Chipacazyga: fwiw, in the general case, DeepEquals will not do what you want11:14
Chipacazyga: it only works there because you're only letting Assignments have 0 or 1 elements11:14
zygaChipaca: oh?11:14
Chipacazyga: but given that it's more like a set, order shouldn't be important11:14
zygaChipaca: can you explain why it would not work?11:14
Chipacazyga: (unless i'm misunderstanding)11:14
zygaChipaca: ah,I see11:14
zygaChipaca: yes, I really miss basic collections here11:14
Chipacaso [ass1, ass2] should be equal to [ass2, ass1]11:14
zygaChipaca: yep, you are correect11:15
zygaChipaca: this is a Set[Assignment] in python's 3.5 parlance11:15
Chipacazyga: even more reason to punt that work to after the demo11:15
Chipacazyga: is an assignment ever going to be more than a snap name and a slot name?11:17
zygaChipaca: I don't believe so11:18
zygaChipaca: it's sufficient for anything I was imagining much further down the linre11:18
zygamvo, Chipaca: it would really help me if you could re-check and land https://github.com/ubuntu-core/snappy/pull/205 that I didn't miss anything11:19
Chipacazyga: Assignments is a set, not a multiset?11:19
Chipacaer11:25
zygathis blocks https://github.com/ubuntu-core/snappy/pull/20611:25
Chipacazyga: i mean, if Assignment A == Assignment B only if A's snap and slot == B's snap and slot11:25
Chipacazyga: then, if A == B, A and B can't both be in Assignments?11:25
zygaChipaca: it is a set, not a multi-set11:25
zygaChipaca: Set[Tuple[str, sr]] in python's typing11:25
zygaChipaca: you are exactly right11:25
Chipacazyga: https://play.golang.org/p/YZm8ETL5gS11:29
Chipacazyga: actually, ignore that for a bit11:31
* Chipaca adds stuff11:31
Chipacazyga: https://play.golang.org/p/en_H4bVD7x11:35
zygaChipaca: looking11:40
zygaChipaca: why a map?11:41
zygaChipaca: and can a map use Assignment keys? I assume go somehow makes that struct comparable beause it has trivial fields11:41
Chipacazyga: because a set is a map without values11:41
zygaChipaca: ah, right, that makes sesnse11:42
zygaChipaca: thanks!11:42
zygaChipaca: I'm looking at https://github.com/ubuntu-core/snappy/pull/208#discussion_r4645453311:43
zygaChipaca: it seems the gustavo wants .err() on the deaemon.response (or was it resp) type11:43
Chipacazyga: https://golang.org/ref/spec#Comparison_operators11:43
zygaChipaca: not sure though11:43
Chipacazyga: best to ask gustavo what gustavo wants :)11:44
Chipacazyga: “Struct values are comparable if all their fields are comparable. Two struct values are equal if their corresponding non-blank fields are equal.”11:44
zygaChipaca: right, I remember reading that a few weeks ago, I was just double checking11:44
Chipacazyga: meaning that as long as the structs contain things that compare by value, it'll work as expected11:45
Chipacameaning: no pointers, no slices11:45
zygaChipaca: how would you feel if I added daemon.resp.err() method11:45
Chipacazyga: puzzled11:45
zygaChipaca: that conjures an error if the stuff is right11:45
Chipacazyga: puzzled because client doesn't use daemon, and shouldn't11:46
zygaChipaca: but gustavo pointed out a test case for api.go11:46
zygaChipaca: so this is pure server side stuff11:47
Chipacahrmm11:48
Chipacai guess i'm going to go *read*11:49
Chipacayou meanie11:49
zygaChipaca: well, I can go ahead and just do it11:49
zygaChipaca: but it feels somewhat weird since it's just for testing11:49
zygaChipaca: and this structure never becomes an error otherwise, as far as I can see11:49
Chipacazyga: there was a different comment from gustavo about err(), but i can't see it now11:49
Chipacawhere was taht?11:49
Chipacathat*11:49
zygaChipaca: it was about client side stuff and it's done now11:50
zygaChipaca: it was about processErrorResponse()11:50
Chipacaright, i think that might be where my confusion comes from (and i suspect, his too)11:50
zygaChipaca: there are similar comments involving .err() in several branches AFAIR11:50
=== LarreaMikel1 is now known as LarreaMikel
* zyga wonders what to do about pending requests as stuff is blocked11:53
zygaChipaca: I'll work on assign changes we've discussed11:53
zygaChipaca: even if it doesn't land before end of week, I'd like to have something that works to show11:53
Chipacazyga: there ya go12:01
Chipacazyga: i think that one's ready to land with this, yes?12:02
zygaChipaca: https://github.com/ubuntu-core/snappy/pull/208 ? I'd like to improve the test for client.AddCapability() to observe the POST being made12:06
zygaChipaca: I'm just reading how to mock that with SetDoer12:06
asacmvo: 15.0412:07
asacmvo: if you have a snap i can test it12:07
mvoasac: what version of webdm is installed for you?12:07
Chipacazyga: so you want an integration-ish test12:08
asacmvo: http://104.196.33.52:4200/12:08
ogra_lol12:08
ogra_yay security !12:08
Chipacaogra_: ?12:08
* ogra_ goes and installs transmission in asac'S machine 12:08
asacthats great12:08
asacdo it :)12:08
* ogra_ does12:09
Chipaca*gasp*12:09
* Chipaca installs windows 10 on ogra's machine12:09
asactell me if you can do anything with it12:09
ogra_http://104.196.33.52:9091/ seems blocked by your firewall12:09
asacsee :P12:09
Chipacaasac: i uninstalled http.chipaca12:09
Chipacaasac: you can't trust that chipaca person12:10
mvoasac: please run "sudo snappy install webdm/edge" and see if that installs version 0.1112:10
* ogra_ removes transmission again ... useless :P12:10
asacseems hackers have some sense of clean room :)12:10
ogra_do we have a bu for the "ubuntu-core is -1B big"12:10
ogra_?12:10
ogra_*bug12:11
asacmvo: sudo snappy install webdm/edge12:11
asacInstalling webdm/edge12:11
asacwebdm/edge failed to install: a package by that name is already installed12:11
mvoasac: hm, sudo snappy update webdm/edge maybe ? if not you need to uninstall first and then reinstall webdm/edge12:11
mvo(sorry for that)12:12
Chipacahah!12:12
Chipacathe url for channels in webdm needs to be *triple* escaped12:12
Chipacae.g. http://104.196.33.52:4200/snap/http.chipaca%25252fstable/12:12
ogra_third time is the charm :)12:12
ogra_"Mode.fetch() failed"12:13
ogra_heh, and reloading it works :P12:13
asacmvo: update did nothing12:13
mvoasac: ok, please remove install again12:14
asacdoing12:14
asaclooks good12:14
asacsee yourself12:14
ogra_nethack installed !12:15
asacjust saw that :)12:15
mvoasac: yay12:15
Chipacazyga: sorry, getting back to you now12:15
mvoasac: ok, if you don't find anything bad I will promote to stable after lunch12:15
asacmvo: so chnnels are now happy?12:15
* Chipaca was having too much fun breaking asac's stuff12:15
Chipacazyga: that test is supposed to check that the client made the right request, correct?12:16
zygaChipaca: yes12:16
Chipacazyga: in which case, grab cs.req and check it12:16
zygaChipaca: I just figured that out12:16
zygaChipaca: :D12:16
zygaChipaca: it's a bit convoluted at first when you're not familiar12:16
zygaChipaca: personally I would unabbreviate some of the variables12:16
mvoasac: yes, it seems to be. if you don't see anything breaking I will promote to stable12:16
zygaChipaca: rsp,req,resp all look too similar12:16
Chipacabut they line up so nicely when everything uses just three letters :-p12:16
mvonethack!12:16
* asac installs lxd curl and mosquitto12:17
ogra_you have been eaten by a grue !12:17
asachmm. lxd failed to install it tells me12:17
zygaChipaca: I think it's because it's not my first language12:17
ogra_asac, it does that for docker too but in fact the install works12:18
ogra_asac, check on cmdline12:18
asacok seems it doesnt really like concurrent installs :)12:18
ogra_i think the timeout is to sowrt or some such, bot do some setup12:18
asaclxd really failed12:18
asacbut i think i just clicked too fast12:18
asacnow it workd12:19
Chipacazyga: i'm bad with names, everybody knows that12:19
* ogra_ installs moon-buggy too ... now you have a true snappy gamer system !12:19
asachaha12:19
asacmoon buggy is buggy :P12:19
asacnice game12:19
asac moon-buggy.moon-buggy12:19
asacmkdir: cannot create directory ‘/home/ubuntu/apps/moon-buggy.dholbach’: Permission denied12:19
ogra_is it ?12:19
ogra_wow12:20
asacthat feels like a bug12:20
asacin snappy12:20
ogra_yeah, it should use the version there12:20
asacthe version?12:20
asaci have http.chipaca in that dir12:20
asacthat has a version indeed12:20
ogra_/home/ubuntu/apps/moon-buggy.dholbach/$version/12:20
asacmaybe12:21
asacwho is creating that directory?12:21
asacsnappy?12:21
ogra_the launcher i think12:21
Chipacaum12:21
Chipacathat'll happen12:21
Chipacaif you run the app once as root, and then as the user12:21
asaci didnt run it as root12:21
Chipacahmm12:21
zygaChipaca: /me wonders how to get the request body out of the "mock" doer code12:21
Chipacaah, cannot create, not cannot read12:21
asacyes12:22
Chipacazyga: req.Body12:22
asacwe shouldnt have reomved http.chipaca i am sure12:22
Chipacazyga: cs.req.Body12:22
Chipacaasac: I did that one12:22
zygaahhh12:22
* zyga is dumb12:22
Chipacaasac: i mean, i removed that12:22
zygaChipaca: my code did cs.req.Body12:22
zyganote the req :/12:22
zygawait12:22
zygano12:22
zygawhat's wrong?12:22
* zyga looks12:22
Chipacazyga: no, not dumb. inquisitive :-p12:23
Chipacazyga: um, that looks right12:23
asacmosquitto seems to not register binaries12:23
Chipacado you want the response body, or the request body12:23
asace.g. there is nothing in PATH with mosq*12:23
ogra_should there ?12:23
ogra_(does it actually ship any binaries)12:23
zygaChipaca: it doesn't work, see:12:23
asaccurl works12:23
zyga    c.Check(cs.req.Body, check.Equals, "foo")12:23
zyga... obtained ioutil.nopCloser = ioutil.nopCloser{Reader:(*bytes.Reader)(0xc820013650)}12:23
zyga... expected string = "foo"12:23
asacogra_: well, i think it does12:23
asac/apps/mosquitto.kartben/current/magic-bin/12:24
asacarm-linux-gnueabihf  mosquittox86_64-linux-gnu12:24
ogra_i thought it has a web UI12:24
asacnah its a mqtt CLI thingy12:24
ogra_ah, k12:24
asacat least i think12:24
ogra_the package is from may12:24
asacmaybe i am wrong12:24
asacsyre12:24
asacyes12:24
ogra_might need an update12:24
asacdo we break old packages?12:24
ogra_well, the yaml formats all changed a lot in the last months12:25
asacso you are right12:25
asacthere is a daemon running12:25
asacok seems its really the broker12:25
asacnot the cli12:25
Chipacazyga: cs.req.Body is a ReadCloser12:25
Chipacazyga: you need to read it12:25
ogra_ah, right12:26
asacso false-warning\12:26
zygaChipaca: thanks12:26
asacok i opened port mosquitto-1883 so you can now use that as your mqtt message broker12:29
ogra_asac, open 80 too ;)12:30
asacwhats on 80?12:30
ogra_upnp-server12:30
* ogra_ wants to see if webdav works via internet 12:30
asacogra_: will this allow you to hack that tghing?12:30
asaclighthttp is running on it12:31
ogra_nah, it will only allow my nautilus to connect to dav://104.196.33.52/12:31
asacokk 80 should be open soon12:31
ogra_hmm12:32
ogra_ha ! works :)12:32
ogra_if you open vlc (or any other upnp/dlna capable player in your lan) you should see a snappy upnp server now12:33
ogra_with one song12:33
asacogra_: this is not running in my lan12:33
ogra_ah12:34
ogra_well dav://104.196.33.52/ works at least :)12:34
asacyeah12:34
asacdont share illegal files there please :{12:34
ogra_heh12:34
* ogra_ removes the file12:34
asacwait12:34
asaclet me get it first :12:34
ogra_lol12:35
ogra_oh, bug !12:35
ogra_i cant delete it12:35
asaclol12:35
asacits a honeypot12:35
asaci called the police now12:35
asacwith clear evidence12:35
ogra_haha12:35
asacwhere do i find that stuff?12:35
asacok found it12:36
ogra_/var/lib/apps/upnp-server-armhf.ogra/0.1.0/Media/12:36
asacthats legal isnt it?12:36
asacits gone :P12:36
ogra_well, i paid for the mp3 ... spreding it isnt legal i think12:36
ogra_*spreading12:36
asacu can also pay for gpl software12:36
ogra_christams is coming soon !12:37
ogra_:)12:37
asacodd i can publish to that mosquitto thing12:40
asacbut if i sub i dont see the message12:40
* zyga fixed tests with Chipaca's advice!12:44
zygaChipaca: https://github.com/ubuntu-core/snappy/commit/fe8ddc2c933db716ab9890f8c35b5315451786f612:45
ogra_hmm12:45
zygaChipaca: that's the new test, if you agree it's sufficient then let's land it12:45
Chipacadude12:45
Chipacaduuuude12:45
ogra_why does snappy list on the RPi show generic-i386 and generic-amd64 ?12:46
ogra_webdm hides them i thnk12:46
Chipacazyga: if you were going to unmarshal it, just pass json.NewDecoder(req.Body) ftw12:46
Chipacasnappy just spits out everything the store tells it12:47
Chipacawebdm is more cautious12:47
Chipacamaybe :-p12:47
ogra_i thought webdm just uses snappy as backend ...12:48
ogra_but apparently it adds extra filtering12:48
zygaChipaca: oh, nice, I can tweak that12:48
Chipacaogra_: it's also possible that one of the two is using the wrong store headers12:48
ogra_yeah12:49
Chipacaogra_: webdm is linked against a version of snappy that might not be the system snappy12:49
ogra_yup12:49
Chipacaogra_: (this is one of the things the rest api is trying to fix)12:49
* Chipaca expects to get there before EOY12:49
ogra_+112:49
zygaChipaca: simplified https://github.com/ubuntu-core/snappy/commit/db9343ccda229cc40a0c676a3b10469bab2a254112:52
Chipacazyga: \o/12:55
Chipacazyga: except for the bit about all tests failing12:55
zygaoh12:56
zygayes, bits landed in the meantime12:56
zygano worries, just merge12:56
Chipacazyga: meaning i should just merge, or meaning it's just a merge that you're doing?12:59
zygafixed12:59
zygaChipaca: no, merge removed the carpet from under this branch's feet12:59
zygaChipaca: I just pushed the fix for that, two trivial patches12:59
Chipacak12:59
zygaChipaca: https://github.com/zyga/snappy/commit/10fcafb771c5002bc9831714de0b6573fc4c45f1 and https://github.com/zyga/snappy/commit/3e458f3208f565ad327a1285912930d07326412c13:00
sergiusenskyrofa, are you up? I have some PRs and thought of bugging you instead of Chipaca ;-)13:11
kyrofasergiusens, yeah man, hit me13:11
kyrofasergiusens, snapcraft? Heading there now13:11
sergiusenskyrofa, yeah, one already reviewed by elopio but I left it there so you can go over it too; as soon as that is done, there are 3 more down the pipe13:13
sergiusenskyrofa, I would create them already but the PR doesn't update with the commit id's that have been merged :-/13:14
kyrofasergiusens, looking at it now13:15
elopiosergiusens: kyrofa: I have one too: https://github.com/ubuntu-core/snapcraft/pull/13713:15
elopiosergiusens: this is the one you deleted before. Maybe it's still there because you hate it and want it to die.13:15
kyrofaWait a minute... elopio why are you up?13:17
elopioI don't know. I can't sleep anymore.13:18
kyrofaPoor guy13:21
mvoasac: I updated webdm in the stable channel now to 0.11 too13:37
Chipacazyga: you're going to push a merge to caps-api-remove-capability ?13:38
kyrofasergiusens, now that we have two release branches, what is the process for getting a fix into both of them?13:41
kyrofasergiusens, we might want to consider a CONTRIBUTING.md so github will provide guidance before anyone creates a PR13:42
kyrofaFor instance, dholbach's PR would probably be useful to both branches, no?13:43
asacmvo: great!13:44
=== Ursinha_ is now known as Ursinha
zygaChipaca: yes13:45
zygaChipaca: just fixing tests to mean stuff13:45
Chipacak13:46
* zyga starts to feel better about how requests work13:47
sergiusenselopio kyrofa, thanks13:49
sergiusenselopio, kyrofa here's another one https://github.com/ubuntu-core/snapcraft/pull/14413:49
zygaChipaca: https://github.com/ubuntu-core/snappy/pull/211#commits-pushed-5d934ac13:49
sergiusenskyrofa, that is a good idea, I saw it would be picked up by github; want to craft one or should I?13:50
zygaChipaca: I've added a TODO to document all the new REST calls13:52
Chipacazyga: good :) the one around attributes will change soon, right?13:52
Chipacameaning, dunno if it's worth documenting it until the whole thing is stable13:53
kyrofasergiusens, I'll take a crack at it13:53
zygaChipaca: attributes or assignments?13:53
Chipacaassignments, sorry13:53
zygaChipaca: yes13:53
zygaChipaca: very much so :)13:53
Chipacaand error handling overall13:53
Chipacaso don't worry *too* much about it :)13:54
Chipacaa little worry: ok. a lottle worry: very no13:54
Chipaca:)13:54
kyrofasergiusens, but we still need to decide how we'll do it. Make a PR to both? Backport as needed from master to 1.x?13:54
zygaChipaca: yes, I want to fix all the error handling on both client and daemon side13:54
sergiusenskyrofa, I'd say master first, and if it is supposed to go to 1.x make it as cherry pickable as possible (== less commits)13:55
kyrofasergiusens, what if we suggested that PRs be squashed?13:56
kyrofaToo much?13:56
sergiusenskyrofa, yeah, I'm +1 there13:59
kyrofasergiusens, alright I'll get on that as soon as I finish up this roslaunch thing14:00
sergiusenskyrofa, elopio ok, feel free to entertain yourself with this one https://github.com/ubuntu-core/snapcraft/pull/145 ;-)14:03
filmee24hello from germanmy14:04
filmee24*germany14:04
elopiofilmee24: hello.14:05
filmee24where are you from?14:05
elopiofilmee24: costa rica.14:06
filmee24cool. are you an developer?14:06
davmor2elopio: I still have my hat :)14:07
elopiofilmee24: a quality assurance developer.14:07
elopiodavmor2: I have mine too, but I can't wear it when I have long hair, it doesn't fit any more :(14:08
davmor2elopio: Ha I don't have that issue :D14:08
dholbachsergiusens, so 'vendor' for master should go away but for 1.x it can stay?14:08
elopiodavmor2: I know. Lucky you!14:08
davmor2elopio: Yeah well you live in a country where you don't necessarily need a hat to keep warm either so fairs fair ;)14:09
elopiodavmor2: it's not to keep you warn, it's to block the sun. I live in a country with sun, so yes, I win ;)14:10
sergiusensdholbach, yeah, for 1.x it needs to stay as 15.04 requires it14:12
davmor2elopio: but if you spray it with gortex it becomes waterproof and is the ideal hat to keep you warm and dry :D14:13
sergiusenskyrofa, sorry, I didn't wait for your review :-/14:13
sergiusenskyrofa, it is a good point and I will add that as part of the test14:13
davmor2elopio: although you still win you have sun14:13
kyrofasergiusens, haha, no problem14:13
dholbachsergiusens, done14:19
kyrofaOh, sergiusens elopio I have another meeting clashing with standup today. Any chance we can push it back an hour?14:20
elopiokyrofa: works for me. It will clash with my meeting with fgimenez, but we can just invite him today.14:24
kyrofaHey sounds good to me14:24
sergiusenselopio, kyrofa hmm, I'll see how I can make it then14:24
kyrofasergiusens, if that's difficult, would pushing it back a half an hour be better?14:25
sergiusenskyrofa, nah, an hour is easier, it just needs to last 15 minutes tops ;-)14:26
kyrofaAnd worst case I just miss it today if you guys want to just hold it at 0930. I've finished the ROS install bits and am working on upping the catkin plugin test coverage... which isn't so good14:26
kyrofaOkay we can do that!14:26
dholbachsergiusens, are you going to be on vacation at 21st Dec already?14:32
sergiusensdholbach, oh, I'll be avail on the 21st14:33
sergiusensdholbach, forgot to mention; I'll be off all other days though ;-)14:33
dholbachsergiusens, ok, cool - let me do some timezone math14:33
sergiusensdholbach, sure, I can wiggle time around and about14:33
sergiusensdholbach, just try to not make it 3AM my time :-) but I'm fine with 6AM or 10PM ;-)14:34
sergiusenseven midnight is fine if must be14:34
elopiosergiusens: I'm playing with hard stuff now, cloud9 that's nodejs. It ends up with the modules in /apps/cloud9.sideload/current/lib/node_modules/ls14:36
elopiosorry, hit enter too soon.14:36
elopioIt ends up with modules in /apps/cloud9.sideload/current/lib/node_modules/c9/node_modules, but it's not finding them.14:37
elopioon require, it says that the module is not found.14:37
elopiosergiusens: should I move the modules from node_modules/c9/node_modules to node_modules ?14:37
zygamvo: do you want some more action on https://github.com/ubuntu-core/snappy/pull/21114:38
sergiusenselopio, show me the yaml14:39
elopiosergiusens: https://github.com/elopio/core/blob/snapcraft/snapcraft.yaml14:39
dholbachsergiusens, if I checked correctly your 8:00 should be 19:00 in Taipeh - that might be a compromise?14:40
mvozyga: I was mostly wondering if any name needs quoting, but if its only [a-zA-Z0-9] this is a non-issue of course14:40
sergiusensdholbach, that's fne14:40
elopioballoons: I've sent a google task. Can you please check if it's ok?14:49
balloonssure thing elopio14:49
balloonselopio, looks good, but you'll need to add some links in the description to where snappy lives, the code to check out, etc14:50
balloonsif you write a little blurb, you can probably include it in all the tasks you write14:51
elopioah, right. I hate this description box.14:51
balloonselopio, yea, me too. very much. It's intended you use there API to bulk create tasks, but I've not trid it14:51
jdstrandmvo: hey, when is the next stable supposed to be generated? it looks like it is behind on a security update for the kernel14:51
elopioballoons: done.14:52
elopioballoons: is the time to complete in full days? like 8 hours per day?14:52
balloonselopio, the tasks are intended to be 3-5 hours each14:52
balloonsthe time is how many days they have to do it. It's intended to release if someone says, 'i'll work on it', but then neve rdoes14:53
balloonsso the task frees for someone else14:53
balloonsyou can probably just leave them all on the default14:53
elopioballoons: So I might have to split this, one test per task. But it's going to be hard to organize that, because all the tests will depend on the first.14:53
balloonselopio, you could split it into two. Do the first task (that has a dependency on the rest) as one task14:54
balloonsthen do one more task with several instances (so you don't have to create it multiple times). Each person can take a test you've listed14:55
balloonswe can hold back the second task until the first is done14:55
pedronismvo: Chipaca: thanks for the reviews of the helper branches14:55
elopioballoons: I've just increased the instance count to 7. After some thinking, it seems the merge it's not going to be so hard.14:58
zygaChipaca: I've finished the refactoring, I'll give it some tests and poke you for some reviews if you have the time14:59
zygamvo: can I merge https://github.com/ubuntu-core/snappy/pull/21115:08
mvozyga: merged, yes15:11
zygamvo: thanks15:13
=== barry` is now known as barry_
sergiusensattendee.Join() for attendee in [elopio, kyrofa]15:31
elopioballoons: I'm done with the tasks. That's all I can think of for now.15:32
balloonselopio, thank you very much for adding the tasks! I appreciate you volunteering and doing the rough bit of adding things to the tool15:32
Chipacazyga: pedronis: back from the school run, holler if there's anything i should look at first15:42
zygaChipaca: ack15:49
elopiofgimenez: I'm done with today's snapcraft meeting. Do you want to hang out? (I have nothing to report about snappy, just playing with snapcrafting hard things)15:50
fgimenezelopio, we can meet tomorrow then, i've been fixing some of the issues in the scalingstack instances, hopefully we'll have a green (and ultrafast) build when the last firewall rule will be added15:52
elopiofgimenez: I saw your RTs. Thanks!15:52
fgimenezelopio, np :) i'll continue with the cli purge and the update-rollback stress tests15:54
* zyga has a simple working capability demo!15:55
Chipacapedronis: origin, err = demoCheckSnapAssertions(snap)15:57
Chipacapedronis: <315:57
pedronisheh15:57
pedronisor insanity, but yes15:57
Chipacaalthough i suspect this'll make the automagic sideload version thing not pop up, which'll be a problem for some folks15:58
Chipacabut still15:58
sergiusenselopio, kyrofa I've """fixed""" the tests15:59
pedronisChipaca: well this is not planned to go to master indeed because I  don't think we have decide what we want/what should be the rules15:59
pedronisand because is hooked at the wrong place etc etc16:00
Chipacapedronis: yep yep, but i', still happy about it already doing things that were umpossible before :-)16:03
pedronisChipaca: yes, it's quite powerful, can express various things once the pieces are in place16:05
ogra_pitti, did the handling of "allow-hotpulg" in /e/n/i change with the latest systemd ? we see some werid behavior where the interface comes up unconfigured recently16:26
pittiogra_: no, shouldn't have; we also didn't get a newer ifupdown16:26
ogra_if i add "auto eth0" additionally it seems to come up fine16:26
ogra_yeah16:26
pittiifupdown has changed a bit in Debian, but we haven't merged that yet16:26
pittiogra_: but NB that we never supported "allow-hotplug" in ubuntu16:27
ogra_we have used it successfully since 15.04 i think16:27
ogra_it started misbehaving today on the RPi ... which had no image builds for a week (so your systemd upload only landed today in images) ...16:28
pitti(in meeting, will check more closely in a bit)16:29
ogra_thx16:30
ogra_pitti, we couldnt use "auto" because then the system would wait for network when the NIC isnt plugged in on boot ... "allow-hotplug" worked just fine in the past16:31
pittiogra_: right, with plain devices it ought to work16:32
pittiogra_: our ifenslave, bridge-utils etc. packages don't work with it though, but I guess that doesn't concern you much16:32
ogra_(note that we still have predictable names disabled ...)16:32
ogra_i dont think we have either installed16:33
pittiogra_: so the last change to ifup@.service happened before October, so I doubt that's it; is that reproducible? can you specify "weird behaviour"?16:52
ogra_pitti, well, no IP :)16:52
pittiogra_: do you have a journal output?16:52
ogra_i just collected http://paste.ubuntu.com/13647681/ for Chipaca16:53
Chipacathere's no ifup in that log16:53
ogra_yeah16:53
pittiso I see "eth0: link becomes ready", but nothing further16:53
ogra_right16:53
pittiand that happend after networking.service (as that's only looking at "auto", so ok)16:54
ogra_the system was installed about a month ago and worked til yesterday16:54
ogra_(and is set to auto upgrading)16:54
pittiyou checked /e/n/i already, I suppose16:55
ogra_yes16:55
ogra_(RaspberryPi2)ubuntu@localhost:~$ cat /etc/network/interfaces.d/eth016:55
ogra_allow-hotplug eth016:55
ogra_iface eth0 inet dhcp16:55
ogra_(RaspberryPi2)ubuntu@localhost:~$16:55
ogra_thats our default16:55
Chipacaand it works some of the time :)16:56
ogra_so somehow we do not get a plug event anymore ... one that we did get before16:56
ogra_yeah16:56
ogra_and rickspencer3 sees it too ...16:56
Chipacaogra_: could we see the journalctl of one time it *does* work?16:56
ogra_i can try a few reboots and hope :)16:56
pittiyou can also add a "set -x; exec 2>>/run/networking.trace" to /lib/udev/net.agent16:57
ogra_yeah, in 10min once my boot finished :P16:57
pittiit indeed smells like there's no uevent when the device gets added16:57
ogra_right16:58
ogra_thats my suspicion16:58
ogra_but the kernel didnt change16:58
pittiogra_: yeah, I can't really imagine that either16:59
pittiogra_: it's actually more likely that there's some race condition in /lib/udev/net.agent17:00
ogra_yep17:00
pittiperhaps /etc/network/interfaces gets mounted too late17:00
ogra_it gets mounted from  initrd17:00
ogra_we moved all /etc mounts there17:00
pittithat's the bit that has broken stuff dozens of times already17:00
pittiah17:00
pittivery good, thanks17:00
=== LarreaMikel1 is now known as LarreaMikel
ogra_ok, i managed a boot with IP17:01
ogra_http://paste.ubuntu.com/13647897/17:01
ogra_Chipaca, ^^17:01
Chipacaand there's ifup17:01
pittithat could be because at the time /etc/init.d/networking ran eth0 was already there17:02
ogra_yep17:02
pittialthough, no, it shoudl have happened before the "Started" then, as ifup -a should wait for completion17:03
ogra_well, i wonder why it worked ad-hoc after i added your set -x17:03
ogra_i probably changed the race17:04
* ogra_ tries another reboot 17:04
ogra_yeah ... IP again17:05
pittijust leave the set -x :)17:06
ogra_well, your package ... add it please :P17:06
pittiogra_: more seriously, could you just add an echo before/after the ifup call? that sohudl appear in the journal, but be faster than the set -x17:06
ogra_well, i got /run/networking.trace now ... but i cant make it come up without IP anymore ...17:07
ogra_let me try the echos17:07
Chipacasooo17:10
Chipacaudev coldplug17:10
Chipacaruns before mounting of interfaces.d17:10
Chipaca:-(17:10
ogra_ouch17:12
ogra_yeah, the echo doesnt show up anywhere in the journalctl17:12
ogra_so the /lib/udev/net.agent helper isnt run at all17:12
ogra_Chipaca, but why did the order change (if it did)17:14
Chipacait looks like a race17:15
ogra_right, but one we didnt have before17:15
Chipacapitti could advise17:15
* ogra_ would really like to know what triggers it 17:15
Chipacaogra_: it's possible the old file leftover underneath was hiding this issue17:15
ogra_i can try to put it back17:16
ogra_lets see17:16
ogra_hmm ... i have an IP after reboot17:18
* ogra_ tries a few more17:18
ogra_5 out of 5 boots had an IP now17:22
ogra_so i guess thats it17:22
Chipacapitti: so, what can we do?17:24
pittiwhat is "the old file"?17:24
pittiI would say "boot with debug" to see the events that are going on, but that changes the timing even more dramatically17:25
ogra_OH !!!17:25
Chipacaogra_: ?17:25
pittiso perhaps another echo to /lib/udev/net.agent at the top, to see if it's called at all?17:25
pittiperhaps some check in the middle fails, like the ifquery17:25
pittiOH! sounds good17:25
ogra_heh17:26
Chipacaunless it's followed by a ₂17:26
ogra_soo ...17:26
ogra_the handling of /etc in the initrd obviously only landed in 15.04 ...17:26
pittiChipaca: no, OHOO isn't a thing; CH₂COOH is, though17:27
Chipacapitti: OH₂ is a thing tho17:27
pittitrue that17:27
Chipacagranted CH₂COOH sound smore fun17:27
ogra_thats missing in the initrd mount script in rolling http://paste.ubuntu.com/13648333/17:28
Chipacathere you go :-D17:29
Chipacawhich reminds me, we should tell systemd to not mount all that stuff all over again17:29
pittioh, do you mount it in initrd *and* in fstab?17:30
pittibut if it's already mounted, it shoudl be fine I guess17:30
Chipacapitti: it seems we aren't yet doing it like that in rolling, but we should, because of these races i guess17:30
ogra_fix uploaded17:32
ogra_pitti, it just adds a lot of moise to the boot17:32
ogra_*noise17:32
pittiah, about "already mounted wahwahwah"?17:33
Chipacanoise][: ogra_ says you slow him down17:33
ogra_4-5lines about "hey i tried to mount that ... y'know, it iis mounted already ... so i'll probably not mount it"17:33
* Chipaca tries to start a fight17:33
* pitti gets out the popcorn and the CH₂COOH17:33
ogra_pitti, yeah17:33
ogra_Chipaca, i didnt say slow-down ... just that noise][ is chatty :)17:34
* Chipaca wonders why pitti has acrylic acid with his popcorn17:35
* Chipaca blames systemd17:35
pittioh, crap! I guess I should rather get CH₃COOH :)17:35
ogra_rickspencer3, so tomorrows image should be fine again ... til then you can keep the "auto"17:35
rickspencer3ogra_, ack17:35
pittierr no,17:35
pittiCH₃CH₂OH17:36
pittiit's been too long :)17:36
* ogra_ wonders if this channel is now NSA logged ... 17:36
ogra_chemical formulas !17:36
ChipacaI *suspected* that was what you were looking for17:36
pittiChipaca: you wanted to start a fight, now go :)17:36
Chipaca:)17:36
Chipaca:)17:37
=== verterok is now known as verterok-away
=== verterok-away is now known as verterok
sergiusensChipaca, another thing I don't like about irc, writing like a fool without knowing I was offline :-P17:41
sergiusenselopio, updated the review17:41
Chipacasergiusens: granted17:42
Chipacasergiusens: I don't like it when you write like a fool either17:42
* Chipaca runs17:43
sergiusensChipaca, well at least we agree :-)17:43
* sergiusens already ran earlier today17:43
sergiusens:-)17:43
sergiusensChipaca, btw, maybe you want to look at https://github.com/ubuntu-core/snapcraft/pull/145/files ;-)17:45
elopiosergiusens: can you document the execute function? I think that will clear my questions.17:47
sergiusenselopio, sure17:50
sergiusenselopio, it is the former cmds.py `cmd` in some sense17:51
sergiusenselopio, the only problem is, if I document it now, you will say it doesn't do what I say it should ;-)17:51
elopiosergiusens: I would be happy with TODOs :)17:52
elopiosergiusens: the 'stage' argument feels overloaded. Do we have a better name for that? 'step' maybe?17:52
sergiusenselopio, `step` is good, I think it is how we document it17:54
Chipacalongsleep: you around?17:56
sergiusenselopio, is this good enough paste.ubuntu.com/13648814/ ?17:57
elopiosergiusens: yes, thanks!18:03
elopioas it is public, it deserves a docstring. But maybe... not yet?18:03
elopioI'll leave you my +1.18:04
sergiusenselopio, not yet, they will be confusing; they'll be there when I add `strip`18:04
elopiook18:04
sergiusenselopio, there; there's a TODO for the docstring too18:07
* elopio <- happy18:07
sergiusenselopio, kyrofa https://github.com/ubuntu-core/snapcraft/pull/14818:12
sergiusenselopio, I have no idea how the code coverage dropped; well I do, I removed test code that probably made the percentage go up18:27
nessitaelopio, hi! perhaps you can help me. I would like to create a snap package, the dummiest but valid possible snap package18:29
nessitaelopio, any advice on how to do that?18:30
pedronisnessita: looking for something in particular? you can start from hello-world and strip even the few bits it has out18:40
nessitapedronis, nothing in particular, I just need to populate my account18:45
nessitapedronis, have a link handy for hello-world?18:45
pedronisnessita: it originally lived here lp:~snappy-dev/snappy-hub/snappy-examples/   and now that stuff is at https://github.com/ubuntu-core/snappy-testdata (don't thinkt here are meaningful differences for hello-world  atm)18:48
nessitapedronis, thank you!18:48
elopionessita: pedronis: even dummier than that: https://github.com/ubuntu-core/snappy/tree/master/integration-tests/data/snaps18:53
elopionessita: and you can strip them even more removing the binaries from basic-binaries. Then it would be nothing useful, just metadata. I think nothing complaints about that.18:55
nessitaelopio, amazing, thanks!18:58
elopioah, yes, there is one there already, called basic.18:59
elopiosoon we will be able to even remove the icon from there.18:59
ogra_just wait until we can even remove the code (and it still does what it is supposed to)19:00
nessitaogra_, looking forward to that!19:00
ogra_:)19:00
sergiusenselopio, more of the same https://github.com/ubuntu-core/snapcraft/pull/14919:32
kyrofaelopio, I'm noticing something weird, wondering if you can verify and perhaps explain20:40
kyrofaelopio, as soon as ubuntu-core-launcher launches something (e.g. a snapcraft .wrapper sript), $TMPDIR seems to be reset to /tmp instead of the /tmp/snaps/blah path20:42
sergiusenskyrofa, that is just a new namespace being setup20:42
ogra_kyrofa, that only looks like :)20:42
ogra_it is confusing at first :)20:42
sergiusenskyrofa, from the apps point of view it is tmp, if you look at it from the outside, it will be /tmp/snaps/blah20:42
kyrofaGahh20:43
ogra_touch a file in /tmp and you will see20:43
* kyrofa 's head explodes20:43
sergiusenskyrofa, ns does that sometimes :-)20:43
kyrofaThanks guys :)20:44
kyrofasergiusens, so for file access, once u-c-l has launched it, file access needs to be relative to $SNAP_APP_PATH? i.e. does this explain why this script which is trying to open $SNAP_APP_PATH/blah actually fails?20:49
kyrofaIt should be trying to just open /blah ?20:49
sergiusenskyrofa, no20:49
ogra_kyrofa, writes should go to SNAP_APP_DATA_PATH20:49
sergiusenskyrofa, $SNAP_APP_PATH/blah opening that should work20:49
sergiusensas long as the envvar is correct ;-)20:50
ogra_yeah20:50
kyrofasergiusens, hmm, okay something else is going on here then. I'll keep digging20:50
sergiusenskyrofa, snappy install hello-world and run `hello-world.env`20:50
sergiusenskyrofa, you do that while I add recursion to the lifecycle to properly handle 'after' requests :-)20:50
kyrofasergiusens, ooo recursion. Does that mean if I have enough 'after's I can blow the stack?20:52
sergiusenskyrofa, no, it means that 'after' is just broken; or only solves the case for the 'all' case ;-)20:52
kyrofa:P20:52
kyrofasergiusens, I found my issue. The shebang in a python script was pointing to the snapcraft install directory and not the installed snappy location. #!/usr/bin/env python seems to work as expected, but is that okay in a .snap?21:17
ogra_as long as your interpreter is in $PATH ... and as long as it is called "python" and not something like "python3"21:21
ogra_the wrapper usually puts SNAP_APP_PATH/bin and sbin in PATH21:21
sergiusenskyrofa, totatlly21:21
kyrofaogra_, yup, okay good, moving on21:22
kyrofasergiusens, I'm trying to use self.run to run sed... and having all kinds of issues22:08
sergiusenskyrofa, use subprocess.check_call22:09
sergiusenskyrofa, if you need to run a system command22:09
sergiusenskyrofa, path and libraries will be all reffing whatever is in your install and stage dir if not22:10
kyrofasergiusens, ah interesting, okay22:10
sergiusenskyrofa, may I recommend a python regex ;-)22:10
kyrofasergiusens, I was thinking about that too22:10
sergiusenskyrofa, if having issues, Chipaca always has the magic one liners ;-)22:10
kyrofasergiusens, heh, good to know!22:10
sergiusenskyrofa, elopio btw, any opinion on this? https://github.com/sergiusens/snapcraft/commit/f4c5430b17bc7860b0c976d6cbfbea2860db52df#diff-d5a0fb27fd41b8c98e53ca2b53bdb901R4222:11
Chipacahow can i help?22:11
sergiusensit's not a PR yet, but I just finished battling the python  type system22:11
sergiusensChipaca, oh, eventually, some regexes with python (to not call sed)22:12
sergiusensChipaca, well, if you have time, want to see if that `execute` function makes sense to you https://github.com/sergiusens/snapcraft/commit/f4c5430b17bc7860b0c976d6cbfbea2860db52df#diff-d5a0fb27fd41b8c98e53ca2b53bdb901R42 ?22:13
Chipacasergiusens: makes sense22:28
Chipacaby which i mean, nothing obviously wrong22:28
sergiusensChipaca, thanks23:46
sergiusenselopio, I think getattr is more expensive than if/elif23:48
* sergiusens checks23:48

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!