=== chihchun_afk is now known as chihchun === chihchun is now known as chihchun_afk === chihchun_afk is now known as chihchun === chihchun is now known as chihchun_afk === chihchun_afk is now known as chihchun === chihchun is now known as chihchun_afk [08:19] good morning [08:19] asac: you mentioned that the webdm store is empty. with what version of snappy do you see this? 15.04? or rolling? [08:20] hey dholbach, good morning [08:20] hey mvo [08:20] asac: I have a rebuild of webdm ready now but want to reproduce the issue first before blindly uploading === chihchun_afk is now known as chihchun === chihchun is now known as chihchun_afk === chihchun_afk is now known as chihchun [09:45] fgimenez: hi, I uploaded a fix for the /tmp issue from yesterday, buildig a new image now [09:45] fgimenez: to verify the fix [09:50] good morning! [09:51] mvo, ok thanks a lot! let me know when i can give a try [09:51] hey zyga :) [09:51] * zyga prefers to stick to irc === chihchun is now known as chihchun_afk === chihchun_afk is now known as chihchun [10:10] Chipaca: can we please land http://github.com/ubuntu-core/snappy/pull/212 [10:10] Chipaca: I think everything is addressed now === chihchun is now known as chihchun_afk [10:32] zyga: I followed up with a question, I'm sorry if the question is dumb [10:34] mvo: no questions are, thanks, I've replied [10:40] zyga: something something inquisitive idiots? [10:40] Chipaca: hehe :) [10:41] Chipaca: do you know that mvo helped me out in my first days of ubuntu? [10:41] Chipaca: mvo is awesome! [10:41] zyga: i'd be more surprised if he hadn't, because yes [10:41] also, a joy to work with [10:42] even when he asks dumb questions :-p [10:44] zyga: landed [10:45] * mvo blushes [10:55] mvo, test suite passing locally with 272 \o/ [11:01] zyga: do you have a link to that reflects-using monstrosity again? [11:02] zyga: outside of a hangout i'd like to look at it to show you a more gothic way of doing it, even if you won't use that code because of the simplification [11:05] zyga: got it [11:10] Chipaca: sure [11:10] Chipaca: oh, sorry, I was slow [11:10] Chipaca: I went to remove some code from https://github.com/ubuntu-core/snappy/pull/205 [11:10] Chipaca: I think that fixes all of the comments now [11:11] zyga: so, in this case https://github.com/zyga/snappy/blob/caps-api-assign/daemon/api.go#L1016 [11:12] zyga: because you're racing to have a vertical working, it's fine to use reflect.DeepEqual to save time [11:12] zyga: but the "right" way would be to implement an Equals or whatever yourself [11:12] Chipaca: on Assignment struct? [11:12] Chipaca: will that make comparison on two slices work? [11:12] Chipaca: (not that this code is staying but I'm curious how to do it in go in general) [11:13] either on Assignment or on Caps, depending on the usage [11:13] Chipaca: I mean I only used deep equals because AFAIR go's doesn't compare slices [11:13] zyga: e.g., newCap.Assignments.Equals(oldCap.Assignments) [11:14] zyga: fwiw, in the general case, DeepEquals will not do what you want [11:14] zyga: it only works there because you're only letting Assignments have 0 or 1 elements [11:14] Chipaca: oh? [11:14] zyga: but given that it's more like a set, order shouldn't be important [11:14] Chipaca: can you explain why it would not work? [11:14] zyga: (unless i'm misunderstanding) [11:14] Chipaca: ah,I see [11:14] Chipaca: yes, I really miss basic collections here [11:14] so [ass1, ass2] should be equal to [ass2, ass1] [11:15] Chipaca: yep, you are correect [11:15] Chipaca: this is a Set[Assignment] in python's 3.5 parlance [11:15] zyga: even more reason to punt that work to after the demo [11:17] zyga: is an assignment ever going to be more than a snap name and a slot name? [11:18] Chipaca: I don't believe so [11:18] Chipaca: it's sufficient for anything I was imagining much further down the linre [11:19] mvo, Chipaca: it would really help me if you could re-check and land https://github.com/ubuntu-core/snappy/pull/205 that I didn't miss anything [11:19] zyga: Assignments is a set, not a multiset? [11:25] er [11:25] this blocks https://github.com/ubuntu-core/snappy/pull/206 [11:25] zyga: i mean, if Assignment A == Assignment B only if A's snap and slot == B's snap and slot [11:25] zyga: then, if A == B, A and B can't both be in Assignments? [11:25] Chipaca: it is a set, not a multi-set [11:25] Chipaca: Set[Tuple[str, sr]] in python's typing [11:25] Chipaca: you are exactly right [11:29] zyga: https://play.golang.org/p/YZm8ETL5gS [11:31] zyga: actually, ignore that for a bit [11:31] * Chipaca adds stuff [11:35] zyga: https://play.golang.org/p/en_H4bVD7x [11:40] Chipaca: looking [11:41] Chipaca: why a map? [11:41] Chipaca: and can a map use Assignment keys? I assume go somehow makes that struct comparable beause it has trivial fields [11:41] zyga: because a set is a map without values [11:42] Chipaca: ah, right, that makes sesnse [11:42] Chipaca: thanks! [11:43] Chipaca: I'm looking at https://github.com/ubuntu-core/snappy/pull/208#discussion_r46454533 [11:43] Chipaca: it seems the gustavo wants .err() on the deaemon.response (or was it resp) type [11:43] zyga: https://golang.org/ref/spec#Comparison_operators [11:43] Chipaca: not sure though [11:44] zyga: best to ask gustavo what gustavo wants :) [11:44] zyga: “Struct values are comparable if all their fields are comparable. Two struct values are equal if their corresponding non-blank fields are equal.” [11:44] Chipaca: right, I remember reading that a few weeks ago, I was just double checking [11:45] zyga: meaning that as long as the structs contain things that compare by value, it'll work as expected [11:45] meaning: no pointers, no slices [11:45] Chipaca: how would you feel if I added daemon.resp.err() method [11:45] zyga: puzzled [11:45] Chipaca: that conjures an error if the stuff is right [11:46] zyga: puzzled because client doesn't use daemon, and shouldn't [11:46] Chipaca: but gustavo pointed out a test case for api.go [11:47] Chipaca: so this is pure server side stuff [11:48] hrmm [11:49] i guess i'm going to go *read* [11:49] you meanie [11:49] Chipaca: well, I can go ahead and just do it [11:49] Chipaca: but it feels somewhat weird since it's just for testing [11:49] Chipaca: and this structure never becomes an error otherwise, as far as I can see [11:49] zyga: there was a different comment from gustavo about err(), but i can't see it now [11:49] where was taht? [11:49] that* [11:50] Chipaca: it was about client side stuff and it's done now [11:50] Chipaca: it was about processErrorResponse() [11:50] right, i think that might be where my confusion comes from (and i suspect, his too) [11:50] Chipaca: there are similar comments involving .err() in several branches AFAIR === LarreaMikel1 is now known as LarreaMikel [11:53] * zyga wonders what to do about pending requests as stuff is blocked [11:53] Chipaca: I'll work on assign changes we've discussed [11:53] Chipaca: even if it doesn't land before end of week, I'd like to have something that works to show [12:01] zyga: there ya go [12:02] zyga: i think that one's ready to land with this, yes? [12:06] Chipaca: https://github.com/ubuntu-core/snappy/pull/208 ? I'd like to improve the test for client.AddCapability() to observe the POST being made [12:06] Chipaca: I'm just reading how to mock that with SetDoer [12:07] mvo: 15.04 [12:07] mvo: if you have a snap i can test it [12:07] asac: what version of webdm is installed for you? [12:08] zyga: so you want an integration-ish test [12:08] mvo: http://104.196.33.52:4200/ [12:08] lol [12:08] yay security ! [12:08] ogra_: ? [12:08] * ogra_ goes and installs transmission in asac'S machine [12:08] thats great [12:08] do it :) [12:09] * ogra_ does [12:09] *gasp* [12:09] * Chipaca installs windows 10 on ogra's machine [12:09] tell me if you can do anything with it [12:09] http://104.196.33.52:9091/ seems blocked by your firewall [12:09] see :P [12:09] asac: i uninstalled http.chipaca [12:10] asac: you can't trust that chipaca person [12:10] asac: please run "sudo snappy install webdm/edge" and see if that installs version 0.11 [12:10] * ogra_ removes transmission again ... useless :P [12:10] seems hackers have some sense of clean room :) [12:10] do we have a bu for the "ubuntu-core is -1B big" [12:10] ? [12:11] *bug [12:11] mvo: sudo snappy install webdm/edge [12:11] Installing webdm/edge [12:11] webdm/edge failed to install: a package by that name is already installed [12:11] asac: hm, sudo snappy update webdm/edge maybe ? if not you need to uninstall first and then reinstall webdm/edge [12:12] (sorry for that) [12:12] hah! [12:12] the url for channels in webdm needs to be *triple* escaped [12:12] e.g. http://104.196.33.52:4200/snap/http.chipaca%25252fstable/ [12:12] third time is the charm :) [12:13] "Mode.fetch() failed" [12:13] heh, and reloading it works :P [12:13] mvo: update did nothing [12:14] asac: ok, please remove install again [12:14] doing [12:14] looks good [12:14] see yourself [12:15] nethack installed ! [12:15] just saw that :) [12:15] asac: yay [12:15] zyga: sorry, getting back to you now [12:15] asac: ok, if you don't find anything bad I will promote to stable after lunch [12:15] mvo: so chnnels are now happy? [12:15] * Chipaca was having too much fun breaking asac's stuff [12:16] zyga: that test is supposed to check that the client made the right request, correct? [12:16] Chipaca: yes [12:16] zyga: in which case, grab cs.req and check it [12:16] Chipaca: I just figured that out [12:16] Chipaca: :D [12:16] Chipaca: it's a bit convoluted at first when you're not familiar [12:16] Chipaca: personally I would unabbreviate some of the variables [12:16] asac: yes, it seems to be. if you don't see anything breaking I will promote to stable [12:16] Chipaca: rsp,req,resp all look too similar [12:16] but they line up so nicely when everything uses just three letters :-p [12:16] nethack! [12:17] * asac installs lxd curl and mosquitto [12:17] you have been eaten by a grue ! [12:17] hmm. lxd failed to install it tells me [12:17] Chipaca: I think it's because it's not my first language [12:18] asac, it does that for docker too but in fact the install works [12:18] asac, check on cmdline [12:18] ok seems it doesnt really like concurrent installs :) [12:18] i think the timeout is to sowrt or some such, bot do some setup [12:18] lxd really failed [12:18] but i think i just clicked too fast [12:19] now it workd [12:19] zyga: i'm bad with names, everybody knows that [12:19] * ogra_ installs moon-buggy too ... now you have a true snappy gamer system ! [12:19] haha [12:19] moon buggy is buggy :P [12:19] nice game [12:19] moon-buggy.moon-buggy [12:19] mkdir: cannot create directory ‘/home/ubuntu/apps/moon-buggy.dholbach’: Permission denied [12:19] is it ? [12:20] wow [12:20] that feels like a bug [12:20] in snappy [12:20] yeah, it should use the version there [12:20] the version? [12:20] i have http.chipaca in that dir [12:20] that has a version indeed [12:20] /home/ubuntu/apps/moon-buggy.dholbach/$version/ [12:21] maybe [12:21] who is creating that directory? [12:21] snappy? [12:21] the launcher i think [12:21] um [12:21] that'll happen [12:21] if you run the app once as root, and then as the user [12:21] i didnt run it as root [12:21] hmm [12:21] Chipaca: /me wonders how to get the request body out of the "mock" doer code [12:21] ah, cannot create, not cannot read [12:22] yes [12:22] zyga: req.Body [12:22] we shouldnt have reomved http.chipaca i am sure [12:22] zyga: cs.req.Body [12:22] asac: I did that one [12:22] ahhh [12:22] * zyga is dumb [12:22] asac: i mean, i removed that [12:22] Chipaca: my code did cs.req.Body [12:22] note the req :/ [12:22] wait [12:22] no [12:22] what's wrong? [12:22] * zyga looks [12:23] zyga: no, not dumb. inquisitive :-p [12:23] zyga: um, that looks right [12:23] mosquitto seems to not register binaries [12:23] do you want the response body, or the request body [12:23] e.g. there is nothing in PATH with mosq* [12:23] should there ? [12:23] (does it actually ship any binaries) [12:23] Chipaca: it doesn't work, see: [12:23] curl works [12:23] c.Check(cs.req.Body, check.Equals, "foo") [12:23] ... obtained ioutil.nopCloser = ioutil.nopCloser{Reader:(*bytes.Reader)(0xc820013650)} [12:23] ... expected string = "foo" [12:23] ogra_: well, i think it does [12:24] /apps/mosquitto.kartben/current/magic-bin/ [12:24] arm-linux-gnueabihf mosquitto x86_64-linux-gnu [12:24] i thought it has a web UI [12:24] nah its a mqtt CLI thingy [12:24] ah, k [12:24] at least i think [12:24] the package is from may [12:24] maybe i am wrong [12:24] syre [12:24] yes [12:24] might need an update [12:24] do we break old packages? [12:25] well, the yaml formats all changed a lot in the last months [12:25] so you are right [12:25] there is a daemon running [12:25] ok seems its really the broker [12:25] not the cli [12:25] zyga: cs.req.Body is a ReadCloser [12:25] zyga: you need to read it [12:26] ah, right [12:26] so false-warning\ [12:26] Chipaca: thanks [12:29] ok i opened port mosquitto-1883 so you can now use that as your mqtt message broker [12:30] asac, open 80 too ;) [12:30] whats on 80? [12:30] upnp-server [12:30] * ogra_ wants to see if webdav works via internet [12:30] ogra_: will this allow you to hack that tghing? [12:31] lighthttp is running on it [12:31] nah, it will only allow my nautilus to connect to dav://104.196.33.52/ [12:31] okk 80 should be open soon [12:32] hmm [12:32] ha ! works :) [12:33] if you open vlc (or any other upnp/dlna capable player in your lan) you should see a snappy upnp server now [12:33] with one song [12:33] ogra_: this is not running in my lan [12:34] ah [12:34] well dav://104.196.33.52/ works at least :) [12:34] yeah [12:34] dont share illegal files there please :{ [12:34] heh [12:34] * ogra_ removes the file [12:34] wait [12:34] let me get it first : [12:35] lol [12:35] oh, bug ! [12:35] i cant delete it [12:35] lol [12:35] its a honeypot [12:35] i called the police now [12:35] with clear evidence [12:35] haha [12:35] where do i find that stuff? [12:36] ok found it [12:36] /var/lib/apps/upnp-server-armhf.ogra/0.1.0/Media/ [12:36] thats legal isnt it? [12:36] its gone :P [12:36] well, i paid for the mp3 ... spreding it isnt legal i think [12:36] *spreading [12:36] u can also pay for gpl software [12:37] christams is coming soon ! [12:37] :) [12:40] odd i can publish to that mosquitto thing [12:40] but if i sub i dont see the message [12:44] * zyga fixed tests with Chipaca's advice! [12:45] Chipaca: https://github.com/ubuntu-core/snappy/commit/fe8ddc2c933db716ab9890f8c35b5315451786f6 [12:45] hmm [12:45] Chipaca: that's the new test, if you agree it's sufficient then let's land it [12:45] dude [12:45] duuuude [12:46] why does snappy list on the RPi show generic-i386 and generic-amd64 ? [12:46] webdm hides them i thnk [12:46] zyga: if you were going to unmarshal it, just pass json.NewDecoder(req.Body) ftw [12:47] snappy just spits out everything the store tells it [12:47] webdm is more cautious [12:47] maybe :-p [12:48] i thought webdm just uses snappy as backend ... [12:48] but apparently it adds extra filtering [12:48] Chipaca: oh, nice, I can tweak that [12:48] ogra_: it's also possible that one of the two is using the wrong store headers [12:49] yeah [12:49] ogra_: webdm is linked against a version of snappy that might not be the system snappy [12:49] yup [12:49] ogra_: (this is one of the things the rest api is trying to fix) [12:49] * Chipaca expects to get there before EOY [12:49] +1 [12:52] Chipaca: simplified https://github.com/ubuntu-core/snappy/commit/db9343ccda229cc40a0c676a3b10469bab2a2541 [12:55] zyga: \o/ [12:55] zyga: except for the bit about all tests failing [12:56] oh [12:56] yes, bits landed in the meantime [12:56] no worries, just merge [12:59] zyga: meaning i should just merge, or meaning it's just a merge that you're doing? [12:59] fixed [12:59] Chipaca: no, merge removed the carpet from under this branch's feet [12:59] Chipaca: I just pushed the fix for that, two trivial patches [12:59] k [13:00] Chipaca: https://github.com/zyga/snappy/commit/10fcafb771c5002bc9831714de0b6573fc4c45f1 and https://github.com/zyga/snappy/commit/3e458f3208f565ad327a1285912930d07326412c [13:11] kyrofa, are you up? I have some PRs and thought of bugging you instead of Chipaca ;-) [13:11] sergiusens, yeah man, hit me [13:11] sergiusens, snapcraft? Heading there now [13:13] kyrofa, yeah, one already reviewed by elopio but I left it there so you can go over it too; as soon as that is done, there are 3 more down the pipe [13:14] kyrofa, I would create them already but the PR doesn't update with the commit id's that have been merged :-/ [13:15] sergiusens, looking at it now [13:15] sergiusens: kyrofa: I have one too: https://github.com/ubuntu-core/snapcraft/pull/137 [13:15] sergiusens: this is the one you deleted before. Maybe it's still there because you hate it and want it to die. [13:17] Wait a minute... elopio why are you up? [13:18] I don't know. I can't sleep anymore. [13:21] Poor guy [13:37] asac: I updated webdm in the stable channel now to 0.11 too [13:38] zyga: you're going to push a merge to caps-api-remove-capability ? [13:41] sergiusens, now that we have two release branches, what is the process for getting a fix into both of them? [13:42] sergiusens, we might want to consider a CONTRIBUTING.md so github will provide guidance before anyone creates a PR [13:43] For instance, dholbach's PR would probably be useful to both branches, no? [13:44] mvo: great! === Ursinha_ is now known as Ursinha [13:45] Chipaca: yes [13:45] Chipaca: just fixing tests to mean stuff [13:46] k [13:47] * zyga starts to feel better about how requests work [13:49] elopio kyrofa, thanks [13:49] elopio, kyrofa here's another one https://github.com/ubuntu-core/snapcraft/pull/144 [13:49] Chipaca: https://github.com/ubuntu-core/snappy/pull/211#commits-pushed-5d934ac [13:50] kyrofa, that is a good idea, I saw it would be picked up by github; want to craft one or should I? [13:52] Chipaca: I've added a TODO to document all the new REST calls [13:52] zyga: good :) the one around attributes will change soon, right? [13:53] meaning, dunno if it's worth documenting it until the whole thing is stable [13:53] sergiusens, I'll take a crack at it [13:53] Chipaca: attributes or assignments? [13:53] assignments, sorry [13:53] Chipaca: yes [13:53] Chipaca: very much so :) [13:53] and error handling overall [13:54] so don't worry *too* much about it :) [13:54] a little worry: ok. a lottle worry: very no [13:54] :) [13:54] sergiusens, but we still need to decide how we'll do it. Make a PR to both? Backport as needed from master to 1.x? [13:54] Chipaca: yes, I want to fix all the error handling on both client and daemon side [13:55] kyrofa, I'd say master first, and if it is supposed to go to 1.x make it as cherry pickable as possible (== less commits) [13:56] sergiusens, what if we suggested that PRs be squashed? [13:56] Too much? [13:59] kyrofa, yeah, I'm +1 there [14:00] sergiusens, alright I'll get on that as soon as I finish up this roslaunch thing [14:03] kyrofa, elopio ok, feel free to entertain yourself with this one https://github.com/ubuntu-core/snapcraft/pull/145 ;-) [14:04] hello from germanmy [14:04] *germany [14:05] filmee24: hello. [14:05] where are you from? [14:06] filmee24: costa rica. [14:06] cool. are you an developer? [14:07] elopio: I still have my hat :) [14:07] filmee24: a quality assurance developer. [14:08] davmor2: I have mine too, but I can't wear it when I have long hair, it doesn't fit any more :( [14:08] elopio: Ha I don't have that issue :D [14:08] sergiusens, so 'vendor' for master should go away but for 1.x it can stay? [14:08] davmor2: I know. Lucky you! [14:09] elopio: Yeah well you live in a country where you don't necessarily need a hat to keep warm either so fairs fair ;) [14:10] davmor2: it's not to keep you warn, it's to block the sun. I live in a country with sun, so yes, I win ;) [14:12] dholbach, yeah, for 1.x it needs to stay as 15.04 requires it [14:13] elopio: but if you spray it with gortex it becomes waterproof and is the ideal hat to keep you warm and dry :D [14:13] kyrofa, sorry, I didn't wait for your review :-/ [14:13] kyrofa, it is a good point and I will add that as part of the test [14:13] elopio: although you still win you have sun [14:13] sergiusens, haha, no problem [14:19] sergiusens, done [14:20] Oh, sergiusens elopio I have another meeting clashing with standup today. Any chance we can push it back an hour? [14:24] kyrofa: works for me. It will clash with my meeting with fgimenez, but we can just invite him today. [14:24] Hey sounds good to me [14:24] elopio, kyrofa hmm, I'll see how I can make it then [14:25] sergiusens, if that's difficult, would pushing it back a half an hour be better? [14:26] kyrofa, nah, an hour is easier, it just needs to last 15 minutes tops ;-) [14:26] And worst case I just miss it today if you guys want to just hold it at 0930. I've finished the ROS install bits and am working on upping the catkin plugin test coverage... which isn't so good [14:26] Okay we can do that! [14:32] sergiusens, are you going to be on vacation at 21st Dec already? [14:33] dholbach, oh, I'll be avail on the 21st [14:33] dholbach, forgot to mention; I'll be off all other days though ;-) [14:33] sergiusens, ok, cool - let me do some timezone math [14:33] dholbach, sure, I can wiggle time around and about [14:34] dholbach, just try to not make it 3AM my time :-) but I'm fine with 6AM or 10PM ;-) [14:34] even midnight is fine if must be [14:36] sergiusens: I'm playing with hard stuff now, cloud9 that's nodejs. It ends up with the modules in /apps/cloud9.sideload/current/lib/node_modules/ls [14:36] sorry, hit enter too soon. [14:37] It ends up with modules in /apps/cloud9.sideload/current/lib/node_modules/c9/node_modules, but it's not finding them. [14:37] on require, it says that the module is not found. [14:37] sergiusens: should I move the modules from node_modules/c9/node_modules to node_modules ? [14:38]