| blr | is there a reason that debug-hooks can't wait for a unit's public address to be published? | 00:47 |
|---|---|---|
| === natefinch-afk is now known as natefinch | ||
| jose | lazypower: pong | 02:05 |
| bloodearnest | sanity check: if I have $JUJU_REPOSITORY/interfaces/test/{interface.yaml,provides.py,requires.py}, a charm layer in $JUJU_REPOSITORY/layers/test-charm/ that has includes: ['interface:test'], and has the interface in the metadata.yaml, I should expect to see those provides/requires.py in the charm build output somewhere, right? | 10:06 |
| jamespage | gnuoy, thedac, coreycb: what do you think of https://code.launchpad.net/~james-page/openstack-charm-layer-dev/+git/openstack-charm-layer-dev/+merge/279563 ? | 10:28 |
| jamespage | it introduces 'adapters' and a object mechanism for aggregating them across presented interfaces | 10:28 |
| gnuoy | argh, we're working on the same thing | 10:28 |
| gnuoy | jamespage, I really like it | 10:30 |
| jamespage | gnuoy, some of that needs interfaces/relations | 10:30 |
| jamespage | interfaces is the type, rather than the actual named relation | 10:30 |
| jamespage | gnuoy, I think we can add some base adapter mapping as well, and then override in the subclasses | 10:31 |
| gnuoy | jamespage, so I proposed that the adapter code goes into a layer called openstack which places them in lib/openstack/adapters.py | 10:31 |
| jamespage | gnuoy, that sounds good to me | 10:31 |
| jamespage | gnuoy, sorry if I stepped on your toes... | 10:31 |
| gnuoy | jamespage, not at all, you'd got much further than me | 10:32 |
| jamespage | gnuoy, I prefer this class based approach to dealing with things rather than functions and global variable in a utils class | 10:32 |
| gnuoy | jamespage, I'm happy to grab what you've done and do the layer munging unless you want to do that ? | 10:33 |
| jamespage | gnuoy, please go ahead - we can then collab on getting the layer just right... | 10:33 |
| gnuoy | kk | 10:33 |
| jamespage | gnuoy, there are some bits of that I don't like right now | 10:33 |
| jamespage | (I wrote one TODO) | 10:33 |
| jamespage | gnuoy, I did a template mockup as well - http://paste.ubuntu.com/13665616/ | 10:34 |
| jamespage | untested | 10:35 |
| gnuoy | kk | 10:35 |
| jamespage | gnuoy, I'm wondering whether we can also take an object based approach to the handlers as well... | 10:35 |
| jamespage | gnuoy, just making the adapaters classes behave like jinja2 wants | 10:47 |
| gnuoy | jamespage, lp:~openstack-charmers-layers/charms/+source/reactive-openstack-layer | 10:48 |
| jamespage | gnuoy, OK I'll push my change their | 11:08 |
| jamespage | gnuoy, ok should work with jinja2 now | 11:11 |
| jamespage | gnuoy, I'll refocus onto ceph now and stop stepping on your toes... | 11:12 |
| gnuoy | I'm very grateful for the input, thanks | 11:13 |
| jamespage | gnuoy, my thinking on 'interface_type' was to use that for status reporting | 11:13 |
| jamespage | but not thought through just yet | 11:13 |
| gnuoy | jamespage, thedac, coreycb: I've taken James' work and created a branch containing the fledgling openstack base layer. I've also updated the setup branch to use it. | 12:19 |
| * gnuoy heads out | 12:19 | |
| lazypower | jose: hey there. Was looking for you lastnight to get you in touch with mattyw about ubuntu membership | 13:32 |
| coreycb | jamespage, gnuoy: I like that adapter approach. that was a bit to wrap my head around, but if you look at that code without the base classes in the picture it's really pretty simple to write/use an adapter. | 13:48 |
| lazypower | coreycb: what are these adapters you speak of? | 13:55 |
| coreycb | lazypower, https://code.launchpad.net/~james-page/openstack-charm-layer-dev/+git/openstack-charm-layer-dev/+merge/279563 | 13:56 |
| lazypower | interesting.. you can swap in/out interfaces using an adapter? | 13:57 |
| coreycb | lazypower, basically it's a way for the openstack charms to add some logic around interface data, and render it more easily | 13:57 |
| lazypower | i like it | 13:57 |
| lazypower | it looks clean | 13:57 |
| === rogpeppe2 is now known as rogpeppe | ||
| coreycb | lazypower, yeah and and it keeps any logic out of the interface layer, and lets the interface just return data | 13:58 |
| lazypower | coreycb: thats *exactly* what its supposed to do | 13:58 |
| lazypower | \o/ | 13:58 |
| coreycb | yup | 13:59 |
| jamespage | coreycb, lazypower, thedac, gnuoy: I just pushed a bit of a rename I wnated todo into the openstack base layer | 14:02 |
| jamespage | Interface->Relation | 14:02 |
| jamespage | and I added some support for default adapter mappings into the Adapters base case | 14:09 |
| bloodearnest | is there a way to exclude directorys in a layer when building? | 14:09 |
| jamespage | I was about to ask the same thing | 14:09 |
| jamespage | I'd like to exclude unit tests for a layer for example | 14:10 |
| bloodearnest | same here | 14:10 |
| lazypower | there is a way to declare that i do beleive | 14:18 |
| lazypower | Ah, according to the old repo's layer.yaml it only has strategy keys for deleting yaml key names | 14:19 |
| lazypower | from config/metadata | 14:19 |
| bloodearnest | oh wow - so charms.reactive does not use standard python import mechanisms, it does: | 14:23 |
| bloodearnest | sys.modules[modname] = load_source(modname, realpath) | 14:24 |
| bloodearnest | which means imports inside that source don't seem to work right | 14:24 |
| bloodearnest | e.g. so if my reactive/ dir has 3 files ( foo.py, bar.py, __init__.py), I can not import a from b when running as a hook. I can when running unit tests. | 14:26 |
| bloodearnest | s/a from b/foo from bar | 14:26 |
| bloodearnest | oh my | 14:28 |
| bloodearnest | (Pdb) __name__ | 14:28 |
| bloodearnest | '_var_lib_juju_agents_unit-x509-cert-0_charm_reactive_x509_cert_py' | 14:28 |
| bloodearnest | (Pdb) | 14:28 |
| bloodearnest | that would explain it | 14:28 |
| bloodearnest | so, reactive/ modules can not depend on other local files. | 14:29 |
| bloodearnest | an no, that's just name manling, ignore me | 14:30 |
| bloodearnest | *mangling | 14:30 |
| jamespage | thedac, gnuoy, coreycb: added tox configurations to the layer and the rabbitmq interface - does lint only right now but set to go for unit testing as well | 14:33 |
| jamespage | coreycb, wanna add that to the shared-db interface? | 14:33 |
| coreycb | jamespage, +1 yep I'll do that today | 14:33 |
| TheJeff | hello you brainy charmers you | 16:19 |
| marcoceppi | o/ | 16:20 |
| TheJeff | quick q | 16:20 |
| TheJeff | deploying openstack with juju | 16:20 |
| TheJeff | ext-port in the openstack-config.yaml -- is that the existing connection? | 16:20 |
| TheJeff | or a second one | 16:20 |
| marcoceppi | TheJeff: I think it's existing? jamespage gnuoy beisner coreycb ^? | 16:21 |
| TheJeff | like, the interface that connects to MAAS? I guess not, although that seems to be the only active interface on the juju host its up | 16:21 |
| marcoceppi | TheJeff: I think it's for the external network | 16:21 |
| TheJeff | alright... so eth0 will I suppose always default to the MAAS network | 16:22 |
| TheJeff | then if i specify eth1 it'll bring that up on its own connection? | 16:22 |
| marcoceppi | TheJeff: I'd wait to see what the OpenStack charmers have to say | 16:22 |
| TheJeff | we have vlans for each physical interface. I'm not sure from this config file and the way its going to spin up which one will be whitch | 16:22 |
| TheJeff | which* | 16:23 |
| TheJeff | eh, gonna try eth1 (default) and see what happens. if it breaks I'll do it again I suppose | 16:23 |
| TheJeff | unless the governor phones before I hit enter | 16:23 |
| coreycb | TheJeff, that's a second one | 16:26 |
| coreycb | TheJeff, so I believe you need 2 ports for neutron-gateway | 16:27 |
| TheJeff | ok cool | 16:27 |
| coreycb | one for cloud services, one for external instance traffic | 16:27 |
| TheJeff | cool | 16:27 |
| TheJeff | got it | 16:27 |
| TheJeff | additionally - in the same conf, osd-devices suggests sdb | 16:28 |
| TheJeff | is a second phyiscal block device required? | 16:28 |
| TheJeff | we only have sda | 16:28 |
| coreycb | TheJeff, one should be ok | 16:29 |
| coreycb | TheJeff, well, in total I think you'd need at least 2 | 16:30 |
| coreycb | TheJeff, but a minimum of one to use as a ceph osd volume | 16:31 |
| coreycb | if that makes sense, one for ceph to consume, one for your root partition | 16:32 |
| TheJeff | hm | 16:35 |
| jamespage | TheJeff, its an additional port - eth0 will drop all connections to the server | 16:37 |
| jamespage | TheJeff, you might find https://jujucharms.com/openstack-base/ informative | 16:37 |
| jamespage | coreycb, thedac, gnuoy: idea - use ddt for interface testing | 16:39 |
| jamespage | http://ddt.readthedocs.org/en/latest/example.html | 16:39 |
| jamespage | although that might not do quite what we want | 16:41 |
| coreycb | jamespage, that looks pretty neat | 16:47 |
| jamespage | coreycb, yeah - but I'm not sure it can do anything super complex with regards to data read from file | 16:47 |
| jamespage | coreycb, I was thinking we could spec relations as yaml/json | 16:48 |
| coreycb | jamespage, could be nice for the base openstack layer to work off a yaml of key/value interface data | 16:50 |
| jamespage | ? | 16:50 |
| coreycb | jamespage, I'm thinking more of when an event becomes true, so maybe not for testing the base layer | 16:51 |
| coreycb | jamespage, so for testcharm.py for example you could have a yaml of key/value interface data that you test and verify the adapters work. I think you're talking about testing at the interface level though | 16:53 |
| asanjar | arosales: kwmonroe cory_fu ease and speed of building new hadoop/spark solutions (juju bundles) from existing charms has been impressive and mouth dropping by some . | 16:59 |
| kwmonroe | w00t asanjar! that's good to hear. | 16:59 |
| arosales | asanjar: \o/ | 17:00 |
| jamespage | coreycb, nogood brainfried | 17:00 |
| jamespage | 5pm on a friday is not a good time to think about data driven unit testing.... | 17:01 |
| coreycb | jamespage, mine or yours :) yeah time for a wind down I bet | 17:01 |
| jamespage | cory_fu, hey - was looking at your reactive test helper pull request - we're getting to a point where I don't want to write a whole lot more code in interfaces without some unit testing | 17:01 |
| jamespage | cory_fu, for the openstack charms today, we have a way of plugging in a set of 'relation data' which gets plumbed into the relation_get/units/ids calls - what do you think of a similar approach for testing interfaces? | 17:02 |
| jamespage | thinking that we write json/yaml to represent each interface state; that gets read and plumbed in so we can then poke the interface class and ensure it sets the right state etc... | 17:03 |
| jamespage | hey asanjar | 17:03 |
| asanjar | jamespage: how are you my friend.. | 17:04 |
| jamespage | asanjar, well thanks - how about you? | 17:04 |
| asanjar | jamespage: I am well and as usual still causing trouble for arosales | 17:05 |
| jamespage | I'd expect nothing less | 17:05 |
| asanjar | jamespage: sign of good health | 17:05 |
| jamespage | anyway I'm going to EOW for now - have fun everyone | 17:05 |
| * jamespage goes for a beer | 17:05 | |
| * arosales relishes in the touble asanjar creates | 17:05 | |
| arosales | jamespage: have a good weekend, enjoy the beer | 17:06 |
| asanjar | jamespage: have a pint on me | 17:06 |
| === natefinch is now known as natefinch-afk | ||
| cory_fu | jamespage: Sorry, was on a call | 17:12 |
| cory_fu | jamespage: I'm not sure what PR you're talking about, but we definitely want to have some framework / helpers around testing reactive charms. One aspect to consider is that the relation data will need to evolve over time to model an evolving conversation, so a static set of data won't work. | 17:15 |
| cory_fu | We might also want to consider where we cut the testing of interface layer implementations vs charm layer implementations. As in, maybe in charm layer tests we want to have a system to easily "mock" interface classes based on their API and not the low-level data coming over the relation. But that might be more difficult to manage and might not be worth it | 17:16 |
| cory_fu | (Might even be counter productive, if we want full-stack testing) | 17:16 |
| jcastro | hey jose | 17:21 |
| lazypower | cory_fu: when you release a pypi package, you dont track the .egg-info bits or any of that in the repo do you? | 17:24 |
| lazypower | i was looking at charms.reactive as a reference | 17:25 |
| cory_fu | No, you shouldn't | 17:25 |
| asanjar | kwmonroe: cory_fu: reactive charms ??!!! i smell another rewrite of big data charms.. third time's the charm | 17:36 |
| cory_fu | asanjar: Well, you never liked the services framework, and it turned out that everyone else agreed with you. ;) | 17:36 |
| cory_fu | asanjar: Also, it's called "refactor" not "rewrite" ;) | 17:37 |
| asanjar | cory_fu: lol awesome | 17:38 |
| lazypower | asanjar: how could you have missed all the reactive buzz? :P | 17:40 |
| lazypower | we *Started* that in DC | 17:40 |
| lazypower | well, the public buzz anyway | 17:40 |
| mbruzek | asanjar: Welcome to the community. I reject your immutable attitude | 17:41 |
| asanjar | lazypower: I don't remember what I had for breakfast this morning . | 17:41 |
| lazypower | asanjar: are you coming to the charmer summit in belgium? | 17:41 |
| lazypower | asanjar: we need to go hit up that little hookah bar street side in brussels again. I'm hankering for some mojitos | 17:41 |
| asanjar | mbruzek: how are you my friend, how is your MUCH better half | 17:42 |
| mbruzek | asanjar: she is well. Taking a half day today, to buy YOU a gift. | 17:42 |
| mbruzek | asanjar: I don't think the post office will let us mail poo. | 17:43 |
| asanjar | lazypower: I would love to go to the Charm summit, but seriously doubt IBM would pay. | 17:44 |
| asanjar | mbruzek: mark it as white POO, and not BOOM | 17:45 |
| lazypower | asanjar: i smell diversity class coming on | 17:46 |
| asanjar | lazypower: I have that shit reset | 17:46 |
| mbruzek | asanjar: seriously happy holidays to you and your kids. | 17:46 |
| lazypower | asanjar: family friendly please sir :) | 17:46 |
| asanjar | mbruzek: same to you buddy, have a wonderful xmas | 17:47 |
| mbruzek | asanjar: ... I think their names were Cory and Kevin | 17:47 |
| asanjar | mbruzek: lol lol | 17:47 |
| jrwren | oh man, i forgot about that hookah bar. | 17:47 |
| lazypower | jrwren: good times :) | 17:50 |
| === natefinch-afk is now known as natefinch | ||
| hatch | can you create multiple relationships between two services? What are the rules around this interaction? | 18:11 |
| lazypower | hatch: you sure can | 18:14 |
| lazypower | hatch: that the interfaces match on both ends. thats pretty much it. | 18:14 |
| hatch | lazypower: so can you do two from one service to one endpoint on another? | 18:15 |
| hatch | or do the two relations have to have unique endpoints? | 18:15 |
| lazypower | its really only governed by the relationship name/interface. Say you have a db relation that uses interface: mdb and you have a db-admin relation that uses mdb interface. Both are completely reasonable uses of the same "endpoint", and can consume any provided relation using the mdb interface | 18:16 |
| hatch | ahh ok so an endpoint doesn't become 'locked' once it's active | 18:17 |
| hatch | you can connect to that same endpoint multiple times | 18:17 |
| lazypower | right, as its 2 sep. relation scopes on the requires side keep it as independent relations | 18:17 |
| lazypower | they just share the same communication protocol | 18:17 |
| hatch | great, now however you cannot create two identical realtionships | 18:18 |
| hatch | that would be a noop? | 18:18 |
| lazypower | well, thikn of it like this | 18:18 |
| lazypower | juju add-relation foo:bar bar:foo | 18:18 |
| lazypower | when you type that in a second time | 18:18 |
| lazypower | its going to error saying you've already added that relationship | 18:18 |
| lazypower | or rather, that the relationship already exists | 18:18 |
| hatch | lazypower: thanks for clarifying - I'll file a bug to add this information to the user docsc | 18:19 |
| lazypower | hatch: what you may want to do, is follow up with dimiter, as i know that network spaces were changing some of the rules here about this, as the network spaces bring into it the concept of binding service endpoints to a space, and you may be able to "overload" a relation due to the nature of a scoped network. | 18:19 |
| hatch | ahh | 18:19 |
| lazypower | where having 2 services in sep. network spaces use the same relation/interface across the different scopes | 18:20 |
| lazypower | due to whatever crazy networking you're modelling | 18:20 |
| lazypower | because dimiter loves crazy networking ;) | 18:20 |
| hatch | lol | 18:20 |
| lazypower | and meatloaf | 18:20 |
| admcleod- | is there a constraints-type option for config.yaml | 18:38 |
| lazypower | admcleod- So when you say constraints-type, what do you mean by that? | 18:39 |
| admcleod- | if i config set, it must be one of a defined set | 18:39 |
| lazypower | ah, there is not an ENUM type to speak of that i'm aware of | 18:39 |
| lazypower | We've been working around that with status messaging, and an array of accepted values. | 18:40 |
| lazypower | if its not one of the accepted values, status-set blocked, and message the user that they need to *read* what is acceptable | 18:40 |
| admcleod- | ok thanks | 18:40 |
| lazypower | admcleod- seems like a good idea to go poke this issue - https://bugs.launchpad.net/juju-core/+bug/918386 | 18:41 |
| mup | Bug #918386: config.yaml should have enum type <charmers> <config> <pyjuju:Triaged> <juju-core:Triaged> <https://launchpad.net/bugs/918386> | 18:41 |
| lazypower | hey cory_fu, so, i jsut got my layer setup for wheelhousing deps. | 18:57 |
| lazypower | http://paste.ubuntu.com/13674509/ -- as confirmation | 18:57 |
| lazypower | on charm deploy does it do the due dilligence to setup the proper linking for $PATH and all that schenanigans? | 18:57 |
| cory_fu | Ok, first of all, there is a new release of charm-tools coming that will fix the fact that those are platform specific wheels and will probably fail when you deploy them | 18:58 |
| lazypower | ok, i have something i need ot forward you then - as it appears we may have some overlap | 18:59 |
| lazypower | if you check your mail, there's a stack there about being unable to find charms.reactive that i'm en-route to try and reproduce | 18:59 |
| cory_fu | Second of all, the wheelhouse is now installed into the system and not the charm dir, so the path and imports should Just Work. The base layer still supports lib/charms/* in the charm so that you can include small, charm-specific helpers libs in the charms.X namespace without packaging and pushing to pypi | 18:59 |
| lazypower | is that the error you're referencing? | 18:59 |
| cory_fu | lazypower: Hrm, no. The error I would expect is that the pip install on the wheelhouse would fail because the platforms don't match | 19:01 |
| cory_fu | So it would have failed earlier than that | 19:01 |
| cory_fu | And the error would have specifically mentioned the platform | 19:01 |
| lazypower | hmm | 19:03 |
| lazypower | Ok, back to reproducing then | 19:03 |
| lazypower | thanks for TAL | 19:03 |
| cory_fu | np | 19:05 |
| lazypower | ah yep | 19:06 |
| lazypower | found it | 19:06 |
| lazypower | wheel broke when installing PYYAML | 19:06 |
| lazypower | well cory_fu - on the bright side, osx brew released charm tools is now properly embedding dependencies (it didnt seem to in the 1.8.x releases), however its got the wheel bug as you pointed out :) so its progress in the right direction | 19:19 |
| cory_fu | Again, I believe marcoceppi is currently working on the next release (including OS X brew) that should fix the wheel bug | 19:20 |
| lazypower | Right on | 19:21 |
| lazypower | marcoceppi: confirmation on the above? | 19:21 |
| cory_fu | Well, work around it, since we can't actually use wheels any more. (Which makes the "wheelhouse" a bit of a misnomer.) | 19:21 |
| marcoceppi | lazypower cory_fu otp, but afterwards 1.9.4 is being released | 19:21 |
| lazypower | whee \o/ | 19:21 |
| marcoceppi | lazypower cory_fu https://github.com/juju/charm-tools/milestones | 19:21 |
| cory_fu | Thanks for the hard work, marcoceppi! | 19:22 |
| mbruzek | cory_fu: Does the reactive base work with the leadership hooks at this time? | 19:22 |
| mbruzek | cory_fu: In other words can I use @hook('leadership-settings-changed') to decorate my python function? | 19:23 |
| cory_fu | mbruzek: No, but I believe that can be handled outside of the charm-tools release cycle (unlike actions) | 19:23 |
| lazypower | i believe its missing the storage hooks, and the leadership hooks. https://github.com/juju-solutions/reactive-base-layer/issues/4 | 19:23 |
| cory_fu | lazypower: storage hooks will need a charm-tools update as well | 19:24 |
| cory_fu | Since the hook names are not fixed | 19:24 |
| lazypower | ah, true | 19:24 |
| lazypower | it needs to generate them much like the interface layers are handled right? | 19:24 |
| cory_fu | Yep | 19:24 |
| cory_fu | Same w/ actions, and I'm still a little unsure as to how / whether we should handle actions | 19:25 |
| mbruzek | cory_fu: so your advice for leader-settings-changed is to make an old sytle hook named "leader-settings-changed" in this case? | 19:25 |
| cory_fu | mbruzek: Or create a PR against the base layer. I think that fix at least should be easy | 19:25 |
| cory_fu | I'm happy to review and merge | 19:25 |
| mbruzek | ack | 19:25 |
| bdx | hey what up everyone? | 19:38 |
| bdx | has anyone here ever preformed an instance resize? | 19:38 |
| bdx | :-) :-) :-) | 19:38 |
| lazypower | whattup bdx | 19:38 |
| mbruzek | Hi bdx | 19:38 |
| bdx | hey guys, we need to add the "allow_resize_to_same_host=true” and “allow_migrate_to_same_host=true” to ALL nova confs | 19:39 |
| bdx | otherwise resize functionallity is broken | 19:39 |
| lazypower | bdx: would be good ot get that as a bug against the requisit charms | 19:40 |
| bdx | lazypower, will do. | 19:41 |
| bdx | lazypower, mbruzek: I have a few questions concerning charming with layers.... | 19:42 |
| lazypower | fire when ready | 19:43 |
| bdx | I want to create a puppetserver and puppetagent charm | 19:43 |
| bdx | so | 19:43 |
| mbruzek | cory_fu: https://github.com/juju-solutions/reactive-base-layer/pull/12 | 19:43 |
| bdx | from what I can tell, I would need to create a puppet-agent interface and a puppet-server interface | 19:44 |
| bdx | on top of that, I would need to create 2 layers, puppet-server-layer, and puppet-agent-layer | 19:44 |
| lazypower | bdx: i'm not sure why you would need two interfaces. afaics the puppet agent / server comms would use the same interface. perhaps just interface: puppet - as an interface layer so the agents can self-register. | 19:45 |
| bdx | then, 2 charms, a puppet-server and a puppet-agent, each of which would provide the interface for itself, and require the interface for the other | 19:45 |
| lazypower | the other interface would be consuming the typical HTTP layer as puppet master is a REST API, so expose that if required. | 19:46 |
| lazypower | bdx: i think you've got relation and interface confused :) | 19:46 |
| lazypower | bdx: interfaces are just the communciation happening between the two units. same interface, 2 relations - one for each charm. | 19:46 |
| bdx | entirely | 19:47 |
| lazypower | bdx: are you familiar with statically typed languages implementation of interfaces? | 19:48 |
| bdx | somewhat | 19:48 |
| lazypower | its just a data contract, that say you can be / do whatever you want. But you will implement "these things". | 19:48 |
| bdx | totally | 19:48 |
| bdx | ok | 19:48 |
| lazypower | in charms, its very similar. We're saying this interface will *always* expect these data points, and communicate in ['global'|'service'|'unit'] . | 19:49 |
| bdx | totally, tracking | 19:49 |
| lazypower | which is why the interface programmer typically writes the provides/requires side of the interface, that way consumers just point at it, and the metadata susses out the details. All you need to ensur eyou do is grab the proper side of hte interface, and then handle it in your reactive bits | 19:50 |
| lazypower | bdx: did you watch the UOS session over charming with layers? | 19:50 |
| bdx | yes | 19:50 |
| lazypower | cory did a great job of explaining this in that session. highly suggest you grab a re-watch of that session | 19:50 |
| bdx | I've been reading and watching, and following the interface and layer repos you all have created | 19:51 |
| bdx | so | 19:51 |
| cory_fu | mbruzek: Should we go ahead and add update-status while we're at it? | 19:51 |
| lazypower | cory_fu: you had a pretty legitimate concern there | 19:51 |
| cory_fu | There was some discussion on https://github.com/juju-solutions/reactive-base-layer/issues/4 and I was trying to play the devil's advocate, but I'm generally pro-update-status | 19:52 |
| lazypower | cory_fu: lots of curn on the unit during update-status if the hook is treated as a reactive handler. | 19:52 |
| lazypower | *churn | 19:52 |
| cory_fu | Yeah, maybe. Though there are several reasons why it would be very useful | 19:52 |
| cory_fu | And, it's entirely possible to code around that churn and is really something we should be encouraging anyway | 19:52 |
| lazypower | oh indeed :) I see my name on that issue comment stream for being pro update-status, i just wanted to play the devils advocate once :D | 19:52 |
| cory_fu | ha | 19:53 |
| lazypower | because "reasons" | 19:53 |
| cory_fu | mbruzek: Merged | 19:54 |
| cory_fu | I'm really tempted to Friday afternoon cowboy in the update-status hook. :p | 19:54 |
| marcoceppi | cory_fu: do it | 19:56 |
| marcoceppi | cory_fu: do you ened a charm-tools change for that? | 19:56 |
| * marcoceppi hasn't cut the release yet, it won't go out until late tonightr | 19:56 | |
| cory_fu | marcoceppi: Nope | 19:58 |
| cory_fu | storage support would, though if we want to get that in real quick | 19:58 |
| marcoceppi | cory_fu: I'm down | 19:58 |
| marcoceppi | I can hold release off until weekend too | 19:58 |
| marcoceppi | ligaf | 19:59 |
| jcsackett | hey all; i'm managing 2 servers using manual provider, and on the second machine the agent is always lost when i deploy a service and agent-state ends up failing. functionally i can't deploy anything to it. | 20:06 |
| === JoshStrobl is now known as JoshStrobl|AFK | ||
| lazypower | marcoceppi: i urge you to not hold it as the current revision is utterly broken | 20:12 |
| marcoceppi | lazypower: that's fine. it's going out probably around 5pm EST | 20:12 |
| lazypower | marcoceppi: nothing i build coming from c-t 1.9.3 in brew will work | 20:12 |
| lazypower | i'm testing now w/ the vagrant box to see if thats a valid work around | 20:13 |
| cory_fu | mbruzek, lazypower, marcoceppi: https://github.com/juju-solutions/reactive-base-layer/pull/13 | 20:16 |
| === JoshStrobl|AFK is now known as JoshStrobl | ||
| mbruzek | cory_fu: How does one release a new version of a reactive layer? Do we need to do something on interfaces web site? | 21:20 |
| cory_fu | Nope. Anything merged to master is immediately released | 21:20 |
| mbruzek | cory_fu: OK. I did not touch the update-status hook in my contribution because I saw the issue where you were worried about that one hook. | 21:21 |
| cory_fu | mbruzek: Thanks for the README catch | 21:23 |
| mbruzek | cory_fu: no problem, while in the README I wondered why you used so many backticks | 21:23 |
| cory_fu | mbruzek: Also, it's less that I'm worried about the hook, and more that I'm worried about people writing naive charms that end up churning on the machine | 21:23 |
| cory_fu | mbruzek: Too much reST writing in the pydocs | 21:24 |
| lazypower | cory_fu: whats the version in the interfaces site in reference to then? I thought that had ot be incremented when you update a layer... | 21:26 |
| cory_fu | I think it's intended to auto-update, like the charm revision, but it's not implemented yet | 21:27 |
| lazypower | ah ok | 21:28 |
| cory_fu | Also, I wonder if using semver there might be better | 21:28 |
| lazypower | i <3 semver so i'm an automatic +1 to that | 21:34 |
| lazypower | could use a quick pair of eyes on this to get landed, it works in non x-platform cases, which is good enough for me for now - https://github.com/juju-solutions/layer-docker/pull/20 | 21:34 |
| cory_fu | lazypower: Should the "## States" header actually be "### States"? | 21:37 |
| lazypower | Yeah, good call | 21:37 |
| cory_fu | Otherwise +1 | 21:38 |
| mbruzek | ninjaed | 21:39 |
| lazypower | daww i merged it too fast? | 21:40 |
| lazypower | sorry mbruzek, i'm so used to our workflow :P | 21:41 |
| mbruzek | all good | 21:41 |
| cory_fu | marcoceppi, mbruzek: https://github.com/juju/charm-tools/pull/67 | 22:18 |
| marcoceppi | cory_fu: I'm not sure this works | 22:37 |
| cory_fu | Why do you say that? | 22:38 |
| marcoceppi | cory_fu: commented on mp | 22:39 |
| marcoceppi | I also don't see any tests for this? | 22:40 |
| cory_fu | Gah, yeah, so much for me paying attention to my copypasta | 22:40 |
| marcoceppi | mmm pasta | 22:41 |
| cory_fu | marcoceppi: Updated | 22:49 |
| marcoceppi | cory_fu: I'll land this, but it'll be a 1.10.0 bump | 22:59 |
| cory_fu | That's fine | 22:59 |
| marcoceppi | cory_fu: https://github.com/juju/charm-tools/pull/55 is now conflicting | 23:01 |
| cory_fu | marcoceppi: I'm confused, are you now looking at doing a 1.10.0 release? I'm fine with the storage changes not landing now, but I do need the other, smaller changes (dist.yaml and resources.yaml) | 23:02 |
| marcoceppi | cory_fu: well I just landed the storage stuff, so I figured I'd do a 1.10.0 bump | 23:03 |
| marcoceppi | but maybe that was a bit...zealous | 23:03 |
| cory_fu | Oh, well, if you're ok with doing that at EOD on a Friday | 23:03 |
| marcoceppi | I always am | 23:03 |
| marcoceppi | cory_fu: I was saying, if you wanted to update the py3 changes, I'll land that now as well | 23:03 |
| cory_fu | Ok. You ok with a pull --rebase for that branch, or should I just do a merge? | 23:04 |
| marcoceppi | I was just holding off to group it with a bigger minor feature release | 23:04 |
| cory_fu | (To update it to master) | 23:04 |
| marcoceppi | cory_fu: ti's a feature branch do whatever you'd like :) | 23:04 |
| cory_fu | I'm just not sure how github handles PRs being rebased out from under it | 23:04 |
| marcoceppi | though I am a fan of rebase | 23:04 |
| marcoceppi | cory_fu: it does the right thing | 23:04 |
| marcoceppi | you just have to force push your feature branch | 23:04 |
| cory_fu | marcoceppi: Updated. CI is running, but tests passed for me | 23:07 |
| cory_fu | I'm also a fan of rebasing feature branches | 23:08 |
| marcoceppi | cory_fu: cool, ta! | 23:08 |
| mbruzek | have a good weekend guys | 23:20 |
| * mbruzek waves the eow flag | 23:20 | |
| cory_fu | You, too, mbruzek | 23:21 |
| cory_fu | Damn | 23:21 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!