| dholbach | good morning | 07:33 |
|---|---|---|
| dholbach | davidcalle: do you know what the state of deployments is right now? do we know why the last deployment to production failed? | 08:03 |
| davidcalle | dholbach: I don't, all I know is that it worked on staging. mhall119 will know more :) | 08:19 |
| dholbach | ok | 08:19 |
| dholbach | I was just wondering if the latest went to prod :) | 08:20 |
| dholbach | davidcalle: I found a markdown extension to allow github-style markdown - the snappy folks will be happy now :) | 12:52 |
| davidcalle | dholbach, Hah, excellent :) | 12:53 |
| mhall119 | davidcalle: dholbach: something is wrong with the request headers being sent to the devportal, and a change in the last deployment tried to use them which caused the failures | 13:13 |
| dholbach | will it be hard to fix? | 13:15 |
| mhall119 | I don't know, but I can revert the change that triggers it | 13:15 |
| dholbach | mh | 13:15 |
| dholbach | ok | 13:15 |
| davidcalle | mhall119: which changes trigger it? | 13:34 |
| mhall119 | I added USE_X_FORWARDED_HOST in charm_settings.py | 13:37 |
| mhall119 | that was suppose to fix the cn.developer.ubuntu.com redirects, by telling Django the original request host, but instead it's giving Django invalid Host headers | 13:37 |
| mhall119 | dholbach: davidcalle: Found the bug and a potential fix: https://code.djangoproject.com/ticket/11877 | 14:20 |
| ubottu | Django bug 11877 in Documentation "Document that request.get_host() fails when behind multiple reverse proxies" [Normal,Closed] | 14:20 |
| davidcalle | mhall119: 6yo patch! | 14:22 |
| * dholbach crosses fingers | 14:22 | |
| mhall119 | davidcalle: the patch was actually just to documentation, there's an attached middleware we can use to fix the actual problem, I'm working on incorporating that now | 14:23 |
| dholbach | davidcalle: I'm working on fixing links in the importer again :) | 14:25 |
| davidcalle | dholbach: I'm wondering how the initial logic for link scales up to what you are doing | 14:31 |
| dholbach | I don't think it's too bad, but I'm thinking about adding some tests for this - otherwise it's just going to be too brittle | 14:32 |
| dholbach | davidcalle: can you help me fix the markup of https://developer.ubuntu.com/en/snappy/guides/porting/ - I was just trying to fix a link, but some previous unpublished changes were still in there - now the 8- and 12-cols are a bit mixed up - or something :-) | 15:24 |
| davidcalle | dholbach: ouch :) Looking | 15:29 |
| * dholbach hugs davidcalle | 15:29 | |
| davidcalle | dholbach: fixed, there were multiple issues but the main layout one was caused by "twelve-code" instead of "twelve-col" | 15:53 |
| dholbach | ugh... | 15:54 |
| * dholbach hugs davidcalle | 15:54 | |
| dholbach | thanks a lot for fixing it | 15:54 |
| dholbach | davidcalle, mhall119: http://bazaar.launchpad.net/~dholbach/developer-ubuntu-com/rework-importer/revision/220 - tada! :) | 16:16 |
| davidcalle | dholbach: Nooooooo | 16:17 |
| dholbach | davidcalle: you'd prefer to keep the site working just magically? :-P | 16:18 |
| davidcalle | mhall119: look we have a volunteer to write the duc testsuite :D | 16:18 |
| davidcalle | dholbach: that's awesome, though, how do you run it? :) | 16:18 |
| dholbach | manage.py test | 16:18 |
| * davidcalle tries | 16:21 | |
| mhall119 | davidcalle: if we have the framework setup for them, we can ask for volunteers, maybe from GCI? | 16:23 |
| davidcalle | dholbach, this would be very interesting, but I'm wondering if we have many things to be tested. From the top of my mind I can only think of a handful of tests: Maybe 3 for the API importer, 2 for the webapps generator. | 16:26 |
| dholbach | for all our custom code I guess we should have a test or two | 16:26 |
| dholbach | and for the markdown importer I'm going to have at least 10 tests or something | 16:26 |
| davidcalle | True | 16:27 |
| mhall119 | davidcalle: the js scopes docs package doesn't have a data.json, which is the entry point for the yuidoc importer | 17:48 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!