| mwhudson | anastasiamac: could you look at https://github.com/juju/juju/pull/3961 (it's not getting into reviewboard for some reason) | 01:02 |
|---|---|---|
| cmars | anastasiamac, thanks! | 01:09 |
| anastasiamac | mwhudson: of course \o/ | 01:10 |
| mwhudson | anastasiamac: thanks | 01:13 |
| anastasiamac | mwhudson: lgtm :D | 01:13 |
| mwhudson | anastasiamac: thanks. how do i merge it? :-) | 01:16 |
| anastasiamac | mwhudson: i believe that there is a bot on this repo... have u tried $$merge$$? | 01:17 |
| mwhudson | no, let's find out | 01:18 |
| anastasiamac | k | 01:18 |
| perrito666 | hey good morning | 02:05 |
| anastasiamac | perrito666: hi o/ | 02:05 |
| anastasiamac | how is sunshine coast? | 02:06 |
| perrito666 | nice and sunny | 02:06 |
| anastasiamac | aeesome \o/ | 02:06 |
| anastasiamac | i hope hot too - m removing all long-sleeve stuff from suitecase :D | 02:06 |
| wallyworld | cherylj: i think it's a one line, fix, http://reviews.vapour.ws/r/3386/ | 02:24 |
| cherylj | wallyworld: lgtm. Let's hope that's it :) | 02:27 |
| wallyworld | cherylj: i think it is jusdging by the error | 02:27 |
| wallyworld | cherylj: the cutover for alpha2, that's in a few hours? | 02:30 |
| cherylj | yeah, no. I don't think we're going to get an alpha1 out this week. | 02:30 |
| wallyworld | cherylj: works well for me then - i have a couple of series in metadata fixes i want to do later today | 02:31 |
| cherylj | heh, sounds good :) | 02:31 |
| wallyworld | about about to leave for sprint, will do them later tonight | 02:32 |
| cherylj | have a safe trip, wallyworld :) | 02:32 |
| wallyworld | cherylj: will do, it's only a 2 hours drive :-) | 02:32 |
| wallyworld | not a 16 hour flight :-) | 02:32 |
| cherylj | ha, nice | 02:32 |
| anastasiamac | cherylj: and i will b driving - so wallyworld will be safe \o/ | 02:43 |
| anastasiamac | :D | 02:43 |
| dimitern | frobware, hey, sorry I missed our 1:1 | 09:58 |
| frobware | dimitern, np | 09:59 |
| voidspace | dimitern: Error handling subnets "Default space" is not a valid tag | 10:52 |
| voidspace | dimitern: that's great!! | 10:52 |
| dimitern | voidspace, you should upgrade your maas :) | 10:52 |
| voidspace | dimitern: lots of problems with rc3 | 10:52 |
| voidspace | staying with rc2 was deliberate | 10:53 |
| voidspace | dimitern: think it's worth upgrading? | 10:53 |
| voidspace | dimitern: frobware has had various issues with the upgrade (node addresses and leases) | 10:53 |
| dimitern | voidspace, since rc2 or thereabouts spaces are now called "space-0" and fabrics like "fabric-0" | 10:53 |
| voidspace | dimitern: anyway, I'll just add name translation | 10:53 |
| voidspace | dimitern: facade registration worked | 10:53 |
| dimitern | voidspace, is "Default space" the name or the description? | 10:53 |
| voidspace | dimitern: name | 10:54 |
| dimitern | voidspace, I'd first try renaming that to "space-0" | 10:55 |
| dimitern | voidspace, it used to be forbidden to change the default space's name | 10:55 |
| dimitern | voidspace, if you can change it with $ maas <profile> space update 0 name=space-0 | 10:56 |
| voidspace | dimitern: yeah, I did that - now I get "foozle" is not a valid tag, so there's obviously more I need to do in my code | 10:56 |
| voidspace | ("foozle" was the random name I picked) | 10:56 |
| voidspace | ah, maybe I'm using space name on subnets when I should be using tags | 10:57 |
| dimitern | voidspace, yeah - that was what we talked about yesterday I think - space tags are "space-<name>" and should be used instead of space name in api params (except for creating a new one I guess - except to check for dupes) | 10:57 |
| frobware | dimitern, can we sync? | 10:57 |
| dimitern | frobware, sure - standup HO? | 10:58 |
| frobware | yep | 10:58 |
| mup | Bug #1526296 opened: deploy charm with --series --force doesn't reject invalid OS <juju-core:Triaged> <https://launchpad.net/bugs/1526296> | 12:06 |
| mup | Bug #1526296 changed: deploy charm with --series --force doesn't reject invalid OS <juju-core:Triaged> <https://launchpad.net/bugs/1526296> | 12:09 |
| mup | Bug #1526296 opened: deploy charm with --series --force doesn't reject invalid OS <juju-core:Triaged> <https://launchpad.net/bugs/1526296> | 12:18 |
| abentley | cherylj: Good morning. Bug #1526063 has only been observed in the maas-spaces branch. I meant to mark it incomplete for master, since we don't have evidence that it's there. | 13:59 |
| mup | Bug #1526063: TestNoContextWithLock <ci> <intermittent-failure> <test-failure> <juju-core:Triaged> <juju-core maas-spaces:Triaged> <https://launchpad.net/bugs/1526063> | 13:59 |
| abentley | cherylj: But if we do mark it high in master, we have been assigning it to a milestone also. | 14:00 |
| voidspace | dimitern: what's the correct way to create a tag - first check it's valid and then call New*Tag ? | 14:36 |
| dimitern | voidspace, it depends on what New*Tag() does, but most of them IIRC call IsValid*Tag() and panic if it's not | 14:37 |
| voidspace | dimitern: right, that's why to check if valid first | 14:37 |
| dimitern | voidspace, so it's better to check before calling it | 14:37 |
| voidspace | dimitern: if *not* that, then what? | 14:37 |
| voidspace | so that is the correct way | 14:37 |
| voidspace | thanks | 14:37 |
| dimitern | voidspace, where are you getting the name from? | 14:37 |
| voidspace | dimitern: subnet.CIDR and space.ProviderId | 14:38 |
| voidspace | (I've got past the tag probl | 14:39 |
| voidspace | oops | 14:39 |
| cherylj | abentley: I marked it as triaged for both, as both seem to have the same code | 14:39 |
| dimitern | voidspace, so ProviderId can be anything, so but you're not validating it anyway, right? | 14:40 |
| voidspace | dimitern: I'm doing a simple transform first in my current code | 14:40 |
| dimitern | voidspace, as for the CIDR, if it's invalid and you want to convert it to a subnet tag, then it's an error | 14:40 |
| voidspace | sure | 14:40 |
| voidspace | it's the actual mechanics of creating the tag I was asking about | 14:40 |
| voidspace | currently I have a panic on the apiserver when trying to list spaces - nil pointer dereference | 14:42 |
| dimitern | voidspace, hmm does it say where? | 14:42 |
| voidspace | calling space.ProviderId() | 14:42 |
| voidspace | in reflect/value.go from ProviderId() | 14:43 |
| voidspace | which is new | 14:43 |
| voidspace | interesting | 14:43 |
| voidspace | if a field is "omitempty" in a doc then will accessing it get you a nil pointer dereference? | 14:44 |
| voidspace | I just assumed that for a string, omitempty would default to an empty string | 14:44 |
| mup | Bug #1517258 changed: juju 1.24.7 precise: container failed to start and was destroyed <oil> <juju-core:Invalid> <https://launchpad.net/bugs/1517258> | 14:45 |
| voidspace | dimitern: ah, spaceShim doesn't have a ProviderId | 14:51 |
| voidspace | I think that's it | 14:51 |
| mup | Bug #1517258 opened: juju 1.24.7 precise: container failed to start and was destroyed <oil> <juju-core:Invalid> <https://launchpad.net/bugs/1517258> | 14:51 |
| voidspace | that makes more sense | 14:52 |
| dimitern | voidspace, right :) missed that one | 14:54 |
| mup | Bug #1517258 changed: juju 1.24.7 precise: container failed to start and was destroyed <oil> <juju-core:Invalid> <https://launchpad.net/bugs/1517258> | 15:00 |
| dimitern | dooferlad, you've got a review | 15:02 |
| dooferlad | dimitern: thanks! | 15:03 |
| mup | Bug #1517258 opened: juju 1.24.7 precise: container failed to start and was destroyed <oil> <juju-core:Invalid> <https://launchpad.net/bugs/1517258> | 15:03 |
| mup | Bug #1517258 changed: juju 1.24.7 precise: container failed to start and was destroyed <oil> <juju-core:Invalid> <https://launchpad.net/bugs/1517258> | 15:06 |
| voidspace | dimitern: you didn't miss it, ProviderId is new | 15:14 |
| voidspace | dimitern: I didn't realise it would need to be added to spaceShim as well | 15:15 |
| voidspace | re-bootstrapping now | 15:15 |
| frobware | dimitern, you about for 10-15 mins after the OS call? | 15:15 |
| dimitern | voidspace, heh I meant you added that recently to AddSpace et al, right? :) | 15:16 |
| dimitern | frobware, sounds good | 15:17 |
| frobware | dimitern, as a heads-up just trying to add to the release notes for the AWS support post 15.10 | 15:18 |
| dimitern | frobware, ah, nice | 15:21 |
| dimitern | frobware, I though I already added something about it in Juju 1.25.0 Release Notes doc | 15:22 |
| frobware | dimitern, it's the stuff we've done since then, mostly bug fixes IIRC | 15:23 |
| dimitern | frobware, +1 | 15:23 |
| voidspace | dimitern: space imported on bootstrap! | 15:43 |
| dimitern | voidspace, awesome!! \o/ | 15:43 |
| dimitern | voidspace, so as soon as my other branch lands, they should be usable in constrains right after bootstrap | 15:44 |
| voidspace | dimitern: hmm... but not the subnets | 15:44 |
| voidspace | dammit | 15:44 |
| voidspace | ok, next step of debugging | 15:44 |
| dimitern | voidspace, ah :) | 15:44 |
| dooferlad | dimitern: replied to review - just a query about your comment about the comment... | 15:58 |
| cherylj | hey dimitern, are you still working on bug 1525280? | 16:03 |
| mup | Bug #1525280: 1.25.1 with maas 1.8: devices dns allocation uses non-unique hostname <maas-provider> <network> <regression> <juju-core:Triaged by dimitern> <juju-core 1.25:In Progress by dimitern> <https://launchpad.net/bugs/1525280> | 16:03 |
| katco | cherylj: did you already bump the min version blueprint to a2? | 16:03 |
| === ddellav_ is now known as ddellav | ||
| cherylj | katco: yes, let me re-generate the tracking page | 16:04 |
| katco | cherylj: ty for doing that | 16:05 |
| dimitern | dooferlad, cheers - replied | 16:08 |
| dimitern | cherylj, hey, I'm still sorting out a few issues and testing but it will be ready today | 16:09 |
| cherylj | awesome, thanks dimitern | 16:09 |
| frobware | dimitern, if you would like a tester for your change I can help | 16:29 |
| dimitern | frobware, I'll push the changes during the OS call | 16:30 |
| dimitern | frobware, it will be good to get a second verification | 16:30 |
| dimitern | voidspace, openstack call? | 16:33 |
| voidspace | dimitern: omw | 16:35 |
| natefinch | katco: you said no retrospective this friday, right/ | 16:55 |
| katco | natefinch: yeah i'm going to cancel | 16:55 |
| natefinch | katco: ok, cool, just making sure. | 16:55 |
| katco | natefinch: you still need to show up for work though :) | 16:55 |
| natefinch | katco: awww man | 16:56 |
| voidspace | dimitern: hmm... just had a thought, I bet adding a subnet with a spaceTag isn't sufficient to associate it with that space is it | 17:02 |
| voidspace | I bet I need to do more... | 17:02 |
| voidspace | hmmm... no, that's not the root problem - subnet list is also empty even though it found the subnets from the provider and called AddSubnet | 17:02 |
| voidspace | I wasn't checking the result error field in the first cut though - I've added that now | 17:03 |
| voidspace | so at least I should see an error if one occurs | 17:03 |
| voidspace | dimitern: error creating subnet SubnetTag and SubnetProviderId cannot be both set | 17:07 |
| voidspace | dimitern: so that's straightforward | 17:07 |
| dimitern | voidspace, ah :) | 17:08 |
| dimitern | voidspace, yeah - use the provider id | 17:08 |
| voidspace | dimitern: ok | 17:10 |
| voidspace | dimitern: which means we don't use the CIDR at all creating the subnet | 17:10 |
| dimitern | voidspace, we do on AWS | 17:25 |
| dimitern | as an alternative to using provider id | 17:25 |
| dimitern | voidspace, the idea is, if you have provider-id, you can uniquely identify the subnet, whereas with just a CIDR it might be ambiguous (depending on how it's specified) | 17:26 |
| voidspace | dimitern: next issue is in the maas provider itself | 17:30 |
| voidspace | dimitern: exited "discoverspaces": error creating subnet cannot get provider subnets: instance "" not found | 17:30 |
| voidspace | dimitern: that's new code, so obviously needs some work | 17:30 |
| voidspace | (the new subnets code) | 17:30 |
| voidspace | on the apiserver side | 17:30 |
| voidspace | it's an interesting journey :-) | 17:30 |
| dimitern | voidspace, dooferlad, frobware, please have a look http://reviews.vapour.ws/r/3388/ - fixed the critical bug 1525280 | 17:44 |
| mup | Bug #1525280: 1.25.1 with maas 1.8: devices dns allocation uses non-unique hostname <maas-provider> <network> <regression> <juju-core:Triaged by dimitern> <juju-core 1.25:In Progress by dimitern> <https://launchpad.net/bugs/1525280> | 17:44 |
| dimitern | voidspace, I've fixed that in my other branch btw | 17:45 |
| mgz | dimitern: this is address allocation only right? | 17:49 |
| dimitern | voidspace, have a look please - one more thing to do and will set it to land: https://github.com/juju/juju/pull/3921 | 17:50 |
| dimitern | mgz, nope | 17:59 |
| dimitern | mgz, it's the default behavior now | 17:59 |
| dimitern | mgz, but I tried not to break the addressable containers as well | 18:00 |
| mgz | dimitern: sorry, should have been clearer, this is only an issue when we have explict address allocation on, as in 1.25 or 1.24 with flah? | 18:01 |
| dimitern | mgz, ah, well.. that's a good question | 18:02 |
| dimitern | mgz, I think it's fine with the flag still | 18:03 |
| dimitern | mgz, but just doing a quick test now on 1.25+1.9rc4+address-allocation | 18:03 |
| voidspace | dimitern: EOD, but I can look later tonight | 18:43 |
| dimitern | voidspace, cheers, if you can I'll appreciate it | 18:44 |
| voidspace | dimitern: yep | 18:45 |
| voidspace | dimitern: ah, I thought empty instance id already worked! | 18:45 |
| voidspace | dimitern: I thought I'd done that, my fault then :-) | 18:45 |
| frobware | dimitern, should I expect a different name. I see: instance-id: juju-machine-0-lxc-0 | 18:50 |
| dimitern | frobware, in status it will be the same, but if you check the node details on the web UI, you should see a section about containers and VMs and it will be there with the unique hostname | 18:53 |
| katco | natefinch: wwitzel3: have you had a chance to review ericsnow 's patch? http://reviews.vapour.ws/r/3375/ | 18:54 |
| natefinch | katco: almost done with mine | 18:54 |
| dimitern | mgz, it's good that I checked, as it turned out I did break the addressable containers unintentionally; fortunately it's quite easy to fix | 18:55 |
| frobware | dimitern, mgz: we need (developer-centric) automation in this area. Too much manual testing... :( | 19:05 |
| katco | natefinch: also, is your patch ready to be reviewed? | 19:05 |
| katco | natefinch: or still a wip? | 19:05 |
| frobware | dimitern, in the new year we should have a spike on automation | 19:05 |
| natefinch | katco: it is ready to be reviewed | 19:05 |
| katco | natefinch: sweet tal | 19:06 |
| frobware | dimitern, its says "fixed" for me. fixed-kitten-juju-machine-0-lxc-0.maas :) | 19:07 |
| dimitern | frobware, awesome, isn't it? :) | 19:09 |
| frobware | dimitern, want me to sanity test with multiple nics or shouldn't it matter? | 19:09 |
| dimitern | frobware, it might matter, the more tests the better - but don't feel obliged | 19:10 |
| frobware | dimitern, looking again at your revised patch | 19:20 |
| dimitern | frobware, cheers - pure luck I got that on the first attempt (a second test triggered it after a few attempts) | 19:24 |
| katco | natefinch: review up. should have some things to address | 19:27 |
| natefinch | katco: cool, thanks. | 19:27 |
| frobware | dimitern, how come allocate-address worked without requiring a pointer before? | 19:28 |
| dimitern | frobware, :) long story - it basically expected to get a concrete address to try allocating | 19:30 |
| dimitern | frobware, so it didn't need to return anything but an error | 19:30 |
| frobware | yuck | 19:30 |
| frobware | dimitern, I could do this in the review but figured we might go quicker here: splitting host on '.' what happens for some-host.qacdo.maas? | 19:35 |
| dimitern | frobware, it will work as funny-joke-juju-machine-1-lxc-1.qacdo.maas" | 19:36 |
| dimitern | frobware, hmm.. but I think I check if the parts are exactly 2 - good point! | 19:36 |
| frobware | dimitern, right | 19:36 |
| frobware | dimitern, line 1405 I think is the issue, not necessarily the split | 19:37 |
| dimitern | frobware, yep, good catch | 19:38 |
| frobware | dimitern, Is vs IS - is the plan to fix them up as we find them? | 19:51 |
| frobware | dimitern, correction: Id vs ID | 19:51 |
| dimitern | frobware, that's a can of worms right there :) the consensus seems to point towards ID recently though | 19:57 |
| frobware | dimitern, fwiw - for me it would be better to do this in a different PR - less to review | 19:57 |
| dimitern | frobware, agreed - these are just a few drive-by fixes | 19:58 |
| wwitzel3 | ericsnow: looking at your patch now | 20:03 |
| wwitzel3 | katco: ^ | 20:03 |
| dimitern | dooferlad, fwiw the merge bot doesn't take kindly $$c o m m e n t s$$ with spaces apparently | 20:10 |
| frobware | dimitern, why did so many of the IP addrs get bumped? 2.1 => 2.2, for example. | 20:18 |
| natefinch | katco, ericsnow, wwitzel3: Forgot to mention this mornnig - I'll be in an out tomorrow. My wife had a dentist appointment rescheduled which is screwing up a good part of the afternoon. | 20:20 |
| dimitern | frobware, because tests were simpler before and didn't care about the default gateway, and assumed all networks of a node have .1 IPs | 20:21 |
| natefinch | katco, ericsnow, wwitzel3: should be good for the morning, though. | 20:21 |
| frobware | dimitern, ha. makes sense. thx. | 20:21 |
| frobware | dimitern, subtle though. | 20:21 |
| dimitern | frobware, yeah :) | 20:22 |
| natefinch | gotta take off a little early, but will be back later tonight | 20:23 |
| === natefinch is now known as natefinch-afk | ||
| dimitern | and the maas-spaces live test with even more complex constraints works! | 20:24 |
| frobware | dimitern, great! | 20:32 |
| ericsnow | katco, natefinch-afk, wwitzel3: could you also take a look at https://github.com/juju/charm/pull/184 | 22:12 |
| katco | ericsnow: sure | 22:15 |
| ericsnow | katco, natefinch-afk: I've addressed all review comments except for the one about the CharmStore interface | 22:22 |
| ericsnow | katco: regarding that one, did you have any alternatives to recommend? | 22:22 |
| katco | ericsnow: i'd have to look at the interface again | 22:29 |
| katco | ericsnow: one sec | 22:29 |
| katco | ericsnow: maybe like ResourceLister? | 22:32 |
| katco | ericsnow: if we stick with nouns, i agree CharmStore is fine | 22:33 |
| katco | ericsnow: and also it's not really a huge deal :) | 22:33 |
| ericsnow | katco: I was going to say that we are going to add a bunch of other methods, but actually that's not true | 22:34 |
| ericsnow | katco: so I'm fine with doing the normal Go interface name thing | 22:34 |
| katco | ericsnow: well and if we do, i would suggest we pass in multiple interfaces that are grouped by functionality | 22:34 |
| wallyworld | cherylj: that fix did the trick for 1.25 \o/ so I assume you're looking to release real soon now? | 23:29 |
| cherylj | wallyworld: for 1.25.2, yes. We're just waiting on dimitern's fix for bug 1525280 | 23:33 |
| mup | Bug #1525280: 1.25.1 with maas 1.8: devices dns allocation uses non-unique hostname <maas-provider> <network> <regression> <juju-core:Triaged> <juju-core 1.25:In Progress by dimitern> <https://launchpad.net/bugs/1525280> | 23:33 |
| wallyworld | awesome, will be good to see that fixed | 23:34 |
| alexisb | wallyworld, thanks for the quick fix on the windows issue yesterday | 23:40 |
| wallyworld | sure, np | 23:40 |
| alexisb | wallyworld, how is the beach? :) | 23:40 |
| wallyworld | terrible :-( | 23:40 |
| blahdeblah | Yeah - surf is a bit small at the moment | 23:40 |
| alexisb | are you trying to make me feel better | 23:40 |
| wallyworld | i have a horrbile photo i'm going to share with you soon | 23:40 |
| alexisb | punk | 23:41 |
| blahdeblah | I could barely catch a wave at all this morning | 23:41 |
| wallyworld | blahdeblah: where are you based? | 23:41 |
| blahdeblah | wallyworld: Sunshine Coast | 23:41 |
| wallyworld | blahdeblah: ah, we're sprinting at moolooabah | 23:41 |
| blahdeblah | nice | 23:41 |
| wallyworld | we're having a chrosmas party on the weekend | 23:42 |
| wallyworld | want to come? | 23:42 |
| blahdeblah | When is it? | 23:42 |
| wallyworld | sat night? | 23:42 |
| wallyworld | haven't locked it in yet | 23:42 |
| blahdeblah | Will have to check with the social director, but sounds good. | 23:42 |
| wallyworld | ok, let me know asap if you can as places along the esplanade fill up real quick atm | 23:42 |
| blahdeblah | will do | 23:43 |
| wallyworld | and yes, waves are a bit small :-) | 23:43 |
| blahdeblah | mooloolaba will always be small, but even the open beaches are small this week | 23:44 |
| wallyworld | indeed | 23:44 |
| blahdeblah | Not that it will stop me having a go. ;-) | 23:44 |
| wallyworld | me either | 23:44 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!