| mwhudson | wallyworld: spice bar is pretty nice | 00:38 |
|---|---|---|
| wallyworld | mwhudson: i think i saw that, along the esplanade? | 00:38 |
| mwhudson | yeah, at the north end of the main drag iirc | 00:38 |
| mwhudson | not cheap, mind | 00:39 |
| wallyworld | cool, will check it out, there's a lot of choices, but everything closes at 9 or 9:30 | 00:39 |
| blahdeblah | That's because we have to get up early to get out while the surfing's good | 00:39 |
| wallyworld | true, i woke up today at 5:30 and was sorely tempted | 00:40 |
| * blahdeblah was up at 4:50 today for a run | 00:40 | |
| mwhudson | australia outside of the capital cities is bascially a wasteland, right? | 00:40 |
| mwhudson | :-) | 00:40 |
| wallyworld | pretty much :-) | 00:40 |
| blahdeblah | mwhudson: If you like nightclubs and doof doof music, yes | 00:40 |
| mwhudson | i actually really liked mooloolaba | 00:40 |
| mwhudson | (we holidayed there a year and a bit ago) | 00:41 |
| * blahdeblah prefers more active passtimes like surfing, running, fishing | 00:41 | |
| mwhudson | i also sprinted there with the bzr team but that was years ago now | 00:42 |
| wallyworld | mwhudson: that was with ian clatworthy? | 00:55 |
| menn0 | sinzui, mgz, cherylj: the current merge run appears to be wedged running get_ami.py | 01:17 |
| sinzui | menn0: I can help | 01:17 |
| menn0 | sinzui: thank you | 01:19 |
| sinzui | menn0: killed and requeued. I don't think anyone needs to twiddle the mp that was stalled | 01:20 |
| blahdeblah | wallyworld: social director approval received - sign me up! :-) | 01:47 |
| wallyworld | blahdeblah: awesome, to make it easier for us at the sprint, i'm just going to find a place along moolooabah esplanade that can accommodate the numbers | 01:48 |
| blahdeblah | no worries - you know where to find me | 01:48 |
| wallyworld | there's an italian place i'll ask today | 01:49 |
| wallyworld | indded i do | 01:49 |
| mwhudson | wallyworld: yes | 01:49 |
| wallyworld | mwhudson: yeah, that would have been when ian was sick and couldn't travel :-( | 01:50 |
| mwhudson | yep | 01:50 |
| wallyworld | around 2007 maybe | 01:50 |
| rick_h_ | how goes wallyworld | 01:51 |
| mwhudson | 2009 i think | 01:51 |
| wallyworld | rick_h_: living the dream | 01:51 |
| rick_h_ | wallyworld: wheeeee :) | 01:51 |
| mwhudson | 2007 was before i moved to the southern hemisphere :-) | 01:51 |
| wallyworld | lol, wheeee indeed | 01:51 |
| wallyworld | mwhudson: ah yeah, 2009 sounds right | 01:51 |
| perrito666 | axw_: could you take a look at http://reviews.vapour.ws/r/3392/ ? | 02:11 |
| menn0 | waigani: I think your merge is wedged. it's been running for 45 mins when they normally take about 20 mins | 03:14 |
| waigani | really? shit :/ | 03:15 |
| waigani | menn0: the console output is moving ... | 03:16 |
| menn0 | waigani: never mind. it just finished with a failure. I mixed up my times. it was about 20 mins. | 03:18 |
| waigani | menn0: the one before panicked with no reachable servers. Maybe you're referring to that one? | 03:18 |
| menn0 | waigani: I was looking at multiple jobs at the same time and must have mixed up the time stamps | 03:18 |
| menn0 | sorry for the confusions | 03:18 |
| waigani | menn0: ah right. np. I'll just merge that one again as it doesn't look like it was me. | 03:19 |
| waigani | menn0: unless you want to get something in? | 03:19 |
| waigani | menn0: happy to merge mine after ;) | 03:19 |
| menn0 | waigani: mine's merging now. your failure is the occasional mongodb segfault we sometimes see. I've had that today as well. | 03:20 |
| menn0 | webscale | 03:20 |
| waigani | lol | 03:20 |
| wallyworld | axw_: http://reviews.vapour.ws/r/3395/ | 05:16 |
| === ashipika1 is now known as ashipika | ||
| === prabhugs is now known as prabhugs_ | ||
| === prabhugs_ is now known as prabhugs | ||
| voidspace | dimitern: I see your branch landed | 09:01 |
| voidspace | dimitern: $$suckerpunch$$ ! | 09:01 |
| frobware | dooferlad, ping. I'm back. | 09:09 |
| dimitern | voidspace, hey, yeah :) finally - just replied to your mail as well | 09:09 |
| voidspace | dimitern: the PR you landed on maas-spaces doesn't pass the pre-push checks by the way | 09:10 |
| voidspace | dimitern: or at least I had a bug after I rebased which I had to fix | 09:10 |
| dooferlad | frobware: not quite ready | 09:10 |
| voidspace | I haven't seen the email yet | 09:10 |
| voidspace | dimitern: just grabbing coffee and I'll see it | 09:10 |
| frobware | dooferlad, ok | 09:10 |
| dimitern | voidspace, oh? what issues are you seeing? | 09:10 |
| voidspace | dimitern: line 1824 of provider/maas/environ.go | 09:14 |
| voidspace | dimitern: two extra parameters to the Debugf call but only one %v | 09:14 |
| voidspace | dimitern: next issue: error creating subnet Zones cannot be discovered from the provider and must be set | 09:20 |
| dooferlad | frobware: ok, lets try now. The people I am trying to call are engaged. | 09:21 |
| frobware | dooferlad, "but your call is important to us" | 09:21 |
| dimitern | voidspace, oops sorry :/ I should've run go vet | 09:21 |
| dimitern | voidspace, that's known - for now the workaround is to pass the default zone explicitly | 09:21 |
| voidspace | ok | 09:22 |
| voidspace | dimitern: don't you have the pre-push checks set for git? | 09:22 |
| voidspace | dimitern: I have them set, but if I need to push code that doesn't pass you can just use --no-verify | 09:22 |
| dimitern | voidspace, but I guess the better solution will be to just not require a zone for maas subnets (they're orthogonal) | 09:22 |
| voidspace | dimitern: yep | 09:22 |
| voidspace | dimitern: what do I use for the default zone? | 09:23 |
| dimitern | voidspace, it used to be a pain on the old laptop as everything (or so it seems) was so slow, so I didn't use the pre-push scripts | 09:23 |
| voidspace | heh | 09:24 |
| dimitern | voidspace, well, maas provider does support AvailabilityZones() already | 09:24 |
| voidspace | yeah, which is why I'm surpised by this error | 09:25 |
| dimitern | voidspace, just doesn't provide subnet-to-zone(s) mapping, like we have in ec2 | 09:25 |
| voidspace | ah | 09:25 |
| voidspace | is there an example of code setting the default zone I can look at | 09:26 |
| dimitern | this was mostly needed for ec2, to populate SubnetsToZones and use zone+subnetID when distributing units of a service across zones, when spaces constraints are given | 09:26 |
| voidspace | dimitern: what do I pass for the default zone? | 09:27 |
| dimitern | well, you *could* just hard code it to "default" I guess, but ultimately what I think is needed is just to make AllZones() in apiserver/subnets work with MAAS | 09:28 |
| voidspace | dimitern: right, thanks | 09:29 |
| dimitern | voidspace, looking at the code, the subnets facade tries to get all zones from state first, then the provider and caches them | 09:35 |
| voidspace | dimitern: right, that's your code :-) | 09:36 |
| voidspace | dimitern: you mean that call might be failing? | 09:36 |
| voidspace | I don't have any zones set on my maas | 09:36 |
| dimitern | voidspace, :) yeah, unhelpfully complicated, but I see a simple solution | 09:37 |
| dimitern | voidspace, you always have at least 1 zone - "default" (cannot be deleted) | 09:37 |
| voidspace | dimitern: I've hardcoded default for now and am trying it | 09:38 |
| voidspace | but to land in production the zones need to be right I think | 09:38 |
| dimitern | voidspace, I think all that's needed (and should work with providers like maas and openstack, which don't constrain subnets to specific zones)... | 09:38 |
| dimitern | voidspace, ...is just to assume "all zones were explicitly given for each subnet we're about to add" i.e. as if $ juju subnet add CIDR space zone1 zone2 zone3 ... was called | 09:40 |
| voidspace | dimitern: we can talk about it later | 09:41 |
| voidspace | dimitern: with that change subnets import too | 09:41 |
| dimitern | voidspace, and we get the already-cached list of zones and pass them instead of subnetInfo.AvailabilityZones as a first argument of validateZones in addOneSubnet (when the former is empty) | 09:41 |
| voidspace | \o/ | 09:41 |
| voidspace | dimitern: so put each subnet in all zones? | 09:42 |
| dimitern | s/former/subnetInfo.AZs/ | 09:42 |
| voidspace | cool | 09:43 |
| voidspace | dimitern: if you try my branch now it might work for you... :-) | 09:43 |
| voidspace | if not you can tell me what fails | 09:43 |
| dimitern | voidspace, yeah, because that's what it comes down to - since provider does not impose specific constraints which zones a subnet can span, any subnet can span all zones, and it's up to juju to decide which exactly (i.e. we impose the constraint in order to be able to do unit distribution) | 09:43 |
| voidspace | dimitern: I have to go now, back in a bit | 09:43 |
| dimitern | voidspace, well do, cheers | 09:43 |
| voidspace | still a fair bit to do in the branch (tests!) but the happy path works... | 09:44 |
| dimitern | \o/ | 09:45 |
| dimitern | dooferlad, voidspace frobware, otp will join in 3m | 10:01 |
| dooferlad | dimitern: nobody here at the moment anyway... | 10:02 |
| voidspace | back | 10:40 |
| frobware | voidspace, how did it go? | 10:48 |
| voidspace | frobware: hah, very cute | 10:58 |
| voidspace | lovely, a bit cute overdose for me but still lovely | 10:58 |
| voidspace | Irina did some of the actions, not sure she actually sang though | 10:58 |
| dimitern | frobware, so it turned out it the existing code already worked with subdomain.domain.tld sort of hostnames coming from MAAS | 11:11 |
| dimitern | frobware, but adding a few tests proves it and acts also as documentation/examples | 11:11 |
| dimitern | frobware, and it did work because SplitN(s, ".", 2) does exactly what it says on the godoc -> return up to 2 elements, second one always containing the unsplitted remainder of s | 11:13 |
| frobware | dimitern, good to know. sorry for the noise. :) | 11:15 |
| dimitern | frobware, np :) I wasn't sure off hand, so better check | 11:15 |
| dimitern | voidspace, I just verified the tip of your maas-spaces-networking-api3 branch works perfectly on my 1.9RC4 maas - spaces & subnets imported as expected. deployment with spaces constraints works! | 11:31 |
| dimitern | I only commented a few lines in my test script - http://paste.ubuntu.com/14048778/ | 11:32 |
| * dimitern \o/ it's coming together now! :) | 11:32 | |
| frobware | dimitern, could you put "~/Documents/spaces-demo/spaces-demo-bundle-simplified.yaml | 11:33 |
| frobware | watch juju status --format tabular | 11:33 |
| frobware | " in the pastebin? | 11:33 |
| frobware | dimitern, excusing my bad cut&paste | 11:34 |
| dimitern | frobware, sure - http://paste.ubuntu.com/14048794/ | 11:34 |
| frobware | dimitern, thx | 11:35 |
| dimitern | here's some more: $ juju status (http://paste.ubuntu.com/14048801/); $ juju space list (http://paste.ubuntu.com/14048803/) | 11:36 |
| voidspace | dimitern: awesome!!! | 11:38 |
| voidspace | dimitern: as I work on it I'll try and keep that branch in a useable state | 11:38 |
| dimitern | voidspace, tyvm | 11:40 |
| dimitern | voidspace, trying a similar script + bundle might help with that fwiw | 11:42 |
| voidspace | dimitern: right, I only have two spaces and two subnets in this setup | 11:45 |
| voidspace | dimitern: so I'll have to put together a simple bundle | 11:45 |
| frobware | dimitern, standup HO? | 12:02 |
| dimitern | frobware, omw - 2m | 12:03 |
| dimitern | dooferlad, ping | 12:59 |
| dimitern | dooferlad, whenever you're ready we try pairing on the uniter api | 13:00 |
| frobware | dooferlad, voidspace: can somebody drive-by http://reviews.vapour.ws/r/3388/ | 13:23 |
| frobware | dooferlad, voidspace, dimitern: I did some light testing on maas 1.8 and 1.9 and saw the new node names in the UI | 13:23 |
| frobware | dooferlad, voidspace: this needs to land today so taking a look would be appreciated. | 13:24 |
| dimitern | frobware, great! thanks for confirming | 13:24 |
| frobware | dimitern, did you try 1.7 at all? | 13:25 |
| dimitern | frobware, no, I didn't - we should at least check it once I guess; it shouldn't matter as 1.7 doesn't have devices api and none of that code around hostnames will be used | 13:27 |
| frobware | dimitern, "failed to prepare container "0/lxc/0" network config: failed to allocate an address for "0/lxc/0": address allocation not supported" | 13:34 |
| frobware | dimitern, that's from 1.7 | 13:34 |
| dimitern | frobware, where do you see that? | 13:35 |
| frobware | dimitern, let's HO | 13:35 |
| dimitern | if it's just in the logs, that's fine for 1.7 - no regression at least | 13:35 |
| frobware | dimitern, OK | 13:36 |
| dimitern | frobware, I'd be worried if it caused the provisioning to fail | 13:36 |
| dimitern | frobware, it's not worthy of a HO I think ,but I can join if you like | 13:36 |
| frobware | dimitern, agreed | 13:36 |
| frobware | dimitern, so my sanity test on 1.7 was add-machine lxc:0 and I can juju ssh 0/lxc/0 | 13:37 |
| dimitern | frobware, and status shows the container as "started" ? | 13:38 |
| frobware | dimitern, yep | 13:38 |
| dimitern | frobware, it's fine then - it works (not worse than before) | 13:38 |
| dooferlad | dimitern: you have a review | 14:14 |
| dooferlad | dimitern: sorry that I didn't get back to you earlier. Today has been like a slapstick comedy, but without the comedy. At this moment in time things aren't falling apart, which is nice. | 14:19 |
| === admcleod1 is now known as admcleod | ||
| dimitern | dooferlad, thanks! | 14:26 |
| dimitern | dooferlad, it's ok - do you think you can get on with the uniter api task? | 14:26 |
| dooferlad | dimitern: I need a bit of guidance, but once I have that, yes. | 14:27 |
| dooferlad | dimitern: are you free to jump in c9.io and a hangout? | 14:29 |
| dimitern | dooferlad, sure, just give me 2m and I'll join the standup HO | 14:30 |
| dooferlad | dimitern: see you in https://plus.google.com/hangouts/_/canonical.com/juju-sapphire in a moment then | 14:30 |
| dimitern | dooferlad, omw | 14:31 |
| dimitern | dooferlad, i'm in | 14:33 |
| === natefinch-afk is now known as natefinch | ||
| frobware | dimitern, heh - I can't land the script change only as this will bust containers. :( | 15:20 |
| dimitern | frobware, why? | 15:20 |
| frobware | dimitern, previously we did something like: eth0 -> juju-br0 | 15:21 |
| frobware | dimitern, so we effectively replace everthing up until digit | 15:21 |
| frobware | dimitern, which is great until you get to bonds. for bonds we end up with: bond0 -> juju-br0, which can clash with eth0 -> juju-br0 | 15:22 |
| frobware | dimitern, so I made it a prefix, giving us: juju-br-eth0, juju-br-bond0, et al. | 15:22 |
| frobware | dimitern, however. the container stuff is absolutely demanding juju-br0. | 15:23 |
| frobware | dimitern, as it stands that is. once we have the complete change flushed through this wouldn't be a problem. | 15:23 |
| dimitern | frobware, yeah, that sounds right | 15:24 |
| dimitern | frobware, so why not take the rare chance of doing it the right way this time (just in maas-spaces) first? | 15:24 |
| frobware | dimitern, so we could land the script change but if you had a bond0 expect containers to break. | 15:24 |
| dimitern | frobware, well, if this is the only drawback if we land the improved script into 1.25, and master | 15:25 |
| frobware | dimitern, yes - if in maas-spaces you use a bond0 ... well sorry... wip. | 15:26 |
| dimitern | frobware, I still think it's fine - it's not like we *used* to work with bonds + juju-br0 and now we regressed | 15:26 |
| frobware | dimitern, so we're saying let's just land the script, it will get some exposure and we can move on with the bigger change for interface_set, et al. yes? | 15:26 |
| frobware | dimitern, there's no way the script should go beyond maas-spaces at this point. | 15:27 |
| dimitern | frobware, I think since the script is strictly better and simpler, even without handling bonds properly, we should land it, while continuing to iterate over it in maas-spaces to make it solid | 15:33 |
| dimitern | maas-spaces will end up in master eventually, but we'll have more time to improve the script there first | 15:34 |
| katco | natefinch: wwitzel3: ericsnow: forgot to mention, i'm going to close out the iteration this friday in terms of points, so make sure to get any cards you want included moved across to done before EOD friday. | 15:38 |
| wwitzel3 | katco: well I want all of them included .. | 15:40 |
| wwitzel3 | katco: so I'll move all of them, lol | 15:40 |
| katco | wwitzel3: =| | 15:40 |
| katco | wwitzel3: you wound me, sir. | 15:40 |
| dooferlad | dimitern: is there a right way to call the NetworkerAPI from the uniter API? With that we just create a names.MachineTag and call (n *NetworkerAPI) MachineNetworkConfig... | 16:23 |
| dimitern | dooferlad, why would you do that? | 16:24 |
| dooferlad | dimitern: to avoid writing the same function again. | 16:24 |
| dimitern | dooferlad, hmm I see where you're going | 16:24 |
| dooferlad | dimitern: or we just do it client side - generate the machine tag there and call the networker API. | 16:25 |
| dooferlad | dimitern: that would probably make more sense | 16:25 |
| dimitern | dooferlad, but please do it separately, as 1) the networker is not working for a long time now, and 2) I'm seriously considering to remove it in maas-spaces | 16:25 |
| dooferlad | dimitern: ah, OK | 16:26 |
| dooferlad | dimitern: copy and paste time then :-) | 16:26 |
| dimitern | dooferlad, yeah - that's only due to time constraints though (and because of 2) above) - there are ways to reuse code safely across facades and in other cases I'd have suggested it :) | 16:28 |
| dooferlad | dimitern: changes so far: https://github.com/juju/juju/compare/maas-spaces...dooferlad:uniter-network-config?expand=1 | 16:54 |
| dimitern | dooferlad, cheers, looking | 16:54 |
| dooferlad | dimitern: back in a bit. Let me know if you think this is the right direction. | 16:54 |
| dimitern | dooferlad, looks mostly fine - please add a test in api/uniter and apiserver/uniter for NetworkConfig and I think it's ready for revew | 16:57 |
| dimitern | review even | 16:57 |
| dooferlad | dimitern: OK. May not get to it tonight, but will get it done ASAP. | 17:17 |
| dooferlad | dimitern: thanks for taking a look. | 17:17 |
| dimitern | dooferlad, cheers - will have a look tomorrow | 17:20 |
| * dimitern whew... after 4 hour long battle with state - now not only the build succeeds, but only the expected 2 tests out of 1240 fail! getting closer.. | 17:44 | |
| frobware | dimitern, should eth1.3 be bridged? http://pastebin.ubuntu.com/14053466/ | 17:49 |
| dimitern | frobware, it looks like it's not up, is it? | 17:51 |
| frobware | dimitern, correction, look at this one: http://pastebin.ubuntu.com/14053499/ | 17:51 |
| frobware | dimitern, so the raw dev is no up, but the vlan is. | 17:51 |
| dimitern | frobware, both look like they should be up | 17:51 |
| dimitern | frobware, they are both "auto eth..." | 17:52 |
| frobware | dimitern, so my notion of active is based on: self.is_active = self.method == "dhcp" or self.method == "static" | 17:53 |
| frobware | dimitern, maybe that's simply wrong. | 17:53 |
| frobware | dimitern, or not enough. maybe it should take into account the auto stanza. | 17:53 |
| dimitern | frobware, it all depends on how ifup treats these cases | 17:54 |
| dimitern | frobware, I'd expect anything without "auto" to be down | 17:55 |
| frobware | dimitern, given our machine generated /e/n/i - what would change to make eth1 ^^ get an IP address? | 17:56 |
| frobware | dimitern, in the previous example | 17:56 |
| frobware | dimitern, if I had 10 of eth$N, each manual, would we expect 10 bridges? | 17:58 |
| frobware | dimitern, I only really ran into this because I forgot to assign an IP addr in the UI for eth1. | 17:58 |
| dimitern | frobware, didn't we decide to make bridges only on the physical NICs which are up and leave any VLAN NICs - so that traffic for vlans will get tagged but still end up on the bridge ? | 18:05 |
| === natefinch is now known as natefinch-afk | ||
| frobware | dimitern, I think the issue is determining what constitutes 'up'. I'm beginning to think it should be based on the presence of auto. | 18:06 |
| frobware | dimitern, the experiment we did yesterday we bridged vlans. | 18:07 |
| frobware | dimitern, I still think we should do that. | 18:07 |
| dimitern | frobware, yeah - also it's the simplest approach | 18:10 |
| frobware | dimitern, for now I'm going to treat the presence of 'auto' as an active interface. | 18:10 |
| frobware | dimitern, if you just had 'iface eth20 inet manual' then that can never be up so is there any point in creating a bridge? | 18:11 |
| frobware | dimitern, it's the vlan case that is confusing though. | 18:11 |
| frobware | dimitern, the raw device need not have an IP address but the vlan can. in those cases should the raw device have its own bridge? | 18:12 |
| dimitern | frobware, let me think.. | 18:18 |
| dimitern | frobware, so w.r.t. VLANs, even if their raw device is not "auto" or even up, if the vlan device is itself "auto", IIRC that *will* bring the parent up as well | 18:19 |
| frobware | dimitern, it will, but if it is 'manual' it won't (obviously!) have an IP address. | 18:19 |
| dimitern | frobware, that sounds correct, but I'd suggest doing a quick experiment to verify | 18:20 |
| frobware | dimitern, and if it is 'manual' then have no bridge for 'eth1', but we would have a bridge for eth1.789 | 18:21 |
| dimitern | frobware, with iface eth0 inet manual (no auto eth0), and auto eth0.42, iface eth0.42 inet static | 18:21 |
| frobware | dimitern, you'll get juju-br-eth0.42 (i.e., bridged) | 18:21 |
| dimitern | frobware, I don't think that last is correct though | 18:22 |
| dimitern | frobware, it all depends on if no-auto + manual and no address, coupled with auto+static vlan on top of it actually works | 18:22 |
| frobware | dimitern, so going back to http://pastebin.ubuntu.com/14053499/ | 18:24 |
| frobware | dimitern, we would not create a bridge for eth1.3 | 18:24 |
| dimitern | frobware, I think this is correct | 18:29 |
| frobware | dimitern, right now if this is not correct, then change eth1 from manual to dhcp/static | 18:30 |
| dimitern | frobware, I've just tried here with auto ethX, iface ethX inet manual; auto ethX.42; iface ethX.42 inet static; address 10.42.10.0/24; vlan-raw-device ethX; vlan_id 42 | 18:30 |
| dimitern | frobware, I think it will be much easier in maas-spaces | 18:31 |
| frobware | dimitern, because? this is in maas-spaces. I was just doing some testing before submitting a PR for the script | 18:31 |
| voidspace | dimitern: hmm... I thought (like you) that new facade versions should start at 1 | 18:32 |
| dimitern | frobware, as right after acquire node + bindings we get all NICs we asked for and we'll know we need a bridge for *each* one | 18:32 |
| voidspace | dimitern: however, there is a test that they should start at zero (TestFacadeVersionsMatchServerVersions) | 18:32 |
| voidspace | dimitern: so I'm setting it to 0 | 18:32 |
| dimitern | voidspace, that test seems wrong | 18:33 |
| voidspace | dimitern: it passes for everything else... | 18:33 |
| dimitern | voidspace, are you sure it's not about facade version before login? | 18:33 |
| frobware | dimitern, going back to "each one". If you forgot to make eth1 dhcp/static then what we are currently saying is you would not get a bridge for eth1.789 - is that right? | 18:33 |
| voidspace | dimitern: it tests that the version number for each facade is the len of the different versions -1 | 18:33 |
| voidspace | dimitern: i.e. if there is only one version it must be zero | 18:33 |
| voidspace | dimitern: starting some at 1 would require special casing them all in the test | 18:34 |
| dimitern | frobware, ideally we should detect misconfigured interfaces early and report it | 18:34 |
| voidspace | dimitern: gp/afacadeversions_test.go | 18:34 |
| dimitern | frobware, but for now let's assume the network config on the maas node is as expected (in maas-spaces) | 18:35 |
| frobware | dimitern, ok - let's settle on if the underlying raw device is 'auto' but 'manual' any vlans of that will not be bridged. OK? | 18:35 |
| dimitern | voidspace, where? | 18:35 |
| dimitern | frobware, I can live with that :) | 18:36 |
| voidspace | dimitern: gp/afacadeversions_test.go | 18:36 |
| frobware | dimitern, It's trivial to fix either way. was just testing... :) | 18:36 |
| voidspace | dimitern: TestFacadeVersionsMatchServerVersions | 18:36 |
| dimitern | voidspace, that sounds like it expects api/ and apiserver/ facades to match, not that all facades need to start from 0 | 18:38 |
| dimitern | voidspace, e.g. api.FacadeVersions["Spaces"] is only at V1 | 18:39 |
| dimitern | voidspace, apiserver/cleaner is another example (of a agent facade, inlike Subnets) also only with V1 | 18:41 |
| voidspace | dimitern: ah | 18:44 |
| voidspace | dimitern: my misunderstanding then | 18:44 |
| dimitern | voidspace, check if you're using RegisterStandardFacade in discoverspaces init() | 18:45 |
| dimitern | *not* RegisterFacade instead | 18:45 |
| voidspace | dimitern: hah, I was using 0 :-) | 18:45 |
| voidspace | dimitern: uhm, sorry about that | 18:45 |
| dimitern | :) np | 18:46 |
| voidspace | dimitern: go on holiday... | 18:46 |
| dimitern | I know a lot of our tests are bad, but at least we should try to grant them some chance to actually fail for the right reasons :D | 18:46 |
| voidspace | :-p | 18:47 |
| frobware | dooferlad, voidspace, dimitern: if you have the time - http://reviews.vapour.ws/r/3398/ | 19:13 |
| mup | Bug #1526926 opened: Controllers cannot be destroyed or killed <ci> <destroy-controller> <kill-controller> <juju-core:Incomplete> <juju-core controller-rename:Triaged> <https://launchpad.net/bugs/1526926> | 19:16 |
| dimitern | frobware, will have a look in a moment | 19:19 |
| frobware | dimitern, thanks. off-hand, do you know if it is possible for the cloudinit config to add a file to the node. I was just looking and it seems that might be so. it woud be better if our script was added as a file (somewhere) so that we don't see the output in the run cmds from cloudinit- | 19:21 |
| dimitern | frobware, yes - there's a AddBootFiles() which does that | 19:21 |
| frobware | dimitern, aha. | 19:21 |
| dimitern | frobware, your PR looks nice, but I'd like to do a quick test with it and a few configs I found to cause issues; focusing on the demo reqs | 19:23 |
| dimitern | all state tests pass! | 19:26 |
| dimitern | I'm proposing what I have so far as WIP | 19:27 |
| voidspace | frobware: EOD | 19:42 |
| voidspace | frobware: can look tomorrow if it's still needed | 19:42 |
| voidspace | g'night all | 19:42 |
| === BradCrittenden is now known as bac | ||
| wallyworld | frankban: urulama: mothing new from this end, still working on final branch to enable add-relation (writing tests). will be landed by your SOD | 21:21 |
| urulama | wallyworld: kk | 21:22 |
| wallyworld | urulama: frankban: have a good evening and we'll catch up in several hours | 21:23 |
| frankban | wallyworld: sounds good, on the JS side I have a branch in review with the impl of the mega-watcher remote service consumer and the CrossModelRelations.ServiceOffers API call: https://github.com/juju/juju-gui/pull/1091 will ping Jeff later for review. hopefully that stuff would look familiar to you | 21:24 |
| urulama | wallyworld: ok. jeff and huw have some tasks on GUI anyway, and frankban made things available in case you finish before we get up. | 21:25 |
| wallyworld | frankban: awesome, ty, will take a look | 21:25 |
| frankban | wallyworld: ty, have a good day! | 21:25 |
| wallyworld | frankban: can jeff etc review that branch? or does someone else need to look too? | 21:25 |
| frankban | wallyworld: yes Jeff and Huw are definitely I'd like to review that branch | 21:26 |
| frankban | are definitely the ones | 21:26 |
| wallyworld | ok, will do, thanks for doing it :-) | 21:26 |
| urulama | wallyworld: and in case something is not working, please check it with them, so that we can isolate where things get wrong. you'll love JS :) | 21:27 |
| urulama | (and appreciate golang a bunch more later) | 21:27 |
| wallyworld | urulama: oh, i have done a lot of js on the past on launchpad :-) | 21:27 |
| urulama | perfect then :) | 21:28 |
| wallyworld | been a few years :-) | 21:28 |
| wallyworld | was all in yui | 21:28 |
| wallyworld | which is now dead | 21:28 |
| frankban | wallyworld: the GUI has still some YUI bits, but we are gradually moving away | 21:29 |
| wallyworld | to React I hear | 21:29 |
| frankban | yes | 21:29 |
| wallyworld | cherylj: i'll finish release notes first thing this morning within an hour or so, didn't quite get finished yesterday with everything else | 21:37 |
| cherylj | thanks, wallyworld | 21:37 |
| alexisb | is there someone around that can help point me in the right direction regarding details of the status command implementation ? | 23:39 |
| perrito666 | I might, then again, I might not | 23:41 |
| alexisb | heya perrito666 ! | 23:41 |
| * perrito666 is the cheshire cat | 23:41 | |
| alexisb | :) | 23:41 |
| perrito666 | how can I help you suffer status? | 23:41 |
| alexisb | do you mind jumping on a hangout with me, it would be faster I think | 23:42 |
| alexisb | I just need some help navigating the waters | 23:42 |
| perrito666 | alexisb: sure, gimme a sec | 23:42 |
| menn0 | fairly easy review anyone? http://reviews.vapour.ws/r/3404/diff/ | 23:45 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!