=== Puzzle is now known as Guest87146 === Sal is now known as Guest96314 [01:33] Sorry if this is a stupid question, but I submitted a task and it wasn't accepted and I am not sure what is wrong/missing with my submission. Any help would be appreciated. [03:00] balloons: sorry if it's a bit late, but would https://codein.withgoogle.com/tasks/5837926646677504/ require taking photos for the art aspect? Or could I create other art if I claimed it? [03:44] If any mentor is awake can you review https://codein.withgoogle.com/tasks/4843721241657344/ ? Thanks :) [08:18] balloons: cam we pause tasks? with images not building then pointless having tasks related to that [12:56] Can any mentor extend my task's deadline : https://codein.withgoogle.com/dashboard/task-instances/5131342014578688/ === alan_g is now known as alan_g|lunch === alan_g|lunch is now known as alan_g [14:10] yes we can pause [14:11] If its not too much trouble at this time, could a mentor review this task: https://codein.withgoogle.com/dashboard/task-instances/5486692492378112/ [14:13] balloons: good job I happen to be here - I'd never have seen that :p [14:13] anyway builds are failing so ... [14:14] balloons: at least any tasks related to images for ubuntu and xubuntu should be paused - not sure what others have [14:49] I may be lying though flocculant, as I can't unpublish if they are being worked atm [14:53] flocculant, I unpublished Add product to ISO testing bug reports as well. I'm not sure where the code lies for the bot, or how to update it sanely [14:55] everyone requesting a review in here should have had one now [17:17] balloons: ack both those :) === alan_g is now known as alan_g|EOD [18:33] irssi [18:33] Sorry ignore that. [18:34] Hi, I submitted task about ubuntu gnome logo and it's need reviewing [18:34] Can someone here review it [18:35] Yeah, even I submitted that task yesterday. [18:35] Girish, How many tasks have you completed so far? [18:35] Girish and Rob1507, I've had a couple that have taken 2 or so days - might just have to wait. People are probally busy [18:36] Rob1507, Girish, I saw those tasks, but Ali needs to review. And he's asleep atm, it's the middle of the night :-) [18:37] Rob1507, I've got 6 done - you? [18:37] MatthewAllen, only 2 :/ [18:37] 5* [18:37] Its the third task [18:37] Rob1507, I'm the same - just submitted 6 [18:37] Wonder who has the most and how many... [18:38] Oh me too [18:51] balloons : What about the READMEs? I'm still not able to fix the errors. [18:52] Girish, right. So I would simply add a note that says to install things listed in debian/control. That's how you got it to build originally right? [18:52] Yep. [18:52] We can file a bug to have someone prune the list or make it easier if that makes sense [18:52] I would do the same with the other README's. I might be asking too much [18:52] I should add a README.dependencies where I point out to install things listed in dependencies. [18:53] And point README.dependencies in every other README [18:53] Girish, I think I would add it as a section in the build readme [18:53] Okay. [18:53] like you did for the autopilot readme [18:53] Yes. [18:53] thanks for trying to make it just be a package or two. But it doesn't hurt to install the big list. If it's already installed nothing will happen [18:54] so I'm probably just being silly [18:54] Also, I'm able to push code to Launchpad. But every time I try installing the QA dev environment it says Error: public key [18:55] Girish, you need to setup your SSH Keys on launchpad I believe [18:55] I have done that. [18:55] You on Windows, Ubuntu, something else? [18:55] That's why I'm able to push code? [18:55] Ubuntu 15.04 [18:55] Hmmm, not sure then - sorry :\ [18:59] balloons : So I added a sentence Dependencis for the project are listed in ubuntu-calendar-app/debian/control [18:59] That is fine, I guess? [19:00] Dependencies* [19:05] Girish, yes. Just say something like, Before building or running, you will need to install the dependencies for the application. A complete list can be found in the debian/control file. [19:05] Thanks! [19:07] tsimonq2: could you review my task? ;) [19:08] Girish, Rob1507, I approved your tasks. Ali will forgive me ;-) The writeups were good [19:09] Thanks! [19:19] balloons : Made a merge request. [19:27] Girish, ok, I'll have a look. Thanks! [19:35] balloons : The design document link for weather app is broken: https://docs.google.com/presentation/d/1tXcyMBvJAYvwFvUAmTTYzmBP2NFQgbG_Gy8e2gv91kU/edit#slide=id.p [19:35] Found at https://developer.ubuntu.com/en/community/core-apps/weather/ [19:37] Girish, ahh, That's something for popey to fix. I wonder what happened to the link [20:25] Hi kenvandine, for the primer, should I create a tutorial about creating another Game, or just some random example. (I ask this because it says a brief primer, and I'm not sure whether or not by brief you just meant examples or a very simple game) [20:26] doesn't need to be a full game [20:26] xcub, but to test it out yourself you'll probably need a simple game [20:27] xcub, but the goal of the doc is help someone already using bacon2d for a game to understand what behaviors are for and how to use them in their game [20:27] so kind of like the example, showing the concept but not any real objective to the application? [20:28] xcub, hey also on your snap. I found out from elopio that indeed it does have some issues on the device. It's intended to be a service it seems, and not a binary. elopio could explain more [20:29] xcub, yeah [20:29] ok [20:30] xcub, but good explanations are more important than the code examples [20:30] xcub, the code examples should augment the explanation [20:31] alright, I'm thinking of doing something where I build a game, but don't explain any of the things I covered in the last turoail [20:31] xcub, sounds good [20:32] xcub, an example of a non-physics game would be cool too [20:32] perhaps another instance of your previous task [20:32] xcub, you could kill 2 birds with one game here :) [20:33] yeah ok, I'll do that :) [20:33] awesome [20:34] so the second game tutorial could include the behavior, but reference the primer for more information [20:35] balloons : Proposed a merge for weather app READMEs [20:36] actually, i'm not sure how I can appropriately incorporate the srollbehavior into the previous game, I'm more comfortable with building a new game instead. I [20:36] xcub, right... a new game [20:36] your breakout game is a perfect example of a physics game [20:37] maybe a side scrolling game :) [20:38] xcub, actually that would be best using InfiniteScrollEntity [20:39] waiit, sorry i misread the first thing :) [20:40] Girish, heh, speedy. I'll take a look [20:43] Girish, did you confirm your build and debug instructions. Just a note of caution that not every core all is exactly the same in this regard [20:49] balloons: can you check here please :) https://codein.withgoogle.com/dashboard/task-instances/6381048564809728/ [20:51] flocculant, shall we remove it from the display UI too? [20:51] it seems like yes actuall [20:54] balloons: makes sense to me - if people can't add it, seems pointless to be able to see something no-one can use - I was just asking as people used to, so the entries will exist somewhere on the database I assume [20:54] flocculant, yes they will. And I was going to say, just delete it from the form. But it does make more sense to just remove it everywhere, but leave the old data [20:55] right [20:55] balloons, Girish, is that readme's one for the weather-app making the readme into a format like markdown or something ? [20:55] flocculant, which makes me think of what other UI changes we'd want. We've worked down the bugs [20:55] balloons: well - the easier ones :p [20:55] ahayzen, the goal was to lower the barrier to entry for new developers by having a nice set of README's [20:56] balloons, yeah it looks nice :-) is the plan for that to happen for all core-apps? with common sections across the readmes ? [20:56] ahayzen, please do give input on what you like and what you don't like about it. For instance, we never said it had to be in markdown format, but perhaps that's a good idea [20:56] ahayzen, yes, there is a task for every app. Girish is being a boss and going through them :-) [20:56] balloons, yeah i wonder if something like markdown would help, then you could parse that easily in the django developer.ubuntu and show the readmes nicely [20:57] yea.. It hurts nothing at all to have it in markdown [20:57] What do you think Girish? [20:58] balloons: anyway - not sure about the UI atm - will have time to think more tomorrow, but I've just added a new comment to hunter's task, he'll need your ack though [20:58] ahayzen : balloons : Oh yeah that's a brilliant idea! :D [20:58] Does launchpad dislay the readmes/markdown? Even if it didn't, it might be good as markdown is pretty cool [20:58] Girish, shall i put a comment on the MP saying to ensure its markdown ? [20:59] ahayzen :Sure. [20:59] flocculant, I'll agree with you on removing all traces [20:59] k - just added a new 'can we?' to it :D [21:00] flocculant, yea, this is getting into some UI changes.. Which I would LOVE LOVE to se [21:01] :) [21:01] * balloons channels for knome [21:01] I'd obviously like to see one major UI change - getting rid of the ridiculous bug icons ;) [21:01] balloons : btw, I was following my build and debug instructions and I'm getting an error "Ubuntu.Components" version 1.3 is not installed. Shouldn't I already have it when I installed ubuntu-sdk-libs? [21:01] ahayzen, if you'd like, go ahead and finish the review. I can accept the task once you are happy with everything. Sound ok/ [21:02] Girish, you are on wily and have the ppa right? [21:02] balloons, i've put a comment on the MP, maybe the tasks for each of the coreapps should mention markdown ? [21:02] balloons, and yes if you want to add me as the reviewer/mentor that's cool [21:03] Shit I'm on Vivid. IS that exclusively for wily? [21:04] Girish: please tone down the language a bit. :) [21:04] Sorry. [21:04] ahayzen, ack [21:04] no problem. i won't report you to the authorities XD [21:04] Girish, no, not at all [21:04] Girish, but you will need the overlay ppa [21:05] ppa:ci-train-ppa-service/stable-phone-overlay [21:05] Okay. Thanks! [21:05] * balloons notes if he didn't tell you this, it's probably why calendar had issues [21:05] ahayzen, speaking of that overlay ppa, lol, do we need to mention it in the readme? [21:05] We should. [21:05] balloons, overlay ppa? ... [21:05] that's one of those little things I'm trying to suss out [21:06] ahayzen, don't you use it? https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay/+index?field.series_filter=vivid&batch=75&memo=75&start=75 [21:06] balloons, nope [21:06] balloons, should i? lol [21:06] well then . . . [21:06] balloons, maybe that would allow me to run autopilot on the desktop for uc1.3 stuff ? [21:06] ahayzen, you are on wily? [21:06] note i'm still on the old SDK thing, on vivid still [21:07] and i have a local branch of the uitk which i compile and run apps from [21:07] ahayzen, ahh. So how do you build the weather app then? [21:07] then run autopilot via adt to the device [21:07] ahh.. see that craziness means it's impossible for others to help out [21:07] balloons, 'build' weather app is pure QML ;-) [21:07] it's gotta crazy [21:07] ahayzen, well, yes, quite true. But it won't run without the right framework [21:07] $ click-buddy . [21:07] works on vivid :-) [21:08] balloons, this is the script i use for running pretty much any branch on a device http://people.ubuntu.com/~ahayzen/run_branch_on_device.sh [21:08] 'run' actually means install ;-) lol [21:09] balloons, is it all different on wily? [21:09] ahayzen, I added you to all the readme tasks :p. But this conversation makes me wonder a bit. [21:09] \o/ [21:09] balloons, people should be on trusty or wily anyway right? [21:09] not really vivid [21:09] I'd like to make sure it's extremely simple and straightforward to build, run and test every core app. That's the idea behind the readme's. I'm curious now if our recommendations are still the best [21:09] ahayzen, yes [21:10] ahayzen, and with the new SDK release, maybe what we're doing has been made much much simpler [21:10] hopefully [21:10] balloons, what specifically are you having problems with? [21:10] I mean. I *think* all the apps can be built, run and tested inside the SDK now [21:10] that's what i would have thought [21:10] ahayzen, I'm not, but I can hack my way around whatever I need. I'm talking about new contributors [21:11] yeah [21:11] and Girish in particular is having trouble with weather and uitk 1.3 [21:12] so what i do is, have a branch of the UITK and then do $ source export_modules_dir.sh ... but that doesn't work with autopilot IIRC [21:12] balloons: awesome ... me tells hunter to change UI to xubuntu blue :D [21:12] balloons, maybe some of the SDK folks are best to poke about this, i haven't played with the new sdk yet and don't know which PPAs i should be on [21:14] darkxst: is it possible that you give me one more day for the task? [21:14] robbert, sure [21:15] ahayzen, the overlay ppa was to get some of the new phone stuff on the desktop that wasn't in distro [21:16] but if we propose to new folks to install the SDK and use it and only it, stuff in theory should never be an issue [21:16] robbert, done [21:16] my only concern there is what about the other app dependencies? [21:19] balloons, there are some things, like music requiring mediascanner... or weather needing API keys ... but most of those you can figure out from the debian/control or should just be said in the readme i guess? [21:24] When I'm trying to update my system using sudo apt-get update I'm getting the following error: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY 5A7D1D38BEB6D886 [21:24] darkxst: thank you :) [21:24] I googled and tried adding the key manually but go key 5A7D1D38BEB6D886 not found on keyserver [21:25] robbert, how are you going with the task? [21:26] Girish, how did you add the ppa? it grabs the key automagically [21:26] sudo add-apt-repository [21:26] Yeah i did that [21:26] ahayzen, I think the readme should be explicit [21:28] Girish, you can install without it, but the packages can't be verified [21:28] what repo is giving you the error? [21:28] also did the overlay ppa solve the issue? [21:28] It didnt [21:28] Something from opensuse.org [21:29] :) [21:29] Still getting Ubuntu.Components version 1.3 is not installed [21:31] Girish, what do you have installed from opensuse? [21:31] Girish, I will say though vivid is actually out of support [21:32] Should I install willy? [21:33] Or trusty? [21:33] Girish, sorry I'm wrong. It's supported till Jan [21:34] anyways, moving to an LTS is generally a good idea if you don't want to upgrade a lot. [21:34] That said, I wonder about what version of things you have installed [21:35] apt-cache show ubuntu-ui-toolkit [21:35] you should have 1.3.1761+15.04.20151216.1-0ubuntu1 [21:40] Girish, ^^ [21:46] balloons : I don;t have it installed. Unable to locate package. [21:47] Girish, wha? Why not? it's what provides the ubuntu components [21:47] But I installed qtdeclarative5-ubuntu-ui-toolkit-plugin from control [21:47] wild. I'm not sure how you never got that package installed [21:51] Girish, if you install it things should work [21:51] I'd maybe try back tracking starting with disabling the opensuse repo [21:51] just a thought :) [21:52] ahayzen, a long long time coming, but I finally pushed https://code.launchpad.net/~nskaggs/ubuntu-weather-app/manual-tests/+merge/280775 [21:53] balloons, yeah just saw that :-) thankies, i need to update the music-app one with your comments :-) [21:53] ahayzen, I have one for music too. I want to merge at least the initial versions that work [21:53] * balloons preps it now [21:53] balloons, ok, to overlay mine like you did with p opey's ? [21:54] ahayzen, yes. I'll merge yours and make sure I have everything just in case [21:54] balloons, then every features/bug we fix we'll have to start enforcing some form of (regression) test :') hehe [21:55] balloons: If I made a merge request and had to fix some things, should I make a new commit on that same branch and push it or do something else? [21:55] mcinitreevan, yep. A new commit and push it. The MP will update [21:56] ahayzen, balloons I believe I fixed the sql database injection errors, but it's throwing an error at this line: libraryEmpty = self.app.select_single(LibraryEmptyState, objectName="emptyLibrary") [21:56] fazer, I was wondering about you :-) [21:56] fazer, sweeeet [21:56] It says LibraryEmptyState is not a valid object [21:56] good to hear! [21:56] fazer, that's a much nicer place to error [21:56] ahayzen, timing issue? wait_select to check? [21:57] fazer, can you see the empty state being shown when the app starts up? [21:57] I was running hidden, lemme try again [21:57] fazer, and yeah as balloons says, timing,... try wait_select_single() [21:57] * balloons notes autopilot3-sandbox-run supports -X which lets you see things [21:59] I'm going to try to skip the walk through, cause that's the page I see [22:01] fazer, ah hang on copy this code... [22:01] fazer, http://bazaar.launchpad.net/~music-app-dev/music-app/trunk/view/head:/tests/autopilot/music_app/tests/test_music.py#L50 [22:01] fazer, Line 50 and 51 [22:02] I skipped the wlakthrough, theres a method in MusicApp [22:03] * balloons crosses fingers for success [22:03] but that's not the problem, I can still see the three songs in my library. Apparently it didn't load the database properly. [22:03] :( [22:03] fazer, hmm you inheriting from the right base class? ;-) [22:03] fazer, is your latest code pushed as well? [22:05] yes I checked. all the right inheritances. pushing now [22:07] fazer, ok i'll have a look in a bit, having dinner/watching TV :-) [22:07] alright, no prob. [22:11] balloons : I updated the ubuntu-sdk and reinstalled everything in control. [22:11] Getting a new error: Seg fault [22:14] DanChapman, how do I propose something to dekko nowadays? [22:17] balloons : Is ubuntu-ui-toolkit a package which I can install by apt-get? [22:17] Or is it inside another package? [22:23] Girish, directly installable [22:23] ubuntu-sdk-libs should install it I would have thought [22:23] but install it yourself [22:23] apt-get install ubuntu-ui-toolkit doesnt install anything [22:24] Unable to locate package [22:28] ohh, it's qtdeclarative5-ubuntu-ui-toolkit-plugin now. I think you mentioned that [22:28] sorry about that [22:29] Yep. [22:29] however, I see it for vivid in the ppa: ppa:ci-train-ppa-service/stable-phone-overlay [22:29] I'm still getting a Seg fault when I run it. [22:29] under ubuntu-ui-toolkit [22:29] Girish, a pasted log would probably help [22:30] ubuntu-weather-app/app$ qmlscene ubuntu-weather-app.qml [22:30] Segmentation fault (core dumped) [22:30] balloons, wait_select_single() is a method of app_proxy right? And the inputs to that would be the type of Object(eg Albums or LibraryEmptyState) and the object name right? [22:31] fazer, so ... libraryEmpty = self.app.wait_select_single(LibraryEmptyState, objectName="emptyLibrary") [22:31] instead of what you posted earlier [22:31] fazer, wait_select_single is the same as select_single, it just includes a wait step to wait until the object appears, or it times out [22:32] ok, it doesn't work, still says it can't locate that object but I think the real problem is with the databases because I can still audio files in my library [22:32] fazer, what happens when the application starts when running the test? [22:32] fazer, is that when you still see the audio files? [22:33] ahayzen, it skips the walkthrough and then I see the albums page [22:33] with data on it? [22:33] with audio files in it [22:33] ah damn [22:33] yup [22:33] and your code has been pushed? [22:33] ahayzen, yup [22:33] ok, I'll branch the code and look [22:33] cool, i'll have a look in a bit [22:35] if you look at the blank_mediastore.sql file the location where I got an error I've put a comment above that line. It was a unique constraint failed error. I didn't know how to fix that so I jsut commented it out, but I'm assuming now that that line must have been important [22:35] ahayzen balloons ^ [22:35] fazer, ok i may get Victor on the case he understands the sql chaos :-) [22:36] alright. [22:36] I have to leave now. Have to attend a club meet. I can be back in 2 hours but I think you'll probably asleep by then because of the freaking difference in time. [22:37] haha we can comment on the code-in thing if we find anything :-) [22:39] ok thanks [22:39] I'm going to give it a try now [22:39] got my stuff pushed into everything finally [22:39] :-) [22:40] it was painful because of the renames [22:40] balloons, are you running on device or on desktop [22:40] bzr mv, git mv [22:41] ahayzen, I'll be writing / debugging on the desktop [22:42] ok cool [22:42] them we [22:42] we'll test on the device once it's done [22:42] then you don't have todo the mv Music .Music .. mkdir Music... reboot chaos [22:45] balloons : Are my READMEs to build wrong? Or is it a problem with my local environment? [22:45] Girish, I've no idea what is happening on your machine without a log [22:45] can you upload one to pastebin? [22:45] Okay. [22:46] It's just 2 lines. [22:46] well, It would be nice to know what you are running, how you are running it, the exact error, etc [22:46] ahayzen can comment more on what he thinks should allow the app to run [22:46] hehe :-) [22:48] So I cd into ubuntu-weather-app [22:48] Make a directory and change into it. [22:48] mkdir builddir && cd builddir [22:48] Then, [22:48] cmake .. && make -j3 [22:49] Then, [22:49] qmlscene ../app/ubuntu-weather-app.qml [22:49] $ bzr branch lp:ubuntu-weather-app $ cd ubuntu-weather-app // put the API keys in $ qmlscene app/ubuntu-weather-app.qml is what i do [22:49] Do I need the API keys if I need to test it? [22:50] Girish, i don't actually do the cmake, make part :-) as its pure QML there is nothing to compile [22:50] Girish, it should show the window and complain that you don't have a key [22:51] Okay. After that I do ../app/ubuntu-weather-app.qml [22:51] It shows Segmentation fault (core dumped) [22:51] and nothing else? [22:51] Nope. [22:51] and you have the uitk with uc1.3 ? [22:51] but that shouldn't error like that [22:52] I installed all the dependencies. [22:52] When commiting stuff, we never commit the files in po, right? (Unless you are adding translations, but aside from that) [22:53] Girish, they don't necessarily mean you have ubuntu.components 1.3 ... what is the platform you are on? [22:53] Vivide 15.04 [22:53] Vivid* [22:53] Girish, ah ok [22:53] so what i do is, have a branch of lp:ubuntu-ui-toolkit [22:53] Okay. [22:54] Girish, do a qmake and make of that ... then so $ source export_modules_dir.sh .. and then qmlscene /path/to/weather/app [22:54] Girish, see if that works [22:54] Okay. On it [22:55] mcinitreevan, if you have done a pull of trunk that you may need to commit the po's ... and sometimes when translations change you need to... depends what has happened ;-) [22:55] bah, this branch is giving me all sorts of trouble [22:56] Girish, btw vivid has ubuntu.components 1.2 or 1.1 IIRC from the package in the repository [22:57] It was complaining about not having uc 1.3. It didnt after I updated and installed everything from debian/control [22:57] hmmm [22:58] btw, my readmes are correct right? [22:58] they looked good at my initial check [22:58] Girish, was it already in markdown format? most of it looked like it was ? [22:59] Except the links and code snippets, pretty much [22:59] But it wasnt a .md file [22:59] yeah [23:01] Girish, ah so you're bit in the README.developers ... for weather should probably not say the buildir part ? [23:01] Girish, and i would mention the fact you need to get an API key in that file as well [23:02] balloons: since you're here now, would https://codein.withgoogle.com/tasks/5837926646677504/ require taking photos if I wanted to do the artwork aspect? [23:02] And no cmake make also right? [23:02] Girish, yeah its not required to run, as its pure QML [23:02] Girish, other projects will require it though [23:02] Okay I'll edit thoose 3 lines [23:03] Girish, you also mention it in the debugging bit as well [23:03] *mentioned [23:03] Yep, I see. I'm so new to all this. [23:04] its cool don't worry :-) [23:05] ahayzen, btw, music and mediascanner hate me now: what(): Tried to open a db with schema version 9, while supported version is 10. [23:05] balloons, you have to have the xenial mediascanner package [23:05] oh [23:05] yep [23:06] that's the otherway around [23:06] it's painful [23:06] its saying you have an older db that the package installed [23:06] balloons, when are you seeing that? [23:07] balloons, if thats when running the app, and you've just upgraded the package, you likely need to just manually rerun the mediascanner-service thing [23:07] (as any sane person has the service disabled on the desktop :') ) [23:08] downgraded [23:08] it's happy now :-) [23:09] hah :') [23:09] ok, it's running [23:09] but then autopilot won't run ;-) [23:09] as that has schemas 10 [23:09] balloons can you answer my question above? [23:09] no, no.. it's ok with 9 now [23:10] \o/ magic [23:10] adueppen, you want to generate or paint something? [23:10] go for it i'd say! [23:11] balloons: OK I was just looking at the wiki page for the Free culture showcase and it only mentioned photographic wallpapers for the art section [23:12] adueppen, I think it's ok to stretch things a bit. The hard and fast rule is it MUST be the proper resolution [23:13] balloons: OK [23:14] balloons: Is the free culture task gonna be around for awhile? I'd probably like to do it sometime, maybe once I re-learn Pillow to generate some neat stuff [23:15] mcinitreevan, yes it will be there [23:15] we'd love to see your submissions. Give it some pillow time! [23:15] ahayzen, ok I simplified things a bit [23:15] now, after everything indeed the 3 files are still showing [23:15] so I'm going to check the patch [23:17] balloons : ahayzen :Since my READMEs are correct(while in need for some minor fixing) why don't I submit the markdown-ed files and move on to the next task? Will that be fine? [23:17] Girish, is that all pushed in that branch ? [23:18] Girish, if so i'll check it in a bit after dinner then approve the task if its all cool [23:18] I'll push it once you say so. [23:18] yeah push your changes to the branch when you are happy, then i can review in the merge proposal [23:18] :-) [23:18] Ok, cool. Thanks! [23:21] Girish, if you want to you can put a comment in the merge proposal saying you have updated the branch, that is sometimes useful to the reviewers as it reminds them to rereview it :-) [23:24] Yknow before this I had never given the Ubuntu desktop a true shot - I use it on my VPS, of course, but I am super impressed by the desktop version [23:25] ahayzen, lol, got it [23:25] he's still copying over the other db [23:29] balloons, haha :-) [23:30] thoughht it would be something like that [23:30] fazer, ^^ [23:51] AttributeError: Class 'LibraryEmptyState' has no attribute 'isVisible'. [23:55] hah