| Robin_ | I got sent here from #ubuntu, as I reported my bug in the wrong place | 12:10 |
|---|---|---|
| Robin_ | I reported a bug a while ago on Launchpad and I even wrote a fix and included it in my bug report | 12:11 |
| Robin_ | But I did not receive a response to my bug report for almost 2 months now | 12:11 |
| Robin_ | This bug: https://bugs.launchpad.net/ubuntu/+source/software-center/+bug/1510237 | 12:12 |
| ubot5 | Ubuntu bug 1510237 in software-center (Ubuntu) "Software Center doesn't start on systems in Esperanto" [Undecided,New] | 12:12 |
| Robin_ | I just also uploaded the traceback and fixed Python file as an attachment, as I first used Pastebin links | 12:12 |
| hjd | Robin_: Hi | 12:25 |
| hjd | Robin_: Thanks for working on the fix. | 12:27 |
| hjd | I think what would help is if you could create a patch which displays how the changes apply to the file in question. That way, it is easier for reviewers to see what has changed rather than looking at the resulting method. | 12:28 |
| hjd | I'm not sure at the moment what is the current best-practices for patches, but have you worked with bzr branches before? | 12:29 |
| rbasak | hjd: I think the change is so trivial in this case it's OK to treat it as a patch rather than force Robin_ to have to learn the tools. | 12:29 |
| rbasak | I'm sure a committer will be happy to add the try/except if he is happy with it, without requiring a patch file to apply, since it is so simple. | 12:30 |
| hjd | Also, when submitting a patch, you can subscribe the team ubuntu-reviewers to the bug report so that they will be aware of it. (Though, it may still take som time before someone has time to look at it) | 12:30 |
| rbasak | hjd: are you triaging the bug or shall I? | 12:33 |
| hjd | rbasak: That's a fair point. Might be useful to know about for future patches ;) | 12:33 |
| rbasak | hjd: agreed. Useful to know :) | 12:33 |
| hjd | rbasak: Feel free. :) I don't have permission to mark it Triaged anyways. | 12:33 |
| Robin_ | hjd: I don't really know how to make a patch, I looked before online how to submit code, but it looked a bit too complicated for me. That is why I uploaded the code as a normal Python file. | 15:56 |
| Robin_ | Literally the only thing that is added is the try/catch and the whitespaces to indent the code | 15:57 |
| === ZeeNoodley is now known as Minori | ||
| === Minori is now known as kspencer | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!