| dholbach | good morning | 07:37 |
|---|---|---|
| davidcalle | Morning o/ | 08:27 |
| dholbach | salut davidcalle | 08:42 |
| davidcalle | Hey dholbach :) | 08:42 |
| dholbach | davidcalle: there's still a few things to be done, but I wanted to share my WIP: https://code.launchpad.net/~dholbach/developer-ubuntu-com/rework-importer/+merge/281183 | 08:44 |
| dholbach | some links are still broken | 08:44 |
| dholbach | but apart from that the importer works | 08:44 |
| davidcalle | dholbach: comments are stripped even when we don't use the editor? | 08:49 |
| davidcalle | (in rawhtml plugins) | 08:49 |
| dholbach | yes | 08:49 |
| davidcalle | dholbach: I'm about to make an import, should build-apps exist before launching it? Or do I just need Snappy and Guides? | 09:04 |
| davidcalle | dholbach: If I understand correctly, an import directive on a single file will write on the target page, and on a dir, will create subpages | 09:10 |
| dholbach | davidcalle: yes | 09:23 |
| davidcalle | A few things I'm noticing: please tell me if that matches your experience or if I've done something wrong: pages are not published when imported, pages such as HACKING.md or the parent page for the devel docs of snapcraft are named "Snapcraft" in the menu. | 09:26 |
| davidcalle | dholbach: ^ Other than this, I can't say how impressed I am by your tenacity on this front, seriously | 09:27 |
| dholbach | I had it on my TODO list for long enough :) | 09:30 |
| dholbach | and thanks for the flowers | 09:31 |
| dholbach | you helped out quite a bit with it as well | 09:31 |
| dholbach | I'd say if we're happy with testing and we get the links fixed, we should be good for deploying v1 :) | 09:31 |
| davidcalle | dholbach: the two points from above could be good to have for v1 as well, no? The publication issue has also the effect of not publishing changes when the importer runs again | 09:34 |
| davidcalle | I can work on both if you want, I'll just need a moment to wrap my head about these new classes | 09:35 |
| dholbach | davidcalle: I haven't quite figured out what the deal is with the publication status | 09:35 |
| davidcalle | dholbach: regarding pictures importing, it works ootb, right? Eg, the one in build-apps is hotlinked from https://rawgit.com/ted-gould/snapcraft/snapcraft-overview-diagram/docs/snapcraft%20overview.svg | 09:40 |
| davidcalle | dholbach: or is it something you special cased? | 09:40 |
| dholbach | no, it just worked, but I guess we'll need to add a test or two, just to be sure it works :) | 09:40 |
| dholbach | ah ok, here's why it works: | 09:43 |
| dholbach | README.md:[overview-image]: https://rawgit.com/ted-gould/snapcraft/snapcraft-overview-diagram/docs/snapcraft%20overview.svg | 09:43 |
| dholbach | the question is: what happens if you have a local image and try to use that :) | 09:43 |
| davidcalle | dholbach: right, nothing good :) | 09:51 |
| dpm | o/ | 14:03 |
| davidcalle | \o | 14:05 |
| dholbach | yo yo yo | 14:05 |
| davidcalle | dholbach: small branch fixing the translations-dashboard : https://code.launchpad.net/~davidc3/developer-ubuntu-com/translations-dashboard-1528618/+merge/281225 | 15:47 |
| dholbach | looking | 15:49 |
| davidcalle | dholbach, couldn't reproduce it locally, I've changed the code live on staging, works :) https://developer.staging.ubuntu.com/translations-dashboard/ | 15:49 |
| dholbach | very nice | 15:50 |
| dholbach | I should probably check in the importer if the HTML of updated articles actually changed... | 15:50 |
| dholbach | davidcalle: the "list-items" link 404s | 15:51 |
| dholbach | but that might be just an issue on staging(?) | 15:51 |
| davidcalle | dholbach what "list-items"? | 15:51 |
| dholbach | in any case the code looks good to me | 15:51 |
| dholbach | davidcalle: on https://developer.staging.ubuntu.com/translations-dashboard/ there's a link called 'list-items' | 15:52 |
| dholbach | a link to an article | 15:52 |
| dholbach | it points to https://developer.staging.ubuntu.com/apps/design-guide/building-blocks/list-items | 15:52 |
| davidcalle | dholbach: oh sorry, I was looking at my local instance | 15:52 |
| davidcalle | dholbach: yes, that's from a set of pages that were created, but never published (manual import of the app design guide), which makes me realize that I should exclude non-published pages from the list, they are just noise | 15:54 |
| dholbach | nice one! | 15:54 |
| davidcalle | dholbach: updated (haven't updated the live code, but I've tested locally: simply checking if not page.publisher_is_draft is enough to discard updates that are pending changes in draft) | 16:05 |
| dholbach | yep, sounds good | 16:07 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
