=== akhavr1 is now known as akhavr === akhavr1 is now known as akhavr [11:43] is anyone around that knows how to schedule another run of a feature branch? [11:44] I can find the "run-unit-tests-trusty-amd64" suite, and I can see it has a "Build Now" but I have no idea what goes into the "revision_build" string to make it actually work [11:44] I tried copying the content of other tests, and it doesn't seem to do what I want [15:56] To my old Juju colleagues, who may take a look into the channel:I wish you all a Merry Christmas, peaceful and happy days, and a lucky 2016. [15:58] Merry Christmas TheMue [16:06] Merry xmas to you TheMue [16:07] jam, jog would know [16:07] if you are still online [16:43] hi jam, which revision build did you want to see run-unit-tests-trusty-amd64 run against again? [17:03] alexisb, cherylj: I didn't see any update in the bug - just curious [18:24] heya frobware [18:25] jog thinks your patch is the right route [18:25] sorry I mean jam not jog [18:25] but unit tests are still pending [18:26] jog (and I really mean jog this time) is working through some maas issues in CI that are unrelated (we believe) to the bug [18:26] wwitzel3: if I haven't missed you, have a good flight and a good holiday season, and it's been great working with you [18:41] :( [18:41] ...or as we'll be calling him later "Wayne the Betrayer" [18:54] wayne 2.0 "the return"? [18:59] rick_h_: gotta be 4.0, he's already on v3 ;) [19:12] rick_h_: where are the screenshots? http://blog.jujugui.org/2015/12/23/juju-gui-2-0-beta-released/ === akhavr1 is now known as akhavr [19:25] Bug #1528932 opened: No images error when deploying services [19:41] ericsnow: you have reviews for all your open reviews [20:08] natefinch: thanks [20:11] natefinch: no ship-it on http://reviews.vapour.ws/r/3403/? [20:12] ericsnow: oh, I think I needed to go back and finish up. i'll reread it [20:12] natefinch: thanks! [20:27] man, I wish we didn't need a database type, an api type, a print-to-the-user type, and an everything-else type for each logical type in the system :/ [20:28] I know *why* we do it... but, damn, that's a lot of boilerplate [20:54] ericsnow: the fact that this function says it can return an error screws up like 10 levels of functions that need to check for errors... except this function can't ever fail. Why is it marked as returning an error? https://github.com/juju/juju/pull/3981/files#diff-c8d4587dc7a3c49893cdc913b08253ffR111 [20:56] natefinch: because I expect it to return an error in the future and I'd rather not deal with adding all the error handling later [20:57] it doesn't seem like the kind of thing that can possible fail. It's just wrapping state, which presumably at this stage, just exists === akhavr1 is now known as akhavr [21:03] ericsnow: YAGNI [23:44] Bug #1528971 opened: clientSuite.TestClientWatchAll unit test [23:44] Bug #1528975 opened: ClientValidationSuite.TestClaimLeaseName unit test [23:50] Bug #1528971 changed: clientSuite.TestClientWatchAll unit test [23:50] Bug #1528975 changed: ClientValidationSuite.TestClaimLeaseName unit test [23:53] Bug #1528971 opened: clientSuite.TestClientWatchAll unit test [23:53] Bug #1528975 opened: ClientValidationSuite.TestClaimLeaseName unit test