wallyworldanastasiamac: pretty please http://reviews.vapour.ws/r/3459/01:57
anastasiamacwallyworld: looking :D02:02
wallyworldanastasiamac: commeted02:12
wallyworldhopefully it makes sense02:13
anastasiamacwallyworld: looks awesome \o/ thank u - shipited it02:13
wallyworldyay :-) ty02:13
menn0axw: ship it02:33
axwmenn0: cheers02:33
menn0axw: of course, now I see that wallyworld beat me to it02:34
menn0oh well... double ship it02:34
wallyworldanastasiamac: CI should run structured metadata tests shortly, let's keep fingers crossed02:50
wallyworldaxw: anastasiamac: new laptop arrived :-D will be offline for a bit to swap hard drive and stuff02:52
axwwallyworld: excellent. enjoy02:52
wallyworldi will :-D02:52
natefinchaxw: are you familiar with this test? https://github.com/juju/juju/blob/controller-rename/featuretests/cmd_juju_controller_test.go#L11805:36
axwnatefinch: nope, maybe waigani or menn005:36
axwboth of whom are probably EOD now ...05:37
waiganiaxw hey, sorry I was having dinner06:32
axwwaigani: no problem, I don't think anybody expects you to work through dinner ;)06:33
waiganiaxw is there something up with that test?06:34
axwwaigani: no idea, sorry. all I know is that natefinch wants to know about it :)06:35
waiganioh right, hehe, I mis read comment - thought you were looking for me06:35
waiganiand he's gone - oh well. tomorrow is another day. He can catch me then.06:36
axwanastasiamac: FYI, https://github.com/juju/juju/pull/404207:54
anastasiamacaxw: looking :D07:58
mattywgood morning juju09:16
TheMuegood morning mattyw09:20
mattywTheMue, hey hey! You don't belong here ;)09:20
mattywTheMue, happy new year mate, how's it going?09:20
TheMuemattyw: it's a public channel, I'm still interested, so I never left :)09:21
TheMuemattyw: happy new year to you too.09:21
mattywTheMue, very happy to have you around, how's erlang?09:22
TheMuemattyw: technology at new job is fine, but the team is totally missing any kind of process or common habbits like iterations, retrospectives, reviews, etc.09:22
TheMuemattyw: it's a fight to push it into the right direction09:23
mattywTheMue, that's awesome - gives means you can implement it the way it should be done :)09:23
TheMuemattyw: got aware how good we're doing the job here at juju09:23
voidspacedimitern: you really need to run the git pre-push hooks09:36
voidspacedimitern: there's a Warningf call with no formatting directive on maas-spaces tip...09:36
dimiternvoidspace, oh is there..09:37
voidspacedimitern: corrected it in the branch I'm about to merge (the one you reviewed yesterday09:37
voidspacedimitern: :-p09:37
dimiternyeah I was meaning to set up the hook09:37
dimiternat least now with the new laptop I have no excuse like before - everything's much faster09:38
voidspacedimitern: your first comment on this review: http://reviews.vapour.ws/r/3457/09:39
voidspacedimitern: "please fix the imports grouping" - it looks to me like the grouping is correct09:40
voidspacedimitern: non juju/juju in one group and juju/juju separately09:40
voidspacedimitern: no - juju/testing is wrong09:40
voidspacedimitern: never mind09:40
mupBug #1531444 opened: azure: add public mapping of series->Publisher:Offering:SKU <juju-core:Triaged> <https://launchpad.net/bugs/1531444>09:48
mupBug #1531444 changed: azure: add public mapping of series->Publisher:Offering:SKU <juju-core:Triaged> <https://launchpad.net/bugs/1531444>09:51
dimiternah, so I did have pre-push hook, but the symlink was broken in .git/hooks/09:53
voidspacethat doesn't help09:53
dimiternnow I have it on and it did catch that warning09:53
mupBug #1531444 opened: azure: add public mapping of series->Publisher:Offering:SKU <juju-core:Triaged> <https://launchpad.net/bugs/1531444>09:54
dimiternvoidspace, dooferlad, frobware, when you have some time, I'd appreciate a review on http://reviews.vapour.ws/r/3462/09:56
dimiternit might be easier to also look at the PR's individual commits09:56
dooferladdimitern: https://github.com/juju/charm/pull/186 -- I hope this is what you wanted!11:43
dimiterndooferlad, cheers, looking11:44
dimiternuh oh "No description provided."11:44
* dimitern is surprised Storage .. `yaml: ",omitempty"` works for "storage: ..."11:47
dimiternI thought only bson lowercases the field names11:47
dooferladI think json and YAML parses both convert to lowercase on output and interpret lowercase as Title Case on input. Haven't tested it though. Not sure if all-caps becomes all lowercase.11:49
dimiterndooferlad, reviewed12:00
dimiternand please, add a PR description12:00
dimiterne.g. describing the added section with an example YAML excerpt?12:01
dimiterndooferlad, also, adding cards + PR link for that PR and the following 2 would be great12:03
dooferladdimitern: reviewed your pull request. Basically, I am on a TODO needs a bug or card quest at the moment.12:05
jamaxw: are you still around?12:05
jamI'm running into problems with maas 1.9 and KVM nodes not detecting storage during commissioning12:05
dimiterndooferlad, fair enough12:06
dooferladdimitern: Will catch up with cards later and get a decent description in. Lunch now.12:06
dimiterndooferlad, sure, np12:07
jamdimitern: have you seen ^^12:07
voidspacefrobware: dimitern: dooferlad: http://reviews.vapour.ws/r/3463/12:08
dimiternjam, I'm using KVMs on vmaas 1.9 all the time, and haven't seen that issue (even recently had to recommission all the nodes)12:09
dimiternvoidspace, looking12:09
dimiternjam, haven't yet tried 1.9.0 though - still on 1.9rc412:10
jamit might be fine on regular MAAS and it is a problem with storage detection on KVM instances.12:12
dimiternvoidspace, reviewed12:14
voidspacedimitern: ta12:14
voidspacedimitern: heh :-)12:15
voidspaceshould have done that already12:15
dooferladdimitern: could you help me out with what I am supposed to be doing next? I am not clear on what the next steps should be. Perhaps a hangout where we spec out some cards?14:05
dimiterndooferlad, sure, let's HO in like ~20m if you can?14:07
dimiternI just got some food14:08
dooferladdimitern: perfect.14:08
dimiterndooferlad, hey, I added 2 cards and tried to describe the next steps - can you see if that's enough for you to go on with it?14:27
dooferlad dimitern: yep14:28
dimiternif not, let's HO I guess14:28
dooferladdimitern: will have to actually dig into code before I can tell if there is enough info in those cards, but they look good14:34
dimiterndooferlad, sure14:34
dooferladdimitern: if you could mrege my changes (https://github.com/juju/charm/pull/186) that would be great. I don't have write access.14:35
dimiterndooferlad, I don't either, but mgz confirmed the charm repo is under the merge bot, so $$merge$$ will take care of it ... however - I've added one last comment14:39
dimiterndooferlad, sorry to be a pest, but "service wordpress wants to bind to endpoint foo to space bar, which isn't defined by the charm" needs rephrasing14:48
dooferladdimitern: ok14:48
dimiterndooferlad, e.g. to `service "wordpress" wants to bind endpoint "foo" to space "bar", which isn't defined by the charm`14:50
dimiterndooferlad, do you mind doing a follow-up for that?14:50
dimiternor something like that14:51
dooferladdimitern: sure14:51
dimiternthe important bit is to quote names so they stand up in the message14:51
dimiterndooferlad, maybe even ", but the endpoint is not defined by the charm" ?14:53
dooferladdimitern: yea, sounds good]14:54
dimiterndooferlad, tyvm14:54
dooferladdimitern: https://github.com/juju/charm/pull/18714:57
dimiterndooferlad, reviewed14:58
dooferladyou and your %q14:58
natefinch%q is one of my favorite features of Go :)14:59
dimitern:) it's from experience - looking at MBs of logs and trying to find an issue quickly15:00
perrito666natefinch: you are happy with little15:00
dimiterndooferlad, thanks15:02
natefinchperrito666: sometimes :)15:05
dooferladnatefinch: try "%# v" some time -- it will blow your mind.15:09
natefinchdooferlad: oh, I know :)15:12
natefinchdooferlad: but sometimes it's the little things that are nicest.  Like auto-quoting the parameters in a print string :)15:12
natefinchcherylj: got a fix for #1529126, I see your name on git blame, care to do a super quick and easy review? http://reviews.vapour.ws/r/3464/diff/#16:13
mupBug #1529126: cmdControllerSuite.TestControllerDestroy unittest <ci> <intermittent-failure> <test-failure> <unit-tests> <juju-core:Incomplete> <juju-core controller-rename:Triaged by natefinch> <https://launchpad.net/bugs/1529126>16:13
dooferladdimitern: https://github.com/juju/bundlechanges/pull/1516:16
dimiterndooferlad, looking16:17
dimiterndooferlad, LGTM16:22
cheryljnatefinch: sure, looking now16:24
cheryljah, this is the stuff waigani added for the undertaker work he did16:27
voidspacedimitern: heh, if you rename your maas default space you get warnings from the juju client16:29
voidspacedimitern: probably on every operation...16:29
voidspacemy default space is not called "default"16:29
natefinchvoidspace: such a noncomformist16:30
voidspacenatefinch: always! :-D16:30
dooferladmgz: https://github.com/juju/bundlechanges/pull/15 seems to be being ignored by the merge bot. Is it still under bot control?16:49
mgzit's the jujugui gating16:51
mgznot ours16:51
dooferladah, my mistake.16:52
mgzsee the previous prs for how that works16:52
mgz:shipit: I believe16:52
dooferladthought I had seen our bot, but maybe I just have too many github tabs open :-)16:52
dooferladmgz: thanks, that was it.16:57
marcoceppiI need help, upcoming demo to MS about new azure provider today, I can't bootstrap: http://paste.ubuntu.com/14422068/17:24
marcoceppikatco: do you know who I could bother about this^?17:29
katcomarcoceppi: hey, let me take a look at the pastebin. unfortunately this is axw's realm i believe17:32
marcoceppikatco: oh, axw is eod isn't he?17:32
katcomarcoceppi: he's asleep right now (aus)17:32
marcoceppiyup :(17:33
katcomarcoceppi: as an aside, best thing to do in these situations is ping vanguard in #juju on private network17:33
marcoceppiI can't get the old provider to give me the right instances and I seem to be having issues creating a networkcontroller17:33
marcoceppikatco: I think I need to finish reading the instructions17:34
katcomarcoceppi: ok. most interesting thing right now is the final error message. curious if you could manually do a put to this address with correct info: https://management.azure.com/subscriptions/776757db-9bc9-43bc-994e-761d0ce6c309/resourceGroups/juju-azure-west-environment-26ac52cb-0709-424a-891a-0e41adffbb8d/providers/Microsoft.Network/virtualnetworks/juju-internal?api-version=2015-05-01-preview17:35
marcoceppikatco: I need authorization17:35
katcomarcoceppi: (sad trombone)17:35
marcoceppikatco: but later in the release notes I notice it mention "registering components"17:35
marcoceppiand network is one of them17:35
marcoceppitrying that now17:35
* marcoceppi forces hand onto face17:37
marcoceppikatco: it's always when I ask for help, that I find the answer, I didn't have networking enabled on my account17:37
katcomarcoceppi: :) not a problem at all17:38
katcomarcoceppi: just glad it's working17:38
frobwarecherylj, can we do a quick HO to verify whether I see IP addrs being released in my 1.8.2 setup17:47
cheryljfrobware: sure:  https://plus.google.com/hangouts/_/canonical.com/maas1-8-2?authuser=017:48
frobwarecherylj, do we want a separate bug for the lack of gateway?18:11
frobwarecherylj, as you say, bug 1528217 is really about lack of DNS18:12
mupBug #1528217: 1.25.2 doesn't set up DNS information with MAAS <blocker> <ci> <maas> <network> <regression> <juju-core:Incomplete> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1528217>18:12
cheryljfrobware: good point.  I'll open one up for you, give me a few18:14
natefinchericsnow: in your review tyou say there can only ever be one of a resource, but that seems impossible.  Any time you upload a new revision of a resource, you'll by definition have at least two: the old one, which some of the units will still be using, and the new one, which the units will gradually switch over to.18:42
ericsnownatefinch: when you upload it replaces the one that was there18:42
natefinchericsnow: but units are still using that one18:43
ericsnownatefinch: ah, right, but that has not been addressed yet in the spec18:43
ericsnownatefinch: let's keep it simpler for now18:43
natefinchericsnow: I guess.  I'd bet money that we'll want the list sorted... and in fact, even in the spec right now, it appears that the resources from the store are sorted to the top, though of course that may just be coincidence.18:45
ericsnownatefinch: yeah, it may be that the store resources should be shown first18:46
ericsnownatefinch: for now let's just go unsorted and ask for clarification since it's ambiguous18:47
ericsnownatefinch: (mostly)18:47
natefinchericsnow: that's fine, it's vcs, I can always get the code back.18:47
ericsnownatefinch: exactly! :)18:47
ericsnownatefinch: I've done that a time or two :)18:47
natefinchman I hate that the format framework stuff uses interface{} and then immediately requires you to typeconvert to the since type it must be.18:48
natefinchericsnow: so about the FormattedCharmResource and FormattedSvcResource - I disagree that they're not structured data.  There's quite a bit of logic in the FormatSvcTabular function that needs to transform the structured data into unstructured text.  It's less true of FormatCharmTabular, but I'd have to be switching over a raw string in FormatSvcTabular for Origin at the very least.  Origin and DataType are enums, even in this data, it's only when t18:57
natefinchhey're output that we make them into strings.18:57
natefinchI do 100% agree that the lower() function should be in the formatter, not on the data types, though.18:58
ericsnownatefinch: I don't think the logic belongs in the outputter18:58
natefinchericsnow: isn't that the definition of what it's for?  Take this data and spew it out in a specifc way.18:59
ericsnownatefinch: its only job it to convert the formatted data into the output we desire18:59
natefinchyes. we need logic there to know how to merge logical columns into visible columns.18:59
ericsnownatefinch: it isn't to format the data items, but to present (combine) them in a particular way18:59
natefinchand we should be basing the logic of how to combine the columns on strongly typed data, not strings that happen to match some other string19:00
ericsnownatefinch: if the type matters then we should handle it in the formatter19:01
natefinchThe format struct defines the logic columns of data. The outputter uses those to decide how to output the actual columns.  Putting the logic of how to combine the columns in the format struct is mixing concerns.  The format struct shouldn't have logic. That's why I think you were right that the lower() functions belong in the outputter code, not on the struct's data types.19:03
perrito666marcoceppi: did you ever try to deploy openstack using lxd/lxc only? I recall you where doing something like that19:05
marcoceppiperrito666: wayne and paige were working on it, I never really got much into it19:06
perrito666mm, I might try to finish that, I am in need of an openstack19:06
natefinchI guess the question is, do you want the service resource's wacky revision/timestamp column printed out in json and yaml?  If yes, then it should be in the struct... I don't think it belongs there.19:07
cheryljalexisb, dimitern, frobware, it is worth noting that master has this problem as well, since the fix for bug #1483879 landed there as well19:16
mupBug #1483879: MAAS provider: terminate-machine --force or destroy-environment don't DHCP release container IPs <bug-squad> <destroy-machine> <landscape> <maas-provider>19:16
mup<sts> <juju-core:Fix Released by dimitern> <juju-core 1.24:Won't Fix> <juju-core 1.25:Fix Released by dimitern> <https://launchpad.net/bugs/1483879>19:16
frobwarecherylj, ack19:17
cheryljsince master is still in devel, we can probably get away with just noting the problem in the release notes.19:17
cheryljand not back out the fix.19:17
natefinchcherylj: ping on that review?19:18
cheryljnatefinch: yeah, I'm still looking.  For some reason, I've got a lot of meetings today :)19:18
natefinchcherylj: no problem, thought maybe you'd just forgotten to hit publish or something. No rush.19:19
cheryljnatefinch: just to sanity check - did you re-run the race check with your changes?19:20
natefinchcherylj: I did :)  But a very good question to ask.19:21
cheryljnatefinch: shipit!19:22
natefinchcherylj: yay, thanks! :)19:23
mupBug #1531589 opened: debug-log does not work with local provider on xenial + 1.25.0 <juju-core:New> <https://launchpad.net/bugs/1531589>19:32
mupBug #1531589 changed: debug-log does not work with local provider on xenial + 1.25.0 <juju-core:New> <https://launchpad.net/bugs/1531589>19:44
mupBug #1531589 opened: debug-log does not work with local provider on xenial + 1.25.0 <juju-core:New> <https://launchpad.net/bugs/1531589>19:47
natefinchericsnow: made a compromise on the enums - they're string enums now, so I can remove all the BS with making them a stringer and the marshal functions etc.  Really cleans up the code.  I wanted to keep them with specific named values however, so the logic in FormatSvcTabular can switch over real values.  Also, the conversion functions from resource to output is actually fairly valuable buffer to protect us from those values ever changing.20:32
ericsnownatefinch: how is the matter handled in "juju status"?20:34
natefinchericsnow: let me go find the right code under the status component.... OH WAIT.20:35
ericsnownatefinch: haha20:35
natefinchericsnow: which is to say: it'll take me a big to find the right bit of code20:35
ericsnownatefinch: cmd/juju/status/tabular_output.go20:36
perrito666natefinch: if it makes you feel better, even if status where a component, it would still suck20:37
natefinchme: who the heck wrote this?  <git blame>20:39
natefinch2a763456 (Eric Snow         2015-07-28 09:41:01 -0600  32)      p := func(values ...interface{}) {20:39
perrito666* blame is destroying friendships since forever20:41
katconatefinch: =|20:43
natefinchanyway.... :)20:43
perrito666wait until it degenerates into blame hunts20:44
natefinchhonestly, I think git blame has like a 30% chance of coming up eric just based on line count alone20:44
perrito666git blame lies though20:45
natefinchyeah, true true20:45
perrito666if eric moved the line it will blame him20:45
natefinchmerges and stuff20:45
natefinchericsnow: the answer is... I don't know.  I don't really see any enums in the status structs... but maybe some of them are and I just can't tell because someone made them into raw strings. :D20:46
ericsnownatefinch: I'm (just) guessing that the formatter did all the work :)20:47
perrito666I might help you there, what is the problem?20:47
natefinchperrito666: I have a status struct that has enums, because one of the formatters needs to perform some logic to determine what to output... and I didn't want to have a switch that compared raw strings to some magic values.20:50
natefinchperrito666: http://reviews.vapour.ws/r/3445/#comment2110120:52
natefinchperrito666: I've simplified the code somewhat since that, to make Origin and DataType into typed strings, so we can drop the marshal crap.  But eric thinks they should just be raw strings20:53
ericsnownatefinch: I still think the formatter should be in charge of the logic stuff that outputters need20:54
perrito666natefinch: I am going to side with eric in this one20:55
perrito666status is already a nightmare to follow20:55
perrito666if you add that generate magic, even though it is nice, it will be impossible20:55
natefinchperrito666: no no... I've simplified it... let me push my changes20:55
ericsnownatefinch: e.g. the formatter sets a "HasRevisionNumber" field to true20:56
natefinchericsnow: I guess if you then mark those as not getting serialized to yaml/json...  just seems like, if you do all that, then the outputter is just determining the column names and what columns to output.... I guess I just expected to separate the data and the view in different spots.  This seems like it's lumping all the views together in with the data.21:00
ericsnownatefinch: my understanding is that the outputter is just in charge of spitting out the data it's been given (or a subset) in some particular output format21:01
ericsnownatefinch: the issue here is the "subset" part21:01
ericsnownatefinch: you're saying that the formatter should render all the info the outputter needs to do its job21:02
ericsnownatefinch: I agree with that21:02
ericsnownatefinch: I'm arguing for explicitly providing the info and you are arguing for piggybacking on some of the formatted data (which is reasonable)21:03
ericsnownatefinch: this is all relative to what we are already doing: check for magic strings in certain fields in the outputter to make the decision21:05
ericsnownatefinch: I agree that sort of implicit knowledge is problematic21:05
ericsnownatefinch: so let's make it explicit with extra fields in the formatted data21:06
ericsnownatefinch: if you are worried about JSON/YAML, then don't export the extra fields21:06
ericsnownatefinch: if they aren't exported then the marshalers ignore them21:07
natefinchericsnow: right...21:07
natefinchI still think it's merging the views in the wrong spot.... but it sounds like this is just the way they work, so I'll move those tabular columns into nonexported fields in the struct.21:08
ericsnownatefinch: thanks!21:09
perrito666the lxd provider works?21:26
* perrito666 does not feel like deploying a full openstack by hand21:26
natefinchperrito666: yes it works21:29
natefinchperrito666: it requires a few manual steps right now, which are detailed in the default environments.yaml output21:29
natefinchperrito666: (a few one-time manual steps)21:36
perrito666I guess it is behind a flag right?21:37
natefinchperrito666: you need to compile with go 1.3 or higher21:41
perrito6661.5 should be enough21:41
natefinchperrito666: indeed21:41
natefinchperrito666: there's no feature flag21:42
=== ses is now known as Guest1092
=== sinzui_ is now known as sinzui
perrito666well, EOD22:20
axwmarcoceppi: are you awake still?22:26
axwmarcoceppi: you need to add features to your account... I think it's in the release notes, lemme check22:26
katcoaxw: i think he figured it out22:26
axwthanks katco22:27
katcoaxw: he did indeed have to add a feature to his account22:27
axwyup, I also needed to keep reading :)22:27
katcoaxw: lol!22:27
marcoceppiaxw: yeah, I stopped reading the instructions23:32
marcoceppiaxw: when I finished reading them, I found what I needed23:32
axwmarcoceppi: goodo :)  did it all work ok after that?23:32
marcoceppiaxw: so far so good. I was able to deploy to Standard_D12 instances which the old provider didn't allow23:33
axwmarcoceppi: cool23:33
marcoceppiaxw: I've got a problem23:52
marcoceppiaxw: juju expose with the new ARM doesnt' seem to work23:52
axwmarcoceppi: https://bugs.launchpad.net/juju-core/+bug/152768123:53
mupBug #1527681: azure provider does not appear to be opening ports <juju-core:Fix Committed by axwalk> <https://launchpad.net/bugs/1527681>23:53
marcoceppiwell that puts a damper onthis demo23:53
axwmarcoceppi: can you build off master?23:54
marcoceppiaxw: it takes 20 mins to deploy and I have a demo in 30 :)23:55
marcoceppiaxw: I'm going to poke a few holes manually23:55
axwmarcoceppi: :/23:55
marcoceppiif I can figure out how23:55
axwmarcoceppi: you'll need to create rules in the network security group23:56
marcoceppiaxw: found them, thanks23:57
marcoceppiaxw: I'll build from master next time23:57

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!