| wgrant | xnox: http://people.ubuntuwire.org/~wgrant/rebuild-ftbfs-test/primary-xenial-s390x-release.html | 00:20 |
|---|---|---|
| wgrant | (shows a package only if it has an FTBFS in release, but will also show proposed for the package if it exists) | 00:25 |
| wgrant | cjwatson: What is conceptually odd about https://code.launchpad.net/~cjwatson/launchpad/ppa-admins-private/+merge/281647? | 00:27 |
| cjwatson | wgrant: just the way I had to use launchpad.Moderate as a spare permission | 00:28 |
| cjwatson | wait, that was a different MP | 00:29 |
| cjwatson | wgrant: ok, I think I just meant that setting privacy is not quite what I'd originally envisioned PPA admins as doing | 00:29 |
| cjwatson | but it seems acceptable | 00:29 |
| wgrant | The original idea of ppa-self-admins was that they have commercial-admin privs but only over PPAs they own, so it makes sense to me. | 00:30 |
| wgrant | I don't know how I missed the breakage. | 00:30 |
| cjwatson | I probably just didn't understand it quite well enough. | 00:31 |
| wgrant | cjwatson: Does my comment on https://code.launchpad.net/~wgrant/launchpad/reject-not-accepted/+merge/281435 satisfy you? | 00:31 |
| cjwatson | wgrant: Yes - commented | 00:37 |
| wgrant | Thanks. | 00:38 |
| wgrant | Yeah, the test is weird. | 00:38 |
| wgrant | was, rather. | 00:38 |
| cjwatson | Thanks for the db-git-recipe review, will look tomorrow. I have the corresponding code branch nearly done. | 00:38 |
| wgrant | "We rely on it to not store, so let's test that it is stored" | 00:38 |
| cjwatson | Just need to do matrix branch/gitrepository testing for the existing sourcepackagerecipe tests | 00:39 |
| cjwatson | And split it up into reviewable-sized pieces | 00:39 |
| cjwatson | (it's about 1300 lines at the moment) | 00:40 |
| wgrant | Not too bad. | 00:40 |
| wgrant | How much of git-build-recipe is lifted from bzr-builder, or is it a rewrite? | 00:40 |
| cjwatson | Initially lifted, with relatively extensive "porting". | 01:14 |
| cjwatson | If you look at the structure it's pretty similar, which was because I doubted I'd get it to be compatible otherwise. | 01:14 |
| cjwatson | Just as well since I only noticed in the last couple of days that LP expects to be able to use bzr-builder to parse recipes directly. | 01:15 |
| cjwatson | But I started by copying it and then mangling until it worked, basically. | 01:15 |
| xnox | wgrant, \o/ thank you | 09:57 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!