| dholbach | good morning | 07:53 |
|---|---|---|
| davidcalle | Good morning o/ | 08:41 |
| dholbach | davidcalle: I've been banging my head against the wall because of issues in the tests and I started refactoring all kinds of small things in order to make things clearer | 10:17 |
| dholbach | all to no avail | 10:18 |
| dholbach | now I found the issue | 10:18 |
| davidcalle | dholbach: what is it? | 10:18 |
| dholbach | sys.exit is to be avoided at all costs :) | 10:18 |
| dholbach | no big surprise | 10:18 |
| dholbach | I'll fix it now | 10:18 |
| dholbach | it stopped test cleanup functions to be run and other stuff | 10:18 |
| dholbach | I should have fixed it long ago | 10:19 |
| davidcalle | dholbach, ouch :) | 10:23 |
| davidcalle | dholbach, btw, we don't need to fix ubuntu-sdk -> ubuntu-sdk-ide on d.u.c, it's going to keep working | 10:23 |
| dholbach | ok cool | 10:23 |
| dholbach | mh, that was not it... | 10:59 |
| dholbach | I mean... good that I fixed it in any case | 10:59 |
| dholbach | but still I'm seeing some bizarre issues which lead me to believe that the cleanup is not done in between tests | 11:00 |
| dholbach | if you are curious and bored, I pushed a WIP branch to ~dholbach/developer-ubuntu-com/rework-importer | 11:07 |
| dholbach | I think I'll take a lunch break soon and see if I can fix this afterwards :) | 11:07 |
| dholbach | davidcalle: I found the issue /o\ | 14:54 |
| dholbach | I'm very close to having it all working again | 14:54 |
| dholbach | I learnt a lot :) | 14:54 |
| davidcalle | dholbach, what was it!? | 14:54 |
| dholbach | I was surprised how my testcase objects event across different tests were sharing data - it took me a long while to find that I had defined some class members somewhere in the code as class variables | 14:56 |
| dholbach | davidcalle: it's fixed | 15:43 |
| dholbach | davidcalle: all tests pass | 15:43 |
| dholbach | finally | 15:43 |
| dholbach | ok... where was I before I broke everything.......... | 15:43 |
| davidcalle | dholbach: iirc, I was reviewing and about to merge :D | 15:43 |
| dholbach | davidcalle: I'll add some more link rewrite tests | 15:44 |
| dholbach | davidcalle: I call it a day - I pushed a new test for the links, but it doesn't pass | 17:14 |
| dholbach | django.test.Client doesn't quite work the way I imagine it does :-) | 17:15 |
| davidcalle | dholbach, you fight with Django, I fight with Mojo :p | 17:15 |
| dholbach | in some cases a page it retrieves (/docs/intro.md which is obviously wrong) is available, after a redirect, but is empty | 17:15 |
| dholbach | it's all bizarre and I don't know which part of this strange reality to hold on to | 17:16 |
| dholbach | in any case I think it's a good time to call it a day and come back with fresh ideas on a Monday :) | 17:16 |
| davidcalle | dholbach, have a nice week-end, we'll do our best to release this to the word next week :) | 17:17 |
| dholbach | :-) | 17:17 |
| * dholbach hugs davidcalle | 17:17 | |
| dholbach | have a good one yourself! | 17:17 |
| * davidcalle hugs dholbach, thanks! | 17:17 | |
| dholbach | :) | 17:18 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!