| === salem_ is now known as _salem | ||
| adueppen | would anyone here feel it's a bit unethical to do https://codein.withgoogle.com/tasks/5458583860805632/ since I'm going to attend the ubuntu wisconsin monthly meeting whether I claim the task or not? | 01:33 |
|---|---|---|
| xcub | not really, even though you're going to the meetup regardless, no one's going to blame you for getting a little credit :) | 01:56 |
| darkxst | adueppen, I would say that is fine, the whole point of this competition is to participate in the community, and the mentors won't know you went to the meetup if you don't claim it! | 09:48 |
| DanChapman | Girish, hey! sorry had to shoot off yesterday. did you get dekko running ok in the end? | 10:34 |
| MatthewAllen | balloons, was the task "Remove Hello username link from QA Tracker" ever completed or fix? As it is still active on the bug tracker and I am going to have a look at fixing it, however the task I cannot find the task on CodeIn anymore. | 11:23 |
| Girish | DanChapman: Yep. Now where\what do I start next? | 11:26 |
| DanChapman | Girish, excellent. So first off you probably want to get the "Include me in replies" switch in place and stored it's value in the configuration file. I'd say for now stick it under the "Add identity" option in account settings. You also need to add a property to Dekko::Settings::Preferences in src/app/Settings.h to store & reload the value | 11:32 |
| DanChapman | Preferences is attached to the Account object available in that account settings page. So you can access it with account.preferences | 11:33 |
| DanChapman | Girish, actually Preferences settings are applied to all accounts so sticking it there isn't going to work. Hmmm..... stick the property in SmtpSettings instead for now. | 11:41 |
| DanChapman | also in src/app/Settings/Settings.h | 11:42 |
| MatthewAllen | balloons, had a play around with the 404 coming from the user management page, have a look at https://code.launchpad.net/~whosdaz/ubuntu-qa-website/fix1194770/+merge/282091 - not 100% sure if it was what was wanted, so just checking with you :) | 11:48 |
| Meverynoob | hi | 12:50 |
| Meverynoob | erm | 12:50 |
| Meverynoob | emergency ._. | 12:50 |
| Meverynoob | my task is about to expire in 30 minutes' time | 12:50 |
| Meverynoob | sorry to disturb | 12:50 |
| Meverynoob | but right now I can't complete my task | 12:51 |
| Meverynoob | it is simply to install ubuntu calculator and run all testsuites | 12:51 |
| Meverynoob | however the qml testing is not working | 12:51 |
| Meverynoob | for unit testing | 12:51 |
| Meverynoob | please help | 12:52 |
| Meverynoob | ctest keeps saying no tests found | 12:52 |
| MatthewAllen | Meverynoob, are you sure you are inside the directory? | 12:52 |
| MatthewAllen | you may me in your home directory, and thus it wont detect the tests | 12:53 |
| Meverynoob | I am inside the directory | 12:53 |
| Meverynoob | in fact I already ran the autopilot testing | 12:53 |
| Meverynoob | im in the unit directory now | 12:53 |
| MatthewAllen | who are the mentors on the task? You may want to message them. | 12:53 |
| Meverynoob | not sure if that's still feasible in 30 minutes | 12:53 |
| MatthewAllen | who is it, you can probally get them on IRC | 12:54 |
| Meverynoob | Carla Sella Alan Pope Samsruti | 12:54 |
| MatthewAllen | popey, ^ | 12:54 |
| Meverynoob | ping popey | 12:55 |
| Meverynoob | but well | 12:55 |
| Meverynoob | in the scenario he doesn come | 12:55 |
| Meverynoob | do you know how to solve this? | 12:55 |
| MatthewAllen | so are you running it using the command 'ctest' in terminal? | 12:56 |
| Meverynoob | i tried | 12:56 |
| Meverynoob | also tried qmltestrunner | 12:56 |
| Meverynoob | both returned that no tests were found | 12:56 |
| MatthewAllen | If so you need to be in the "ubuntu-calculator-app" root directory, NOT the tests or unit directory | 12:56 |
| MatthewAllen | give me and second and I'll grab the source | 12:57 |
| Meverynoob | still no | 12:57 |
| Meverynoob | thanks so much! | 12:57 |
| MatthewAllen | what is the exact output when you run that? | 12:57 |
| Meverynoob | Test project /home/meverynoob/Downloads/trunk No tests were found!!! | 12:58 |
| Meverynoob | the name trunk is the branch i got through ubuntu sdk | 12:58 |
| Meverynoob | its the same thing | 12:58 |
| Meverynoob | if i run qmltestrunner in the tests/unit directory | 12:58 |
| Meverynoob | qmltestrunner: could not exec '/usr/lib/x86_64-linux-gnu/qt4/bin/qmltestrunner': No such file or directory | 12:59 |
| Meverynoob | this is what I get | 12:59 |
| Meverynoob | I retyped well over 10 times | 12:59 |
| Meverynoob | this isnt working | 12:59 |
| Meverynoob | I tried to update all my qml related software but that didnt work either | 12:59 |
| MatthewAllen | what readme is reffering to Ctest? I can only find Autopilot | 13:00 |
| Meverynoob | the one that says README-unitttest | 13:00 |
| Meverynoob | I was about to wrap up this task | 13:01 |
| Meverynoob | till I saw that document | 13:01 |
| MatthewAllen | you may run the autopilot tests and the qml test seperatly | 13:01 |
| Meverynoob | and then now I'm here | 13:01 |
| Meverynoob | huh? | 13:01 |
| Meverynoob | I've already ran the autopilot tests | 13:01 |
| Meverynoob | the qml test is the only thing left | 13:01 |
| MatthewAllen | Do you have to ubuntu sdk installed? | 13:02 |
| Meverynoob | yes | 13:03 |
| MatthewAllen | hmmm, I'm not 100% sure then - You'll have to wait for Popey to give you a hand - have you said anything on the CodeIn task itself? | 13:03 |
| Meverynoob | not yet | 13:04 |
| MatthewAllen | I'd do that before it expires, they'll get notified as soon as you write something there | 13:04 |
| Meverynoob | yea | 13:05 |
| Meverynoob | just wrote it there | 13:05 |
| Meverynoob | thanks for the effort | 13:05 |
| Meverynoob | ping @popey | 13:05 |
| MatthewAllen | awesome, goodluck then - sorry I couldn't help | 13:05 |
| Meverynoob | its ok | 13:05 |
| Meverynoob | popey please | 13:09 |
| knome | Meverynoob, please, asking again and again isn't going to help | 13:14 |
| knome | Meverynoob, if you have commented what you have done on the task, and what you couldn't do, it'll be fine | 13:15 |
| Meverynoob | if you had 11 minutes to get an online admin to respond, for a matter as trivial as this, in my opinion | 13:17 |
| Meverynoob | it probably could | 13:17 |
| knome | nope; if he's available, he has seen the ping and/or the email already | 13:18 |
| Meverynoob | it seems i havent built the app in ubuntu sdk yet | 13:21 |
| Meverynoob | shucks | 13:21 |
| Meverynoob | not sure if thats gonna be an issure | 13:21 |
| Meverynoob | issue | 13:21 |
| robbert | darkxst, are you here? :) | 13:21 |
| Meverynoob | welp | 13:26 |
| Meverynoob | there goes | 13:26 |
| Meverynoob | I'll just reclaim it the moment its gone | 13:27 |
| popey | hey | 13:30 |
| popey | sorry, I'm busy cooking lunch | 13:31 |
| popey | will take a look after I'm done | 13:31 |
| knome | popey, maybe just extend the time by a few hours would be fine | 13:31 |
| popey | link? | 13:31 |
| knome | Meverynoob, ^ | 13:31 |
| popey | thanks for the ping | 13:31 |
| popey | oh, found it, I have a mail/comment | 13:31 |
| knome | good | 13:32 |
| knome | and bon appetit :) | 13:32 |
| popey | added some time | 13:32 |
| popey | thanks :D | 13:32 |
| Meverynoob | woah | 13:32 |
| Meverynoob | just in time | 13:33 |
| popey | :) | 13:33 |
| * popey disappears again | 13:33 | |
| Meverynoob | hey er | 13:34 |
| Meverynoob | popey | 13:34 |
| Meverynoob | if you dont mind | 13:34 |
| Meverynoob | could you help me with my task? | 13:34 |
| Meverynoob | after youre done with your lunch and all of course | 13:34 |
| Girish | DanChapman: Ok, lets begin. | 15:25 |
| DanChapman | :-) | 15:27 |
| Girish | So I need to add a property in the SmtpSettings class. | 15:30 |
| Meverynoob | ping popey | 15:32 |
| DanChapman | Yep and store via the classes save & reload slots. You might need to add a settings key to Dekko::SettingsNames | 15:32 |
| Girish | Every setting in SettingsNames is of the data type QString. I need a bool right? | 15:35 |
| Girish | Ohh this is the name' | 15:36 |
| Girish | And names a re strings | 15:36 |
| DanChapman | Yes they are your settings keys (names). and the settings values take any QVariant. Take a look in ~/.config/dekko.dekkoproject.conf to see how they get stored. Should make a bit more sense then :-) | 15:39 |
| ahayzen | Meverynoob, i don't work on Calculator but it looks like they don't have any (working) Unit tests in trunk ? http://bazaar.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/trunk/files/head:/tests/unit/ | 15:39 |
| ahayzen | even that hellocomponent test has an import which points to a directory that doesn't exist | 15:40 |
| DanChapman | oops sorry that should of been ~/.config/dekko.dekkoproject/dekko.dekkoproject.conf | 15:40 |
| Girish | Having a look! | 15:41 |
| Meverynoob | really? | 15:41 |
| Meverynoob | but i thought there was the one tst_hellocomponent? | 15:41 |
| Meverynoob | oh | 15:42 |
| Meverynoob | ok | 15:42 |
| Meverynoob | but in any case | 15:42 |
| ahayzen | Meverynoob, that looks the same as the example Qt one, so i don't think that is maintained... | 15:42 |
| ahayzen | Meverynoob, check with your mentor, but if you have done the autopilot testing then i think that'll be enough for the testing part | 15:42 |
| Meverynoob | i'm also not sure if there is a missing file in the repository | 15:42 |
| Meverynoob | i tried to import it in ubuntu sdk | 15:43 |
| Meverynoob | but it needed to create a cbp file | 15:43 |
| Meverynoob | thanks for the heads up | 15:43 |
| Meverynoob | i have no idea what a cbp file is, i'll go ask on the tasksite | 15:45 |
| Meverynoob | im gonna sleep now | 15:45 |
| Girish | DanChapman: So the setting should be something like msa.smtp.<nameOfSetting> = true/false | 15:47 |
| DanChapman | hmmm not sure... were just putting it in SmtpSettings (i.e msa.smtp) for now as it isn't worth creating a whole new settings class for one property. As the identities evolve more properties will come. How about "identities.includeInReplies=bool"? | 15:50 |
| Girish | Yeah that will be better. | 15:51 |
| Girish | So it should be something like const QString SettingsNames::includeInRepliesKey = QLatin1String("identities.includeInReplies"); in the dekko namespace? | 15:59 |
| Girish | DanChapman ^ | 16:00 |
| DanChapman | Yup, looks good :-) | 16:00 |
| Girish | And the .config is something which is created evertime the app is run right? I don't have to insert identities.includeInReplies=bool manually myself, right? | 16:02 |
| Girish | DanChapman ^ | 16:04 |
| DanChapman | Yeah that file is autocreated if it doesn't already exist. You just need to implement m_settings->setValue(YourKey, bool_value) in the save function to store it | 16:05 |
| Girish | I've added static const QString includeInRepliesKey in struct SettingsNames. | 16:07 |
| Girish | DanChapman: DanChapman Where do I find this save function? | 16:12 |
| Girish | in settings.cpp? | 16:13 |
| DanChapman | It's in the SmtpSettings class https://git.launchpad.net/dekko/tree/src/app/Settings/Settings.cpp#n612 | 16:13 |
| DanChapman | yeah | 16:13 |
| Girish | I should edit the bool SmtpSettings::save() class right? | 16:14 |
| DanChapman | Yep and it needs to go between the m_settings->beginGroup() & m_settings->endGroup() calls | 16:15 |
| Girish | DanChapman: Okay since the default value is 'true' should I do m_settings->setValue(Dekko::SettingsNames::includeInRepliesKey, true);? | 16:17 |
| Girish | Or should I construct an If-else construct to check the value? | 16:18 |
| Girish | statement* | 16:19 |
| DanChapman | The default should actually be false for this, and the user should "opt-in" to being included. But anyway your going to need a member variable to store the value in. bool m_includeInReply or something like that. You set the initial default value in the reload function. something like m_includeInReply = m_settings->value(MyKey, false).toBool() have a read of the QSettings docs to see how that works :-) | 16:22 |
| Girish | DanChapman: Link to QSettings docs? | 16:44 |
| Girish | Where should this bool m_includeInReply be declared so that it remains global? | 16:45 |
| DanChapman | Girish, you'll want to declare it in the private: section in the header file of the SmtpSettings class. Then initialise it in the constructor. | 20:04 |
| DanChapman | oh and http://doc.qt.io/qt-5/qsettings.html | 20:04 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!