/srv/irclogs.ubuntu.com/2016/01/11/#launchpad-dev.txt

cjwatsonWow, you get amazingly long test output if you try to @provider something that you forgot to make a subclass of Interface13:22
wgrantHeh, what is the bulk of it?13:22
wgrantZCML spam?13:23
cjwatsonIn this case, TypeErrors reporting duplicate enumerated types from everything else that imports the module in question13:23
wgrant... nice.13:23
cjwatsonI'm not sure I can actually do this though.  I was trying to turn SourcePackageRecipeData into a <securedutility> so that I could use its getParsedRecipe staticmethod from browser code, but its __init__ takes arguments ...13:24
wgrantcomponent= rather than class=.13:25
cjwatsonAha13:25
cjwatsonOf course, thanks13:26
cjwatsonMaybe in fact just a <utility> since RecipeBranch doesn't have a corresponding Zope interface13:27
cjwatsonwgrant: db-git-recipes> you got me on indexes, but why does it need deletion handling in the DB patch?  there's no such handling for base_branch, and I was going to add it to GitRepository._getDeletionRequirements (which, yes, has the same "somebody else creates a recipe that you can't delete" as for Branch, but it's not a new problem, and deleting repositories is less frequent than deleting branches anyway)13:44
wgrantcjwatson: Hm, how does base_branch get around the branch deletion tests?13:46
wgrantThere is at least a test that lists all FKs.13:47
cjwatsonwgrant: That test whitelists SPRD.base_branch13:48
cjwatsonExactly because of the explicit deletion handling for recipes in Branch, I'd assume13:48
cjwatson(Also sourcepackagerecipedatainstruction.branch)13:49
cjwatsonAnd there's no equivalent of that FK listing test for Git at the moment13:50
wgrantSounds acceptable, then.13:51
cjwatsonOK, I'll fix the indexes.13:54
wgrantThanks.13:54
cjwatsonDown to 25 failing recipe tests at the moment ...13:54
wgrantAre you parsing Git recipes with bzr-builder, or switching implementations?13:54
cjwatsonThe former, with a small hack.13:54
wgrantExcellent.13:55
cjwatson(Hack: Git recipes may start with either "# bzr-builder" or "# git-build-recipe", the former for compatibility and the latter because otherwise it looks rather WTF to people who don't know the history.  But bzr-builder won't accept the latter, so we have to munge it.)13:56
cjwatsonwgrant: Could you sort out your pending QA?  I'd like to be able to deploy.18:43
=== ajmitch_ is now known as ajmitch
wgrantcjwatson: Oh, sorry, forgot about that.21:15
wgrantcjwatson: QA is clear.21:47

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!