| darkxst | jose, can you publish https://codein.withgoogle.com/dashboard/tasks/6308179252084736 | 03:40 |
|---|---|---|
| jose | darkxst: is this for ubuntu gnome? | 03:43 |
| darkxst | jose yes | 03:43 |
| jose | all set | 03:43 |
| darkxst | jose, thanks | 03:43 |
| jose | np | 03:43 |
| darkxst | jose, and another: https://codein.withgoogle.com/dashboard/tasks/6588980468383744 | 03:51 |
| jose | published! | 03:52 |
| adueppen | does anyone here have access to https://errors.ubuntu.com ? I need access to a report on it for a task and don't feel comfortable with requesting access at this time. | 03:57 |
| darkxst | adueppen, yes | 03:57 |
| adueppen | darkxst: would you be able to give me the information on https://errors.ubuntu.com/problem/e42912698bfcf8ccef0d970f37ca3d6a021d47aa ? | 03:58 |
| adueppen | also the website keeps freezing on me which doesn't help with requesting access | 03:59 |
| darkxst | adueppen, the stacktrace is incomplete, but I will paste it for you | 03:59 |
| adueppen | darkxst: thanks. was there any other information on steps to reproduce? | 04:00 |
| darkxst | the error tracker just contains the crash reports, but it is linked to https://launchpad.net/bugs/1531018 | 04:01 |
| darkxst | maybe info in there? | 04:01 |
| ubot93 | Launchpad bug 1531018 in thunar (Ubuntu) "/usr/bin/thunar:11:exo_icon_view_get_item_needed_size:exo_icon_view_scroll_to_item:exo_icon_view_move_cursor_up_down:exo_icon_view_real_move_cursor:_exo_marshal_BOOLEAN__ENUM_INT" [Undecided,New] | 04:01 |
| adueppen | darkxst: that's the bug I'm looking at, all it really has is a link to that error report | 04:02 |
| darkxst | adueppen, look at the stacktrace I sent you (not that it will help reproduce it!) | 04:02 |
| adueppen | darkxst: hmm looks a bit like it's something with the tooltip for when you hover the mouse over folders on the desktop, but I can't seem to get a crash out of it. looks like I'll have to pick another bug to try and confirm | 04:05 |
| darkxst | adueppen, its crashing in the callback, see if you can find what fires that! | 04:08 |
| adueppen | darkxst: seems to be either <exo_icon_view_real_move_cursor> or __FUNCTION__ = "_exo_marshal_BOOLEAN__ENUM_INT" | 04:10 |
| darkxst | there will be some signal or so connected to exo_icon_view_real_move_cursor | 04:11 |
| adueppen | darkxst: hmm I might just go with a different bug since the task is to confirm a bug in Thunar | 04:14 |
| darkxst | ok | 04:14 |
| MatthewAllen | anyone know where I can find Flocculant on IRC? | 05:16 |
| wxl | MatthewAllen: he's usually on ubuntu-quality | 05:17 |
| wxl | MatthewAllen: he has been idle for 11 hours though, so that's not great :) | 05:18 |
| MatthewAllen | wxl, ahhh - it' | 05:19 |
| MatthewAllen | it's not urgent, so I'm not worried | 05:19 |
| Girish | balloons: Left a few comments on https://codein.withgoogle.com/dashboard/task-instances/5458917932924928/?sp-page=1 | 11:05 |
| === _salem is now known as salem_ | ||
| Girish | darkxst: I'm trying to set an environment for Ubuntu Packaging. | 12:06 |
| Girish | When I run sudo sbuild --dist=vivid --arch=amd64 -c vivid-proposed+restricted-amd64-sbuild | 12:06 |
| Girish | I get the following errors: tail: cannot open '/home/girish/debian/changelog' for reading: No such file or directory | 12:07 |
| Girish | dpkg-parsechangelog: error: tail of /home/girish/debian/changelog gave error exit status 1 | 12:07 |
| Girish | E: Could not parse /home/girish/debian/changelog: | 12:07 |
| darkxst | Girish you need to give it something to build! | 12:07 |
| darkxst | Girish, I need to sleep, will be back in the morning | 12:11 |
| Girish | Okay, Good Night! :) | 12:11 |
| knome | MatthewAllen, what's it about? (re: finding focculant) | 12:12 |
| MatthewAllen | knome, It was about a merge on Launchpad, he's talked to me through the merge though - so I don't need him anymore | 12:13 |
| knome | sure, and if you need something from him and he's not around, feel free to ask me | 12:14 |
| balloons | Girish, interesting designs. How much of that can actually be implemented? | 13:40 |
| Girish | balloons: Well the navbar can definitely be implemented. design.ubuntu.com has the same navbar. | 13:47 |
| balloons | Girish, I ask because I'd like to make sure we can actually implement the design -- and do so when we are ready | 13:48 |
| balloons | MatthewAllen, so no luck on condensing the vertical space? How about just in the add a result box? | 13:50 |
| balloons | I mean for https://code.launchpad.net/~whosdaz/ubuntu-qa-website/fix1531980/+merge/282043 | 13:50 |
| MatthewAllen | MatthewAllen, I can make the result box collapsible if you like - the testcase itself is not possible with the link in the title | 13:52 |
| MatthewAllen | balloons, I can do whatever you want - see my message above ^^ | 13:53 |
| balloons | MatthewAllen, I was more looking for condensing the UI elements, so they span horiziontally just a little bit, to make it less vertical | 13:53 |
| MatthewAllen | balloons, I was just following the report as Flocculant was requesting, I'm sure I can do that | 13:54 |
| balloons | MatthewAllen, I'd like to see that included if you don't mind :-) | 13:55 |
| MatthewAllen | balloons, so make the add a result collapisble? It's a tiny change - so no problem for me | 13:55 |
| balloons | MatthewAllen, well, sure. But What I'm really asking is to change the UI elements, not collapse them | 13:56 |
| balloons | perhaps a screenshot | 13:56 |
| MatthewAllen | balloons, any specific ideas? I'd probally chuck them in a diffrent merge request because that one is targetted directly at Flocculants bug report | 13:56 |
| balloons | MatthewAllen, http://imgur.com/ckk6hpW | 14:02 |
| balloons | I didn't edit it nice, but you get the idea. Notice the comment box vertical height is halved | 14:03 |
| MatthewAllen | ahh, will see what I can do | 14:03 |
| balloons | you can also move the submit result button to be next to the result radio icons | 14:03 |
| balloons | get it? | 14:03 |
| balloons | compress those things ;-) | 14:03 |
| MatthewAllen | yep, will have a look | 14:04 |
| MatthewAllen | If I make those changes, can I submit that as a CodeIn task? | 14:04 |
| balloons | Though not specified, I think it's part of the bug report you are working on :-) | 14:05 |
| balloons | It's not a major overhaul, but the idea was to reduce the existing page length and re-arrange things so the new bug table didn't eat all the space up | 14:06 |
| balloons | so I'd like them on the same MP | 14:06 |
| MatthewAllen | mmk, I'll message you when I've submitted them | 14:14 |
| Girish | balloons: My idea of a mockup was to sketch out the basic elements and their position. | 14:30 |
| Girish | Do you think that my mockup is complicated? | 14:30 |
| balloons | Girish, maybe, maybe not. I just wanted to make sure it's doable with what we have; it's drupal, and a php module + basic theme :-) | 14:32 |
| fazer | elopio: can you check this task: https://codein.withgoogle.com/dashboard/task-instances/5128575074172928/?sp-page=1 ? | 14:33 |
| balloons | Girish, that said, I like the fresh approach alot. I was hoping to see radical changes from what we see now. What exists now is kind of cobbled toegther | 14:33 |
| balloons | Girish, so a prototype never hurts to make sure your design can meet reality once you've finished the design concept | 14:34 |
| balloons | Girish, I'll leave some feedback on the task | 14:35 |
| Girish | Sure. | 14:35 |
| balloons | knome can too I'm sure ;-) | 14:35 |
| Girish | AS for if it's achievable or not, Drupal does have a theme for MDL: https://www.drupal.org/sandbox/rhormens/2532394 | 14:36 |
| Girish | MDL can be used for the hovering card effect: http://www.getmdl.io/components/index.html#cards-section | 14:37 |
| Girish | And the navbar is already implemented in design.ubuntu.com | 14:37 |
| balloons | brillant, so you've thought it through a bit | 14:40 |
| MatthewAllen | balloons, have a look at this - http://i.imgur.com/c8LmcZM.png | 14:42 |
| fazer | elopio: Who should I add as project manager? | 14:45 |
| balloons | MatthewAllen, looks nicer. We could do more with those elements I'm sure, but that should have shortened the page a good bit already right? | 14:48 |
| MatthewAllen | balloons, about 200px from chrome said | 14:49 |
| MatthewAllen | I'm having a look at moving the submit button now | 14:49 |
| balloons | ok; not sure how they will look once it's done, but it will grab some more real estate if so | 14:49 |
| balloons | either way, I'm going to be happy with the MP | 14:50 |
| MatthewAllen | balloons, the submit button doesn't seem to want to move - if I try to put it anywhere else it disapears | 14:51 |
| MatthewAllen | so I'm not 100% sure if it's gonna be able to be moved | 14:51 |
| balloons | MatthewAllen, that's fine then. What you have is a real nice improvement and meets the goal | 14:52 |
| elopio | fazer: that is Oliver Ries | 14:52 |
| MatthewAllen | balloons, I could shorten the comment box a little bit horizontally - and put the submit button on the right? | 14:52 |
| elopio | fazer: thanks for working on it. I left a comment about testing through the "public" interface. Let me know if you need a hand with that. | 14:52 |
| MatthewAllen | balloons, if you wanted to save a little bit more room we could tighten up the vertical spacing around the Submit button, as it has alot of padding on the top and bottom | 14:57 |
| balloons | MatthewAllen, little tweaks like that sound just fine. I won't push for anything further from you, as I hope we can consider a more radical overhaul at some point. But simple things to make what we have better are most welcome. The vertical space is key | 14:59 |
| MatthewAllen | balloons, from what I can work out the vertical spacing is being handled by the css files inside the System module, and that seems to be overiding my attempts at changes - So I don't think I'm able to fix that | 15:01 |
| balloons | fyi to all those who've done qatracker work; going to attempt another production release today including the outstanding MP's | 15:17 |
| fazer | elopio: I don't exactly understand what you mean by 'testing through the get method'. | 15:25 |
| elopio | fazer: in python you mark a method as internal putting a _ in front. | 15:27 |
| elopio | The internal methods are likely to change a lot, and are considered an implementation detail. So when writing unit tests, it's better to only test the methods that don't have a _ in front. | 15:27 |
| elopio | the get method in sources.py is the one that calls the _get_source_type_from_uri method. So that's the one you should use to test. | 15:28 |
| fazer | oh ok. | 15:28 |
| elopio | what we need to test in unit tests is the public interface, as much as possible. Sometimes we have to test the internal methods, but that's not common. | 15:28 |
| fazer | so I will have to check that the valu of handler_class is correct right? | 15:29 |
| fazer | elopio ^^ | 15:31 |
| Girish | balloons: What about my task? | 15:32 |
| elopio | fazer: no, that's a variable you won't be able to access from the test. | 15:32 |
| elopio | fazer: you call get, and you check that halder.pull executed the right command. | 15:32 |
| fazer | ok. | 15:33 |
| elopio | for that, you patch subprocess.check_call to be able to spy on what parameter was passed to it. | 15:33 |
| fazer | What should I use for sourcedir and builddir ? | 15:33 |
| balloons | Girish, any thoughts on what other pages might look like? Also, I'm waiting for knome to review and give his feedback | 15:35 |
| balloons | Girish, I will say, I'd like to see the mockup include more data. We have pages with many results and many bugs. And one of the issues is you aren't showing the same amount of info | 15:35 |
| elopio | fazer: use something like 'testsourcedir' and 'testbuilddir'. | 15:39 |
| fazer | elopio: I meant can I leave them uninitialized? | 15:39 |
| elopio | fazer: you need to use values that you then check on the assertion. | 15:40 |
| fazer | I don't understand. | 15:40 |
| elopio | fazer: the value you select for sourcedir and builddir will be passed to the check_call. So in the final assertion, you will have to check that check_call received the same values you chose for the two parameters. | 15:44 |
| fazer | elopio: using the assert_called_with() right? | 15:46 |
| elopio | fazer: right. | 15:47 |
| fazer | elopio, ok, I;m starting to understand. So do I need to mock when it calls handler.pull() or only subprocess.check_call()? | 15:48 |
| elopio | fazer: it's better to mock at the lower level. So subprocess.check_call. | 15:50 |
| elopio | that way you test all the code we control. | 15:50 |
| fazer | ok | 15:50 |
| fazer | elopio: there are already tests for the Git.pull() method. So shouldn't I be assuming that that already works and only be testing the get() method? | 15:55 |
| elopio | fazer: let me see. There are multiple options of how to do that. | 15:56 |
| elopio | fazer: you are right. As git.pull is already tested mocking the subprocess call, I think a nice way to do it is to mock git.pull, as you suggested before. | 15:58 |
| elopio | the test it's a lot smaller this way than what I proposed. :D sorry for the misdirection. | 15:59 |
| fazer | elopio ok cool. no problem. :) | 15:59 |
| fazer | elopio: what variable type is options? It can't be just a regular tuple/array | 16:24 |
| elopio | fazer: I think it's a dictionary. | 16:30 |
| fazer | elopio: how do I add attributes to it? none of the methods I try seem to work. | 16:48 |
| elopio | fazer: it's not a dictionary, it's an object. | 16:53 |
| elopio | take a look at how it's done in this test: https://github.com/ubuntu-core/snapcraft/blob/master/snapcraft/tests/test_base_plugin.py#L29 | 16:53 |
| elopio | python relies heavily on duck typing. So any object with the attributes that you require will work. | 16:54 |
| balloons | xcub, this updates for you. New leaderboard going up | 17:43 |
| balloons | done; http://people.canonical.com/~nskaggs/gcileaderboard.html | 17:45 |
| MatthewAllen | balloons, with the "Create an alternate tool via QATracker API" task, would a terminal application that allows the reporting of test image results be appropriate? | 17:46 |
| fazer | elopio: why is this not correct: patcher = unittest.mock.patch('handler.pull') ? What am I doing wrong? I get an error that says no module handler | 17:54 |
| fazer | am I supposed to import it or something? | 17:54 |
| balloons | MatthewAllen, yes, sounds like it | 17:55 |
| elopio | fazer: take a look at the TestTar | 17:59 |
| elopio | @unittest.mock.patch('snapcraft.sources.Tar.provision'), I would use something like that. snapcraft.sources.Git.pull | 18:00 |
| elopio | and another option is to use @patch.object(snapcraft.sources.Git, 'pull') | 18:02 |
| fazer | where do I specify what variable I'm using for this? | 18:07 |
| fazer | like mock_pull or mock_run etc. elopio ^^ | 18:08 |
| elopio | fazer: when you use it as a decorator, with the @, the name of the variable comes from the method definition. | 18:09 |
| elopio | like in the TestTar, take a look at mock_prov | 18:10 |
| fazer | so mock_prov is the var for TestTar? | 18:10 |
| fazer | ok. | 18:10 |
| fazer | elopio: so just specify a variable as parameter? | 18:10 |
| fazer | elopio ^^ | 18:17 |
| elopio | fazer: yes. | 18:17 |
| fazer | elopio, it says TestUri has no attribute mock_pull | 18:18 |
| fazer | @unittest.mock.patch('snapcraft.sources.Git.pull') | 18:19 |
| fazer | def test_get_git_source_from_uri(self, mock_pull): | 18:19 |
| fazer | elopio ^^ | 18:22 |
| elopio | fazer: do not use it as TestUri.mock_pull. Just mock_pull, it's an argument local to the method. | 18:23 |
| fazer | elopio, I'm done. I pushed. | 18:49 |
| fazer | elopio, it fails: it calls it twice. That makes sense since I'm calling it in a loop that is expected to iterate twice. | 18:53 |
| elopio | fazer: ah, you need to reset the mock | 18:55 |
| elopio | or use testscenarios. | 18:55 |
| elopio | personally, I find testscenarios nicer. | 18:55 |
| elopio | I think sergiusens prefers subTests, so let me see how to reset. | 18:57 |
| elopio | fazer: call mock_pull.reset_mock() | 18:57 |
| fazer | elopio, where should I move the MockOptions class to? | 19:09 |
| elopio | fazer: to snapcraft/tests/__init__.py | 19:10 |
| fazer | ok | 19:10 |
| wxl | i want to revert the "more work needed" on this and call it "approved." can an admin help? https://codein.withgoogle.com/dashboard/task-instances/5641788366782464/?sp-page=1 | 19:52 |
| fazer | elopio: I added the year to the copyright info. | 20:02 |
| balloons | wxl, I can't help -- the student should just resubmit. | 21:31 |
| === salem_ is now known as _salem | ||
| wxl | thx balloons | 22:36 |
| Bill_ | Hi I want to start working on the: Test Ubuntu live on your Laptop and report results on the laptop tracker task. I can't find the images for Ubuntu Desktop i386 | 22:37 |
| Bill_ | I looked here http://laptop.qa.ubuntu.com/qatracker/milestones/352/builds/108235/downloads can't find it | 22:37 |
| fazer | elopio, Most of the tests no longer work for some reason. idk why. I only modified 3 different files | 22:38 |
| Bill_ | I think i'll just grab the regular images from here http://cdimage.ubuntu.com/daily-live/current/ | 22:44 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
