[02:07] jose: hmm, I thought we got summit moved to https [02:07] nope, still using http for me [02:16] jose: you should file an RT to get it using https, there's nothing to be done in the code [02:16] will do [02:16] thanks [07:30] good morning [08:51] davidcalle: I'm looking at a very strange phenomenon with using django.test.Client.get() to test local links [08:51] the following used during the test: [08:51] print((url, type(res), len(res.content))) [08:51] gives: [08:51] ('/file2/', , 0) [08:51] ('/en/file2/', , 12641) [08:52] HttpResponseNotFound doesn't seem to be what we think it is :) [08:53] I think I'll just test for len(django.test.Client.get(url).content)>0 and that's it :) [09:02] dholbach, indeed, I was actually wondering the same thing about httpresponsenotfound when I tried your test last week, maybe Django doesn't do exactly the same thing when it's being tested VS in browser. [09:09] davidcalle: yep, looks like it [09:17] hum... len(res.content)>0 also doesn't work - the 404 page also has content :) [14:01] davidcalle: finally fixed it by using cms.test_utils.testcases.CMSTestCase.get_request() [14:01] (and fixed a couple of other bits along the way) [14:01] dholbach: Nice! [14:21] davidcalle: links are working now and are part of the test suite [14:22] I think we're getting close to having this usable [14:25] * davidcalle tests [14:51] davidcalle: do you remember what we did to fix things like https://bugs.launchpad.net/developer-ubuntu-com/+bug/1531200? [14:51] Launchpad bug 1531200 in Ubuntu Developer Portal "Snappy/Snapcraft docs don't show sublists" [Undecided,New] [15:14] dholbach: I don't, let me try [15:15] davidcalle: it looks like the new JS scopes API doc package still hasn't hit their PPA, is something blocking it? [15:17] dholbach: bzr messed up while importing the pip cache of your branch, setting it up again, hold on :) [15:20] ah yes... I might need to add this new module to pip [15:22] I mean adding the markdown extension to the cache [15:22] brb, need to restart my session - my mouse pointer just vanished [15:28] For this specific file, with nested lists, this works: html=markdown.markdown(md_text, tab_length=3) [15:29] dholbach: I guess (and hope) that matches github way of doing nested lists, so this would be consistent. [15:29] (And not mess up other files) [15:29] dholbach: do we have nested lists somewhere else? (/me looks at snappy/security) [15:30] davidcalle: hum, do we know that that's consistent with what github does? [15:31] snappy - docs/meta.md [15:32] snappy - docs/rest.md [15:32] snappy - docs/security.md [15:32] that's all files with nested lists AFAICS right now [15:33] dholbach: so, other docs (that imports fine with nested ul), follow two rules: no spaces before a bullet point "* ", and 4 spaces before a nested one " * " [15:33] dholbach: snapcraft doc writer is clearly evil. [15:35] (and I'm just going to disregard the fact that we should probably write guidelines for imported md :) ) [15:37] dholbach: are you used to do github mps? Maybe you can teach me? :) [15:37] I failed a couple of times already ;-) [15:37] I'm happy to help [16:02] dholbach: https://github.com/ubuntu-core/snapcraft/pull/218 \o/ Thanks :) [16:03] nice work [16:22] davidcalle: so the one image we currently have (on https://github.com/ubuntu-core/snapcraft/blob/master/README.md) works because it points to a remote URL - should the importer block if it finds a local image (for now... until we have a better idea how to fix it)? [16:22] dholbach: tha's probably the best idea, yeah [16:22] ok