| === TheMuso` is now known as TheMuso | ||
| === jzheng_afk is now known as jzheng | ||
| Saviq | @unity: correct, while PS Jenkins Bot works, trust that one, Unity8 doesn't run all the QML tests yet, just builds packages | 09:01 |
|---|---|---|
| mzanetti | kk | 09:11 |
| tsdgeos | mzanetti: i set back to needs review your launcher branches | 09:30 |
| tsdgeos | tests are failing | 09:30 |
| oSoMoN | Saviq, hey, I’m looking at https://bugs.launchpad.net/qtubuntu/+bug/1433138 , trying to understand the code that forwards key events in src/ubuntumirclient/input.cpp, and more specifically the translateKeysym function, which apparently was written by Gerry but he doesn’t seem to be around, do you know who could help me make sense of it? | 10:25 |
| ubot5 | Launchpad bug 1433138 in qtubuntu "Under Mir, physical keyboard’s Return key does not work within web pages" [High,In progress] | 10:25 |
| === jzheng is now known as jzheng_afk | ||
| tsdgeos | oSoMoN: yeah gerry is on holiday | 10:48 |
| tsdgeos | oSoMoN: what question do you have about that function? | 10:51 |
| oSoMoN | tsdgeos, see my last comment on the bug report: https://bugs.launchpad.net/webbrowser-app/+bug/1433138/comments/12 | 10:59 |
| ubot5 | Launchpad bug 1433138 in qtubuntu "Under Mir, physical keyboard’s Return key does not work within web pages" [High,In progress] | 10:59 |
| oSoMoN | tsdgeos, and a related question: where do I find the logs for qtubuntu? | 11:03 |
| tsdgeos | oSoMoN: interesting | 11:08 |
| tsdgeos | oSoMoN: what do you mean the logs? | 11:09 |
| tsdgeos | in bzr? | 11:09 |
| tsdgeos | mzanetti: did you see the other launcher branch also needs updating? | 11:11 |
| mzanetti | yes, on it atm | 11:12 |
| mzanetti | tsdgeos, ^ | 11:12 |
| tsdgeos | k | 11:12 |
| mzanetti | tsdgeos, something is broken with the launcher | 11:26 |
| * mzanetti tries trunk | 11:27 | |
| tsdgeos | mzanetti: seems fine here, what do you find broken? | 11:27 |
| mzanetti | dismiss by tap somehow behaves really weird | 11:28 |
| tsdgeos | seems pretty solid here on the latest phone image | 11:29 |
| tsdgeos | there was a bug fixed lately about that | 11:30 |
| tsdgeos | are you trying trunk or your branches? | 11:30 |
| tsdgeos | maybe you somehow reverted it on your branches? | 11:30 |
| tsdgeos | back in 15 | 11:31 |
| === alan_g is now known as alan_g|afk | ||
| tsdgeos | pstolowski: ping | 12:03 |
| pstolowski | tsdgeos, pong | 12:05 |
| tsdgeos | pstolowski: taping on an artist in the my music scope | 12:05 |
| tsdgeos | takes a long time to show me the artist "page" on the scope | 12:06 |
| tsdgeos | at first i thought it was hung or something | 12:06 |
| tsdgeos | long time like 10 seconds or more | 12:06 |
| pstolowski | interesting.. it's instant here. but maybe because i've all the images cached already | 12:07 |
| pstolowski | i think i saw the bug where we request insanely large image size for artist, but not sure | 12:07 |
| pstolowski | lemme try to find it | 12:08 |
| tsdgeos | i can reproduce it more or less | 12:09 |
| tsdgeos | "The Gossip" is the artist | 12:09 |
| pstolowski | tsdgeos, can you share the mp3 file? | 12:09 |
| tsdgeos | i guess that depends on the legal situation of your country :D | 12:09 |
| pstolowski | i'll remove if after the test, i promise ;) | 12:10 |
| oSoMoN | tsdgeos, sorry I didn’t see your answer earlier, by logs I mean the logs that are output (somewhere in a file, presumably) when there is a call to LOG("…") in the code | 12:22 |
| tsdgeos | ah | 12:22 |
| tsdgeos | :D | 12:22 |
| oSoMoN | couldn’t find them anywhere in /var/log nor in /home/phablet/.cache/upstart/ | 12:22 |
| oSoMoN | not sure where else to look for them | 12:22 |
| tsdgeos | oSoMoN: LOG is going to qDebug | 12:23 |
| tsdgeos | DLOG is compile time | 12:23 |
| tsdgeos | so if you're using the packages may go to nowhere | 12:23 |
| tsdgeos | LOG should be in /home/phablet/.cache/upstart/ i undertand that in the app log itself | 12:23 |
| oSoMoN | ah indeed | 12:25 |
| oSoMoN | I’d swear I had looked for them there too | 12:26 |
| oSoMoN | tsdgeos, thanks | 12:26 |
| mzanetti | tsdgeos, ok... there was a criss cross merge which would duplicate functions (like the assertFocusOnIndex one) without showing me any conflicts at all | 12:45 |
| mzanetti | should be good now I hope | 12:45 |
| tsdgeos | we're getting SUCCESS in CI in vivid qmluitests again | 13:27 |
| tsdgeos | \o/ | 13:27 |
| tsdgeos | i'm having a look at the xenial ones | 13:28 |
| Saviq | tsdgeos, nice | 13:37 |
| Saviq | tsdgeos, just started a run in Jenkaas, wonder how that goes ;) | 13:37 |
| tsdgeos | he he | 13:37 |
| mzanetti | tsdgeos, do'h! | 13:39 |
| mzanetti | sorry :D | 13:39 |
| tsdgeos | k | 13:41 |
| dandrader | mzanetti, would you have some spare time to review this one? https://code.launchpad.net/~dandrader/unity8/dontRotateDesktop-lp1515977/+merge/282590 | 13:56 |
| mzanetti | dandrader, ack | 13:57 |
| ltinkl | dandrader, one question there, nothing needed to be done in the DesktopStage? | 14:11 |
| ltinkl | dandrader, meh sorry, overlooked it | 14:12 |
| * Saviq positively surprised @jenkaas's package install speed | 14:15 | |
| Saviq | it's done within 2m30s for full unity8 installation in a clean chroot | 14:16 |
| Saviq | definitely not a priority to reduce, then | 14:16 |
| Saviq | will first have a look at ccache, then | 14:17 |
| === dandrader is now known as dandrader|afk | ||
| mzanetti | ltinkl, this only happens when interacting with the mouse, correct? https://code.launchpad.net/~mzanetti/unity8/launcher-sizing/+merge/280149/comments/717178 | 14:24 |
| ltinkl | mzanetti, let me try with touch | 14:27 |
| mzanetti | ltinkl, well, I meant pointer device | 14:27 |
| mzanetti | ltinkl, question was really: I can't repro it if sticking to kbd interaction | 14:27 |
| mzanetti | but it seems to happen when mixing kbd navigation and pointer interaction | 14:28 |
| ltinkl | mzanetti, yeah, with touch too; the point is, if the quicklist is open and the kbd navigation is on, launching something or clicking outside the quicklist renders the focus ring unusuable | 14:31 |
| mzanetti | ack | 14:31 |
| ltinkl | mzanetti, if you don't touch/tap and just use the keyboard, all seems to be fine | 14:31 |
| mzanetti | just wanted to understand your issue properly | 14:32 |
| tsdgeos | Saviq: the one for the launcher tests that sometimes fail to open the launcher https://code.launchpad.net/~aacid/unity8/launcher_test_remove_dda_constraints/+merge/282600 | 14:45 |
| Saviq | tsdgeos, coolz, that should improve autopkgtest results in the cloud then (as we had a slew of launcher fails on xenial) | 14:47 |
| ltinkl | Saviq, yup, just tried that on xenial locally, was passing | 14:49 |
| Saviq | nice nice | 14:49 |
| ltinkl | I'm seeing something weird locally in all branches: | 14:49 |
| ltinkl | file:///home/ltinkl/bzr/unity8/alt-input/qml/Components/NotificationAudio.qml:38: Error: Qt.createQmlObject(): failed to create object: | 14:49 |
| ltinkl | file:///home/ltinkl/bzr/unity8/alt-input/qml/Components/inline:1:34: Cannot assign to non-existent property "source" | 14:49 |
| ltinkl | tsdgeos, deos it ring a bell? | 14:50 |
| tsdgeos | that's how it's supposed to be | 14:50 |
| tsdgeos | i think | 14:50 |
| tsdgeos | yeah | 14:50 |
| tsdgeos | it's our way of load this or that | 14:50 |
| ltinkl | should it fail really? | 14:50 |
| ltinkl | but this doesn't seem to load anything | 14:50 |
| ltinkl | before I used to be getting: Upstream audioRole enum not available, falling back to old role name. | 14:51 |
| ltinkl | which is imho correct | 14:51 |
| tsdgeos | ah wait, this is the tests | 14:52 |
| tsdgeos | yeah the mock is incomplete | 14:52 |
| tsdgeos | and doesn't have a source property | 14:52 |
| Saviq | tsdgeos, nice one https://unity8-jenkins.ubuntu.com/view/Maintain/job/run-commands/376/consoleFull - only LazyImage failed, that should be fixed by cimi's lp:~cimi/unity8/fix-lazyImage-test-flakyness, if he ever puts it into Needs review ;) | 14:52 |
| Saviq | not sure why xml output isn't there | 14:52 |
| Saviq | and 40mins... definitely need to improve that | 14:53 |
| tsdgeos | i guess we could re-add it for the sake of less noisy test runs | 14:53 |
| tsdgeos | Saviq: compile+test run? | 14:53 |
| Saviq | tsdgeos, "just" the test run, which only compiles mocks and such | 14:53 |
| tsdgeos | Saviq: it's what it takes, no? whenevre i do a full run it's also slow | 14:54 |
| Saviq | on that note, we're building mocks on a normal build, aren't we | 14:54 |
| Saviq | tsdgeos, well, we can parallelize them | 14:54 |
| tsdgeos | oh sure, if there's more cpus we could | 14:54 |
| tsdgeos | Saviq: i think we probably are yes | 14:55 |
| Saviq | we probably shouldn't | 14:55 |
| cimi | Saviq, it is needs review, but I need to address mzanetti comment | 14:56 |
| ltinkl | tsdgeos, ah right ofc, it's in tests :) | 14:56 |
| Saviq | cimi, oh, thought it's down in WiP | 14:56 |
| === dandrader|afk is now known as dandrader | ||
| Saviq | Mirv, are you aware of a cross-build dependency issue somewhere in qt 5.5 packages? I've had lpunity-api cross-build fine on vivid but fail on xenial, can get you a more info if you need | 17:06 |
| cimi | mzanetti, ping | 17:14 |
| cimi | mzanetti, you sure https://code.launchpad.net/~cimi/unity8/fix-lazyImage-test-flakyness/+merge/277459/comments/705903 works? | 17:15 |
| mzanetti | cimi, it should | 17:20 |
| cimi | mzanetti, how would you use it, I added the id to the animations inside the transition, but still fails to get it | 17:31 |
| cimi | mzanetti, I tried looking with findChild and findInvisibleChild both on the root and from the transition that contains the animation | 17:32 |
| === dandrader is now known as dandrader|afk | ||
| cimi | still always same error of cannot find obj | 17:32 |
| mzanetti | cimi, hmm... odd | 17:42 |
| mzanetti | cimi, but you can use tryCompare on any of the properties that are animated in the transition | 17:44 |
| === dandrader|afk is now known as dandrader | ||
| cimi | mzanetti, or I can try to add a property instead a signal, but to be honest I might have already tried in november, there must be a reason why I ended up adding a signal | 17:58 |
| * cimi forgot | 17:58 | |
| mzanetti | I quite dislike adding such signals to a component's api if it's really only for testing... In most cases tests can be done nevertheless just as good | 17:59 |
| mzanetti | but if you really find no way out with this one... | 17:59 |
| cimi | mzanetti, do you have the flakyness on your laptop? | 17:59 |
| mzanetti | for this test? | 17:59 |
| cimi | yes | 18:00 |
| mzanetti | need to try | 18:00 |
| cimi | mzanetti, just run make testLazyImage | 18:00 |
| cimi | if your pc is fast it fails | 18:00 |
| cimi | in the offie atm and it does not fail here :) | 18:00 |
| mzanetti | my pc used to be fast... now its quite regular | 18:00 |
| cimi | :) | 18:00 |
| mzanetti | cimi, no... passes here | 18:26 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!