| fazer | Does anybody know what Vatika Harlaka's nickname is? | 00:04 |
|---|---|---|
| knome | not everybody is on IRC | 00:05 |
| fazer | I guess... Even the mentors? | 00:15 |
| knome | even them/us :) | 00:16 |
| fazer | I claimed this task and its not very specific: https://codein.withgoogle.com/dashboard/task-instances/5207178558308352/?sp-page=1 . It says make 5 code refactors but it doesn | 00:26 |
| fazer | 't specify which repo/project to make the changes to. | 00:26 |
| knome | jose, ping! please publish https://codein.withgoogle.com/dashboard/tasks/4874591692390400/ :) | 15:45 |
| jose | knome: hello! let me check | 15:45 |
| jose | knome: should be all set now :) | 15:46 |
| * knome bows | 15:46 | |
| knome | jose, now that you are there, we can publish this task too (i don't know why it wasn't already): https://codein.withgoogle.com/dashboard/tasks/4514565299634176/ | 15:48 |
| jose | sure, let me check | 15:49 |
| jose | and published as well | 15:51 |
| knome | thanks again | 15:53 |
| MatthewAllen | knome, on http://docs.xubuntu.org/contributors/ the links for the PDF's both A4 and US Letter are dead links | 16:05 |
| knome | MatthewAllen, right.. just dismiss that for now :) | 16:30 |
| knome | (unless you want to read it in pdf, in which case you should be able to build the documentation with those files as long as you are not running xenial) | 16:31 |
| tsimonq2 | MatthewAllen: you should be good to go | 16:35 |
| tsimonq2 | :) | 16:35 |
| MatthewAllen | tsimonq2, thanks! :) | 16:35 |
| wxl | darnit can someone unapprove this please? https://codein.withgoogle.com/dashboard/task-instances/6609275128381440/ | 19:23 |
| fazer | ahayzen, isn't what you want me to do the same as this: http://bazaar.launchpad.net/~ubuntu-weather-dev/ubuntu-weather-app/reboot/view/head:/tests/autopilot/ubuntu_weather_app/tests/test_locations_page.py#L69 | 20:58 |
| ahayzen | fazer, just commented, it is similar | 20:59 |
| ahayzen | fazer, but the test is to use the swiping left/right rather than through the button edge | 21:00 |
| ahayzen | so you'll be able to use the same assert on the self.home_page.get_selected_location_index() ..but instead of going to the location page... you simple swipe across | 21:00 |
| ahayzen | *simply | 21:00 |
| fazer | ahayzen, ok. That shouldn't be too hard. | 21:01 |
| ahayzen | yup :-) | 21:01 |
| ahayzen | just add a swipe method to the Home page helper class | 21:01 |
| ahayzen | then it'll be a very similar test | 21:01 |
| fazer | and this test goes in the test_home_page right? not locations. | 21:02 |
| ahayzen | it'll go in the test_home file yes | 21:02 |
| fazer | ahayzen, the default orientation is the next tab on the right, right? So I have to wipe to the left to get to it? | 21:22 |
| ahayzen | fazer, yup | 21:24 |
| fazer | ok cool. | 21:24 |
| fazer | so my swipe can just be swiping to the left? I don't need to have a parameter for the direction? | 21:25 |
| ahayzen | fazer, you could make it generic | 21:48 |
| fazer | ok. | 21:49 |
| ahayzen | fazer, as the method names are clear, maybe a swipe_left and swipe_right method on the home class and then a generic method outside of the class | 21:50 |
| fazer | ahayzen, by outside you mean in BAseTestCaseWithPatchedHome()? | 21:52 |
| ahayzen | fazer, just straight into the helper file the __init__.py not the tests/__init__.py IIRC | 21:53 |
| fazer | ok. | 21:54 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!