[00:11] ahayzen, can you check out my task asap, because I'd like to get to work on another task soon. [00:11] fazer, yup :-) [00:13] thanks === _salem is now known as salem_ === salem_ is now known as _salem === _salem is now known as salem_ [15:57] Hi balloons, is a screenshot okay for this task https://codein.withgoogle.com/dashboard/task-instances/4818117368741888/?sp-page=1 ? [17:22] hey xcub [17:22] balloons, you killed him :( [17:22] hai knome! [17:22] hello balloons [17:27] thanks for keeping tabs on the new designs -- what do you think overall? [17:33] knome, did you see https://codein.withgoogle.com/dashboard/task-instances/6023557586878464/?sp-page=1? [18:28] elopio, I'm adding another test to snapcraft. I'm trying to squash my commits but when I rebase, my merge upstream commit isn't visible, how can I squash that? [18:35] top ten: 1) MatthewAllen: 36 tasks. 2) malevasquez: 30 tasks. 3) Girish Rawat: 22 tasks. 4) Alex Dueppen: 20 tasks. 5) Aditya: 17 tasks. 6) xcub: 11 tasks. 7) fazerlicourice71256: 8 tasks. 8) McIntireEvan: 8 tasks. 9) Ayush: 7 tasks. 10) Hunter Jarrell: 7 tasks. [18:36] since I can't update the page and haven't in awhile [18:37] fazer: I'm the wrong person to ask about git. I would try git rebase -i master, but it might end up worst. My snapcraft teammates will help you better there. [18:38] elopio, it's ok. I figured it out. My branch is running the travis ci build now, I think it should be ready to merge soon [18:42] balloons, they also take into account the kind of tasks right? like coding vs documentation ? [18:53] ahayzen, for this beginner task: https://codein.withgoogle.com/tasks/6226596490903552/?sp-organization=4568116747042816&sp-is_beginner=True what exactly do you want me to do? Just pull the weather-app and run the test suite? [19:00] balloons, could you give my task a look please? [19:00] I would ask gnome but he doesn't seem to be around [19:01] knome* [19:22] fazer, yup simply build and run the test suite by the looks of it [19:22] ahayzen alright,cool. [19:22] ahayzen, two of the tests are failing. The ones taht I pointed out to you when I was working on my last task. [19:23] Should I get a key and try those? Is that what's wrong? [19:23] fazer, they all pass on my device, it is just on jenkins some are failing [19:23] fazer, yeah if you try with a key it may fix them, although i'm not sure if just an OWM will be enough [19:23] ahayzen, so what should I do about the task? Just point out that those two fail. [19:24] oh ok, i'll try with a key. [19:24] fazer, yeah just comment that, i know that those two will fail without a key, so that's cool [19:24] Ok. awesome. [19:24] fazer, it is more the fact that you have shown you can build and run the app/test suite [19:25] yeah, I would think :) . I need the quick extra task though, while another one is getting approved. [19:28] elopio, can you take a look at my Merge proposal? I believe it can be merged. [19:29] elopio: https://github.com/ubuntu-core/snapcraft/pull/245 [20:46] it really is a shame that GCI ends right after most people are finally done with final/semester exams [20:47] adueppen, the timing is a bit rough isn't it? [20:47] the good news is we're still all here after :-) === salem_ is now known as _salem [22:05] Can any of the mentors look at this task, because the listed mentor doesn't seem to be available. https://codein.withgoogle.com/dashboard/task-instances/4831775901614080/?sp-page=1 [22:06] Yeah I had exams this past week, toughest ones Ive ever had, really (being a senior, it makes sense) but either way it's not super important to me to complete a ton of tasks, I know I cant win in terms of tasks completed and its not like I cant continue to contribute after (which I will, because my school schedule is pretty good this last semester) [22:47] popey, ahayzen can you take a look at this task? https://codein.withgoogle.com/dashboard/task-instances/5962049209237504/?sp-page=1 [22:48] fazer, looks good :-) [22:48] cool [22:48] fazer, just of interest, did you have to install qtdeclarative5-qtlocation-plugin and qtdeclarative5-qtpositioning-plugin ? to get the app to run ? [22:50] ahayzen, Yes I think I did. It might have been for another app. But I remember doing that fairly recently so it was probably for this one. [22:50] fazer, ah cool thanks :-) i've been trying to fix the debian/control files to have the right depends :-) [22:51] ahayzen, can you accept the task? [22:52] fazer, yup, just reading the task description, i haven't looked at this one before... [22:52] oh ok. wait.. but how come you're a mentor for it? [22:53] fazer, done :-) I got added adhoc to the coreapps tasks :-) [22:53] ahayzen, thanks. Whats adhoc? [22:54] fazer, like i was added to them after they were created [22:54] oh ok.