/srv/irclogs.ubuntu.com/2016/01/29/#juju-dev.txt

thumperoh shit00:55
* thumper sadface00:55
thumperwallyworld: juju run seems to be broken for hosted environments00:56
wallyworldyay00:56
wallyworldin master?00:56
thumperI recall having a different system identity created for the hosted environments00:56
thumperyes master00:57
thumperI have a hosted env called to-move00:57
thumperjuju ssh -e to-move 000:57
thumperworks00:57
thumperjuju run -e to-move --machine 0 'ls'00:57
thumperdoes not00:57
wallyworlddamn00:59
axwwallyworld: probably not the most thorough review I ever did, but your PR is good to go01:05
wallyworldaxw: tyvm, a lot of it is boilerplate - moving stuff around rather than too many renames. we can fix things if we find them01:06
=== natefinch-afk is now known as natefinch
thumperfirst migration demo is a success02:45
thumperall seems to work exactly as designed02:45
thumperas long as you only have simple machines and no services or storage02:45
thumperor networks02:45
thumper:)02:45
thumperand manual hackery to update agents config02:45
* thumper wonders why the 2UTC call is at 3UTC02:51
axwwallyworld: how would you feel about me adding the -o flag at least temporarily? existing bootstrap tests depend on certain config set (e.g. default-series, agent-stream)02:56
wallyworldaxw: sure, go for it02:57
axwwallyworld: I can back it out once we have a --config02:57
wallyworldnp02:57
wallyworldaxw: we'll just let rick know it's a stop gap02:57
axwwallyworld: I wasn't planning on documenting it, but can do02:59
wallyworldaxw: if it's not needed for the demo, then don't :-)02:59
axwwallyworld: no, just for the unit tests03:00
wallyworldok, np, no doco needed03:00
cheryljcan I get a quick review?  http://reviews.vapour.ws/r/3676/03:25
cheryljIt's adding some logging in an attempt to track down some recent CI failures03:25
* thumper is done done03:33
thumperlaters03:33
cheryljwallyworld: fwiw, you'll probably want to pull that PR into the api-command-rename branch as well, as it is also seeing the connection is shutdown failures.03:48
wallyworldcherylj: i do need to merge master, will do that after the latest stuff lands03:49
cheryljwallyworld: could you take a quick look at that RB?  http://reviews.vapour.ws/r/3676/03:50
cheryljoh03:50
cheryljn/m03:50
wallyworldcherylj: i just hit merge :-)03:50
cheryljYou'll need to JFDI it03:50
cheryljI can do it03:50
wallyworldah yeah03:50
axwwallyworld: finally, http://reviews.vapour.ws/r/367706:14
wallyworldok06:15
wallyworldaxw: one possibly stupid question to answer06:44
axwwallyworld: ta06:47
wallyworldnp06:47
axwwallyworld: which one's the possibly stupid question?06:48
wallyworldaxw: so many to choose from :-) the one about why region is set to cloud name06:48
axwwallyworld: comment about setting region?06:48
axwok06:48
wallyworldyup06:48
axwwallyworld: that's a hack for lxd06:48
axwwallyworld: I think we want to detect the region name instead06:48
wallyworldregion should be local in that case06:48
wallyworldlocalhost06:49
wallyworldand only done for lxd and not all clouds06:49
axwwallyworld: sure, the lxd provider would return a region of "localhost" when asked to detect. I'll write a TODO to fix this.06:49
wallyworldta06:49
axwwallyworld: well, I don't want to go special casing things like we did for the local provider06:50
wallyworldyep, sorry, was just using a general statement06:50
axwwallyworld: I think there's value in having detection for other things too, e.g. to pick up OS_REGION... I'll add a TODO and we can go over it in more detail later06:50
wallyworldimplementation tba sort of thing06:50
axwyep06:50
wallyworldyeah, todo is good, allows readers of code to grok what is wip etc06:51
axwwallyworld: I was running tests and found out why the cmd/juju/status tests are so insanely slow. the status filtering code is doing IP resolution (and way more than it even needs to)06:51
wallyworldoh dear06:52
axwwallyworld: it shouldn't need to at all, since we store IPs06:52
wallyworldlet's add a card to fix that06:52
axwyep06:52
wallyworldty06:52
mupBug #1539428 opened: cmd/juju/status: status filtering performs IP resolution of patterns <status> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1539428>07:08
=== ashipika1 is now known as ashipika
rogpeppe1fwereade_: any idea how a unit might not have a CharmURL (i.e. why does state.Unit.CharmURL return a bool) ?09:21
iceyaxw: does the open stack provider have the storage hook support?09:25
axwicey: yes, it supports block storage via cinder09:25
iceyawesome, thanks axw!09:26
axwnps09:26
iceyaxw: what version is required for thta?09:30
iceythat*09:30
axwicey: 1.2509:31
axwicey: something going wrong?09:31
iceynope, just discussing what we can do with testing for the ceph charms, wanting to get some more advanced storage stuff tested axw09:32
axwicey: okey dokey. FYI, we have storage support in AWS, MAAS, OpenStack, Azure, and GCE09:33
axwall from 1.25 onwards09:33
iceygreat, thanks axw!09:33
voidspacedimitern: ping09:35
dimiternvoidspace, pong09:41
voidspacedimitern: soooo...09:42
voidspacedimitern: I'm still working on a test in MachineSuite, in cmd/jujud/agent/machine_test.go09:42
voidspacedimitern: and PatchValue isn't working!09:42
voidspacedimitern: I'm doing exactly what other tests are doing (as far as I can see)09:43
voidspacebut with the patch in place the original function is still called (if I put a panic in the original function and run just the new test it panics)09:43
dimiternvoidspace, hmm - are you doing it in SetUpSuite?09:43
voidspacedimitern: not in SetUpSuite, in the test09:43
voidspacedimitern: https://github.com/juju/juju/compare/maas-spaces...voidspace:maas-spaces-networking-api10#diff-918e88c5445d929c38db9bf4f0a85cc8R101409:43
dimiternvoidspace, looking09:43
dimitern+s.PatchValue(&newDiscoverSpaces, newDiscoverSpaces)09:44
voidspaceit's called from startEnvWorkers in machine.go09:44
voidspacehttps://github.com/juju/juju/compare/maas-spaces...voidspace:maas-spaces-networking-api10#diff-f5ec9ed405cc8f3a833355afdc629bd3R125709:44
dimiternwhat are you patching?09:44
voidspacedimitern: that's an alias for discoverspaces.NewWorker09:45
voidspacedimitern: this is exactly what many other tests do for patching out worker creation09:45
voidspaceas far as I can tell identical anyway, I'm obviously missing something09:45
dimiternvoidspace, well, the func you're patching it with has the same name, so aren't you doing a no-op?09:45
voidspacehah09:45
voidspacedimitern: yep09:46
voidspacedimitern: thank you09:46
dimiternvoidspace, ;)09:46
voidspacethe patch is applying locally, I'm shadowing it09:46
dimiternvoidspace, np09:46
voidspacedimitern: needed another set of eyes09:46
voidspaceI burned more than an hour on that yesterday09:46
voidspacedimitern: thanks09:46
dimiternvoidspace, I'll do that later today for some reviews btw09:47
voidspacedimitern: heh, no problem09:47
dimiternvoidspace, I know I said I could use some help yesterday, but it turned out it's simpler to do as one PR than to split it artificially09:47
voidspacehmmmm, no still doesn't seem like my func is being called09:48
voidspacelet me put that panic back in09:48
voidspaceok, it doesn't panic so the fake is in place at least09:49
dimiternvoidspace, why not pass a channel to newDiscoverSpaces and closed it when done, instead of a mutex?09:54
voidspacedimitern: I only need to wait for discovery if discovery was actually started09:56
voidspacedimitern: so with a bool, it defaults to false and we only set it to true when discovery starts09:56
voidspacedimitern: not sure there's a clean way of doing the same with a channel09:56
dimiternvoidspace, I'm trying to find a good example..10:00
voidspacedimitern: I'd need a way to tell if a channel has been started but not yet closed10:00
dimiternhttp://dave.cheney.net/2013/04/30/curious-channels10:00
voidspacedimitern: frobware: dooferlad: stdup?10:01
voidspaceFriday meeting room10:01
dimiternvoidspace, you can make it buffered, so you write true to it once it starts and wait to read from it in a select later10:01
dimiternvoidspace, omw10:01
voidspacedimitern: that doesn't sound any simpler than a bool and a mutex10:01
fwereade_rogpeppe1, sorry I missed you10:58
rogpeppe1fwereade_: np, i think i worked it out anyway10:59
fwereade_rogpeppe1, a unit doesn't have a charm url until it knows what charm it's actually going to run because it's downloaded and verified10:59
rogpeppe1fwereade_: yeah, i figured that11:00
perrito666morning all11:38
* perrito666 visits an office and fixes their network11:46
voidspacedimitern: hey, is this meeting still happening this afternoon?14:07
dimiternvoidspace, the one in ~15m ?14:14
dimiternI think so14:14
voidspacedimitern: I thought frobware and dooferlad would be invited, but they're not on the list so I assume so too :-)14:15
voidspacedimitern: my test is complete and passes14:16
voidspacedimitern: changing it to use a channel now, which does change the test - but shouldn't take long14:17
voidspaceah, no it doesn't pass14:17
voidspacegrrr, it did a minute ago14:17
voidspacenearly there anyway14:17
voidspaceah, admin user can't log in14:18
voidspacehow odd14:18
voidspace"invalid entity name or password"14:18
voidspacehave to find someone who can login14:18
dimiternvoidspace, right - it's more about the plan for merging into master - it's not necessary to go if you don't want to14:18
dimiternvoidspace, ah :) you'd likely need to also create the user you're trying to use14:19
dimiternand set password14:19
voidspacegrrr14:19
voidspacethis is from s.AdminUserTag(c)14:19
voidspaceI assumed that user existed14:19
voidspaceit's probably the wrong password14:19
voidspacedimitern: hah, the password is "dummy-secret"!!!14:20
voidspacenow it passes...14:20
dimiternvoidspace, \o/ sweet!14:20
frobwaredimitern, is there a merge meeting taking place that I should attend?14:30
voidspacefrobware: https://plus.google.com/hangouts/_/canonical.com/maas-spaces?authuser=0&hceid=YWxleGlzLmJydWVtbWVyQGNhbm9uaWNhbC5jb20.5fqsbuut5c9fh29v70q11o7vt414:31
dimiternfrobware, it's scheduled, but I don't know more - I'm joining now14:31
voidspacedimitern: frobware: PR for merge of latest master onto maas-spaces14:44
voidspacehttp://reviews.vapour.ws/r/3681/14:44
voidspacedimitern: the NetworkManager job has gone now too, right?14:44
voidspacethat came back across in the merge from master and I deleted it14:45
dimiternvoidspace, it's not gone, but it's no longer used to decide whether the networker should run or not (as it's gone as well)14:46
voidspacedimitern: interestingly on maas-spaces JobManageNetworking isn't in cmd/jujud/agent/machine.go14:46
voidspaceok14:46
dimiternvoidspace, that will take some time to read btw ... will have a look through the 15+ pages a bit later14:46
voidspacedimitern: I deleted it from machine.go after the merge from master which had added it back14:46
voidspaceheh14:47
voidspacedimitern: most of it was automatic - except cmd/jujud/agent/machine.go14:47
voidspaceand the networker changes which I had to redelete14:47
dimiternvoidspace, ok, it should be easier then14:49
voidspacedimitern: if we're dropping support for maas < 1.9 then we can drop some of the legacy codepaths14:49
voidspaceand just fail if maas < 1.914:49
frobwaredimitern, voidspace: part of me says we should understand why 1.8 doesn't work - CI-wise.14:53
dimiternfrobware, agreed14:53
dimiternvoidspace, it's too early to do that properly I think14:53
voidspaceunderstanding is good14:54
voidspacebut we have until monday to merge...14:54
frobwarevoidspace, this could be just ... take maas-spaces and bootstrap on 1.8, even if its just to say "aha..."14:56
frobwarevoidspace, were there any conflicts?15:02
ericsnownatefinch: standup?15:02
voidspacefrobware: changes to the networker worker and api, which we've deleted (so easy to resolve)15:02
natefinchericsnow: coming15:02
voidspacefrobware: and changes around starting the networker in cmd./jujud/agent/machine.go15:02
voidspacefrobware: I just deleted all references, dimitern can check if I did it right.15:02
voidspacefrobware: everything alright at home - you still able to go to FOSDEM and charm conf?15:03
dimiternvoidspace, have you seen the changes around the machine agent?15:23
dimiternvoidspace, it looks like with them it's much simpler to check the order of started workers, as well as add a "discover-spaces-started-gate" like the "upgrade-steps-gate" to signaling the import started15:24
voidspacedimitern: I haven't15:44
voidspacedimitern: I guess I should look and I'll have to change my test :-)15:44
voidspacedimitern: maybe have to change how this worker is started15:44
voidspacedimitern: let's get the merge in15:45
voidspacedimitern: I'm taking a late lunch15:45
dimiternvoidspace, well, I think it will be worth it - it does look much nicer and easier15:46
voidspacedimitern: great15:46
dimiternvoidspace, *whew*.. finished with that monstrous diff - it looks good15:49
voidspacedimitern: thanks15:53
mupBug #1539656 opened: leadership dependency failures in CI deploy tests <juju-core:Incomplete> <juju-core api-command-rename:Triaged> <https://launchpad.net/bugs/1539656>15:57
mupBug #1539684 opened: storage-get unable to access previously attached devices <juju-core:New> <https://launchpad.net/bugs/1539684>16:33
=== marcoc|airplane is now known as marcoceppi
=== urulama is now known as urulama__
ericsnownatefinch: looks like I've addressed everything except the context patch review (and I'm working on that now)19:55
natefinchericsnow: cool19:57
natefinchericsnow: btw, thanks for the pointer on the new doc comments in the names package. That helps clarify things a lot... and it sounds like we agree entirely about how they should be used.  I really there was only one string representation of a tag... having two just seems like it's asking for trouble, especially when the two functions are called Id() and String().20:05
natefinchericsnow: "new" (march of last year ;)20:05
ericsnownatefinch:  :)20:05
natefinchericsnow: in the persistence layer, I was using fmt.Sprintf("resource#%s#%s#%s", serviceID, id, unitID) for the unitresource's id... but do you think we really need the service ID?  maybe just fmt.Sprintf("resource#%s#%s", unitID, id)?20:44
ericsnownatefinch: given the dependence of the unit ID on the service ID, yeah, we probably don't need it20:45
natefinchericsnow: would it be evil to consolidate SetUnitResource and SetResource into a single SetResource(id, ownerID string, res resource.Resource)?20:48
natefinchericsnow: since the only difference now is the name of the function and the name of the argument20:48
ericsnownatefinch: that would make it too easy to get it wrong20:48
natefinchericsnow: fair enough, I can make two exported functions, but send them to the same internal functions20:49
ericsnownatefinch: the distinction still matters even if they do the same thing20:49
ericsnownatefinch: sounds good20:49
ericsnownatefinch: I've responded to all the context-related review comments and addressed nearly all of them21:02
ericsnownatefinch: would you mind running through them real quick?21:02
natefinchericsnow: sure, I'll go look right now21:02
ericsnownatefinch: I should be able to land the branch now21:02
natefinchericsnow: sweet21:03
ericsnownatefinch: we can resolve the more philosophical differences once we have time to breath21:03
perrito666marcoceppi: ping21:04
ericsnownatefinch: BTW, just ran through a manual test and it worked correctly on the first try :)21:32
alexisbericsnow, that sounds encouraging :)21:43
natefinchheh, I've been doing manual tests for a few days... other than those two bugs we found earlier in the week, yeah, it all looks good21:44
ericsnowalexisb: it was working already, but we've since cleaned up the code we'd hastily written and added tests :)21:44
natefinchnice that it's surviving refactoring and edits, though :)21:44
ericsnowyep21:44
cheryljfwereade_: do you happen to be around?21:52
ericsnownatefinch: I'm going to land the patch and leave those extra issues open on the context review as a reminder21:53
perrito666mm, at a status level we seem to lack information regarding if a relation is a peer or normal relation21:58
natefinchericsnow: that's fine21:59
natefinchericsnow: I'll be back tonight and will rebase my patches off of the feature branch and finish up the review changes22:00
ericsnownatefinch: k22:00
mupBug #1539785 opened: lxd provider leaks resources <landscape> <juju-core:New> <https://launchpad.net/bugs/1539785>22:04
wallyworldcherylj: thats for creating that doc. the latest run has the restore tests passing. as you found, the CI scripts need tweaking and that should address some of the other failures, so that branch is looking good for next week22:20
wallyworld*thanks22:20
cheryljwallyworld: I am worried about this bug, though:  https://bugs.launchpad.net/juju-core/+bug/153965622:21
mupBug #1539656: leadership dependency failures in CI deploy tests <juju-core:Incomplete> <juju-core api-command-rename:Triaged> <https://launchpad.net/bugs/1539656>22:21
wallyworldcherylj: that issue is only seen in the feature branch?22:22
cheryljgod I've looked at too many bugs today.  Let me check22:23
wallyworldthere was a note in the doc that said it has been seen elsewhere22:24
wallyworldif that's the case, and it's in master, then we shouldn't block the feature branch on that22:24
cheryljah, glad I wrote it down at some point, then22:24
wallyworld:-) you has so much to keep track of22:24
wallyworldyour brain must be full22:25
wallyworldcherylj: there were some leadership changes in master just recently to address another bug i can't recall right now, might be related to that22:25
cheryljwallyworld: I checked that master passed with dave's changes22:26
cheryljand it did22:26
cheryljnow I'm wondering if I was mistaken about this leadership one...  the other failure with similar symptoms have different logs22:26
wallyworldcherylj: ok, will need to look closer then22:27
wallyworldcherylj: so it seems that bug above is only on the maas 1.9 deploy according to the doc; the other maas failures are due to the replicaset issue22:28
cheryljwallyworld: the 1.7 maas deploy also fails with that leadership problem22:29
wallyworldregardless, it's weird it's only on one substrate. dort of indicates it's a timing issue22:30
cheryljwallyworld: and I'm thinking the replicaset issue may be an unfortunate "working as designed"22:30
cheryljwallyworld: I think that's the only place this charm is deployed in CI?  maybe?22:30
wallyworldnot sure, will need to check22:30
cheryljsinzui, abentley mgz - is the dummy-sink-0 charm deployed to other substrates in CI tests?  or is that just a MAAS test?22:31
sinzuicherylj: every substrate for every series22:31
cheryljhmm22:31
cheryljinteresting22:31
sinzuicherylj: the dummies are trrivial and consistent for every series, though the windows version is definitely different22:32
cheryljsinzui: what would the other tests be named?22:32
cheryljI want to look at their test logs22:32
cheryljgce-deployer-bundle?22:33
sinzuicherylj: almost every job that is xxx-<depoloy|upgrade>-*22:33
cheryljok22:33
wallyworldcherylj: on the surface, i can't see how this is related to the branch per se, but it could be. the fact it's ony one substrate indicates a more general timing or other issue. will need to look closer into it22:33
sinzuicherylj: deployer and quickskstart and functional are not dummies22:33
* wallyworld afk for a bit22:34
cheryljwallyworld:  here's an example of a successful deploy of that charm:  http://data.vapour.ws/juju-ci/products/version-3555/aws-deploy-trusty-amd64-on-wily-amd64/build-588/unit-dummy-sink-0.log.gz22:34
cheryljfor when you get back :)22:34
sinzuicherylj: http://reports.vapour.ws/releases/3557 The CPC and Substrates sections are all using dummy source and sink to very hooks trade infoirmation22:35
cheryljand sinzui, wallyworld, for that manual provider connection is shut down bug, I think the changing of the replicaset is valid.  It's switching to use the cloud-local address rather than the public address.22:35
cheryljit's unfortunate that it makes mongo drop the connections22:36
cheryljanyways, I need to go pick up the kid22:38
cheryljbbl22:38
mupBug #1539806 opened: [ARM64][LXD Provider][ 2.0-alpha1-0ubuntu1~16.04.1~juju1] kibana 'hook failed: "install"' <juju-core:New> <https://launchpad.net/bugs/1539806>23:19
mupBug #1539806 changed: [ARM64][LXD Provider][ 2.0-alpha1-0ubuntu1~16.04.1~juju1] kibana 'hook failed: "install"' <juju-core:New> <https://launchpad.net/bugs/1539806>23:31
mupBug #1539806 opened: [ARM64][LXD Provider][ 2.0-alpha1-0ubuntu1~16.04.1~juju1] kibana 'hook failed: "install"' <juju-core:New> <https://launchpad.net/bugs/1539806>23:34
wallyworldcherylj: with the successful deploy referenced above in build 3555, it also works in build 3557 on mass 1.8 trusty amd64 and all other substrates, but fails only maas 1.7. and it works on maas 1.9 whereas it failed in a previous run where the only change was to add the restore-backup alias. on the surface, I cannot see how this issue is specific to the feature branch23:48

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!