=== maclin1 is now known as maclin
=== andyrock_ is now known as andyrock
ioanmhi guys, 1 question I have noticed a bug in unity 7 in ubuntu 14.04 lts whenever i launch an app in the recent list, the icon disappears from the unity search window while the app(if I press super i can see the icon disappear) and reappears short after app closes08:02
ioanmmay I be assigned to fix this recent list bug?08:02
=== davmor2_ is now known as davmor2
Saviqtsdgeos, hey, looks like LazyImage still not good enough https://requests.ci-train.ubuntu.com/static/britney/vivid/landing-019/excuses.html - could you have a look please, now that we've Pass elsewhere it's going to be trouble :)09:27
tsdgeosok, i'll have a look09:27
cimiSaviq, we should try the other branch too09:29
cimiSaviq, https://code.launchpad.net/~cimi/unity8/fix-lazyImage-test-flakyness/+merge/27745909:30
cimiSaviq, that one was before michael told me to use waitForRendering and simplify everything09:30
tsdgeoscimi: honestly, first he todl you to not have the signal and just to find the object on the test09:31
tsdgeossince the signal is not used for anything else09:32
tsdgeosthen you fell into the trap of removing everything and adding a waitForRendering09:32
cimithat's a trap!09:32
cimiiirc I couldnt find the animation because it was inside the transition, or I had issues with running property09:34
cimiso I went for good old signals09:34
cimitsdgeos, Saviq I'm having a second look too10:01
cimitsdgeos, if you have any idea/patch that i can try, I can reproduce the original bug on my desktop pc10:02
tsdgeosoki, was finishing something for patty, will have a look now10:02
tsdgeoscimi: so with https://code.launchpad.net/~cimi/unity8/fix-lazyImage-test-flakyness/+merge/277459 you can not reproduce?10:02
cimitsdgeos, flakyness is fixed for me with both branches10:03
cimitsdgeos, I can reproduce the original flakyness10:03
cimijenkins always flaky - way to powerful! :)10:04
=== marcusto_ is now known as marcustomlinson
tsdgeoscimi: the "transitionCount: 4" is "a bug"?10:26
tsdgeosi mean a bug in the current code10:26
tsdgeoswhy would it transition twice?10:27
cimitsdgeos, that's exactly why I am having a look again10:34
cimitsdgeos, when I proposed the fix, that was what I did in an afternoon iirc, thought it was more critical10:34
tsdgeosyour branch still fails for me10:36
cimioh crap10:36
tsdgeoswait i left the waitforrendering, maybe i need to remove it10:37
cimitsdgeos, I am wondering if we need a better cleanup()10:40
cimitsdgeos, from my understanding, jenkins is so fast that the animation doesnt start10:40
tsdgeoscimi: that makes no sense, why would your code fix it then?10:42
cimitsdgeos, which code, former branch or the last one?10:43
cimitsdgeos, that is right too, so why would it fail on a faster pc?10:44
tsdgeosi don't know10:45
tsdgeosjenkins is usually dead slow10:45
tsdgeosnot faster10:45
cimitsdgeos, that's what I thought, but on my slower machine I cannot reproduce, while I can with the faster one11:00
=== lool- is now known as lool
tsdgeosSaviq: cimi: my variant https://code.launchpad.net/~aacid/unity8/more_stable_lazy_image_test/+merge/28459111:54
tsdgeosit's similar to cimi's but withotu changing the lazyimage code itself11:54
cimitsdgeos, that looks better, however I am trying to see if we can still add waitForRendering11:55
Saviqdednick, forgot, please merge trunk qtmir test refactor12:02
dednickSaviq: k12:02
Saviqdandrader, you might wanna remerge your bits on top of ↑12:03
Saviqdandrader, also, https://code.launchpad.net/~dandrader/qtmir/appRestart-lp1527737/+merge/281701 needs rebasing12:04
dandraderSaviq, you planning on merging appRestart-lp1527737 ?12:04
Saviqdandrader, at some point, I hope ;)12:08
Saviqdandrader, wanted to add to our next silo to be able to test again and maybe give you more data12:08
Saviqltinkl, hey, I set up GECOS on the phablet user, but greeter still shows "phablet", do you know if that's expected? code says "realName" on the lightdm model, so I thought it would use the right thing?12:09
Saviqor is realName stored somewhere else?12:09
Saviqhmm doesn't seem to work on my laptop either, so we might need to change something after all12:11
ltinklSaviq, dunno what the greeter shows... josh should know12:14
Saviqhmm I wonder if it should use displayName or so12:16
Saviqhmm no realName seems to be the right role12:16
dednickSaviq: done.12:18
Saviqdednick, tx12:18
Saviqtsdgeos, huh, here's a question: http://bazaar.launchpad.net/~lightdm-team/lightdm/trunk/view/head:/liblightdm-qt/usersmodel.cpp#L226 any idea how to get to Qt::DisplayRole in QML?12:19
Saviqit'd have to be set in setRoleNames, wouldn't it12:19
tsdgeosthink so12:20
ltinklSaviq, it doesn't have to I think12:20
ltinklSaviq, it's modelData in QML12:20
Saviqltinkl, is it?12:20
tsdgeosyou can try with12:21
tsdgeos            (*this)[Qt::DisplayRole] = "display";12:21
tsdgeosthat is part of DefaultRoleNames12:21
tsdgeosbut i think that gets overwritten on setRoleNames12:21
tsdgeoslet me check12:21
tsdgeosSaviq: yeah from looking at the code i'd say it gets overwritten, but give "display" a quick try12:22
ltinkltsdgeos, it gets initialized with the default ones12:23
tsdgeosltinkl: sure, but it gets overwriten on setRoleNames12:26
Saviqltinkl, modelData is not defined12:27
Saviqtsdgeos, "display" seems to work actually, looks like lightdm is b0rked12:28
cimitsdgeos, Saviq I'm curious to see if this one will pass too https://code.launchpad.net/~cimi/unity8/more_stable_lazy_image_test/+merge/284595, it's a mix of both branches12:28
Saviqcimi, you'll ~know soon enough12:29
Saviqdumb comma12:29
* cimi goes groceries 5 mins I'm back12:29
Saviqcimi, prereq?12:29
cimiSaviq, yeah I can12:29
cimiSaviq, https://code.launchpad.net/~cimi/unity8/more_stable_lazy_image_test/+merge/28459612:30
ltinklSaviq, tsdgeos: thinking about how to expose the keymap from the surface as a property... is a QPair accessible from QML?12:52
* ltinkl doesn't think so12:52
=== alan_g is now known as alan_g|lunch
Saviqltinkl, other than some primitive thing like an array, custom object seems to be the only sane choice?13:10
=== ssweeny` is now known as ssweeny
ltinklSaviq, yeah... I went with 2 read-only QString properties (layout+variant) and a setter that takes both13:10
ltinklSaviq, not that we strictly need it now but once we'll want to make the indicator work, we must have a way to query the current surface's keymap13:11
Saviqltinkl, ack13:11
ltinklSaviq, Mir doesn't provide it, it only has a setter... :/13:12
Saviqltinkl, you'll need to rewrite history of your kbd branch https://ci-train.ubuntu.com/job/ubuntu-landing-051-1-build/42/console13:20
Saviqstart with Daniel's initialSurfaceGeom and put the diff on top, please13:20
Saviqyou'll need to --overwrite, but there's only so much we can do13:20
Saviqwhen we get into criss-crosses13:20
ltinklSaviq, yeah, working on that (and also adding a unity-api branch into the mix)13:20
ltinkldandrader, https://code.launchpad.net/~lukas-kde/unity-api/kbdLayout/+merge/28460213:25
ltinkldandrader, I'll make the changes to qtmir+unity8 in a minute13:25
dandraderltinkl, ok13:29
ltinkldandrader, https://code.launchpad.net/~lukas-kde/qtmir/kbdLayout/+merge/284466 should be good too now13:30
=== dandrader is now known as dandrader|afk
Saviqmterry, moarning13:37
Saviqmterry, got bug #1536714 for you on the lightdm side13:37
ubot5`bug 1536714 in lightdm (Ubuntu) "Fix the user login experience on the greeter" [Critical,Triaged] https://launchpad.net/bugs/153671413:37
Saviqmterry, never gives up anything other than username it seems13:38
mterrySaviq, ok will look13:40
tsdgeoscimi: if you're removing the whole signal spy, shouldn't you remove it altogether?13:43
ltinkldandrader|afk, https://code.launchpad.net/~lukas-kde/unity8/kbdLayout/+merge/28460613:46
=== alan_g|lunch is now known as alan_g
=== dandrader|afk is now known as dandrader
cimitsdgeos, yeah but you added it for the cleanup no?14:03
tsdgeoscimi: ah right14:03
tsdgeoscimi: still failed here14:03
cimitsdgeos, I dislike the transitionCount14:03
cimitsdgeos, which one failed?14:03
tsdgeosthe one i put in the MR14:04
tsdgeosbasically the same that fails all the time14:04
tsdgeosthe waitforrendering is not going to help there14:04
tsdgeosyou're basically making it fail more and not less14:05
tsdgeosif the waitforrendering takes some time14:05
tsdgeosthe transition will start and finish and you'll still be in waitforrendering14:05
tsdgeoscimi: if you dislike the transition count another way is checking for the state and that the animation is finished14:06
tsdgeosthat will have the same effect14:06
* cimi looks in 10 mins14:07
dandraderSaviq, rebased lp:~dandrader/qtmir/removeUselessClass and lp:~dandrader/qtmir/initialSurfaceGeom14:10
Saviqdandrader, oh? those were merging fine?14:10
mterrySaviq, you've marked that lightdm bug for 9.5?  that seems ambitious14:10
mterrySaviq, not a hard change all around, but isn't 9.5 real soon now?14:10
Saviqmterry, it was marked 9.5 before14:10
mterrySaviq, ah ok14:10
Saviqmterry, but if we can make it ;)14:10
mterrySaviq, hah I'll start now14:11
Saviqmterry, well, yeah, later today14:11
Saviqltinkl, you'll be interested ↑↑ dandrader rewrote history of his branches again ;)14:11
mterryltinkl, I'm working on another maybe-9.5 thing right now, dandrader is reviewing the kbdLayout branches?14:11
ltinklSaviq, this silo is turning into a madness...14:12
ltinklmterry, yeah looks like it :) I'm fixing the mock + test atm14:12
Saviqltinkl, yeah, thanks bzr14:12
dandradermterry, not really reviewing them. just pointed out some missing "paperwork"14:21
mterryltinkl, ^14:27
ltinklmterry, dandrader: you guys decide :)14:33
mterryltinkl, I'm happy to review it, but I'm working on something else this morning.  Can get to it later14:34
ltinklmterry, sure, no rush I guess14:34
Saviqltinkl, mterry, yeah, won't land for OTA9.5 anyway so there's less pressure14:36
ltinkldandrader, the 2 separate QString properties are there really only because exposing a QPair isn't possible, but they act together14:48
ltinkldandrader, see the test_setKeymap(data) in u8/tst_DesktopStage.qml14:49
dandraderltinkl, I know they act together. but when you expose them as properties, you should do it the whole way14:53
ltinkldandrader, by which you mean 2 separate signals?14:53
dandraderltinkl, you can setKeymap("x+y") then setKeymap("x+z"). so variant changes but layout does not. But if you say that Qt has no issues using this  two-parameter signal as the notify one then it's ok14:56
ltinkldandrader, yeah, the signal doesn't have to match14:56
ltinkldandrader, you could as well have a keymapChanged() without any parameter for both properties14:57
ltinkldandrader, but signalling both at once with the same signal makes writing the tests (and maybe the indicator in the future) much easier14:58
=== dandrader is now known as dandrader|lunch
=== dandrader|lunch is now known as dandrader
dandraderdednick, got a quick one for you: https://code.launchpad.net/~dandrader/qtmir/updateMirVersion/+merge/28462915:31
dednickdandrader: approved15:32
SaviqMirv, hey, https://requests.ci-train.ubuntu.com/#/ticket/939 seems to have failed to build, needs bumping symbols around?16:35
tsdgeoscimi: i still don't understand what you don't like about my branch for lazy image tests16:42
cimitsdgeos, you said it failed, and I wanted to get rid of that signal counts16:50
tsdgeoscimi: yours failed16:50
tsdgeosmine works16:50
tsdgeosthe signal counting is not terrible16:50
tsdgeosthere's 3 state changes so the signal count is 616:50
tsdgeosthere's others ways to fix ait for the same, but i don't see why counting the state changes is that bad16:51
cimitsdgeos, you disliked my original branch when I added the transition count https://code.launchpad.net/~cimi/unity8/fix-lazyImage-test-flakyness/+merge/277459/comments/70229316:51
tsdgeosi did16:52
tsdgeosand i still dislike the 416:52
cimiI thought we wanted to have a smarter approach16:52
tsdgeosthe 4 is a bug on the original code most certainly16:52
tsdgeosthe 6 is fine16:52
tsdgeosit goes default -> loading -> error16:53
cimiyeah I saw16:53
cimiwell, let's approve yours then16:53
cimiat least we dont have changes in LazyImage.qml16:53
cimiwhile tests pass16:53
cimitsdgeos, you ok with that?16:53
tsdgeosi am16:54
Saviqtsdgeos, cimi will add to silo 19 tomorrow16:55
tsdgeosSaviq: any chance we get https://code.launchpad.net/~aacid/unity8/preview_audio_playlist/+merge/284624 for the MWC image ? seems patriciadavila/PM wants it there17:07
cimitsdgeos, on that branch, I noticed you do on purpose two for cycles for the playlist, first from index to end of the repeater then you start again from the index 017:08
cimitsdgeos, is this to have the playlist looping ya?17:09
tsdgeoscimi: no, this is to have the playluist starting in the correct index17:09
cimitsdgeos, yeah I meant that, it starts from where it should then adds the rest of the elements17:10
tsdgeosthen yes is for that :)17:10
cimitsdgeos, it's the only logic part you changed in the real code, so i wanted to ask why that and not a single for :)17:11
Saviqtsdgeos, we can get anything for MWC, we'll be demoing rc-proposed from two-three weeks from now17:14
tsdgeosSaviq: ah, awesomeness17:14
cimitsdgeos, Saviq anyway that audio playlist, just approved17:18
cimiI'm gonna approve the other flakyness too or we first try in silo 19 Saviq ?17:18
* tsdgeos eods17:18
* tsdgeos waves17:18
cimitoo fast17:18
Saviqcimi, approve away17:20
cimithis one didnt fail too though, maybe we can approve that one too https://code.launchpad.net/~cimi/unity8/more_stable_lazy_image_test/+merge/284596 I'll see with albert magnana17:22
mterryltinkl, you asked in the qtubuntu kbdLayout branch, if it really needed to link with xkbcommon?  Just look at jenkins failing.  I also ran into it in a chroot build17:51
mterryltinkl, and in the unity8 kbdLayout branch, you asked what I had in mind for one of the tests.  In tests/plugins/AccountsService/client.cpp, we have some tests that just make sure "dbus -> AccountsService service -> our listener object" works for a few properties.  And since we're using weird types in this case, it might be good to test the InputSources property17:54
=== alan_g is now known as alan_g|EOD
=== dandrader is now known as dandrader|afk
=== dandrader|afk is now known as dandrader
mhall119Saviq: is there any way to test a Unity 8 session on my wily laptop?19:17
mterryltinkl, I can't build your qtmir kbdLayout branch -- get errors about missing overrides for qtmir::MirSurface.  "invalid new-expression of abstract class type ‘qtmir::MirSurface’"20:32
UmeaboyThe webpage http://unity.ubuntu.com/getinvolved doesn't load.21:47
UmeaboyReason: Error reading from remote server21:47
ltinklmterry, still around?21:56
mterryltinkl, i am22:01
ltinklmterry, there's a new branch/MP: https://code.launchpad.net/~lukas-kde/qtmir/kbdLayout2/+merge/28464322:01
ltinklmterry, sorry, I had to start from scratch, bzr was too confused by the several pre-requisites22:02
mterryltinkl, ah ok22:02
ltinklmterry, this should build (at least it did in the silo)22:02
ltinklmterry, there's also a (new) unity-api branch needed: https://code.launchpad.net/~lukas-kde/unity-api/kbdLayout/+merge/28460222:04
ltinklmterry, which dandrader already approved22:04
mterryltinkl, yah saw that22:04
Saviqmhall119, you may try, but wily is really not a target any more - you'd be better off with vivid+overlay or xenial22:10
ltinklmterry, I added the explicit linking to xkbcommon in https://code.launchpad.net/~lukas-kde/qtubuntu/kbdLayout/+merge/28431022:16
mhall119Saviq: if I were to try on wily, what would be the best way? unity8-desktop-session-mir or unity8-lxc?22:37
Saviqmhall119, lxc is unmaintained and known to not be working for a while, desktop session is it22:38
mhall119well, that won't install because of unmet dependencies, is there a live ISO I can boot?22:52

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!