anastasiamaccherylj: we are all holding our breaths :D00:12
alexisbanastasiamac, me too :)00:12
alexisbwallyworld, I am free when you are ready to chat00:13
davechen1ycherylj: thanks00:15
=== jillr_ is now known as jillr
perrito666wow save file still has that annoying create new folder bug00:21
alexisbperrito666, sounds like you are volunteering00:23
perrito666alexisb: for what?00:24
alexisbfixing an annoying bug :P00:24
perrito666alexisb: I am by no means fixing a bug in unity700:24
wallyworldalexisb: just finished with andrew, let's meet in our 1:100:25
thumperdavechen1y, cherylj, wallyworld: while I remember, next Monday is a public holiday in NZ00:26
wallyworldwaitaingi day?00:26
alexisbwallyworld, ack00:27
thumperwill do00:27
* thumper goes to add to team calendar00:27
perrito666wallyworld: and monday and tuesday are holidays in argentina (be cause we cant be less than nz)00:28
thumperperrito666: what is your excuse?00:29
perrito666thumper: carnival ;) south america rules00:29
perrito666also, the fact that we stop the country 2 days for carnival might hint you on why the economy is going down the drain :p00:30
davechen1ythumper: noted00:30
davechen1y3 day kiwi weekend00:30
anastasiamacperrito666: well, in Oz, we have a horse race that apparently stops the country for the whole of 5 mins but "it's the race that stops Australia" :D00:31
thumperperrito666: I think more countries should take two days off for a party00:31
thumperalexisb: worth noting that even though I'm off monday, we still have our call on your monday :)00:32
davechen1yanastasiamac: 5 minutes on the track; 24 hours on the terps00:32
anastasiamac+100 for parties00:32
anastasiamacdavechen1y: \o/00:32
menn0waigani: there's something up with the diff for the deployer PR. Lots of errors that weren't there before.01:20
waiganimenn0: I think I know why. Another worker landed into MADE-workers - and now there are conflicts01:22
menn0waigani: that sounds likely01:23
menn0phew! I have caught up on reviews.01:23
menn0everyone stop working now :)01:23
anastasiamacmenn0: but then u'll have nothing to do \o/ what will become of u?... :D01:25
davechen1ywe have gc.Matches01:35
davechen1ywhich is _sort_ of a regex01:35
davechen1ybut expects to match exactly01:35
davechen1ydo we have something like gc.Substring ?01:35
* thumper is a tad surprised01:38
thumpertests pass01:38
thumperit means I didn't screw up the refactoring01:38
thumperwhat I mean to say is01:38
thumperof course it works!01:38
perrito666I find your faith in our tests disturbing01:38
davechen1yprey that I do not change the scope further01:39
perrito666ok, my brain just became pudding, see you all tomorrow01:40
davechen1ygc.Match does not handle multi line input01:41
davechen1ywhat a shit01:41
waiganimenn0: that was the problem. I've resolved conflicts. Other than conflicts, only change I made was to return the Uninstall err01:46
menn0cool. Ship it then!01:53
thumperholy crap01:55
thumperjust now looking at the number of comments that menn0 added to the migrate-machines branch01:55
menn0thumper: sorry, most are small things IIRC01:56
thumperthat's fine01:56
thumperjust going through them now01:56
thumperso I can get a re-review while you are oncall01:56
thumperalso, I want to land it01:56
thumperservices is almost ready01:56
* davechen1y considers writing a one off checker for what I want01:57
wallyworldaxw: huzah! just merged master into cloud-crdentials branch, 220 files with conflicts \o/02:07
axwwallyworld: heh :)02:07
wallyworldguess what i'm doing today -( :-(02:07
anastasiamacwow :(02:08
wallyworldffs, almost none of these are true conflicts. wtf is git doing02:11
blahdeblahwallyworld: At least you're not using bzr...02:12
wallyworldblahdeblah: i love bzr, *much* better thT GIT02:12
wallyworldintiuitive cli02:12
blahdeblahMuch better at creating conflicts that aren'tr true conflicts, though...02:12
wallyworldyou don't need to understand the internal model02:12
wallyworldthat might be true02:13
* davechen1y decides not to write a checker02:19
davechen1yi'll just write a function that takes a gc.C02:19
davechen1ymenn0: perrito666 http://reviews.vapour.ws/r/3713/02:55
davechen1y^ addresses your commentson the 1.25 backport02:55
davechen1ywill land on master and merge into my 1.25 backport branch02:55
menn0davechen1y: looking02:56
thumpermenn0: i.makeMachineJobs(m.Jobs())02:56
thumperwrong paste02:57
thumpermenn0: http://reviews.vapour.ws/r/3656/02:57
thumpersometimes having two paste buffers is annoying02:57
menn0thumper: I liked the first one better :)02:57
thumpermenn0: I agreed with almost all your review points02:57
thumperperhaps you'd like a few minute call to talk about the others?02:57
menn0davechen1y: looks good. ship it!02:58
menn0thumper: lemme have a look first02:58
thumpermenn0: ack02:58
thumpermenn0: in the service branch, I had realised also that I wanted a method called Tag(), and a separate one for Name()02:59
thumpermenn0: luckily I didn't go back and do the machine ones02:59
thumperI was thinking about it02:59
thumperhave done so for this review02:59
menn0thumper: I'm fine with the issues you dropped. I'm happy with your reasoning and/or they were ones I either didn't feel too strongly about.03:25
menn0still going through the diff now.03:25
thumperI didn't sneak anything else in :)03:25
menn0thumper: just seeing how you addressed the issues03:27
thumpermostly by deleting things :)03:27
menn0thumper: hmmmm.. maybe I shouldn't have asked for all those doc strings.03:29
menn0a lot are pointless.03:29
menn0e.g. SetStatus implements Machine.SetStatus.03:29
thumperbut 'required'03:29
thumperjeez I'm hot03:30
thumperphysically hot03:30
thumperit is mid 20s here03:30
thumperI'd hate to have to live somewhere where it is regularly this hot03:30
* thumper looks at wallyworld, axw and anastasiamac03:30
thumperno air con03:31
thumperbecause this is NZ03:31
menn0thumper: I just talked to my parents. It's 38 right now in Brisbane03:31
thumperwhy would you want to cool things down?03:31
menn0New Zealanders are often in denial about hot and cold03:31
axwthumper: actually quite nice today, 26C. going to be 40 on the weekend though :o03:31
menn0for example the freezing student flats in Dunedin03:31
menn0thumper: ship it, with a few minor comments03:34
thumpermenn0: cheers03:34
thumpermenn0: I'm not sure on the 'canonical' comment for interface method implementations03:37
thumperdavechen1y: do you have an opinion on this?03:37
thumperaxw, wallyworld: or you folks?03:37
menn0thumper: IMHO repeating the method name adds more repetition to an already low-value doc string03:38
menn0axw: // Foo implements SomeInterface.Foo03:38
menn0/ Foo implements SomeInterface.03:39
menn0/ even03:39
thumperor // Foo implements SomeInterface method03:39
axwmenn0: oh. I've never thought either was really that helpful, TBH.03:39
* thumper shrugs03:39
thumperaxw: but if we are wanting to have tools that complain if you are missing comments for exported methods / types03:39
menn0mentioning the interface being implemented offers a little bit of value in terms of linking back to the intended interface03:39
thumperwe should have something03:39
menn0mentioning the method name twice doesn't add any value03:40
menn0I don't care too much though03:40
* thumper nods03:40
axwof the two, I'd go for the methodless one03:40
thumperaxw: so // Foo implements SomeInterface.03:40
axwthumper menn0: I think in the past I've written "// Foo is part of SomeInterface"03:41
thumperI like that03:41
menn0that's fine too03:41
thumperI'm thinking of what I have though03:41
menn0although it's sort of vaguely incorrect03:41
thumperwill look like: // Id is part of Machine.03:42
menn0"implements" is slightly more accurate03:42
axwyeah, it might not have been that specifically03:42
thumper // Id implements Machine.03:42
thumperis that better?03:42
axwmenn0: well... all the methods together implement that interface03:42
axwI'm fine with that03:42
* axw doesn't really care03:42
thumpershall we really bikeshed it and take it to the mailing list?03:43
thumpermenn0: the fact that the method on partially implements the interface is why I added the name on the end03:43
* thumper shrugs03:44
* thumper looks at our current code03:44
thumper/ SubnetId implements StateIPAddress.03:44
thumper // SubnetId implements StateIPAddress.03:45
thumperI'll go with that03:45
thumperat least we'll be mostly internally consistent03:45
menn0It really doesn't matter too much. All the approaches are fine. I was trying to avoid requiring a little extra typing and maintenance.03:48
davechen1ythumper: can you bless this please https://github.com/juju/juju/pull/427504:05
thumperdavechen1y: done04:12
menn0waigani: I'm just pushing a PR now which adds the test helpers for PostUpgradeManifold based manifolds04:26
menn0waigani: in includes new unit tests for proxyupdater's manifold04:26
waiganimenn0: awesome! I'll learn from the proxyupdater04:27
menn0waigani: https://github.com/juju/juju/pull/427704:28
menn0waigani: yeah I figured a non-trival example would be useful04:28
waiganimenn0: shipit. Thanks for the unit test examples, all makes sense.04:48
davechen1ythumper: tahnks04:49
davechen1ythumper: relly $$__JDFI__$$ ?04:50
menn0waigani: thanks04:51
thumperlaters folks04:54
thumperI'll be checking in on my merge job04:55
mupBug #1541228 opened: deployed container in maas provider does not honor maas proxy settings <juju-core:New> <https://launchpad.net/bugs/1541228>07:19
mupBug #1541228 changed: deployed container in maas provider does not honor maas proxy settings <juju-core:New> <https://launchpad.net/bugs/1541228>07:22
=== ses is now known as Guest63441
mupBug #1541228 opened: deployed container in maas provider does not honor maas proxy settings <juju-core:New> <https://launchpad.net/bugs/1541228>07:37
=== coreycb` is now known as coreycb
dimiternvoidspace, morning09:04
dimiternvoidspace, it seems like apart from ci issues the most common cause of the last curse was due to "spaces still being discovered" - e.g. on a manual provider or joyent, etc.09:05
voidspacedimitern: that should be a warning not an error09:05
voidspacedimitern: and it shouldn't happen on providers that don't support discovery09:05
dimiternvoidspace, also the api rename branch has landed on master, I'm preparing a merge PR for maas-spaces09:05
voidspacedimitern: oh dear in other words09:06
voidspacedimitern: cool09:06
dimiternvoidspace, well, have a look at the ci report09:06
voidspacedimitern: I'll look into the failures09:06
voidspacedimitern: yep09:06
voidspacedimitern: ah, just worked out what it could be09:06
voidspacedimitern: if I'm right, will be a trivial fix (and extra test)09:06
voidspacedimitern: coffee first09:07
voidspacedimitern: (I suspect we don't close the channel if discovery isn't supported - I thought that was tested, but maybe not)09:07
dimiternvoidspace, cheers - I suspected something like that09:09
voidspacedimitern: confirmed09:09
voidspacedimitern: just pushing a fix, will write test after coffee but before standup09:10
dimiternvoidspace, sure, thanks09:10
voidspacedimitern: that's the fix: https://github.com/juju/juju/compare/maas-spaces...voidspace:maas-spaces-discovery-fix?expand=109:11
dimiternvoidspace, looks good, but can you please try a live test on something other than maas?09:14
voidspacedimitern: hmmm... there was a test for that, obviously something wrong with the test09:14
voidspacedimitern: yep09:14
dimiternvoidspace, ta09:14
voidspacedimitern: ah no, it was just where the provider doesn't support networking - and you can't get a dummy provider that doesn't support networking09:19
voidspacedimitern: so it wasn't testable09:19
voidspacedimitern: so I'm pull requesting this as is09:21
voidspacedimitern: http://reviews.vapour.ws/r/3716/09:21
dimiternvoidspace, networking maybe, but space discovery is testable with dummy09:24
voidspacedimitern: yes, and it is tested09:28
voidspacedimitern: the faulty code path is where the provider doesn't support networking09:28
voidspacedimitern: where environs.SuppportsNetworkingEnviron(environ) returns false for ok09:29
dimiternvoidspace, ah, I see09:29
voidspacedimitern: and you can't trigger that with the dummy provider09:29
dimiternvoidspace, there are ways to trigger it09:29
voidspacedimitern: I couldn't see any09:30
dimiternvoidspace, in networkingcommon we use a stub that embeds environs.Enviorn09:30
voidspacedimitern: it's a type cast and there isn't a dummy provider that doesn't have those methods09:30
voidspacedimitern: not in networkingcommon we don't09:32
voidspacedimitern: ah, apiservertesting StubProviderType09:32
voidspacedimitern: ok, I'll look at those tests09:33
dimiternvoidspace, yeah - it's ok for this specific feature to be tested with a stub environ I think - since we test the rest of the logic already09:35
frobwaredimitern, voidspace, dooferlad: we also need to concentrate on just 1 branch to test (i.e., maas-spaces).09:51
voidspacefrobware: I don't really understand. We are concentrating on just maas-spaces aren't we?09:52
frobwarevoidspace, nope. the last few CI runs have been based off dimiter's wip branch.09:52
frobwarevoidspace, dimitern: we should get that merged into maas-spaces (assuming we're happy the CI results and changes per-se)09:52
voidspacefrobware: ah09:53
frobwarevoidspace, dimitern, dooferlad: the CI tests look better in that I didn't see the empty series error09:53
dimiternfrobware, agreed - I'm almost done with the merge PR from master09:53
dimiternfrobware, yeah, that last minute refactoring around select|acquire|startNode seems to have worked09:54
frobwaredimitern, I took a look too. there were some conflicts but perhaps fewer than I feared.09:54
voidspacedimitern: with the stub-non-networking-provider I can create an apiserver facade that uses it09:56
dimiternfrobware, most conflicts are around discoverspaces and the networkingcommon restructuring09:57
dimiternvoidspace, awesome - so it will work for the test?09:57
voidspacedimitern: but I need an api facade (to create a discoverspaces.API to create the worker), that will return the right config from EnvironConfig to get the stub environ09:57
voidspacedimitern: you were too quick :-) an apiserver facade is only part of the machinery09:57
frobwaremgz, ping09:59
voidspacedimitern: setting up the dummy provider is done in JujuConnSuite in setUpConn09:59
voidspacedimitern: and there's a *lot* of code there10:00
dimiternvoidspace, yeah, so you need another suite not based on jujuconnsuite10:00
voidspacedimitern: but that's my point10:00
voidspacedimitern: in order to get an api that can actually get back at the provider I think I probably need jujuconnsuite10:00
dimiternvoidspace, let's topic this for standup10:01
voidspacedimitern: ok10:01
voidspacedimitern: frobware: dooferlad: finally failed with "unable to connect to API" (not because of space discovery though)10:44
voidspacedimitern: frobware: dooferlad: this is the error I expected, I just expected it a bit earlier in the process!10:44
dimiternvoidspace, right, that's perhaps due to the dep engine churning through dependencies10:48
dimiternvoidspace, also, if you're waiting for a fixed time that's flaky - it needs no to depend on the real clock if possible10:50
voidspacedimitern: this is just normal bootstrap, there's no additional timeout code in any of the discoverspaces stuff10:56
voidspacedimitern: maybe there's a timeout set in environments.yaml I can tweak?10:56
voidspacenot that I can see10:57
dimiternvoidspace, there's bootstrap timeout settings - see juju help bootstrap10:58
voidspacedimitern: I'm not *sure* that's the problem though11:00
dimiternvoidspace, :) when in doubt - add more logging11:04
voidspacedimitern: what do you have in ~/.ssh/config for Canonistack?11:20
voidspacedimitern: I have a ProxyCommand there, through chinstrap, which is probably why it "works"11:20
voidspacespecifically, I'm wondering what you use for User - I have "ubuntu"11:20
dimiternvoidspace, let me check11:21
dimiternvoidspace, I have these: https://pastebin.canonical.com/149020/, but I haven't tried if it still works11:23
voidspacedimitern: thanks11:23
jamespagejam, alexisb: hey - not sure if you are around but https://github.com/juju/juju/pull/4131 is required for local LXD provider on xenial right now11:44
dimiternfrobware, dooferlad, voidspace: https://github.com/juju/juju/pull/4279 please take a look - all tests pass, incl. a live test on both ec2 and maas 1912:14
frobwaredimitern, dooferlad, voidspace: please can I ask that we have two 'ShipIts' for this change. I was just trying this independently and what to see if I end up with the same tree. Thx.12:15
dimiternfrobware, it won't be the same tree12:15
dimiternfrobware, it's a cherry-picked merge from tip of master + a few more commits on top to fix the issues12:16
frobwaredimitern, I can pull your tree and compare, that's all I was thinking of. Unless I'm missing something....12:16
dimiternfrobware, but it also changes a few names - e.g. TestManageEnvironX -> TestManageModel; for consistency12:16
frobwaredimitern, I think we should have followed up with that kind of change.12:16
frobwaredimitern, i.e., do the simplest smallest change possible12:17
dimiternfrobware, it's not a lot more than the simplest thing - see the latter commits12:17
frobwaredimitern, ok12:18
mupBug #1541393 opened: apiserver/logsink.log gets created while running unit tests <juju-core:Triaged> <https://launchpad.net/bugs/1541393>13:35
dimiternfrobware, voidspace, dooferlad, any feedback or issues with the master merge while testing?13:41
dimiternI've rebased my other branch on top of the merge PR with not a lot of churn13:41
frobwaredimitern, I didn't get the same-ish tree as you - was just looking to understand why13:41
dooferladdimitern: I am about to run the mediawiki demo. Just need to sort out a problem.13:41
dimiterndooferlad, cheers13:42
dimiternfrobware, I've used the tip of master with: git cherry-pick -m1 9e7dbcf67cefe89dbaf291222ace59c74c28aa6713:43
frobwaredimitern, that was your initial merge, then followed up with name fixes?13:44
voidspaceI'm still trying to bootstrap with my branch - couldn't bootstrap canonistack with master and a 20minute timeout13:45
dimiternfrobware, yeah, however as I discovered later I had to change a few places (reverting a bit of the post-merge commit changes) and they are in the last commit13:45
voidspaceit *may* be that an even longer timeout is needed, not sure13:45
voidspacebut need this branch to land so testing with amazon and maas at least first13:45
dimiternvoidspace, did you use --debug ?13:46
voidspacedimitern: not yet, good point - but need to do sanity test with amazon/maas *anyway*13:46
voidspaceso getting that done13:46
dimiternvoidspace, I'll give your PR a try13:46
frankbanocr I need a review for http://reviews.vapour.ws/r/3719/ (quick fix to juju deploy flags)13:53
frankbancherylj: FYI ^^^13:53
voidspaceright, I'm nipping out14:02
voidspaceback soon14:02
dimiternvoidspace, (when you're back) I can confirm your fix works in maas 1.9 and aws, now trying local and manual to be certain14:15
dimiternvoidspace, manual bootstrap on wily works fine, a well as local - no unnecessary blocking14:31
dooferladdimitern: http://pastebin.ubuntu.com/14866490/14:42
dooferladdimitern: not sure what happened. Just digging through the logs now.14:42
dimiterndooferlad, hmm interesting - that's reported by FinishBootstrap I think (or thereabouts)14:46
dooferladdimitern: SetBootstrapEndpointAddress14:47
dimiterndooferlad, did you use -m maas by any chance?14:49
dimiternit doesn't look like from the paste14:49
dooferladdimitern: no14:49
dooferladdimitern: I switched to maas, then did the bootstrap14:49
dimiterndooferlad, so it completed, but the juju client messed up saving the endpoint14:52
dimiterndooferlad, it you can repro this, try bootstrap with --debug14:52
dooferladdimitern: looks like it. I am trying again with --debug to see if I get more useful output14:52
dimiterndooferlad, check if you have any surprising/stale stuff in ~/.juju/environments/ (or ~/.juju/ for that matter)14:56
dimiterndooferlad, I found there a cache.yaml file with a section like: "": ... - perhaps that "" was supposed to contain "maas" in your case14:57
dooferladdimitern: yea, it does seem to contain some rubbish14:59
dooferladdimitern: yep, server-data: "": ...14:59
dimiterndooferlad, that cache.yaml is news to me - perhaps a step towards dropping environments.yaml and using (another piece of news) --bootstrap-config argument15:00
dooferladdimitern: looks like it. I just deleted it and am trying again.15:01
dooferladdimitern: this time it has a UUID. Strange!15:02
dimiterndooferlad, yeah, sounds like a bug15:02
dimiterndooferlad, can you please file a bug if that's the cause - having a cache.yaml with empty uuid?15:03
dooferladdimitern: sure.15:04
dimiterndooferlad, cheers!15:05
=== akhavr1 is now known as akhavr
cheryljdimitern, dooferlad  - the api-command-rename branch changed the default juju home, so you'll see weird things if you switch between a juju built before then, and one built after15:28
dimiterncherylj, really, what changed there?15:29
cheryljgah, I can't find what it changed it.15:31
cheryljwhat it changed TO.  give me a minute15:31
=== akhavr1 is now known as akhavr
dimiterncherylj, np, thanks for the heads up :)15:32
frobwaredimitern, dooferlad: the only joy I have right now is to set JUJU_HOME=~/.juju2 if on master/maas-spaces. otherwise switching between that and 1.25 makes things confusing.15:35
cheryljdimitern: the problem I run into is because cache.yaml is now in ~/.juju/models/  so if I try to use an older client, it thinks the environment isn't bootstrapped15:35
cheryljI thought they changed the default juju home, maybe that hasn't happened yet.15:36
voidspacedimitern: thanks for the review - I've tested with maas (spaces are discovered fine) and amazon (no spaces but bootstrap completes fine)15:39
voidspacedimitern: will set to land and work on getting canonistack to work plus testing15:40
dimiterncherylj, I see, thanks15:40
dimiternvoidspace, ta!15:40
mupBug #1541445 opened: empty uuid in cache.yaml after destroy-controller <juju-core:New> <https://launchpad.net/bugs/1541445>15:41
mupBug #1541445 changed: empty uuid in cache.yaml after destroy-controller <juju-core:New> <https://launchpad.net/bugs/1541445>15:44
mupBug #1541445 opened: empty uuid in cache.yaml after destroy-controller <juju-core:New> <https://launchpad.net/bugs/1541445>15:53
perrito666aghh lxd stable ppa provides go 1.6 that is insane15:54
voidspaceperrito666: why is that insance?15:54
perrito666because 1.6 rc1 is not someting I would call stable15:54
perrito666voidspace: also it is a bit intrusive15:56
voidspaceperrito666: ah, RC115:56
perrito666voidspace: yep missed that, but anyway, replacing someones compiler for go is not that nice :p15:56
voidspaceperrito666: ah, it replaces it - yeah, agree15:57
perrito666voidspace: if you apt-get install it in vivid you get golang-go from lxc stable ppa15:57
perrito666which is by no means a good thing to do to someone's system15:57
voidspaceperrito666: do you ever deploy to canonistack15:59
perrito666voidspace: I do not, why?16:00
voidspaceperrito666: I have the right ~/.ssh/config setup so it can bootstrap via ssh16:00
voidspaceperrito666: but I don't have the right sshuttle incantation so it can connect to the apiserver afterwards16:00
voidspacethe one I used to use doesn't any longer16:00
perrito666ah my go to person for that kind of magic usually is sinzui16:00
voidspacegood idea16:01
voidspacenot around though16:01
voidspacemgz: ping16:01
mgzvoidspace: hey16:02
voidspacemgz: hey, hi16:02
voidspacemgz: do you know the right sshuttle incantation to be able to bootstrap to canonistack16:03
voidspacemgz:  I have the right ~/.ssh/config setup so it can bootstrap via ssh16:03
voidspacemgz: but I don't have the right sshuttle incantation so it can connect to the apiserver afterwards16:03
voidspaceso bootstrap still fails16:03
mgzvoidspace: can ou just enable the vpn?16:03
voidspaceI used to use: sshuttle -D -r ubuntu@
voidspacemgz: sshuttle is what I used to use instead of the vpn16:04
voidspacemgz: I would need to setup the vpn to use that, I can do I suppose if it's required - sshuttle seems *better*16:04
mgzyeah, it was the only option before16:04
voidspacemgz: I'll try setting up the VPN, thanks16:05
mgzwhat I do is actually have a machine in canonistack that I bootstrap from, I guess the other option is be fast on the sshuttle incantation when the machine comes up16:08
mgzas you need the address of the bootstrap machine to route to, but if you can't get api to finish bootstrap you need to mid-process set that up16:08
mupBug #1541473 opened:  ensure-availability timesout in 1.25 <blocker> <ci> <ensure-availability> <regression> <juju-core:Incomplete> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1541473>16:12
dimiternfrobware, dooferlad, voidspace's fix landed, and now I'm rebasing my merge to include it - do you foresee any issues with the merge so far? I'd rather land it today if we can16:14
frobwaredimitern, not at the moment. I did have some problems bootstrapping but on reflection I believe that's because I'm jumping between old (1.25) and new.16:15
frobwaredimitern, my merge showed a diff between your api/service/client.go and mine - was just verifying.16:16
voidspacedimitern: an easier way to test "no-networking" would be to patch out (and make it possible to patch out) environs.SupportsNetworking16:17
perrito666so, the answer is "its a ppa" whch is completely fair but we should make sure we dont break people, I think we are recommending said ppa for lxd provider16:18
perrito666katco: natefinch-afk ^^16:19
dimiternfrobware, anything surprising?16:20
dimiternvoidspace, agreed that seems the proper way to fix it and make it test-able16:21
frobwaredimitern, it was in ServiceDeploy() - I had the old len(placements) and len(bindings) ...16:21
frobwaredimitern, just a bit bemused why that it atm.16:22
dimiternfrobware, do you have a diff?16:26
frobwaredimitern, not to hand16:26
frobwaredimitern, why testing mostly on your branch16:27
dimiternfrobware, ok, so ServiceDeploy used to take ToMachineSpec and []Placement, now the latter is used for both16:29
mupBug #1541479 opened: unable to completely destroy-model with LXD provider <juju-core:New> <https://launchpad.net/bugs/1541479>16:30
mupBug #1541482 opened: unable to download charm due to hash mismatch in multi-model deployment <juju-core:New> <https://launchpad.net/bugs/1541482>16:30
perrito666cherylj: I thought master got unblocked last night16:30
cheryljperrito666: not until we get a bless16:31
perrito666cherylj: ah I also thought we got a bless16:32
perrito666well bot will kick me16:32
dooferladdimitern: at long last, I have a clean run of the mediawiki demo.16:33
frobwaredooferlad, \o/16:35
frobwaredooferlad, using which branch?16:35
dooferladfrobware: maas-spaces-merge-master16:36
dimiterndooferlad, great!16:37
frobwaredooferlad, what were the issues?16:38
mupBug #1541479 changed: unable to completely destroy-model with LXD provider <juju-core:New> <https://launchpad.net/bugs/1541479>16:39
mupBug #1541482 changed: unable to download charm due to hash mismatch in multi-model deployment <juju-core:New> <https://launchpad.net/bugs/1541482>16:39
dooferladjust juju 2.0 not playing nice with old configurations and some changes to how it outputs status16:39
mupBug #1541482 opened: unable to download charm due to hash mismatch in multi-model deployment <juju-core:New> <https://launchpad.net/bugs/1541482>16:42
perrito666go rename is wonderful16:47
mupBug #1541479 opened: unable to completely destroy-model with LXD provider <juju-core:New> <https://launchpad.net/bugs/1541479>16:48
mupBug #1541479 changed: unable to completely destroy-model with LXD provider <juju-core:New> <https://launchpad.net/bugs/1541479>16:57
dimiterndooferlad, so it worked ok eventually?16:58
dooferladdimitern: yes16:58
dimiterndooferlad, \o/16:59
dimiternfrobware, I think it's time to push the button :) I'm running make check on maas-spaces-merge-master after rebasing onto voidspace's fix - once it's done I'll push17:00
dimiternfrobware, voidspace, dooferlad, unless any of you feel strongly against merging today?17:00
dooferladdimitern: +117:01
dimiternfrobware, voidspace, last chance? :)17:06
frobwaredimitern, go for it17:07
frobwaredimitern, there's no point waiting. :)17:07
* dimitern types $$merge$$ and hits [Comment]17:07
dimiternfrobware, cheers17:08
frobwaremgz, once maas-spaces is updated can we get a CI run?17:09
mgzfrobware: will do, we're just in some maas untangling now to get a clean 1.25 run17:09
frobwaremgz, ack17:09
voidspacedimitern: frobware: awesome17:35
frobwaredimitern, voidspace, dooferlad: at some point RSN I want to delete upstream/maas-spaces-controller-space-config to avoid any inadvertent runs on that branch. Concerns?17:37
voidspacefrobware: not if it has merged, no17:39
frobwarevoidspace, I will of course double-check. :)  But hopefully our "party" is all taking place in maas-spaces now.17:40
dimiternfrobware, yeah, i'll push another one which is based on maas-spaces after the merge17:43
dimiternand drop the other17:43
frobwaredimitern, push another branch? and to where?17:44
frobwaredimitern, all that "stuff" is in maas-spaces, no?17:44
dimiternfrobware, I have maas-spaces-controller-space-after-master-merge almost ready to push (well, in only slightly better tested state)17:45
frobwaredimitern, but the essence of maas-spaces-controller-space-config is in maas-spaces now, no?17:45
dimiternfrobware, no, not at all17:46
frobwaredimitern, ohhhhhhhhhhhhhhhhhhh17:46
dimiternfrobware, it's not ready yet17:46
frobwaredimitern, well I have to confess that's a surprise for me.17:47
dimiternfrobware, but maas-spaces is up-to-date with master now, so we might get fewer issues17:47
frobwaredimitern, but we still get the failed '' series, no?17:47
dimiternfrobware, I didn't want to churn things too much by combining the relatively straightforward merge from master with the still highly untested controller-space stuff17:48
dimiternfrobware, hmm, well17:48
dimiternfrobware, no17:48
dimiternfrobware, as I believe that was only in my controller-space branch?17:49
frobwaredimitern, does maas-spaces-controller-space-config have all that's currently in maas-spaces? ie. is it rebased?17:49
dimiternfrobware, no, I branched of the merge branch and cherry picked the controller space commits onto it17:49
frobwaredimitern, ok, but testing maas-spaces means we will fail CI tests with space name issues17:49
dimiternfrobware, that's correct17:50
frobwaredimitern, so there's no point running that in CI17:50
dimiternfrobware, not maas-spaces, but maas-spaces-controller-space-after-master-merge is worth testing prior to merging I guess17:51
frobwaredimitern, we need to get that into CI; the easiest way is to push the changes into the existing upstream branch maas-spaces-controller-space-config as CI is setup to run that.17:52
dimiternfrobware, fair point, ok17:52
dimiternfrobware, then I'll rebase it and push17:53
frobwaremgz, ^^ we want to do another run of maas-spaces-controller-space-config, just waiting to land the bits.17:53
frobwaredimitern, which comes back to "any concerns for deleting that branch". Turns out the answer is emphatically yes!17:54
frobwaredimitern, is there a reason for tonight's CI tests we cannot also merge maas-spaces into upstream/maas-spaces-controller-space-config?17:56
dimiternfrobware, sorry, I meant concerns about the master merge branch17:56
dimiternfrobware, i'm doing the rebase of maas-spaces-controller-config onto current tip of maas-spaces now17:57
frobwaredimitern, if you want some sanity testing let me know and I'll try stuff out.17:58
dimiternfrobware, more testing is always welcome :)17:58
dimiternfrobware, will ping you when done and pushed17:58
perrito666rick_h__: hey, are you around?18:08
mupBug #1541536 opened: Deployer and Quickstart failed setting annotations because of socket or json parsing <api> <blocker> <ci> <deployer> <quickstart> <regression> <juju-core:Incomplete> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1541536>18:12
perrito666aghh why are there no good terminal emulators around :(18:17
dimiternfrobware, so I can't seem to convince git to push to the same branch18:24
frobwaredimitern, nope, I suspect I'll have to do it.18:24
dimiternfrobware, so the changes are pushed to https://github.com/juju/juju/compare/maas-spaces...dimitern:maas-spaces-controller-space-after-master-merge?expand=118:24
frobwaredimitern, hmm.18:25
dimiternfrobware, make check passed, live test as well18:25
frobwaredimitern, when you say same branch, you mean your github/dimitern branch?18:25
dimiternfrobware, yep18:26
dimiternfrobware, so I think I should still drop https://github.com/juju/juju/pull/4255 along with the branch and pass dimitern:maas-spaces-controller-space-after-master-merge through CI instead18:28
frobwaredimitern, ok, need to coordinate with mgz18:28
dimiternfrobware, how did you arrange the first ci run? did you push the branch to juju/juju/ ?18:29
frobwaredimitern, the QA folk helped out18:29
dimiternfrobware, ok, so then can I leave you to it?18:30
frobwaredimitern, ok, I need to EOD soon. but I'm hoping mgz has seen "this" conversation18:31
dimiternfrobware, and just to reduce the confusion I'll drop #425518:31
frobwaredimitern, yep18:31
dimiternfrobware, yeah, hopefully - I'll ping in #juju @c as well18:31
dimiternfrobware, cheers18:32
voidspacemgz: ping18:51
rick_h__perrito666: kind of, in a car atm19:51
rick_h__cherylj: will be late to the meeting. in a car between the airport and apt.19:52
rick_h__cherylj: don't see thumper to ping if you can share the info please19:52
cheryljrick_h__: will do19:52
wallyworldcherylj: i may be a touch late to 2.0 meeting20:23
cheryljwallyworld: the release standup?20:23
rick_h__thumper: cherylj all still up for a chat?20:26
thumperrick_h__: happy to, not sure who else is around20:26
rick_h__doh hit the end20:26
thumperrick_h__: I edited the hangout20:26
rick_h__thumper: k20:26
thumperso it is the same as our standup20:26
thumperrick_h__: I'm in the hangout20:27
cheryljrick_h__: we can hear you20:27
thumpercmars: ping21:03
cmarsthumper, pong21:03
thumpercmars: can we have a quick call?21:03
cmarsthumper, certainly21:03
thumpercmars: I have questions regarding migration21:03
thumpercmars: https://plus.google.com/hangouts/_/canonical.com/casey-tim?authuser=121:04
alexisbchanging locations will be back online in about 30 minutes21:10
wallyworldcherylj: ah, i thought we had the 2.0 messaging meeting but i'm a week out21:34
cheryljwallyworld: ah, ok21:34
cheryljI was confused :)21:34
wallyworldyeah, i can see why21:34
davecheneymenn0: perrito666 http://reviews.vapour.ws/r/3700/22:17
menn0davecheney: looking22:18
menn0davecheney: LGTM. You already had a Ship It from me. Land away.22:19
perrito666same here22:19
davecheneycherylj: 1.25 is blocked, do I have your permission to JFDI ?22:20
cheryljdavecheney: is this for the pprof stuff?22:22
cheryljdavecheney: yes, jfdi it.  We want that in 1.25.422:22
thumperalexisb: I have no good internet right now22:56
thumpergoing through my phone's data22:56
thumperhangouts suck too much data for my plan22:56
thumperI've just rebooted the router to see if it was that22:56
alexisbwell we will just make all the important decisions without you then22:56
davecheneywut ?23:05
davecheneylucky(~/src/github.com/juju/juju) % juju ssh -23:05
davecheneyWarning: Permanently added '' (ECDSA) to the list of known hosts.23:05
davecheneync: getaddrinfo: Name or service not known23:05
davecheneyssh_exchange_identification: Connection closed by remote host23:05
thumperdavecheney: you need to specify a machine right?23:16
davecheneyyes, if you give no machine, it will error out23:19
davecheneybut - is not a valid number, machine, or unit23:19
davecheneythat's clearly choosing machine 023:19
davecheneythen bombing because it's passing - to the ssh child process23:19
perrito666I just lost years of my life merging git...23:23
menn0waigani: note that in master the Environment facade was renamed to Model, and then removed completely.23:32
menn0waigani: see https://github.com/juju/juju/commit/95a766fd18728ac9331e4f282efcb7861a1e027723:32
menn0waigani: the Agent facade should be used to call EnvironConfig (now called ModelConfig)23:33
menn0waigani: you probably want to remerge master into the MADE-workers branch and deal with with the fallout23:33
menn0waigani: also note that the proxyupdater has been changed a bit in master too23:34
thumpermenn0: we need to chat at some stage this afternoon about migration of binaries23:35
thumperparticularly charms23:35
menn0thumper: ok23:35
thumpermenn0: also, if you are bored - http://reviews.vapour.ws/r/3729/23:36
thumperwaigani: it looks like you on call reviewer day has dropped off the team calendar23:36
menn0thumper: ok, that's on my queue. I want a few other things closed off first23:36
* thumper heads to lunch23:36
thumpermenn0: np23:36

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!