[01:03] cherylj: ping [01:03] 10:03 < davecheney> cherylj: what's the status of 1.25.4 ? [01:03] 10:04 < davecheney> i'm building up a lot of chagnes on master that should be backported to 1.25 [01:04] davecheney: I think you should prepare the changes for 1.25 branch [01:04] the question becomes whether to do one or many [01:04] davecheney: I hear zfs works real well with lxd [01:07] thumper: should I land what I have now? [01:07] when is 1.25.4 coming out ? [01:07] davecheney: I think some of these connection type issues are needing to be fixed in 1.25 too [01:07] so yes, I think you should be landing these changes on 1.25 too [01:08] anastasiamac: thanks for review, please see my response to your issue before I go ahead [01:08] sweeet master is bless [01:09] perrito666: I hope you kicked off all your merges before you announced that [01:09] axw: no pending merges from me :) [01:09] perrito666: :p [01:12] davecheney, cherylj is out for the evening === alexisb is now known as alexisb-afk [01:17] Bug #1491399 changed: TestInstallMongodServiceExists fails on centos

[01:17] Bug #1494726 changed: TestGetUsesCache different mime-type centos

[01:20] Bug #1491399 opened: TestInstallMongodServiceExists fails on centos

[01:20] Bug #1494726 opened: TestGetUsesCache different mime-type centos

[01:23] Bug #1491399 changed: TestInstallMongodServiceExists fails on centos

[01:23] Bug #1494726 changed: TestGetUsesCache different mime-type centos

[01:25] alexisb-afk: ahh, thanks [01:27] thumper: do we have a error.Causes checker ? [01:27] ie, rather than writing [01:27] errors.Cause(err), gc.Equals, ....) [01:27] can wr write [01:28] I don't think so... [01:28] err, gc.Causes, expected [01:28] i thought you were talking about adding htat way back when [01:28] there is jc.Satisfies [01:28] that checks type [01:28] I'm not sure if that looks at the cause [01:28] which isn't close enough [01:28] pretty sure we don't [01:29] but could be useful [01:29] anyway, i have got my branch to the point that we dont' have to add all that 'request error: ' prefix nonsense [01:29] cool [01:29] which is the whole reason params.ClientError existed -- to filter that out [01:29] now we have *rpc.RequestError as a type, properly annotated all the way back out to the caller [01:31] :) [01:33] thumper: [01:33] - c.Assert(err, gc.ErrorMatches, "permission denied") [01:33] + c.Assert(errors.Cause(err), gc.Equals, &rpc.RequestError{ [01:33] + Message: "permission denied", [01:33] + Code: "unauthorized access", [01:33] + }) [01:34] nice [01:34] ... [01:34] but begs for some new checkers [01:34] c.Assert(err, blah.IsUnauthorized) [01:36] lets see how big the diff is [01:36] i dont want to change more than I have to to backport this to 1.2 [01:36] i dont want to change more than I have to to backport this to 1.25 [01:38] k [01:51] yeah, this attempt is generating a much smaller diff [01:53] Bug # changed: 1497355, 1508585, 1510951, 1514877, 1534201, 1536425, 1536426, 1539656, 1542336, 1543178, 1543189, 1543193 [01:56] Bug # opened: 1497355, 1508585, 1510951, 1514877, 1534201, 1536425, 1536426, 1539656, 1542336, 1543178, 1543189, 1543193 === natefinch-afk is now known as natefinch [01:59] Bug # changed: 1497355, 1508585, 1510951, 1514877, 1534201, 1536425, 1536426, 1539656, 1542336, 1543178, 1543189, 1543193 [02:02] Bug #1538868 changed: kill-controller failed: sudo: switch: command not found

[02:02] Bug #1541473 changed: ensure-availability brings down the state-server

[02:02] Bug #1543216 changed: EOF uploading charm

[02:04] cherylj: hrm. still hasn't run :( [02:04] cherylj: is there a queue somewhere i can look at? [02:08] Bug #1538868 opened: kill-controller failed: sudo: switch: command not found

[02:08] Bug #1541473 opened: ensure-availability brings down the state-server

[02:08] Bug #1543216 opened: EOF uploading charm

[02:09] tych0: we've been busy testing master [02:10] wallyworld_: sorry, I forgot to look at your branch earlier. it's ready to ship now [02:10] tych0: now that we're releasing alpha2, CI should pick up other branches [02:10] axw: np, ty. i've been caught up in other things [02:10] cherylj: ah, ok, cool. [02:11] davecheney: we will probably be doing 1.25.4 after 2.0-beta1. So, sometime the week of Feb-22 [02:18] Bug #1538868 changed: kill-controller failed: sudo: switch: command not found

[02:18] Bug #1541473 changed: ensure-availability brings down the state-server

[02:18] Bug #1543216 changed: EOF uploading charm

[02:19] axw: u r all good to go! HUGE thank you for this PR \o/ [02:19] anastasiamac: thanks, accounts.yaml on its way (basically just a sed command, for real) [02:19] anastasiamac: also, your PRs are reviewed [02:20] axw: u r amazing \o/ tyvm! [02:21] Bug #1538868 opened: kill-controller failed: sudo: switch: command not found

[02:21] Bug #1541473 opened: ensure-availability brings down the state-server

[02:21] Bug #1543216 opened: EOF uploading charm

[02:22] axw: about show-contoller not showing last model... would be nicer to show all models for this controller with indication of current? [02:22] anastasiamac: I think both would be good actually [02:23] axw: excellent \o/ i agree :D [02:24] Bug #1538868 changed: kill-controller failed: sudo: switch: command not found

[02:24] Bug #1541473 changed: ensure-availability brings down the state-server

[02:24] Bug #1543216 changed: EOF uploading charm

[02:26] wallyworld_: I'll fix your comments in my next branch for accounts [02:26] fix/address [02:26] np ata ll [02:41] wallyworld_: when you remove the api-info command, can you please remove ModelCommandBase.ConnectionEndpoint (if you haven't already) [02:41] yup [02:42] axw: i'm waiting to merge your work and then will deal with the inevitable conflicts etc [02:42] wallyworld_: ok [02:43] cherylj: ok, i'll work hard to get all my fixes backported before then [02:46] wallyworld_: axw: list-controllers output in spec shows "-" for not-currently-logged-in... AFAIK there is no precedence, can I just leave the column cell empty or is "-" highly desired? [02:47] * wallyworld_ checks the spec [02:48] p 9 (of 13) [02:48] anastasiamac: I kinda like "-", but prefer consistency [02:48] axw: we can start consistency from here, if it's preferred :D [02:49] "-" is for currently logged in [02:49] not not currently logged in [02:49] right? [02:49] and * is for default [02:49] wallyworld_: USER and MODEL columns [02:50] ah [02:50] wallyworld_: the prefix - is not consistent [02:50] wallyworld_: and list-model uses * suffix to indicate current [02:50] "-" is for the active controller [02:51] you can be logged into more than one [02:51] but only one is active [02:51] wallyworld_: axw and I *thought* *suffix would be nice for active controller too [02:51] how to we denote the default one in that case? [02:52] i agree that we should be consistent [02:52] wallyworld_: we're talking about the "-" in columns that have no value [02:52] wallyworld_: separately, there is some inconsistency in the spec w.r.t. using - vs * for active [02:52] I think we settled on using * as a suffix [02:52] yes :-( [02:52] ok [02:53] wallyworld_: axw: http://pastebin.ubuntu.com/15013438/ [02:53] i must admit, i would like to see "-" for empty region too :-) [02:54] when in doubt, i think we adhere to spec (use "-" for model/user) and ask for feedback [02:54] wallyworld_: yes, I think we should b consistent from now on to show "-" for empty in cmd output :D [02:55] wallyworld_: axw: from the pastebin above, *suffix may be obscured by long names... [02:55] wallyworld_ anastasiamac: added AccountStore [02:55] https://github.com/juju/juju/pull/4379/ [02:55] \o/ [02:55] axw: u r powering thru this \o/ [02:55] anastasiamac: a simple sed command [02:56] :) [02:56] axw: all simple things r ingenious :P [02:57] Bug # changed: 1382274, 1468972, 1497802, 1511659, 1515289, 1533275, 1533896, 1535165, 1536378, 1537717, 1540701, 1542510 [02:58] in your current work, we are moving away from separate current-controller and current-model files right? [02:58] wallyworld_: this is what it looks like form axw's recent PRs \o/ [02:59] wallyworld_: for now we still have current-controller, but current-model will be no more [02:59] great, i only skimmed, just wanted to check :-) [02:59] anastasiamac: ^ [02:59] we can add current-controller to controllers.yaml too though? [02:59] i think so [03:00] Bug # opened: 1382274, 1468972, 1497802, 1511659, 1515289, 1533275, 1533896, 1535165, 1536378, 1537717, 1540701, 1542510 [03:00] axw: although, that embeds user state in that file [03:01] so not sure. makes sense for models file as that's a cache [03:01] wallyworld_: true. and you'd (probably) never share accounts.yaml. [03:02] yes, i was thinking about accounts.yaml too and think i came to the same conclusion that it's ok to put current account in there, but still am not 100% [03:02] i can see a case for a current-ccount file [03:02] wallyworld_: it'll need to be a per-controller file [03:03] true, so in that case, ok as is probably [03:03] Bug # changed: 1382274, 1468972, 1497802, 1511659, 1515289, 1533275, 1533896, 1535165, 1536378, 1537717, 1540701, 1542510 [03:04] axw: wallyworld_: could we plz update blueprint with all files we are unravelling? :P [03:04] one day [03:04] the files are in the spec [03:04] i don't want to duplicate info [03:04] the blueprint should just refer to the spec [03:05] we should have separate as-built doco [03:05] but that's not for the blueprint, we should have that stuff elsewhere [03:05] we're not good at doing that though :-( [03:05] the blue print can refer to the as-built doc [03:06] the blueprint is more to track progess the way we're using it [03:06] wallyworld_: also to communicate with QA [03:07] wallyworld_: this info can b the backbone of Release Notes [03:07] there needs to be separate doc for that IMO - a proper test plan [03:07] wallyworld_: that we tend to write *after* the effect [03:07] file implementation detail is not for release notes [03:08] wallyworld_: \o/ proper test plan would b amazing! [03:08] when and who would do it? [03:08] all the people we don't have :-( [03:08] should be done as the feature is planned, post one page spec [03:08] file implementation detail is not but what files to expect may b of interest to QA [03:08] sure, but that's not what we are using blueprints for [03:09] the spec in this case has the file detail [03:09] but it's not detailed enough for QA - we need a test plan [03:10] wish there were more hours in a day [03:10] wallyworld_: i agree, jeez, a lot of planning and definition needs to happen after one pager :D Test Plans, Acceptance Criteria, Task break down [03:10] indeed [03:10] we do the task breakdown [03:10] wish we had a dedicated resource... :))) [03:10] yes :-( [03:11] wallyworld_: https://www.youtube.com/watch?v=Dj3GH5myc3M [03:11] rotflmao [03:12] you look nothing like a donkey [03:12] are you saying i am an ogre [03:13] wallyworld_: not everything needs to be read literally (just btw the lines) :P [03:13] i know, just going along with the theme [03:13] :)) i know u know [03:17] wallyworld_: a smaller, easier one: http://reviews.vapour.ws/r/3823/ [03:17] looking [03:17] so we don't need to change crap that can just be deleted [03:18] +1 to that [03:18] +2 [03:20] axw: there may be some nuggets in api_test that need to be retain i suspect? [03:20] or at least re-homed [03:21] wallyworld_: the file's not gone, the branch is conflicted so it doesn't show up on RB [03:21] wallyworld_: will fix in a sec, look on GitHub in the mean time please [03:21] ok [03:35] wallyworld_: so once controllers, models, accounts are all in, what else are you waiting on? [03:35] wallyworld_: are you doing the changes to pass controller/model name through, or am I? [03:35] pass through to API conn opening code that is [03:36] i was working to eliminate cache.yaml [03:36] remove bootstrap config etc [03:36] and not write controller addresses, accounts etc [03:36] you could do the work to pass in controller/model first [03:37] i am currently adding private-key to joyent [03:37] * thumper headdesks [03:37] but the credentials stuff needs to pass in the optional attr [03:37] wallyworld_: seems like something you'd do at the same time [03:37] ok, np, i can do do, need to look at the code again [03:37] wallyworld_: that's why I don't want it to be a separate attr, but a flag on the attr that allows you to specify a file [03:38] wallyworld_: I'm happy to do it, just not sure how far into it you are [03:38] the joyent stuff? [03:38] just started looking [03:38] so you can do that if you want [03:38] wallyworld_: no, the API stuff [03:39] i have a branch that i started that has a shit tonne of changes, but many will be conflicting with your recent work; i think it just needs to be discarded [03:39] so you could look to do that next bit while you're on a roll in the area [03:41] wallyworld_: ok. if I can, I'll leave stuff to be done in parallel [03:41] axw: what i can do first if you want is remove the bootstrap config stuff [03:41] that won't conflict too much [03:41] wallyworld_: that would be good [03:42] axw: in the interim, did you want to add that fromfile attr to credentials schema? CI needs it [03:42] as they like to use the private-key directly [03:42] wallyworld_: ok, I'll take a lok [03:42] look* [03:42] ok, ty [03:45] axw: damn, such a long queue waiting to land, hopefully your account store is not at the end [03:46] wallyworld_: maybe just pull my branch down and work off that? [03:46] wallyworld_: actually you shouldn't need it [03:46] if you're just removing bootstrap bits [03:47] might go a bit further depending. wil grab a bite to eat [03:50] /me is surprised thumper's desk is still standing [04:02] thumper: PTAL [04:02] https://github.com/juju/juju/pull/4361 [04:02] totally redone and made much simpler [04:03] no reviewboard link im afraid [04:08] hmm... I wonder why no reviewboard [04:14] 'cos I closed the old review [04:14] removed the link from the description [04:14] but rb didn't add a new one [04:33] bootstrapping [04:33] is [04:33] soooo [04:33] slow [04:33] * davecheney drums fingers while some huge file is uuencoded, sent to the remote bash at a few kb / sec [04:37] thumper: if this bootstrap works [04:37] are you find with me to JFDI this fix onto master [04:37] then I'll roll up a big backport patch for 1.25 [04:37] which fix is this? [04:37] the error stuff? [04:38] https://github.com/juju/juju/pull/4361 [04:38] this is all the groudnwork I think we need to implement retrying on all API requests [04:42] davecheney: yes [04:45] axw: the preferIPv6 flag is used to sort the host api addresses so that ipv6 appear first because we start at the top of the list and try each in turn [04:45] * thumper is off now [04:45]