wallyworldrick_h__: something weird is going on; the ec2 config schema for master is identical to 1.25, so control bucket support should also be the same. so a bug would be good00:00
wallyworldoh wait, you said rax?00:00
wallyworldhow is control-bucket getting into rackspace config00:01
wallyworldand there it is00:01
wallyworldlooks like someone cut and paste some ec2 code into rackspace provider00:02
wallyworldrick_h__: ^^^^ so yeah, that's a bug sadly00:02
rick_h__wallyworld: ok, will file and go back to previous alpha for demo hopefully00:04
rick_h__wallyworld: is there anything I can pass it to make it less cranky in alpha2?00:05
wallyworldyeah, sorry, it's a one line fix by the looks, just a cut and paste error00:05
wallyworldrick_h__: sadly no, i don't think so00:05
rick_h__wallyworld: k, ty for checking for me00:06
wallyworldrick_h__: np, i'll follow up with QA to see how our tests can improve00:06
wallyworldrick_h__: if you need a build for demo, i can do that for you00:07
* wallyworld waits in anticipation00:20
rick_h__wallyworld: ty for the QA follow up.00:20
wallyworldhaven't done it yet, but will do tomorrow when we meet :-)00:21
rick_h__wallyworld: guessing we're not trying to create-model on each provider00:21
wallyworldguess not :-(00:21
rick_h__wallyworld: yea, just got me thinking about how that slipped by00:21
wallyworldrick_h__: i have a feeling a lot of the QA scripts are pre-JES00:22
axwanastasiamac: would you please review this small one? https://github.com/juju/juju/pull/441700:59
anastasiamacaxw: of course \o/01:00
anastasiamacaxw: looks gr8! tyvm01:03
axwanastasiamac: ta01:03
anastasiamacaxw: quartz could b multi-coloured too... and does not imply location (best opals are from Oz \o/) and does not start with "O" like some other teams already...01:20
axwanastasiamac: good points01:23
anastasiamacwallyworld: axw: show-contorller cleaned up http://reviews.vapour.ws/r/3814/01:28
axwanastasiamac: will look shortly01:30
axwoh, I already did shipit01:30
anastasiamacaxw: u did but I've added some output that u might want to agree to...01:31
axwanastasiamac: ok01:31
anastasiamacaxw: no rush, whenever u get a chance \o/01:31
axwanastasiamac: why change to using file-based store?01:33
axwanastasiamac: in the tests01:34
axwwallyworld: a thought just occurred to me, we could change the "restore-bootstrap -b" on its head, and add a "--restore" flag to bootstrap01:36
axwwallyworld: not for now, maybe later01:36
axwwallyworld: I think that would make intent a bit clearer01:36
wallyworldhmm, not a bad idea, i'm asking anastasiamac to do a one pager on this, so she can consider it01:37
anastasiamacaxw: easier to load in tests...01:37
anastasiamacand actually clearer what m loading too...01:37
axwanastasiamac: I'd rather we stop messing with the filesystem if possible. I suspect my change to jujuclienttesting (merging now) would make it clearer/easier for the in-mem case01:38
axwanastasiamac: I won't block it for now, but next time could you please look at the new MemStore, see if it's easier with the new struct?01:39
axwanastasiamac: ... and if not, try and make it easier, so we don't have to touch the filesystem01:39
anastasiamacaxw: k, m happy to wait for ur changes, rebase and updte the tests.01:40
wallyworldaxw: one liner http://reviews.vapour.ws/r/3858/01:41
axwwallyworld: LGTM01:41
anastasiamacaxw: altho, considering list-controller tests depend ont he same stuff.. i'd rather land this and then fix both command testsonce in memory store lands01:42
axwanastasiamac: fine by me01:42
anastasiamacaxw: awesome \o/01:42
anastasiamacaxw: so if u r happy with smaple output (in current tests probably esier to see), then m going to respect ur original ship-it and land01:43
axwanastasiamac: just a moment please, still looking01:43
anastasiamacaxw: nps01:44
axwanastasiamac: couple of small things, and one biggish one -- I think we shouldn't be showing passwords by default01:46
axwwallyworld: ^^01:46
wallyworldof course01:46
anastasiamacaxw: when u say "by default" do u mean not at all?01:47
anastasiamacor do u mean have a flag?01:47
axwcherylj: thanks for letting aaron know -- I've been emailing him about this. Aaron says it's a trivial change01:47
cheryljaxw: ah, ok01:47
axwanastasiamac: I mean, clear out the password flag unless the user provides "--include-passwords" or something01:48
anastasiamacalso isnt this command only displays to users their own accounts?... we are not going out..01:48
axwanastasiamac: someone might want to get the addresses for their controller, and inadvertantly show a conference room their password01:48
anastasiamacaxw: ha. i'll add a flag01:49
anastasiamaccherylj: pm-ed u01:49
axwwallyworld: I've created a "backup/restore 2.0" card under Juju 2.001:52
wallyworldgreat ty01:53
axwthe board is getting out of hand :p01:53
wallyworldyes, too much work :-(01:59
axwwallyworld: do you have time to review another one? https://github.com/juju/juju/pull/4419  -- ignoring the first commit, and the jenv.go stuff in the second one02:43
axw(covered by other PRs)02:43
wallyworldaxw: just heading out, will get to it as soon as i can02:43
axwwallyworld: ok, nps02:43
axwargggggghhhhhhhh. have the state tests gotten worse, or were they always this shit02:54
anastasiamacaxw: probably always02:54
axwseems like every 2nd test run fails because "no reachable servers" or similar02:56
bradmanyone know what generating /etc/rsyslog.d/25-juju.conf ?  its got a dodgy IP in it that I need to remove, from virbr0 as well as all the juju state nodes.  it only appears to be in the state nodes03:15
menn0thumper or waigani: this will be used to replace most of what the current statestarter worker does: http://reviews.vapour.ws/r/3860/03:26
* thumper leaves for waigani03:27
mupBug #1544846 changed: restore fails with could not exit restoring status <nil> <backup-restore> <ci> <regression> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1544846>03:32
waiganimenn0: sorry just saw your PR looking now03:34
mupBug #1544846 opened: restore fails with could not exit restoring status <nil> <backup-restore> <ci> <regression> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1544846>03:35
menn0waigani: np03:35
waiganithumper: btw didn't spot anything weird in the diff. Though I release I merged in tip, not latest blessed master. But still, they're not seeing it at all in master.03:37
thumperwaigani: weird03:38
mupBug #1544846 changed: restore fails with could not exit restoring status <nil> <backup-restore> <ci> <regression> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1544846>03:38
thumperwaigani: I have to head out shortly, so either check in with menn0 or we could go through it tomorrow03:38
waiganithumper: will do. cheers.03:39
mupBug #1545562 opened: Restore assumes systemd present on machines <backup-restore> <juju-core:Triaged> <https://launchpad.net/bugs/1545562>03:53
mupBug #1545563 opened: Cannot deploy service after restoring <backup-restore> <juju-core:Triaged> <https://launchpad.net/bugs/1545563>03:53
mupBug #1545568 opened: api/backups/restore.go has no unit tests <backup-restore> <tech-debt> <juju-core:Triaged> <https://launchpad.net/bugs/1545568>03:53
mupBug #1545562 changed: Restore assumes systemd present on machines <backup-restore> <juju-core:Triaged> <https://launchpad.net/bugs/1545562>03:59
mupBug #1545563 changed: Cannot deploy service after restoring <backup-restore> <juju-core:Triaged> <https://launchpad.net/bugs/1545563>03:59
mupBug #1545568 changed: api/backups/restore.go has no unit tests <backup-restore> <tech-debt> <juju-core:Triaged> <https://launchpad.net/bugs/1545568>03:59
mupBug #1545562 opened: Restore assumes systemd present on machines <backup-restore> <juju-core:Triaged> <https://launchpad.net/bugs/1545562>04:02
mupBug #1545563 opened: Cannot deploy service after restoring <backup-restore> <juju-core:Triaged> <https://launchpad.net/bugs/1545563>04:02
mupBug #1545568 opened: api/backups/restore.go has no unit tests <backup-restore> <tech-debt> <juju-core:Triaged> <https://launchpad.net/bugs/1545568>04:02
=== alexlist` is now known as alexlist
mupBug #1545589 opened: Destroying a model leaves stale current-model file <destroy-environment> <juju-release-support> <juju-core:Triaged> <https://launchpad.net/bugs/1545589>05:35
cheryljwallyworld, axw, could you guys take a look at http://reviews.vapour.ws/r/3861/ ?05:49
axwcherylj: I don't understand this comment: This is necessary as05:58
axw/ the error type returned from a facade call is rpc.RequestError05:58
axw/ and we cannot use params.IsCodeUpgradeInProgress05:58
axwcherylj: RequestError is an rpc.ErrorCoder, so should be usable in params.ErrCode05:58
axw(which is what IsCode... functions use under the hood)05:59
davecheneyan the "code" is just a string06:00
cheryljah, I may have mixed up my comments.  We can't use params.IsCodeUpgradeInProgress, because the code returned from the rpc call *isn't* apiserver.CodeUpgradeInProgress06:02
wallyworldcherylj: sure, looking06:03
cheryljit's the inUpgradeError returned from the upgrading_root06:03
cheryljit was hard to keep track of all the type mismatches06:03
cheryljI'll update the comment06:04
cheryljactually, maybe I'll go back to what it was before, and add in a new function into upgrading_root.go to check IsInUpgradeError06:06
cheryljaxw: how does that sound? ^^06:06
cherylj(and I mean, what I had it as before I committed)06:06
axwcherylj: as in do the check on the servert, and translate to the code that the client was expecting?06:06
cheryljaxw: that's not quite what I was thinking, although I could do that.06:08
axwcherylj: can you explain more? sorry, slow. I'm not keen to have snowflakes that don't use the IsCode... functions06:09
cheryljYeah, I'm sorry, I'm super tired06:09
cheryljI was going to add a func IsCodeInUpgrade()....06:09
cheryljor I could have the existing in Upgrade check see if it matches CodeUpgradeInProgress or the upgrade_root.go inUpgradeErr06:10
cheryljam I still not making sense?  It is after midnight here.  Maybe I should go to sleep and continue this tomorrow06:11
axwcherylj: you may be, but I still don't understand :p06:12
cheryljheh, ok, let me push up a proposed change06:12
axwcherylj: sounds good, I comprehend code better than english06:13
wallyworldaxw: sorry for delay, reviewed your earlier pr, see what you think of suggestions06:35
cheryljaxw: did you have any other concerns with the PR?06:35
axwcherylj: nothing else jumped out06:41
axwwallyworld: thanks, looking in a sec06:42
cheryljok, I'm just retesting with my change.  This takes forever...06:42
wallyworldaxw: later when you are free http://reviews.vapour.ws/r/3862/06:44
cheryljomfg why is it taking 20 minutes to do apt-get update on an AWS instance?!07:00
axwwallyworld: PTAL. looking at yours now07:10
anastasiamacaxw: wallyworld: we don't write to models or accounts files yet, riite?..07:14
axwanastasiamac: I'm working on it07:14
anastasiamacaxw: \o/07:14
anastasiamacaxw: so m not going crazy a little here.. :D07:14
axwwallyworld: just one main concern, about the rpc change07:18
wallyworldaxw: with the remaining ClientStore() comment, i was really trying to look for a way not to have that method07:20
wallyworldthe store is really internal to the command07:20
wallyworldif the method is merely used to see what's been set is nil, can we cater for that another way07:21
axwwallyworld: each controller or model command will need to call ClientStore()07:24
axwwallyworld: well maybe not all of them, but some of them do07:24
axwwallyworld: e.g. list-controllers will call ClientStore() to get the store and then call AllControllers()07:24
wallyworldfair enough lgtm07:25
wallyworldaxw: the version != 0 thing. that appeared fundamentally broken. it totally rejected rpc calls where the version was not 0, and with all the old code removed, tests failed07:28
wallyworldi don't know a reason why we'd not allow rpc calls with version != 007:28
axwwallyworld: version isn't used in that code below there, so I'm a bit concerned that something is passing in a version wrongly07:32
wallyworldaxw: yeah, it was only used in that bogus (IMO) check07:32
wallyworldwhy would we return an error if version != 0 ?07:33
wallyworldI've tested the branch live with lxd, everythign seems fine07:33
wallyworldi'd have to check again, i think the test failure was on the Admin facade07:34
axwwallyworld: sorry, it just doesn't look right. if an object doesn't support versioned methods, then the client shouldn't be requesting them. can you find the object & method that's being requested?07:44
wallyworldi'll check soon, just diggin into some python client stuff07:45
mupBug #1545126 changed: juju/maas do not create ptr reccords for bare metal servers with multiple networks <MAAS:New> <https://launchpad.net/bugs/1545126>07:48
cheryljugh, this upgrade in progress error is funky - the error string is put into the Message and not the Code08:11
anastasiamaccherylj: omg, i hate being the clock but is it not 2am for u?08:12
cheryljanastasiamac: it is08:12
anastasiamaccherylj: wow08:13
dimiterncherylj, that's because it's not a coded error - just like all generic errors it has no code and just message08:13
cheryljdimitern: yeah, but I can't inspect it using errors.Cause() == upgradeErr because it's an rpc.ResultError so the types are different08:14
cheryljso I need to use the check I have08:14
dimiterncherylj, yeah, that's a result of not using concrete errors, unfortunately - and need to resort to strings.HasSuffix(err.Error(), ...) :.08:15
cheryljjust got a ship it from thumper, so fuck it.  I'm merging and trying to get some sleep08:15
dimiterncherylj, you should +108:16
cheryljthanks for taking  a look at that bug, dimitern08:16
dimiternno worries08:16
dimiterncherylj, I hope some of my friday rant on that blocker bug helped a bit :)08:17
axwcherylj: it appears that the IsCodeUpgradeInProgress only works if the original error is state.UpgradeInProgressError08:17
axwcherylj: and not the one in apiserver08:18
cheryljaxw: yeah, I found that out the hard way yesterday08:18
axwcherylj: ok. well, anyway, sleep :)08:18
wallyworldaxw: that rpc FindMethod() call is being asked to find the "Login" method on the "Admin" facade with version = 3. That's when we fail the test. That code comes from api/state.go Login() which tried v2 then fell back to v1 and then v0.So the only reason it was all working is due to some obsolete fallback code in that client Login() method which I removed08:23
axwwallyworld: so the other versions never worked? :/08:24
wallyworldmaster always fell bacl to v008:24
wallyworldor so the code seems to suggest08:24
wallyworldthere were 2 lots is params.IsCodeNotImplemented()08:25
wallyworldin that api state Login()08:25
wallyworldi hate that error08:25
axwwallyworld: sorry, I still need to convince myself08:25
wallyworldaxw: open up api/state.go08:25
wallyworldsee the Login() method at the top08:26
wallyworldi removed the fallbacks08:26
axwwallyworld: I'm *fairly* sure I don't see three Login RPC calls each time I connect though...08:26
wallyworldneed to check i guess, maybe it's the tests only affected. but the code path to the error makes sense. we are passing a version 3 and it complains when it has no right to08:27
wallyworldthe method is there on the facade08:28
axwwallyworld: I'm going to pull your branch and dig a bit. if I can convince myself it's ok, I'll merge it (unless you're still around)08:29
wallyworldi'll be here. i'll see what master does also08:29
axwwallyworld: I think it must be tests only, because live test without that code removed works08:36
axwwallyworld: at the top level we should have apiserver.anonRoot, which has its own FindMethod. I suspect some test is constructing a login facade and serving that directly08:36
wallyworldaxw: but live, we should still be passing the login call to anonroot i would have thought08:38
axwwallyworld: yes... testing live works. it goes to anonRoot, but anonRoot is not one of those rpcreflect things that you changed08:38
wallyworldok, i'll dig into tests later fater dinner. but i still can see why we'd just blanket reject calls with non 0 version08:39
dimiternwallyworld, axw, fwiw apiserver/doLogin calls maintenanceInProgress which fakes up a login request with a user tag08:42
dimiternmight be related, as I discovered while looking into why upgrade/restore didn't work as expected08:42
axwwallyworld: the problem is the errRoot08:55
axwwallyworld: changing that to have a FindMethod which ignores the version, and using ServeFinder does the trick08:56
axwwallyworld: the reason for not accepting a non-zero version is strictness: objects of that type don't understand versions, ergo the client shouldn't request versions. if they do, they're probably doing something wrong08:57
axwsafer to ignore versions on a case-by-case basis08:57
frobwarejam: just rebooting to locate my headset...09:00
jamfrobware: k09:01
=== ashipika1 is now known as ashipika
=== Odd_Blok1 is now known as Odd_Bloke
voidspacedimitern: frobware: dooferlad: if you get a chance http://reviews.vapour.ws/r/3848/09:32
dimiternvoidspace, sure, looking09:33
dimiternvoidspace, reviewed09:39
voidspacedimitern: you think the local machine will never attempt to login (your comment about that code path never being taken)?09:43
voidspacedimitern: won't agents that use the api login as the local machine09:43
dimiternvoidspace, they'll try, but have a look in maintenanceInProgress and follow what happens when the validator return an unknown error (i.e. not UpgradeInProgress or one of the others)09:44
dimiternvoidspace, actually doLogin is the place09:45
voidspacedimitern: hmmm...09:46
voidspacedimitern: I see the code, however that returns a concrete error - and we see the "space discovery in progress" error09:47
dimiternvoidspace, that's why I suggested (not now, but soon) to add a concrete error for discovery in progress and check it early in doLogin09:47
voidspacedimitern: which indicates to me that code path isn't being hit09:47
voidspacedimitern: we hit the code path earlier which just fails - we bail out before maintenanceInProgress is called09:48
voidspacethe switch on concrete error types09:48
voidspacedimitern: but those cases all return a restricted api - we either return full api or no api09:48
voidspacemind you, not if the login succeeds09:49
dimiternvoidspace, yeah09:49
voidspaceah, so for the local machine doLogin still fails09:49
voidspaceso why bother allowing local machine at all09:49
dimiternvoidspace, it fails for any machine09:49
voidspaceit will attempt to login, succeed, then double check to see if arbitrary logins work09:49
voidspacewhen they don't it will bail09:49
dimiternvoidspace, if we get as far down as doCheckCreds and maintenanceInProgress09:50
voidspacewell, only if there's an error09:50
voidspaceif they logged in with local machine (e.g. the discover spaces worker which needs access to the api)09:50
voidspacethey should get that far and doCheckCreds should succeed09:50
voidspaceso it will never hit maintenanceInProgress09:51
dimiternvoidspace, nope, because of line 68 above09:51
jamfrobware: did I miss you somehow?09:51
voidspacedimitern: if the login is from the local machine they will get "case nil"09:51
voidspacedimitern: no error at all09:51
frobwarejam: nope was still there, saw you come back and thought you disconnected09:51
voidspacedimitern: and if the login isn't local machine it will fail completely on line 6809:52
voidspacedimitern: and that's all desired behaviour I think09:52
jamfrobware: yeah, I had to restart the connection, but now I don't seem to see you anymore09:52
frobwarejam: I got disconnected09:53
frobwarejam: live migration. :)09:53
jamfrobware: k. I'm back in the hangout09:53
frobwarejam: trying..09:54
dimiternon error from checkCreds the s.validator is called again with a user tag.. what a mess :/09:54
voidspacedimitern: right, but checkCreds shouldn't fail should it?09:55
wallyworldaxw: changes pushed09:56
dimiternvoidspace, I'd expect so09:57
dimiternvoidspace, but maybe it's deeper than that - e.g. something around empty uuid (for backwards compatibility), the MA trying v2 then v1 / v0 ?09:58
dooferladdimitern, voidspace, frobware: may be a tiny bit late for standup - just off to get coffee.09:58
dimiterndooferlad, np09:58
axwwallyworld: reviewed09:59
axwgotta go take care of the kids for a while, bbl09:59
menn0fwereade: would you mind having a look at http://reviews.vapour.ws/r/3860/ pls?10:06
menn0fwereade: a bit of infrastructure for converting the state worker to work under the dependency engine10:06
dimiternvoidspace, standup?10:08
voidspacedimitern: oops, sorry - omw10:09
voidspacedimitern: frobware: uhm, I can't login10:11
voidspacedimitern: frobware: I lost my phone over the weekend - I thought I had some saved codes for two factor auth in my gmail account10:11
voidspacedimitern: frobware: but I don't - I'll have to contact IS to get them to turn off two factor temporarily10:11
voidspacedimitern: frobware: sorry :-(10:12
voidspacedimitern: frobware: dooferlad: my standup report - test fixes and discovery reliability landing now10:12
dimiternvoidspace, ok, np10:13
voidspacedimitern: frobware: dooferlad: I've been working on having the maas provider (maasInstance) Addresses method add provider id10:13
voidspacedimitern: frobware: dooferlad: that's complete but needs gomaasapi support for the spaces endpoint in the test server10:14
voidspacedimitern: frobware: dooferlad: which is partly implemented but not usable (or tested) - so I've been working on that10:14
voidspacewhen that is done I can test my branch for provider ids and land that10:14
voidspacedimitern: frobware: dooferlad: caveat is that we need both the provider id *and* the space name10:14
voidspacedimitern: frobware: dooferlad: so addresses out of the provider will have space name and id set - but this will be a *maas name* not a juju name for the space10:15
voidspacedimitern: frobware: dooferlad: so we have to ensure it is converted before ever storing it in state or we will confuse ourselves a great deal10:15
voidspacedimitern: frobware: dooferlad: *or* we add SpaceProviderName *as well*, which is annoying but might be better10:16
voidspaceor we just use provider id and don't set the provider space name, this might actually be better10:17
voidspacebut we have code that currently relies on having the name set I think10:17
dimiternvoidspace, let's sync up on this after standup10:17
voidspacedimitern: ok10:18
perrito666morning all11:02
perrito666mm, odd for some operations lxd provider seems to be unregistered11:27
mupBug #1545686 opened: Multi-series not backwards compatible <juju-core:New> <https://launchpad.net/bugs/1545686>12:03
mupBug #1545686 changed: Multi-series not backwards compatible <juju-core:New> <https://launchpad.net/bugs/1545686>12:06
mupBug #1545686 opened: Multi-series not backwards compatible <juju-core:New> <https://launchpad.net/bugs/1545686>12:12
mupBug #1545686 changed: Multi-series not backwards compatible <juju-core:New> <https://launchpad.net/bugs/1545686>12:18
mupBug #1545686 opened: Multi-series not backwards compatible <juju-core:New> <https://launchpad.net/bugs/1545686>12:24
axwwallyworld: there are assumptions in the code that the initial controller name == initial model name12:51
axwwallyworld: so I've had to revert the model name back to controller name, from "admin"12:51
wallyworlddamn, i thought we could work around those12:51
axwwallyworld: possibly in a follow up, but it wasn't working right12:51
wallyworldsure np12:52
wallyworldi wasn't fully across how deeply ingrained the assumption was12:52
rick_h___thanks for trying!12:53
wallyworldrick_h__: temporary setback, it will be fixed :-)12:53
axwwallyworld: sorry about the rambling PR, the tendrils keep spreading12:53
rick_h___wallyworld: is there anyone that can hand hold an outside commit? Looks like OCR is out today (domas)12:53
rick_h___wallyworld: https://github.com/juju/juju/pull/4426 is from an outsider through the mailing list trying to get the m4 types to work12:54
rick_h___wallyworld: so needs some kid gloves and "yay outside commits" love and such12:54
wallyworldrick_h__: perrito666 would love to :-)12:54
rick_h___ty :)12:54
wallyworldhe's at SOD12:54
wallyworldrick_h__: longer term, we want to query those instance types using the new aws api12:55
wallyworldmaybe for 2.112:55
rick_h___wallyworld: completely understand and agree12:55
rick_h___marcoceppi: ^ fyi12:56
axwwallyworld: at the very least, we should probably stop caring about the region and assume theyre the same relative costs across all12:56
rick_h___marcoceppi: faster to reply than me :P12:56
wallyworldaxw: that is sensible, the costs are just approximate anyway12:57
wallyworldused in sorting12:57
wallyworldto select the cheapest by default12:57
axwI'm off, bonne nuit12:59
mupBug #1545704 opened: no-auto-upgrade not respected in environments.yaml <kanban-cross-team> <landscape> <juju-core:New> <https://launchpad.net/bugs/1545704>13:06
rick_h___marcoceppi: ?13:08
rick_h___marcoceppi: also fyi email on the way I need help on asap please so I can help the team out13:08
marcoceppirick_h___: I like the idea of moving aws queries out of the codebase13:08
rick_h___marcoceppi: oic, yea. I more meant that we have a reviewer nominated so we don't both bug folks on it.13:09
rick_h___marcoceppi: but yea, moving the instance types out is a long standing wishlist thing for the team heh13:09
marcoceppirick_h___: oh, cool. I just say I'm going to bug someone but never actually do it ;)13:09
rick_h___marcoceppi: :P13:09
wallyworldrick_h__: marcoceppi: until recently we haven't had the option for aws. was built into openstack from day one13:12
mupBug #1545712 opened: WARNING juju.network address.go:268 no hostPorts found in space "default" <network> <juju-core:New> <https://launchpad.net/bugs/1545712>13:12
rick_h___wallyworld: yea, the new api for that data is good stuff from aws13:22
wallyworldand not a day too soon13:22
=== akhavr1 is now known as akhavr
mupBug #1545704 changed: no-auto-upgrade not respected in environments.yaml <kanban-cross-team> <landscape> <juju-core:Invalid> <https://launchpad.net/bugs/1545704>13:42
mupBug #1545713 opened: Lost Unit when specifying constraints incorrectly <juju-core:New> <https://launchpad.net/bugs/1545713>13:43
tvansteenburghwallyworld: you and dpb1 proceed w/o me on the python-jujuclient stuff - i can't make the meeting. if i need to be in the loop (to help with the actual work), please take notes or something.13:57
=== akhavr1 is now known as akhavr
voidspacefrobware: dooferlad: dimitern: in sapphire room?14:01
voidspacefrobware: dooferlad: dimitern: our normal retrospective room, or our normal standup room?14:02
voidspaceI'm in sapphire alone...14:02
dooferladvoidspace: https://plus.google.com/hangouts/_/canonical.com/juju-sapphire14:03
frobwarevoidspace, normal standup14:03
dooferladvoidspace: that is where andrew and I are14:03
voidspaceI guessed wrong...14:03
dimiternfrobware, voidspace, dooferlad, sorry guys just got back in, omw14:04
marcoceppiwallyworld: I'll be filling in for tvansteenburgh tomorrow14:15
wwitzel3the ol' bait and switch14:21
perrito666ohh, today is a holiday in the US, that explains the silence14:41
rick_h__we're paying respects to our presidents today14:42
perrito666you clearly have better presidens than we do :p14:42
=== mbruzek is now known as mbruzek-holiday
bogdanteleagado charms need to be changed in any way for 2.0? I've got one charm I've been using for a while now for testing, but it doesn't even get downloaded to the machine16:06
voidspacefrobware: dimitern: dooferlad: PR for gomaasapi spaces support https://github.com/juju/gomaasapi/pull/416:08
dimiternvoidspace, looking16:13
dimiternvoidspace, what's the significance of the *Space used in server.spaces ?16:30
dimiternvoidspace, it is an optimization to not fetch subnets again?16:30
voidspacedimitern: no, it's so that any changes persist rather than them being copied16:32
voidspacedimitern: it makes them mutable16:32
dimiternvoidspace, right16:32
dimiternvoidspace, LGTM16:33
voidspacedimitern: thanks16:34
dimiternwe should really sort out the growing code duplication in gomaasapi soon btw16:34
voidspacedimitern: fair point about goroutine safety - but this is a test server16:35
voidspacedimitern: and incrementing id rather than dict iteration preserves order of result by id16:36
dimiternvoidspace, yeah16:37
voidspacedimitern: not my code but I assume that is the intent16:37
dimiternvoidspace, exactly :)16:37
dimiternvoidspace, that's the point - if the reason is not obvious, the code needs refactoring16:37
voidspacedimitern: well, a comment would do16:38
dimiternvoidspace, +116:38
dimiternjust because it's test code doesn't mean we shouldn't try to make it clean16:38
voidspacedimitern: I've added a comment16:39
voidspacedimitern: does $$merge$$ work here?16:39
voidspacedoesn't look like it16:39
dimiternvoidspace, cheers16:39
dimiternvoidspace, yes, it should16:39
voidspaceah well, I'll wait a bit and see then16:39
voidspaceah yes, merge request accepted16:40
voidspaceaaand merged16:40
dimiternvoidspace, sweet :)16:40
voidspaceback to juju then16:41
=== mbruzek is now known as mbruzek-holiday
=== thumper is now known as thumper-dogwalk
perrito666wallyworld: be warned, it is starting to rain here so power might go off (just in case I dont show at the standup)23:06
axwwallyworld: I might have to look at fixing the "juju status" code this morning, it takes 10 minutes every time I do a full test run...23:08
axwkilling me23:08
axwjust the cmd/juju/status package23:09
davecheneyuh, why does the apiserver import the api client during testing ?!?!23:48

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!