axw | wallyworld: almost there, but I need to duck out | 00:11 |
---|---|---|
axw | wallyworld: I'll push the code now, and fix the remaining bugs when I get back | 00:12 |
wallyworld | axw: no problem, ty | 00:12 |
axw | wallyworld: https://github.com/juju/juju/pull/4469 | 00:13 |
wallyworld | ta | 00:14 |
mup | Bug #1547268 opened: Can't bootstrap environment after latest lxd upgrade <juju-core:New> <https://launchpad.net/bugs/1547268> | 00:26 |
thumper | fwereade: are you still lurking? | 00:29 |
axw | wallyworld: bugs fixed, PTAL | 01:07 |
wallyworld | looking | 01:10 |
wallyworld | axw: did you see my last question about map/slice? | 01:11 |
axw | wallyworld: I didn't. no, it won't work, goyaml will unmarshal it as the default types (MapItem is (interface{}, interface{})) | 01:12 |
wallyworld | and we can't do a type assertion? | 01:13 |
axw | wallyworld: no... that's never going to work. goyaml just sees a MapSlice, it doesn't know you want it to be a region | 01:13 |
wallyworld | ok | 01:14 |
wallyworld | axw: also, change the version to beta1 in the PR so we land one change | 01:14 |
axw | wallyworld: sure, just about to rebase on master, will do that | 01:15 |
wallyworld | axw: and just for sanity since we need this to get blessed with one run, test live? | 01:15 |
axw | wallyworld: will do | 01:15 |
wallyworld | ta | 01:15 |
katco | axw: o/ | 01:17 |
axw | katco: heya | 01:17 |
katco | axw: don't need anything, just thought i'd say hey while the opportunity presents itself :) | 01:17 |
axw | katco: :) | 01:17 |
axw | katco: I was looking forward to having standups with you and the others, timezones suck | 01:18 |
katco | axw: that they do. i'm positive we'll be in one together sometime in the near future | 01:18 |
axw | maybe I'll get up before the crack of dawn one day | 01:19 |
katco | axw: haha, that will be a nice surprise, but certainly not expected | 01:19 |
katco | axw: wallyworld said, "we'll all just move to st. louis" which i think is an awful idea | 01:19 |
katco | axw: of course i'm not sure i'd like to live in the land of giant spiders either :| | 01:20 |
axw | katco: heh :p | 01:20 |
axw | they mostly just sit there and watch you | 01:20 |
katco | that's even worse! | 01:21 |
axw | wallyworld: what magic do you use to preserve the line ending in setup.iss when updating the version? or does it not matter? | 01:25 |
wallyworld | axw: i think my IDE respects what is there | 01:26 |
sinzui | axw, in every editor I have used to edit setup.iss, all is fine, but git's diff makes the line ending look scary | 01:29 |
axw | sinzui: ok, thanks. I'll sed it and hope for the best | 01:29 |
axw | wallyworld: https://github.com/juju/juju/pull/4470 <- same changes + delta1->beta1 | 01:33 |
wallyworld | looking | 01:34 |
wallyworld | axw: lgtm | 01:34 |
=== beisner- is now known as beisner | ||
axw | wallyworld: I'm going to copy&paste the bootstrap release notes as a reply to your email | 02:28 |
axw | wallyworld: so people know how to bootstrap... and thye can vet the notes at the same time | 02:28 |
wallyworld | axw: ah yes, good idea, ty | 02:28 |
wallyworld | axw: i am so used to the new syntax i forgtot others wouldn't be :-) | 02:29 |
wallyworld | other devs | 02:29 |
axw | wallyworld: I can update the list-clouds output if you like | 02:34 |
axw | if you're not already doing it | 02:34 |
axw | wallyworld: list-clouds output order is not right :/ must be another map somewhere | 02:36 |
wallyworld | damn | 02:37 |
wallyworld | in the cmd i guess | 02:37 |
axw | wallyworld: yep, in cmd/juju/cloud/show.go | 02:37 |
wallyworld | axw: but the default regon is correct. so we can add a note in the release notes | 02:38 |
wallyworld | that list-clouds will be fixed next beta | 02:38 |
wallyworld | axw: i'm out for a bit so will pick up any remaining release notes issues when i get back unless you get to them first | 02:38 |
axw | wallyworld: sure | 02:38 |
axw | enjoy lunch | 02:39 |
natefinch | gaaaah uniter tests | 02:50 |
menn0 | thumper and/or waigani: http://reviews.vapour.ws/r/3907/ | 03:43 |
thumper | pending tests, I *think* I have relation imports working | 03:46 |
thumper | well, haven't tried to compile yet | 03:46 |
thumper | but the theory seems sound | 03:46 |
thumper | menn0: I'll take a look now before writing tests | 03:47 |
waigani | menn0: oh, was just going to look .... | 03:47 |
menn0 | thumper: I like your optimism :p | 03:48 |
* menn0 facepalms | 03:48 | |
thumper | waigani: you can look too | 03:48 |
thumper | that's fine | 03:48 |
waigani | thanks :) | 03:48 |
menn0 | some people I know in Brisbane (acquaintances) just called their son "Pheonix" | 03:49 |
menn0 | at least check the spelling of a word before calling using it for your child's name... | 03:50 |
natefinch | lol | 03:51 |
thumper | heh | 03:51 |
thumper | are they going to "fix" it? | 03:52 |
natefinch | friends of mine called their kid Orion... she's a girl | 03:52 |
thumper | or is this one of those new alternative spellings? | 03:52 |
thumper | at least not "north" or another direction | 03:53 |
natefinch | haha | 03:53 |
natefinch | another friend named their kid Aoife... which is evidently irish and pronounced eefah ... but yeah, good luck kid. | 03:54 |
thumper | menn0: done | 04:12 |
menn0 | thumper: thanks | 04:13 |
menn0 | thumper: man, I'm clearly tired. lots of stupid stuff | 04:21 |
thumper | :) | 04:24 |
davecheney | All, what is the client facade in the api server ? | 04:37 |
davecheney | is the apiserver a client of itself ? | 04:37 |
davecheney | is this a version of the human centepede ? | 04:37 |
davecheney | no, seriously | 04:49 |
davecheney | what is the Client facade that the API exports | 04:49 |
davecheney | axw: do you know | 04:49 |
axw | davecheney: it's the facade that does all the things that the CLI client wants to do. we've been slowly splitting bits out into new, more specific facades | 04:50 |
menn0 | davecheney: what axw said. It has (predictably) grown into a kitchen sink of functionality. | 04:51 |
axw | davecheney: e.g. the Service facade for deploying. that used to be on the Client facade | 04:51 |
menn0 | davecheney: nothing new should be added to Client now | 04:51 |
davecheney | so apiserver/client | 04:51 |
davecheney | imports api/ to get api.CharmInfo | 04:52 |
davecheney | this is 3 inches away from an import loop | 04:52 |
davecheney | client is a shitty name for an api endpoint | 04:52 |
davecheney | it would be like me having a child and calling it "person" | 04:52 |
menn0 | thumper: review responded to: http://reviews.vapour.ws/r/3907/ | 04:57 |
davecheney | hey can anyone get to ap-southeast-2 at the moment ? | 05:02 |
davecheney | ok, so trying to hit aws.amazon.com is routing via tokyo | 05:07 |
natefinch | your packets have a hankering for sushi, I guess | 05:08 |
davecheney | om nom nom | 05:08 |
natefinch | well, I've officially added a new test to the uniter. And it only took 3 days. | 05:09 |
natefinch | that's not fair. The test only took a day, it was 2 days of wrestling with the existing tests to figure out why they were failing. | 05:10 |
natefinch | but the test is only 3 lines, which obviously saved me a lot of time. | 05:11 |
thumper | :) | 05:12 |
davecheney | we have two CharmInfo structures delcared in the client | 05:32 |
davecheney | api.CharmInfo | 05:32 |
davecheney | api/charms.CharmInfo | 05:32 |
davecheney | !!!! | 05:32 |
davecheney | THEY ARE IDENTICAL | 05:33 |
thumper | bah, extra tests can wait | 05:33 |
davecheney | and in fact they have the same method on their type | 05:33 |
=== thumper is now known as thumper-afk | ||
davecheney | axw: what the F | 05:35 |
davecheney | https://github.com/juju/juju/blob/master/api/charms/client.go#L15-L43 | 05:35 |
davecheney | https://github.com/juju/juju/blob/master/api/client.go#L161-L178 | 05:35 |
axw | davecheney: I suspect the one in api should have been deleted | 05:36 |
davecheney | trying to figure out which one is unused now | 05:36 |
axw | davecheney: it should be in the params package anyway | 05:37 |
axw | wait... there is one in the params package | 05:37 |
axw | sorry | 05:37 |
axw | never mind. | 05:37 |
davecheney | the api/charms package's CharmInfo method is not used | 05:40 |
davecheney | if I remove the method | 05:40 |
davecheney | then api/charms no longer needs to import "gopkg.in/juju/charm.v6-unstable" as charm | 05:40 |
davecheney | which undermines the name of the whole package | 05:40 |
axw | davecheney: sounds good. that apiserver/client code for CharmInfo might still be required for the GUI, not sure. should be safe to remvoe the api code tho | 05:42 |
davecheney | if the gui needs it | 05:43 |
davecheney | all it cares about is the json form | 05:44 |
davecheney | which is what I was checking | 05:44 |
davecheney | but it turns out that no copies of CharmInfo have any json tags | 05:44 |
davecheney | so we can just replace them with an anon stryct | 05:44 |
davecheney | so we can just replace them with an anon struct | 05:44 |
davecheney | axw: besides i'm removing code from api/ | 05:47 |
davecheney | so the gui won't be affected | 05:47 |
axw | davecheney: yeah, I'm saying that's fine, but we should check before going further and removing the backend from apiserver/client | 05:48 |
axw | not that you said you were going to, just in case | 05:48 |
davecheney | axw: https://github.com/juju/juju/pull/4474 | 05:53 |
davecheney | yeah, i won't remove that method | 05:53 |
davecheney | just it's dependency on a type defined in it's client | 05:53 |
davecheney | just its dependency on a type defined in its client | 05:53 |
axw | davecheney: uh sorry, lost in translation. I thought you were removing them from the api/client.go code. I'm pretty sure the code should be changed to use api/charm instead of api | 05:56 |
natefinch | man, I'm going to start squashing all my branches down to a single commit... it makes rebasing and cherry-picking and all that garbage so much easier. | 06:04 |
natefinch | axw: on that review where I'm trying to get API params to show during tests... you said to tweak the logging instead. Do you know where that would be done? JujuConnSuite or something? | 06:11 |
axw | natefinch: if it's for a full stack test, which I assume it is if you need logs, that'd probably be the appropriate spot | 06:12 |
wallyworld | axw: looks like CI is borked so lets sneak this one in http://reviews.vapour.ws/r/3911/ | 06:45 |
axw | wallyworld: ... http://reviews.vapour.ws/r/3906/ | 06:46 |
wallyworld | damn :-) | 06:46 |
wallyworld | axw: but does map slice work as expected for json | 06:47 |
axw | wallyworld: it'll come out as a [{Key:name, Value:{...}}] | 06:58 |
axw | wallyworld: not ideal. hadn't thought of JSON | 06:58 |
wallyworld | axw: i think my solution works for json | 06:58 |
wallyworld | i could add you test stuff to my branch | 06:59 |
axw | wallyworld: yes please | 06:59 |
wallyworld | sure, will do | 06:59 |
axw | wallyworld: except mines based on formatting/parsing the YAML... | 06:59 |
axw | wallyworld: maybe the YAML format could use Regions instead of RegionsMap? | 07:00 |
wallyworld | axw: to preserve order, yeah, good point | 07:01 |
wallyworld | i'll rework it a bit | 07:01 |
dimitern | wallyworld, axw, just running make check now on master triggered my chrome to open up and ask for credentials - could it be related? | 07:16 |
wallyworld | credentials for what? | 07:16 |
dimitern | well, the sso screen | 07:16 |
axw | dimitern: nothing to do with our changes. *maybe* related to macaroons? | 07:17 |
dimitern | axw, ah, could be | 07:17 |
axw | wallyworld: what version of lxd do you have? | 07:17 |
axw | I dist-upgraded and now lxd provider doesn't work. | 07:18 |
wallyworld | axw: sadly i updated today and so i suspect i am borked | 07:18 |
axw | :/ | 07:18 |
wallyworld | yep, known issue, casey files a bug | 07:18 |
wallyworld | they don't test juju with their stuff it seems | 07:18 |
wallyworld | bug 1547268 | 07:19 |
mup | Bug #1547268: Can't bootstrap environment after latest lxd upgrade <juju-core:New> <https://launchpad.net/bugs/1547268> | 07:19 |
axw | wallyworld: lxd_2.0.0~beta2 is OK, FYI | 07:21 |
axw | just uninstalled and installed the deb from cache | 07:21 |
wallyworld | axw: yeah, i think i was running that one priot to the upgrade | 07:21 |
=== urulama__ is now known as urulama | ||
wallyworld | axw: PTAL, also fixed a bug where we were printing storage endpoint in region details even if it was the same as the cloud default storage endpoint | 07:30 |
axw | wallyworld: the same applies to Endpoint | 07:32 |
wallyworld | doh | 07:33 |
wallyworld | of course | 07:33 |
axw | wallyworld: are we pushing the register one through as well, or wait till after? | 07:42 |
wallyworld | axw: it seems pretty safe doesn't it | 07:43 |
wallyworld | will only fail in unit tests | 07:44 |
axw | wallyworld: yeah, also pretty safe to leave it out tho. assuming people don't expect to be able to upgrade from a beta to release... | 07:44 |
wallyworld | we don't support upgrade, and models.yaml is changing also anyway | 07:45 |
axw | true | 07:45 |
axw | wallyworld: I'll just leave it till later. no need to rush it through | 07:46 |
wallyworld | +1 | 07:46 |
wallyworld | i hope this current change gets through CI in time | 07:46 |
wallyworld | shoudl do | 07:46 |
frobware | dimitern: ping | 09:09 |
dimitern | frobware, pong | 09:12 |
frobware | dimitern: can we do standup now? james is out, as is michael, and I want to futz with my hosts /e/n/i. :) | 09:12 |
dimitern | frobware, sure, why not - omw | 09:12 |
frobware | dimitern: ah, I suspect I'm in the wrong HO... tis Friday. | 09:15 |
=== urulama_ is now known as urulama | ||
cmars | https://bugs.launchpad.net/juju-core/+bug/1547268 | 14:04 |
mup | Bug #1547268: Can't bootstrap environment after latest lxd upgrade <juju-core:New> <https://launchpad.net/bugs/1547268> | 14:04 |
cmars | latest lxd (2.0.0~beta3) upgrade seems to break the LXD provider ^^ | 14:05 |
cmars | wily does not seem to be affected, but if you're installing lxd from the lxd-stable PPA on trusty, or testing xenial, you'll see it | 14:06 |
cmars | also, i can't seem to juju init with latest master. gonna open a bug... | 14:06 |
katco | ericsnow: hey i left several comments on your download resource metadata pr... lmk if you want to chat about it | 15:04 |
katco | natefinch: how goes the uniter tests? | 15:04 |
natefinch | katco: got them working last night, finally. | 15:05 |
katco | natefinch: woohoo! ah i see your review now | 15:08 |
katco | natefinch: moved your card for you | 15:08 |
katco | natefinch: can you give ericsnow's prs a review? | 15:08 |
natefinch | katco: will do | 15:09 |
ericsnow | katco: thanks | 15:29 |
katco | natefinch: review up | 15:44 |
natefinch | katco: thanks! | 15:44 |
mup | Bug #1547186 changed: Cannot create model with Azure provider <docteam> <juju-core:Invalid> <https://launchpad.net/bugs/1547186> | 15:58 |
perrito666 | does anyone know how livetests work? | 15:59 |
natefinch | perrito666: nope | 16:04 |
perrito666 | they seem to be mocking ec2, not sure where | 16:05 |
katco | perrito666: hey i know a bit how they work | 16:06 |
perrito666 | katco: can you give me a hint? :) | 16:07 |
katco | perrito666: no, i just wanted to let you know i knew :) 1 sec | 16:07 |
katco | perrito666: https://github.com/go-amz/amz/blob/v1/ec2/ec2test/server.go | 16:07 |
katco | perrito666: except you probably want latest, so make sure you hit the v3/v4 branch | 16:08 |
dimitern | frobware, hey | 16:08 |
niedbalski | perrito666, mfoord do you guys know if LP 1435283 is entirely fixed? we are seeing a weird behavior with 1.25.0 (http://paste.ubuntu.com/15132753/) , basically is picking any address as the public-address instead of using a sticky one since first election. | 16:09 |
dimitern | frobware, I've proposed the next step: https://github.com/juju/juju/pull/4481, a few things still remain around tests, but I need to go out, so I'd appreciate if you have a look later | 16:09 |
perrito666 | niedbalski: have no clue | 16:09 |
niedbalski | dimitern, can you take a look ? ^^ | 16:10 |
dimitern | fwereade, if you're around, I'd very much like your thoughts on that as well ^^ | 16:10 |
perrito666 | katco: thanks taking a look, I am pretty sure the filter I need is not implemented, because such is my luck | 16:10 |
* dimitern reads scrollback | 16:10 | |
katco | perrito666: =/ lmk if you need anything else | 16:10 |
dimitern | niedbalski, well, the fix for that bug in 1.25 IIRC was to ensure whatever gets picked for private/public address sticks for the lifetime of the machine | 16:12 |
dimitern | the story for 2.0 is a lot better though | 16:12 |
* dimitern needs to step out, perhaps back later | 16:13 | |
niedbalski | dimitern, well, it doesn't seems to be the case with 1.25.0 http://paste.ubuntu.com/15132831/ | 16:16 |
fwereade | dimitern, sorry, I don't think I have any special insight -- did I michael EOWing the other day? | 16:20 |
katco | ericsnow: review on your other pr | 16:27 |
ericsnow | katco: thanks! | 16:27 |
ericsnow | katco: you're tearing it up! | 16:27 |
katco | ericsnow: uninterrupted blocks of time! | 16:27 |
ericsnow | katco: get used to it :) | 16:28 |
ericsnow | katco: (and the consequences <wink>) | 16:28 |
katco | ericsnow: natefinch: master merged into the feature branch cleanly. merge PR CI run underway | 16:31 |
katco | (god bless the component oriented approach) | 16:32 |
perrito666 | bbl, | 16:32 |
perrito666 | katco: btw, thank you for the pointer it was very helpful. | 16:32 |
katco | perrito666: np, i'm hear for anything you need in the future | 16:32 |
katco | perrito666: i am the ian of the western hemisphere | 16:32 |
katco | perrito666: bleh... s/hear/here/g | 16:33 |
ericsnow | katco: +1 (long live the component-oriented approach!) :) | 16:34 |
natefinch | katco: awesome about merging master | 16:36 |
katco | ericsnow: natefinch: 7 line change: http://reviews.vapour.ws/r/3916/ | 16:50 |
dimitern | fwereade, sorry for the mix up, I meant if you can have a look at this PR https://github.com/juju/juju/pull/4481 | 17:10 |
lazyPower | hi o/ | 17:16 |
lazyPower | did we nuke kvm as a provider option when we nuked the local provider? | 17:16 |
mbruzek | I am trying to set up juju 2.0 and I really need kvm | 17:16 |
lazyPower | mbruzek really wants to know | 17:16 |
mbruzek | I get an error when bootstrapping kvm. | 17:16 |
mbruzek | ERROR model "kvm" has an unknown provider type "local" | 17:17 |
mbruzek | Does anyone know how I can use kvm in 2.0? We need that because containers currently don't run in lxd. | 17:17 |
katco | lazyPower: mbruzek: if we did, that was unintended | 17:18 |
katco | tych0: do you have any insight? ^^^ | 17:18 |
lazyPower | mbruzek - app-containers *ftfy | 17:18 |
mbruzek | katco: I tried changing the provider to "kvm" that did not work either. | 17:18 |
mbruzek | katco: I was really happy with the kvm support in juju 1.25 it was nearly as fast as the lxc provider, and it let me run docker containers inside kvm machines. | 17:19 |
katco | mbruzek: good to hear. we'll figure out what's going on. it should still work, so either an oversight or we've changed how you interact with it | 17:20 |
mbruzek | katco: Yeah if there is a new way to configure it I would be willing to test those instructions out. | 17:21 |
mbruzek | katco: I checked the docs and seem to be configuring it properly | 17:22 |
mbruzek | https://jujucharms.com/docs/devel/config-KVM | 17:22 |
katco | ericsnow: natefinch: master merged into feature-resources. i don't expect you to have conflicts, but might want to rebase all the same. | 17:28 |
ericsnow | katco: k | 17:28 |
* katco lunches | 17:28 | |
ericsnow | natefinch: I just reviewed your patch | 19:27 |
natefinch | ericsnow: thanks! | 19:27 |
natefinch | ericsnow: in theory, resources in the DB shouldn't ever change unless their bytes change, right? It would be kind of bad if a resource got updated with a different origin or type or something | 19:48 |
ericsnow | natefinch: that's mostly true | 19:50 |
natefinch | ericsnow: there's two logical parts of a resource - the definition as exists in the charm metadata, and the bytes + metadata about the bytes | 19:50 |
ericsnow | natefinch: if I remember right, there's also info for a resource that will have bytes stored soon | 19:51 |
ericsnow | natefinch: e.g. charm store resource where no unit has called resource-get since the last time we synced up with the charm store info for that resource | 19:53 |
katco | ericsnow: you got a pile of comments dumped on you. working through them? disagree? | 20:25 |
ericsnow | katco: working on it :) | 20:25 |
katco | ericsnow: kk | 20:25 |
ericsnow | katco: I'll let you know | 20:25 |
katco | ericsnow: natefinch: just keep in mind we have 4 points to complete next week to stay on track. i have 2 of those in-flight, but waiting to see how ericsnow's poller patch turns out | 20:26 |
katco | ericsnow: also, i think i'll need to ask you to migrate the state stuff since you're most familiar | 20:27 |
ericsnow | katco: k | 20:27 |
natefinch | katco: I think that other 2 pointer will be pretty quick. I think we're in good shape, but definitely if we can get ahead of the game and get more delivered than scheduled, we should try to do that. | 20:32 |
katco | natefinch: i agree on all counts | 20:33 |
ericsnow | katco, natefinch, rick_h_: doesn't there need to be a way to tell the controller to use a different charmstore revision of a resource? | 20:33 |
katco | ericsnow: what's the use case for that? | 20:34 |
natefinch | I thought it was juju upgrade-charm, to use the latest in the charmstore... | 20:34 |
katco | natefinch: ericsnow: ditto | 20:34 |
natefinch | I'm not sure the charmstore even exposes anything other than the current tuple | 20:35 |
katco | natefinch: well, i think we're defining that | 20:35 |
ericsnow | katco, natefinch: ah, the charm revision in the charm store isn't tied to a particular set of resource revisions | 20:35 |
ericsnow | katco, natefinch: but on the controller it is | 20:35 |
ericsnow | never mind then | 20:35 |
katco | ericsnow: i think we will be coupling those concepts in our new set of api endpoints | 20:36 |
ericsnow | katco: k | 20:36 |
katco | ericsnow: honestly, i probably need to spend next week digging into that | 20:36 |
ericsnow | urulama: ping | 20:41 |
ericsnow | urulama: we need to talk about resources in the charm store API (e.g. that charmrepo PR I put up) | 20:42 |
urulama | ericsnow: sure ... i've already pinged the team about that | 20:43 |
ericsnow | urulama: k | 20:43 |
urulama | ericsnow: sorry, but it's 10pm here and i really want to finish :) | 20:44 |
ericsnow | urulama: no worries :) | 20:44 |
urulama | ericsnow: so, talk to Francesco and Roger next week | 20:44 |
ericsnow | k | 20:44 |
mup | Bug #1547665 opened: juju 2.0 no longer supports KVM <juju-core:New> <https://launchpad.net/bugs/1547665> | 21:08 |
rick_h_ | ericsnow: katco natefinch yes, this is all tied to the charmstore apis and updates required there. | 21:29 |
katco | ericsnow: standup time | 21:32 |
perrito666 | seems that I drew the short straw for all neverending tests... | 21:55 |
perrito666 | meh, hangout died no me | 22:04 |
katco | perrito666: i think it kicked us all out | 22:04 |
perrito666 | oh I feel better now | 22:04 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!