dholbach | good morning | 07:45 |
---|---|---|
=== tsimonq2alt is now known as tsimonq2 | ||
dholbach | davidcalle, it drives me nuts - there's markdown with its way of thinking of what HTML should look like, there's beautifulsoup which we use to rewrite links and then there's the text-editor plugin which is what's beneath RawHTML, which also play around with the HTML | 14:50 |
dholbach | somehow I'm stuck between them :) | 14:50 |
dholbach | but I'll figure it out | 14:50 |
davidcalle | dholbach: can I help? | 15:30 |
dholbach | I think I'll try to solve this still today and if I don't fix it today, we can take a fresh look at it together on Monday? | 15:31 |
davidcalle | dholbach: ok. Do you see something odd with https://code.launchpad.net/~dholbach/developer-ubuntu-com/advertise-articles/+merge/286788 ? At the top of the diff, there is "Failed to fetch available diffs." and when I try to top-approve, it changes to "Approved", but stays orange and goes back to needs review when I refresh the page. | 15:40 |
dholbach | shall I commit an empty commit message to see if that 'fixes' LP? | 15:40 |
dholbach | I think there was an issue when I pushed the branch | 15:40 |
dholbach | something in LP | 15:40 |
davidcalle | dholbach: you can try that, yeah | 15:41 |
dholbach | done | 15:41 |
dholbach | looks better - let me know if it works for you now? | 15:42 |
davidcalle | dholbach: I can't even comment on it, the comment button turns red and I get and empty error message box. Can you add a comment to the mp? | 15:44 |
dholbach | yep | 15:44 |
davidcalle | Meh. | 15:44 |
dholbach | shall I try to top approve it? | 15:45 |
davidcalle | dholbach: worked from Chrome | 15:45 |
dholbach | bizarre | 15:46 |
davidcalle | Bad Firefox, bad! | 15:46 |
dholbach | davidcalle, do you think stripping any "aria-hidden=true" bits in <a> tags will hurt? >:-) | 16:55 |
dholbach | I don't know WTF they come from, what they're good for, but I think they're what's giving me headaches | 16:55 |
davidcalle | dholbach: apparently it "Indicates that this section of the document and its children are hidden from the rendered view." I don't think that applies to our use case, imho, you can ditch them :) | 16:57 |
dholbach | it's not all, apparently the elements with in the anchor are all moved around: | 16:59 |
dholbach | <h1 id="test"><a name="user-content-test" class="headeranchor-link" href="#test"><span class="headeranchor"></span></a>Test</h1> | 16:59 |
dholbach | I'm considering turning off the auto-header-anchoring :-P | 16:59 |
davidcalle | dholbach: any idea where this ^ mess comes from? | 17:00 |
davidcalle | Looks like wiki -> html | 17:01 |
davidcalle | Which is sad :p | 17:01 |
dholbach | I think it's one of the markdown extensions | 17:01 |
dholbach | I'll try to turn it off just to see if that helps ;-) | 17:01 |
dholbach | now there's still some rewriting going on, whenever we say plugin.body = html | 17:03 |
dholbach | I'll try to figure out what it is and how we can emulate it | 17:03 |
dholbach | I thought it was from djangocms_text_ckeditor.html import clean_html | 17:03 |
dholbach | I mean the clean_html function | 17:03 |
dholbach_ | looks like hexchat is not the cleverest in figuring out when disconnected :) | 17:13 |
dholbach_ | <dholbach> I think it's one of the markdown extensions | 17:13 |
dholbach_ | <dholbach> I'll try to turn it off just to see if that helps ;-) | 17:13 |
dholbach_ | <dholbach> now there's still some rewriting going on, whenever we say plugin.body = html | 17:13 |
dholbach_ | <dholbach> I'll try to figure out what it is and how we can emulate it | 17:13 |
dholbach_ | <dholbach> I thought it was from djangocms_text_ckeditor.html import clean_html | 17:13 |
dholbach_ | <dholbach> I mean the clean_html function | 17:13 |
dholbach_ | <dholbach> http://paste.ubuntu.com/15207399/ is where I am right now | 17:14 |
dholbach_ | <dholbach> I think I'll call it a day now | 17:14 |
dholbach_ | <dholbach> if you're very bored, give it a try, but it's probably better to call it a day and start enjoying the weekend :-) | 17:14 |
dholbach_ | davidcalle, ^ :) | 17:14 |
=== dholbach_ is now known as dholbach | ||
davidcalle | dholbach: will give it a shot this weekend, kids at their grandparents :) | 17:15 |
dholbach | have a great weekend davidcalle! | 17:16 |
davidcalle | dholbach: same :) | 17:16 |
dholbach | I'll do my best :-D | 17:16 |
=== mhall119_ is now known as mhall119 | ||
=== dpm is now known as dpm-afk | ||
=== tsimonq2alt is now known as tsimonq2 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!