/srv/irclogs.ubuntu.com/2016/03/01/#juju-dev.txt

davecheneysoftware http://paste.ubuntu.com/15248178/00:33
perrito666beautiful00:36
thumperdavecheney: ping00:43
thumperdavecheney: I have []someDocType, and a method Insert(docs ...interface{})00:43
thumperis there an easy way to squich the former into the latter?00:44
thumper cannot use docs (type []historicalStatusDoc) as type []interface {} in argument to statusHistory.Writeable().Insert00:44
thumpermenn0: ^^ any ideas?00:46
thumpernm00:47
thumperfound an easy soluntion00:47
menn0thumper: sorry i'm on my way out to run an errand00:50
thumperdon't worry00:50
thumperall sorted00:50
sinzuikatco: cherylj as a formality, can you approve we want to merge feature-resources into master http://reviews.vapour.ws/r/4007/00:50
thumper    c.Check(importedHistory[i].Since, gc.Equals, exportedHistory[i].Since)00:52
thumper... obtained *time.Time = &time.Time{sec:63592390248, nsec:901470923, loc:(*time.Location)(0x3fc4ec0)} ("2016-03-01 13:50:48.901470923 +1300 NZDT")00:52
thumper... expected *time.Time = &time.Time{sec:63592390248, nsec:901470923, loc:(*time.Location)(0x3fc4ec0)} ("2016-03-01 13:50:48.901470923 +1300 NZDT")00:52
thumperwho can spot the difference?00:52
thumperdeepequals necessary?00:53
thumperyep00:55
thumperneed jc.DeepEquals00:55
cheryljsinzui: shipit!00:59
sinzuithank you cherylj00:59
sinzuiouch cherylj I cannot merge, sorry katco, feature-resources now conflicts with master https://github.com/juju/juju/pull/456901:00
cherylj:(01:01
davecheneythumper: http://reviews.vapour.ws/r/4009/01:33
thumperdavecheney: shipit01:34
davecheneythumper: thanks01:34
thumpernp01:36
davecheneythumper: http://reviews.vapour.ws/r/4013/02:54
davecheneyanother one for you02:55
davecheneythumper: http://reviews.vapour.ws/r/4014/03:31
* thumper is out now04:12
thumperprobably back later tonight, because, you know, busy...04:12
davecheneyHey thumper, look what we get noe05:22
davecheneylocal error: bad record MAC05:22
davecheneygithub.com/juju/juju/state/open.go:208: cannot create index05:22
davecheneygithub.com/juju/juju/state/open.go:239:05:22
davecheneygithub.com/juju/juju/state/open.go:83:05:22
davecheneygithub.com/juju/juju/state/open.go:114:05:22
jammgz: bug 1549545 would be good to discuss when you're around09:26
mupBug #1549545: Bundle deploys fail at lxc-start when bridge br-eth1 is created <ci> <deploy> <maas-provider> <test-failure> <juju-core:Triaged by dimitern> <https://launchpad.net/bugs/1549545>09:26
=== akhavr1 is now known as akhavr
mgzjam, sure thing09:26
mgzjam: I thought from the previius chatter dimitern had a pretty good idea what was up09:29
mgz...what is that... 'previius'? jesu09:30
jamI think it is the Previous Prius09:30
jammgz: so, dimitern is working on making sure Juju 2.0 supports multiple nics, but since it doesn't yet, it seems that we shouldn't have the lab set up to require it.09:31
mgzehehe09:31
jamI thought bug #1549545 was preventing us from getting a blessed release09:31
mupBug #1549545: Bundle deploys fail at lxc-start when bridge br-eth1 is created <ci> <deploy> <maas-provider> <test-failure> <juju-core:Triaged by dimitern> <https://launchpad.net/bugs/1549545>09:31
jamand while it is a configuration we want to support, it wasn't supported in the past.09:31
jamOR did we actually break a mode that was working previously?09:32
mgzso, the reason we do is that it was a bug in 1.x to pick the wrong nic and fail, and the extra interfaces (and ordering of them) was to catch regressions to the handlign there09:32
jamso we did regress vs 1.x behavior09:32
mgzwe can release with the bug and put it in release notes, so it's not blocking as such09:33
jamwhere we only supported 1, but we detected which was the default gateway09:33
mgzjam: yeah, see the history of the maas-1_9-deployer job say, 1.25 passes09:33
jammgz: so in CI, is any particular job always run on the same hardware in the same configuration? and it is just the Juju version that is changing?09:34
mgzwe try to do that. there are obviously a few exceptions09:35
mgzmaas can randomly pick different things to deploy on. here we have to use different bundles due to the format change, but they are roughly equivalent09:36
mgzso, what we talked about yesterday in our standup,09:36
mgzwas making at least one of these deployer jobs have constraints so it only deploys on maas nodes with simple nic setup09:37
mgzso we don't lose all coverage of bundle deployment on maas due to this issue for now09:37
jamwell ultimately it would suck to not support more than one network card as we roll out our big "network model" release.09:37
jambut we may have to do that in the short term.09:38
jammgz: my concern is that we want to enable it as soon as we do have support09:39
jamadding workarounds tend to end up left there09:39
dimiternI'd appreciate a review on this really short and simple PR: http://reviews.vapour.ws/r/4019/09:41
dimiternmgz, hey, can we have a chat about that br-eth1 bug?09:41
mgzdimitern: see backscroll :)09:42
dimiternjam, exactly my point fwiw - too early to depend on br-eth1 will work09:43
jamdimitern: yeah, the shame is that "default-gateway" from 1.25 was sufficient for this, so we are regressing09:43
dimiternmgz, jam, there is a regression with 1.25 vs master with more than one container bridge, sure - but it's being worked on09:44
jamdimitern: what is "Empty" vs "IsNil" ?09:45
dimiternand since I'm practically the only one working on it, it will take a few days09:45
dimiternjam, well, I needed a schema.StringMap() that doesn't allow empty keys, and doesn't allow non-nil values as well.. so this came abotu09:46
jamdimitern: your coerce makes it look like the error you get is that if something isn't empty it tells you it is empty09:46
jamam I reading that correctly?09:47
perrito666morning09:48
dimiternjam, which test are you referring to?09:48
jammorning perrito66609:49
jamdimitern: I was just reading it wrong. Seems label is what goes in "expected".09:49
dimiternperrito666, morning fellow OCR ;)09:49
dimiternjam, ah, well - comments / suggestions are welcome :)09:50
jamdimitern: commented09:54
frobwaredimitern, mgz, jam: once possibility for the br-ethX bug is that we don't bridge all interfaces until we land dimiter's changes.09:59
* frobware continues that possibility in standup10:00
voidspacefrobware: dimitern: dooferlad: dealing with son - be a few minutes late to standup10:00
dimiternjam, thanks!10:01
dimiternjam, thanks for the review, replied to all issues10:27
dimiternfrobware, got latest master and did go instal ghc/j/j/... now waiting for make check to finish and will see how bad's the merge10:33
frobwaredimitern: any conflicts?10:35
dimiternperrito666, can you have a look at http://reviews.vapour.ws/r/4019/ while jam's back please?10:35
dimiternfrobware, will know in a few minutes, but a cursory diff against maas-spaces2 seems clean enough10:35
frobwaredimitern, voidspace: http://reviews.vapour.ws/r/4021/10:41
dimiternfrobware, looking10:41
dimiternfrobware, no conflicts btw \o/10:45
frobwaredimitern: great10:45
dimiternfrobware, as soon as make check is done I'm proposing it10:47
frobwaredimitern: thanks for the review10:49
dimiternfrobware, LGTM10:49
dimitern:)10:49
frobwaredimitern: I think we should take that into maas-spaces2, want to wait for it to merge in master?10:50
mgz$ ~/go/bin/juju version10:50
mgz2.0-beta2-vivid-armhf10:50
mgzwell, that was a pain10:51
dimiternfrobware, let's not merge it into maas-spaces2 yet I think10:51
frobwaredimitern: fair enough, but if xenial deployment is gating in CI then maas-spaces2 will fail.10:51
dimiternfrobware, that's ok for the time being I guess, if it's the only thing remaining even better :)10:52
perrito666dimitern: hey, just came to the computer, lemme see10:55
dimiternperrito666, tyvm! I've said I'll rename Empty to Nil, but haven't pushed that yet - will do in a few minutes10:56
* dimitern haven't seen 2 make check runs in a row to both succeed in quite some time now..10:58
=== rvba` is now known as rvba
dimiternvoidspace, frobware, here's the merge - since there were neither test failures nor conflicts, I vote to just $$merge$$ it11:00
dimiternhttps://github.com/juju/juju/pull/458311:01
frobwaredimitern: agreed.11:02
frobwaredimitern: go for the hat-trick :)11:03
* dimitern types $$merge$$ and hits comment11:03
voidspacecool11:03
dimitern:)11:03
perrito666dimitern: ship it11:03
jammgz: so what is going to be the best way to fix things for platforms I don't have (ppc, arm64, etc)11:04
* perrito666 tries to ingest some sort of caffeine11:04
dimiternperrito666, jam, cheers!11:04
mgzjam: ppc64 and arm64 is probably easiest using the machines CI has11:05
mgzthere are credentials for the stilsons and the new arm bits in cloud-city11:06
jammgz: so is that grabbing cloud-city and going to town? or what's the handshake around that?11:06
mgzand yeah, say on irc that you're using a machine for informational purposes11:07
mgzyou're unlikely to clash with active CI runs/the release process anyway11:08
mgzbut can ask if unsure11:08
frobwarejam: curious as to why you think we'd move to only bridging a single NIC as the default -- assuming I read that (email) correctly.11:19
dimiternperrito666, frobware, voidspace, jam, please have a look when you can at the next PR in line: https://github.com/juju/charm/pull/191 - extra-bindings in metadata11:41
jamfrobware: that we're moving to bridging *all* NICs as default11:41
jamwas what I was intending to say.11:42
jamfrobware: I thought that was what you were proposing as a "fix"11:42
jamwas it not?11:42
jamdimitern: the extra-bindings names should *not* be the same as peer relations11:43
jamwe went with option 111:43
jamwhich is all relations implicitly have bindings.11:43
dimiternjam, how about provides/requires ?11:44
jamdimitern: btw, my original confusion with "Empty" was because I thought it was a GoCheck Checker not a Schema one.11:44
jamdimitern: right all relations have a binding11:44
frobwarejam: my proposed fix was to bridge 1 nic (agreed). but the way I read your email implied that would be our ongoing fix. perhaps I just misinterpreted that.11:44
dimiternjam, I suspected as much :)11:45
jamif we went with plain "bindings" then it would be you could list matching ones, but since we are doing "extra-bindings" you really should only specify ones that aren't listed elsewhere, I think.11:45
dimiternjam, ah, got you11:45
jamfrobware: ah, it is "Reverting all" I missed the word reverting.11:45
jamfrobware: do we know why it breaks if all of the containers are bridged? That seems odd.11:46
jamis it that the containers don't get the right default gateways to match the host?11:46
dimiternjam, that makes sense, so the PR should include tests ensuring extra bindings names do not match relation names?11:46
jamdimitern: yes. I think it is a charm schema failure if you duplicate the names.11:46
frobwarejam: don't know. was trying to reproduce to understand and validate the proposal to revert to just one bridged nic.11:47
jamfrobware: sure11:48
dimiternjam, that wasn't clear to me from the spec, but now it is, thanks - will adapt the PR accordingly11:48
jammgz: just to confirm with you, is it ok if I create a development directory on stilson-05 to try to reproduce some of the test failures on ppc ?11:54
jamcherylj: I believe that tych0's patch does help with the CI regressions: github.com/juju/juju/pull/456411:57
jamI'm just hesitant to land it myself since I broke stuff the last time I did that.11:57
perrito666my first OCR day without coffee is hell12:07
dimiternjam, frobware, updated https://github.com/juju/charm/pull/191 as discussed earlier12:17
frobwaredimitern: any chance you could drop on to the standup HO?12:32
dimiternfrobware, yeah, omw in 2m12:33
jamperrito666: well clearly you should get coffee then13:07
=== akhavr1 is now known as akhavr
marcoceppicherylj katco are resources in beta1?13:21
mgzjam: sorry, was out for lunch, yeah, create a new dir in home, set GOPATH to it, is what I normally do, pull tarball from reports.vapour.ws as needed13:31
jammgz: it has limited network connectivity, right?13:31
mgzjam: it should be able to reach out to streams.canonical.com etc13:32
rick_h__marcoceppi: yes asked ger yesterday and it's there13:40
rick_h__marcoceppi: uogrwde i think will be in beta213:41
rick_h__upgrade that is13:41
marcoceppikk13:41
urulamaresources in local only, that is.13:42
rick_h__marcoceppi: we want to see if there's a good charm to enable resources in with beta2 and get a joint blog/email to the list between her folks and someone on your team marcoceppi13:42
rick_h__marcoceppi: not sure if any good targets are in flight13:43
rick_h__urulama: yes, local only atm13:43
marcoceppirick_h__: well I have a usecase for it for 2.013:43
marcoceppiand want to be able to test it out13:43
rick_h__marcoceppi: cool13:43
marcoceppilocal is fine13:43
rick_h__marcoceppi: i've asked them.to reach out to get a good real world.use case put together in the next couple of weeks so awesome13:44
marcoceppirick_h__: how about dtag, that a good enough use case ;)13:44
rick_h__marcoceppi: :)13:44
dimiternjam, frobware, voidspace, guys, sorry to be a pest, but I need to land this in order to continue with the last 2 remaining PRs for extra-bindings: https://github.com/juju/charm/pull/19113:49
frobwaredimitern: looking13:52
frobwaredimitern: is there a RB for this? I'm happy to comment in the PR, just asking as I didn't see one.13:53
=== Spads_ is now known as Spads
jamdimitern: responded13:54
jamfrobware: I thought the same, but it is vs "charm" not vs "juju" so no RB13:54
dimiternfrobware, no, it didn't create a RB diff for it again for some reason13:54
dimiternjam, thanks!13:55
frobwarejam: ah, was on autopilot. thx.13:56
mupBug #1551743 opened: juju <command> --format {yaml,json} should be more verbose <juju-core:New> <https://launchpad.net/bugs/1551743>13:56
frobwaredimitern: reviewed. only concerns are about the type assertions14:08
dimiternfrobware, I've updated the comment with my original reply to jam's question - does it make better sense now?14:09
dimiternfrobware, and thanks!14:09
frobwaredimitern: yep, comment helps. thx.14:12
=== akhavr1 is now known as akhavr
=== cmars` is now known as cmars
mupBug #1551779 opened: New azure provider ignores agent mirrors <azure-provider> <regression> <streams> <juju-core:Triaged> <https://launchpad.net/bugs/1551779>14:56
alexisbfrobware, I am on the hangout when you are ready15:32
frobwarealexisb: omw15:32
=== rcj` is now known as rcj
katcosinzui: fyi: https://github.com/juju/juju/pull/458516:03
katcosinzui: will we be able to merge after, or do we need another bless?16:04
sinzuikatco: I not certain, was the merge simple?16:06
katcosinzui: very. 1 line conflict16:06
katcosinzui: and it was very obvious that feature-resources should have had the preferred change16:06
sinzuikatco: great. let's merge once your feature branch is current16:07
katcosinzui: awesome, i'll let you know16:07
=== akhavr1 is now known as akhavr
natefinchgah, what the heck?  gopkg.in/juju/charmrepo.v1/csclient/params/params.go:37: undefined: charm.Reference16:28
ericsnownatefinch: don't you mean charmrepo.v2-unstable?16:29
natefinchericsnow: ahh.. that's probably goimports16:29
ericsnownatefinch: yeah, the default branch is v1...16:30
natefinchericsnow: thanks for catching that.. would have taken me forever to notice that16:30
ericsnownatefinch: I've got my mind on the charm store and the charm store on my mind16:30
katcoericsnow: lol16:31
natefinchman, we have way too many packages called "testing"16:31
ericsnownatefinch: I've starting switching to the XXXtest naming convention (a la the stdlib)16:32
katcowe really need a meta testing package to test for the number of testing packages present... like github.com/juju/juju/juju/testing/testing/tests_test.go16:32
natefinchlol16:32
ericsnowkatco: I wish!16:32
* natefinch shudders and adds code to export_test.go :/16:33
mupBug #1551842 opened: Juju 2.0 Trunk launches disconnected nodes <juju-core:New> <https://launchpad.net/bugs/1551842>16:39
cheryljhey frobware, are you going to backport a fix for bug 1550306 to 1.25?16:41
mupBug #1550306: 1.25.3 can't bootstrap xenial environments <landscape> <juju-core:Fix Committed by frobware> <juju-core 1.25:Triaged by frobware> <https://launchpad.net/bugs/1550306>16:42
voidspacedimitern: ping16:43
natefinchlol assertCharmsUplodaded16:44
dimiternvoidspace, pong16:44
voidspacedimitern: never mind, scratch that16:44
voidspacedimitern: following a different trail16:44
dimiternvoidspace, ok :)16:44
mupBug #1551842 changed: Juju 2.0 Trunk launches disconnected nodes <juju-core:New> <https://launchpad.net/bugs/1551842>16:45
katcosinzui: https://github.com/juju/juju/pull/4585 there are no conflicts with master now16:48
katcoericsnow: natefinch: merged master into feature-resources again. consider rebasing.16:49
sinzuithank you katco16:49
ericsnowkatco: thanks16:49
natefinchkatco: huzzah, thanks for that16:50
frobwarecherylj: yes, but was looking at a fix for bug #1549545 first16:52
mupBug #1549545: Bundle deploys fail at lxc-start when bridge br-eth1 is created <ci> <deploy> <maas-provider> <test-failure> <juju-core:Triaged by frobware> <https://launchpad.net/bugs/1549545>16:53
dimiternnatefinch, ericsnow, juju/charm.v6-unstable is broken since https://github.com/juju/charm/pull/189 due to not updating juju/utils deps I believe16:53
cheryljfrobware: is it an easy backport?16:53
frobwarecherylj: yes16:53
cheryljfrobware: I'll give it a try16:53
frobwareit's not a straight cherry pick16:54
ericsnowdimitern: k16:54
mupBug #1551842 opened: Juju 2.0 Trunk launches disconnected nodes <juju-core:New> <https://launchpad.net/bugs/1551842>16:54
katcosinzui: please lmk when we're merged into master16:55
frobwarecherylj: let me look at 1.25 - shouldn't take me too long.16:59
cheryljfrobware: is the problem specific to xenial on maas?17:00
frobwarecherylj: yes17:01
frobwarecherylj: backport done - needs follow-up live testing on precise, trusty, wily and xenial. bbiab.17:09
katconatefinch: how difficult are those tests turning out to be?17:13
natefinchkatco: blech.  I'm having to cargo cult a bunch of stuff from the deploy tests.  Those tests are internal and mine have to be external, due to circular imports, so I'm having to copy & paste a bunch (or edit hundreds of lines of test code to export the existing test infrastructure that was written non-exported).17:16
cheryljfrobware: I can help with testing17:16
natefinchkatco: that being said, I have the infrastructure working and can deploy starsay during tests with full charmstore support17:16
katconatefinch: well at least there's that :)17:17
natefinchkatco: so, the hard part is mostly done, now I just have to write the actual tests, which shouldn't be too bad17:17
katconatefinch: yippee :D17:17
mupBug #1551857 opened: juju 2.0 Beta1: ERROR zip: not a valid zip file while deploying invalid yaml bundle <oil> <juju-core:New> <https://launchpad.net/bugs/1551857>17:36
=== mpontillo_ is now known as mpontillo
natefinchug... the empty charmstore stuff is failing validation, so it kills my tests...feh.19:40
=== JoseeAntonioR is now known as jose
natefinchericsnow: booooooo... was looking for the resource persistence stuff... remembered it lives in juju/state now :/19:50
ericsnownatefinch: gee, thanks for reminding me :P19:51
natefinchericsnow: lol19:51
ericsnownatefinch: puzzling through the charmstore full-stack tests right now, so you got me at a cheerful moment <wink>19:52
natefinchericsnow: hmm... this produces zero-value resources: https://github.com/juju/juju/blob/master/state/resources_persistence.go#L8819:53
natefinchericsnow: (since there's no resources being returned from the store)19:53
natefinchericsnow: which results in empty resources being put in the CharmStoreResources, which fail validation19:53
ericsnownatefinch: ah, crappy19:54
ericsnownatefinch: I was going to fix that and forgot19:54
natefinchericsnow: this whole "write the client before the server exists" is kind of a giant PITA19:55
ericsnownatefinch: agreed19:55
ericsnownatefinch: as far as that bug goes, we need to be sure that we set the "store" resource at the same time we set the resource during deploy/upgrade-charm19:57
perrito666uff, I am tired of deprecating code19:57
natefinchericsnow: I was pretty sure we're doing that... sure seems like it, but maybe I'm missing something20:03
katcoericsnow: natefinch: are you 2 able to do the standup half an hour earlier? wallyworld and i have a conflict20:13
natefinchkatco: yep20:16
ericsnowkatco: fine with me20:17
katconatefinch: ericsnow: ta20:17
ericsnownatefinch, katco: I'm so glad I have to run an actual elasticsearch server in order to run the charm store test suites! :P20:18
wwitzel3lol20:18
katcoericsnow: ....... ...20:19
katcoericsnow: i don't know what to say to that. it's obvious to at least me that this is non-optimal20:19
natefinchlol20:20
ericsnowkatco: I'd better not say anything else20:20
natefinchobviously, elasticsearch has been finely tuned and optimized, so running any kind of a mock would be slower20:20
wwitzel3plus the format elasticsearch returns is just hard to mock20:21
katcowwitzel3: did you notice how we all just casually ignored you?20:21
wwitzel3pesky json20:21
natefinchkatco: so, just like old times? ;)20:22
katcozing!20:22
wwitzel3yeah, natefinch nailed it, how is that any different :P20:22
wwitzel3I have a NLP plugin for my client that detects when ericsnow is being sarcastic and automatically sends a lol20:23
perrito666it is different in the fact that wwitzel3 does not have to deal with these tests :p20:24
katcowwitzel3: lol20:24
natefinchMust have a bug, since we haven't been spammed by lols ;)20:24
ericsnowwwitzel3: you need to tune it because I've been a lot more sarcastic lately and haven't see your lol <wink>20:24
wwitzel3hah, well there is consensus on that at least :)20:25
katcowwitzel3: i have been seriously concerned with the dangerously low level of tattoos on our team since you left. i'm trying to convince ericsnow to get a python facial tatt.20:25
wwitzel3neck is better20:25
ericsnowkatco: forehead20:26
katcoericsnow: we can start calling you snake20:27
katcoericsnow: "snake, the gopher eater"20:27
natefinchreally, after eric shaved his head and got the eyebrow piercing, I think all bets are off20:27
natefinchkatco: these tests are going slower than expected... I think there's some bugs in the code that they're finding, but figuring out exactly where it is, is kinda slow going (since they're full stack tests.....)20:30
katconatefinch: want to hop in a hangout and pair?20:31
natefinchkatco: sure thing20:32
katconatefinch: i'm just in moonstone. putting some water to boil on20:32
katconatefinch: rather, water on to boil20:32
perrito666katco: clearly moonstone hangout has better features than tanzanite, ours is only good for chatting20:32
perrito666:p20:33
natefinchkatco: coming20:35
katcoericsnow: moonstone if you have a moment20:45
thumpermenn0: http://reviews.vapour.ws/r/4008/ updated20:57
thumpermenn0: also http://reviews.vapour.ws/r/4015/20:58
thumpermenn0: would also like to talk about this new package for managing migration, and where to put it and what to call it20:59
menn0thumper: will look first21:04
menn0at reviews21:04
menn0and then talk?21:04
thumpersur21:04
thumpere21:04
menn0thumper: ship it (with 2 non-issues) for http://reviews.vapour.ws/r/4008/21:13
thumpermenn0: cheers21:16
menn0thumper: ship it on the other one too21:29
mupBug #1551959 opened: juju-tools 1.25.0 with juju-agent 1.25.3 has networking issues <juju-core:New> <https://launchpad.net/bugs/1551959>21:42
=== natefinch is now known as natefinch-voting
mupBug #1465307 changed: 1.24.0: Lots of "agent is lost, sorry!" messages <landscape> <regression> <juju-core:New> <https://launchpad.net/bugs/1465307>22:06

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!