[00:00] ahayzen, u freaking genius! I finally got all clock AP tests passing... [00:00] * nik90 sighs a relief [00:00] nik90, OMG awesome man :-) [00:00] \o/ [00:01] nik90, is that on jenkins though ? :') [00:01] ahayzen, erm no..just locally..I still need to flake and pep8 tests [00:01] there was a command to check that? [00:01] ah cool, and if you have location allow/deny then... [00:01] pyflake if I remember [00:02] i usually use $ pep8 . and $ pyflakes . [00:02] but there is $ flake8 . [00:02] ok [00:02] as well [00:02] ahayzen, I am pretty sure we resolved the location issue at some point...let's see what happens. [00:02] nik90, if you need the py3 version do $ python3 -m flake8 . [00:02] need to clean up the AP test file now that everything is passing and propose MP [00:03] hmm not sure if we converted to python3 [00:03] nik90, i just wanna migrate as much as possible of ours to QUnit and then rewrite the test part of ours [00:04] ahayzen, so you're to use QUnit for both unit and feature testing? [00:04] or use both AP and QML tests? [00:04] nik90, it'll usually pass for py2 as well, just depends if you have some py3 specific syntax that fails in py2 :-) [00:04] nik90, QUnit for *as much as possible* :-) and then AP for probably more 'user stories' i would think [00:04] ahayzen, that's the way to go..keep user stories in AP if possible. [00:05] so really for us, we wouldn't remove many AP tests [00:05] but add loads of QUnit [00:05] however for weather... alot could be QUnit i think [00:05] here's thomi's post about test coverage, http://www.tech-foo.net/on-test-levels-and-coverage.html [00:05] + [00:06] ah cool thanks :-) [00:06] ahayzen, btw for weather, I migrated some of the pages to UC 1.3, thereby fixing the Silo 50 issues it had [00:06] still some work left for it. [00:06] nik90, awesome, i saw the MP, on my list to review :-) [00:07] ahayzen, btw how did you come to know about the trigger_leading_action() AP functions? Are there any docs on SDK helpers? [00:07] nik90, you talking of thomi reminded me, you ever seen his talk on Connascence ? https://www.youtube.com/watch?v=iwADIlIgDNA http://connascence.io/ [00:08] ahayzen, I haven't...will check it out [00:08] nik90, https://developer.ubuntu.com/api/autopilot/python/1.5.0/ubuntuuitoolkit/#ubuntuuitoolkit.UCListItem.trigger_trailing_action [00:08] the SDK helpers from the docs :-) [00:09] cool thnx [00:10] AP is much easier now with all the helpers :-) === _salem is now known as salem_ [00:54] ahayzen, Do you happen to know how to use the SDK helpers for the new PageHeader? With UC 1.3 every page can potentially create its own PageHeader which is what we did with clock app. I am having trouble getting a reference to that PageHeader. [00:54] I have a class for say WorldCityPage(Page) [00:54] in that how do I grab its PageHeader? [00:55] I can no longer do self.main_view.get_header() because it is not mainview's header. [00:55] looking at autopilot3 vis, I only see "PageHeader" objects and not AppHeader which is referenced in the SDK Helper docs [00:55] i haven't tried it yet, still trying to get the PageHeader to act how i want :') [00:56] but i guess do a select_single of the header then apply as normal...but maybe not [00:56] hmmm [00:56] nik90, maybe talk to Tim, he may know if there are helpers [00:56] nik90, otherwise, put objectName's on things and then see if it can find them [00:56] will ask him tomorrow [00:57] well for now I did just used UCAbstractButton to click the header buttons [00:57] but I wanted to try the SDK helpers for this. [00:57] nik90, i'll be interested in the response, so could you relay to me if you find out :-) [00:57] ah cool [00:57] :) === salem_ is now known as _salem === BOHverkill_ is now known as BOHverkill === _stowa_ is now known as _stowa === ondra_ is now known as ondra === popey_ is now known as popey === marcusto_ is now known as marcustomlinson [10:10] JMulholland, ping [10:44] faenil, I tried cpulimit -l 1 qmlscene, however I am unable to link the c++ libraries that clock needs so it just fails there [10:44] nik90: more details [10:44] that said that listview has atmost 4 items..should it really slow down on a less performant hardware ;) ? [10:45] usually I run clock app as, qmlscene app/ubuntu-clock-app.qml -I builddir/backend/ [10:45] however when I do cpulimit -l 1 qmlscene, it allow me to only choose the qml file and not the backend [10:46] if it's asking for the qml file then it means it's not receiving the parameters [10:47] I couldn't pass the qmlfile and backend as arguments in the cpulimit command. [10:47] it only allow passing the processid, path to executable etc. [10:47] I don't have a clock-app executable to run [10:48] nik90: are you sure the path to the qml is correct? it works fine here [10:49] nik90: otherwise, just try "cpulimit -l 1 -- " [10:49] ah you added "--" [10:49] * nik90 tried [10:49] * nik90 tries* [10:50] ok that works === lool- is now known as lool [10:50] :) good [10:54] nik90: more on the "--" here, if you're interested http://www.cyberciti.biz/faq/what-does-double-dash-mean-in-ssh-command/ [10:55] faenil, With 1% CPU, the listitem expands, the height slowly increases to match the required height [10:55] Did you notice it failing to bind at 1% CPU? [10:55] nik90: I didn't test your branch, I just reviewed the code and suggested to check places where it could fail :) [10:55] as in never able to reproduce the scenario where the listview has loaded, but the height is not set to its requirements. [10:56] Ok, I will then comment on the MP [10:56] my worry was more about expansion.height changes not being reflected in the actualy ListItem logic, but it seems it's working as it should. I just wanted you to doublecheck ;) [10:57] instead of suggesting something that would have broken on phones :D [10:57] :) === _salem is now known as salem_ === jdstrand_ is now known as jdstrand === beuno_ is now known as beuni === beuni is now known as beuno [16:28] popey, are you able to build the calendar app from the SDK? [16:28] dunno, I am on 14.04 so the sdk is dead to me [16:28] I realize it is just qml, but opening the cmakelists file doesn't get me a project I can do anything with [16:29] I only ever build using click-buddy [16:56] jdstrand, popey just asked me to review com.ubuntu.clock_3.7.456_armhf.click and I'm seeing http://paste.ubuntu.com/15274605/ [16:56] popey, clock moved from multi to armhf? [16:56] yes [16:56] so that's intentional? [16:56] yes [16:57] ok [16:57] Sorry, should I have warned someone? I apologise. [16:57] jdstrand, can you maybe help popey with this review as I'm not quite sure how to respond [16:57] Didn't think it would impact anything [16:57] and I need to run in a few [16:57] popey, so it was armhf+amd64 before? [16:57] all 3 [16:57] (not sure if we have amd64 users of clock already) [16:58] hmm [16:58] jdstrand, the click-review explodes in the same way for the current version in the store as well [16:59] all rightie... I need to run - see you all tomorrow! [17:00] sorry popey for not being more helpful [17:00] no prolemo! [17:00] THanks! [17:00] hugs! [17:03] balloons, hey, yes I can open calendar-app on 14.04 in qtc using cmakelist.txt [17:07] popey, can you push clock app to the store when're you free (added bonus of screenshots if possible) [17:08] nik90: i have already, but it's failing click-review, dholbach asked jdstrand to look at it [17:09] balloons, I got a gift for you..fixed all clock app AP tests to PASS. Also added 3 stopwatch tests..and in the process of adding 3-4 settings tests. [17:09] popey, ah ok. [17:09] \o/ [17:09] nik90, you did? Awesome! Did you make a helper for the bottomedge? [17:09] nik90, are the new tests AP or qml? [17:10] balloons, no, I saw that bottomedge hint turned out in autopilot vis as a nice rectangle that you can swipe up, so it was easy to reuse code where possible. [17:10] balloons, AP [17:11] I was in the process of fixing the AP tests in trunk, when everything just clicked and went well..so added few additional tests [17:11] all feature tests [17:11] balloons, does jenkins run the clock-app AP tests? [17:11] gotcha. [17:12] nik90, see https://wiki.ubuntu.com/Touch/CoreApps/Jenkins#Workflow [17:12] rev. 3 or so. We're now working on running post merge, but on every merge [17:13] I think this may end up as the final state [17:13] hmm so it runs the AP test post-merge. Where do I see the test-results? [17:14] Does it post it in the MP still? [17:14] I haven't created the jobs yet. No it doesn't post to the MP the results of AP anymore. I've removed the AP job calls from all the ci jobs. [17:14] ok [17:15] if you need to see the results for your branch, we can just kick off a job [17:15] https://core-apps-jenkins.ubuntu.com/view/Release/job/release-build-test/ [17:15] yup was just looking at it. [17:15] that will get you a build and AP test run you can look at [17:16] let me try it myself and see if I get it right [17:16] indeed, go for it [17:18] job #91 kicked off.. [17:23] balloons, hmm #91 didnt run AP tests..do I have to explicitly ensure that the job name ends with "run-ap-tests-*" to ensure it runs AP? [17:23] it commented in the MP as expected. [17:33] nik90, what do you mean? [17:33] this? https://core-apps-jenkins.ubuntu.com/job/clock-app-ci/91/ [17:33] yes, notice the downstream projects doesn't include the run-ap-tests job anymore :-) [17:33] build with this: https://core-apps-jenkins.ubuntu.com/view/Release/job/release-build-test/ [17:34] it's generic for any branch [17:34] it won't leave a comment on the mp, and you'll have to view the job yourself [17:37] nik90, so it's running now: https://core-apps-jenkins.ubuntu.com/view/Release/job/run-ap-tests-release/7/console [17:37] balloons, erm I started #5 for that [17:38] it is your run.. I didn't start it [17:38] balloons, that said, how do I get to the release-build-test page from core-app-jenkins.com? [17:38] https://core-apps-jenkins.ubuntu.com/view/Release/ [17:39] I guess we can point anyone at the job, unless you'd like something else to build your branches more easily [17:40] the only annoying bit is having to have two jobs to do a run, because we can't build the clicks on the device [17:40] from https://core-apps-jenkins.ubuntu.com/view/Release/ what do I click? I tried the sidebar links like "New Item" [17:41] nik90, ohh.. You click release-build-test, then 'build with parameters' [17:41] ah found it [17:41] thnx [17:42] sounds like building this is not as easy as I thought [17:42] so feel free to give comments on what you'd like to see and we can discuss, then document [17:44] nik90, if you want to re-test now, assuming you don't change the app itself, you can simply rebuild https://core-apps-jenkins.ubuntu.com/view/Release/job/run-ap-tests-release/7/ [17:44] does that make sense? [17:44] aka, commit changes, push them to your branch, re-run [17:44] yup makes sense [17:45] already notice it failing on krillin...bah :/ [18:00] balloons, just checkout the autopilot.subunit file with trv, 5 out of 8 tests are failing. The alarm tests are failing because the keyboard doesn't popup. Surely that's a system-bug? [18:01] nik90, it is [18:01] i don't know the bug offhand sadly [18:01] but it [18:01] it's filed [18:01] it says KeyboardContainer.activeKeypadState failed:'Shifted' != dbus.String('Normal', variant_level=1) [18:01] ok [18:02] balloons, well the tests pass locally for me...no flaky ones. [18:02] so I'm happy with that. [18:02] I will run my own AP tests when I review other people's branches to ensure this doesn't fail. === e is now known as Guest99940 [18:11] hi. first attempt to create a scope by following the tutorial. when i run it I get an error saying "This application failed to start because it could not find or load the Qt platform plugin "xcb". Reinstalling the application may fix this problem. The program has unexpectedly finished. /usr/ubuntu-sdk-ide/share/qtcreator/ubuntu/scripts/qtc_desktop_scoperunner.py crashed" [18:12] how do i add xcb? [18:15] sudo apt-get install xcb says it is already installed [18:19] Guest99940: running it with unity-scope-tool? [18:20] hmm, not sure. i clcked the green play button in qt creator [18:21] i am totally new to this so i may be missing something very obvious. [18:28] @dobey no i am not running unity-scope-tool. [18:29] its working now. [18:30] ok [18:30] i dont know if it was connected but a software update 7MB was waiting. updated it. restarted qt creator. it works [18:30] not sure what i did though. anyway. thanks. [19:28] I'm having trouble identifying the correct policy_groups for my webapp. It should allow WebRTC in oxide, so audio and video (i.e. camera access). [19:33] According to [1] it should be "camera", but `click-review` complains. [19:33] [1] https://developer.ubuntu.com/en/start/platform/guides/app-confinement/#Usage-1 [21:04] popey: fyi, com.ubuntu.clock_3.7.456_armhf.click review looks fine [21:05] popey: as in no tracebacks [21:05] hm [21:05] locally? [21:05] popey: both review tools 0.38 and trunk are working correctly. I think maybe the store was in a bad spot-- it just got updated a few hours ago [21:06] jdstrand: would you mind reviewing it in the store so I can publish it please? [21:06] popey: yes, locally, but the store looks fine too: https://myapps.developer.ubuntu.com/dev/click-apps/121/rev/37/ [21:06] ah i see [21:07] popey: has this always used the calendar? [21:09] it looks like it [21:09] * jdstrand approves [21:11] yes [21:11] thanks [21:11] I'm having problems with policy_groups with a web app I'm trying to submit. I can't take the click-review on my local machine as a reference, because it complained on version 0.1 of my package while this passed the review online. [21:13] ahayzen, did you by chance happen to move the Slider{} in your music=app AP tests? [21:13] nik90, hmm, we definitely used to [21:13] just a simple calc on the width then click at that x,y [21:13] I need additional policy_groups for the web app in order to allow access to the camera and microphone. I added that according to [1], but unfortunately the review failed after submission of version 0.2 [2]. [21:14] [1] https://developer.ubuntu.com/en/start/platform/guides/app-confinement/#Usage-1 [21:14] [2] https://myapps.developer.ubuntu.com/dev/click-apps/4646/rev/2/ [21:14] but now IIRC we just do something like .position.wait_for(5000) or something [21:14] however i think we even managed to remove those [21:14] ahayzen, yup makes sense [21:14] nik90, but doing a click is pretty simple if that is what you need [21:15] The failing review points are: [21:15] "found unusual policy groups: connectivity, camera, microphone security_policy_groups_webapp (appear-in.apparmor)" [21:15] just get the vertical centre, and then calc the x position [21:15] ahayzen, well even I do the click, I wouldn't be to verify that the alarm volume is a certain value. [21:16] maybe this is a better candidate for QML tests [21:16] nik90, you'd be able to verify the slider was correct...and the backend that that is setting is of the correct value [21:16] yeah, i was about to say that ;-) [21:16] ;) [21:18] nik90: clock published [21:19] popey, woohoo..thnx [21:19] Ooh! Need new screenshots! [21:19] wow clock only 456 kb... [21:20] thats the bzr rev :) [21:21] spooky [21:21] haha [21:53] Anyone know more about the policy_groups? The latest policy_version is 1.3, correct? [21:53] peter-bittner, yes 1.3 is latest [21:54] And the policy_groups listed on [1] are the ones matching version 1.3? [21:54] [1] https://developer.ubuntu.com/en/start/platform/guides/app-confinement/#Usage-1 [21:57] If yes, why is the review of my app failing with "found unusual policy groups: connectivity, camera, microphone security_policy_groups_webapp (appear-in.apparmor)"? [21:59] peter-bittner, I am not familiar with the last policy group (webapp) since I only work on native apps. [21:59] Perhaps it is best to look at an existing web-app to see how they do things [22:00] search https://uappexplorer.com/ for good webapps and look at their source code. Most are open-source [22:00] I have a bunch of web apps, but it's the first time I need to access camera and microphone (because oxide didn't support it half a year ago). [22:03] Can't wait to be told this is a restriction of web apps. As designed in 2014. *nirg* :-/ === salem_ is now known as _salem [22:05] peter-bittner: please submit it. it will trigger a manual review and I'll get pinged. I'll talk to the oxide devs about it. they are offline now [22:06] Done. It's submitted. https://myapps.developer.ubuntu.com/dev/click-apps/4646/rev/2/ [22:07] jdstrand: Do you have access to my app review / submission= [22:07] ? [22:07] yes [22:08] I've added it to me todo to talk to them tomorrow [22:08] It was "automatically rejected". [22:08] Thank you. [22:08] peter-bittner: can you click the 'request manual review' button? [22:09] Done. Now the red button is gone. [22:10] jdstrand. Do you happen to know whether it's possible to control which camera is used by the web app (by default)? [22:10] peter-bittner: I don't. oSoMoN might [22:11] he is one of the people that are eod that I was going to talk to though [22:11] oSoMoN = ? [22:11] Ah, okay. [22:12] I'm asking because in the web app there will be no way to access the browser settings menu. Only there you can switch between the rear and the front camera.