[00:33] robert_ancell: still there? You should maybe subscribe to appstream@lists.freedesktop.org - hughsie recently proposed his JSON protocol for ratings & reviews for inclusion into the standard, and I would like to have some feedback from other SC implementors [00:34] technically, you're "just" using GNOME Software, but especially since Ubuntu has it's own Ratings & Reviews, I would welcome feedback on this [00:35] I don't want to favor just one distro or add things to the spec which will only be used by very few people (with the rest using alternative implementations) [00:59] ximion, I will take a look [01:11] reminds me, does Laney know that the AppStream mailinglist exists? [01:11] * ximion missed the opportunity to make some noise about it in the AppStream release notes [01:11] anyway, need sleep, gn8 === maclin1 is now known as maclin === meetingology` is now known as meetingology === larsu_ is now known as larsu === sarnold_ is now known as sarnold [05:30] hello === popey_ is now known as popey [09:04] sup [09:04] Laney: tried to drink orange juice, but the straw had a hole [09:05] good morning desktopers! [09:05] plug it with your finger! [09:05] hey larsu Laney [09:05] * larsu contends that he has the most interesting story of the morning [09:05] Laney: got a new one ;) [09:05] bonjour seb128! [09:06] hey seb128 [09:06] ooh the new paint for the wall ↑ came this morning [09:06] that's an interesting story [09:07] check it out [09:07] hm, true [09:07] maybe we should put it up to a vote [09:07] I wonder if meetingology can conduct votes? [09:07] Laney, does tha mean you have to paint the wall! [09:07] darkxst: our friend is starting a business doing painting :P [09:08] we are some of the first customers! [09:08] Laney, so you are the guinea pig :) [09:10] Laney: nice color! [09:11] not as bright in place unfortunately, the wall it's going on doesn't get direct light ;_; [09:12] is that official Ubuntu orange? ;-) [09:12] Laney is a true believer in the brand [09:12] Good morning everyone ! [09:12] new official orange or old official orange? [09:12] :@ [09:13] depend of your screen and color profile :p [09:13] we have melting snow this morning, I wonder if that's enough of a story to compete with the orange juice and paintain [09:13] ing [09:14] depends. how fast is it melting? [09:14] seb128, it would melt way faster here ;) [09:15] larsu, now it's turning on "melting before reaching the ground" [09:16] but earlier it was sticking a bit on the ground [09:16] we would need a few °C less :/ [09:16] wow... this story is suspenseful! I don't think the paint can compete with that [09:16] :-) [09:19] * Laney mutters [09:19] i'll get you next time [09:19] * darkxst trained the chickens to train the dogs, not to eat them! how it that for a story ;0 [09:20] you... [09:20] can train chickens? [09:20] chickens can eat dogs? [09:20] so many questions [09:20] apparently and no, dogs eat chickens or ours would! [09:22] muktupavels: so... https://code.launchpad.net/~albertsmuktupavels/compiz/gwd-marco-gsettings-v2/+merge/287836 is replacing the old branch from ~ubuntu-mate-dev? [09:24] hey Trevinho, how are your holidays going? [09:25] seb128: good, but working today :) [09:26] seb128: snow was awesome two days ago... I really enjoyed skiing [09:27] nice [09:27] Trevinho, ok, the "week summary" email said your were off on thursday/friday [09:28] seb128: yeah, I changed, since weather isn't great today, so I prefer to work [09:28] k, makes sense [09:28] it's good that we have flexibility like that ;-) [09:28] Yeah... Like a dream :) [09:28] Also today there was the meeting with kylin, so I preferred to stay. [09:32] k [09:32] * seb128 doesn't know what to do with that GtkPlacesSidebar ABI change in gtk 3.18 and old nautilus [09:33] that's annoying [09:33] * seb128 wants snaps to be able to bundle an old gtk :p [09:34] seb128, you could port the 3.18 sidebar widget to old nautilus, or you just don't like the new one? [09:34] I'm leaning toward copying the widget from gtk 3.16 in nautilus [09:34] but I then need to copy gtkbookmarks&trash as well [09:35] I can't easily do that no [09:35] Laney: did you see the upstream changes related to https://bugs.launchpad.net/ubuntu/+source/pkg-config/+bug/1523508 ? [09:35] Launchpad bug 1523508 in pkg-config (Ubuntu) "Building xorg-gtest fails with new pkg-config" [High,Triaged] [09:35] Laney: not sure it's the case to backport the changes... [09:35] the issue is that sidebar changes to be menu based to handle popovers [09:35] but the new api is based on gactions [09:36] converting nautilus 3.14 is too much work [09:37] and 3.18 nautilus is too unstable? [09:38] it certainly has its issues, but 3.18.5 seems better [09:38] seb128: infinity is out so the xserver is still not copied to xenial.. should I just reupload it all so that they'll get rebuilt in -proposed instead? [09:38] Trevinho: can't we take 0.29.1? [09:38] Trevinho: can you test that commit? [09:39] Laney: we could take 0.29.1 yes... [09:39] Laney: as for compiz side, we handle both cases now, so... It just doesn't matter [09:39] still would be good to know if it fixes the original problem [09:39] but, to avoid other unknown breakages around, I'd go with the old-fashioned way of handling vars [09:40] Laney: ok, yes [09:40] I can do that [09:40] darkxst, we had it and reverted, the zoom levels limitation and some other things make it risky user reception for the lts [09:41] tjaalton, hey, sorry I didn't follow ... what's the issue? are you blocked on copy and by what? [09:41] seb128, yes I am aware it was reverted [09:41] Laney: however it seems quite likely, since it's a revert... [09:42] seb128, zoom levels don't seem hard to fix, but what else is causing problems? [09:42] seb128: the xserver transition, I've been waiting for someone to copy the binaries but infinity is out [09:42] tjaalton, you don't have upload rights for it? [09:42] I do, but before they've been just copied from the staging ppa [09:43] well if you can upload you can copy [09:43] how? [09:43] I don't understand why you need somebody [09:43] using copy-package [09:43] never knew that [09:43] Trevinho: sounds like a revert + looking for quotes, so should be safe but still good to confirm - thanks! [09:44] nice that he fixed it [09:44] ok I have the archive-tools handy.. will give it a go then :) [09:44] great, let me know if you need help [09:45] tjaalton, should be something around the line of [09:45] ./copy-package --ppa=canonical-x --ppa-name=x-staging -s xenial --to-primary --to-suite xenial-proposed [09:48] yep, seems to work [09:49] darkxst, there is a summary of the reasons in [09:49] https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1541954 [09:49] Launchpad bug 1541954 in nautilus (Ubuntu) "Revert to the previous nautilus version" [High,Fix released] [09:49] tjaalton, sorry, I though that you know that whoever can upload can also copy [09:49] knew [09:49] I didn't really understand why you were holding, I would have told you earlier :-/ [09:51] heh, no worries [09:51] realized that mlankhorst couldn't copy, not all of these anyway [09:52] Candidate copy target: https://api.launchpad.net/devel/ubuntu/+archive/primary [09:52] looks right? [09:53] where do you see that? [09:53] seb128, its a balancing act, carlos has been pretty good backporting fixes to the 3.18 branch [09:53] I'm unsure to understand the question [09:53] Copy candidates: xorg-server 2:1.18.1-1ubuntu3 in xenial [09:53] Candidate copy target: https://api.launchpad.net/devel/ubuntu/+archive/primary [09:54] but some things like zoom arent consider a problem upstream [09:54] Trevinho, only if you are ok with removing tests. why they are not enabled when building debian packages? [09:55] darkxst: did you see https://csorianognome.wordpress.com/2016/02/24/nautilus-3-20-last-change-zooms/ ? [09:55] seb128, why is it so hard to add the menu bar back? [09:55] darkxst, they are, it's being worked on on e.g https://git.gnome.org/browse/nautilus/log/?h=wip/cosimoc/zoom-levels-v2 and csoriano said he's probably going to need to distro patch something there for the next RHEL update as well [09:56] no I hadnt seen that [09:57] tjaalton, looks fine to me, I didn't use it for a while but if you did "--to-primary --to-suite xenial-proposed" it should be right [09:57] most people can't upload to the release pocket directly anyway [09:57] so it'll fail [09:58] Laney, but tjaalton can uploaded xorg so it should work no? [09:58] but why wouldnt you cherry-pick improvement rather than revert [09:58] seb128: yeah I mean the maximum harm of getting it wrong isn't very high [09:58] darkxst, because at the time we reverted the improvements were still not done and judged difficult to do [09:58] Laney, right [09:58] unless you're in the release team in which case it gets accepted into xenial-release [09:58] darkxst, also that is one of the points [09:58] and then you get killed [09:59] haha [10:00] ok, all copied [10:01] oh hell [10:01] tjaalton, ? [10:01] guess I get to do a bunch of rebuilds [10:02] I thought this would copy the binaries too [10:02] arg [10:02] sorry my fault, you need "-b" for that :-/ [10:02] yeah missed that from the help [10:03] seb128, I dont rrally have time for what if's, but I do have maybe a week before I am back at full-time work [10:07] but still I have largely no idea whats needs to be done... [10:08] and yes apparently I can't type while watching TV [10:48] since I'm not doing a very good job of being off sick I might as well log in === lool- is now known as lool [10:50] seb128: is there a way to artificially keep a package in proposed? [10:57] hmm I guess xserver will remain there until rdeps have been rebuilt [10:58] which is good [11:01] hey willcooke [11:01] ello [11:01] are you contagious? [11:02] I think so [11:02] I've put a face mask over my ethernet port [11:02] * Laney backs off [11:02] willcooke: confirmed you modem bug [11:02] thx davmor2 [11:02] spoke to cyphermox last night, he's going to see what he can do for NM upgrade [11:03] davmor2, if you manually run usb_modeswitch does it "fix" it? [11:03] willcooke: will try that now [11:05] meh that'll be why I have modemmanger removed to be able to flash phones D'oh let me do a fresh install on some hardware and reconfirm [11:05] ah ha [11:06] willcooke: infact I can run it from a live session that will be quicker still [11:12] willcooke: so for me in live session I get Mobile Broadband not enabled [11:13] dont follow you [11:13] is that good or bad? [11:13] willcooke: so it looks like the switch is happening but not connection is made [11:14] davmor2, oh. But it detects the modem ok? [11:15] willcooke: well debatable I'll wait for awe and cyphermox to get online and have a debug session from live session then hopefully we can whittle it down a bit for them [11:15] davmor2, nice one, cheers matey [11:27] willcooke: bugger looks like it is biting us in 14.04.4 too [11:27] davmor2, erk [11:28] willcooke: there though I get no connection at all so is likely to be the usb mode switch [11:29] * davmor2 is so glad to have all this spare hardware just lying around honest [11:30] oh and it's a contract sim so not like it is out of credit either and if I test it in my mifi device is just connects so definitely and issue. [11:31] davmor2, in fairness, I dont have a SIM in mine, but the HW should still show up (and indeed does when I run usb_modeswitch manually) [11:31] word up [11:31] hihi desrt [11:38] morning, willcooke [11:41] "motning" [11:41] *morning [11:42] willcooke: not sure what to do abouth this card: https://trello.com/c/GiWywEtG/1-work-out-what-to-do-about-desktop-files [11:42] marco's was handling the bamf/unity part [11:42] *marco was [11:42] * andyrock is still sleeping [11:42] :D === olli_ is now known as olli === alan_g is now known as alan_g|lunch [13:20] pitti: Do you have time to look at bug #1510198 (FFe)? There are still a few pending details, but it would be good to have a decision regards the FFe before spending more time on it. [13:20] bug 1510198 in openoffice.org-hyphenation (Ubuntu) "[FFe] Sync (almost) with libreoffice-dictionaries in Debian sid" [Medium,Confirmed] https://launchpad.net/bugs/1510198 [13:21] Laney: thanks for the update on the seed. two things though ... [13:23] Laney: 1/ libreoffice-style-human and libreoffice-style-breeze are now _both_ on the image, I dunno why -human is still around. at least in the ubuntu-meta_1349.tar.xz, there is no reference to it. [13:24] Laney: 2/ the dir in the ubuntu-meta tarball is named ...-1.350 which seems to be off for a 1.349 release === hikiko is now known as hikiko|ln [13:25] ahh, the answer to 1/ is simple 5.1.1~rc2 is still in -proposed and 5.1.0-0ubuntu1 still deps somehow on -human, I guess. [13:25] * Sweet5hark1 checks [13:26] Also the migration happened after today's image [13:26] 2> dpkg-source doesn't care about the first component [13:27] I ran ./update twice and it renamed the directory the second time [13:27] then I manually changed it back [13:27] but that didn't rename it back :-o [13:27] use dget :-) [13:28] Laney: I just looked into it on launchpad, so np, just noticed it to be odd. [13:30] nod, good observation! [13:30] hmmm, libreoffice-gtk 5.1.0 already recommends -breeze. so I wonder what pulls in -human still. [13:30] the old seed [13:30] Laney: ah, doh. [13:31] http://people.canonical.com/~ubuntu-archive/germinate-output/ubuntu-touch.xenial/rdepends/libreoffice/libreoffice-style-human [13:31] and we got breeze like this http://people.canonical.com/~ubuntu-archive/germinate-output/ubuntu-touch.xenial/rdepends/libreoffice/libreoffice-style-breeze [13:31] s/-touch// [13:32] doesn't matter in that case :P [13:57] thanks cyphermox :) [13:57] good morning [13:58] aannd yet another more releasish libreoffice-snap build ... failing after 50 minutes on big bertha ... [13:59] Sweet5hark1, https://www.youtube.com/watch?v=coZfzTcv4bA === hikiko|ln is now known as hikiko [14:01] willcooke: oh thats a lot more cute than the stuff that resulted in that machine having the name bertha (https://en.wikipedia.org/wiki/Big_Bertha_%28howitzer%29) [14:01] :D === jdstrand_ is now known as jdstrand === Pici` is now known as Pici [14:44] Laney: so I've been able to generate: https://wiki.ubuntu.com/mhall119/AppStreamTest [14:44] it's a big list, but ranked by popcon installs [14:46] * mhall119 is surprised by how many xpm's are still in use [15:10] GunnarHj, Sweet5hark1: from an FF point of view, bug 1510198 seems fine to me [15:10] bug 1510198 in openoffice.org-hyphenation (Ubuntu) "[FFe] Sync (almost) with libreoffice-dictionaries in Debian sid" [Medium,Confirmed] https://launchpad.net/bugs/1510198 [15:12] pitti: oh, yeah, that one. Im in a call right now, will look afterwards. IIRC it wasnt hugely problematic when I last looked. [15:13] pitti: Thanks! Can you please make a note about it on the bug report. [15:15] Sweet5hark1: Great if you don't have any big doubts. There are still some pending details to deal with. I'm about to upload a new set of proposals to a PPA. [15:18] GunnarHj: I did already [15:18] pitti: Have seen it now. Thanks again! [15:39] mhall119: cool! [15:40] how are you planning to run this? [15:46] Laney: I will write a blog post detailing the need and the steps to contribute an icon (including working with upstream), then point to a wiki page with that list for people to choose from [15:46] Laney: how often does the AppStream data on http://appstream.ubuntu.com/hints/xenial/main/ get updated? [15:46] hourly [15:46] oh, wow [15:47] well, I might re-generate the list on a daily basis for a while [15:47] or just have people manually update it when they submit [15:47] you might want a link to search for already filed bugs [15:47] willcooke: I got NM to build (minus a lot of patches), so I'll get back to it in a few hours, see if I can quickly get nm-applet together [15:47] Launchpad should do that for us [15:48] mmm [15:48] Laney: since I'm pre-populating the bug title with the "Submit" link, it will match if somebody clicks it a second time [15:48] that won't stop someone from creating a duplicate, but it should at least warn them [15:48] ok, then people should be told to file a bug when they start work [15:49] sounds reasonable [15:49] I can add a "claim" column to the page where people can also indicate that they've started on one [15:50] that or the bug assignee, don't know what is easier [15:50] * Laney had already started to finish banshee, better delete that [15:50] oh, wiki is 500ing, cool [15:50] cyphermox, thanks!! [15:50] yeah, keep trying, it 500's about half the time [15:52] meh [15:52] it means I can't log in [15:59] Laney: re g-s, is it expected for it to leave packages behind that need apt-get autoremove ? [16:02] flocculant: I don't know, I'm not really working on the client side [16:02] what does software-center do? [16:02] leaves configs [16:03] Laney: best to talk to robert ancell later? [16:03] flocculant: yeah or report a bug [16:04] Laney: I'll talk to him - don't want to report something not a bug ... [16:04] if it is then I will :) [16:05] it's easy to close them [16:07] I guess [16:07] well, up to you, either works [16:07] :) [16:11] flocculant, g-s is not a system upgrader, why would it clean up things? [16:12] when removing [16:14] seb128: it installed something - I'd expect it to clean up after itself :) [16:14] it's a complex problem [16:15] you install firefox which brings gtk2 [16:15] then you install inkscape [16:15] then you remove firefox [16:15] apt wouldn't mark it as autoremovable then [16:15] gtk2 is not linked to firefox which installed it anymore [16:15] if you had some local gtk2 program though [16:16] right, I'm just saying that autoremove is different from "that comes from that program" [16:16] imho those cleanup jobs are still better handled by the upgrader component [16:16] g-s only knows about desktop components [16:17] seb128: so not a bug as such? [16:17] well I guess it's valid to discuss [16:17] I think it's debatable [16:18] if one component is doing it then it cannot be more harmful for another one to also [16:18] seb128 Laney - ok I'll report it then [16:18] thanks [16:18] but not really up to me :) [16:18] do we know how other distros/upstream g-s handle that? [16:19] also you said that software-center was "leaving configs" [16:19] but does it autoremove? [16:19] seb128: yea - or did with the experiment I did [16:21] I'll add as much info as I can to bug anyway [16:21] thanks [16:24] * flocculant makes alias for ubuntu-bug gnome-software ... [16:27] lol [16:32] bug 1552792 for better or worse :) [16:32] bug 1552792 in gnome-software (Ubuntu) "gnome software leaves dependencies installed" [Undecided,New] https://launchpad.net/bugs/1552792 === alan_g|lunch is now known as alan_g [16:50] snappy build still running, now at ~9GB ... [16:53] Sweet5hark1: erk [16:53] that's 7 times bigger than an entire ubuntu desktop iso which *contains* LibO [16:53] whats 9GB compared to the size of the universe though [16:54] 1/5? [16:54] ogra_: wait until his build finishes :) [16:54] * ogra_ is happy that we aim for embedded devices with snappy now ... [16:54] pitti: nono no panic, thats the size of the workdir, not the final snap. this is expected to be bigger than the snap will be in the end. [16:54] the ones with a 5TB disk :P [16:55] ogra_: you don't have a 16TB SD card in your raspi yet? [16:55] pitti, waiting for mediamarkt to seel them for 9,90 [16:55] * Sweet5hark1 uses df -h as a progress bar :/ [16:55] *sell [16:55] * pitti ^5s ogra_ [16:55] :D [16:55] Sweet5hark1: hah, nice; what's 100%? [16:56] lBuild Architecture: amd64 [16:56] Build-Space: 13169060 [16:56] Build-Time: 22424 [16:56] Distribution: xenial-proposed [16:56] I wonder what unit that is [16:57] I suppose kB or KiB, as it's certainly not B :) [16:57] 13 GB sounds plausible [16:57] man, you and your universe-heating packages :) [16:57] yep. but that is without l10n, I assume? [16:58] yeah, I just looked at libo amd64 xenial's build log [16:58] pitti: lets just say I am generous with distributing entrophy .... [16:59] -h [17:02] meh -- build looks odd though: 100% make, no childs and no output :/ [17:10] seb128: it's ok to install debs in GS using aptdaemon, right? [17:11] attente, yes [17:11] isn't that what we use as a backend atm? [17:11] seb128: i wasn't sure because i didn't see aptdaemon in the GS depends [17:14] seb128: it doesn't look like it from what i can tell [17:14] attente, it should probably be a depends, debian/patches/apt-plugin.patch uses it [17:15] aptd_transaction() [17:15] + result = g_dbus_connection_call_sync (conn, [17:15] + "org.debian.apt", [17:15] + "/org/debian/apt", [17:15] hrm... interesting. i'm not sure which branch that comes from [17:15] https://git.gnome.org/browse/gnome-software/log/?h=wip/rancell/apt [17:15] I would say [17:15] ah. ok. i didn't see that [17:15] thanks [17:15] yw [18:05] seb128: sorry - got waylaid - gs/synaptic screeny added now [18:08] flocculant, thanks [18:31] * Laney woofs goodnight [18:33] woot, new gst landing [18:33] Laney, enjoy your evening! [18:33] stir fry night [18:33] gimme a helllllllllll yeah [18:33] you too! bye! [18:39] stir fry, yummy! :-) [18:39] * seb128 goes for dinner as well [18:51] seb128: added a new screeny after starting a vm and installing the same package in synaptic and gnome software at the same time [18:51] flocculant, thanks [18:52] seb128: sorry if I'm getting boring about this stuff - but I'm trying to test it to distraction for xubuntu ;) [18:52] flocculant, no, don't worry, it's useful feedback, please keep playing with it and reporting issues! [18:53] :) [18:53] I shall ofc [19:29] Laney: when working on the new data generator, I realized that some parts of the current one are a bit more complex than they need to be... [19:29] unfortunately the icon finder can't be simplified further :( [19:29] * ximion will fetch food, then review all outstanding PRs [20:44] attente, I've removed all the non-review related changes in wip/rancell/reviews and put them in wip/ubuntu-changes [20:45] robert_ancell: ok, thanks. sorry i wasn't sure if you wanted me to force push those removals or not... [20:45] git revert it fine [20:47] robert_ancell: i'm trying to get the deb sideloading to work, but for whatever reason GS refreshes to an empty page after installation [20:47] attente, we don't currently reload the apt/dpkg information - could that be the issue? [20:47] wondering if you have any ideas why it might be doing that... [20:49] robert_ancell: it could be, there might be some disparity between the gsapp we generate for the deb and what's added to the db [20:50] robert_ancell, hey [20:50] seb128, hello [20:51] robert_ancell, attente, should we make g-s refresh its index on start? [20:51] seb128, it loads the index on start, but it never reloads it. I was going to add a file watch on the files and reload when they change [20:51] seb128: i guess we have to refresh the index after the deb is installed [20:52] G-S asks for new information after an install. I originally had it loading the index every time, but that seems inefficient [20:52] robert_ancell, does it? it doesn't indicate it's doing so and it's not obvious... [20:53] seb128, after you install an app, G-S asks for the list of installed apps [20:53] g-s seems to lack feedback on when it's doing things/waiting [20:53] same if the apt lock is taken by another process [20:54] it acts like if it was doing work === shiznix_ is now known as shiznix [20:54] seb128, there is an issue with the theming where the loading bar is not shown [20:56] yeah, I saw that one. but even if the bar was loading, if something else is having a lock on apt you can wait for ever [20:56] seb128, yes, but there's nothing we can really do about that... [20:56] That's just apt being a bit shitty [20:58] software-center/update-manager handle that better, they tell you they are waiting because something has a lock on the db [20:59] so it's doable [20:59] but it might be hackish, no idea [20:59] how does s-c detect the lock? [20:59] attente, aptd gives status information, it's probably in there [21:00] seb128, file a bug for a label as to why it's waiting! [21:00] via the dbus interface? [21:00] attente, yeah [21:00] I should do that ;-) [21:00] attente, see transaction_property_changed [21:00] attente, see transaction_property_changed_cb rather [21:01] attente, your new gs_plugin_filename_to_app doesn't check if the number of tokens from the strsplit is what you expect... [21:02] and your g_spawn_sync can return FALSE but doesn't set error... [21:03] robert_ancell: yeah, i got a bit sidetracked with getting the app page to refresh properly.. [21:03] thanks for catching those [21:05] desrt, has anyone ever proposed a g_strv_new, i.e. gchar **argv = g_strv_new ("foo", "--bar", "3", NULL); [21:06] I feel like I'm writing that sort of code all the time [21:06] a common trick is to use split [21:06] desrt, yeah, but that doesn't work well if the contents are variables [21:07] indeed [21:07] ie.. gchar **argv = g_strv_new ("foo", "--bar", some_user_value, NULL) [21:07] why aren't you using gsubprocess? :) [21:07] desrt, is it worth proposing or is it the dreaded glib feature creep? [21:07] I'm super glad g_strv_contains exists now [21:08] Was sick of writing that over and over... [21:08] ya.. me too [21:08] robert_ancell, is bug #1552074 one of the issues you fixed? the git commit have no bug reference/bt so not easy to say [21:08] bug 1552074 in gnome-software (Ubuntu) "gnome-software crashed with SIGSEGV in gtk_stack_set_visible_child_name()" [Medium,Confirmed] https://launchpad.net/bugs/1552074 [21:08] seb128, I'm looking at that now, not fixed AFAIK [21:08] k [21:08] seriously, though [21:08] GSubprocess? [21:09] desrt, sure, in that case, but there are others. [21:09] People end up using GPtrArray instead, which is a bit heavy === thumper is now known as thumper-afk [21:10] or strv = g_new(char*, 4); strv[0] = ...; etc. [21:10] which is kinda reasonable imho [21:10] yes [21:10] but g_strv_new() is also kinda reasonable [21:10] well, I'd say it's leess than ideal [21:10] i'd be happy to review a patch [21:10] ok [21:10] but it's too late for this cycle [21:10] that's fine [21:11] it's not urgent, but it makes GLib easier to use [21:11] imho it's not really great for this case [21:11] since it will necessarily dup the input strings [21:11] but meh [21:11] hint: try to copy the valist to avoid doing multiple allocations [21:11] ie: va_copy [21:13] i guess you could do some speculation and alloca() as well [21:13] robert_ancell, https://bugs.launchpad.net/ubuntu/+source/gnome-software/+bug/1552918 seems to be something quite some users hit [21:13] Launchpad bug 1552918 in gnome-software (Ubuntu) "/usr/bin/gnome-software:11:g_menu_model_get_n_items:gtk_application_window_update_shell_shows_app_menu:gtk_application_window_real_realize:_g_closure_invoke_va:g_signal_emit_valist" [Undecided,New] [21:13] but in terms of how it will end up looking in assembly, the copy is definitely cleanest [21:15] (and just to avoid roundtrips, don't forget): docs section addition, sentinal attribute [21:15] you'll probably also get tripped up on the missing version macros. feel free to submit a patch to add those =) [21:16] desrt, missing version macros? [21:16] i.e. defines for the latest version? [21:17] yes [21:17] since you're writing the patch against the not-yet-existent series-to-come... [21:22] is that the LIM/headerbar bug? [21:35] seb128: btw, I found out why PK was percieved as slow: When it was tested initially, Ubuntu didn't have AppStream metadata, and in that case GS emits FindFiles() calls to PK, which cause a search for which pkg provides a specific filename - and those searches are super slow, even when using APT directly. [21:36] with AppStream metadata present, GS has all the package information and only rarely needs to resolve a filename to a package. For packages, it will only emit a Resolve() call, and resolve calls are really cheap [21:39] ximion, hey, k, so maybe that's a non issue then [21:39] seb128: I ran into this myself yesterday on a Debian machine which had broken metadata [21:39] was an enlightening experience on that matter === marga- is now known as marga [21:44] ximion, what's the status of the appstream-glib issue/screenshots? seems like the bug is without activity since december :-/ [21:44] seb128: hughsie won't implement it, so someone else would need to do it [21:45] what's the difference which makes it work on fedora? [21:45] I wanted to quickly submit a match, but making this work requires passing around the media_baseurl parameter down to the parsing functions, which is a more invasive change [21:45] so I wanted to have hughsie take a look at it first [21:46] seb128: fedora is using the XML data, which doesn't know MediaBaseUrl and just duplicated the full url for every screenshot [21:47] libappstream implements the DEP-11 spec correctly, so the only SC which is currently affected by this bug is GNOME Software (and potentially other stuff using libappstream-glib, but the only bug report I got was from GS so far) [21:49] seb128: btw, technically implementing MediaBaseUrl isn't hard [21:49] the "Origin" field in AppStream metadata works the same way [21:50] I don't understand those details enough to get a clear idea of what's going on exactly [21:50] but we need to get that fixed this cycle one way or another [21:50] what do you recommend doing? [21:51] is that something robert_ancell_ or attente or Laney are looking at? [21:51] seb128, I'm aware of it, was hoping Laney was looking at it [21:51] seb128: definitely fix appstream-glib to follow the spec ;-) [21:52] that works if something is assigned/going to do it [21:52] ximion, is there a bug with the information? We can carry a patch in Ubuntu if necessary [21:52] which doesn't seem the case atm [21:52] theoretically we could make the generator thow out some different version of the data, but that would have some annoying issues on the server side, e.g. we couldn't easily change the url of the screenshots and icons anymore [21:52] could we just do whatever fedora is doing? [21:52] * ximion doesn't like that [21:53] robert_ancell_: no, the data is fine - just https://github.com/hughsie/appstream-glib/issues/70 needs to be fixed [21:54] ximion, ok, so it just needs someone to write the patch and convince hugshie this is the right thing to do? [21:55] spec here: https://www.freedesktop.org/software/appstream/docs/sect-AppStream-DEP11.html#spec-dep11-general [21:55] robert_ancell_: jup - while convincing hughsie would not be hard :) [21:55] (I hope ^^) [21:55] ximion, oh regarding reviews in appstream. That doesn't make sense to me either - they seem too dynamic to be mixed in.. [21:55] And there could be many thousands of reviews [21:56] robert_ancell_: jup, I don't want that - but specifying the protocol to get them in AppStream is something I would like [21:56] jup, I am not sure if I misunderstood hughsie there [21:56] ximion, that makes sense I guess [21:57] we already have services in the spec: https://www.freedesktop.org/software/appstream/docs/chap-AppStream-Services.html [21:57] because before hughsie introduced metainfo / appdata files, it was thought that every distro would simply implement the Debian screenshot server API [21:57] and OpenSUSE even did that :) [21:58] now, the screenshot service is only a fallback [22:00] robert_ancell_: on the generator side, having MediaBaseUrl allows us to store the pre-generated metadata in a database and easily change the location of the screenshots server without regenerating all metadata or parsing all YAML and string-replacing the old url with the new one when altering it [22:01] yeah, that makes sense if you want to mirror it I guess? [22:01] also, this could later be used by distributions to have multiple mirrors for screenshots, or add a mirror pattern [22:02] some people expressed interest in this, because not everyone has a powerful server or redirect service running for this [22:02] jup, exactly [22:03] desrt, could you have a quick look at https://errors.ubuntu.com/problem/23ba6db9a4c30881ade44cef107a6dd5d76a41ef. Essentially, inside GApplication a GTK settings callback is trying to access app_menu_section, which is NULL even though it shoul be defined for the lifetime of the application. [22:04] Was wondering if perhaps the callback has been called after dispose() somehow [22:04] GtkApplication rather === thumper-afk is now known as thumper [22:11] sounds likely [22:22] robert_ancell_: the app_menu_section here is an attribute of the window itself -- not the app [22:23] it is created in _init() of the window and freed in dispose [22:23] aha [22:23] so this looks like someone is trying to realize a window after it has already been disposed [22:24] via gtk_widget_show [22:25] bug is in whatever defines gs_application_activate() i'd say [22:26] i'm guessing it holds a ref on the window so that it can show it again, but it doesn't prevent the window from being destroyed on delete