| === maclin1 is now known as maclin | ||
| hikiko | hello | 08:21 |
|---|---|---|
| Trevinho | Hi handsome_feng | 08:27 |
| handsome_feng | hi | 08:29 |
| hikiko | hi Trevinho handsome_feng | 08:30 |
| Trevinho | hey hikiko | 08:30 |
| handsome_feng | It seems a long time from last meeting | 08:31 |
| handsome_feng | :) | 08:31 |
| Trevinho | handsome_feng: yeah, sorry about that... It happened twice that I had no notifications for the meeting and I missed it. It looks like my calendar wasn't properly synced | 08:33 |
| ypwong | hi there | 08:34 |
| Trevinho | hi ypwong | 08:35 |
| Trevinho | handsome_feng: however... It's great that we got the ACK for getting all your work upstream for 16.04... | 08:35 |
| handsome_feng | It does't matter, just repair your calendar ,and don't miss the next one. :) | 08:35 |
| Trevinho | handsome_feng: I've been looking at your code in the past weeks, but I need to finish a proper review. | 08:35 |
| handsome_feng | fine | 08:36 |
| Trevinho | handsome_feng: last time I checked there was still that issue for the tooltip / quicklist anchors that aren't properly centered | 08:36 |
| Trevinho | I could have a look to that as well | 08:36 |
| handsome_feng | I think i fix that now | 08:36 |
| Trevinho | https://www.irccloud.com/pastebin/LokuJYEU/ | 08:37 |
| Trevinho | err | 08:37 |
| Trevinho | <handsome_feng> I found a litter problem in tooltips recently, when switch from one icon to another, the background of the new tooltip will keep the previous one's shadow...can you have a look at this btw when review the branch ? | 08:37 |
| handsome_feng | yes | 08:37 |
| handsome_feng | I still have this problem... | 08:37 |
| handsome_feng | It | 08:38 |
| Trevinho | I can check that | 08:38 |
| handsome_feng | Ok, thank you ! | 08:40 |
| Trevinho | handsome_feng: as for the dash thing, once the dash is moved to the bottom, I think we need to disable the panel switching mode... As now the panel has only to be blurred when the dash is maximized | 08:41 |
| Trevinho | Anyway, I'll do a proper review in next days, I think next week since tomorrow I'm off | 08:41 |
| handsome_feng | ok, I will modified it... Is there a deadline for the merge ? | 08:44 |
| Trevinho | handsome_feng: well, the sooner the better | 08:45 |
| Trevinho | handsome_feng: we need to preapare an FFe bug for that, maybe ypwong can help with it? | 08:45 |
| ypwong | Trevinho, yes i can help | 08:45 |
| Trevinho | nice | 08:46 |
| handsome_feng | Thank you, ypwong ! | 08:46 |
| Trevinho | handsome_feng: however, the thing is we're already in feature freeze, so let's try to get the main thing in in two weeks window. Then you can fix and shape it in the coming weeks till the final freeze, since bug fixes are allowed | 08:47 |
| handsome_feng | Trevinho, so you will review the branch before you leave? | 08:48 |
| Trevinho | handsome_feng: leave for what? I'm off tomorrow, but next week I'm here again | 08:49 |
| Trevinho | handsome_feng: about this, I don't see why this should fix the issue... I mean, what is it doing differently? | 08:50 |
| Trevinho | http://bazaar.launchpad.net/~feng-kylin/unity/unityshell-rotated-kylin/revision/4023 | 08:50 |
| handsome_feng | without this, when changed the scale in display, the launcher position will be at wrong place | 08:51 |
| Trevinho | handsome_feng: yeah, I read the commit, but I don't see why... MHmhm | 08:52 |
| Trevinho | I mean, positioning should all be done in OnMonitorChanged, which is called anyway | 08:52 |
| handsome_feng | the launcherHeight get wrong value in OnMonitorChanged | 08:53 |
| handsome_feng | launcherSize | 08:53 |
| Trevinho | Mh, | 08:53 |
| Trevinho | Is that maybe a race or what? | 08:54 |
| Trevinho | I think we should try to understand what's going on... Not because your change is bad, but it looks like that there's something going on somewhere else that is not working as it should | 08:54 |
| Trevinho | so it could be the effect of something not working properly. | 08:55 |
| handsome_feng | Ok, I will Investigate this | 08:56 |
| Trevinho | it's just a minor thing, eh.. .But... | 08:56 |
| handsome_feng | I tried to find out why, but inconclusive :( | 08:59 |
| Trevinho | handsome_feng: I understand.. | 09:02 |
| Trevinho | handsome_feng: however, I was quickly looking at the code and I think we've the most on place now | 09:06 |
| Trevinho | handsome_feng: as for the dash branch, have you given a check to the AP tests? | 09:06 |
| handsome_feng | not yet ... | 09:06 |
| handsome_feng | er, just forgot that, I will do that ASAP | 09:09 |
| Trevinho | handsome_feng: ok, thanks | 09:09 |
| Trevinho | handsome_feng: so, I think we can wrap this up.. I'm happy we can continue in this path. I'll do the reviews in next days, and I'll give you some branches in case. | 09:14 |
| handsome_feng | OK, Thank you ! | 09:14 |
| handsome_feng | bye ! Trevinho, hikiko, ypwong | 09:15 |
| Trevinho | bye handsome_feng, have a nice evening! | 09:15 |
| hikiko | bye handsome_feng :) | 09:16 |
| === hikiko is now known as hikiko|ln | ||
| === hikiko|ln is now known as hikiko | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!